Hi Yunfei and Xiaoyong,
W dniu 16.05.2024 o 14:21, Yunfei Dong pisze:
From: Xiaoyong Lu
Change av1 driver to support secure video playback(svp) for
mt8188. Need to map shared memory with optee interface and
wait interrupt in optee-os.
Signed-off-by: Xiaoyong Lu
Signed-off-by: Yunfei Dong
--
Hi,
I'm having second thoughts, please see inline,
W dniu 22.05.2024 o 14:26, Andrzej Pietrasiewicz pisze:
Hi Yunfei,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order to
support one plane memory. The buffer size is luma + c
Hi Yunfei,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order to
support one plane memory. The buffer size is luma + chroma, luma is
stored at the start and chrome is stored at the end.
Signed-off-by: Yunfei Dong
---
Documentation/
Hi Yunfei,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Need to call dma heap interface to allocate/free secure memory when playing
secure video.
Signed-off-by: Yunfei Dong
---
.../media/platform/mediatek/vcodec/Kconfig| 1 +
.../mediatek/vcodec/common/mtk_vcodec_util.c | 122 ++
Hi Yunfei & Jeffrey,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
From: Jeffrey Kardatzke
Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED.
Why not in the patch where the flag is actually being added?
From that commit until this commit it would be undocumented.
While at it...
Signed-o
Hi Yunfei,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Allocate two share memory for each lat and core hardware used to share
information with optee-os. Msg buffer used to send ipi command and get ack
command with optee-os, data buffer used to store vsi information which
used for hardware deco
Hi Yunfei & Jeffrey,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Setting msg and vsi information to shared buffer, then call tee invoke
function to send it to optee-os.
Signed-off-by: Yunfei Dong
---
.../vcodec/decoder/mtk_vcodec_dec_optee.c | 140 ++
.../vcodec/decode
Hi Yunfei & Jeffrey,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
Open tee context to initialize the environment in order to communication
with optee-os, then open tee session as the communication pipeline for
lat and core to send data for hardware decode.
Signed-off-by: Yunfei Dong
---
...
Hi Yunfei & Jeffrey,
W dniu 16.05.2024 o 14:20, Yunfei Dong pisze:
From: Jeffrey Kardatzke
Validates the restricted memory flags when setting up a queue and
ensures the queue has the proper capability.
Signed-off-by: Jeffrey Kardatzke
Signed-off-by: Yunfei Dong
---
.../media/common/videob
Hi Paul,
W dniu 22.03.2023 o 10:21, Paul Cercueil pisze:
Hi,
This small patchset adds three new IOCTLs that can be used to attach,
detach, or transfer from/to a DMABUF object.
Changes since v1:
- patch [2/3] is new. I had to reuse a piece of code that was already
duplicated in the driver, s
quest_setup() is called in mtk_vdec_worker which is
before this function.
great
Thanks
Best Regards
xiaoyong Lu
Please avoid top-posting. It is easier for your reviewer to read your answers
inline. And, actually, it is easier for you not having to find the relevant
fragments, copy and then pas
Hi again,
W dniu 17.11.2022 o 13:42, Andrzej Pietrasiewicz pisze:
Hi Xiaoyong Lu,
Sorry about chiming in only at v6. Please see inline below.
Andrzej
W dniu 17.11.2022 o 07:17, Xiaoyong Lu pisze:
Add mediatek av1 decoder linux driver which use the stateless API in
MT8195.
Signed-off-by
Hi,
Did you receive my comments for v6?
Regards,
Andrzej
W dniu 17.11.2022 o 10:43, Xiaoyong Lu pisze:
Add mediatek av1 decoder linux driver which use the stateless API in
MT8195.
Signed-off-by: Xiaoyong Lu
---
Changes from v6:
- change slot_id type from u8 to s8
- test by av1 fluster, resu
Hi Xiaoyong Lu,
Sorry about chiming in only at v6. Please see inline below.
Andrzej
W dniu 17.11.2022 o 07:17, Xiaoyong Lu pisze:
Add mediatek av1 decoder linux driver which use the stateless API in
MT8195.
Signed-off-by: Xiaoyong Lu
---
Changes from v5:
- change av1 PROFILE and LEVEL cfg
-
ns that were swapped in commit 7707f7227f09. I reviewed them to
the best of my ability according to the RK3399 TRM and fixed them up.
This fixes IOMMU issues (and display errors) when testing with BG24
color formats.
Fixes: 7707f7227f09 ("drm/rockchip: Add support for afbc")
Cc: Andrzej
Hi,
W dniu 13.10.2021 o 03:08, yunfei.d...@mediatek.com pisze:
Hi Andrzej,
On Tue, 2021-10-12 at 16:27 +0200, Andrzej Pietrasiewicz wrote:
Hi Yunfei Dong,
W dniu 11.10.2021 o 09:02, Yunfei Dong pisze:
This series adds support for multi hardware decode into mtk-vcodec,
by first
adding use
Hi Yunfei Dong,
W dniu 11.10.2021 o 09:02, Yunfei Dong pisze:
This series adds support for multi hardware decode into mtk-vcodec, by first
adding use of_platform_populate to manage each hardware information: interrupt,
clock, register bases and power. Secondly add core thread to deal with core
h
Hi,
W dniu 02.10.2020 o 16:02, Greg Kroah-Hartman pisze:
On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote:
Hi,
W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze:
On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote:
Userland might want to execute e.g
Hi,
W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze:
On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote:
Userland might want to execute e.g. 'w' (show blocked tasks), followed
by 's' (sync), followed by 1000 ms delay and then followed by 'c
W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze:
W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze:
On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote:
This is a follow-up of this thread:
https://www.spinics.net/lists/linux-input/msg68446.html
lore.kernel.org is
W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze:
On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote:
This is a follow-up of this thread:
https://www.spinics.net/lists/linux-input/msg68446.html
lore.kernel.org is easier to pull stuff from :)
Anyway, what ever happened
-SysRq-.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/admin-guide/sysrq.rst | 2 ++
drivers/gpu/drm/drm_fb_helper.c | 2 +-
drivers/tty/sysrq.c | 49 +++--
3 files changed, 50 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin
encoding it (Jiri Slaby)
- updated help message of sysrq_drm_fb_helper_restore_op (Jiri Slaby)
- used unsigned int for specifying delays (Jiri Slaby)
- improved printed messages formatting (Jiri Slaby)
Andrzej Pietrasiewicz (2):
tty/sysrq: Extend the sysrq_key_table to cover capital letters
tty/sys
of that many milliseconds, e.g.:
ws:1000c
or
r:100eis:1000ub
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/admin-guide/sysrq.rst | 9
drivers/tty/sysrq.c | 82 -
include/linux/sysrq.h | 1 +
3 files changed, 91 insertions(+
of that many milliseconds, e.g.:
ws:1000c
or
r:100eis:1000ub
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/admin-guide/sysrq.rst | 9
drivers/tty/sysrq.c | 82 -
include/linux/sysrq.h | 1 +
3 files changed, 91 insertions(+
-SysRq-.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/admin-guide/sysrq.rst | 2 ++
drivers/gpu/drm/drm_fb_helper.c | 2 +-
drivers/tty/sysrq.c | 49 +++--
3 files changed, 50 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin
i Slaby)
- used unsigned int for specifying delays (Jiri Slaby)
- improved printed messages formatting (Jiri Slaby)
Andrzej Pietrasiewicz (2):
tty/sysrq: Extend the sysrq_key_table to cover capital letters
tty/sysrq: Add configurable handler to execute a compound action
Documentatio
W dniu 15.04.2020 o 20:33, Daniel Vetter pisze:
On Wed, Apr 15, 2020 at 7:19 PM Andrzej Pietrasiewicz
wrote:
drm_gem_fb_init() is passed the fb and never allocates it, so it should be
not the one freeing it. As it is now the second call to kfree() is possible
with the same fb. Coverity
llow drivers allocate a subclass of struct
drm_framebuffer")
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
b/drivers/gpu/drm/drm_gem
Use drm_dbg_kms() instead of DRM_DEBUG_KMS.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
b/drivers/gpu/drm
This short series addresses the way bpp value is made available
for drm_gem_afbc_min_size(). It can be inferred from the format
if a driver hasn't set anything in cpp[0] (patch 2/2).
While at it, use proper debugging macro (patch 1/2).
Andrzej Pietrasiewicz (2):
drm/core: Use proper debu
Some drivers (komeda, malidp) don't set anything in cpp. If that is the
case the right value can be inferred from the format. Then the "bpp" member
can be eliminated from struct drm_afbc_framebuffer.
Signed-off-by: Andrzej Pietrasiewicz
---
Documentation/gpu/todo.rst
Hi Daniel,
W dniu 30.03.2020 o 19:01, Daniel Vetter pisze:
On Wed, Mar 11, 2020 at 3:55 PM Andrzej Pietrasiewicz
wrote:
The new struct contains afbc-specific data.
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 439656f55c5d..37a3a023c114 100644
--- a
height' not
described in 'drm_afbc_framebuffer'
Trivial spelling mistakes.
Signed-off-by: Sam Ravnborg
Fixes: 55f7f72753ab ("drm/core: Add drm_afbc_framebuffer and a corresponding
helper")
Cc: Andrzej Pietrasiewicz
Cc: Emil Velikov
Cc: James Qian Wang
Cc: Daniel Vetter
Cc
Hi Sandy,
W dniu 19.03.2020 o 03:57, Sandy Huang pisze:
Hi Emil,
--
2.17.1
Heiko, Sandy, being the maintainers of the Rockchip driver, can you
review/ack this patch?
I believe the intention is to merge the series via drm-misc. Andrzej
already has commit access.
-Emil
Thanks for you p
This patch adds support for afbc handling. afbc is a compressed format
which reduces the necessary memory bandwidth.
Co-developed-by: Mark Yao
Signed-off-by: Mark Yao
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip
Use available afbc helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 44 +++-
1 file changed, 4 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index b9715b19af94
Prepare for using generic afbc helpers.
Use an existing helper which allows allocating a struct drm_framebuffer
in the driver.
afbc-specific checks should go after drm_gem_fb_init_with_funcs().
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 50
Consolidating framebuffer creation into one function will make it easier
to transition to generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 157 +--
1 file changed, 66 insertions(+), 91 deletions(-)
diff --git a
truct drm_framebuffer, exactly
the way the new version of drm_gem_fb_create_with_funcs() does.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 87 ++--
include/drm/drm_gem_framebuffer_helper.h | 5 ++
2 files changed, 67 insertions(+), 25 dele
The new struct contains afbc-specific data.
The new function can be used by drivers which support afbc to complete
the preparation of struct drm_afbc_framebuffer. It must be called after
allocating the said struct and calling drm_gem_fb_init_with_funcs().
Signed-off-by: Andrzej Pietrasiewicz
dressed comments from Daniel Stone, Ayan Halder, Mihail Atanassov
- coding style fixes
Andrzej Pietrasiewicz (6):
drm/core: Allow drivers allocate a subclass of struct drm_framebuffer
drm/core: Add drm_afbc_framebuffer and a corresponding helper
drm/arm/malidp: Factor-in framebuffer creation
dr
This patch adds support for afbc handling. afbc is a compressed format
which reduces the necessary memory bandwidth.
Co-developed-by: Mark Yao
Signed-off-by: Mark Yao
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
drivers/gpu/drm/rockchip
Prepare for using generic afbc helpers.
Use an existing helper which allows allocating a struct drm_framebuffer
in the driver.
afbc-specific checks should go after drm_gem_fb_init_with_funcs().
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 40
Use available afbc helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 44 +++-
1 file changed, 4 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index c076d0fd5b28
Consolidating framebuffer creation into one function will make it easier
to transition to generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 158 +--
1 file changed, 67 insertions(+), 91 deletions(-)
diff --git a
truct drm_framebuffer, exactly
the way the new version of drm_gem_fb_create_with_funcs() does.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 65 +++-
include/drm/drm_gem_framebuffer_helper.h | 5 ++
2 files changed, 56 insertions(+), 14 dele
The new struct contains afbc-specific data.
The new function can be used by drivers which support afbc to complete
the preparation of struct drm_afbc_framebuffer. It must be called after
allocating the said struct and calling drm_gem_fb_init_with_funcs().
Signed-off-by: Andrzej Pietrasiewicz
t direction.
I also kindly ask for input on how to accommodate komeda.
The CONFIG_DRM_AFBC option has been eliminated in favour of adding
drm_afbc.c to drm_kms_helper.
v1..v2:
- addressed comments from Daniel Stone, Ayan Halder, Mihail Atanassov
- coding style fixes
Andrzej Pietrasiewicz (6):
drm
3, 2019 at 04:58:35PM +0100, Andrzej Pietrasiewicz wrote:
The new version accepts a struct describing deviations from standard way of
doing the size checks. The caller must provide the respective values.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_hel
Hi All again,
@malidp and komeda folks: I kindly ask you to have your say. If there is
no interest from you (which is ok with me) I will resend the series
dropping the komeda and malidp part.
Andrzej
W dniu 30.01.2020 o 10:08, Andrzej Pietrasiewicz pisze:
Hi All,
A gentle reminder.
Please
+0100, Andrzej Pietrasiewicz wrote:
Hi All,
A gentle reminder.
Please also see inline:
W dniu 17.12.2019 o 15:49, Andrzej Pietrasiewicz pisze:
This series adds AFBC support for Rockchip. It is inspired by:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/factory-gru
Hi All,
A gentle reminder.
Please also see inline:
W dniu 17.12.2019 o 15:49, Andrzej Pietrasiewicz pisze:
This series adds AFBC support for Rockchip. It is inspired by:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads/factory-gru-9017.B-chromeos-4.4/drivers/gpu
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Sam Ravnborg
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b
The series completes the process of adding ddc symlink in connector's
sysfs directory: of the initial submission only the below patches are
still pending, hence this resend. Rebased onto drm-misc-next as of
2020-01-02.
Andrzej Pietrasiewicz (4):
drm/tegra: Provide ddc symlink in o
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Sam Ravnborg
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/zte/zx_vga.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Sam Ravnborg
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/zte/zx_hdmi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu
Use the ddc pointer provided by the generic connector.
Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Sam Ravnborg
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/tegra/hdmi.c | 7 ---
drivers/gpu/drm/tegra/sor.c | 7 ---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a
Prepare for using generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 142 +++
1 file changed, 68 insertions(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
Helpers are now available for checking afbc buffer properties. Use those.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 71 ++--
1 file changed, 30 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers
Use generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index
Between the old and new place nothing depends on data retrieved with the
helper, so it is safe to move its invocation.
The err_cleanup case is changed accordingly.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 5 +++--
1 file changed, 3
Add checking if a modifier is afbc and getting afbc block size.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_fourcc.c | 53
include/drm/drm_fourcc.h | 4 +++
2 files changed, 57 insertions(+)
diff --git a/drivers/gpu/drm/drm_fourcc.c b
The invocation is the same in both cases and is the last thing inside a
block, so move it outside the if-else clause.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c| 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a
This patch adds support for afbc handling. afbc is a compressed format
which reduces the necessary memory bandwidth.
Co-developed-by: Mark Yao
Signed-off-by: Mark Yao
Signed-off-by: Andrzej Pietrasiewicz
# Conflicts:
# drivers/gpu/drm/rockchip/rockchip_drm_fb.c
---
drivers/gpu/drm
The assignments are the same in both branches of the "if" statement and
nothing depends on them between their original position and the new
position, so this can be safely done.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 7 +++--
Ultimately we want lookups happening only once in komeda's fb_create
implementation.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 21 ---
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/k
Don't use a separate function to call the helper. The ultimate goal is
to unify non-afbc and afbc cases as much as possible and then moving the
helper invocation outside the if-else clause.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c
The replaced fragment is 1:1 with the helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers
Use generic helper code. Adapt struct komeda_fb users to new location
of respective data members.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/d71/d71_component.c| 6 +--
.../arm/display/komeda/komeda_framebuffer.c | 44 +--
.../arm/display/komeda
The next step towards using generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 36
1 file changed, 9 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm
This will make it easier to transition to generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index
Prepare for unification with non-afbc case.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 84 ---
1 file changed, 37 insertions(+), 47 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm
The new version accepts a struct describing deviations from standard way of
doing the size checks. The caller must provide the respective values.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 46
include/drm
Use the generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 46 +--
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm/arm/display
The same data is available in mode_cmd.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c| 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm/arm
It does still depend on komeda_fb, but only for komeda-specific parameters.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda
Add a variant of the function which doesn't need neither
struct drm_framebuffer nor container_of it. Maintain current interface
for existing users.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 68 +++
.../arm/display/k
Reduce dependency of the function on the "info" variable as much as
possible.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/disp
Use less code to handle errors.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 32 ---
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm/arm/display
Ultimately we want lookups happening only once in komeda's fb_create
implementation.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 30 +++
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/arm/di
Next step towards unifying afbc and non-afbc cases as much as possible.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda
Use generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 22 +++
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm/arm/display/komeda
The lookup is performed the same way in both branches of the "if"
statement, so move the lookup to before the "if". err_cleanup case
is adjusted accordingly.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 23 +++---
Extend the size-checking special function to handle afbc.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 49 +--
include/drm/drm_framebuffer.h| 50
include/drm/drm_gem_framebuffer_helper.h | 1
All necessary data is now available in other data structures.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b
Apparently komeda silently assumes that there is only 1 plane in an AFBC
buffer. Make this assumption explicit.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/arm/display
G_DRM_AFBC option has been eliminated in favour of adding
drm_afbc.c to drm_kms_helper.
v1..v2:
- addressed comments from Daniel Stone, Ayan Halder, Mihail Atanassov
- coding style fixes** BLURB HERE ***
Andrzej Pietrasiewicz (34):
drm/core: Add afbc helper functions
drm/gem-fb-helper: A
There is a local "info" variable which is exactly fb->format, so use it.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_
For AFBC case num_planes equals 1 so the check will not affect it.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c| 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda
Next step towards unifying afbc and non-afbc cases as much as possible.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c| 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda
Makes the code shorter and more readable.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers/gpu/drm
also inside the helpers themselves.
The interested drivers will likely need to be able to perform object
lookups and size checks in separate invocations and this patch provides
that as well. Helpers themselves are updated, too.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm
Hi Liviu,
My way of thinking is explained below. Do you still find it problematic?
W dniu 16.12.2019 o 18:08, Liviu Dudau pisze:
Hi Andrzej,
+struct drm_framebuffer *
+drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
+const struct drm
Hi Liviu,
W dniu 16.12.2019 o 18:19, Liviu Dudau pisze:
Hi Andrzej,
On Fri, Dec 13, 2019 at 04:58:36PM +0100, Andrzej Pietrasiewicz wrote:
Extend the size-checking special function to handle afbc.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_fourcc.c | 10
W dniu 28.11.2019 o 16:01, Andrzej Pietrasiewicz pisze:
Use the ddc pointer provided by the generic connector.
A gentle ping.
Andrzej
Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Sam Ravnborg
Reviewed-by: Emil Velikov
---
Rebased onto drm-intel-next-queued.
drivers/gpu/drm/i915
Use generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index
The invocation is the same in both cases and is the last thing inside a
block, so move it outside the if-else clause.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a
The replaced fragment is 1:1 with the helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
b/drivers
Use generic helper code. Adapt struct komeda_fb users to new location
of respective data members.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/d71/d71_component.c| 7 ++-
.../arm/display/komeda/komeda_framebuffer.c | 60 +--
.../arm/display/komeda
1 - 100 of 309 matches
Mail list logo
