[pull] amdgpu, amdkfd drm-fixes-6.16

2025-06-18 Thread Alex Deucher
ABGR16161616 fix - RMCM fix - Backlight fixes - GFX11 kicker support - SDMA reset fixes - VCN 5.0.1 fix - Reset fix - Misc small fixes amdkfd: - SDMA reset fix - Fix race in GWS scheduling Alex Deucher (3): drm/amdgpu: switch job

Re: [PATCH v7 5/5] drm/amdgpu: Make use of drm_wedge_task_info

2025-06-13 Thread Alex Deucher
On Fri, Jun 13, 2025 at 2:44 PM André Almeida wrote: > > To notify userspace about which task (if any) made the device get in a > wedge state, make use of drm_wedge_task_info parameter, filling it with > the task PID and name. > > Signed-off-by: André Almeida If you want the guilty state to be r

Re: [PATCH V1] accel/amdxdna: Fix incorrect PSP firmware size

2025-06-09 Thread Alex Deucher
On Wed, Jun 4, 2025 at 8:12 PM Lizhi Hou wrote: > > > On 6/4/25 07:51, Alex Deucher wrote: > > On Wed, Jun 4, 2025 at 10:42 AM Lizhi Hou wrote: > >> The incorrect PSP firmware size is used for initializing. It may > >> cause error for newer version firmware. >

[pull] amdgpu, amdkfd drm-fixes-6.16

2025-06-05 Thread Alex Deucher
-- amd-drm-fixes-6.16-2025-06-05: amdgpu: - IP discovery fix - Cleaner shader fix for GC 10.1.x - OD fix - UserQ fixes - Non-OLED panel fix - Misc display fixes - Brightness fixes amdkfd: - Enable CONFIG_HSA_AMD on RISCV ---- Alex

Re: [PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 3:30 PM SDL wrote: > > > > On Sat, May 24, 2025 at 2:14 AM Alexey Nepomnyashih wrote: > >> A potential NULL pointer dereference may occur when accessing > >> tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. > >> This may happen if mqd_backup[mqd_idx] i

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 10:55 AM Uwe Kleine-König wrote: > > Hello Alex, > > On Wed, Jun 04, 2025 at 03:29:58PM +0200, Greg KH wrote: > > On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > > > On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König > > >

Re: [PATCH V1] accel/amdxdna: Fix incorrect PSP firmware size

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 10:42 AM Lizhi Hou wrote: > > The incorrect PSP firmware size is used for initializing. It may > cause error for newer version firmware. > > Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/a

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König wrote: > > Hello Alex, > > On Fri, May 30, 2025 at 04:14:09PM -0400, Alex Deucher wrote: > > On Fri, May 30, 2025 at 4:09 PM Aurabindo Pillai > > wrote: > > > > > > This reverts commit 219898d29c438d8ec34a

Re: [PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-05-30 Thread Alex Deucher
On Sat, May 24, 2025 at 2:14 AM Alexey Nepomnyashih wrote: > > A potential NULL pointer dereference may occur when accessing > tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. > This may happen if mqd_backup[mqd_idx] is unexpectedly NULL. > > Although a NULL check for mqd_bac

Re: [PATCH] drm/amdgpu: Fix integer overflow in amdgpu_gem_add_input_fence()

2025-05-30 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 23, 2025 at 12:34 PM Dan Carpenter wrote: > > The "num_syncobj_handles" is a u32 value that comes from the user via the > ioctl. On 32bit systems the "sizeof(uint32_t) * num_syncobj_handles" > multiplication can have an integer overflow. Use size_mul() to fix

Re: [PATCH] drm/amdgpu: Fix integer overflow issues in amdgpu_userq_fence.c

2025-05-30 Thread Alex Deucher
Applied. Thanks! On Fri, May 23, 2025 at 12:25 PM Dan Carpenter wrote: > > This patch only affects 32bit systems. There are several integer > overflows bugs here but only the "sizeof(u32) * num_syncobj" > multiplication is a problem at runtime. (The last lines of this patch). > > These variabl

Re: Regression: RX 470 fails to boot with amdgpu.dpm=1 on kernel 6.7+

2025-05-30 Thread Alex Deucher
On Thu, May 22, 2025 at 8:39 AM Ozgur Kara wrote: > > Durmuş , 22 May 2025 Per, 15:15 tarihinde şunu yazdı: > > > > I'm using dual monitors. I disconnected the HDMI to test with a single > > screen, but the result was the same. I also swapped the HDMI ports, > > but the issue still persisted. > >

[pull] amdgpu, amdkfd, radeon drm-fixes-6.16

2025-05-29 Thread Alex Deucher
c cleanups ---- Alex Deucher (3): drm/amdgpu: Update runtime pm checks drm/amdgpu/mes: add missing locking in helper functions drm/amdgpu/mes: remove some unused functions Andrey Vatoropin (1): drm/amdkfd: Change svm_range_get_i

Re: [PATCH 1/4] drm/sched: optimize drm_sched_job_add_dependency

2025-05-28 Thread Alex Deucher
On Wed, May 28, 2025 at 8:45 AM Simona Vetter wrote: > > On Mon, May 26, 2025 at 01:27:28PM +0200, Philipp Stanner wrote: > > On Mon, 2025-05-26 at 13:16 +0200, Christian König wrote: > > > On 5/26/25 11:34, Philipp Stanner wrote: > > > > On Mon, 2025-05-26 at 11:25 +0200, Christian König wrote: >

[pull] amdgpu drm-fixes-6.15

2025-05-22 Thread Alex Deucher
Hi Dave, Simona, One fix for 6.15. The following changes since commit a5806cd506af5a7c19bcd596e4708b5c464bfd21: Linux 6.15-rc7 (2025-05-18 13:57:29 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.15-2025-05-22 for you to

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

2025-05-22 Thread Alex Deucher
On Thu, May 15, 2025 at 4:58 AM Christian König wrote: > > Explicitly adding the scheduler maintainers. > > On 5/15/25 04:07, Lin.Cao wrote: > > Previously we only signaled finished fence which may cause some > > submission's dependency cannot be cleared the cause benchmark hang. > > Signal both s

Re: [PATCH 2/2] fixing typo in function name

2025-05-19 Thread Alex Deucher
On Sat, May 17, 2025 at 8:38 AM Jihed Chaibi wrote: > > "ENABLE" is currently misspelled in SYS_INFO_GPUCAPS__ENABEL_DFS_BYPASS > > Signed-off-by: Jihed Chaibi Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/atombios.h | 2 +- > drivers/gpu/drm/radeon/kv_dpm.c | 2 +- > 2 files change

Re: [PATCH 1/2] fixing typo in macro name

2025-05-19 Thread Alex Deucher
Applied. Thanks! On Sat, May 17, 2025 at 7:43 AM Jihed Chaibi wrote: > > "ENABLE" is currently misspelled in SYS_INFO_GPUCAPS__ENABEL_DFS_BYPASS > > PS: checkpatch.pl is complaining about the presence of a space at the > start of drivers/gpu/drm/amd/include/atomfirmware.h line: 1716 > This is pr

Re: [PATCH] drm/amd/display: fix typo in comments

2025-05-19 Thread Alex Deucher
Applied. Thanks! Alex On Sat, May 17, 2025 at 8:38 AM Daniil Ryabov wrote: > > Fix double 'u' in 'frequuency' > > Signed-off-by: Daniil Ryabov > --- > drivers/gpu/drm/amd/display/dc/basics/dce_calcs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH 2/2 RESEND] drm/amd/display: Adjust set_value function with prefix to help in ftrace

2025-05-19 Thread Alex Deucher
Applied the series. Thanks! Alex On Sat, May 17, 2025 at 10:28 AM Leonardo Gomes wrote: > > Adjust set_value function in hw_hpd.c file to have > prefix to help in ftrace, the name change from > 'set_value' to 'dal_hw_hpd_set_value' > > Signed-off-by: Leonardo da Silva Gomes > Co-developed-by:

[pull] amdgpu, amdkfd, radeon drm-next-6.16

2025-05-16 Thread Alex Deucher
0.1 SR-IOV updates - JPEG 5.0.1 SR-IOV updates amdkfd: - Fix spurious warning in interrupt code - XNACK fixes radeon: - CIK doorbell cleanup ---- Alex Deucher (1): drm/amdkfd: drop warning in event_interrupt_isr_v1*() Amber Lin (1):

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

2025-05-16 Thread Alex Deucher
n. Alex > Leonardo Gomes > > Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher > escreveu: >> >> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes >> wrote: >> > >> > Adjust get_value function in hw_hpd.c file to have >> > prefix to help in

Re: Kernels >= 6.3 disable video output

2025-05-15 Thread Alex Deucher
+ Harry On Thu, May 15, 2025 at 12:11 PM Steven J Abner wrote: > > On Mon, May 12 2025 at 08:10:40 PM +, Alex Deucher > wrote: > > See: > > https://docs.kernel.org/admin-guide/bug-bisect.html > > ... identify the exact commit which broke caused your issue. >

Re: [PATCH] docs: fix doc warning for DC_HDCP_LC_ENABLE_SW_FALLBACK in amd_shared.h

2025-05-15 Thread Alex Deucher
On Thu, May 15, 2025 at 3:09 AM Rahul Kumar wrote: > > Fixes a kernel-doc warning by correctly documenting the enum value > `DC_HDCP_LC_ENABLE_SW_FALLBACK` in the DC_DEBUG_MASK enum. > > The previous documentation was incorrectly formatted and incomplete. > Updated to follow proper kernel-doc synt

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

2025-05-14 Thread Alex Deucher
On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes wrote: > > Adjust get_value function in hw_hpd.c file to have > prefix to help in ftrace, the name change from > 'get_value' to 'dal_hw_gpio_get_value' This won't compile. dal_hw_gpio_get_value is already defined in drivers/gpu/drm/amd/display/dc/gp

[pull] amdgpu drm-fixes-6.15

2025-05-14 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.15. The following changes since commit 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3: Linux 6.15-rc6 (2025-05-11 14:54:11 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.15-2025-05-14 for you to fe

Re: [PATCH] drm/radeon/cik: Clean up doorbells

2025-05-14 Thread Alex Deucher
On Tue, May 13, 2025 at 9:53 PM wrote: > > From: "Dr. David Alan Gilbert" > > Free doorbells in the error paths of cik_init and in cik_fini. > > Build tested only. > > Suggested-by: Christophe JAILLET > Signed-off-by: Dr. David Alan Gilbert Applied. Thanks! Alex > --- > RFC->v1 > Renamed

Re: [PATCH] drm/amdgpu: Fix docs build warning

2025-05-14 Thread Alex Deucher
On Wed, May 14, 2025 at 3:24 AM George Anthony Vernon wrote: > > The kerneldoc comment for HGCP locality check debug mask was missing a > semicolon resulting in a documentation build warning. Correct it. > > Signed-off-by: George Anthony Vernon Thanks for the patch, but this was already fixed.

Re: [PATCH] drm/amd: fix kernel-doc parameter tag format

2025-05-14 Thread Alex Deucher
On Wed, May 14, 2025 at 3:31 AM Abdelrahman Fekry wrote: > > The DC_HDCP_LC_ENABLE_SW_FALLBACK enum comment was missing the required > colon after the parameter name in its kernel-doc tag: > > * @DC_HDCP_LC_ENABLE_SW_FALLBACK If set, ... > > Kernel-doc insists on the form @name: description. Add

Re: Kernels >= 6.3 disable video output

2025-05-12 Thread Alex Deucher
On Mon, May 12, 2025 at 4:07 PM Steven J Abner wrote: > > On Fri, May 9 2025 at 03:01:13 PM +, Steven J Abner > wrote: > > On Fri, May 9 2025 at 02:05:16 PM +0000, Alex Deucher > > wrote: > >> bisect between 6.2.16 and 6.2.17 to identify the commit which brok

Re: [PATCH] Documentation/gpu: Disambiguate SPI term

2025-05-12 Thread Alex Deucher
On Mon, May 12, 2025 at 3:58 AM Bagas Sanjaya wrote: > > Documentation/userspace-api/media/glossary.rst:170: WARNING: duplicate term > description of SPI, other instance in gpu/amdgpu/amdgpu-glossary > > That's because SPI of amdgpu (Shader Processor Input) shares the same > global glossary term

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-05-12 Thread Alex Deucher
On Sun, May 11, 2025 at 8:13 AM Dr. David Alan Gilbert wrote: > > * Christophe JAILLET (christophe.jail...@wanadoo.fr) wrote: > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > > From: "Dr. David Alan Gilbert" > > > > > > radeon_doorbell_free() was added in 2013 by > > > commit 75efdee11b

Re: amdgpu RENOIR funky complaints in dmesg

2025-05-12 Thread Alex Deucher
+ Wayne, Leo, Harry On Mon, May 12, 2025 at 8:28 AM Borislav Petkov wrote: > > Hey folks, > > this is rc6 + tip/master on a Zen2 RN laptop. > > Needless to say, the complaints are brand new. > > Thx. > > [0.875804] ACPI: bus type drm_connector registered > [0.877903] [drm] Initialized vge

[pull] amdgpu, amdkfd, drm, dma-buf drm-next-6.16

2025-05-09 Thread Alex Deucher
Alex Deucher (9): Revert "drm/amd: Stop evicting resources on APUs in suspend" drm/amdgpu: fix pm notifier handling drm/amdgpu/psp: mark securedisplay TA as optional Revert "drm/amdgpu: Use generic hdp

Re: Kernels >= 6.3 disable video output

2025-05-09 Thread Alex Deucher
On Fri, May 9, 2025 at 9:39 AM Steven J Abner wrote: > > On Fri, May 9 2025 at 01:11:17 PM +, Alex Deucher > wrote: > > What display(s) are you using and how are they connected? Can you > > bisect? > > Not sure the question, but it's a tv thru HDMI. > >

Re: Kernels >= 6.3 disable video output

2025-05-09 Thread Alex Deucher
On Fri, May 9, 2025 at 3:43 AM Steven J Abner wrote: > > AMD 2400g, Zen1, 'Raven' firmware, igpu, no card. > Code that was added to 6.2.16 to create 6.3 and up, to last tested > 6.13.4, breaks the igpu for Ryzen. Kernels with firmware, same as that > used on 6.3 and up, works 100% on 5.4 to 6.2.1

[pull] amdgpu drm-fixes-6.15

2025-05-08 Thread Alex Deucher
- DMUB AUX fixes - VCN fix - Hibernation fixes - HDP fixes Alex Deucher (7): Revert "drm/amd: Stop evicting resources on APUs in suspend" drm/amdgpu: fix pm notifier handling drm/amdgpu/hdp4: use memcfg regist

Re: [PATCH 3/3] drm/amd/pm: Remove remainder of mode2_reset_is_support

2025-05-08 Thread Alex Deucher
Applied the series. Thanks! Alex On Wed, May 7, 2025 at 1:13 PM wrote: > > From: "Dr. David Alan Gilbert" > > The previous patch removed smu_mode2_reset_is_support() > which was the only function to call through the mode2_reset_is_support() > method pointer. > > Remove the remaining functions

Re: [RFC 2/2] drm/amd: Use suspend and hibernate post freeze notifications

2025-05-07 Thread Alex Deucher
On Wed, May 7, 2025 at 3:39 PM Rafael J. Wysocki wrote: > > On Wed, May 7, 2025 at 9:17 PM Mario Limonciello wrote: > > > > On 5/7/2025 2:14 PM, Rafael J. Wysocki wrote: > > > On Thu, May 1, 2025 at 11:17 PM Mario Limonciello > > > wrote: > > >> > > >> From: Mario Limonciello > > >> > > >> com

Re: [PATCH 3/3] drm/amd/pm/smu13: Remove unused smu_v3 functions

2025-05-07 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, May 6, 2025 at 8:33 PM wrote: > > From: "Dr. David Alan Gilbert" > > smu_v13_0_display_clock_voltage_request() and > smu_v13_0_set_min_deep_sleep_dcefclk() were added in 2020 by > commit c05d1c401572 ("drm/amd/swsmu: add aldebaran smu13 ip support (v3)"

Re: [PATCH AUTOSEL 6.14 248/642] drm/amdgpu: add dce_v6_0_soft_reset() to DCE6

2025-05-06 Thread Alex Deucher
under DCE8 and DCE10. > > Signed-off-by: Alexandre Demers > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin This is not stable material. Alex > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 53 ++- > 1 file changed, 51 insertions(+), 2 deletio

Re: [PATCH AUTOSEL 6.12 376/486] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 6:53 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

Re: [PATCH AUTOSEL 6.6 229/294] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 7:04 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

Re: [PATCH AUTOSEL 5.15 090/153] drm/amd/display: fix dcn4x init failed

2025-05-06 Thread Alex Deucher
ff-by: Charlene Liu > Signed-off-by: Zaeem Mohamed > Tested-by: Daniel Wheeler > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin Support for DCN 4 was added in 6.11 I think so there is no need to backport DCN 4.x fixes to kernels older than 6.11. Alex > --- > d

Re: [PATCH AUTOSEL 6.14 483/642] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 6:34 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

[pull] amdgpu, amdkfd, radeon drm-next-6.16

2025-05-02 Thread Alex Deucher
/-/merge_requests/32700 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33661 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34370 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34493 Alex Deucher

[pull] amdgpu drm-fixes-6.15

2025-05-01 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.15. The following changes since commit b4432656b36e5cc1d50a1f2dc15357543add530e: Linux 6.15-rc4 (2025-04-27 15:19:23 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.15-2025-05-01 for you to fe

Re: [PATCH] drm/amd/display: Rename program_timing function for better debugging

2025-04-30 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 30, 2025 at 3:44 AM Antonio Fernando Silva e Cruz Filho wrote: > > [WHY] > Improve the output when using the ftrace debug feature, > making it easier to identify which function is currently being executed. > > [HOW] > Rename the program_timing function to a name that

Re: [PATCH] drm/amdgpu/userq: remove unnecessary NULL check

2025-04-30 Thread Alex Deucher
On Wed, Apr 30, 2025 at 4:13 AM Dan Carpenter wrote: > > The "ticket" pointer points to in the middle of the &exec struct so it > can't be NULL. Remove the check. > > Signed-off-by: Dan Carpenter Applied. Thanks! > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +- > 1 file changed, 1 i

Re: [PATCH next] drm/amdgpu/userq: Call unreserve on error in amdgpu_userq_fence_read_wptr()

2025-04-30 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 30, 2025 at 4:08 AM Dan Carpenter wrote: > > This error path should call amdgpu_bo_unreserve() before returning. > > Fixes: d8675102ba32 ("drm/amdgpu: add vm root BO lock before accessing the > vm") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH AUTOSEL 6.14 33/39] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.12 32/37] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.6 18/21] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.1 07/10] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH] drm/amd/display: Don't check for NULL divisor in fixpt code

2025-04-29 Thread Alex Deucher
Drop the ASSERTs in both DC and SPL variants. > > Signed-off-by: Harry Wentland > Cc: Linus Torvalds > Cc: Leo Li > Cc: Alex Deucher Maybe add Fixes tags for the original patches which added these? Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/basics/fi

Re: [PATCH 1/1] drm/amd: Fix malformed kerneldoc comment

2025-04-28 Thread Alex Deucher
Thanks for the patch. This was already fixed. Alex On Mon, Apr 28, 2025 at 8:53 AM Brahmajit Das wrote: > > One kerneldoc commets in amd_shared.h failed to adhere to required > format, resulting in these doc-build warnings: > > ./drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect

Re: [PATCH] drm/amdgpu/userq: fix user_queue parameters list

2025-04-28 Thread Alex Deucher
Applied. Thanks. Alex On Sat, Apr 26, 2025 at 10:37 PM Bagas Sanjaya wrote: > > Sphinx reports htmldocs warning: > > Documentation/gpu/amdgpu/module-parameters:7: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1119: ERROR: Unexpected indentation. > [docutils] > > Fix the warning by using reST bull

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2025-04-28 Thread Alex Deucher
On Sun, Apr 27, 2025 at 5:46 AM R Sundar wrote: > > Use string choice helpers for better readability. > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/ > Signed-off-by: R Sundar > --- > > Reported in linux rep

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-24 Thread Alex Deucher
On Wed, Apr 23, 2025 at 10:29 AM Christian König wrote: > > On 4/22/25 18:26, Deucher, Alexander wrote: > > [Public] > > > >> -Original Message----- > >> From: Alex Deucher > >> Sent: Tuesday, April 22, 2025 9:46 AM > >> To: Koenig,

Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Alex Deucher
On Thu, Apr 24, 2025 at 4:49 AM Marek Marczykowski-Górecki wrote: > > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > > > > > But the code would start to become quite

[pull] amdgpu drm-fixes-6.15

2025-04-23 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.15. The following changes since commit 0467145fab3b3a7a1efd221722310fe32329b3da: Merge tag 'drm-msm-fixes-2025-04-18' of https://gitlab.freedesktop.org/drm/msm into drm-fixes (2025-04-19 15:09:29 +1000) are available in the Git repository at: https://gitlab.f

Re: [PATCH RESEND v13 0/5] Expose modifiers/formats supported by async flips

2025-04-23 Thread Alex Deucher
+ Harry and Leo On Wed, Apr 16, 2025 at 2:33 AM Borah, Chaitanya Kumar wrote: > > Hello Alexander, > > > -Original Message- > > From: Murthy, Arun R > > Sent: Monday, April 7, 2025 11:14 AM > > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > > x...@lists.fr

Re: [PATCH] drm/amdgpu/atom: Work around vbios NULL offset false positive

2025-04-22 Thread Alex Deucher
On Tue, Apr 22, 2025 at 10:56 AM Kees Cook wrote: > > On Tue, Apr 22, 2025 at 09:22:26AM -0400, Alex Deucher wrote: > > On Mon, Apr 21, 2025 at 5:59 PM Kees Cook wrote: > > > > > > GCC really does not want to consider NULL (or near-NULL) addresses as > > &

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-22 Thread Alex Deucher
Applied. Thanks! On Tue, Apr 22, 2025 at 5:13 AM Koenig, Christian wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Reviewed-by: Christian König > > > Von: Denis Arefev > Gesendet: Freitag, 18. April 2025 10:31 > An: Deucher, Alex

Re: [PATCH][next] drm/amdgpu: Fix spelling mistake "rounter" -> "rounter"

2025-04-22 Thread Alex Deucher
On Tue, Apr 22, 2025 at 6:33 AM Colin Ian King wrote: > > There is a spelling mistake with the array utcl2_rounter_str, it > appears it should be utcl2_router_str. Fix it. > > Signed-off-by: Colin Ian King Applied with the patch title fixed up. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu/atom: Work around vbios NULL offset false positive

2025-04-22 Thread Alex Deucher
ne way to convince it otherwise, hide vbios_str from > GCC's optimizer to avoid the warning so we can get closer to enabling > -Warray-bounds globally. > > Signed-off-by: Kees Cook Acked-by: Alex Deucher Do you want me to pick this up, or do you want to take this through some oth

Re: [PATCH] drm/amd/pm/powerplay/smumgr/vegam_smumgr: Fix error handling in vegam_populate_smc_boot_level()

2025-04-18 Thread Alex Deucher
On Tue, Apr 15, 2025 at 8:33 AM Wentao Liang wrote: > > In vegam_populate_smc_boot_level(), the return value of > phm_find_boot_level() is 0 or negative error code and the > "if (result)" branch statement will never run into the true > branch. Besides, this will skip setting the voltages later > b

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread Alex Deucher
On Fri, Apr 18, 2025 at 2:18 AM Christophe JAILLET wrote: > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > From: "Dr. David Alan Gilbert" > > > > radeon_doorbell_free() was added in 2013 by > > commit 75efdee11b5d ("drm/radeon: implement simple doorbell page > > allocator") > > but neve

Re: [PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-18 Thread Alex Deucher
Applied patches 1, 3, 4. Thanks! On Thu, Apr 17, 2025 at 8:28 PM wrote: > > From: "Dr. David Alan Gilbert" > > rn_vbios_smu_set_dprefclk() was added in 2019 by > commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") > rv1_vbios_smu_set_dprefclk() was also added in 2019 by > commit d

Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

2025-04-16 Thread Alex Deucher
On Tue, Apr 15, 2025 at 6:23 AM Wentao Liang wrote: > > The return value of fiji_populate_smc_boot_level() is needs to be checked. > An error handling is also needed to phm_find_boot_level() to reset the > boot level when the function fails. A proper implementation can be found > in tonga_populate

[pull] amdgpu drm-fixes-6.15

2025-04-16 Thread Alex Deucher
doorbell free ordering - Video caps fix - DML2 memory allocation optimization - HDP fix Alex Deucher (1): drm/amd/display/dml2: use vzalloc rather than kzalloc Christian König (1): drm/amdgpu: use a dummy owner for sysfs

Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-04-16 Thread Alex Deucher
Can you resend, I can't seem to find the original emails. Additionally, all of the NISLANDS structures are unused in amdgpu, so those could be removed. Alex On Wed, Apr 16, 2025 at 12:48 AM Gustavo A. R. Silva wrote: > > Hi all, > > Friendly ping (second one): who can take this patch, please? 🙂 >

Re: [PATCH v2 2/2] drm/amdgpu: Clean up error handling in amdgpu_userq_fence_driver_alloc()

2025-04-15 Thread Alex Deucher
Applied the series. Thanks! On Mon, Apr 14, 2025 at 12:48 AM Yadav, Arvind wrote: > > Reviewed-by:Arvind Yadav > > On 4/12/2025 8:09 PM, Dan Carpenter wrote: > > 1) Checkpatch complains if we print an error message for kzalloc() > > failure. The kzalloc() failure already has it's own error

Re: [Linaro-mm-sig] [PATCH AUTOSEL 6.13 15/34] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH AUTOSEL 6.14 15/34] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH AUTOSEL 6.12 11/30] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH RESEND] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Fix wrong return value of fiji_populate_smc_boot_level()

2025-04-14 Thread Alex Deucher
On Mon, Apr 14, 2025 at 3:24 AM Wentao Liang wrote: > > The return value of fiji_populate_smc_boot_level() is always 0, which > represent the failure of the function. The result of phm_find_boot_level() > should be recored and return. An error handling is also needed to > phm_find_boot_level() to

Re: [PATCH v1 3/3] drm/amdgpu: update the error logging for more information

2025-04-11 Thread Alex Deucher
On Fri, Apr 11, 2025 at 9:05 AM Sunil Khatri wrote: > > add process and pid information in the userqueue error > logging to make it more useful in resolving the error > by logs. > > Sample log: > [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed > out waiting for fence

[pull] amdgpu, amdkfd drm-fixes-6.15

2025-04-09 Thread Alex Deucher
possible division by 0 in fan handling amdkfd: - Queue reset fixes Alex Deucher (5): drm/amdgpu/mes11: optimize MES pipe FW version fetching drm/amdgpu/pm: add workload profile pause helper drm/amdgpu/pm/swsmu: implement

Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

2025-04-08 Thread Alex Deucher
Oh, sorry, I've picked it up now. Thanks! Alex On Tue, Apr 8, 2025 at 4:16 AM Denis Arefev wrote: > > > --- > > drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c > > b/dr

Re: [PATCH] drm/amd/display: Add error check for avi and vendor infoframe setup function

2025-04-07 Thread Alex Deucher
On Mon, Apr 7, 2025 at 8:52 AM Wentao Liang wrote: > > The function fill_stream_properties_from_drm_display_mode() calls the > function drm_hdmi_avi_infoframe_from_display_mode() and the > function drm_hdmi_vendor_infoframe_from_display_mode(), but does > not check its return value. Log the error

Re: [PATCH] drm/amd/display: removed unused function

2025-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 27, 2025 at 11:37 PM James Flowers wrote: > > Removed unused function mpc401_get_3dlut_fast_load_status. > > Signed-off-by: James Flowers > --- > drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 17 - > .../drm/amd/display/dc/mpc/dcn401/dcn40

Re: [PATCH v2 18/57] irqdomain: gpu: Switch to irq_domain_create_linear()

2025-04-05 Thread Alex Deucher
on case to > case basis (by people who can actually test with the HW). > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Simona Vetter > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry B

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 24, 2025 at 8:08 PM Andres Urian Florez wrote: > > Instead of using the strcpy() deprecated function to populate the > fw_name, use the strscpy() function > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy > > Signed-off-by: Andres

Re: [PATCH] Documentation: Remove repeated word in docs

2025-04-05 Thread Alex Deucher
On Thu, Feb 13, 2025 at 2:08 AM Charles Han wrote: > > Remove the repeated word "the" in docs. > > Signed-off-by: Charles Han Applied. Thanks! Alex > --- > Documentation/gpu/amdgpu/display/dc-debug.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gpu

[pull] amdgpu drm-next-6.15

2025-03-27 Thread Alex Deucher
tching fix - MES fixes - Queue reset fix ---- Alex Deucher (2): drm/amdgpu/gfx11: fix num_mec drm/amdgpu/gfx12: fix num_mec Asad Kamal (3): drm/amd/pm: Remove host limit metrics support drm/amd/pm: Update smu metrics

Re: [PATCH] drm/amdgpu: use static ids for ACP platform devs

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 6:07 PM Brady Norander wrote: > > mfd_add_hotplug_devices() assigns child platform devices with > PLATFORM_DEVID_AUTO, but the ACP machine drivers expect the platform > device names to never change. Use mfd_add_devices() instead and give > each cell a unique id. While you

Re: [PATCH] drm/amd/amdgpu: Fix typo

2025-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 25, 2025 at 4:14 AM AnantaSrikar wrote: > > From: Ananta Srikar > > Fixes a typo in the word "version" in an error message. > > Signed-off-by: Ananta Srikar > > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 9:50 AM Christian König wrote: > > Am 25.03.25 um 14:30 schrieb Alex Deucher: > > On Tue, Mar 25, 2025 at 4:38 AM Christian König > > wrote: > >> Alex shouldn't be try to completely nuke the CGS functions? > > Sure, but it would need

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 4:38 AM Christian König wrote: > > Alex shouldn't be try to completely nuke the CGS functions? Sure, but it would need to be replaced with something else so I'm not sure it's worth the effort since it's only used by a few older GPUs. Alex > > Christian. > > Am 25.03.25 u

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-21 Thread Alex Deucher
drm/amdgpu/sdam: Skip SDMA queue reset for SRIOV Alex Deucher (14): drm/amdgpu: drop drm_firmware_drivers_only() drm/amdgpu: adjust drm_firmware_drivers_only() handling drm/amdgpu: don't free conflicting apertures for non-display devices drm/amdgpu/gfx: fi

Re: [PATCH 0/5] drm/amd/pm: Prevent division by zero

2025-03-21 Thread Alex Deucher
On Fri, Mar 21, 2025 at 6:53 AM Denis Arefev wrote: > > This series of patches prevents possible division by zero. > > The user can set any speed value. > If speed is greater than UINT_MAX/8, division by zero is possible. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. Appli

[pull] amdgpu, amdkfd, radeon drm-fixes-6.14

2025-03-20 Thread Alex Deucher
d-drm-fixes-6.14-2025-03-20: amdgpu: - Fix video caps limits on several asics - SMU 14.x fixes - GC 12 fixes - eDP fixes - DMUB fix amdkfd: - GC 12 trap handler fix - GC 7/8 queue validation fix radeon: - VCE IB parsing fix Alex De

Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

2025-03-20 Thread Alex Deucher
On Thu, Mar 20, 2025 at 9:11 AM Denis Arefev wrote: > > The user can set any speed value. > If speed is greater than UINT_MAX/8, division by zero is possible. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 1e866f1fe528 ("drm/amd/pm: Prevent divide by zero") > Sign

Re: [PATCH] drm/radeon/uvd: Replace nested max() with single max3()

2025-03-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 18, 2025 at 2:18 AM wrote: > > From: FengWei > > Use max3() macro instead of nesting max() to simplify the return > statement. > > Signed-off-by: FengWei > --- > drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-15 Thread Alex Deucher
on cleanup fixes - Retry fault fixes - Dequeue retry timeout adjustments - GC 12.x trap handler fixes - GC 9.5.x updates radeon: - VCE command parser fix ---- Alex Deucher (11): drm/amdgpu/vcn: fix idle work handler for VCN 2.5

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 12, 2025 at 6:09 AM Wentao Liang wrote: > > In gfx_v12_0_cp_gfx_load_me_microcode_rs64(), gfx_v12_0_pfp_fini() is > incorrectly used to free 'me' field of 'gfx', since gfx_v12_0_pfp_fini() > can only release 'pfp' field of 'gfx'. The release function of 'me' fi

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Alex Deucher
lt;48> 8b 7f 58 48 89 e6 ba 01 00 00 00 e8 08 3c 2a 00 65 48 8b 04 5 > >> [ 37.904703] RSP: 0018:969442853300 EFLAGS: 00010202 > >> [ 37.909933] RAX: RBX: 92db0300 RCX: > >> 969442853358 > >> [ 37.917068] RDX: 96944285

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-03-12 Thread Alex Deucher
C DCE 6.x fix - Hibernation fix - HPD fix - Backlight fixes - Color depth fix - UAF fix in hdcp_work - VCE 2.x fix - GC 12.x PTE fix amdkfd: - Queue eviction fix Alex Deucher (1): drm/amdgpu/vce2: fix ip block reference Alex

[pull] amdgpu, amdkfd, radeon drm-fixes-6.14

2025-03-11 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 7eb172143d5508b4da468ed59ee857c6e5e01da6: Linux 6.14-rc5 (2025-03-02 11:48:20 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-03-06 for you to fe

  1   2   3   4   5   6   7   8   9   10   >