Re: [RFC 2/2] drm/amd: Use suspend and hibernate post freeze notifications

2025-05-07 Thread Alex Deucher
On Wed, May 7, 2025 at 3:39 PM Rafael J. Wysocki wrote: > > On Wed, May 7, 2025 at 9:17 PM Mario Limonciello wrote: > > > > On 5/7/2025 2:14 PM, Rafael J. Wysocki wrote: > > > On Thu, May 1, 2025 at 11:17 PM Mario Limonciello > > > wrote: > > >> > > >> From: Mario Limonciello > > >> > > >> com

Re: [PATCH 3/3] drm/amd/pm/smu13: Remove unused smu_v3 functions

2025-05-07 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, May 6, 2025 at 8:33 PM wrote: > > From: "Dr. David Alan Gilbert" > > smu_v13_0_display_clock_voltage_request() and > smu_v13_0_set_min_deep_sleep_dcefclk() were added in 2020 by > commit c05d1c401572 ("drm/amd/swsmu: add aldebaran smu13 ip support (v3)"

Re: [PATCH AUTOSEL 6.14 248/642] drm/amdgpu: add dce_v6_0_soft_reset() to DCE6

2025-05-06 Thread Alex Deucher
under DCE8 and DCE10. > > Signed-off-by: Alexandre Demers > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin This is not stable material. Alex > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 53 ++- > 1 file changed, 51 insertions(+), 2 deletio

Re: [PATCH AUTOSEL 6.12 376/486] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 6:53 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

Re: [PATCH AUTOSEL 6.6 229/294] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 7:04 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

Re: [PATCH AUTOSEL 5.15 090/153] drm/amd/display: fix dcn4x init failed

2025-05-06 Thread Alex Deucher
ff-by: Charlene Liu > Signed-off-by: Zaeem Mohamed > Tested-by: Daniel Wheeler > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin Support for DCN 4 was added in 6.11 I think so there is no need to backport DCN 4.x fixes to kernels older than 6.11. Alex > --- > d

Re: [PATCH AUTOSEL 6.14 483/642] drm/amd/display/dc: enable oem i2c support for DCE 12.x

2025-05-06 Thread Alex Deucher
On Mon, May 5, 2025 at 6:34 PM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 2ed83f2cc41e8f7ced1c0610ec2b0821c5522ed5 ] > > Use the value pulled from the vbios just like newer chips. > > Reviewed-by: Harry Wentland > Signed-off-by: Alex Deucher &

[pull] amdgpu, amdkfd, radeon drm-next-6.16

2025-05-02 Thread Alex Deucher
/-/merge_requests/32700 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33661 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34370 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34493 Alex Deucher

[pull] amdgpu drm-fixes-6.15

2025-05-01 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.15. The following changes since commit b4432656b36e5cc1d50a1f2dc15357543add530e: Linux 6.15-rc4 (2025-04-27 15:19:23 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.15-2025-05-01 for you to fe

Re: [PATCH] drm/amd/display: Rename program_timing function for better debugging

2025-04-30 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 30, 2025 at 3:44 AM Antonio Fernando Silva e Cruz Filho wrote: > > [WHY] > Improve the output when using the ftrace debug feature, > making it easier to identify which function is currently being executed. > > [HOW] > Rename the program_timing function to a name that

Re: [PATCH] drm/amdgpu/userq: remove unnecessary NULL check

2025-04-30 Thread Alex Deucher
On Wed, Apr 30, 2025 at 4:13 AM Dan Carpenter wrote: > > The "ticket" pointer points to in the middle of the &exec struct so it > can't be NULL. Remove the check. > > Signed-off-by: Dan Carpenter Applied. Thanks! > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +- > 1 file changed, 1 i

Re: [PATCH next] drm/amdgpu/userq: Call unreserve on error in amdgpu_userq_fence_read_wptr()

2025-04-30 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 30, 2025 at 4:08 AM Dan Carpenter wrote: > > This error path should call amdgpu_bo_unreserve() before returning. > > Fixes: d8675102ba32 ("drm/amdgpu: add vm root BO lock before accessing the > vm") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH AUTOSEL 6.14 33/39] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.12 32/37] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.6 18/21] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH AUTOSEL 6.1 07/10] drm/amdgpu: Allow P2P access through XGMI

2025-04-30 Thread Alex Deucher
nt. > > Signed-off-by: Felix Kuehling > Tested-by: Hao (Claire) Zhou > Reviewed-by: Christian König > Signed-off-by: Alex Deucher > (cherry picked from commit 372c8d72c3680fdea3fbb2d6b089f76b4a6d596a) > Signed-off-by: Sasha Levin This patch is only applicable to 6.15

Re: [PATCH] drm/amd/display: Don't check for NULL divisor in fixpt code

2025-04-29 Thread Alex Deucher
Drop the ASSERTs in both DC and SPL variants. > > Signed-off-by: Harry Wentland > Cc: Linus Torvalds > Cc: Leo Li > Cc: Alex Deucher Maybe add Fixes tags for the original patches which added these? Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/basics/fi

Re: [PATCH 1/1] drm/amd: Fix malformed kerneldoc comment

2025-04-28 Thread Alex Deucher
Thanks for the patch. This was already fixed. Alex On Mon, Apr 28, 2025 at 8:53 AM Brahmajit Das wrote: > > One kerneldoc commets in amd_shared.h failed to adhere to required > format, resulting in these doc-build warnings: > > ./drivers/gpu/drm/amd/include/amd_shared.h:369: warning: Incorrect

Re: [PATCH] drm/amdgpu/userq: fix user_queue parameters list

2025-04-28 Thread Alex Deucher
Applied. Thanks. Alex On Sat, Apr 26, 2025 at 10:37 PM Bagas Sanjaya wrote: > > Sphinx reports htmldocs warning: > > Documentation/gpu/amdgpu/module-parameters:7: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1119: ERROR: Unexpected indentation. > [docutils] > > Fix the warning by using reST bull

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2025-04-28 Thread Alex Deucher
On Sun, Apr 27, 2025 at 5:46 AM R Sundar wrote: > > Use string choice helpers for better readability. > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/ > Signed-off-by: R Sundar > --- > > Reported in linux rep

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-24 Thread Alex Deucher
On Wed, Apr 23, 2025 at 10:29 AM Christian König wrote: > > On 4/22/25 18:26, Deucher, Alexander wrote: > > [Public] > > > >> -Original Message----- > >> From: Alex Deucher > >> Sent: Tuesday, April 22, 2025 9:46 AM > >> To: Koenig,

Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Alex Deucher
On Thu, Apr 24, 2025 at 4:49 AM Marek Marczykowski-Górecki wrote: > > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > > > > > But the code would start to become quite

[pull] amdgpu drm-fixes-6.15

2025-04-23 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.15. The following changes since commit 0467145fab3b3a7a1efd221722310fe32329b3da: Merge tag 'drm-msm-fixes-2025-04-18' of https://gitlab.freedesktop.org/drm/msm into drm-fixes (2025-04-19 15:09:29 +1000) are available in the Git repository at: https://gitlab.f

Re: [PATCH RESEND v13 0/5] Expose modifiers/formats supported by async flips

2025-04-23 Thread Alex Deucher
+ Harry and Leo On Wed, Apr 16, 2025 at 2:33 AM Borah, Chaitanya Kumar wrote: > > Hello Alexander, > > > -Original Message- > > From: Murthy, Arun R > > Sent: Monday, April 7, 2025 11:14 AM > > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > > x...@lists.fr

Re: [PATCH] drm/amdgpu/atom: Work around vbios NULL offset false positive

2025-04-22 Thread Alex Deucher
On Tue, Apr 22, 2025 at 10:56 AM Kees Cook wrote: > > On Tue, Apr 22, 2025 at 09:22:26AM -0400, Alex Deucher wrote: > > On Mon, Apr 21, 2025 at 5:59 PM Kees Cook wrote: > > > > > > GCC really does not want to consider NULL (or near-NULL) addresses as > > &

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-22 Thread Alex Deucher
Applied. Thanks! On Tue, Apr 22, 2025 at 5:13 AM Koenig, Christian wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Reviewed-by: Christian König > > > Von: Denis Arefev > Gesendet: Freitag, 18. April 2025 10:31 > An: Deucher, Alex

Re: [PATCH][next] drm/amdgpu: Fix spelling mistake "rounter" -> "rounter"

2025-04-22 Thread Alex Deucher
On Tue, Apr 22, 2025 at 6:33 AM Colin Ian King wrote: > > There is a spelling mistake with the array utcl2_rounter_str, it > appears it should be utcl2_router_str. Fix it. > > Signed-off-by: Colin Ian King Applied with the patch title fixed up. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu/atom: Work around vbios NULL offset false positive

2025-04-22 Thread Alex Deucher
ne way to convince it otherwise, hide vbios_str from > GCC's optimizer to avoid the warning so we can get closer to enabling > -Warray-bounds globally. > > Signed-off-by: Kees Cook Acked-by: Alex Deucher Do you want me to pick this up, or do you want to take this through some oth

Re: [PATCH] drm/amd/pm/powerplay/smumgr/vegam_smumgr: Fix error handling in vegam_populate_smc_boot_level()

2025-04-18 Thread Alex Deucher
On Tue, Apr 15, 2025 at 8:33 AM Wentao Liang wrote: > > In vegam_populate_smc_boot_level(), the return value of > phm_find_boot_level() is 0 or negative error code and the > "if (result)" branch statement will never run into the true > branch. Besides, this will skip setting the voltages later > b

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread Alex Deucher
On Fri, Apr 18, 2025 at 2:18 AM Christophe JAILLET wrote: > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > From: "Dr. David Alan Gilbert" > > > > radeon_doorbell_free() was added in 2013 by > > commit 75efdee11b5d ("drm/radeon: implement simple doorbell page > > allocator") > > but neve

Re: [PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-18 Thread Alex Deucher
Applied patches 1, 3, 4. Thanks! On Thu, Apr 17, 2025 at 8:28 PM wrote: > > From: "Dr. David Alan Gilbert" > > rn_vbios_smu_set_dprefclk() was added in 2019 by > commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") > rv1_vbios_smu_set_dprefclk() was also added in 2019 by > commit d

Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

2025-04-16 Thread Alex Deucher
On Tue, Apr 15, 2025 at 6:23 AM Wentao Liang wrote: > > The return value of fiji_populate_smc_boot_level() is needs to be checked. > An error handling is also needed to phm_find_boot_level() to reset the > boot level when the function fails. A proper implementation can be found > in tonga_populate

[pull] amdgpu drm-fixes-6.15

2025-04-16 Thread Alex Deucher
doorbell free ordering - Video caps fix - DML2 memory allocation optimization - HDP fix Alex Deucher (1): drm/amd/display/dml2: use vzalloc rather than kzalloc Christian König (1): drm/amdgpu: use a dummy owner for sysfs

Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-04-16 Thread Alex Deucher
Can you resend, I can't seem to find the original emails. Additionally, all of the NISLANDS structures are unused in amdgpu, so those could be removed. Alex On Wed, Apr 16, 2025 at 12:48 AM Gustavo A. R. Silva wrote: > > Hi all, > > Friendly ping (second one): who can take this patch, please? 🙂 >

Re: [PATCH v2 2/2] drm/amdgpu: Clean up error handling in amdgpu_userq_fence_driver_alloc()

2025-04-15 Thread Alex Deucher
Applied the series. Thanks! On Mon, Apr 14, 2025 at 12:48 AM Yadav, Arvind wrote: > > Reviewed-by:Arvind Yadav > > On 4/12/2025 8:09 PM, Dan Carpenter wrote: > > 1) Checkpatch complains if we print an error message for kzalloc() > > failure. The kzalloc() failure already has it's own error

Re: [Linaro-mm-sig] [PATCH AUTOSEL 6.13 15/34] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH AUTOSEL 6.14 15/34] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH AUTOSEL 6.12 11/30] drm/amdgpu: allow pinning DMA-bufs into VRAM if all importers can do P2P

2025-04-14 Thread Alex Deucher
7;t do > P2P just pin into GTT instead. > > Acked-by: Simona Vetter > Signed-off-by: Christian König > Signed-off-by: Felix Kuehling > Reviewed-by: Felix Kuehling > Tested-by: Pak Nin Lui > Cc: Simona Vetter > Signed-off-by: Alex Deucher > Signed-off-by: Sasha L

Re: [PATCH RESEND] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Fix wrong return value of fiji_populate_smc_boot_level()

2025-04-14 Thread Alex Deucher
On Mon, Apr 14, 2025 at 3:24 AM Wentao Liang wrote: > > The return value of fiji_populate_smc_boot_level() is always 0, which > represent the failure of the function. The result of phm_find_boot_level() > should be recored and return. An error handling is also needed to > phm_find_boot_level() to

Re: [PATCH v1 3/3] drm/amdgpu: update the error logging for more information

2025-04-11 Thread Alex Deucher
On Fri, Apr 11, 2025 at 9:05 AM Sunil Khatri wrote: > > add process and pid information in the userqueue error > logging to make it more useful in resolving the error > by logs. > > Sample log: > [ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERROR* Timed > out waiting for fence

[pull] amdgpu, amdkfd drm-fixes-6.15

2025-04-09 Thread Alex Deucher
possible division by 0 in fan handling amdkfd: - Queue reset fixes Alex Deucher (5): drm/amdgpu/mes11: optimize MES pipe FW version fetching drm/amdgpu/pm: add workload profile pause helper drm/amdgpu/pm/swsmu: implement

Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

2025-04-08 Thread Alex Deucher
Oh, sorry, I've picked it up now. Thanks! Alex On Tue, Apr 8, 2025 at 4:16 AM Denis Arefev wrote: > > > --- > > drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c > > b/dr

Re: [PATCH] drm/amd/display: Add error check for avi and vendor infoframe setup function

2025-04-07 Thread Alex Deucher
On Mon, Apr 7, 2025 at 8:52 AM Wentao Liang wrote: > > The function fill_stream_properties_from_drm_display_mode() calls the > function drm_hdmi_avi_infoframe_from_display_mode() and the > function drm_hdmi_vendor_infoframe_from_display_mode(), but does > not check its return value. Log the error

Re: [PATCH] drm/amd/display: removed unused function

2025-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 27, 2025 at 11:37 PM James Flowers wrote: > > Removed unused function mpc401_get_3dlut_fast_load_status. > > Signed-off-by: James Flowers > --- > drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 17 - > .../drm/amd/display/dc/mpc/dcn401/dcn40

Re: [PATCH v2 18/57] irqdomain: gpu: Switch to irq_domain_create_linear()

2025-04-05 Thread Alex Deucher
on case to > case basis (by people who can actually test with the HW). > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Simona Vetter > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry B

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-04-05 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 24, 2025 at 8:08 PM Andres Urian Florez wrote: > > Instead of using the strcpy() deprecated function to populate the > fw_name, use the strscpy() function > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy > > Signed-off-by: Andres

Re: [PATCH] Documentation: Remove repeated word in docs

2025-04-05 Thread Alex Deucher
On Thu, Feb 13, 2025 at 2:08 AM Charles Han wrote: > > Remove the repeated word "the" in docs. > > Signed-off-by: Charles Han Applied. Thanks! Alex > --- > Documentation/gpu/amdgpu/display/dc-debug.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gpu

[pull] amdgpu drm-next-6.15

2025-03-27 Thread Alex Deucher
tching fix - MES fixes - Queue reset fix ---- Alex Deucher (2): drm/amdgpu/gfx11: fix num_mec drm/amdgpu/gfx12: fix num_mec Asad Kamal (3): drm/amd/pm: Remove host limit metrics support drm/amd/pm: Update smu metrics

Re: [PATCH] drm/amdgpu: use static ids for ACP platform devs

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 6:07 PM Brady Norander wrote: > > mfd_add_hotplug_devices() assigns child platform devices with > PLATFORM_DEVID_AUTO, but the ACP machine drivers expect the platform > device names to never change. Use mfd_add_devices() instead and give > each cell a unique id. While you

Re: [PATCH] drm/amd/amdgpu: Fix typo

2025-03-25 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 25, 2025 at 4:14 AM AnantaSrikar wrote: > > From: Ananta Srikar > > Fixes a typo in the word "version" in an error message. > > Signed-off-by: Ananta Srikar > > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 9:50 AM Christian König wrote: > > Am 25.03.25 um 14:30 schrieb Alex Deucher: > > On Tue, Mar 25, 2025 at 4:38 AM Christian König > > wrote: > >> Alex shouldn't be try to completely nuke the CGS functions? > > Sure, but it would need

Re: [PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-03-25 Thread Alex Deucher
On Tue, Mar 25, 2025 at 4:38 AM Christian König wrote: > > Alex shouldn't be try to completely nuke the CGS functions? Sure, but it would need to be replaced with something else so I'm not sure it's worth the effort since it's only used by a few older GPUs. Alex > > Christian. > > Am 25.03.25 u

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-21 Thread Alex Deucher
drm/amdgpu/sdam: Skip SDMA queue reset for SRIOV Alex Deucher (14): drm/amdgpu: drop drm_firmware_drivers_only() drm/amdgpu: adjust drm_firmware_drivers_only() handling drm/amdgpu: don't free conflicting apertures for non-display devices drm/amdgpu/gfx: fi

Re: [PATCH 0/5] drm/amd/pm: Prevent division by zero

2025-03-21 Thread Alex Deucher
On Fri, Mar 21, 2025 at 6:53 AM Denis Arefev wrote: > > This series of patches prevents possible division by zero. > > The user can set any speed value. > If speed is greater than UINT_MAX/8, division by zero is possible. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. Appli

[pull] amdgpu, amdkfd, radeon drm-fixes-6.14

2025-03-20 Thread Alex Deucher
d-drm-fixes-6.14-2025-03-20: amdgpu: - Fix video caps limits on several asics - SMU 14.x fixes - GC 12 fixes - eDP fixes - DMUB fix amdkfd: - GC 12 trap handler fix - GC 7/8 queue validation fix radeon: - VCE IB parsing fix Alex De

Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

2025-03-20 Thread Alex Deucher
On Thu, Mar 20, 2025 at 9:11 AM Denis Arefev wrote: > > The user can set any speed value. > If speed is greater than UINT_MAX/8, division by zero is possible. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 1e866f1fe528 ("drm/amd/pm: Prevent divide by zero") > Sign

Re: [PATCH] drm/radeon/uvd: Replace nested max() with single max3()

2025-03-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 18, 2025 at 2:18 AM wrote: > > From: FengWei > > Use max3() macro instead of nesting max() to simplify the return > statement. > > Signed-off-by: FengWei > --- > drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[pull] amdgpu, amdkfd, radeon drm-next-6.15

2025-03-15 Thread Alex Deucher
on cleanup fixes - Retry fault fixes - Dequeue retry timeout adjustments - GC 12.x trap handler fixes - GC 9.5.x updates radeon: - VCE command parser fix ---- Alex Deucher (11): drm/amdgpu/vcn: fix idle work handler for VCN 2.5

Re: [PATCH] drm/amdgpu/gfx12: correct cleanup of 'me' field with gfx_v12_0_me_fini()

2025-03-13 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 12, 2025 at 6:09 AM Wentao Liang wrote: > > In gfx_v12_0_cp_gfx_load_me_microcode_rs64(), gfx_v12_0_pfp_fini() is > incorrectly used to free 'me' field of 'gfx', since gfx_v12_0_pfp_fini() > can only release 'pfp' field of 'gfx'. The release function of 'me' fi

Re: [PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

2025-03-13 Thread Alex Deucher
lt;48> 8b 7f 58 48 89 e6 ba 01 00 00 00 e8 08 3c 2a 00 65 48 8b 04 5 > >> [ 37.904703] RSP: 0018:969442853300 EFLAGS: 00010202 > >> [ 37.909933] RAX: RBX: 92db0300 RCX: > >> 969442853358 > >> [ 37.917068] RDX: 96944285

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-03-12 Thread Alex Deucher
C DCE 6.x fix - Hibernation fix - HPD fix - Backlight fixes - Color depth fix - UAF fix in hdcp_work - VCE 2.x fix - GC 12.x PTE fix amdkfd: - Queue eviction fix Alex Deucher (1): drm/amdgpu/vce2: fix ip block reference Alex

[pull] amdgpu, amdkfd, radeon drm-fixes-6.14

2025-03-11 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 7eb172143d5508b4da468ed59ee857c6e5e01da6: Linux 6.14-rc5 (2025-03-02 11:48:20 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-03-06 for you to fe

Re: [PATCH] drm/amdkfd: delete stray tab in kfd_dbg_set_mes_debug_mode()

2025-03-11 Thread Alex Deucher
Applied. thanks! On Mon, Mar 10, 2025 at 6:48 AM Dan Carpenter wrote: > > These lines are indented one tab more than they should be. Delete > the stray tabs. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 12 ++-- > 1 file changed, 6 insertions(+), 6

Re: [PATCH] drm/amdgpu: Use tabs for indenting in amdgpu_sdma_reset_engine()

2025-03-11 Thread Alex Deucher
Thanks for the patch, but someone already fixed this. Thanks! Alex On Mon, Mar 10, 2025 at 6:47 AM Dan Carpenter wrote: > > This line has a seven space indent instead of a tab. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse()

2025-03-11 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 11, 2025 at 7:23 AM Nikita Zhandarovich wrote: > > On the off chance that command stream passed from userspace via > ioctl() call to radeon_vce_cs_parse() is weirdly crafted and > first command to execute is to encode (case 0x0301), the function > in questi

Re: [PATCH] drm/amdgpu/gfx: delete stray tabs

2025-03-11 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 10, 2025 at 8:18 AM SRINIVASAN SHANMUGAM wrote: > > > On 3/10/2025 4:17 PM, Dan Carpenter wrote: > > These lines are indented one tab too far. Delete the extra tabs. > > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++-- > 1 fil

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-10 Thread Alex Deucher
); > >>>> + } > >>>> + } > >>> Is this guaranteed to be guilty app and not some scheduled worker? > >> > >> This is how amdgpu decides which app is the guilty one earlier in the code > >> as in the print: > >

Re: [PATCH v3] drm/amdgpu: Trigger a wedged event for ring reset

2025-03-10 Thread Alex Deucher
Applied. Thanks On Tue, Mar 4, 2025 at 4:29 AM Christian König wrote: > > Am 25.02.25 um 02:02 schrieb André Almeida: > > Instead of only triggering a wedged event for complete GPU resets, > > trigger for ring resets. Regardless of the reset, it's useful for > > userspace to know that it happen

[pull] amdgpu, amdkfd, radeon, UAPI drm-next-6.15

2025-03-07 Thread Alex Deucher
Hi Dave, Simona, More updates for 6.15. The following changes since commit 7d83c129a8d7df23334d4a35bca9090a26b0a118: drm/amdgpu: Fix parameter annotation in vcn_v5_0_0_is_idle (2025-02-27 16:50:05 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.gi

Re: [PATCH v2] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()

2025-03-06 Thread Alex Deucher
Applied. Thanks On Thu, Mar 6, 2025 at 2:52 AM Wentao Liang wrote: > > Add error handling to propagate amdgpu_cgs_create_device() failures > to the caller. When amdgpu_cgs_create_device() fails, release hwmgr > and return -ENOMEM to prevent null pointer dereference. > > [v1]->[v2]: Change error

Re: [PATCH] drm/amdgpu: fix inconsistent indenting warning

2025-03-05 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 5, 2025 at 5:41 AM Charles Han wrote: > > Fix below inconsistent indenting smatch warning. > smatch warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:582 amdgpu_sdma_reset_engine() warn: > inconsistent indenting > > Signed-off-by: Charles Han > --- > driv

Re: [PATCH] drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create()

2025-03-05 Thread Alex Deucher
On Tue, Mar 4, 2025 at 4:29 AM Wentao Liang wrote: > > Add error handling to propagate amdgpu_cgs_create_device() failures > to the caller. When amdgpu_cgs_create_device() fails, immediately > return -EINVAL to stop further processing and prevent null pointer > dereference. > > Signed-off-by: Went

Re: [PATCH 6/6] drm/amdgpu: Remove unused pqm_get_kernel_queue

2025-03-03 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Mar 3, 2025 at 9:49 AM wrote: > > From: "Dr. David Alan Gilbert" > > pqm_get_kernel_queue() has been unused since 2022's > commit 5bdd3eb25354 ("drm/amdkfd: Remove unused old debugger > implementation") > > Remove it. > > Signed-off-by: Dr. David Alan G

[pull] amdgpu, amdkfd drm-next-6.15

2025-02-28 Thread Alex Deucher
queue size minimum clamping - Drop old pasid handling now that we've unified with amdgpu - GPU reset fixes Alex Deucher (50): drm/amdgpu: disable BAR resize on Dell G5 SE MAINTAINERS: update amdgpu maintainers list

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-02-26 Thread Alex Deucher
fix for DELL G5 SE - MAINTAINERS updates - Enforce Isolation fixes - mailmap update - EDID reading i2c fix - PSR fix - eDP fix - HPD interrupt handling fix - Clear memory fix amdkfd: - MQD handling fix Alex Deucher (4): drm

Re: [PATCH] drm/amdgpu: Create a debug option to disable ring reset

2025-02-26 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 26, 2025 at 8:11 AM André Almeida wrote: > > Prior to the addition of ring reset, the debug option > `debug_disable_soft_recovery` could be used to force a full device > reset. Now that we have ring reset, create a debug option to disable > them in amdgpu, forcing th

Re: [PATCH v2] drm/amd/display: Fix null check for pipe_ctx->plane_state in resource_build_scaling_params

2025-02-26 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Feb 26, 2025 at 2:04 PM Alex Hung wrote: > > Reviewed-by: Alex Hung > > On 2/26/25 01:37, Ma Ke wrote: > > Null pointer dereference issue could occur when pipe_ctx->plane_state > > is null. The fix adds a check to ensure 'pipe_ctx->plane_state' is not > > null bef

Re: [PATCH][next] drm/amdgpu: Fix spelling mistake "initiailize" -> "initialize" and grammar

2025-02-26 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 26, 2025 at 4:13 AM Zhou1, Tao wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Reviewed-by: Tao Zhou > > > -Original Message- > > From: Colin Ian King > > Sent: Wednesday, February 26, 2025 4:58 PM > > To: Deucher, Alexander ; Koenig

Re: [PATCH] drm/amd/display: Remove unused optc3_fpu_set_vrr_m_const

2025-02-25 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 24, 2025 at 8:43 AM wrote: > > From: "Dr. David Alan Gilbert" > > The last use of optc3_fpu_set_vrr_m_const() was removed in 2022's > commit 64f991590ff4 ("drm/amd/display: Fix a compilation failure on PowerPC > caused by FPU code") > which removed the only ca

Re: [PATCH v4] drm/amd/display/dc: Refactor remove duplications

2025-02-25 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 24, 2025 at 8:55 PM Luan Icaro Pinto Arcanjo wrote: > > From: Luan Arcanjo > > All dce command_table_helper's shares a copy-pasted collection > of copy-pasted functions, which are: phy_id_to_atom, > clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom

Re: [PATCH v2 2/3] drm/amdgpu: Log after a successful ring reset

2025-02-21 Thread Alex Deucher
Applied. Thanks! On Thu, Feb 20, 2025 at 11:28 AM André Almeida wrote: > > When a ring reset happens, the kernel log shows only "amdgpu: Starting > ring reset", but when it finishes nothing appears in the > log. Explicitly write in the log that the reset has finished correctly. > > Reviewed-by:

[pull] amdgpu, amdkfd, UAPI drm-next-6.15

2025-02-21 Thread Alex Deucher
Proposed userspace: https://github.com/ROCm/amdsmi/commit/e663bed7d6b3df79f5959e73981749b1f22ec698 ---- Alex Deucher (33): drm/amd/display/dm: drop extra parameters to create_i2c() drm/amd/display/dm: drop hw_suppor

Re: [PATCH][next] drm/amd/display: Fix spelling mistake "oustanding" -> "outstanding"

2025-02-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 17, 2025 at 5:48 AM Colin Ian King wrote: > > There is a spelling mistake in max_oustanding_when_urgent_expected, > fix it. > > Signed-off-by: Colin Ian King > --- > .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 6 +++--- > .../dc/dml2/dml21/s

Re: [PATCH v2] drm/amd/display: restore edid reading from a given i2c adapter

2025-02-21 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 21, 2025 at 3:48 PM Alex Hung wrote: > > Reviewed-by: Alex Hung > > On 2/15/25 14:15, Melissa Wen wrote: > > When switching to drm_edid, we slightly changed how to get edid by > > removing the possibility of getting them from dc_link when in aux > > transactio

Re: [PATCH] drm/amdgpu: Remove unused nbif_v6_3_1_sriov_funcs

2025-02-21 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 19, 2025 at 4:48 PM wrote: > > From: "Dr. David Alan Gilbert" > > The nbif_v6_3_1_sriov_funcs instance of amdgpu_nbio_funcs was added in > commit 894c6d3522d1 ("drm/amdgpu: Add nbif v6_3_1 ip block support") > but has remained unused. > > Alex has confirmed it wasn'

Re: [PATCH] drm/radeon: Add error handlings for r420 cp errata initiation

2025-02-21 Thread Alex Deucher
On Thu, Feb 20, 2025 at 1:41 AM Wentao Liang wrote: > > In r420_cp_errata_init(), the RESYNC information is stored even > when the Scratch register is not correctly allocated. > > Change the return type of r420_cp_errata_init() from void to int > to propagate errors to the caller. Add error checki

Re: [PATCH v2 1/3] drm/amdgpu: Log the creation of a coredump file

2025-02-21 Thread Alex Deucher
Applied, thanks! Alex On Thu, Feb 20, 2025 at 11:28 AM André Almeida wrote: > > After a GPU reset happens, the driver creates a coredump file. However, > the user might not be aware of it. Log the file creation the user can > find more information about the device and add the file to bug reports

Re: missing wire up of nbif_v6_3_1_sriov_funcs ?

2025-02-19 Thread Alex Deucher
On Wed, Feb 19, 2025 at 3:00 PM Dr. David Alan Gilbert wrote: > > * Alex Deucher (alexdeuc...@gmail.com) wrote: > > On Wed, Feb 19, 2025 at 2:04 PM Dr. David Alan Gilbert > > wrote: > > > > > > Hi All, > > > I think you may be misisng some wiring

Re: missing wire up of nbif_v6_3_1_sriov_funcs ?

2025-02-19 Thread Alex Deucher
On Wed, Feb 19, 2025 at 2:04 PM Dr. David Alan Gilbert wrote: > > Hi All, > I think you may be misisng some wiring of nbif_v6_3_1_sriov_funcs. > > My scripts noticed 'nbif_v6_3_1_sriov_funcs' was unused; > It was added in: > Commit: 894c6d3522d1 ("drm/amdgpu: Add nbif v6_3_1 ip block support

Re: [PATCH] drm/amd/display: Disable -Wenum-float-conversion for dml2_dpmm_dcn4.c

2025-02-14 Thread Alex Deucher
On Fri, Feb 14, 2025 at 11:28 AM Nathan Chancellor wrote: > > On Thu, Dec 19, 2024 at 05:21:41PM -0500, Alex Deucher wrote: > > On Thu, Dec 19, 2024 at 12:23 PM Nathan Chancellor > > wrote: > > > > > > Commit be4e3509314a ("drm/amd/display: DML21 Rei

Re: [PATCH] drm/radeon/ci_dpm: Remove needless NULL checks of dpm tables

2025-02-13 Thread Alex Deucher
On Thu, Feb 13, 2025 at 12:03 PM Nikita Zhandarovich wrote: > > Gentle ping :) Was already applied: https://gitlab.freedesktop.org/agd5f/linux/-/commit/189abca05a89fc7b422811e497a7116b3e4f4dca Thanks, Alex > > On 1/14/25 16:58, Nikita Zhandarovich wrote: > > This patch removes useless NULL poi

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-02-13 Thread Alex Deucher
andler fix ---- Alex Deucher (3): drm/amdgpu/pm: fix UVD handing in amdgpu_dpm_set_powergating_by_smu() drm/amdgpu/gfx9: manually control gfxoff for CS on RV drm/amdgpu: bump version for RV/PCO compute fix Jiang Liu (2): drm/amdgpu: bail out when failed to

Re: [PATCH v12 2/2] drm/amdgpu: Enable async flip on overlay planes

2025-02-12 Thread Alex Deucher
Acked-by: Alex Deucher for the series. On Thu, Feb 6, 2025 at 5:37 PM Harry Wentland wrote: > > > > On 2025-01-27 14:59, André Almeida wrote: > > amdgpu can handle async flips on overlay planes, so allow it for atomic > > async checks. > > > > Signed-of

Re: [PATCH v3] drm/amd/display/dc: Refactor remove duplications on command_table files

2025-02-11 Thread Alex Deucher
On Fri, Feb 7, 2025 at 6:13 PM Luan Icaro Pinto Arcanjo wrote: > > From: Luan Arcanjo > > All dce command_table_helper's shares a copy-pasted collection > of copy-pasted functions, which are: phy_id_to_atom, > clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom. > > This patch removes t

[pull] amdgpu drm-fixes-6.14

2025-02-05 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b: Linux 6.14-rc1 (2025-02-02 15:39:26 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-02-05 for you to fe

Re: [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations

2025-02-04 Thread Alex Deucher
On Tue, Feb 4, 2025 at 8:37 AM Christian König wrote: > > Hi Friedrich, > > adding Alex. > > Am 04.02.25 um 13:32 schrieb Friedrich Vock: > > Hi, > > > > On 19.08.24 13:21, Christian König wrote: > >> Am 19.08.24 um 09:21 schrieb Friedrich Vock: > >>> In Vulkan, it is the application's responsibil

Re: [PATCH 0/7] drm/amd/display: More deadcoding

2025-02-03 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Feb 2, 2025 at 5:08 PM wrote: > > From: "Dr. David Alan Gilbert" > > Another small pile of deadcode patches. > > Signed-off-by: Dr. David Alan Gilbert > > > Dr. David Alan Gilbert (7): > drm/amd/display: Remove unused mpc1_is_mpcc_idle > drm/amd/display: Remo

Re: [PATCH] drm/amd/display: Respect user's CONFIG_FRAME_WARN more for dml files

2025-02-03 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 31, 2025 at 5:38 PM Nathan Chancellor wrote: > > Currently, there are several files in drm/amd/display that aim to have a > higher -Wframe-larger-than value to avoid instances of that warning with > a lower value from the user's configuration. However, with the

[pull] amdgpu, amdkfd drm-fixes-6.14

2025-01-29 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14. The following changes since commit 64179a1416e1420a34226ab3beb5f84710953d16: Merge tag 'drm-misc-next-fixes-2025-01-24' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-next (2025-01-24 17:06:06 +0100) are available in the Git repository at: htt

Re: [PATCH] drm/amd/display: restore invalid MSA timing check for freesync

2025-01-28 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jan 28, 2025 at 10:03 AM Harry Wentland wrote: > > > > On 2025-01-27 19:41, Melissa Wen wrote: > > This restores the original behavior that gets min/max freq from EDID and > > only set DP/eDP connector as freesync capable if "sink device is capable > > of rendering

  1   2   3   4   5   6   7   8   9   10   >