Re: [PATCH] drm/panel: himax-hx83112a: transition to mipi_dsi wrapped functions

On Wed, Sep 11, 2024 at 09:41:30AM +0200, neil.armstr...@linaro.org wrote: > On 10/09/2024 23:19, Doug Anderson wrote: > > Hi, > > > > On Sat, Sep 7, 2024 at 1:32 AM Tejas Vipin wrote: > > > > > > On 9/7/24 3:53 AM, Jessica Zhang wrote: > > > > > > > > > > > > On 9/6/2024 3:14 PM, Jessica Zhan

Re: [PATCH] drm/panel: himax-hx83112a: transition to mipi_dsi wrapped functions

On Tue, Sep 10, 2024 at 02:19:53PM -0700, Doug Anderson wrote: > Hi, > > On Sat, Sep 7, 2024 at 1:32 AM Tejas Vipin wrote: > > > > On 9/7/24 3:53 AM, Jessica Zhang wrote: > > > > > > > > > On 9/6/2024 3:14 PM, Jessica Zhang wrote: > > >> > > >> > > >> On 9/4/2024 7:15 AM, Tejas Vipin wrote: > > >

Re: [PATCH v2] drm/panel: hx83112a: Transition to wrapped mipi_dsi functions

Hi Doug, Thanks for the feedback. On Tue, Sep 10, 2024 at 02:22:37PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 3, 2024 at 10:32 AM Abhishek Tamboli > wrote: > > > > Transition to mipi_dsi_dcs_write_seq_multi() macros for initialization > > sequences. The p

[PATCH v2] drm/panel: hx83112a: Transition to wrapped mipi_dsi functions

://lore.kernel.org/oe-kbuild-all/202409040049.2hf8jrzg-...@intel.com/ Signed-off-by: Abhishek Tamboli --- Changes in v2: - Update the commit message to explain the reason for the change. - Correct the code by changing 'dsi->mode_flags' to 'dsi_ctx.dsi->mode_flags' This change add

Re: [PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions

On Tue, Sep 03, 2024 at 11:17:37AM +0200, Javier Martinez Canillas wrote: > Abhishek Tamboli writes: > Hi Javier, > > > Use the new mipi_dsi_*_multi wrapped function in hx83112a_on > > and hx83112a_disable function. > IMO commit messages should explain why the change

[PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions

Use the new mipi_dsi_*_multi wrapped function in hx83112a_on and hx83112a_disable function. Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/panel/panel-himax-hx83112a.c | 136 --- 1 file changed, 58 insertions(+), 78 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH] drm/panel: nv3051d: Transition to mipi_dsi_dcs_write_seq_multi

Replace deprecated 'mipi_dsi_dcs_write_seq()' macro to 'mipi_dsi_dcs_write_seq_multi' macro in panel_nv3051d_init_sequence function. Signed-off-by: Abhishek Tamboli --- .../gpu/drm/panel/panel-newvision-nv3051d.c | 367 +- 1 file changed, 184 insertio

Re: [PATCH] drm/panel: mantix: Transition to multi-context write sequence

//lore.kernel.org/dri-devel/172414629205.2571141.13215409630895562248.b4...@linaro.org/#t > Hi Guido, Thanks for letting me know. Regards, Abhishek > > On Mon, Aug 26, 2024 at 09:33:28PM +0530, Abhishek Tamboli wrote: > > Replace deprecated 'mipi_dsi_generic_write_seq()' macro > > to 'mi

[PATCH] drm/panel: mantix: Transition to multi-context write sequence

Replace deprecated 'mipi_dsi_generic_write_seq()' macro to 'mipi_dsi_generic_write_seq_multi()' macro in mantix_init_sequence function. Signed-off-by: Abhishek Tamboli --- .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 19 +++ 1 file changed, 11 insert

[PATCH v2] drm/panel: ili9341: Add comments for registers in ili9341_config()

Add detail comments for registers definitions in struct ili9341_config(). Replace TODO with comment for each registers. Signed-off-by: Abhishek Tamboli --- Changes in v2: - Rephrased the commit message. drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++--- 1 file changed, 7

Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register

Hi, Neil Thanks for the feedback. On Mon, Aug 19, 2024 at 05:41:07PM +0200, neil.armstr...@linaro.org wrote: > On 12/08/2024 19:10, Abhishek Tamboli wrote: > > TODO : Add missing comments for ILI9341 register definition. > > Please rephrase the commit message, and explain why in a

[PATCH] drm/panel: ili9341: Add comments for ILI9341 register

TODO : Add missing comments for ILI9341 register definition. Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel

[PATCH] drm/amd/display: Fix documentation warning for mpc.h

Fix documentation compile warning by adding description for program_3dlut_size function. Remove the following warning: ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1043: warning: Function parameter or struct member 'program_3dlut_size' not described in 'mpc_funcs' Sig

Re: [PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h

On Mon, Jul 15, 2024 at 05:46:38PM -0400, Aurabindo Pillai wrote: > > > On 7/12/24 1:45 PM, Abhishek Tamboli wrote: > > Add detail description for the read_mpcc_state function in the > > mpc_funcs struct to resolve the documentation warning. > > > > A

[PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h

'mpc_funcs'. Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h index 34a398f23fc6..9e65ecf1d3b0

[PATCH] drm: Add documentation for struct drm_plane_size_hint members

Add descriptions for 'width' and 'height' members in struct drm_plane_size_hint to improve clarity and documentation coverage. Signed-off-by: Abhishek Tamboli --- include/uapi/drm/drm_mode.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/drm/drm_mode.