Hi Doug, Thanks for the feedback.
On Tue, Sep 10, 2024 at 02:22:37PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 3, 2024 at 10:32 AM Abhishek Tamboli > <abhishektambo...@gmail.com> wrote: > > > > Transition to mipi_dsi_dcs_write_seq_multi() macros for initialization > > sequences. The previous mipi_dsi_dcs_write_seq() macros were > > non-intuitive and use other wrapped MIPI DSI functions in the > > driver code to simplify the code pattern. > > > > Reported-by: kernel test robot <l...@intel.com> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202409040049.2hf8jrzg-...@intel.com/ > > You'd only include the above two tags if the original problematic > commit had actually landed. Since it didn't you leave them off and the > Robot gets no credit (even though it is awesome). Sure, I will keep this in mind before sending the next patch. > > > Signed-off-by: Abhishek Tamboli <abhishektambo...@gmail.com> > > --- > > Changes in v2: > > - Update the commit message to explain the reason for the change. > > - Correct the code by changing 'dsi->mode_flags' to > > 'dsi_ctx.dsi->mode_flags' > > This change addresses a build error in v1 reported by kernel test robot > > caused by using an undeclared variable 'dsi'. > > [v1] : > > https://lore.kernel.org/all/20240902170153.34512-1-abhishektambo...@gmail.com/ > > > > drivers/gpu/drm/panel/panel-himax-hx83112a.c | 140 ++++++++----------- > > 1 file changed, 60 insertions(+), 80 deletions(-) > > Just adding a note that there's nearly the same patch in > https://lore.kernel.org/r/20240904141521.554451-1-tejasvipi...@gmail.com > and we're discussing what to do about it there. > Regards, Abhishek
