[PATCH][next] drm/nouveau: outp: Use __member_size() helper

2025-04-22 Thread Gustavo A. R. Silva
Use __member_size() to get the size of the flex-array member at compile time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/nvif/outp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH][next] drm/nouveau: disp: Use __member_size() helper

2025-04-22 Thread Gustavo A. R. Silva
Use __member_size() to get the size of the flex-array member at compile time, instead of the convoluted expression `__struct_size(p) - sizeof(*p)` Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-04-22 Thread Gustavo A. R. Silva
On 16/04/25 09:04, Alex Deucher wrote: Can you resend, I can't seem to find the original emails. Additionally, all of the NISLANDS structures are unused in amdgpu, so those could be removed. Okay, I'll take a look. Thanks -Gustavo

[PATCH v2][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-16 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the

Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-04-15 Thread Gustavo A. R. Silva
Hi all, Friendly ping (second one): who can take this patch, please? 🙂 Thanks! -Gustavo On 11/03/25 02:10, Gustavo A. R. Silva wrote: Hi all, Friendly ping: who can take this, please? :) Thanks! -- Gustavo On 14/02/25 18:48, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was

Re: [PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-11 Thread Gustavo A. R. Silva
On 08/04/25 17:40, Kees Cook wrote: On Mon, Apr 07, 2025 at 05:35:47PM -0600, Gustavo A. R. Silva wrote: [..] - struct { - struct nvif_chan_v0 chan; - char name[TASK_COMM_LEN+16]; - } args; + DEFINE_RAW_FLEX(struct nvif_chan_v0, args, name

Re: [PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-10 Thread Gustavo A. R. Silva
On 07/04/25 13:50, Kees Cook wrote: On Thu, Apr 03, 2025 at 10:45:18AM -0600, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions of a flexible

Re: [PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-07 Thread Gustavo A. R. Silva
2"? i.e. isn't struct nv_device_info_v1::count the counted_by for struct nv_device_info_v1::data? Yes, it's just `2`. However, I didn't want to explicitly use the magic number, in case people don't like it, as in other similar patches (in other subsystems). But, yeah, it&#

[PATCH v2][next] drm/nouveau: disp: Avoid -Wflex-array-member-not-at-end warning

2025-04-05 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

[PATCH v2][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-04 Thread Gustavo A. R. Silva
/nouveau/nvif/fifo.c:29:42: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Adjust heap allocation instead of using the DEFINE_RAW_FLEX() helper. - Link: https

Re: [PATCH][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-04 Thread Gustavo A. R. Silva
On 03/04/25 11:41, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known

[PATCH][next] drm/nouveau: fifo: Avoid -Wflex-array-member-not-at-end warning

2025-04-03 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

Re: [PATCH v2][next] drm/nouveau: disp: Avoid -Wflex-array-member-not-at-end warning

2025-04-03 Thread Gustavo A. R. Silva
Applied this one (as well as the svm and fence one) to drm-misc-next, thanks! Awesome. :) Thanks! -- Gustavo

[PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-03 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the

[PATCH][next] drm/nouveau: svm: Avoid -Wflex-array-member-not-at-end warning

2025-04-02 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

[PATCH][next] drm/nouveau: fence: Avoid -Wflex-array-member-not-at-end warning

2025-04-02 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

[PATCH v2][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

Re: [PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
On 28/03/25 09:05, Danilo Krummrich wrote: On Fri, Mar 28, 2025 at 08:45:32AM -0600, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a

[PATCH][next] drm/nouveau/conn: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

[PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code

Re: [PATCH v3] arm64: defconfig: mediatek: enable PHY drivers

2025-03-15 Thread Nícolas F . R . A . Prado
ut that's just so you know in the future, you don't need to send a new version just for that. > > Fixes: 924d66011f24 ("drm/mediatek: stop selecting foreign drivers") > Signed-off-by: Vignesh Raman Reviewed-by: Nícolas F. R. A. Prado Thanks, Nícolas

Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

2025-03-12 Thread Nícolas F . R . A . Prado
fig. > > --- > arch/arm64/configs/defconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 1f25423de383..87e8cbd3fd26 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/

Re: [PATCH v1] arm64: defconfig: mediatek: enable PHY drivers

2025-03-11 Thread Nícolas F . R . A . Prado
14-rc4, with the following errors: > > > > Which boards? > > These are the boards, > https://lava.pages.collabora.com/docs/boards/chromebooks/boards/hana/ > https://lava.pages.collabora.com/docs/boards/chromebooks/boards/jacuzzi/ You can use the Devicetree name to identify th

Re: [PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-03-11 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? :) Thanks! -- Gustavo On 14/02/25 18:48, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. So, in order to avoid ending up with a flexible-array member in the

[PATCH 2/2] drm/bridge: ti-sn65dsi83: add h/vsync-disable support

2025-03-06 Thread A. Zini
level or ground. Signed-off-by: Alessandro Zini --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 95563aa1b450d..c94ea92159402 100644

[PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: add h/vsync-disable bindings

2025-03-06 Thread A. Zini
From: Alessandro Zini Add hsync- and vsync-disable bindings, used to disable the generation of h/vsync signals. Signed-off-by: Alessandro Zini --- .../bindings/display/bridge/ti,sn65dsi83.yaml| 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree

[PATCH 0/2] Introduce h/vsync-disable properties for ti-sn65dsi83

2025-03-06 Thread A. Zini
From: Alessandro Zini This patch series adds support for disabling the generation of h/vsync signals on the ti-sn65dsi83 bridge. This is required on some panels which are driven in DE-only mode but do not ignore sync packets, and instead require them to be low-voltage level or ground. A

Re: [PATCH v2 0/2] Add driver for Himax HX8279 DriverIC panels

2025-03-04 Thread Nícolas F . R . A . Prado
t by CJ > > This series adds a driver for DSI panels using the Himax HX8279 and > HX8279-D DriverICs, and introduces one panel using such a configuration, > the Startek KX070FHFID078. > > This panel is found on the latest hardware revisions of some MediaTek > Genio Evalu

Re: [PATCH][next] drm/nouveau: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-02-27 Thread Gustavo A. R. Silva
> Applied to drm-misc-next, thanks! Awesome. :) Thank you, guys. -- Gustavo

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-27 Thread James A. MacInnes
On Thu, 13 Feb 2025 01:58:06 +0200 Dmitry Baryshkov wrote: > On Thu, Feb 13, 2025 at 12:41:02AM +0100, Marijn Suijten wrote: > > On 2025-02-12 15:03:46, James A. MacInnes wrote: > > > SDM845 DPU hardware is rev 4.0.0 per hardware documents. > > > Original patch to en

[PATCH][next] drm/amd/pm: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-02-14 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. So, in order to avoid ending up with a flexible-array member in the middle of other structs, we use the `struct_group_tagged()` helper to create a new tagged `struct NISLANDS_SMC_SWSTATE_HDR

[PATCH v2 0/2] drm/msm/dp: Fix Type-C Timing

2025-02-12 Thread James A. MacInnes
: Added comments to explain use of wide_bus_en. Increased verbosity of commit message. Verified functionality on SDM845 using Lantronix SOM. Tested with Type-C to DisplayPort and Dell Monitor. Tested with Type-C hub with HDMI to Samsung 4k TV. James A. MacInnes (2): drm/msm/dp

[PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings. - Re-used wide_bus_en as flag to prevent porch shifting Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: James A. MacInnes --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_

[PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread James A. MacInnes
: c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets") Signed-off-by: James A. MacInnes --- drivers/gpu/drm/msm/dp/dp_display.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_displ

[PATCH][next] drm/nouveau: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-02-12 Thread Gustavo A. R. Silva
/nouveau/nvif/object.c:60:38: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] drivers/gpu/drm/nouveau/nvif/object.c:233:38: warning: structure containing a flexible array member is not at the end of another structure [-Wflex

Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG_reclaim

2025-02-03 Thread Kirill A. Shutemov
On Sat, Feb 01, 2025 at 04:01:43PM +0800, Kairui Song wrote: > On Thu, Jan 30, 2025 at 6:02 PM Kirill A. Shutemov > wrote: > > > > The recently introduced PG_dropbehind allows for freeing folios > > immediately after writeback. Unlike PG_reclaim, it does not need vmscan &

Re: [PATCHv2 11/11] mm: Rename PG_dropbehind to PG_reclaim

2025-01-17 Thread Kirill A. Shutemov
On Wed, Jan 15, 2025 at 10:18:16PM -0800, Christoph Hellwig wrote: > On Wed, Jan 15, 2025 at 11:31:35AM +0200, Kirill A. Shutemov wrote: > > Now as PG_reclaim is gone, its name can be reclaimed for better > > use :) > > > > Rename PG_dropbehind to PG_reclaim and r

Re: [PATCHv2 05/11] mm/truncate: Use folio_set_dropbehind() instead of deactivate_file_folio()k

2025-01-17 Thread Kirill A. Shutemov
On Wed, Jan 15, 2025 at 02:46:44PM -0700, Yu Zhao wrote: > On Wed, Jan 15, 2025 at 2:35 PM Matthew Wilcox wrote: > > > > On Wed, Jan 15, 2025 at 11:31:29AM +0200, Kirill A. Shutemov wrote: > > > -static void lru_deactivate_file(struct lruvec *lruvec, st

Re: [PATCH 8/8] mm: Remove PG_reclaim

2025-01-14 Thread Kirill A. Shutemov
On Mon, Jan 13, 2025 at 03:28:43PM +, Matthew Wilcox wrote: > On Mon, Jan 13, 2025 at 11:34:53AM +0200, Kirill A. Shutemov wrote: > > diff --git a/mm/migrate.c b/mm/migrate.c > > index caadbe393aa2..beba72da5e33 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c &

Re: [PATCH 4/8] mm/swap: Use PG_dropbehind instead of PG_reclaim

2025-01-14 Thread Kirill A. Shutemov
On Mon, Jan 13, 2025 at 08:17:20AM -0800, Yosry Ahmed wrote: > On Mon, Jan 13, 2025 at 1:35 AM Kirill A. Shutemov > wrote: > > > > The recently introduced PG_dropbehind allows for freeing folios > > immediately after writeback. Unlike PG_reclaim, it does not need vmscan &

Re: [PATCH 0/8] mm: Remove PG_reclaim

2025-01-13 Thread Kirill A. Shutemov
On Mon, Jan 13, 2025 at 01:45:48PM +, Matthew Wilcox wrote: > On Mon, Jan 13, 2025 at 11:34:45AM +0200, Kirill A. Shutemov wrote: > > Use PG_dropbehind instead of PG_reclaim and remove PG_reclaim. > > I was hoping we'd end up with the name PG_reclaim instead of the

[PATCH v5 2/2] leds: lp8864: New driver

2024-12-18 Thread A. Sverdlin
ed, 316 insertions(+) create mode 100644 drivers/leds/leds-lp8864.c diff --git a/MAINTAINERS b/MAINTAINERS index b332995b3350..d4268a3bbc5a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23322,6 +23322,13 @@ S: Supported F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml F:

[PATCH v5 1/2] dt-bindings: backlight: add TI LP8864/LP8866 LED-backlight drivers

2024-12-18 Thread A. Sverdlin
From: Alexander Sverdlin Add bindings for Texas Instruments' LP8864/LP8866 LED-backlight drivers. Note that multiple channels in these models are used for load-balancing and brightness is controlled gobally, so from a user perspective it's only one LED. Reviewed-by: Rob Herring (Ar

[PATCH v5 0/2] leds: TI LP8864/LP8866 support

2024-12-18 Thread A. Sverdlin
From: Alexander Sverdlin The series adds support for a family of Texas Instruments' automotive high-efficiency LED drivers with boost controller. The four or six high-precision current sinks support phase shifting that is automatically adjusted based on the number of channels in use

[PATCH v4 2/2] leds: lp8864: New driver

2024-12-17 Thread A. Sverdlin
vers/leds/leds-lp8864.c diff --git a/MAINTAINERS b/MAINTAINERS index b332995b3350..d4268a3bbc5a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23322,6 +23322,13 @@ S: Supported F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml F: drivers/iio/dac/ti-dac7612.c +TEXAS INST

[PATCH v4 1/2] dt-bindings: backlight: add TI LP8864/LP8866 LED-backlight drivers

2024-12-17 Thread A. Sverdlin
From: Alexander Sverdlin Add bindings for Texas Instruments' LP8864/LP8866 LED-backlight drivers. Note that multiple channels in these models are used for load-balancing and brightness is controlled gobally, so from a user perspective it's only one LED. Reviewed-by: Rob Herring (Ar

[PATCH v4 0/2] leds: TI LP8864/LP8866 support

2024-12-17 Thread A. Sverdlin
From: Alexander Sverdlin The series adds support for a family of Texas Instruments' automotive high-efficiency LED drivers with boost controller. The four or six high-precision current sinks support phase shifting that is automatically adjusted based on the number of channels in use

[PATCH v3 1/2] dt-bindings: backlight: add TI LP8864/LP8866 LED-backlight drivers

2024-12-09 Thread A. Sverdlin
From: Alexander Sverdlin Add bindings for Texas Instruments' LP8864/LP8866 LED-backlight drivers. Note that multiple channels in these models are used for load-balancing and brightness is controlled gobally, so from a user perspective it's only one LED. Signed-off-by: Alexande

[PATCH v3 0/2] leds: TI LP8864/LP8866 support

2024-12-09 Thread A. Sverdlin
From: Alexander Sverdlin The series adds support for a family of Texas Instruments' automotive high-efficiency LED drivers with boost controller. The four or six high-precision current sinks support phase shifting that is automatically adjusted based on the number of channels in use

[PATCH v3 2/2] leds: lp8864: New driver

2024-12-09 Thread A. Sverdlin
+ drivers/leds/Kconfig | 12 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-lp8864.c | 308 + 4 files changed, 328 insertions(+) create mode 100644 drivers/leds/leds-lp8864.c diff --git a/MAINTAINERS b/MAINTAINERS index 21f855fe468bc..a89f0b9d991fb

[PATCH v2 1/2] dt-bindings: backlight: add TI LP8864/LP8866 LED-backlight drivers

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add bindings for Texas Instruments' LP8864/LP8866 LED-backlight drivers. Note that multiple channels in these models are used for load-balancing and brightness is controlled gobally, so from a user perspective it's only one LED. Signed-off-by: Alexande

[PATCH v2 2/2] leds: lp8864: New driver

2024-12-06 Thread A. Sverdlin
.c diff --git a/MAINTAINERS b/MAINTAINERS index 21f855fe468bc..a89f0b9d991fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23262,6 +23262,13 @@ S: Supported F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml F: drivers/iio/dac/ti-dac7612.c +TEXAS INSTRUMENTS' LB886

[PATCH v2 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin The series adds support for a family of Texas Instruments' automotive high-efficiency LED drivers with boost controller. The four or six high-precision current sinks support phase shifting that is automatically adjusted based on the number of channels in use

[PATCH 2/2] leds: lp8864: New driver

2024-12-06 Thread A. Sverdlin
--- MAINTAINERS| 7 + drivers/leds/Kconfig | 12 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-lp8864.c | 320 + 4 files changed, 340 insertions(+) create mode 100644 drivers/leds/leds-lp8864.c diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread A. Sverdlin
From: Alexander Sverdlin Add new DT compatible ti,lp8864 to support all four software-compatible devices: - LP8864 - LP8864S - LP8866 - LP8866S This is a new family with a functionality similar to LP8860 -- hence the same (re-used) DT bindings. They had to be converted to YAML along the way

[PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread A. Sverdlin
les changed, 86 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/backlight/ti,lp8860.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-lp8860.txt diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,lp8860.yaml b/Documenta

Re: [PATCH] drm: display: Set fwnode for aux bus devices

2024-10-23 Thread Nícolas F . R . A . Prado
On Wed, Oct 23, 2024 at 12:13:36PM -0700, Saravana Kannan wrote: > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you'll see error > messages like this when the supplier has probed and tries to make sure &g

Re: [PATCH 2/2] drm/vc4: Stop the active perfmon before being destroyed

2024-10-04 Thread Juan A.
Worth to mention we got this issue happened also for v3d (a fix was already submitted). Reviewed-by: Juan A. Suarez On Fri, 2024-10-04 at 09:36 -0300, Maíra Canal wrote: > Upon closing the file descriptor, the active performance monitor is > not > stopped. Although all perfmons are

Re: [PATCH 1/2] drm/vc4: Use `vc4_perfmon_find()`

2024-10-04 Thread Juan A.
Reviewed-by: Juan A. Suarez On Fri, 2024-10-04 at 09:35 -0300, Maíra Canal wrote: > Similar to commit f2a4bcb25328 ("drm/v3d: Use v3d_perfmon_find()"), > replace the open-coded `vc4_perfmon_find()` with the real thing. > > Cc: Christian Gmeiner > Signed-off-by: Maír

Re: [PATCH] drm/v3d: Stop the active perfmon before being destroyed

2024-10-04 Thread Juan A.
Good catch! Reviewed-by: Juan A. Suarez

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-10-03 Thread Gustavo A. R. Silva
Yes, it's not great, but I think it's better than having the length in two places. Agreed. I'll respin. :) Thanks -- Gustavo

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-10-03 Thread Gustavo A. R. Silva
On 03/10/24 12:36, Danilo Krummrich wrote: On 9/13/24 12:23 PM, Danilo Krummrich wrote: Hi, On 9/13/24 10:09 AM, Gustavo A. R. Silva wrote: Hi all, Friendly ping: who can take this, please? 🙂 Usually, that's me. But I thought you might want to send a v2 based on Kees' comm

Re: [PATCH v3 00/19] random: Resolve circular include dependency and include

2024-09-30 Thread Jason A. Donenfeld
Hi Uros, Per your plan, I took this into random.git, and we'll now see if being in next unearths some problems over the next week or two. Jason

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-09-13 Thread Gustavo A. R. Silva
Hi all, Friendly ping: who can take this, please? 🙂 Thanks -Gustavo On 21/08/24 22:16, Gustavo A. R. Silva wrote: Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
x; } // error > > void *bar(void __as(1) *x) { return (void *)x; } // fine > --cut here-- > > When compiling this, the compiler returns: > > clang-as.c:3:37: error: returning '__as(1) void *' from a function > with result type 'void *' changes addre

Re: [PATCH RESEND v2 00/19] random: Resolve circular include dependency and include

2024-09-09 Thread Jason A. Donenfeld
Hi Uros, On Mon, Sep 09, 2024 at 09:53:43AM +0200, Uros Bizjak wrote: > a) Substitutes the inclusion of with the > inclusion of where needed (patches 1 - 17). > > b) Removes legacy inclusion of from > (patch 18). > > c) Includes in (patch 19). Thanks for doing th

Re: [PATCH v3 5/5] soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function

2024-08-30 Thread Nícolas F . R . A . Prado
mdq_pkt_finalize() have been switched to cmdq_pkt_eoc() and cmdq_pkt_jump_rel() for more fine-grained control, remove cmdq_pkt_finalize(). > > Signed-off-by: Chun-Kuang Hu Reviewed-by: Nícolas F. R. A. Prado Thanks, Nícolas

Re: [PATCH v3 4/5] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-08-30 Thread Nícolas F . R . A . Prado
> 1 file changed, 4 insertions(+), 41 deletions(-) > > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c > b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c > index 0cddafedbecc..48432d60b49a 100644 > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-c

Re: [PATCH v4 3/3] arm64: dts: mediatek: mt8186: Add svs node

2024-08-30 Thread Nícolas F . R . A . Prado
On Fri, Aug 30, 2024 at 08:45:44AM +, Rohit Agarwal wrote: > Add clock/irq/efuse setting in svs nodes for mt8186 SoC. > > Signed-off-by: Rohit Agarwal Reviewed-by: Nícolas F. R. A. Prado Although FWIW the SVS driver fails to probe as is, as for MT8186 it expects "cpu-big

Re: [PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-08-27 Thread Gustavo A. R. Silva
On 22/08/24 11:27, Kees Cook wrote: On Wed, Aug 21, 2024 at 02:16:21PM -0600, Gustavo A. R. Silva wrote: Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the

Re: [PATCH v3 3/3] arm64: dts: mediatek: mt8186: Add svs node

2024-08-22 Thread Nícolas F . R . A . Prado
On Thu, Aug 22, 2024 at 06:46:50AM +, Rohit Agarwal wrote: > Add clock/irq/efuse setting in svs nodes for mt8186 SoC. > > Signed-off-by: Rohit Agarwal > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 20 > 1 file changed, 20 insertions(+) > >

[PATCH][next] drm/nouveau: Avoid -Wflex-array-member-not-at-end warning

2024-08-21 Thread Gustavo A. R. Silva
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, accordingly. So, with this, fix the following warning: drivers/gpu/drm/nouveau/dispnv50/disp.c:779:47

[PATCH v2] drm/mediatek: Log errors in probe with dev_err_probe()

2024-06-06 Thread Nícolas F . R . A . Prado
Use dev_err_probe() to log errors in the probe function of all drm mediatek drivers. This avoids -EPROBE_DEFER return values from being logged as errors, like the following: mediatek-disp-rdma 1c002000.rdma: Failed to add component: -517 As a side benefit it also standardizes the format of the

Re: [PATCH v4 0/3] drm/mediatek: Add support for OF graphs

2024-06-06 Thread Nícolas F . R . A . Prado
On Thu, May 16, 2024 at 10:11:01AM +0200, AngeloGioacchino Del Regno wrote: > Changes in v4: > - Fixed a typo that caused pure OF graphs pipelines multiple >concurrent outputs to not get correctly parsed (port->id); > - Added OVL_ADAPTOR support for OF graph specified pipe

[PATCH] drm/mediatek: Don't print error if EDEFER_PROBE returned on component_add

2024-06-05 Thread Nícolas F . R . A . Prado
update them all. Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +- drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 +- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 2 +- drivers/gpu/drm

[PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses

2024-04-19 Thread A
ses around 'devcode != 0x' + if ((devcode != 0x) && (devcode != 0x9320)) Signed-off-by: Ashok Kumar --- drivers/staging/fbtft/fb_ili9320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbt

Re: [PATCH] staging: fbtft Removed redundant parentheses

2024-04-17 Thread A
On Wed, 2024-04-17 at 09:07 +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 16, 2024 at 01:14:52PM -0700, A wrote: > > > From 6dbcb120581fc7cb45812193227b0a197abd8ba4 Mon Sep 17 00:00:00 > > > 2001 > > From: Ashok Kumar > > Date: Tue, 16 Apr 2024 09:19:32 -0700 >

[PATCH] staging: fbtft Removed redundant parentheses

2024-04-17 Thread A
rs/staging/fbtft/fb_ssd1325.c | 2 -- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fbtft-bus.c | 6 +++--- drivers/staging/fbtft/fbtft-core.c | 7 +-- 6 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_

[PATCH v3 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Suggested-by: AngeloGioacchino Del Regno Reviewed-by

[PATCH v3 7/9] drm/bridge: dpc3433: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Also move the "failed to attach" error messa

[PATCH v3 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 623a3531e9cf ("drm/panel: Add drive

[PATCH v3 6/9] drm/bridge: tc358775: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: b26975593b17 ("display/drm/bridge: TC35877

[PATCH v3 5/9] drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 0cbbd5b1a012 ("drm: bridge: add suppor

[PATCH v3 4/9] drm/bridge: lt9611: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 23278bf54afe ("drm/bridge: Introduce LT961

[PATCH v3 3/9] drm/bridge: lt8912b: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT

[PATCH v3 2/9] drm/bridge: icn6211: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Ad

[PATCH v3 0/9] drm: Switch from dev_err to dev_err_probe for missing DSI host error path

2024-04-15 Thread Nícolas F . R . A . Prado
and prevents errors to be spammed in the kernel log every time the driver retries to probe, unnecessarily alerting userspace about something that is a normal part of the boot process. I have omitted a Fixes: tag in the last patch, for the truly-nt35597 panel, because it predates the dev_err_probe()

[PATCH v3 1/9] drm/bridge: anx7625: Don't log an error when DSI host can't be found

2024-04-15 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 269332997a16 ("drm/bridge: anx7625: R

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-08 Thread guomengqi (A)
n() before drm_dev_put() should solve the problem. Note that vkms exit code is refactored by 53d77aaa3f76 ("drm/vkms: Use devm_drm_dev_alloc") in tags/v5.10-rc1. So this bug only exists on 4.19 and 5.4. Do we also need this for 5.4? If so, can you send a version for that tree wi

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-03 Thread guomengqi (A)
在 2024/3/29 17:57, Greg KH 写道: On Thu, Mar 21, 2024 at 03:55:37PM +0800, guomengqi (A) wrote: 在 2024/3/21 15:39, Greg KH 写道: On Thu, Mar 21, 2024 at 03:07:52PM +0800, Guo Mengqi wrote: commit 73a82b22963d ("drm/atomic: Fix potential use-after-free in nonblocking commits")

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-03-21 Thread guomengqi (A)
n() before drm_dev_put() should solve the problem. Fixes: 73a82b22963d ("drm/atomic: Fix potential use-after-free in nonblocking commits") Signed-off-by: Guo Mengqi --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
On Thu, Mar 21, 2024 at 02:08:59AM +0800, Chen-Yu Tsai wrote: > On Thu, Mar 21, 2024 at 1:59 AM Nícolas F. R. A. Prado > wrote: > > > > On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Mar 20, 2024 at 1

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote: > Hi, > > On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote: > > I noticed that there are some commits from drm-misc-next [1] that haven't > > been > > added to the for-linux-n

Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
3b8864 ("dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat") which have been applied almost a month ago [3]. I noticed because running 'make dtbs_check' on today's next is showing new warnings, but with these commits applied there shouldn't be any warn

Re: [PATCH v2 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found

2024-03-08 Thread Nícolas F . R . A . Prado
On Fri, Mar 01, 2024 at 09:44:51AM +0100, AngeloGioacchino Del Regno wrote: > Il 01/03/24 01:12, Nícolas F. R. A. Prado ha scritto: > > Given that failing to find a DSI host causes the driver to defer probe, > > make use of dev_err_probe() to log the reason. This makes the defer &

Re: [PATCH v2 0/9] drm: Switch from dev_err to dev_err_probe for missing DSI host error path

2024-03-01 Thread Nícolas F . R . A . Prado
On Fri, Mar 01, 2024 at 08:34:31AM +0200, Laurent Pinchart wrote: > Hi Nícolas, > > On Thu, Feb 29, 2024 at 07:12:06PM -0500, Nícolas F. R. A. Prado wrote: > > This series changes every occurence of the following pattern: > > > > dsi_host = of_find_mipi_dsi_ho

[PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found

2024-02-29 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Suggested-by: AngeloGioacchino Del Regno Signed-off

[PATCH v2 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found

2024-02-29 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 623a3531e9cf ("drm/panel: Add drive

[PATCH v2 7/9] drm/bridge: dpc3433: Don't log an error when DSI host can't be found

2024-02-29 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Also move the "failed to attach" error messa

[PATCH v2 6/9] drm/bridge: tc358775: Don't log an error when DSI host can't be found

2024-02-29 Thread Nícolas F . R . A . Prado
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: b26975593b17 ("display/drm/bridge: TC35877

  1   2   3   4   5   6   7   8   9   10   >