Re: [PATCH 0/8] DRM Rust abstractions

2025-04-10 Thread Asahi Lina
On 4/11/25 9:43 AM, Dave Airlie wrote: >> >>> However, I understand that you prefer to have primary authorship, even if >>> the >>> code has been re-organized in new commits, moved, modified or rewritten. >> >> Correct. > > For anyone working in this area that is intending to upstream anything >

Re: [PATCH v3 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-10 Thread Geert Uytterhoeven
On Wed, 9 Apr 2025 at 16:16, Javier Martinez Canillas wrote: > Marcus Folkesson writes: > > On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote: > > [...] > > >> > >> Likely you will need to define more stuff to be specific for each entry, > >> maybe > >> you will need diffe

Re: [PATCH 01/19] drm: Pass pixel_format+modifier to .get_format_info()

2025-04-10 Thread Ville Syrjälä
On Thu, Apr 10, 2025 at 10:27:45PM +0300, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the patch. > > On Thu, Apr 10, 2025 at 07:32:00PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Decouple .get_format_info() from struct drm_mode_fb_cmd2 and just > > pass the pixel form

Re: [PATCH 04/19] drm: Pass the format info to .fb_create()

2025-04-10 Thread Geert Uytterhoeven
On Thu, 10 Apr 2025 at 18:33, Ville Syrjala wrote: > From: Ville Syrjälä > > Pass long the format information from the top to .fb_create() s/long/along/ > so that we can avoid redundant (and somewhat expensive) lookups > in the drivers. [...] > Signed-off-by: Ville Syrjälä > drivers/gpu/dr

Re: [PATCH v3 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-10 Thread Marcus Folkesson
Hello, On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote: > Marcus Folkesson writes: > > Hello Marcus, > > [...] > > >> > >> That's a god question, I don't really know... > >> > >> But fbdev does support XRGB, which may be another good reason to add > >> it and mak

[PATCH 2/2] drm/i915/backlight: Modify condition to use panel luminance

2025-04-10 Thread Suraj Kandpal
According to our internal spec we need to now check if both panel luminance and smooth brightness are available in panel for us to be able to change brightness using luminance value. --v2 -Add Fixes tag [Ankit] Fixes: 64481497924d ("drm/i915/backlight: Check Luminance based brightness control fo

[PATCH 1/2] drm/dp: Add smooth brightness register bit definition

2025-04-10 Thread Suraj Kandpal
Add DP_EDP_SMOOTH_BRIGHTNESS register bit definition for EDP_GENERAL_CAPABILITY 2 register. --v2 -Add eDP 2.0 comment [Ankit] Signed-off-by: Suraj Kandpal Reviewed-by: Arun R Murthy --- include/drm/display/drm_dp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/display/drm_dp.

[PATCH 0/2] Register bit definition for EDP_GENERAL_CAP2

2025-04-10 Thread Suraj Kandpal
Add smooth brightness register bit definition for register EDP_GENERAL_CAPABILITY 2 Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/dp: Add smooth brightness register bit definition drm/i915/backlight: Modify condition to use panel luminance drivers/gpu/drm/i915/display/intel_dp_aux_ba

Re: [PATCH v3 00/11] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE)

2025-04-10 Thread Amirreza Zarrabi
On 4/9/2025 6:30 PM, neil.armstr...@linaro.org wrote: > On 28/03/2025 03:47, Amirreza Zarrabi wrote: >> This patch series introduces a Trusted Execution Environment (TEE) >> driver for Qualcomm TEE (QTEE). QTEE enables Trusted Applications (TAs) >> and services to run securely. It uses an object

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Herbert Xu
On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: > > added crypto maintainers for comments. > IMO, as accel framework is designed to support any type of compute > accelerators, the PKI crypto accelerator in accel framework is not > completely out of place here, as also suggested at: >

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Gupta, Nipun
On 10-04-2025 13:06, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact with the device for offloading and accelerating asymmetric crypto operations. For me this is clearly a crypto dri

[PATCH 09/13] drm/dp: Change argument type of drm_edp_backlight_enable

2025-04-10 Thread Suraj Kandpal
Change the argument type to u32 for the default level being sent since it has to now account for luminance value which has to be set for DP_EDP_PANEL_LUMINANCE_TARGET_VALUE. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 6 +++--- drivers/gpu/drm/nouveau/dispnv50/disp

[PATCH 08/13] drm/dp: Modify drm_edp_backlight_set_level

2025-04-10 Thread Suraj Kandpal
Modify drm_edp_backlight_set_level to be able to set the value for register in DP_EDP_PANEL_TARGET_LUMINANCE_VALUE. We multiply the level with 1000 since we get the value in Nits and the register accepts it in milliNits. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c |

[PATCH 12/13] drm/i915/backlight: Use drm helper to set edp backlight

2025-04-10 Thread Suraj Kandpal
Now that the drm helper sets the backlight using luminance too we can use that. Remove the obselete function. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 34 ++- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/i9

[PATCH 11/13] drm/i915/backlight: Use drm helper to initialize edp backlight

2025-04-10 Thread Suraj Kandpal
Now that drm_edp_backlight init has been to be able to setup brightness manipulation via luminance we can just use that. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 100 +- 1 file changed, 49 insertions(+), 51 deletions(-) diff --git a/driver

[PATCH 05/13] drm/dp: Change current_level argument type to u32

2025-04-10 Thread Suraj Kandpal
Change the current_level argument type to u32 from u16 since it can now carry the value which it gets from DP_EDP_PANEL_TARGET_LUMINANCE_VALUE. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c |

[PATCH 13/13] drm/i915/backlight: Use drm_edp_backlight_enable

2025-04-10 Thread Suraj Kandpal
Use drm dp helper to enable backlight now that it has been modified to set PANEL_LUMINANCE_CONTROL_ENABLE bit based on if capability supports it and the driver wants it. Remove the dead code. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 14 --

[PATCH 07/13] drm/dp: Change argument type for drm_edp_backlight_set_level

2025-04-10 Thread Suraj Kandpal
Use u32 for level variable as one may need to pass value for DP_EDP_PANEL_TARGET_LUMINANCE_VALUE. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 6 +++--- include/drm/display/drm_dp_helper.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 01/13] drm/dp: Introduce new member in drm_backlight_info

2025-04-10 Thread Suraj Kandpal
Introduce luminance_set flag which indicates if we can manipulate backlight using luminance value or not which is only possible after eDP v1.5. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 8 ++-- include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 7

[PATCH 10/13] drm/dp: Enable backlight control using luminance

2025-04-10 Thread Suraj Kandpal
Add flag to enable brightness control via luminance value when enabling edp backlight. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.

[PATCH 06/13] drm/dp: Modify drm_edp_probe_state

2025-04-10 Thread Suraj Kandpal
Modify drm_edp_probe_state to read current level from DP_EDP_PANEL_TARGET_LUMINANCE_VALUE. We divide it by 1000 since the value in this register is in millinits. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 35 ++--- 1 file changed, 25 insertions

[PATCH 03/13] drm/dp: Add argument for luminance range info in drm_edp_backlight_init

2025-04-10 Thread Suraj Kandpal
Add new argument to drm_edp_backlight_init which gives the drm_luminance_range_info struct which will be needed to set the min and max values for backlight. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 5 - drivers/gpu/drm/i915/display/intel_dp_aux

[PATCH 04/13] drm/dp: Move from u16 to u32 for max in drm_edp_backlight_info

2025-04-10 Thread Suraj Kandpal
Use u32 instead of u16 for max variable in drm_edp_backlight_info since it can now hold max luminance range value which is u32. We will set this max with max_luminance value when luminance_set is true. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 10 +++--- incl

[PATCH 02/13] drm/dp: Add argument in drm_edp_backlight_init

2025-04-10 Thread Suraj Kandpal
Add bool argument in drm_edp_backlight init to provide the drivers option to choose if they want to use luminance values to manipulate brightness. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/display/drm_dp_helper.c | 7 --- drivers/gpu/drm/i915/display/intel_dp_aux_backlig

[PATCH 00/13] Modify drm helpers to use luminance

2025-04-10 Thread Suraj Kandpal
This series modifies drm dp edp helpers so that drivers can now use them to manipulate brightness using luminance value via the PANEL_TARGET_LUMINANCE_VALUE register. This feature was introduced frin eDP 1.5. Signed-off-by: Suraj Kandpal Suraj Kandpal (13): drm/dp: Introduce new member in drm_

RE: [PATCH 1/3] mm: Export vmf_insert_mixed_mkwrite()

2025-04-10 Thread Michael Kelley
From: Christoph Hellwig Sent: Thursday, April 10, 2025 12:42 AM > > On Wed, Apr 09, 2025 at 02:10:26PM +, Michael Kelley wrote: > > Hmmm. What's the reference to "as told last time"? I don't think I've had > > this conversation before. > > Hmm, there was a conversation about deferred I/O, an

Re: [git pull] drm fixes for 6.15-rc2

2025-04-10 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Apr 2025 12:58:55 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-04-11-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/900241a5cc15e6e0709a012051cc72d224cd6a6e Thank you! -- Deet-doot-dot, I am a bot.

[git pull] drm fixes for 6.15-rc2

2025-04-10 Thread Dave Airlie
Hi Linus, Weekly fixes, as expected it has a bit more in it than probably usual for rc2. amdgpu/xe/i915 lead the way with fixes all over for a bunch of other drivers. Nothing major stands out from what I can see. Regards, Dave. drm-fixes-2025-04-11-1: drm fixes for 6.15-rc2 tests: - Clean up st

[PATCH -next] drm/sched: Remove duplicate linux/atomic.h header

2025-04-10 Thread Jiapeng Chong
./drivers/gpu/drm/scheduler/tests/sched_tests.h: linux/atomic.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=20293 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/scheduler/tests/sched_tests.h | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH v9 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-04-10 Thread Yongbang Shi
Gracious ping for this series, it's been posted over 10 days. Baihan, Thanks. From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v8 -> v9: - modify the adaptation of hibmc_dp_link_reduce_rate(). - fix the le

Re: [PATCH] drm/msm: Convert comma to semicolon

2025-04-10 Thread Dmitry Baryshkov
On Thu, Apr 10, 2025 at 10:52:21AM +0800, Chen Ni wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. >

[PATCH v2 0/9] drm/udl: Support adapters without vendor firmware descriptor

2025-04-10 Thread Thomas Zimmermann
Fallback to default values for devices without vendor firmware descriptor. Enables support for such devices. Since we're at it, improve the descriptor parser. Patches 1 to 3 do some cleanups for the driver. Patches 4 to 8 rewrite the parser code for the vendor firmware descriptor. It's now more c

Re: [PATCH v3 3/3] drm/appletbdrm: use %p4cl instead of %p4cc

2025-04-10 Thread Andy Shevchenko
On Mon, Apr 07, 2025 at 07:07:54PM +0530, Aditya Garg wrote: > From: Aditya Garg > > Due to lack of a proper printk format, %p4cc was being used instead of s/printk format/format specifier/ That's basically the term (`man printf`) everybody knows. > %p4cl for the purpose of printing FourCCs. B

Re: [PATCH 0/8] DRM Rust abstractions

2025-04-10 Thread Dave Airlie
> > > However, I understand that you prefer to have primary authorship, even if > > the > > code has been re-organized in new commits, moved, modified or rewritten. > > Correct. For anyone working in this area that is intending to upstream anything from asahi, I think if code is rewritten complet

Re: [PATCH v2 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-04-10 Thread Dmitry Baryshkov
On 09/04/2025 01:29, Aleksandrs Vinarskis wrote: On Tue, 1 Apr 2025 at 02:55, Dmitry Baryshkov wrote: On Wed, Mar 12, 2025 at 12:38:04AM +0100, Aleksandrs Vinarskis wrote: DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR close

Re: Need Help Enabling HDMI on Debix Model A

2025-04-10 Thread Tarang Raval
> On Thu, Apr 10, 2025 at 11:33:08AM +, Tarang Raval wrote: > > > On Thu, Apr 10, 2025 at 08:13:17AM +, Tarang Raval wrote: > > > > > On Mon, Apr 07, 2025 at 02:06:35PM +, Tarang Raval wrote: > > > > > > > On Mon, Apr 07, 2025 at 11:10:23AM +, Tarang Raval wrote: > > > > > > > > Hi

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-04-10 Thread Sumit Garg
On Tue, Apr 01, 2025 at 02:26:59PM +0200, Jens Wiklander wrote: > On Tue, Apr 1, 2025 at 12:13 PM Sumit Garg wrote: > > > > + MM folks to seek guidance here. > > > > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: > > > Hi Sumit, > > > > > > On Tue, Mar 25, 2025 at 8:42 AM Sumit Ga

Re: [PATCH v7 01/12] mtd: core: always create master device

2025-04-10 Thread Miquel Raynal
Hello, > The mtd_master is completely different class to avoid mtd tree disturbances. > It is real kernel device object, I'm not sure how we can do 'link to' > magic here. Maybe we can add that later if someone needs. > About MTD_PARTITIONED_MASTER - we can treat it as another partition and > c

[PATCH v2 8/8] MAINTAINERS: add DRM Rust source files to DRM DRIVERS

2025-04-10 Thread Danilo Krummrich
Add the DRM Rust source files to the DRM DRIVERS maintainers entry. Signed-off-by: Danilo Krummrich --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 96b827049501..a975fa8d262f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7798,6 +7798,7 @@ F:

[PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina DRM GEM is the DRM memory management subsystem used by most modern drivers; add a Rust abstraction for DRM GEM. This includes the BaseObject trait, which contains operations shared by all GEM object classes. Signed-off-by: Asahi Lina [ Rework of GEM object abstractions * s

[PATCH v2 6/8] rust: drm: file: Add File abstraction

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Reviewed-by: Maxime Ripard Signed-off-by: Asahi Lina [ Rework

[PATCH v2 5/8] rust: drm: add DRM driver registration

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina Implement the DRM driver `Registration`. The `Registration` structure is responsible to register and unregister a DRM driver. It makes use of the `Devres` container in order to allow the `Registration` to be owned by devres, such that it is automatically dropped (and the DRM dri

[PATCH v2 4/8] rust: drm: add device abstraction

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina Implement the abstraction for a `struct drm_device`. A `drm::Device` creates a static const `struct drm_driver` filled with the data from the `drm::Driver` trait implementation of the actual driver creating the `drm::Device`. Reviewed-by: Maxime Ripard Signed-off-by: Asahi Lin

[PATCH v2 3/8] rust: drm: add driver abstractions

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina Implement the DRM driver abstractions. The `Driver` trait provides the interface to the actual driver to fill in the driver specific data, such as the `DriverInfo`, driver features and IOCTLs. Reviewed-by: Maxime Ripard Signed-off-by: Asahi Lina [ Remove unnecessary DRM featu

[PATCH v2 2/8] rust: drm: ioctl: Add DRM ioctl abstraction

2025-04-10 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the abstractio

[PATCH v2 1/8] drm: drv: implement __drm_dev_alloc()

2025-04-10 Thread Danilo Krummrich
In the Rust DRM device abstraction we need to allocate a struct drm_device. Currently, there are two options, the deprecated drm_dev_alloc() (which does not support subclassing) and devm_drm_dev_alloc(). The latter supports subclassing, but also manages the initial reference through devres for the

[PATCH v2 0/8] DRM Rust abstractions

2025-04-10 Thread Danilo Krummrich
This is the series for the initial DRM Rust abstractions, including DRM device / driver, IOCTL, File and GEM object abstractions. Compared to the original work from Lina, the patches in this series contain the following modifications. - "rust: drm: ioctl: Add DRM ioctl abstraction" * wrap

[PATCH 3/4] drm/mediatek: Add mipi dsi driver for mt8196

2025-04-10 Thread Bincai Liu
Add dsi and mipi phy driver for mt8196. Signed-off-by: Bincai Liu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 + drivers/gpu/drm/mediatek/mtk_dsi.c| 248 +++--- drivers/phy/mediatek/Makefile | 1 + .../phy/mediatek/phy-mtk-mipi-dsi-mt8196.c

[PATCH 1/3] media: renesas: vsp1: Name nested structure in vsp1_drm

2025-04-10 Thread Laurent Pinchart
The vsp1_drm structure defines an anonymous nested structure to store per-input data. In preparation for extending that structure, give it a name and is it through the driver. This improves code readability. Signed-off-by: Laurent Pinchart --- drivers/media/platform/renesas/vsp1/vsp1_drm.c | 18

[PATCH 0/3] drm: rcar-du: Support plane color space properties

2025-04-10 Thread Laurent Pinchart
Hello, This small patch series builds on top of the R-Car VSP1 color space support ("[PATCH 0/6] media: renesas: vsp1: Add colorspace support", posted as [1]) to implement the KMS plane color space properties in the R-Car DU driver. The first two patches add support to specify plane color encodin

[PATCH 3/3] drm: rcar-du: Create plane color properties

2025-04-10 Thread Laurent Pinchart
Now that the VSP1 driver allows setting per-plance color encoding and color range for its DRM pipeline, create the corresponding DRM properties in the DU driver and wire them to the VSP. This completes support for plane color space. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/renesas/rca

[PATCH 2/3] media: renesas: vsp1: Expose color space through the DRM API

2025-04-10 Thread Laurent Pinchart
Now that the VSP1 driver supports color spaces, expose them through the API used by the DU driver. This allows configuring the YCbCr encoding and quantization used by each plane, ensuring correct color rendering. Signed-off-by: Laurent Pinchart --- drivers/media/platform/renesas/vsp1/vsp1_drm.c

Re: [PATCH] drm/v3d: Fix Indirect Dispatch configuration for V3D 7.1.6 and later

2025-04-10 Thread Maíra Canal
Hi Iago, On 10/04/25 03:02, Iago Toral wrote: Reviewed-by: Iago Toral Quiroga Applied to misc/kernel.git (drm-misc-fixes). Best Regards, - Maíra El mié, 09-04-2025 a las 17:50 -0300, Maíra Canal escribió: This commit is a resubmission of commit 1fe1c66274fb ("drm/v3d: Fix Indirect Dispat

Re: [PATCH 1/2] drm/vmwgfx: Update last_read_seqno under the fence lock

2025-04-10 Thread Maaz Mombasawala
On 4/10/25 12:55, Ian Forbes wrote: > There was a possible race in vmw_update_seqno. Because of this race it > was possible for last_read_seqno to go backwards. Remove this function > and replace it with vmw_update_fences which now sets and returns the > last_read_seqno while holding the fence lock

[PATCH v6 14/18] drm/imagination: Add RISC-V firmware processor support

2025-04-10 Thread Matt Coster
From: Sarah Walker Newer PowerVR GPUs (such as the BXS-4-64 MC1) use a RISC-V firmware processor instead of the previous MIPS or META. The current version of this patch depends on a patch[1] which exists in drm-misc-fixes, but has not yet made it back to drm-misc-next (the target of this patch).

Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests

2025-04-10 Thread Maxime Ripard
On Tue, Apr 01, 2025 at 07:47:16AM +0530, Vignesh Raman wrote: > On 28/03/25 20:40, Maxime Ripard wrote: > > On Thu, Mar 27, 2025 at 09:31:12PM +0530, Vignesh Raman wrote: > > > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool. > > > > > > Signed-off-by: Vignesh Raman > > > ---

Re: [PATCH v2 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

2025-04-10 Thread Marcus Folkesson
Hi Thomas, Thank you for your review and feedback! On Mon, Apr 07, 2025 at 10:30:28AM +0200, Thomas Zimmermann wrote: > Hi > > Am 04.04.25 um 15:50 schrieb Marcus Folkesson: > > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller. > > The controller has a SPI, I2C and 8bit parallel in

[PATCH] drm/sysfb: efidrm: Avoid clang -Wsometimes-uninitialized in efidrm_device_create()

2025-04-10 Thread Nathan Chancellor
Clang warns (or errors with CONFIG_WERROR=y): drivers/gpu/drm/sysfb/efidrm.c:353:11: error: variable 'screen_base' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] 353 | else if (mem_flags & EFI_MEMORY_WB) | ^~~

[PATCH 4/4] drm/msm/mdss: Get HBB dynamically, if available

2025-04-10 Thread Konrad Dybcio
From: Konrad Dybcio The Highest Bank address Bit value can change based on memory type used. Attempt to retrieve it dynamically, and fall back to a reasonable default (the one used prior to this change) on error. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 35 +++

[PATCH v2 13/15] drm: renesas: rz-du: mipi_dsi: Add function pointers for configuring VCLK and mode validation

2025-04-10 Thread Prabhakar
From: Lad Prabhakar Introduce `dphy_conf_clks` and `dphy_mode_clk_check` callbacks in `rzg2l_mipi_dsi_hw_info` to configure the VCLK and validate supported display modes. On the RZ/V2H(P) SoC, the DSI PLL dividers need to be as accurate as possible. To ensure compatibility with both RZ/G2L and R

[PATCH v3 1/2] mm/kmap: Add kmap_local_page_try_from_panic()

2025-04-10 Thread Jocelyn Falempe
kmap_local_page() can be unsafe to call from a panic handler, if CONFIG_HIGHMEM is set, and the page is in the highmem zone. So add kmap_local_page_try_from_panic() to handle this case. Suggested-by: Simona Vetter Reviewed-by: Thomas Gleixner Signed-off-by: Jocelyn Falempe --- v3: * Add a com

[PATCH v6 16/18] drm/imagination: Add support for TI AM68 GPU

2025-04-10 Thread Matt Coster
Since we already added a generic compatible string for all IMG Rogue GPUs ("img,img-rogue"), all that's needed here is to link the appropriate firmware for the BXS-4-64 GPU in the AM68. Signed-off-by: Matt Coster Reviewed-by: Frank Binns --- Changes in v6: - Add Frank's Rb - Link to v5: https:/

Re: [6.13.6 stable regression?] Nouveau reboot failure in r535_gsp_msg_recv()

2025-04-10 Thread David Woodhouse
On Tue, 2025-04-08 at 16:30 +, Timur Tabi wrote: > On Tue, 2025-04-08 at 17:21 +0100, David Woodhouse wrote: > > If I set the BIOS to use the external display at boot time, that works > > and Linux starts booting using the USB-C monitor — until nouveau inits, > > at which point it stops working

[PATCH v4 3/3] drm/appletbdrm: use %p4cl instead of %p4cc

2025-04-10 Thread Aditya Garg
From: Aditya Garg Due to lack of a proper format specifier, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Aditya Ga

[PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-04-10 Thread Luca Ceresoli
Add a basic KUnit test for the newly introduced drm_bridge_alloc(). Signed-off-by: Luca Ceresoli --- Changed in v7: - rebase on current drm-misc-next, which now has a drm_bridge_test.c file - cleanup commit message Changed in v6: - update to new devm_drm_bridge_alloc() API - remove drm_tes

[PATCH] drm/msm/dpu: drop rogue intr_tear_rd_ptr values

2025-04-10 Thread Dmitry Baryshkov
The commit 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1") shifted IRQ indices by 1, making 'NO_IRQ' to be 0 rather than -1 (and allowing to skip the definition if the IRQ is not present). Several platform files were sketched before that commit, but got applied afterwards. As such, they inheri

[PATCH v2 08/15] drm: renesas: rz-du: mipi_dsi: Use VCLK for HSFREQ calculation

2025-04-10 Thread Prabhakar
From: Lad Prabhakar Update the RZ/G2L MIPI DSI driver to calculate HSFREQ using the actual VCLK rate instead of the mode clock. The relationship between HSCLK and VCLK is: vclk * bpp <= hsclk * 8 * lanes Retrieve the VCLK rate using `clk_get_rate(dsi->vclk)`, ensuring that HSFREQ accurately

Re: [PATCH 07/19] drm/gem: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-04-10 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.15-rc1 next-20250410] [cannot apply to drm-exynos/exynos-drm-next tegra/for-next rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes] [If your patch is

[PATCH v6 1/4] drm/panthor: Introduce BO labeling

2025-04-10 Thread Adrián Larumbe
Add a new character string Panthor BO field, and a function that allows setting it from within the driver. Driver takes care of freeing the string when it's replaced or no longer needed at object destruction time, but allocating it is the responsibility of callers. Signed-off-by: Adrián Larumbe

Re: [PATCH v4 01/13] bitops: Change parity8() to parity_odd() with u64 input and bool return type

2025-04-10 Thread Kuan-Wei Chiu
On Wed, Apr 09, 2025 at 12:59:14PM -0400, Yury Norov wrote: > On Wed, Apr 09, 2025 at 11:43:44PM +0800, Kuan-Wei Chiu wrote: > > Redesign the parity8() helper as parity_odd(), changing its input type > > from u8 to u64 to support broader use cases and its return type from > > int to bool to clearly

Re: [PATCH 0/8] DRM Rust abstractions

2025-04-10 Thread Asahi Lina
On 4/9/25 4:17 AM, Danilo Krummrich wrote: > On Wed, Apr 09, 2025 at 03:06:38AM +0900, Asahi Lina wrote: >> On 4/9/25 2:04 AM, Danilo Krummrich wrote: >>> On Wed, Apr 09, 2025 at 01:29:35AM +0900, Asahi Lina wrote: On 3/26/25 8:54 AM, Danilo Krummrich wrote: >>> >>> You said "use it/submit

Re: [PATCH V1] accel/amdxdna: Fix incorrect size of ERT_START_NPU commands

2025-04-10 Thread Falkowski, Maciej
On 4/9/2025 11:00 PM, Lizhi Hou wrote: When multiple ERT_START_NPU commands are combined in one buffer, the buffer size calculation is incorrect. Also, the condition to make sure the buffer size is not beyond 4K is also fixed. Fixes: aac243092b70 ("accel/amdxdna: Add command execution") Signed-

Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero

2025-04-10 Thread Denis Arefev
> --- > drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c > index 189c6a32b6bd..54229b991858 100644 > --- a/drivers/gpu/drm/amd/p

[PATCH v8 06/23] drm/mediatek: hdmi: Use regmap instead of iomem for main registers

2025-04-10 Thread AngeloGioacchino Del Regno
From: Guillaume Ranquet In preparation for the addition of a new version of the HDMI IP which will need to share its iospace between multiple subdrivers, and in preparation for moving out the common bits between the two, migrate this driver to fully use regmap. Signed-off-by: Guillaume Ranquet

Re: [PATCH RFC 4/9] drm/amd/pm: Avoid open-coded use of ratelimit_state structure's internals

2025-04-10 Thread Paul E. McKenney
On Mon, Apr 07, 2025 at 02:35:59PM +, Deucher, Alexander wrote: > [Public] > > > -Original Message- > > From: Paul E. McKenney > > Sent: Thursday, April 3, 2025 5:15 PM > > To: linux-ker...@vger.kernel.org > > Cc: kernel-t...@meta.com; Paul E. McKenney ; kernel > > test robot ; Feng,

[PATCH 0/2] Register bit definition for EDP_GENERAL_CAP2

2025-04-10 Thread Suraj Kandpal
Add smooth brightness register bit definition for register EDP_GENERAL_CAPABILITY 2 Signed-off-by: Suraj Kandpal Suraj Kandpal (2): drm/dp: Add smooth brightness register bit definition drm/i915/backlight: Modify condition to use panel luminance drivers/gpu/drm/i915/display/intel_dp_aux_ba

[PATCH 5/5] drm/nouveau: Remove waitque for sched teardown

2025-04-10 Thread Philipp Stanner
struct nouveau_sched contains a waitque needed to prevent drm_sched_fini() from being called while there are still jobs pending. Doing so so far would have caused memory leaks. With the new memleak-free mode of operation switched on in drm_sched_fini() by providing the callback nouveau_sched_fence

Re: [PATCH 4/4] backlight: ktz8866: add definitions to make it more readable

2025-04-10 Thread Daniel Thompson
On Mon, Apr 07, 2025 at 05:51:19PM +0800, Pengyu Luo wrote: > LSB, MSB and their handling are slightly confused, so improve it. > > Signed-off-by: Pengyu Luo > --- > drivers/video/backlight/ktz8866.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/ba

[PATCH v8 11/23] drm/mediatek: mtk_hdmi: Use dev_err_probe() in mtk_hdmi_dt_parse_pdata()

2025-04-10 Thread AngeloGioacchino Del Regno
Change error prints to use dev_err_probe() instead of dev_err() where possible in function mtk_hdmi_dt_parse_pdata(), used only during device probe. While at it, also beautify some prints. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 31

Re: [PATCH v6 3/4] drm/panthor: Label all kernel BO's

2025-04-10 Thread Liviu Dudau
On Wed, Apr 09, 2025 at 10:22:21PM +0100, Adrián Larumbe wrote: > Kernel BO's aren't exposed to UM, so labelling them is the responsibility > of the driver itself. This kind of tagging will prove useful in further > commits when want to expose these objects through DebugFS. > > Expand panthor_kern

Re: [PATCH v3] drm: Fix potential overflow issue in event_string array

2025-04-10 Thread Raag Jadav
On Wed, Apr 09, 2025 at 09:46:33AM +0800, jiangf...@kylinos.cn wrote: > From: Feng Jiang > > When calling scnprintf() to append recovery method to event_string, > the second argument should be `sizeof(event_string) - len`, otherwise > there is a potential overflow problem. > > Fixes: b7cf9f4ac1b

[PATCH v2 05/15] drm: renesas: rz-du: Add support for RZ/V2H(P) SoC

2025-04-10 Thread Prabhakar
From: Lad Prabhakar The LCD controller (LCDC) on the RZ/V2H(P) SoC is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). There is one LCDC unit available on the RZ/V2H(P) SoC which is connected to the DSI. Signed-off-by: Lad Prabhakar --- v1-

Re: [PATCH 1/2] drm/vmwgfx: Update last_read_seqno under the fence lock

2025-04-10 Thread Maaz Mombasawala
On 4/10/25 12:55, Ian Forbes wrote: > There was a possible race in vmw_update_seqno. Because of this race it > was possible for last_read_seqno to go backwards. Remove this function > and replace it with vmw_update_fences which now sets and returns the > last_read_seqno while holding the fence lock

Re: [PATCH v3 13/15] drm/tests: hdmi: Add limited range tests for YUV420 mode

2025-04-10 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:20:02PM +0200, Cristian Ciocaltea wrote: > Provide tests to verify that drm_atomic_helper_connector_hdmi_check() > helper behaviour when using YUV420 output format is to always set the > limited RGB quantization range to 'limited', no matter what the value of > Broadcast

[PATCH v6 05/18] drm/imagination: Add power domain control

2025-04-10 Thread Matt Coster
The first supported GPU only used a single power domain so this was automatically handled by the device runtime. In order to support multiple power domains, they must be enumerated from devicetree and linked to both the GPU device and each other to ensure correct power sequencing at start time. F

Re: [PATCH 2/4] drm/panel: ilitek-ili9881c: Add support for two-lane configuration

2025-04-10 Thread Dmitry Baryshkov
On Thu, Apr 10, 2025 at 12:34:15PM +0300, Dmitry Baryshkov wrote: > On Tue, Apr 08, 2025 at 05:27:01PM +0200, Kory Maincent wrote: > > Enable support for two-lane configuration which is done by setting the > > LANSEL_SW_EN and LANSEL_SW bits in the Pad Control register. > > > > Use the dsi-lanes d

Re: [PATCH][next] drm/nouveau: chan: Avoid -Wflex-array-member-not-at-end warnings

2025-04-10 Thread Gustavo A. R. Silva
On 07/04/25 13:50, Kees Cook wrote: On Thu, Apr 03, 2025 at 10:45:18AM -0600, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for a few on-stack definitions of a flexible s

Re: [PATCH next] drm/syncobj: Fix leak in drm_syncobj_import_sync_file_fence()

2025-04-10 Thread Rob Clark
On Thu, Apr 10, 2025 at 9:33 AM Dan Carpenter wrote: > > We need to cleanup if the chain = dma_fence_chain_alloc() allocation > fails. Now that we have multiple error returns in this function, switch > to using an unwind ladder for cleanup. > > Fixes: c2d3a7300695 ("drm/syncobj: Extend EXPORT_SYN

Re: [PATCH] drm/amd/display: do not copy invalid CRTC timing info

2025-04-10 Thread Alex Hung
Hi Gergo, Thanks for the patch. I am sending this patch for testing and I will update test result next week. On 4/2/25 11:03, Gergo Koteles wrote: Since b255ce4388e0, it is possible that the CRTC timing information for the preferred mode has not yet been calculated while amdgpu_dm_connector_

Re: [PATCH 04/19] drm: Pass the format info to .fb_create()

2025-04-10 Thread kernel test robot
Hi Ville, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.15-rc1 next-20250410] [cannot apply to drm-exynos/exynos-drm-next tegra/for-next rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes] [If your patch is

Re: [PATCH v3 2/3] printf: add tests for generic FourCCs

2025-04-10 Thread Petr Mladek
On Mon 2025-04-07 19:12:39, Aditya Garg wrote: > > > On 07/04/25 7:07 pm, Aditya Garg wrote: > > From: Aditya Garg > > > > This patch adds support for kunit tests of generic 32-bit FourCCs added to > > vsprintf. > > > > Acked-by: Tamir Duberstein > > Reviewed-by: Andy Shevchenko > > Signed-o

Re: [PATCH] udmabuf: fix a buf size overflow issue during udmabuf creation

2025-04-10 Thread Chen, Xiaogang
On 3/26/2025 2:41 AM, Christian König wrote: Am 26.03.25 um 03:59 schrieb Kasireddy, Vivek: Hi Christian, Subject: Re: [PATCH] udmabuf: fix a buf size overflow issue during udmabuf creation Am 25.03.25 um 07:23 schrieb Kasireddy, Vivek: Hi Christian, Am 21.03.25 um 17:41 schrieb Xiaogang.

Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning

2025-04-10 Thread Arnd Bergmann
On Thu, Apr 10, 2025, at 13:22, Matt Coster wrote: > On 09/04/2025 13:22, Arnd Bergmann wrote: >> >> Rather than adding more #ifdef blocks, address this by changing the >> existing #ifdef into equivalent IS_ENABLED() checks so gcc can see >> where the symbol is used but still eliminate it from the

Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

2025-04-10 Thread Vignesh Raman
Hi Helen, On 09/04/25 23:53, Helen Koike wrote: Hi Vignesh, Thank you for your patch. On 09/04/2025 03:15, Vignesh Raman wrote: Add jobs to validate devicetrees and run KUnit tests. Pipeline link, https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550 I see the checks are in

Re: [PATCH 2/2] drm/sysfb: efidrm: Support module builds

2025-04-10 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Make CONFIG_DRM_EFIDRM a tristate to enable module builds. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: Need Help Enabling HDMI on Debix Model A

2025-04-10 Thread Laurent Pinchart
On Thu, Apr 10, 2025 at 11:33:08AM +, Tarang Raval wrote: > > On Thu, Apr 10, 2025 at 08:13:17AM +, Tarang Raval wrote: > > > > On Mon, Apr 07, 2025 at 02:06:35PM +, Tarang Raval wrote: > > > > > > On Mon, Apr 07, 2025 at 11:10:23AM +, Tarang Raval wrote: > > > > > > > Hi Laurent, >

Re: [PATCH v3 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-04-10 Thread Ayushi Makhija
On 4/7/2025 1:42 AM, Dmitry Baryshkov wrote: > On Fri, Apr 04, 2025 at 05:25:36PM +0530, Ayushi Makhija wrote: >> Add anx7625 DSI to DP bridge device nodes. >> >> Signed-off-by: Ayushi Makhija >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 - >> 1 file changed, 207

[PATCH v6 13/18] drm/imagination: Move ELF fw utils to common file

2025-04-10 Thread Matt Coster
Currently only MIPS firmware processors use ELF-formatted firmware. When adding support for RISC-V firmware processors, it will be useful to have ELF handling functions ready to go. Signed-off-by: Matt Coster Reviewed-by: Frank Binns --- Changes in v6: - Move loop variable as per https://lore.k

Re: [PATCH 2/4] backlight: ktz8866: add slave handler

2025-04-10 Thread Daniel Thompson
On Mon, Apr 07, 2025 at 05:51:17PM +0800, Pengyu Luo wrote: > Kinetic ktz8866, found in many android devices, nowadays, some oem use > dual ktz8866 to support a larger panel and higher brightness, original > driver would only handle half backlight region on these devices, > registering it twice is

Re: [PATCH v3 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

2025-04-10 Thread Mattijs Korpershoek
Hi Maxime, Thank you for the patch. On lun., avril 07, 2025 at 18:29, Maxime Ripard wrote: > Some reserved memory regions might have particular memory setup or > attributes that make them good candidates for heaps. > > Let's provide a heap type that will create a new heap for each reserved > me

  1   2   3   4   >