Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-28 Thread Yongbang Shi
On Fri, Mar 28, 2025 at 12:28:14PM +0200, Jani Nikula wrote: On Fri, 28 Mar 2025, Yongbang Shi wrote: On Thu, 27 Mar 2025, Yongbang Shi wrote: 在 2025/3/26 17:32, Jani Nikula 写道: On Tue, 25 Mar 2025, Yongbang Shi wrote: On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025, Yongban

Re: [PATCH v3 03/11] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF

2025-03-28 Thread kernel test robot
Hi Amirreza, kernel test robot noticed the following build warnings: [auto build test WARNING on db8da9da41bced445077925f8a886c776a47440c] url: https://github.com/intel-lab-lkp/linux/commits/Amirreza-Zarrabi/tee-allow-a-driver-to-allocate-a-tee_device-without-a-pool/20250328-104950 base

Re: [PATCH 3/8] rust: drm: add driver abstractions

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 06:00:11PM -0400, Lyude Paul wrote: > On Wed, 2025-03-26 at 00:54 +0100, Danilo Krummrich wrote: > > diff --git a/rust/kernel/drm/driver.rs b/rust/kernel/drm/driver.rs > > new file mode 100644 > > index ..1ac770482ae0 > > --- /dev/null > > +++ b/rust/kernel/drm/d

[PATCH v15 4/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-28 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) Signed-off-by: Jonathan Cavitt Cc: Zhang Jianxun --- include/

Re: [git pull] drm for 6.15-rc1

2025-03-28 Thread Linus Torvalds
On Thu, 27 Mar 2025 at 19:53, Dave Airlie wrote: > > This is the main drm pull request for 6.15. Bit late, but my wife was > away getting a PhD and kids took over my writing summaries time, and > fd.o was offline last week which slowed me down a small bit. Grr. I did the pull, resolved the (trivi

Re: [GIT PULL] fbdev updates for v6.15-rc1

2025-03-28 Thread pr-tracker-bot
The pull request you sent on Thu, 27 Mar 2025 19:03:38 +0100: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.15-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/51aad189f8e0f926c0977d180cae6a78df445f27 Thank you! -- Dee

Re: [git pull] drm for 6.15-rc1

2025-03-28 Thread pr-tracker-bot
The pull request you sent on Fri, 28 Mar 2025 12:53:20 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2025-03-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0c86b42439b6c11d758b3392a21117934fef00c1 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Andrew Morton
On Fri, 28 Mar 2025 16:14:55 -0600 Shuah Khan wrote: > On 3/13/25 16:05, Andrew Morton wrote: > > On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: > > > >> On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > > Yeah, as with my prior review, I'm a fan of this. It ma

[PATCH v2 4/7] drm/gpusvm: refactor core API to use pages struct

2025-03-28 Thread Matthew Auld
Refactor the core API of get/unmap/free pages to all operate on drm_gpusvm_pages. In the next patch we want to export a simplified core API without needing fully blown svm range etc. Suggested-by: Matthew Brost Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/drm_gpusvm.c |

Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()

2025-03-28 Thread Lyude Paul
On Wed, 2025-03-26 at 12:39 +0200, Jani Nikula wrote: > On Tue, 25 Mar 2025, Lyude Paul wrote: > > A negative resolution doesn't really make any sense, no one goes into a TV > > store and says "Hello sir, I would like a negative 4K TV please", that > > would make everyone look at you funny. > > T

Re: [PATCH v3 08/11] tee: add Qualcomm TEE driver

2025-03-28 Thread kernel test robot
Hi Amirreza, kernel test robot noticed the following build warnings: [auto build test WARNING on db8da9da41bced445077925f8a886c776a47440c] url: https://github.com/intel-lab-lkp/linux/commits/Amirreza-Zarrabi/tee-allow-a-driver-to-allocate-a-tee_device-without-a-pool/20250328-104950 base

Re: [PATCH 3/8] rust: drm: add driver abstractions

2025-03-28 Thread Lyude Paul
On Wed, 2025-03-26 at 00:54 +0100, Danilo Krummrich wrote: > diff --git a/rust/kernel/drm/driver.rs b/rust/kernel/drm/driver.rs > new file mode 100644 > index ..1ac770482ae0 > --- /dev/null > +++ b/rust/kernel/drm/driver.rs > @@ -0,0 +1,143 @@ > +// SPDX-License-Identifier: GPL-2.0 OR M

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Shuah Khan
On 3/13/25 16:05, Andrew Morton wrote: On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my very noisy tests much easier to deal with. And for the reco

Re: [RFC PATCH 0/6] Deep talk about folio vmap

2025-03-28 Thread Vishal Moola (Oracle)
On Thu, Mar 27, 2025 at 05:28:27PM +0800, Huan Yang wrote: > Bingbu reported an issue in [1] that udmabuf vmap failed and in [2], we > discussed the scenario of folio vmap due to the misuse of vmap_pfn > in udmabuf. > > We reached the conclusion that vmap_pfn prohibits the use of page-based > PFNs

[PATCH 1/4] drm-uapi/xe: Declare xe_vm_get_property_ioctl

2025-03-28 Thread Jonathan Cavitt
Align with 20250326165751.72881-1-jonathan.cav...@intel.com Add initial declarations for the xe_vm_get_property_ioctl call, including necessary structures and IOCTL macros. Signed-off-by: Jonathan Cavitt --- include/drm-uapi/xe_drm.h | 78 +++ 1 file changed,

[PATCH 3/4] tests/intel/xe_vm: Add DRM_IOCTL_XE_VM_GET_PROPERTY validation tests

2025-03-28 Thread Jonathan Cavitt
Add tests to xe_vm that exercise the new DRM_IOCTL_XE_VM_GET_PROPERTY ioctl. Specifically, add input validation tests that exercise the return values for improperly formatted ioctl structures. Signed-off-by: Jonathan Cavitt --- tests/intel/xe_vm.c | 82 ++

[PATCH 0/4] tests/intel/xe_vm: Add drm_xe_vm_get_property tests

2025-03-28 Thread Jonathan Cavitt
Add tests that exercise the new drm_xe_vm_get_property uapi, specifically for ioctl input validation and for determining that pagefaults are correctly tracked and returned by the reporter. Signed-off-by: Jonathan Cavitt Suggested-by: Joonas Lahtinen Suggested-by: Matthew Brost Suggested-by: Zha

[PATCH 4/4] tests/intel/xe_vm: Test DRM_IOCTL_XE_VM_GET_PROPERTY fault reporting

2025-03-28 Thread Jonathan Cavitt
Add a test to xe_vm that determines if pagefaults are correctly tracked and reported by the DRM_IOCTL_XE_VM_GET_PROPERTY. Signed-off-by: Jonathan Cavitt Suggested-by: Jianxun Zhang Suggested-by: Stuart Summers --- tests/intel/xe_vm.c | 162 +++- 1 file c

[PATCH 2/4] lib/xe/xe_ioctl: Add xe_vm_get_property helper function

2025-03-28 Thread Jonathan Cavitt
Add a helper function, xe_vm_get_property, that calls the drm_xe_vm_get_property ioctl. Since the ioctl behaves similarly to an xe_query in that it needs to be called once to get the size of the return data and again to save the data, the helper function takes the ioctl structure as a parameter.

[PATCH v15 5/6] drm/xe/xe_vm: Add per VM fault info

2025-03-28 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v15 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-28 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v15 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-28 Thread Jonathan Cavitt
Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jain

[PATCH v15 3/6] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-28 Thread Jonathan Cavitt
Move the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault_types.h header file, and move the associated enum values into the regs folder under xe_pagefault_desc.h Since xe_pagefault_desc.h is being initialized here, also move the xe_guc_pagefault_desc hardware formats to the new file.

[PATCH v15 1/6] drm/xe/xe_hw_engine: Map xe and user engine class in header

2025-03-28 Thread Jonathan Cavitt
Move the helper arrays xe_to_user_engine_class and user_to_xe_engine_class to xe_hw_engine_types.h, making them available to more of the xe kernel. This is done for user_to_xe_engine_class to reduce duplication, and xe_to_user_engine_class can and will be used in more than one place in the future.

[PATCH v15 2/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-28 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_p

[PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-03-28 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. v5: Correct the if condition for modifier support check (Chaitanya) v6: Replace uint32_t/uint64_t with u32/u64 (Jani) v7: Move plannar check from intel_async

Re: [PATCH V3] accel/amdxdna: Add BO import and export

2025-03-28 Thread Lizhi Hou
On 3/28/25 09:16, Jeff Hugo wrote: On 3/25/2025 2:01 PM, Lizhi Hou wrote: Add amdxdna_gem_prime_export() and amdxdna_gem_prime_import() for BO import and export. Register mmu notifier for imported BO as well. When MMU_NOTIFIER_UNMAP event is received, queue work to remove the notifier. The sa

Re: [PATCH] drm: renesas: rz-du: Support dmabuf import

2025-03-28 Thread Lad, Prabhakar
On Fri, Mar 21, 2025 at 10:46 AM Laurent Pinchart wrote: > > The rz-du driver uses GEM DMA helpers, but does not implement the > drm_driver .gem_prime_import_sg_table operation. This prevents > importing dmabufs. Fix it by implementing the missing operation using > the DRM_GEM_DMA_DRIVER_OPS_WITH

Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-28 Thread Dmitry Baryshkov
On Fri, 28 Mar 2025 at 16:22, Krzysztof Kozlowski wrote: > > On 28/03/2025 13:45, Dmitry Baryshkov wrote: > > On Fri, Mar 28, 2025 at 03:13:57PM +0530, Ayushi Makhija wrote: > >>> These both above commented from Dmitry I have addressed in the version 2 > >>> of patch 7 of the series. > >>> I have

Re: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-28 Thread Lad, Prabhakar
On Fri, Mar 21, 2025 at 5:22 PM Kieran Bingham wrote: > > From: Kieran Bingham > > The RZ/G2L driver utilises the VSPD to read data from input sources. > > The rzg2l_du_kms component lists a restricted subset of the capabilities > of the VSPd which prevents additional formats from being used for

Re: [PATCH] drm/xe: avoid plain 64-bit division

2025-03-28 Thread Rodrigo Vivi
On Mon, Mar 24, 2025 at 10:06:02PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building the xe driver for i386 results in a link time warning: > > x86_64-linux-ld: drivers/gpu/drm/xe/xe_migrate.o: in function > `xe_migrate_vram': > xe_migrate.c:(.text+0x1e15): undefined reference to `

[PATCH v5 2/4] drm/xe/sriov: Shifting GGTT area post migration

2025-03-28 Thread Tomasz Lis
We have only one GGTT for all IOV functions, with each VF having assigned a range of addresses for its use. After migration, a VF can receive a different range of addresses than it had initially. This implements shifting GGTT addresses within drm_mm nodes, so that VMAs stay valid after migration.

Re: [PATCH 1/2] drm/amd/display: Protect dml2_create()/dml2_copy()/dml2_create_copy()

2025-03-28 Thread Aurabindo Pillai
On 2025-03-26 21:40, Huacai Chen wrote: Hi, Alex, On Thu, Mar 27, 2025 at 8:10 AM Alex Hung wrote: The following error messages showed up on an APU and a dGPU during testing. <3> [100.231411] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:321 <3> [100.23141

[PATCH v5 0/4] drm/xe/vf: Post-migration recovery of GGTT nodes and CTB

2025-03-28 Thread Tomasz Lis
To support VF Migration, it is necessary to do fixups to any non-virtualized resources. These fixups need to be applied within VM, on the KMD working with VF. This series adds two fixup functions to the recovery worker: * for fixing drm_mm nodes which represent GGTT allocations * for fixing conten

Re: [PATCH] drm/i915/gsc: delete a stray tab in intel_gsc_fw_get_binary_info()

2025-03-28 Thread Rodrigo Vivi
On Mon, Mar 10, 2025 at 10:46:19PM +0300, Dan Carpenter wrote: > This line is indented on tab too far. Delete the extra tab. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushing right now... > --- > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +- > 1 file changed, 1 inse

[PATCH v5 4/4] drm/xe/vf: Fixup CTB send buffer messages after migration

2025-03-28 Thread Tomasz Lis
During post-migration recovery of a VF, it is necessary to update GGTT references included in messages which are going to be sent to GuC. GuC will start consuming messages after VF KMD will inform it about fixups being done; before that, the VF KMD is expected to update any H2G messages which are a

[PATCH v5 3/4] drm/xe/guc: Introduce enum with offsets for multi-LRC register H2G

2025-03-28 Thread Tomasz Lis
Some GuC messages are constructed with incrementing dword counter rather than referencing specific DWORDs, as described in GuC interface specification. This change introduces the definitions of DWORD numbers for parameters which will need to be referenced in a CTB parser to be added in a following

[PATCH v2 3/7] drm/gpusvm: pull out drm_gpusvm_pages substructure

2025-03-28 Thread Matthew Auld
Pull the pages stuff from the svm range into its own substructure, with the idea of having the main pages related routines, like get_pages(), unmap_pages() and free_pages() all operating on some lower level structures, which can then be re-used for stuff like userptr. v2: - Move seq into pages s

[PATCH v2 5/7] drm/gpusvm: export drm_gpusvm_pages API

2025-03-28 Thread Matthew Auld
Export get/unmap/free pages API. We also need to tweak the SVM init to allow skipping much of the unneeded parts. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Matthew Brost --- drivers/gpu/drm/drm_gpusvm.c | 66 include/drm/drm_gpusvm.h | 16 +++

[PATCH v2 6/7] drm/xe/userptr: replace xe_hmm with gpusvm

2025-03-28 Thread Matthew Auld
Goal here is cut over to gpusvm and remove xe_hmm, relying instead on common code. The core facilities we need are get_pages(), unmap_pages() and free_pages() for a given useptr range, plus a vm level notifier lock, which is now provided by gpusvm. v2: - Reuse the same SVM vm struct we use for f

[PATCH v2 7/7] drm/xe/pt: unify xe_pt_svm_pre_commit with userptr

2025-03-28 Thread Matthew Auld
We now use the same notifier lock for SVM and userptr, with that we can combine xe_pt_userptr_pre_commit and xe_pt_svm_pre_commit. Suggested-by: Matthew Brost Signed-off-by: Matthew Auld Cc: Himal Prasad Ghimiray Cc: Thomas Hellström --- drivers/gpu/drm/xe/xe_pt.c | 95 +--

[PATCH v2 1/7] drm/gpusvm: fix hmm_pfn_to_map_order() usage

2025-03-28 Thread Matthew Auld
Handle the case where the hmm range partially covers a huge page (like 2M), otherwise we can potentially end up doing something nasty like mapping memory which is outside the range, and maybe not even mapped by the mm. Fix is based on the xe userptr code, which in a future patch will directly use g

[PATCH v2 0/7] Replace xe_hmm with gpusvm

2025-03-28 Thread Matthew Auld
As a first step to moving userptr handling over to drm, replace the hmm usage in xe over to gpusvm, which already offers similar functionality. As some prep steps we also align on some of the missing pieces that were already handled in xe_hmm. v2: - Rework the gpusvm API based on feedback. - U

Re: [PATCH v2 4/4] drm/panel/panel-simple: Use the new allocation in place of devm_kzalloc()

2025-03-28 Thread Anusha Srivatsa
On Fri, Mar 28, 2025 at 4:54 AM Luca Ceresoli wrote: > On Thu, 27 Mar 2025 10:55:42 -0400 > Anusha Srivatsa wrote: > > > Start using the new helper that does the refcounted > > allocations. > > > > v2: check error condition (Luca) > > Here as well, when you resend, move the changelog after the '

[PATCH v3 6/7] drm/syncobj: Add a fast path to drm_syncobj_array_wait_timeout

2025-03-28 Thread Tvrtko Ursulin
Running the Cyberpunk 2077 benchmark we can observe that waiting on DRM sycobjs is relatively hot, but the 96% of the calls are for a single object. (~4% for two points, and never more than three points. While a more trivial workload like vkmark under Plasma is even more skewed to single point wait

[PATCH v3 2/7] drm/syncobj: Do not allocate an array to store zeros when waiting

2025-03-28 Thread Tvrtko Ursulin
When waiting on syncobjs the current code allocates a temporary array only to fill it up with all zeros. We can avoid that by relying on the allocated entry array already being zero allocated. For the timeline mode we can fetch the timeline point values as we populate the entries array so also do

[PATCH v3 7/7] drm/syncobj: Add a fast path to drm_syncobj_array_find

2025-03-28 Thread Tvrtko Ursulin
Running the Cyberpunk 2077 benchmark we can observe that the lookup helper is relatively hot, but the 97% of the calls are for a single object. (~3% for two points, and never more than three points. While a more trivial workload like vkmark under Plasma is even more skewed to single point lookups.)

[PATCH v3 5/7] drm/syncobj: Avoid temporary allocation in drm_syncobj_timeline_signal_ioctl

2025-03-28 Thread Tvrtko Ursulin
We can avoid one of the two temporary allocations if we read the userspace supplied timeline points as we go along. The only new complication is to unwind unused fence chains on the error path, but even that code was already present in the function. Signed-off-by: Tvrtko Ursulin Reviewed-by: Maí

[PATCH v3 1/7] drm/syncobj: Remove unhelpful helper

2025-03-28 Thread Tvrtko Ursulin
Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean parameter is not very helpful or readable. Lets just remove it and proof in the pudding is the net smaller code. Signed-off-by: Tvrtko Ursulin Reviewed-by: Maíra Canal --- v2: * Assi

[PATCH v3 0/7] few drm_syncobj optimisations

2025-03-28 Thread Tvrtko Ursulin
A small set of drm_syncobj optimisations which should make things a tiny bit more efficient on the CPU side of things. Improvement seems to be around 1.5%* more FPS if observed with "vkgears -present-mailbox" on a Steam Deck Plasma desktop, but I am reluctant to make a definitive claim on the numb

Re: [PATCH v6 4/6] PCI/IOV: Check that VF BAR fits within the reservation

2025-03-28 Thread Ilpo Järvinen
On Wed, 26 Mar 2025, Ilpo Järvinen wrote: > On Thu, 20 Mar 2025, Michał Winiarski wrote: > > > When the resource representing VF MMIO BAR reservation is created, its > > size is always large enough to accommodate the BAR of all SR-IOV Virtual > > Functions that can potentially be created (total V

Re: [PATCH v2][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 09:52:18AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

Re: [PATCH V3] accel/amdxdna: Add BO import and export

2025-03-28 Thread Jeff Hugo
On 3/25/2025 2:01 PM, Lizhi Hou wrote: Add amdxdna_gem_prime_export() and amdxdna_gem_prime_import() for BO import and export. Register mmu notifier for imported BO as well. When MMU_NOTIFIER_UNMAP event is received, queue work to remove the notifier. The same BO could be mapped multiple times i

[PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip

2025-03-28 Thread Arun R Murthy
Async flip is not supported with Indexed 8 bit format as it depends on LUT and can't be updated atomically. Signed-off-by: Arun R Murthy Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v11 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-28 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flip are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flip su

[PATCH v11 2/5] drm/plane: modify create_in_formats to acommodate async

2025-03-28 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[PATCH v11 3/5] drm/i915/display: Acomodate format check in intel_plane_can_async_flip()

2025-03-28 Thread Arun R Murthy
The function intel_plane_can_async_flip() checks for async supported modifier, add format support check also in the same function. Note: on ADL the surface base addr is required to be 16k aligned and if not might generate DMAR and GGTT faults leading to glitches. v11: Move filtering Indexed 8bit

[PATCH v11 4/5] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-03-28 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. v5: Correct the if condition for modifier support check (Chaitanya) v6: Replace uint32_t/uint64_t with u32/u64 (Jani) v7: Move plannar check from intel_async

Re: DRM CI

2025-03-28 Thread Maxime Ripard
On Thu, Mar 20, 2025 at 09:32:36AM -0300, Helen Koike wrote: > Hi Maxime, > > Thanks for your reply. > > On 20/03/2025 06:33, Maxime Ripard wrote: > > Hi, > > > > On Wed, Mar 19, 2025 at 02:39:59PM -0300, Helen Koike wrote: > > > Hi Maxime, > > > > > > On 19/03/2025 11:11, Maxime Ripard wrote:

RE: [PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Murthy, Arun R
> On Fri, Mar 28, 2025 at 06:15:37PM +0530, Arun R Murthy wrote: > > The function pointer can_async_flip() checks for async supported > > modifier, add format support check also in the same function. > > You are changing intel_plane_can_async_flip(), not the > .can_async_flip() vfunc. So this comm

[PATCH v2][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
On 28/03/25 09:05, Danilo Krummrich wrote: On Fri, Mar 28, 2025 at 08:45:32AM -0600, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexibl

Re: [PATCH 2/2] accel/ivpu: Fix PM related deadlocks in MS IOCTLs

2025-03-28 Thread Lizhi Hou
On 3/25/25 04:43, Maciej Falkowski wrote: From: Jacek Lawrynowicz Prevent runtime resume/suspend while MS IOCTLs are in progress. Failed suspend will call ivpu_ms_cleanup() that would try to acquire file_priv->ms_lock, which is already held by the IOCTLs. Fixes: cdfad4db7756 ("accel/ivpu: Ad

Re: [PATCH 3/4] drm/vc4: tests: Stop allocating the state in test init

2025-03-28 Thread Maxime Ripard
On Sun, Mar 23, 2025 at 03:48:17PM -0300, Maíra Canal wrote: > Hi Maxime, > > On 18/03/25 11:17, Maxime Ripard wrote: > > The vc4-pv-muxing-combinations and vc5-pv-muxing-combinations test > > suites use a common test init function which, in part, allocates the > > drm atomic state the test will u

Re: [PATCH][next] drm/nouveau/conn: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 08:56:25AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

Re: [PATCH 2/4] drm/vc4: tests: Document output handling functions

2025-03-28 Thread Maxime Ripard
On Sun, Mar 23, 2025 at 03:34:50PM -0300, Maíra Canal wrote: > Hi Maxime, > > On 18/03/25 11:17, Maxime Ripard wrote: > > vc4_mock_atomic_add_output() and vc4_mock_atomic_del_output() public but > > Nit: s/public/are public Good catch, thanks! > > aren't documented. Let's provide the documentat

Re: [PATCH 1/2] accel/ivpu: Fix deadlock in ivpu_ms_cleanup()

2025-03-28 Thread Lizhi Hou
On 3/28/25 01:23, Jacek Lawrynowicz wrote: On 3/27/2025 6:38 PM, Lizhi Hou wrote: On 3/26/25 01:06, Jacek Lawrynowicz wrote: Hi, On 3/25/2025 9:50 PM, Lizhi Hou wrote: On 3/25/25 04:43, Maciej Falkowski wrote: From: Jacek Lawrynowicz Fix deadlock in ivpu_ms_cleanup() by preventing runti

[PATCH v2 8/8] drm/format-helper: Optimize 32-to-8-bpp conversion

2025-03-28 Thread Thomas Zimmermann
For ease of implementation, existing line-conversion functions for 8-bit formats write each pixel individually. Optimize the performance by writing multiple pixels in a single 32-bit store. v2: - simplify address calculation (Jani) - fix typo in commit message (Jocelyn) Signed-off-by: Thomas Zimm

Re: [PATCH v2 1/4] drm/panel: Add new helpers for refcounted panel allocatons

2025-03-28 Thread Anusha Srivatsa
On Fri, Mar 28, 2025 at 4:34 AM Luca Ceresoli wrote: > Hello Anusha, > > Thanks for your continued effort. > > I have a few minor comments. Nothing big, but since Maxime requested a > change you'll have to send a new iteration, so find my comments below. > > On Thu, 27 Mar 2025 10:55:39 -0400 > A

Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests

2025-03-28 Thread Maxime Ripard
On Thu, Mar 27, 2025 at 09:31:12PM +0530, Vignesh Raman wrote: > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool. > > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/gitlab-ci.yml | 1 + > drivers/gpu/drm/ci/kunit.sh | 34 > driv

[PATCH 11/18] drm/bridge: cdns-dsi: Remove broken fifo emptying check

2025-03-28 Thread Tomi Valkeinen
The driver check if "DPI(HFP) > DSI(HSS+HSA+HSE+HBP)", and rejects the mode if not. However, testing shows that this doesn't hold at all. I can set the hfp to very small values, with no errors. The feedback from the HW team also was that the check is not right, although it's not clear if there's a

Re: [PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 08:45:32AM -0600, Gustavo A. R. Silva wrote: > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > getting ready to enable it, globally. > > Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of > a flexible structure where the size of the flexi

[PATCH][next] drm/nouveau/conn: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH 8/8] MAINTAINERS: add DRM Rust source files to DRM DRIVERS

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 03:49:20PM +0100, Maxime Ripard wrote: > On Wed, Mar 26, 2025 at 12:54:35AM +0100, Danilo Krummrich wrote: > > Add the DRM Rust source files to the DRM DRIVERS maintainers entry. > > > > Signed-off-by: Danilo Krummrich > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1

Re: [PATCH 5/8] rust: drm: add DRM driver registration

2025-03-28 Thread Danilo Krummrich
On Fri, Mar 28, 2025 at 03:28:04PM +0100, Maxime Ripard wrote: > On Wed, Mar 26, 2025 at 11:46:54AM +0100, Danilo Krummrich wrote: > > On Wed, Mar 26, 2025 at 10:24:43AM +0100, Maxime Ripard wrote: > > > On Wed, Mar 26, 2025 at 12:54:32AM +0100, Danilo Krummrich wrote: > > > > drm_dev_unregister a

Re: [PATCH 8/8] MAINTAINERS: add DRM Rust source files to DRM DRIVERS

2025-03-28 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:54:35AM +0100, Danilo Krummrich wrote: > Add the DRM Rust source files to the DRM DRIVERS maintainers entry. > > Signed-off-by: Danilo Krummrich > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index de46acc247c3

[PATCH][next] drm/nouveau/outp: Avoid -Wflex-array-member-not-at-end warning

2025-03-28 Thread Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of a flexible structure where the size of the flexible-array member is known at compile-time, and refactor the rest of the code, a

Re: [PATCH 6/8] rust: drm: file: Add File abstraction

2025-03-28 Thread Maxime Ripard
On Wed, 26 Mar 2025 00:54:33 +0100, Danilo Krummrich wrote: > A DRM File is the DRM counterpart to a kernel file structure, > representing an open DRM file descriptor. > > Add a Rust abstraction to allow drivers to implement their own File types > that implement the DriverFile trait. > > [ ... ]

Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-28 Thread Krzysztof Kozlowski
On 13/03/2025 13:10, Ayushi Makhija wrote: ... > >> + >> +anx_bridge_1: anx7625@58 { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-de

[PATCH v2 1/8] drm/format-helper: Move helpers for pixel conversion to header file

2025-03-28 Thread Thomas Zimmermann
The DRM draw helpers contain format-conversion helpers that operate on individual pixels. Move them into an internal header file and adopt them as individual API. Update the draw code accordingly. The pixel helpers will also be useful for other format conversion helpers. Signed-off-by: Thomas Zimm

Re: [PATCH v3 3/4] drm/panthor: show device-wide list of DRM GEM objects over DebugFS

2025-03-28 Thread Boris Brezillon
On Thu, 27 Mar 2025 14:08:36 + Adrián Larumbe wrote: > Add a device DebugFS file that displays a complete list of all the DRM GEM > objects that are exposed to UM through a DRM handle. > > Since leaking object identifiers that might belong to a different NS is > inadmissible, this functional

Re: [PATCH 5/8] rust: drm: add DRM driver registration

2025-03-28 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 11:46:54AM +0100, Danilo Krummrich wrote: > On Wed, Mar 26, 2025 at 10:24:43AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Wed, Mar 26, 2025 at 12:54:32AM +0100, Danilo Krummrich wrote: > > > Implement the DRM driver `Registration`. > > > > > > The `Registration` struct

Re: [PATCH v2 4/4] drm/panthor: Display heap chunk entries in DebugFS GEMS file

2025-03-28 Thread Boris Brezillon
On Thu, 27 Mar 2025 13:18:47 + Adrián Larumbe wrote: > On 19.03.2025 18:00, Boris Brezillon wrote: > > On Wed, 19 Mar 2025 15:03:19 + > > Adrián Larumbe wrote: > > > > > Expand the driver's DebugFS GEMS file to display entries for the heap > > > chunks' GEM objects, both those allocate

Re: [PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-28 Thread Krzysztof Kozlowski
On 28/03/2025 13:45, Dmitry Baryshkov wrote: > On Fri, Mar 28, 2025 at 03:13:57PM +0530, Ayushi Makhija wrote: >>> These both above commented from Dmitry I have addressed in the version 2 of >>> patch 7 of the series. >>> I have squash patch 8 into patch 7 of version 1 into patch 7 of version 2 >

[PATCH v2 6/8] drm/format-helper: Optimize 32-to-24-bpp conversion

2025-03-28 Thread Thomas Zimmermann
For ease of implementation, existing line-conversion functions for 24-bit formats write each byte individually. Optimize the performance by writing 4 pixels in 3 32-bit stores. v2: - simplify address calculation (Jani) Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/g

[PATCH v2 7/8] drm/format-helper: Optimize 32-to-16-bpp conversion

2025-03-28 Thread Thomas Zimmermann
For ease of implementation, existing line-conversion functions for 16-bit formats write each pixel individually. Optimize the performance by writing multiple pixels in single 64-bit and 32-bit stores. v2: - simplify address calculation (Jani) - fix typo in commit message (Jocelyn) Signed-off-by:

[PATCH v2 4/8] drm/format-helper: Add generic conversion to 16-bit formats

2025-03-28 Thread Thomas Zimmermann
Add drm_fb_xfrm_line_32to16() to implement conversion from 32-bit pixels to 16-bit pixels. The pixel-conversion is specified by the given callback parameter. Mark the helper as always_inline to avoid overhead from function calls. Then implement all existing line-conversion functions with the new g

[PATCH v2 5/8] drm/format-helper: Add generic conversion to 8-bit formats

2025-03-28 Thread Thomas Zimmermann
Add drm_fb_xfrm_line_32to8() to implement conversion from 32-bit pixels to 8-bit pixels. The pixel-conversion is specified by the given callback parameter. Mark the helper as always_inline to avoid overhead from function calls. Then implement all existing line-conversion functions with the new gen

[PATCH v2 2/8] drm/format-helper: Add generic conversion to 32-bit formats

2025-03-28 Thread Thomas Zimmermann
Add drm_fb_xfrm_line_32to32() to implement conversion from 32-bit pixels to 32-bit pixels. The pixel-conversion is specified by the given callback parameter. Mark the helper as always_inline to avoid overhead from function calls. Then implement all existing line-conversion functions with the new g

[PATCH v2 0/8] drm/format-helper: Add helpers for line conversion

2025-03-28 Thread Thomas Zimmermann
Add helpers for converting the pixel format of scanline. This used to be implemented for each format individually, but only the per-pixel code is really different among formats. Patch 1 moves the per-pixel format helpers from drm_draw.c to an internal header. These functions have equivalents in th

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Maxime Ripard
a bunch of my > > > very noisy tests much easier to deal with. > > > > And for the record, we're also affected by this in DRM and would very > > much like to get it merged in one shape or another. > > Here is another case: > https://lore.kernel.org/all/20250328.a

Re: [PATCH] drm: of: fix documentation reference

2025-03-28 Thread Maxime Ripard
On Fri, 28 Mar 2025 12:41:48 +0100, Raphael Gallais-Pou wrote: > Documentation/devicetree/bindings/graph.txt content has move directly to > the dt-schema repo. > > Point to the YAML of the official repo instead of the old file. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: DRM CI

2025-03-28 Thread Vignesh Raman
Hi Maxime, On 20/03/25 15:03, Maxime Ripard wrote: Hi, On Wed, Mar 19, 2025 at 02:39:59PM -0300, Helen Koike wrote: Hi Maxime, On 19/03/2025 11:11, Maxime Ripard wrote: Hi, At last Plumbers, we agreed with Dave that a good first step to ramp up CI for DRM trees would be to enable build and

Re: [PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Ville Syrjälä
On Fri, Mar 28, 2025 at 06:15:37PM +0530, Arun R Murthy wrote: > The function pointer can_async_flip() checks for async supported > modifier, add format support check also in the same function. You are changing intel_plane_can_async_flip(), not the .can_async_flip() vfunc. So this commit message d

Re: [PATCH v11 5/5] drm/i915/display: Indexed 8bit format does not support async flip

2025-03-28 Thread Ville Syrjälä
On Fri, Mar 28, 2025 at 06:15:39PM +0530, Arun R Murthy wrote: > Async flip is not supported with Indexed 8 bit format as it depends on > LUT and can't be updated atomically. > > Signed-off-by: Arun R Murthy Seems OK to me. Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/inte

[PATCH RFC v3 7/7] gpu: nova-core: add falcon register definitions and probe code

2025-03-28 Thread Alexandre Courbot
This is still very preliminary work, and is mostly designed to show how register fields can be turned into safe types that force us to handle invalid values. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/driver.rs| 2 +- drivers/gpu/nova-core/falcon.rs| 618 +++

Re: [PATCH v4 08/11] backlight: lcd: Replace fb events with a dedicated function call

2025-03-28 Thread Thomas Zimmermann
Hi Am 28.03.25 um 09:42 schrieb Lee Jones: On Mon, 24 Mar 2025, Thomas Zimmermann wrote: Hi Am 21.03.25 um 12:27 schrieb Daniel Thompson: On Fri, Mar 21, 2025 at 10:54:01AM +0100, Thomas Zimmermann wrote: Remove support for fb events from the lcd subsystem. Provide the helper lcd_notify_bla

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-28 Thread Danilo Krummrich
On Thu, Mar 27, 2025 at 03:01:54PM -0400, M Henning wrote: > On Thu, Mar 27, 2025 at 9:58 AM Danilo Krummrich wrote: > > > > On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > > > This is a pointer in the gpu's virtual address space. It must be > > > aligned according to ctxsw_align and

[PATCH v11 2/5] drm/plane: modify create_in_formats to acommodate async

2025-03-28 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[PATCH v11 3/5] drm/i915/display: Acomodate format check in can_async_flip()

2025-03-28 Thread Arun R Murthy
The function pointer can_async_flip() checks for async supported modifier, add format support check also in the same function. v11: Move filtering Indexed 8bit to a separate patch Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915

  1   2   >