Re: [PATCH v3] drm: Add UAPI for the Asahi driver

2025-03-23 Thread Simona Vetter
On Fri, Mar 14, 2025 at 07:23:16PM -0400, Alyssa Rosenzweig wrote: > This adds the UAPI for the Asahi driver targeting the GPU in the Apple > M1 and M2 series systems on chip. The UAPI design is based on other > modern Vulkan-capable drivers, including Xe and Panthor. Memory > management is based o

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-23 Thread Liu Ying
On 03/07/2025, Luca Ceresoli wrote: > This warning notifies a clock was set to an inaccurate value. Modify the > string to also show the clock name. > > While doing that also rewrap the entire function call. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/fsl-ldb.c | 6 +++--- >

linux-next: manual merge of the drm tree with Linus' tree

2025-03-23 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/xe/xe_bo.h between commit: 50af7cab7520 ("drm/xe: Fix exporting xe buffers multiple times") from Linus' tree and commit: 00c8efc3180f ("drm/xe: Add a shrinker for xe bos") from the drm tree. I fixed it

[PATCH v4] drm: Add UAPI for the Asahi driver

2025-03-23 Thread Alyssa Rosenzweig
This adds the UAPI for the Asahi driver targeting the GPU in the Apple M1 and M2 series systems on chip. The UAPI design is based on other modern Vulkan-capable drivers, including Xe and Panthor. Memory management is based on explicit VM management. Synchronization is exclusively explicit sync. Th

Re: [PATCH v2 10/15] drm/mediatek: add EXDMA support for MT8196

2025-03-23 Thread 胡俊光

Re: [PATCH v2 03/15] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-03-23 Thread 胡俊光

Re: [PATCH v1 1/7] virtio-gpu api: add blob userptr resource

2025-03-23 Thread Huang, Honglei1
On 2025/3/18 19:25, Huang, Honglei1 wrote: On 2025/3/18 9:37, Gurchetan Singh wrote: On Thu, Mar 6, 2025 at 2:52 AM Huang, Honglei1 > wrote:     On 2025/3/1 5:21, Demi Marie Obenour wrote: > On 2/28/25 12:36 AM, Honglei Huang wrote: >> From: Hon

Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

2025-03-23 Thread Liu Ying
On 03/07/2025, Luca Ceresoli wrote: > 'ret' can only be 0 at this point, being preceded by a 'if (ret) return > ret;'. So return 0 for clarity. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to mi

Re: [PATCH] drm/xe/svm: fix dereferencing error pointer in drm_gpusvm_range_alloc()

2025-03-23 Thread Christophe JAILLET
Le 23/03/2025 à 13:49, Harshit Mogalapalli a écrit : xe_svm_range_alloc() returns ERR_PTR(-ENOMEM) on failure and there is a dereference of "range" after that: --> range->gpusvm = gpusvm; In xe_svm_range_alloc(), when memory allocation fails return NULL instead to handle this situat

Re: [PATCH 3/4] drm/vc4: tests: Stop allocating the state in test init

2025-03-23 Thread Maíra Canal
Hi Maxime, On 18/03/25 11:17, Maxime Ripard wrote: The vc4-pv-muxing-combinations and vc5-pv-muxing-combinations test suites use a common test init function which, in part, allocates the drm atomic state the test will use. That allocation relies on drm_kunit_helper_atomic_state_alloc(), and th

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-23 Thread H. Peter Anvin
On March 23, 2025 8:16:24 AM PDT, Kuan-Wei Chiu wrote: >On Thu, Mar 13, 2025 at 03:41:49PM +0800, Kuan-Wei Chiu wrote: >> On Thu, Mar 13, 2025 at 12:29:13AM +0800, Kuan-Wei Chiu wrote: >> > On Wed, Mar 12, 2025 at 11:51:12AM -0400, Yury Norov wrote: >> > > On Tue, Mar 11, 2025 at 03:24:14PM -0700,

Re: [PATCH v2 -next] drm/xe: Fix unmet direct dependencies warning

2025-03-23 Thread Lucas De Marchi
On Sun, Mar 23, 2025 at 07:41:03PM +0800, Yue Haibing wrote: WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT

[BUG] drm_connector reference counting and USB-C docks

2025-03-23 Thread Chris Bainbridge
There is a reference couting / lifecycle issue with drm_connector when used with a USB-C dock. The problem has been previously reproduced on both Intel and AMD GPUs. On both Intel and AMD, the symptoms are: - multiple connectors being listed in sysfs `sys/class/drm/cardX/` (because the old

Re: [PATCH 4/4] drm/vc4: tests: Retry pv-muxing tests when EDEADLK

2025-03-23 Thread Maíra Canal
Hi Maxime, On 18/03/25 11:17, Maxime Ripard wrote: Some functions used by the HVS->PV muxing tests can return with EDEADLK, meaning the entire sequence should be restarted. It's not a fatal error and we should treat it as a recoverable error, and recover, instead of failing the test like we curr

Re: [PATCH RFC v3 6/7] gpu: nova-core: add basic timer device

2025-03-23 Thread Alexandre Courbot
On Sat Mar 22, 2025 at 1:20 AM JST, Daniel Brooks wrote: > "Alexandre Courbot" writes: > >> Hi Boqun, >> >> On Fri Mar 21, 2025 at 3:17 AM JST, Boqun Feng wrote: >>> Also an Instant type has been proposed and reviewed for a while: >>> >>> >>> https://lore.kernel.org/rust-for-linux/20250220070

Re: [PATCH v3] drm: Add UAPI for the Asahi driver

2025-03-23 Thread Daniel Almeida
Hi Alyssa, > +/** + * @DRM_ASAHI_BIND_SINGLE_PAGE: Map a single page of the BO repeatedly + * across the VA range. + * + * This is useful to fill a VA range with scratch pages or zero pages. + * It is intended as a mechanism t

Re: [PATCH v3] drm: Add UAPI for the Asahi driver

2025-03-23 Thread Alyssa Rosenzweig
> > > +/** > > > + * enum drm_asahi_bind_op - Bind operation > > > + */ > > > +enum drm_asahi_bind_op { > > > +/** @DRM_ASAHI_BIND_OP_BIND: Bind a BO to a GPU VMA range */ > > > +DRM_ASAHI_BIND_OP_BIND = 0, > > > + > > > +/** @DRM_ASAHI_BIND_OP_UNBIND: Unbind a GP

Re: [PATCH v3] drm: Add UAPI for the Asahi driver

2025-03-23 Thread Alyssa Rosenzweig
> Since this is a deparature from our usual requirement that all pieces > should be ready before landing anything we had discussion whether this is > an acceptable one-off exception for special circumstance. Thanks a lot to > Alyssa for driving this. The very much summarized consensus is that due t

Re: [PATCH RESEND 2/3] drm/bridge: it6505: modify DP link training work

2025-03-23 Thread Dmitry Baryshkov
On Tue, Mar 18, 2025 at 04:32:10PM +0800, Hermes Wu wrote: > The DP link training work include auto training and after > auto training failed "auto_train_retry" times, it switch to > step training mode. > > It will more efficiency that finish link auto training, > include retry, and step training

Re: [PATCH v6 0/5] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

2025-03-23 Thread Maíra Canal
On 17/03/25 22:01, Maíra Canal wrote: This series addresses GPU reset issues reported in [1], where running a long compute job would trigger repeated GPU resets, leading to a UI freeze. The patches that prevent the same faulty job from being resubmitted in a loop were merged in drm-misc/drm-misc

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-23 Thread Kuan-Wei Chiu
On Thu, Mar 13, 2025 at 03:41:49PM +0800, Kuan-Wei Chiu wrote: > On Thu, Mar 13, 2025 at 12:29:13AM +0800, Kuan-Wei Chiu wrote: > > On Wed, Mar 12, 2025 at 11:51:12AM -0400, Yury Norov wrote: > > > On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > > > > On March 11, 2025 3:01:30 PM

Re: [PATCH] drm/panel: himax-hx8394: transition to mipi_dsi wrapped functions

2025-03-23 Thread Dmitry Baryshkov
On Sun, Mar 23, 2025 at 11:00:07AM +0530, Tejas Vipin wrote: > Changes the himax-hx8394 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-himax-hx8394.c | 444 ++--- > 1 file changed, 210 insertion

Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for unterminated strings

2025-03-23 Thread Damian Tometzki
On Mon, 10. Mar 15:23, Kees Cook wrote: > When a character array without a terminating NUL character has a static > initializer, GCC 15's -Wunterminated-string-initialization will only > warn if the array lacks the "nonstring" attribute[1]. Mark the arrays > with __nonstring to and correctly identi

[PATCH] drm/xe/svm: fix dereferencing error pointer in drm_gpusvm_range_alloc()

2025-03-23 Thread Harshit Mogalapalli
xe_svm_range_alloc() returns ERR_PTR(-ENOMEM) on failure and there is a dereference of "range" after that: --> range->gpusvm = gpusvm; In xe_svm_range_alloc(), when memory allocation fails return NULL instead to handle this situation. Fixes: 99624bdff867 ("drm/gpusvm: Add support for

Re: [PATCH RESEND 3/3] drm/bridge: it6505: skip auto training when previous try fail

2025-03-23 Thread Dmitry Baryshkov
On Tue, Mar 18, 2025 at 04:32:11PM +0800, Hermes Wu wrote: > When connect to device which can only training done by > step training, skip auto training when link training restart, > usually happen when display resolution is changed. > > Signed-off-by: Hermes Wu > --- > drivers/gpu/drm/bridge/ite

Re: [PATCH RESEND 1/3] drm/bridge: it6505: modify DP link auto training

2025-03-23 Thread Dmitry Baryshkov
On Tue, Mar 18, 2025 at 04:32:09PM +0800, Hermes Wu wrote: > IT6505 supports HW link training which will write DPCD and check > training status automatically. > > In the case that driver set link rate at 2.7G and HW fail to training, > it will change link configuration and try 1.65G. And this will

[PATCH v2 -next] drm/xe: Fix unmet direct dependencies warning

2025-03-23 Thread Yue Haibing
WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y] DRM_XE_DISPLAY requires FB_IOMEM_HELPERS, but the depe

Re: [PATCH 08/18] drm/sysfb: Merge connector functions

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Merge the connector functions of ofdrm and simpledrm. Replace the > code in each driver with the shared helpers. Set up callbacks with > initializer macros. > > No effective code changes. The sysfb connector only returns the > preconfigured display mode. > > Signed-off

Re: [PATCH 07/18] drm/sysfb: Merge mode-config functions

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Provide initializer to set struct drm_mode_config_funcs. Convert > ofdrm and simpledrm. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 06/18] drm/sysfb: Provide single mode-init helper

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Merge the mode-init functions of ofdrm and simpledrm to the new helper > drm_sysfb_mode(). Also implement the DPI defaults there. Replace the > code in each driver with the shared helper. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canilla

Re: [PATCH 05/18] drm/sysfb: Add struct drm_sysfb_device

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add struct drm_sysfb_device that stores the system display's hardware > settings. Further helpers for the mode-setting pipeline will use these > fields. Convert ofdrm and simpledrm by embedding the sysfb device in > their device structs. > > Signed-off-by: Thomas Zimme

Re: [PATCH 04/18] drm: Move sysfb drivers into separate subdirectory

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The ofdrm and simpledrm drivers are special as they operate on > externally provided framebuffers. Move them into their own sub- > directory. Will let them share common code. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best

Re: [PATCH 03/18] drm/simpledrm: Remove struct simpledrm_device.nformats

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The field nformats is unused. Remove it. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/simpledrm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/tiny/simpledrm.c > b/drivers/gpu/drm/tiny/simpledrm.c > index 5d9ab8adf800.

Re: [PATCH 02/18] drm/ofdrm: Open-code drm_simple_encoder_init()

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The helper drm_simple_encoder_init() is a trivial helper around > drm_encoder_init() and therefore deprecated. Open-code the function > and remove the dependency. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Ja

Re: [PATCH 01/18] drm/ofdrm: Remove struct ofdrm_device.pdev

2025-03-23 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The field pdev is unused. Remove it. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ofdrm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c > index 13491c0e704a..7469dd281083 10064

[PATCH v8 00/10] Improve gpu_scheduler trace events + UAPI

2025-03-23 Thread Pierre-Eric Pelloux-Prayer
Hi, The initial goal of this series was to improve the drm and amdgpu trace events to be able to expose more of the inner workings of the scheduler and drivers to developers via tools. Then, the series evolved to become focused only on gpu_scheduler. The changes around vblank events will be part

[PATCH v2 3/7] drm/virtgpu api: add blob userptr resource

2025-03-23 Thread Honglei Huang
From: Honglei Huang This makes blob userptr resource available to guest userspace. - Flag VIRTGPU_BLOB_FLAG_USE_USERPTR for guest userspace blob create, enable this flag to indicate blob userptr resource create. - Flag VIRTGPU_BLOB_FLAG_USERPTR_RDONLY used for read only userptr, if not set then