Re: linux-next: build failure after merge of the driver-core tree

2025-03-19 Thread Stephen Rothwell
Hi Danilo, On Wed, 19 Mar 2025 12:16:39 +0100 Danilo Krummrich wrote: > > The following diff should fix the below conflict. > > diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs > index 63c19f140fbd..a08fb6599267 100644 > --- a/drivers/gpu/nova-core/driver.rs > +++ b

[PATCH v2] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-19 Thread Chris Bainbridge
Fix an oops in ttm_bo_delayed_delete which results from dererencing a dangling pointer: Oops: general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b6b7b: [#1] PREEMPT SMP CPU: 4 UID: 0 PID: 1082 Comm: kworker/u65:2 Not tainted 6.14.0-rc4-00267-g505460b44513-dirty #216 H

Re: [PATCH v2 18/57] irqdomain: gpu: Switch to irq_domain_create_linear()

2025-03-19 Thread Jiri Slaby
On 19. 03. 25, 14:31, Alex Deucher wrote: On Wed, Mar 19, 2025 at 5:44 AM Jiri Slaby (SUSE) wrote: irq_domain_add_linear() is going away as being obsolete now. Switch to the preferred irq_domain_create_linear(). That differs in the first parameter: It takes more generic struct fwnode_handle in

Re: [PATCH v6 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-19 Thread Yongbang Shi
On Mon, 10 Mar 2025, Yongbang Shi wrote: @@ -15,11 +15,17 @@ static int hibmc_dp_connector_get_modes(struct drm_connector *connector) { + struct hibmc_dp *dp = to_hibmc_dp(connector); + const struct drm_edid *drm_edid; int count; - count = drm_add_modes_noedid(c

[PATCH 1/2] arm64: dts: qcom: sa8775p: add GPDSP fastrpc-compute-cb nodes

2025-03-19 Thread Ling Xu
Add GPDSP0 and GPDSP1 fastrpc compute-cb nodes for sa8775p SoC. Signed-off-by: Ling Xu --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 58 +++ 1 file changed, 58 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 5

Re: [PATCH v7 drm-dp 0/9] Add HPD, getting EDID, colorbar features in DP function

2025-03-19 Thread Yongbang Shi
On Wed, Mar 19, 2025 at 11:24:26AM +0800, Yongbang Shi wrote: From: Baihan Li To support DP HPD, edid printing, and colorbar display features based on the Hisislcon DP devices. --- ChangeLog: v6 -> v7: - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nik

[PATCH 2/2] misc: fastrpc: add support for gpdsp remoteproc

2025-03-19 Thread Ling Xu
The fastrpc driver has support for 5 types of remoteprocs. There are some products which support GPDSP remoteprocs. Add changes to support GPDSP remoteprocs. Signed-off-by: Ling Xu --- drivers/misc/fastrpc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/m

[PATCH 0/2] Add support for gpdsp remoteproc on sa8775p

2025-03-19 Thread Ling Xu
The fastrpc driver has support for 5 types of remoteprocs. There are some products which support GPDSP remoteprocs. GPDSPs are General Purpose DSPs where tasks can be offloaded. Add changes to support GPDSP remoteprocs and also add GPDSP fastrpc nodes. Ling Xu (2): arm64: dts: qcom: sa8775p: add

RE: [PATCH] drm/amdgpu: Higher log level for missing PCIe atomics caps

2025-03-19 Thread Daisuke Matsuda (Fujitsu)
On Tue, Mar 18, 2025 5:35 AM Felix Kuehling wrote: > On 2025-03-17 15:07, Deucher, Alexander wrote: > > [Public] > > > >> -Original Message- > >> From: Daisuke Matsuda > >> Sent: Thursday, March 13, 2025 9:18 PM > >> To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > >>

Re: [PATCH 1/2] drm/amd/display: Protect dml2_create()/dml2_copy()/dml2_create_copy()

2025-03-19 Thread Huacai Chen
Hi, Alex, On Thu, Mar 20, 2025 at 10:16 AM Alex Hung wrote: > > > > On 3/18/25 05:17, Huacai Chen wrote: > > Commit 7da55c27e76749b9 ("drm/amd/display: Remove incorrect FP context > > start") removes the FP context protection of dml2_create(), and it said > > "All the DC_FP_START/END should be us

Re: [PATCH 2/2] drm/amd/display: Protect dml2_validate() from its callers

2025-03-19 Thread Alex Hung
Please see comments for patch 1. On 3/18/25 05:17, Huacai Chen wrote: Similar to dml2_create()/dml2_copy()/dml2_create_copy(), dml2_validate() should also be protected from its callers because "All the DC_FP_START/END should be used before call anything from DML2". So protect dml2_validate() wi

Re: [PATCH 1/2] drm/amd/display: Protect dml2_create()/dml2_copy()/dml2_create_copy()

2025-03-19 Thread Alex Hung
On 3/18/25 05:17, Huacai Chen wrote: Commit 7da55c27e76749b9 ("drm/amd/display: Remove incorrect FP context start") removes the FP context protection of dml2_create(), and it said "All the DC_FP_START/END should be used before call anything from DML2". However, dml2_create()/dml2_copy()/dml2_

Re: [PATCH v2] fbcon: Use static attribute groups for sysfs entries

2025-03-19 Thread Helge Deller
On 3/14/25 09:16, Thomas Zimmermann wrote: Am 14.03.25 um 07:09 schrieb oushixiong1...@163.com: From: Shixiong Ou Using device_create_with_groups() to simplify creation and removal. Same as commit 1083a7be4504 ("tty: Use static attribute groups for sysfs entries"). Signed-off-by: Shixiong Ou

Re: [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-19 Thread Andy Shevchenko
On Wed, Mar 19, 2025 at 11:30 AM Jiri Slaby (SUSE) wrote: > > Hi, > > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during

Re: [PATCH v8 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-19 Thread Jianxun Zhang
On 3/13/25 11:34, Jonathan Cavitt wrote: Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jca

Re: [PATCH v2 5/7] drm/tests: hdmi: Add macros to simplify EDID setup

2025-03-19 Thread Cristian Ciocaltea
On 3/19/25 5:32 PM, Maxime Ripard wrote: > On Wed, Mar 12, 2025 at 12:44:26AM +0200, Cristian Ciocaltea wrote: >> On 3/11/25 6:12 PM, Maxime Ripard wrote: >>> On Tue, Mar 11, 2025 at 12:57:37PM +0200, Cristian Ciocaltea wrote: Introduce a few macros to facilitate setting custom (i.e. non-defau

Re: [PATCH v9 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-19 Thread Jianxun Zhang
On 3/19/25 14:13, Cavitt, Jonathan wrote: -Original Message- From: Zhang, Jianxun Sent: Wednesday, March 19, 2025 2:02 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin, Shuicheng ; dri-de

Re: [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-19 Thread Jiri Slaby
On 19. 03. 25, 11:21, Andy Shevchenko wrote: I am all to support the idea, but in some cases I would think of a bit more work to be done to get rid of the of_fwnode_handle(np) in favour of dev_fwnode(dev). Note, this is based on a brief look, I haven't any example at hand right now. Aah, that's

Re: [PATCH] video: fbdev: sm501fb: Add some geometry checks.

2025-03-19 Thread Helge Deller
On 3/19/25 02:30, Danila Chernetsov wrote: Added checks for xoffset, yoffset settings. Incorrect settings of these parameters can lead to errors in sm501fb_pan_ functions. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5fc404e47bdf ("[PATCH] fb: SM501 framebuffer drive

RE: [PATCH v9 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-19 Thread Cavitt, Jonathan
-Original Message- From: Zhang, Jianxun Sent: Wednesday, March 19, 2025 2:02 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org; Wajdeczko, Michal

Re: [PATCH v2 16/34] drm/msm: Mark VM as unusable on faults

2025-03-19 Thread Rob Clark
On Wed, Mar 19, 2025 at 9:15 AM Connor Abbott wrote: > > On Wed, Mar 19, 2025 at 10:55 AM Rob Clark wrote: > > > > From: Rob Clark > > > > If userspace has opted-in to VM_BIND, then GPU faults and VM_BIND errors > > will mark the VM as unusable. > > > > Signed-off-by: Rob Clark > > --- > > dri

RE: [PATCH v9 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-19 Thread Cavitt, Jonathan
-Original Message- From: Zhang, Jianxun Sent: Wednesday, March 19, 2025 12:59 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org; Wajdeczko, Michal

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-19 Thread Doug Anderson
Hi, On Wed, Mar 19, 2025 at 11:31 AM Tejas Vipin wrote: > > Changes the samsung-s6d7aa0 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Remove unnecessary early return in s6d7aa0_lock > - Remove redundant GPIO re

Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

2025-03-19 Thread Conor Dooley
On Tue, Mar 18, 2025 at 03:14:07AM +, Sunny Shen (沈姍姍) wrote: > On Mon, 2025-02-24 at 19:01 +, Conor Dooley wrote: > > On Sun, Feb 23, 2025 at 05:49:45PM +, Sunny Shen (沈姍姍) wrote: > > > On Tue, 2025-02-11 at 17:54 +, Conor Dooley wrote: > > > > On Tue, Feb 11, 2025 at 10:52:50AM +0

Re: [PATCH v9 3/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-19 Thread Jianxun Zhang
On 3/18/25 10:11, Jonathan Cavitt wrote: Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) Signed-off-by: Jonathan Cavitt Cc: Zhang Jianxun --- include/uapi/drm/xe_drm.h | 80 ++

Re: [PATCH] drm/amdgpu: Higher log level for missing PCIe atomics caps

2025-03-19 Thread Felix Kuehling
On 2025-03-19 03:02, Daisuke Matsuda (Fujitsu) wrote: On Tue, Mar 18, 2025 5:35 AM Felix Kuehling wrote: On 2025-03-17 15:07, Deucher, Alexander wrote: [Public] -Original Message- From: Daisuke Matsuda Sent: Thursday, March 13, 2025 9:18 PM To: amd-...@lists.freedesktop.org; dri-deve

[PATCH v2 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-19 Thread Adrián Larumbe
Allow UM to label a BO for which it possesses a DRM handle. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panthor/panthor_drv.c | 37 +++ include/uapi/drm/panthor_drm.h| 19 ++ 2 files changed, 56 insertions(+) diff --git a/drivers/gpu/drm/panthor

Re: [PATCH 00/18] drm: Provide helpers for system framebuffers and add efidrm/vesadrm

2025-03-19 Thread nerdopolis
On Wednesday, March 19, 2025 3:44:59 AM EDT Thomas Zimmermann wrote: > This series simplifies the existing ofdrm and simepldrm drivers, > and adds new drivers for EFI- and VESA-based framebuffers. Existing > drivers for system framebuffers, ofdrm and simpledrm, share much of > their mode-setting pi

Re: [PATCH v2 5/7] drm/tests: hdmi: Add macros to simplify EDID setup

2025-03-19 Thread Maxime Ripard
On Wed, Mar 12, 2025 at 12:44:26AM +0200, Cristian Ciocaltea wrote: > On 3/11/25 6:12 PM, Maxime Ripard wrote: > > On Tue, Mar 11, 2025 at 12:57:37PM +0200, Cristian Ciocaltea wrote: > >> Introduce a few macros to facilitate setting custom (i.e. non-default) > >> EDID data during connector initiali

[PATCH v2] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-19 Thread Tejas Vipin
Changes the samsung-s6d7aa0 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- Changes in v2: - Remove unnecessary early return in s6d7aa0_lock - Remove redundant GPIO reset setting in s6d7aa0_on. Link to v1: https://lore.kernel.org/all/202503

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-19 Thread Thierry Reding
On Mon, Mar 10, 2025 at 12:34:35PM +, Diogo Ivo wrote: > > Hello again, > > On 2/4/25 7:18 PM, Jason Gunthorpe wrote: > > Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain > > could have been left as NULL. The NULL domain is specially recognized by > > host1x_iommu_at

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-19 Thread Thierry Reding
On Tue, Feb 04, 2025 at 03:18:19PM -0400, Jason Gunthorpe wrote: > Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain > could have been left as NULL. The NULL domain is specially recognized by > host1x_iommu_attach() as meaning it is not the DMA domain and > should be replac

Re: [PATCH RESEND 0/2] Refactoring the fbcon packed pixel drawing routines

2025-03-19 Thread Helge Deller
On 3/9/25 19:47, Zsolt Kajtar wrote: This is the same patch as before just updated to latest fbdev master and with better description. And hopefully sent intact this time. Zsolt Kajtar (2): Refactoring the fbcon packed pixel drawing routines Adding contact info for packed pixel drawing T

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Tamir Duberstein
On Wed, Mar 19, 2025 at 12:43 PM Miguel Ojeda wrote: > > On Wed, Mar 19, 2025 at 5:13 PM Tamir Duberstein wrote: > > > > No, I meant avoiding the check. The existing code already explicitly > > checks `new_len > self.len()` before evaluating `new_len - > > self.len()`. This means the check occurs

Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support

2025-03-19 Thread Sverdlin, Alexander
Thank you for the patches, Aradhya! On Sun, 2024-11-24 at 20:06 +0530, Aradhya Bhatia wrote: > Regardless, I'd appreciate it if somebody can test it, and report back if they > observe any issues. I've tried to test the patchset with necessary pre-requisites and DT additions with a single channel

Re: DRM CI

2025-03-19 Thread Helen Koike
Hi Maxime, On 19/03/2025 11:11, Maxime Ripard wrote: Hi, At last Plumbers, we agreed with Dave that a good first step to ramp up CI for DRM trees would be to enable build and kunit testing in the main DRM tree. I played around with it last week and wrote a good first iteration of the gitlab-ci

Re: [PATCH v1 2/3] drm/ci: uprev IGT

2025-03-19 Thread Helen Mae Koike Fornazier
Em sex., 14 de mar. de 2025 às 05:59, Vignesh Raman escreveu: > > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman It feels that the xfails list is growing more instead of shrinking, well... Acked-by: Helen Koike Thanks Helen > --- > drivers/gpu

Re: [PATCH v1 1/3] drm/ci: uprev mesa

2025-03-19 Thread Helen Mae Koike Fornazier
Em qua., 19 de mar. de 2025 às 10:24, Vignesh Raman escreveu: > > Hi Helen, > > On 19/03/25 00:22, Helen Mae Koike Fornazier wrote: > > Em sex., 14 de mar. de 2025 às 05:59, Vignesh Raman > > escreveu: > >> > >> LAVA was recently patched [1] with a fix on how parameters are parsed in > >> `lava-t

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-19 Thread Jason Gunthorpe
On Thu, Mar 13, 2025 at 03:32:14PM +0100, Simona Vetter wrote: > So I think you can still achieve that building on top of revocable and a > few more abstractions that are internally unsafe. Or are you thinking of > different runtime checks? I'm thinking on the access side of the revocable you don

Re: [PATCH v2 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-19 Thread Boris Brezillon
On Wed, 19 Mar 2025 15:03:17 + Adrián Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. > > Signed-off-by: Adrián Larumbe > --- > drivers/gpu/drm/panthor/panthor_drv.c | 37 +++ > include/uapi/drm/panthor_drm.h| 19 ++ >

Re: [PATCH] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-03-19 Thread Anusha Srivatsa
On Tue, 18 Mar 2025 at 12:00 PM, Dmitry Baryshkov < dmitry.barysh...@oss.qualcomm.com> wrote: > On Tue, 18 Mar 2025 at 18:55, Anusha Srivatsa wrote: > > > > On Sun, Mar 16, 2025 at 7:32 PM Dmitry Baryshkov < > dmitry.barysh...@oss.qualcomm.com> wrote: > >> > >> On Sun, Mar 16, 2025 at 02:58:22PM

Re: [PATCH v2 4/4] drm/panthor: Display heap chunk entries in DebugFS GEMS file

2025-03-19 Thread Boris Brezillon
On Wed, 19 Mar 2025 15:03:19 + Adrián Larumbe wrote: > Expand the driver's DebugFS GEMS file to display entries for the heap > chunks' GEM objects, both those allocated at heap creation time through an > ioctl(), or in response to a tiler OOM event. > > Signed-off-by: Adrián Larumbe > --- >

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Miguel Ojeda
On Wed, Mar 19, 2025 at 5:13 PM Tamir Duberstein wrote: > > No, I meant avoiding the check. The existing code already explicitly > checks `new_len > self.len()` before evaluating `new_len - > self.len()`. This means the check occurs twice. `checked_sub` reduces > the number of checks by 1. Perhaps

Re: [PATCH v2 1/4] drm/panthor: Introduce BO labeling

2025-03-19 Thread Boris Brezillon
On Wed, 19 Mar 2025 15:03:16 + Adrián Larumbe wrote: > Add a new character string Panthor BO field, and a function that allows > setting it from within the driver. > > Driver takes care of freeing the string when it's replaced or no longer > needed at object destruction time, but allocating

Re: [PATCH 4/4] drm/panthor: Display heap chunk entries in DebugFS GEMS file

2025-03-19 Thread Boris Brezillon
On Wed, 19 Mar 2025 13:18:53 + Adrián Larumbe wrote: > On 17.03.2025 09:31, Boris Brezillon wrote: > > On Sun, 16 Mar 2025 21:51:35 + > > Adrián Larumbe wrote: > > > > > Expand the driver's DebugFS GEMS file to display entries for the heap > > > chunks' GEM objects, both those allocate

Re: [PATCH 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-19 Thread Boris Brezillon
On Wed, 19 Mar 2025 13:49:02 + Adrián Larumbe wrote: > Hi Boris, > > On 17.03.2025 08:50, Boris Brezillon wrote: > > On Sun, 16 Mar 2025 21:51:33 + > > Adrián Larumbe wrote: > > > > > Allow UM to label a BO for which it possesses a DRM handle. > > > > > > Signed-off-by: Adrián Larumbe

Re: [PATCH v7 00/11] drm/bridge: add devm_drm_bridge_alloc() with bridge refcount

2025-03-19 Thread Maxime Ripard
On Mon, Mar 17, 2025 at 03:56:07PM +0100, Luca Ceresoli wrote: > Hello Maxime, > > On Fri, 14 Mar 2025 19:21:01 +0100 > Maxime Ripard wrote: > > > Hi, > > > > On Fri, Mar 14, 2025 at 11:31:13AM +0100, Luca Ceresoli wrote: > > > This series improves the way DRM bridges are allocated and > > > in

Re: [PATCH v2 16/34] drm/msm: Mark VM as unusable on faults

2025-03-19 Thread Connor Abbott
On Wed, Mar 19, 2025 at 10:55 AM Rob Clark wrote: > > From: Rob Clark > > If userspace has opted-in to VM_BIND, then GPU faults and VM_BIND errors > will mark the VM as unusable. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem.h| 17 + > drivers/gpu/drm/

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Tamir Duberstein
On Wed, Mar 19, 2025 at 12:06 PM Miguel Ojeda wrote: > > On Wed, Mar 19, 2025 at 4:59 PM Tamir Duberstein wrote: > > > > If we're talking about the same thing then I think we're both wrong > > and the correct phrasing would have been: "you can avoid underflow > > checking when CONFIG_RUST_OVERFLO

[PATCH v2 14/34] drm/msm: Lazily create context VM

2025-03-19 Thread Rob Clark
From: Rob Clark In the next commit, a way for userspace to opt-in to userspace managed VM is added. For this to work, we need to defer creation of the VM until it is needed. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 ++- drivers/gpu/drm/msm/adreno/adreno_gpu.c

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Miguel Ojeda
On Wed, Mar 19, 2025 at 4:59 PM Tamir Duberstein wrote: > > If we're talking about the same thing then I think we're both wrong > and the correct phrasing would have been: "you can avoid underflow > checking when CONFIG_RUST_OVERFLOW_CHECKS=y by using `checked_sub`". I > was referring to the under

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Tamir Duberstein
On Wed, Mar 19, 2025 at 10:34 AM Benno Lossin wrote: > > On Wed Mar 19, 2025 at 2:42 PM CET, Tamir Duberstein wrote: > > On Tue, Mar 18, 2025 at 8:50 PM Benno Lossin wrote: > >> > >> On Tue Mar 18, 2025 at 9:12 PM CET, Tamir Duberstein wrote: > >> > On Sun, Mar 16, 2025 at 7:17 AM Andrew Ballance

Re: [PATCH v6 3/4] drm/bridge-connector: hook DisplayPort audio support

2025-03-19 Thread Maxime Ripard
On Fri, 14 Mar 2025 11:36:50 +0200, Dmitry Baryshkov wrote: > Reuse existing code plumbing HDMI audio support and the existing HDMI > audio helpers that register HDMI codec device and plumb in the > DisplayPort audio interfaces to be handled by the drm_bridge_connector. > > Signed-off-by: Dmitry B

[PATCH v2 03/34] drm/gpuvm: Allow VAs to hold soft reference to BOs

2025-03-19 Thread Rob Clark
From: Rob Clark Eases migration for drivers where VAs don't hold hard references to their associated BO, avoiding reference loops. In particular, msm uses soft references to optimistically keep around mappings until the BO is distroyed. Which obviously won't work if the VA (the mapping) is hold

[PATCH v2 13/34] drm/msm: Split submit_pin_objects()

2025-03-19 Thread Rob Clark
From: Rob Clark For VM_BIND, in the first step, we just want to get the backing pages, but defer creating the vma until the map/unmap/ops are evaluated. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 27 +++ 1 file changed, 19 insertions(+), 8 delet

RE: [PATCH v9 2/6] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-19 Thread Cavitt, Jonathan
-Original Message- From: Wajdeczko, Michal Sent: Tuesday, March 18, 2025 3:02 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org;

[PATCH v2 1/4] drm/panthor: Introduce BO labeling

2025-03-19 Thread Adrián Larumbe
Add a new character string Panthor BO field, and a function that allows setting it from within the driver. Driver takes care of freeing the string when it's replaced or no longer needed at object destruction time, but allocating it is the responsibility of callers. Signed-off-by: Adrián Larumbe

[PATCH v2 0/4] Panthor BO tagging and GEMS debug display

2025-03-19 Thread Adrián Larumbe
This patch series is aimed at providing UM with detailed memory profiling information in debug builds. It is achieved through a device-wide list of DRM GEM objects, and also implementing the ability to label BO's from UM through a new IOCTL. The new debugfs file shows a list of driver DRM GEM obje

[PATCH v2 04/34] drm/gpuvm: Add drm_gpuvm_sm_unmap_va()

2025-03-19 Thread Rob Clark
From: Rob Clark Add drm_gpuvm_sm_unmap_va(), which works similarly to drm_gpuvm_sm_unmap(), except that it operates on a single VA at a time. This is needed by drm/msm, where due to locking ordering we cannot reuse drm_gpuvm_sm_unmap() as-is. This helper lets us reuse the logic about remaps vs

[PATCH v2 27/34] drm/msm: Pre-allocate pages for pgtable entries

2025-03-19 Thread Rob Clark
From: Rob Clark Introduce a mechanism to count the worst case # of pages required in a VM_BIND op. Note that previously we would have had to somehow account for allocations in unmap, when splitting a block. This behavior was removed in commit 33729a5fc0ca ("iommu/io-pgtable-arm: Remove split on

linux-next: build failure after merge of the driver-core tree

2025-03-19 Thread Stephen Rothwell
Hi all, After merging the driver-core tree, today's linux-next build (x86_64 allmodconfig) failed like this: error[E0053]: method `probe` has an incompatible type for trait --> drivers/gpu/nova-core/driver.rs:30:20 | 30 | fn probe(pdev: &mut pci::Device, _info: &Self::IdInfo) -> Result>

[PATCH v2 21/34] drm/msm: Add mmu support for non-zero offset

2025-03-19 Thread Rob Clark
From: Rob Clark Only needs to be supported for iopgtables mmu, the other cases are either only used for kernel managed mappings (where offset is always zero) or devices which do not support sparse bindings. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 - drive

[PATCH v2 05/34] drm/msm: Rename msm_file_private -> msm_context

2025-03-19 Thread Rob Clark
From: Rob Clark This is a more descriptive name. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 +-- drivers/gpu/drm/msm/msm_drv.c | 14 - drivers/gp

[PATCH v2 32/34] drm/msm: Crashdec support for sparse

2025-03-19 Thread Rob Clark
From: Rob Clark In this case, we need to iterate the VMAs looking for ones with MSM_VMA_DUMP flag. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 73 +-- 1 file changed, 52 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c

[PATCH v2 16/34] drm/msm: Mark VM as unusable on faults

2025-03-19 Thread Rob Clark
From: Rob Clark If userspace has opted-in to VM_BIND, then GPU faults and VM_BIND errors will mark the VM as unusable. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h| 17 + drivers/gpu/drm/msm/msm_gem_submit.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.c|

[PATCH v2 31/34] drm/msm: rd dumping prep for sparse mappings

2025-03-19 Thread Rob Clark
From: Rob Clark Similar to the previous commit, add support for dumping partial mappings. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h | 10 - drivers/gpu/drm/msm/msm_rd.c | 38 --- 2 files changed, 17 insertions(+), 31 deletions(-) diff

[PATCH v2 33/34] drm/msm: rd dumping support for sparse

2025-03-19 Thread Rob Clark
From: Rob Clark As with devcoredump, we need to iterate the VMAs to figure out what to dump. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_rd.c | 48 +--- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drive

[PATCH v2 34/34] drm/msm: Bump UAPI version

2025-03-19 Thread Rob Clark
From: Rob Clark Bump version to signal to userspace that VM_BIND is supported. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 70c3a3712a3e..ee5a

[PATCH v2 25/34] drm/msm: Pre-allocate VMAs

2025-03-19 Thread Rob Clark
From: Rob Clark Pre-allocate the VMA objects that we will need in the vm bind job. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h| 9 + drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++ drivers/gpu/drm/msm/msm_gem_vma.c| 60 3 files change

[PATCH v2 29/34] drm/msm: Wire up drm_gpuvm debugfs

2025-03-19 Thread Rob Clark
From: Rob Clark Core drm already provides a helper to dump vm state. We just need to wire up tracking of VMs and giving userspace VMs a suitable name. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/msm_debugfs.c | 20 d

[PATCH v2 17/34] drm/msm: Extend SUBMIT ioctl for VM_BIND

2025-03-19 Thread Rob Clark
From: Rob Clark This is a bit different than the path taken by other clean-slate drivers. But there is a lot in similar with BO pinning in the legacy "EXEC" path and "VM_BIND" MAP path. Also, we want the same fence and syncobj handling. (Why bother with fence fd's? Because for virtgpu nctx fo

[PATCH v2 28/34] drm/msm: Wire up gpuvm ops

2025-03-19 Thread Rob Clark
From: Rob Clark Hook up the map/remap/unmap ops to apply MAP/UNMAP operations. The MAP/UNMAP operations are split up by drm_gpuvm into a series of map/ remap/unmap ops, for example an UNMAP operation which spans multiple vmas will get split up into a sequence of unmap (and possibly remap) ops wh

[PATCH v2 23/34] drm/msm: Rename msm_gem_vma_purge() -> _unmap()

2025-03-19 Thread Rob Clark
From: Rob Clark This is a more descriptive name. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 4 ++-- drivers/gpu/drm/msm/msm_gem.h | 2 +- drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_g

[PATCH v2 24/34] drm/msm: Split msm_gem_vma_new()

2025-03-19 Thread Rob Clark
From: Rob Clark Split memory allocation from vma initialization. Async vm-bind happens in the fence signalling path, so it will need to use pre-allocated memory. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 67 ++- 1 file changed, 49 insertions(

[PATCH v2 22/34] drm/msm: Add PRR support

2025-03-19 Thread Rob Clark
From: Rob Clark Add PRR (Partial Resident Region) is a bypass address which make GPU writes go to /dev/null and reads return zero. This is used to implement vulkan sparse residency. To support PRR/NULL mappings, we allocate a page to reserve a physical address which we know will not be used as

[PATCH v2 20/34] drm/msm: Split out helper to get iommu prot flags

2025-03-19 Thread Rob Clark
From: Rob Clark We'll re-use this in the vm_bind path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 12 ++-- drivers/gpu/drm/msm/msm_gem.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem

[PATCH v2 18/34] drm/msm: Add VM_BIND submitqueue

2025-03-19 Thread Rob Clark
From: Rob Clark This submitqueue type isn't tied to a hw ringbuffer, but instead executes on the CPU for performing async VM_BIND ops. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 3 +- drivers/gpu/drm/msm/msm_gem.h | 10 ++ drivers/gpu/drm/msm/msm_gem_submit

[PATCH v2 15/34] drm/msm: Add opt-in for VM_BIND

2025-03-19 Thread Rob Clark
From: Rob Clark Add a SET_PARAM for userspace to request to manage to the VM itself, instead of getting a kernel managed VM. In order to transition to a userspace managed VM, this param must be set before any mappings are created. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_g

[PATCH v2 11/34] drm/msm: drm_gpuvm conversion

2025-03-19 Thread Rob Clark
From: Rob Clark Now that we've realigned deletion and allocation, switch over to using drm_gpuvm/drm_gpuva. This allows us to support multiple VMAs per BO per VM, to allow mapping different parts of a single BO at different virtual addresses, which is a key requirement for sparse/VM_BIND. This

[PATCH v2 10/34] drm/msm: Collapse vma close and delete

2025-03-19 Thread Rob Clark
From: Rob Clark This fits better drm_gpuvm/drm_gpuva. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 16 +++- drivers/gpu/drm/msm/msm_gem_vma.c | 2 ++ 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm

[PATCH v2 08/34] drm/msm: Remove vram carveout support

2025-03-19 Thread Rob Clark
From: Rob Clark It is standing in the way of drm_gpuvm / VM_BIND support. Not to mention frequently broken and rarely tested. And I think only needed for a 10yr old not quite upstream SoC (msm8974). Maybe we can add support back in later, but I'm doubtful. Signed-off-by: Rob Clark --- drive

[PATCH v2 12/34] drm/msm: Use drm_gpuvm types more

2025-03-19 Thread Rob Clark
From: Rob Clark Most of the driver code doesn't need to reach in to msm specific fields, so just use the drm_gpuvm/drm_gpuva types directly. This should hopefully improve commonality with other drivers and make the code easier to understand. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/ad

[PATCH v2 09/34] drm/msm: Collapse vma allocation and initialization

2025-03-19 Thread Rob Clark
From: Rob Clark Now that we've dropped vram carveout support, we can collapse vma allocation and initialization. This better matches how things work with drm_gpuvm. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 30 +++--- drivers/gpu/drm/msm/msm_gem.h

[PATCH v2 07/34] drm/msm: Rename msm_gem_address_space -> msm_gem_vm

2025-03-19 Thread Rob Clark
From: Rob Clark Re-aligning naming to better match drm_gpuvm terminology will make things less confusing at the end of the drm_gpuvm conversion. This is just rename churn, no functional change. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 18 ++-- drivers/gpu/d

[PATCH v2 06/34] drm/msm: Improve msm_context comments

2025-03-19 Thread Rob Clark
From: Rob Clark Just some tidying up. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.h | 44 +++ 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 957d6fb3469d..c699ce0c5

[PATCH v2 01/34] drm/gpuvm: Don't require obj lock in destructor path

2025-03-19 Thread Rob Clark
From: Rob Clark See commit a414fe3a2129 ("drm/msm/gem: Drop obj lock in msm_gem_free_object()") for justification. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_gpuvm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/d

[PATCH v2 00/34] drm/msm: sparse / "VM_BIND" support

2025-03-19 Thread Rob Clark
From: Rob Clark Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of: 1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands 2. Extending the SUBMIT ioctl to allow submitting batches of one or more MAP

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Benno Lossin
On Wed Mar 19, 2025 at 2:42 PM CET, Tamir Duberstein wrote: > On Tue, Mar 18, 2025 at 8:50 PM Benno Lossin wrote: >> >> On Tue Mar 18, 2025 at 9:12 PM CET, Tamir Duberstein wrote: >> > On Sun, Mar 16, 2025 at 7:17 AM Andrew Ballance >> > wrote: >> >> +pub fn resize(&mut self, new_len: usize,

DRM CI

2025-03-19 Thread Maxime Ripard
Hi, At last Plumbers, we agreed with Dave that a good first step to ramp up CI for DRM trees would be to enable build and kunit testing in the main DRM tree. I played around with it last week and wrote a good first iteration of the gitlab-ci file. https://gitlab.freedesktop.org/mripard/gitlab/-/

Re: [PATCH v2] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-19 Thread Danilo Krummrich
On Wed, Mar 19, 2025 at 03:06:52PM +0100, Christian König wrote: > Am 19.03.25 um 14:04 schrieb Danilo Krummrich: > > >> Signed-off-by: Chris Bainbridge > >> Co-Developed-by: Christian König > > Then also Christian's SoB is required. > > I only pointed out which two lines in nouveau need to mov

Re: [PATCH] Documentation: vgaarbiter: Fix grammar

2025-03-19 Thread Maxime Ripard
On Tue, 18 Mar 2025 11:12:50 +0700, Bagas Sanjaya wrote: > Correct grammar issues: > > - Fix "co-exist" subject-verb agreement > - Correct plural form of "server" in context of more than one legacy > devices > - Use passive mood for intro sentence of libpciaccess section > > [...] Applied to m

Re: [PATCH v2] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

2025-03-19 Thread Christian König
Am 19.03.25 um 14:04 schrieb Danilo Krummrich: > Hi Chris, > > Thanks for the fix, few comments below. > > On Wed, Mar 19, 2025 at 12:54:26PM +, Chris Bainbridge wrote: >> Fix an oops in ttm_bo_delayed_delete which results from dererencing a >> dangling pointer: >> >> Oops: general protection f

Re: [PATCH 2/4] drm/panthor: Add driver IOCTL for setting BO labels

2025-03-19 Thread Adrián Larumbe
Hi Boris, On 17.03.2025 08:50, Boris Brezillon wrote: > On Sun, 16 Mar 2025 21:51:33 + > Adrián Larumbe wrote: > > > Allow UM to label a BO for which it possesses a DRM handle. > > > > Signed-off-by: Adrián Larumbe > > --- > > drivers/gpu/drm/panthor/panthor_drv.c | 31 +

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-19 Thread Guenter Roeck
On 3/19/25 01:05, Christophe Leroy wrote: Le 18/03/2025 à 16:59, Will Deacon a écrit : On Thu, Mar 13, 2025 at 05:40:59PM +0100, Alessandro Carminati wrote: On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: diff --git

Re: [PATCH v2 2/3] rust: alloc: add Vec::resize method

2025-03-19 Thread Tamir Duberstein
On Tue, Mar 18, 2025 at 8:50 PM Benno Lossin wrote: > > On Tue Mar 18, 2025 at 9:12 PM CET, Tamir Duberstein wrote: > > On Sun, Mar 16, 2025 at 7:17 AM Andrew Ballance > > wrote: > >> +pub fn resize(&mut self, new_len: usize, value: T, flags: Flags) -> > >> Result<(), AllocError> { > >> +

[PATCH 10/18] drm/sysfb: Merge CRTC functions

2025-03-19 Thread Thomas Zimmermann
Merge the CRTC functions of ofdrm and simpledrm. Replace the code in each driver with the shared helpers. Set up callbacks with initializer macros. Ofdrm supports a gamma LUT, while simpledrm does not. So far ofdrm's LUT size has been hard-coded in the driver CRTC's atomic_check helper. Now pass t

[PATCH 17/18] drm/sysfb: vesadrm: Add EDID support

2025-03-19 Thread Thomas Zimmermann
Enable the connector's EDID property if edid_info contains valid data. Exports the EDID via sysfs for user-space compositors. EDID information is not always available. Depending on the system and kernel configuration, it is either provided by the boot loader or read by the kernel during early boot

Re: [PATCH v1 1/3] drm/ci: uprev mesa

2025-03-19 Thread Vignesh Raman
Hi Helen, On 19/03/25 00:22, Helen Mae Koike Fornazier wrote: Em sex., 14 de mar. de 2025 às 05:59, Vignesh Raman escreveu: LAVA was recently patched [1] with a fix on how parameters are parsed in `lava-test-case`, so we don't need to repeat quotes to send the arguments properly to it. Uprev

Re: [PATCH v6 4/7] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*()

2025-03-19 Thread Yury Norov
On Wed, Mar 19, 2025 at 01:37:32PM +0900, Vincent Mailhol wrote: > On 19/03/2025 at 07:32, Jani Nikula wrote: > > On Tue, 18 Mar 2025, Yury Norov wrote: > >> On Sat, Mar 08, 2025 at 01:48:51AM +0900, Vincent Mailhol via B4 Relay > >> wrote: > >>> From: Lucas De Marchi > >>> > >>> Now that includ

Re: [PATCH 4/4] drm/panthor: Display heap chunk entries in DebugFS GEMS file

2025-03-19 Thread Adrián Larumbe
On 17.03.2025 09:31, Boris Brezillon wrote: > On Sun, 16 Mar 2025 21:51:35 + > Adrián Larumbe wrote: > > > Expand the driver's DebugFS GEMS file to display entries for the heap > > chunks' GEM objects, both those allocated at heap creation time through an > > ioctl(), or in response to a tiler

  1   2   >