Re: [PATCH 1/5] dt-bindings: display: Document DPI color codings

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 11:33:44AM +0100, Maxime Ripard wrote: > > +properties: > > + dpi-color-coding: > > +enum: > > + - 16bit-configuration1 > > + - 16bit-configuration2 > > + - 16bit-configuration3 > > + - 18bit-configuration1 > > + - 18bit-configuration2 > > +

Re: [PATCH] drm/panel: fix Visionox RM692E5 dependencies

2025-03-04 Thread Neil Armstrong
On 04/03/2025 15:29, Arnd Bergmann wrote: From: Arnd Bergmann The newly added driver uses the DSC helpers, so the corresponding Kconfig option must be enabled: ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-visionox-rm692e5.ko] undefined! Fixes: 7cb3274341bf ("drm/pa

RE: [PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Cavitt, Jonathan
Hello Lucas, Rodrigo, and Thomas. Just querying the room on something. I need help deciding if this new xe_vm_get_property_ioctl should actually just be an extension of the currently existing xe_query functionality. On one hand, there's a decent chance that this ioctl will need to be extended

Re: [PATCH] drm: Select DRM_KMS_HELPER from DRM_DEBUG_DP_MST_TOPOLOGY_REFS

2025-03-04 Thread Thomas Zimmermann
depends on EXPERT help --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250304-drm_debug_dp_mst_topo_kconfig-a112904ba611 Best regards, -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuer

Re: [PATCH] fbtft: Remove access to page->index

2025-03-04 Thread Simona Vetter
On Tue, Mar 04, 2025 at 04:21:30PM +, Matthew Wilcox wrote: > On Fri, Feb 21, 2025 at 05:53:16PM +, Lorenzo Stoakes wrote: > > On Fri, Feb 21, 2025 at 05:31:29PM +, Matthew Wilcox (Oracle) wrote: > > > There is no need to print out page->index as part of the debug message. > > > > > > S

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-04 Thread Simona Vetter
On Tue, Mar 04, 2025 at 12:42:01PM -0400, Jason Gunthorpe wrote: > On Tue, Mar 04, 2025 at 05:10:45PM +0100, Simona Vetter wrote: > > On Fri, Feb 28, 2025 at 02:40:13PM -0400, Jason Gunthorpe wrote: > > > On Fri, Feb 28, 2025 at 11:52:57AM +0100, Simona Vetter wrote: > > > > > > > - Nuke the drive

Re: [PATCH v3 drm-dp 7/8] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-03-04 Thread Yongbang Shi
On Tue, Mar 04, 2025 at 10:23:14AM +0800, Yongbang Shi wrote: On Mon, Mar 03, 2025 at 01:02:44PM +0800, Yongbang Shi wrote: On Sat, 1 Mar 2025 at 11:54, Yongbang Shi wrote: On Sat, Mar 01, 2025 at 04:45:40PM +0800, Yongbang Shi wrote: On Thu, Feb 27, 2025 at 09:46:10PM +0800, Yongbang Shi

Re: [RFC 0/1] drm/mm: Introduce address space shifting

2025-03-04 Thread Christian König
Am 05.02.25 um 17:02 schrieb Lis, Tomasz: > > On 05.02.2025 09:32, Christian König wrote: >> Am 04.02.25 um 23:41 schrieb Tomasz Lis: >>> This RFC asks for introduction of an interface which allows to shift >>> a range managed by drm_mm instance without repeating the node list >>> creation. >> >> W

Re: [RFC 0/1] drm/mm: Introduce address space shifting

2025-03-04 Thread Christian König
Am 04.03.25 um 16:39 schrieb Lis, Tomasz: > There was no NACK, and no further questions/comments for a month. > > From that, we conclude that the proposed change is considered acceptable. Well there was also not any comment from Arun nor Matthew who are the de facto maintainers for this particula

RE: [PATCH v7 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-03-04 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Murthy, Arun R > Sent: Tuesday, February 25, 2025 1:04 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; ville.syrj...@linux.intel.com > Cc: Murthy, Arun R ; Borah, Chaitanya Kumar > ; Kumar, Navee

Re: [PATCH] drm/i915: implement vmap/vunmap GEM object functions

2025-03-04 Thread Thomas Zimmermann
Am 02.07.24 um 09:17 schrieb Thomas Zimmermann: Hi Am 29.06.24 um 20:25 schrieb Asbjørn Sloth Tønnesen: Implement i915_gem_vmap_object() and i915_gem_vunmap_object(), based on i915_gem_dmabuf_vmap() and i915_gem_dmabuf_vunmap(). This enables a drm_client to use drm_client_buffer_vmap() and

Re: [PATCH 0/4] drm/amd/display: move from kzalloc(size * nr, ...) to kcalloc(nr, size, ...)

2025-03-04 Thread Rodrigo Siqueira
On 02/27, Ethan Carter Edwards wrote: > We are trying to get rid of all multiplications from allocation > functions to prevent integer overflows. Here the multiplications are > probably safe, but using kcalloc() is more appropriate and improves > readability. It is also safer. This series contains

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-04 Thread Dmitry Baryshkov
On Wed, 5 Mar 2025 at 00:43, Abhinav Kumar wrote: > > > > On 3/4/2025 12:42 PM, Dmitry Baryshkov wrote: > > On Tue, Mar 04, 2025 at 11:38:24AM -0800, Abhinav Kumar wrote: > >> > >> > >> On 3/3/2025 9:32 PM, Dmitry Baryshkov wrote: > >>> On Tue, 4 Mar 2025 at 03:44, Jessica Zhang > >>> wrote: > >

Re: RESEND Re: [PATCH v16 2/7] drm/ttm/pool, drm/ttm/tt: Provide a helper to shrink pages

2025-03-04 Thread Dave Airlie
I've looked over the two patches mentioned here, I think they have seen enough time and we need to unblock, Please add and merge them: Acked-by: Dave Airlie Dave. On Tue, 25 Feb 2025 at 18:44, Thomas Hellström wrote: > > Hi, Christian, > > Ping? I'd really want to get this in before -rc6 > > T

Re:Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller

2025-03-04 Thread Andy Yan
Hi Piotr, 在 2025-03-04 21:12:50,"Piotr Oniszczuk" 写道: > > >> Wiadomość napisana przez Andy Yan w dniu 1 mar 2025, o >> godz. 13:24: >> >> >> Hi Piotr, >> >>> >>> is it worth to play with this or it is too early? >> >> I think you could give it a try if it using the Standard DP(non-ALT mod

[PATCH -next] drm: adp: Remove unnecessary print function dev_err()

2025-03-04 Thread Jiapeng Chong
The print function dev_err() is redundant because platform_get_irq_byname() already prints an error. ./drivers/gpu/drm/adp/adp_drv.c:470:2-9: line 470 is redundant because platform_get_irq() already prints an error. ./drivers/gpu/drm/adp/adp_drv.c:476:2-9: line 476 is redundant because platform_

Re: [PATCH v3] Documentation: dma-buf: heaps: Add heap name definitions

2025-03-04 Thread T.J. Mercier
On Mon, Mar 3, 2025 at 8:02 AM Maxime Ripard wrote: > > Following a recent discussion at last Plumbers, John Stultz, Sumit > Sewal, TJ Mercier and I came to an agreement that we should document > what the dma-buf heaps names are expected to be, and what the buffers > attributes you'll get should b

Re: [PATCH v8 12/15] drm/msm/dpu: blend pipes per mixer pairs config

2025-03-04 Thread Jessica Zhang
On 3/3/2025 7:14 AM, Jun Nie wrote: Currently, only 2 pipes are used at most for a plane. A stage structure describes the configuration for a mixer pair. So only one stage is needed for current usage cases. The quad-pipe case will be added in future and 2 stages are used in the case. So extend

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-04 Thread Abhinav Kumar
On 3/4/2025 12:42 PM, Dmitry Baryshkov wrote: On Tue, Mar 04, 2025 at 11:38:24AM -0800, Abhinav Kumar wrote: On 3/3/2025 9:32 PM, Dmitry Baryshkov wrote: On Tue, 4 Mar 2025 at 03:44, Jessica Zhang wrote: On 3/3/2025 3:49 PM, Dmitry Baryshkov wrote: On Mon, Mar 03, 2025 at 10:28:00AM

RE: [PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Lin, Shuicheng
On Tue, Mar 4, 2025 9:09 AM Cavitt, Jonathan wrote > Add support for userspace to request a list of observed failed pagefaults from > a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it > is

Re: [PATCH v8 11/15] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2025-03-04 Thread Jessica Zhang
On 3/3/2025 7:14 AM, Jun Nie wrote: The stage contains configuration for a mixer pair. Currently the plane supports just one stage and 2 pipes. Quad-pipe support will require handling 2 stages and 4 pipes at the same time. In preparation for that add a separate define, PIPES_PER_PLANE, to deno

RE: [PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Cavitt, Jonathan
From: Zhang, Jianxun Sent: Tuesday, March 4, 2025 12:38 PM To: Cavitt, Jonathan ; intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 6/6] drm/xe/xe_vm: Impleme

RE: [PATCH v5 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-04 Thread Lin, Shuicheng
On Tue, Mar 04, 2025 9:09 AM Cavitt, Jonathan wrote > Add additional information to each VM so they can report up to the last > 50 seen pagefaults. Only failed pagefaults are saved this way, as successful > pagefaults should recover and not need to be reported to userspace. > > Signed-off-by: Jon

Re: [PATCH 00/12] drm/{i915,xe}: Convert to DRM client setup

2025-03-04 Thread Jocelyn Falempe
On 04/03/2025 20:40, Maarten Lankhorst wrote: Hey, On 2025-02-28 09:49, Thomas Zimmermann wrote: Hi Maarten Am 12.02.25 um 08:28 schrieb Maarten Lankhorst: Hey, I'll give it a spin on xe today. It seems someone already tried on i915, so I expect no issues. Did you get to test the series? S

Re: [PATCH v3 0/3] drm/rockchip: lvds: probe logging improvements

2025-03-04 Thread Heiko Stuebner
On Tue, 04 Mar 2025 13:44:15 +0100, Heiko Stuebner wrote: > Getting the panel already uses dev_err_probe to stay silent, when > the panel just probes later, and the lvds defers. > > But the phy needed on px30, also has the capability to probe after > the lvds. So make the rest of the lvds probe/

[PATCH v5 3/7] drm/mxsfb: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

Re: [PATCH v3 1/3] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-03-04 Thread Heiko Stübner
Am Dienstag, 4. März 2025, 21:30:22 MEZ schrieb Dragan Simic: > Hello Heiko, > > On 2025-03-04 13:44, Heiko Stuebner wrote: > > diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c > > b/drivers/gpu/drm/rockchip/rockchip_lvds.c > > index 385cf6881504..ecfae8d5da89 100644 > > --- a/drivers/gpu/drm

[PATCH v5 7/7] Documentation: Update the todo

2025-03-04 Thread Anusha Srivatsa
Update the Documentation to be more precise. v2: Update for clarity v3: Further details in Todo Cc: Thomas Zimmermann Signed-off-by: Anusha Srivatsa Acked-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Doc

[PATCH v5 6/7] drm/tegra: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH v5 4/7] drm/sprd: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_2@ identifier res; expression ioremap; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); <... -if (!res) { -... -} ...>

[PATCH v5 5/7] drm/sti: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource/_byname + devm_ioremap with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule@ identifier res; expression ioremap; identifier pdev; constant mem; expression name; @@ -struct resource *res; ... -res = platform_get_resource_byna

[PATCH v5 1/7] drm/fsl-dcu: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH v5 2/7] drm/hisilicon: move to devm_platform_ioremap_resource() usage

2025-03-04 Thread Anusha Srivatsa
Replace platform_get_resource + devm_ioremap_resource with just devm_platform_ioremap_resource() Used Coccinelle to do this change. SmPl patch: @rule_1@ identifier res; expression ioremap_res; identifier pdev; @@ -struct resource *res; ... -res = platform_get_resource(pdev,...); -ioremap_res = dev

[PATCH v5 0/7] drm: Move to using devm_platform_ioremap_resource

2025-03-04 Thread Anusha Srivatsa
| 14 +++--- drivers/gpu/drm/tegra/dsi.c | 4 +--- 16 files changed, 40 insertions(+), 121 deletions(-) --- base-commit: 0670c2f56e45b3f4541985a9ebe06d04308e43b0 change-id: 20250304-mem-fixes-34df71d18b98 Best regards, -- Anusha Srivatsa

Re: [PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Zhang, Jianxun
From: Cavitt, Jonathan Sent: Tuesday, March 4, 2025 9:08 AM To: intel...@lists.freedesktop.org Cc: Gupta, saurabhg ; Zuo, Alex ; Cavitt, Jonathan ; joonas.lahti...@linux.intel.com ; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedeskt

Re: [PATCH v6 03/14] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-03-04 Thread Dmitry Baryshkov
On Tue, Mar 04, 2025 at 01:43:09AM +0200, Dmitry Baryshkov wrote: > On Mon, Mar 03, 2025 at 10:45:19AM -0800, Jessica Zhang wrote: > > > > > > On 2/27/2025 7:07 AM, Dmitry Baryshkov wrote: > > > On Fri, Feb 14, 2025 at 04:14:26PM -0800, Jessica Zhang wrote: > > > > From: Dmitry Baryshkov > > > >

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-04 Thread Dmitry Baryshkov
On Tue, Mar 04, 2025 at 11:38:24AM -0800, Abhinav Kumar wrote: > > > On 3/3/2025 9:32 PM, Dmitry Baryshkov wrote: > > On Tue, 4 Mar 2025 at 03:44, Jessica Zhang > > wrote: > > > > > > > > > > > > On 3/3/2025 3:49 PM, Dmitry Baryshkov wrote: > > > > On Mon, Mar 03, 2025 at 10:28:00AM -0800, J

[PATCH v5 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header

2025-03-04 Thread Jonathan Cavitt
Migrate the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault.h header file, along with the associated enum values. v2: Normalize names for common header (Matt Brost) Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 43 ++-- drivers/

Re: [PATCH v3 1/3] drm/rockchip: lvds: move pclk preparation in with clk_get

2025-03-04 Thread Dragan Simic
Hello Heiko, On 2025-03-04 13:44, Heiko Stuebner wrote: diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index 385cf6881504..ecfae8d5da89 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -448,1

[PATCH V2 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect

2025-03-04 Thread Stefan Wahren
drm_atomic_helper_connector_hdmi_hotplug() must be called regardless of the connection status, otherwise the HDMI audio disconnect event won't be notified. Fixes: 2ea9ec5d2c20 ("drm/vc4: hdmi: use drm_atomic_helper_connector_hdmi_hotplug()") Suggested-by: Dmitry Baryshkov Signed-off-by: Stefan W

Re: [PATCH 00/12] drm/{i915,xe}: Convert to DRM client setup

2025-03-04 Thread Maarten Lankhorst
Hey, On 2025-02-28 09:49, Thomas Zimmermann wrote: Hi Maarten Am 12.02.25 um 08:28 schrieb Maarten Lankhorst: Hey, I'll give it a spin on xe today. It seems someone already tried on i915, so I expect no issues. Did you get to test the series? Sorry, should have gotten back to you sooner. Xe

[PATCH V2 0/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-04 Thread Stefan Wahren
This series ensure the proper jack detection of HDMI audio. Changes in V2: - split initial patch into fix and jack detection feature as suggested by Dmitry David Turner (1): drm/vc4: hdmi: Add jack detection to HDMI audio driver Stefan Wahren (1): drm/vc4: hdmi: Call HDMI hotplug helper on

[PATCH V2 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

2025-03-04 Thread Stefan Wahren
From: David Turner Add ALSA jack detection to the vc4-hdmi audio driver so userspace knows when to add/remove HDMI audio devices. Signed-off-by: David Turner Signed-off-by: Stefan Wahren --- drivers/gpu/drm/vc4/vc4_hdmi.c | 18 ++ drivers/gpu/drm/vc4/vc4_hdmi.h | 7 +++ 2

Re: [PATCH RFC] drm/msm/dpu: Force modeset if new CTLs have been reserved

2025-03-04 Thread Abhinav Kumar
On 3/3/2025 9:32 PM, Dmitry Baryshkov wrote: On Tue, 4 Mar 2025 at 03:44, Jessica Zhang wrote: On 3/3/2025 3:49 PM, Dmitry Baryshkov wrote: On Mon, Mar 03, 2025 at 10:28:00AM -0800, Jessica Zhang wrote: If new CTLs are reserved by CRTC but atomic_enable() is skipped, the encoders will c

Re: [PATCH] drm/xe: Select INTEL_VSEC to fix build dependency

2025-03-04 Thread kernel test robot
Hi Su, kernel test robot noticed the following build errors: [auto build test ERROR on drm-xe/drm-xe-next] [also build test ERROR on linus/master v6.14-rc5 next-20250304] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH v5 3/5] rust: firmware: add `module_firmware!` macro

2025-03-04 Thread Jarkko Sakkinen
On Tue, Mar 04, 2025 at 06:34:50PM +0100, Danilo Krummrich wrote: > Analogous to the `module!` macro `module_firmware!` adds additional > firmware path strings to the .modinfo section. > > In contrast to `module!`, where path strings need to be string literals, > path strings can be composed with

Re: [PATCH v5 2/5] rust: firmware: introduce `firmware::ModInfoBuilder`

2025-03-04 Thread Jarkko Sakkinen
On Tue, Mar 04, 2025 at 06:34:49PM +0100, Danilo Krummrich wrote: > The `firmware` field of the `module!` only accepts literal strings, > which is due to the fact that it is implemented as a proc macro. > > Some drivers require a lot of firmware files (such as nova-core) and > hence benefit from m

Re: [PATCH v5 1/5] rust: module: add type `LocalModule`

2025-03-04 Thread Jarkko Sakkinen
On Tue, Mar 04, 2025 at 06:34:48PM +0100, Danilo Krummrich wrote: > The `LocalModule` type is the type of the module created by `module!`, > `module_pci_driver!`, `module_platform_driver!`, etc. > > Since the exact type of the module is sometimes generated on the fly by > the listed macros, provid

[PATCH] drm: Select DRM_KMS_HELPER from DRM_DEBUG_DP_MST_TOPOLOGY_REFS

2025-03-04 Thread Janne Grunau via B4 Relay
ory in the DP MST helpers" depends on STACKTRACE_SUPPORT select STACKDEPOT -depends on DRM_KMS_HELPER +select DRM_KMS_HELPER depends on DEBUG_KERNEL depends on EXPERT help --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 2025030

Re: [PATCH v2 1/1] accel/habanalabs: Switch to use %ptTs

2025-03-04 Thread Jani Nikula
On Thu, 06 Feb 2025, Andy Shevchenko wrote: > Use %ptTs instead of open-coded variant to print contents of time64_t type > in human readable form. > > Signed-off-by: Andy Shevchenko > --- > > v2: fixed the parameters to be the pointers > > drivers/accel/habanalabs/common/device.c | 25 +++---

[PATCH] drm/vmwgfx: Make sure the dirty tracker is released on surfaces

2025-03-04 Thread Zack Rusin
Free all the dirty trackers associated with the surface when the parent framebuffer is destroyed. The buffers backing framebuffers are explicitly made coherent. Code separates buffers from surfaces. Buffers only require a dirty tracker which is released during the framebuffer cleanup. Surfaces, wh

Re: firmware requirements

2025-03-04 Thread Simona Vetter
Hi Jacek! Bit late reply, was sick last week and still recovering from missed mails. On Thu, Feb 20, 2025 at 11:50:10AM +0100, Jacek Lawrynowicz wrote: > On 2/19/2025 10:01 PM, Dave Airlie wrote: > > I'd just like to remind everyone of the firmware requirements for > > vendors that control their

Re: [PATCH v2 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-03-04 Thread Louis Chauvet
Le 04/03/2025 à 17:23, José Expósito a écrit : On Tue, Mar 04, 2025 at 04:35:50PM +0100, Louis Chauvet wrote: Le 04/03/2025 à 15:54, José Expósito a écrit : Hi Louis, On Mon, Mar 03, 2025 at 11:34:50AM +0100, Louis Chauvet wrote: Le 03/03/2025 à 09:50, José Expósito a écrit : Hi Louis

Re: [PATCH 2/2] drm: ensure drm headers are self-contained and pass kernel-doc

2025-03-04 Thread Masahiro Yamada
On Mon, Mar 3, 2025 at 10:53 PM Jani Nikula wrote: > > On Mon, 03 Mar 2025, Masahiro Yamada wrote: > > On Mon, Mar 3, 2025 at 7:02 PM Jani Nikula wrote: > >> > >> On Mon, 03 Mar 2025, Masahiro Yamada wrote: > >> And one of the underlying goals is to make for minimal headers with > >> minimal in

Re: [PATCH v3] drm: add modifiers for Apple GPU layouts

2025-03-04 Thread Faith Ekstrand
~Faith Ekstrand On Sat, 01 Mar 2025 16:01:30 -0600 Alyssa Rosenzweig wrote --- Apple GPUs support various non-linear image layouts. Add modifiers for these layouts. Mesa requires these modifiers to share non-linear buffers across processes, but no other userspace or kernel suppo

[PATCH v5 5/5] gpu: nova-core: add initial documentation

2025-03-04 Thread Danilo Krummrich
Add the initial documentation of the Nova project. The initial project documentation consists out of a brief introduction of the project, as well as project guidelines both general and nova-core specific and a task list for nova-core specifically. The task list is divided into tasks for general R

[PATCH v5 4/5] gpu: nova-core: add initial driver stub

2025-03-04 Thread Danilo Krummrich
Add the initial nova-core driver stub. nova-core is intended to serve as a common base for nova-drm (the corresponding DRM driver) and the vGPU manager VFIO driver, serving as a hard- and firmware abstraction layer for GSP-based NVIDIA GPUs. The Nova project, including nova-core and nova-drm, in

[PATCH v5 2/5] rust: firmware: introduce `firmware::ModInfoBuilder`

2025-03-04 Thread Danilo Krummrich
The `firmware` field of the `module!` only accepts literal strings, which is due to the fact that it is implemented as a proc macro. Some drivers require a lot of firmware files (such as nova-core) and hence benefit from more flexibility composing firmware path strings. The `firmware::ModInfoBuil

[PATCH v5 3/5] rust: firmware: add `module_firmware!` macro

2025-03-04 Thread Danilo Krummrich
Analogous to the `module!` macro `module_firmware!` adds additional firmware path strings to the .modinfo section. In contrast to `module!`, where path strings need to be string literals, path strings can be composed with the `firmware::ModInfoBuilder`. Some drivers require a lot of firmware file

[PATCH v5 1/5] rust: module: add type `LocalModule`

2025-03-04 Thread Danilo Krummrich
The `LocalModule` type is the type of the module created by `module!`, `module_pci_driver!`, `module_platform_driver!`, etc. Since the exact type of the module is sometimes generated on the fly by the listed macros, provide an alias. This is first used by the `module_firmware!` macro introduced i

[PATCH v5 0/5] Initial Nova Core series

2025-03-04 Thread Danilo Krummrich
This is the initial series for the nova-core stub driver. nova-core is intended to serve as a common base for nova-drm (the corresponding DRM driver) and the vGPU manager VFIO driver, serving as a hard- and firmware abstraction layer for GSP-based NVIDIA GPUs. The Nova project, including nova-cor

[PATCH v5 1/6] drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs

2025-03-04 Thread Jonathan Cavitt
The page fault handler should reject write/atomic access to read only VMAs. Add code to handle this in handle_pagefault after the VMA lookup. Fixes: 3d420e9fa848 ("drm/xe: Rework GPU page fault handling") Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/drm/xe/xe_gt_p

[PATCH v5 3/6] drm/xe/xe_vm: Add per VM pagefault info

2025-03-04 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. Signed-off-by: Jonathan Cavitt Suggested-by: Matthew Brost --- drivers/gpu/dr

[PATCH v5 5/6] drm/xe/xe_gt_pagefault: Add address_type field to pagefaults

2025-03-04 Thread Jonathan Cavitt
Add a new field to the xe_pagefault struct, address_type, that tracks the type of fault the pagefault incurred. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 3 +++ drivers/gpu/drm/xe/xe_gt_pagefault.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/

[PATCH v5 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. Additionally, add a new ioctl - xe_vm_get_property_ioctl - that allows the user

[PATCH v5 4/6] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-04 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. Signed-off-by: Jonathan Cavitt --- include/uapi/drm/xe_drm.h | 67 +++ 1 file changed, 67 insertions(+) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 76a462fae05f..53617

[PATCH v5 6/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-04 Thread Jonathan Cavitt
Add support for userspace to request a list of observed failed pagefaults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from

Re: [PATCH] fbtft: Remove access to page->index

2025-03-04 Thread Matthew Wilcox
On Fri, Feb 21, 2025 at 05:53:16PM +, Lorenzo Stoakes wrote: > On Fri, Feb 21, 2025 at 05:31:29PM +, Matthew Wilcox (Oracle) wrote: > > There is no need to print out page->index as part of the debug message. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > LGTM from my side, > > Review

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-04 Thread Jason Gunthorpe
On Tue, Mar 04, 2025 at 05:10:45PM +0100, Simona Vetter wrote: > On Fri, Feb 28, 2025 at 02:40:13PM -0400, Jason Gunthorpe wrote: > > On Fri, Feb 28, 2025 at 11:52:57AM +0100, Simona Vetter wrote: > > > > > - Nuke the driver binding manually through sysfs with the unbind files. > > > - Nuke all us

Re: [PATCH next] drm/vc4: hdmi: Fix some NULL vs IS_ERR() bugs

2025-03-04 Thread Maxime Ripard
On Tue, Mar 04, 2025 at 10:22:29AM -0500, Anusha Srivatsa wrote: > Thanks for the fix. I shall revisit the rest of my series. > > Reviewed-by: Anusha Srivatsa It's already been applied Maxime signature.asc Description: PGP signature

Re: [PATCH next] drm/vc4: hdmi: Fix some NULL vs IS_ERR() bugs

2025-03-04 Thread Anusha Srivatsa
Thanks for the fix. I shall revisit the rest of my series. Reviewed-by: Anusha Srivatsa On Fri, Feb 28, 2025 at 4:38 AM Dan Carpenter wrote: > The devm_platform_ioremap_resource_byname() function doesn't return NULL, > it returns error pointers. Update the checking to match. > > Fixes: b93f07

Re: [PATCH v2 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-03-04 Thread José Expósito
On Tue, Mar 04, 2025 at 04:35:50PM +0100, Louis Chauvet wrote: > > > Le 04/03/2025 à 15:54, José Expósito a écrit : > > Hi Louis, > > > > On Mon, Mar 03, 2025 at 11:34:50AM +0100, Louis Chauvet wrote: > > > > > > > > > Le 03/03/2025 à 09:50, José Expósito a écrit : > > > > Hi Louis, > > > > >

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-03-04 Thread Simona Vetter
On Fri, Feb 28, 2025 at 02:40:13PM -0400, Jason Gunthorpe wrote: > On Fri, Feb 28, 2025 at 11:52:57AM +0100, Simona Vetter wrote: > > > - Nuke the driver binding manually through sysfs with the unbind files. > > - Nuke all userspace that might beholding files and other resources open. > > - At thi

Re: [RFC 0/1] drm/mm: Introduce address space shifting

2025-03-04 Thread Lis, Tomasz
There was no NACK, and no further questions/comments for a month. From that, we conclude that the proposed change is considered acceptable. In case anyone disagrees, please respond now. We are starting work on a series which will use the proposed drm_mm function. -Tomasz On 04.02.2025 23:41

Re: [PATCH v2 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-03-04 Thread Louis Chauvet
Le 04/03/2025 à 15:54, José Expósito a écrit : Hi Louis, On Mon, Mar 03, 2025 at 11:34:50AM +0100, Louis Chauvet wrote: Le 03/03/2025 à 09:50, José Expósito a écrit : Hi Louis, On Fri, Feb 28, 2025 at 03:43:25PM +0100, Louis Chauvet wrote: Le 25/02/2025 à 18:59, José Expósito a écrit 

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-04 Thread Rob Herring
On Tue, Mar 04, 2025 at 06:15:28PM +0800, Liu Ying wrote: > A DPI color encoder, as a simple display bridge, converts input DPI color > coding to output DPI color coding, like Adafruit Kippah DPI hat[1] which > converts input 18-bit pixel data to 24-bit pixel data(with 2 low padding > bits in every

Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables

2025-03-04 Thread Jani Nikula
On Tue, 04 Mar 2025, Aditya Garg wrote: >> On 4 Mar 2025, at 6:49 PM, Nathan Chancellor wrote: >> >> When building for a 32-bit platform, there are some warnings (or errors >> with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t' >> variables, which is typedef'd as 'unsigned int' for

Re: [PATCH] drm/tiny: fix printk format string for 32-bit

2025-03-04 Thread Jani Nikula
drm_err(drm, "Actual size (%d) doesn't match expected >> size (%lu)\n", >> | ^~~ >> >> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs") >> Signed-off-by: Arnd Bergmann >> — > > Its the duplicate of: > > https://lore.kernel.org/dri-devel/20250304-appletbdrm-fix-size_t-specifier-v1-1-94fe1d2c9...@kernel.org/ Pushed this one to drm-misc-next. BR, Jani. > > as well as > > https://lore.kernel.org/dri-devel/20250304135456.429407-1-jani.nik...@intel.com/ > > -- Jani Nikula, Intel

Re: [PATCH 0/5] drm: strict type checking for drm_device based logging helpers

2025-03-04 Thread Jani Nikula
On Thu, 23 Jan 2025, Jani Nikula wrote: > Fix all cases that pass something other than struct drm_device to the > drm_device based logging helpers, and add strict type checking. > > Gustavo Sousa (1): > drm/print: Include drm_device.h This was pushed earlier, independently. > > Jani Nikula (4)

Re: [PATCH 0/5] drm/bridge: simple-bridge: Add DPI color encoder support

2025-03-04 Thread Alexander Stein
Hi, Am Dienstag, 4. März 2025, 11:15:25 CET schrieb Liu Ying: > Hi, > > This patch series aims to add DPI color encoder support as a simple DRM > bridge. A DPI color encoder simply converts input DPI color coding to > output DPI color coding, like Adafruit Kippah DPI hat[1] which converts > inpu

Re: [PATCH v3 3/3] drm/rockchip: lvds: lower log severity for missing pinctrl settings

2025-03-04 Thread Quentin Schulz
Hi Heiko, On 3/4/25 1:44 PM, Heiko Stuebner wrote: From: Heiko Stuebner While missing lvds pinctrl is unexpected and is reported, we nevertheless don't fail setting up the device and instead continue without explicit pinctrl handling. So lower the log-level from error to warning to reflect tha

Re: [PATCH v3 2/3] drm/rockchip: lvds: Hide scary error messages on probe deferral

2025-03-04 Thread Quentin Schulz
Hi Heiko, On 3/4/25 1:44 PM, Heiko Stuebner wrote: From: Heiko Stuebner Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when probing defer") already started hiding scary messages that are not relevant if the requested supply just returned EPROBE_DEFER, but there are more p

Re: [PATCH v2 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-03-04 Thread José Expósito
Hi Louis, On Mon, Mar 03, 2025 at 11:34:50AM +0100, Louis Chauvet wrote: > > > Le 03/03/2025 à 09:50, José Expósito a écrit : > > Hi Louis, > > > > On Fri, Feb 28, 2025 at 03:43:25PM +0100, Louis Chauvet wrote: > > > > > > > > > Le 25/02/2025 à 18:59, José Expósito a écrit : > > > > Create a

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-03-04 Thread Leon Romanovsky
On Tue, Mar 04, 2025 at 03:29:42PM +0100, Christian König wrote: > Am 26.02.25 um 14:38 schrieb Jason Gunthorpe: > > On Wed, Feb 26, 2025 at 07:55:07AM +, Kasireddy, Vivek wrote: > > > >>> Is there any update or ETA for the v3? Are there any ways we can help? > >> I believe Leon's series is ver

Re: [PATCH] drm/tiny: fix printk format string for 32-bit

2025-03-04 Thread Aditya Garg
7;} > [-Werror=format=] > drivers/gpu/drm/tiny/appletbdrm.c:211:17: note: in expansion of macro > 'drm_err' > 211 | drm_err(drm, "Actual size (%d) doesn't match expected > size (%lu)\n", > | ^~~ > > Fixe

Re: [PATCH v2 0/2] Add driver for Himax HX8279 DriverIC panels

2025-03-04 Thread Nícolas F . R . A . Prado
On Tue, Feb 18, 2025 at 03:39:50PM +0100, AngeloGioacchino Del Regno wrote: > Changes in v2: > - Removed unneeded mipi_dsi_device_unregister() call for secondary >DSI: as the driver is using devm, that's not necessary (CJ) > - Removed superfluous if branch as pointed out by CJ > > This serie

Re: [PATCH v2 1/1] accel/habanalabs: Switch to use %ptTs

2025-03-04 Thread Andy Shevchenko
On Thu, Feb 06, 2025 at 09:20:43PM +0200, Andy Shevchenko wrote: > Use %ptTs instead of open-coded variant to print contents of time64_t type > in human readable form. Any comments on this, please? If no, can it be applied? -- With Best Regards, Andy Shevchenko

[PATCH libdrm 0/2] Add an option to configure the plain pattern in modetest

2025-03-04 Thread Louis Chauvet
| 19 +-- tests/util/pattern.h | 1 + 5 files changed, 36 insertions(+), 14 deletions(-) --- base-commit: a7eb2cfd53a70fcd9ba9dcfad80a3994642f362f change-id: 20250304-color-option-950cccb9ead7 Best regards, -- Louis Chauvet

[PATCH libdrm 2/2] modetest: Add color configuration for plain pattern

2025-03-04 Thread Louis Chauvet
The plain pattern is useful to debug display issues. Unfortunatly this pattern is not configurable. Add a new option '-V' for this. Co-developed-by: Miquel Raynal Signed-off-by: Miquel Raynal Signed-off-by: Louis Chauvet --- tests/modetest/buffers.c | 5 +++-- tests/modetest/buffers.h | 3

[PATCH libdrm 1/2] util: Add option to change the color for plain pattern

2025-03-04 Thread Louis Chauvet
The plain pattern can be useful to debug some color issues. Add an option to configure the color for the plain pattern. Co-developed-by: Miquel Raynal Signed-off-by: Miquel Raynal Signed-off-by: Louis Chauvet --- tests/modetest/buffers.c | 2 +- tests/util/pattern.c | 19 +

Re: [PATCH v2 2/5] drm/scheduler: Add scheduler unit testing infrastructure and some basic tests

2025-03-04 Thread Tvrtko Ursulin
On 04/03/2025 12:29, Philipp Stanner wrote: [snip] +struct drm_mock_scheduler *drm_mock_new_scheduler(struct kunit *test) +{ + struct drm_sched_init_args args = { + .ops= &drm_mock_scheduler_ops, + .num_rqs= DRM_SCHED_PRIORITY_COUNT, +

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-03-04 Thread Jason Gunthorpe
On Tue, Mar 04, 2025 at 03:29:42PM +0100, Christian König wrote: > Am 26.02.25 um 14:38 schrieb Jason Gunthorpe: > > On Wed, Feb 26, 2025 at 07:55:07AM +, Kasireddy, Vivek wrote: > > > >>> Is there any update or ETA for the v3? Are there any ways we can help? > >> I believe Leon's series is ver

Re: [PATCH v4 5/6] gpu: nova-core: add initial driver stub

2025-03-04 Thread Danilo Krummrich
On Tue, Mar 04, 2025 at 11:19:49PM +0900, Alexandre Courbot wrote: > On Thu Feb 27, 2025 at 2:55 AM JST, Danilo Krummrich wrote: > > > +// TODO replace with something like derive(FromPrimitive) > > +impl TryFrom for Chipset { > > +type Error = kernel::error::Error; > > + > > +fn try_from(v

Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf

2025-03-04 Thread Christian König
Am 26.02.25 um 14:38 schrieb Jason Gunthorpe: > On Wed, Feb 26, 2025 at 07:55:07AM +, Kasireddy, Vivek wrote: > >>> Is there any update or ETA for the v3? Are there any ways we can help? >> I believe Leon's series is very close to getting merged. Once it >> lands, this series can be revived. >

[PATCH] drm/panel: fix Visionox RM692E5 dependencies

2025-03-04 Thread Arnd Bergmann
From: Arnd Bergmann The newly added driver uses the DSC helpers, so the corresponding Kconfig option must be enabled: ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-visionox-rm692e5.ko] undefined! Fixes: 7cb3274341bf ("drm/panel: Add Visionox RM692E5 panel driver") Sig

[PATCH] drm/tiny: fix printk format string for 32-bit

2025-03-04 Thread Arnd Bergmann
From: Arnd Bergmann A size_t must be printed with the %z modifier instead of %l: In file included from include/linux/device.h:15, from include/linux/usb.h:19, from drivers/gpu/drm/tiny/appletbdrm.c:19: drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_s

Re: [PATCH] drm/appletbdrm: Fix format specifier for size_t variables

2025-03-04 Thread Aditya Garg
> On 4 Mar 2025, at 6:49 PM, Nathan Chancellor wrote: > > When building for a 32-bit platform, there are some warnings (or errors > with CONFIG_WERROR=y) due to an incorrect specifier for 'size_t' > variables, which is typedef'd as 'unsigned int' for these architectures: > > drivers/gpu/drm/

Re: [PATCH v4 5/6] gpu: nova-core: add initial driver stub

2025-03-04 Thread Alexandre Courbot
Hi Danilo, On Thu Feb 27, 2025 at 2:55 AM JST, Danilo Krummrich wrote: > Add the initial nova-core driver stub. > > nova-core is intended to serve as a common base for nova-drm (the > corresponding DRM driver) and the vGPU manager VFIO driver, serving as a > hard- and firmware abstraction layer fo

Re: [PATCH] drm/bochs: Fix DPMS regression

2025-03-04 Thread Thomas Zimmermann
Am 04.03.25 um 14:41 schrieb Takashi Iwai: The recent rewrite with the use of regular atomic helpers broke the DPMS unblanking on X11. Fix it by moving the call of bochs_hw_blank(false) from CRTC mode_set_nofb() to atomic_enable(). Fixes: 2037174993c8 ("drm/bochs: Use regular atomic helpers"

[PATCH v2] drm/sched: drm_sched_job_cleanup(): correct false doc

2025-03-04 Thread Philipp Stanner
drm_sched_job_cleanup()'s documentation claims that calling drm_sched_job_arm() is a "point of no return", implying that afterwards a job cannot be cancelled anymore. This is not correct, as proven by the function's code itself, which takes a previous call to drm_sched_job_arm() into account. In t

  1   2   >