Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Thomas Zimmermann
Hi Am 24.02.25 um 17:58 schrieb Aditya Garg: [...] +config DRM_APPLETBDRM +tristate "DRM support for Apple Touch Bars" +depends on DRM && USB && MMU +select DRM_GEM_SHMEM_HELPER +select DRM_KMS_HELPER +select HID_APPLETB_BL Btw I have a doubt regarding this dependency. Whil

[PATCH v2 6/7] accel/rocket: Add job submission IOCTL

2025-02-24 Thread Tomeu Vizoso
Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was initially based on Panfrost. v2: - Remove hardcoded number

[PATCH v2 3/7] arm64: dts: rockchip: Enable the NPU on quartzpro64

2025-02-24 Thread Tomeu Vizoso
Enable the nodes added in a previous commit to the rk3588s device tree. v2: - Split nodes (Sebastian Reichel) - Sort nodes (Sebastian Reichel) - Add board regulators (Sebastian Reichel) Signed-off-by: Tomeu Vizoso --- .../arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 30 +

[PATCH v2 7/7] accel/rocket: Add IOCTLs for synchronizing memory accesses

2025-02-24 Thread Tomeu Vizoso
The NPU cores have their own access to the memory bus, and this isn't cache coherent with the CPUs. Add IOCTLs so userspace can mark when the caches need to be flushed, and also when a writer job needs to be waited for before the buffer can be accessed from the CPU. Initially based on the same IO

[PATCH v2 5/7] accel/rocket: Add IOCTL for BO creation

2025-02-24 Thread Tomeu Vizoso
This uses the SHMEM DRM helpers and we map right away to the CPU and NPU sides, as all buffers are expected to be accessed from both. v2: - Sync the IOMMUs for the other cores when mapping and unmapping. Signed-off-by: Tomeu Vizoso --- drivers/accel/rocket/Makefile| 3 +- drivers/acce

[PATCH v2 2/7] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2025-02-24 Thread Tomeu Vizoso
See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). This is a derivative of NVIDIA's NVDLA, but with its own front-end processor. The IP is divided in three cores, programmed independently. The first core though is special, requiring to be powered on before any of the others can be used. The IOM

[PATCH v2 1/7] dt-bindings: npu: rockchip,rknn: Add bindings

2025-02-24 Thread Tomeu Vizoso
Add the bindings for the Neural Processing Unit IP from Rockchip. v2: - Adapt to new node structure (one node per core, each with its own IOMMU) - Several misc. fixes from Sebastian Reichel Signed-off-by: Tomeu Vizoso Signed-off-by: Sebastian Reichel --- .../bindings/npu/rockchip,rknn-core.y

[PATCH v2 0/7] New DRM accel driver for Rockchip's RKNN NPU

2025-02-24 Thread Tomeu Vizoso
This series adds a new driver for the NPU that Rockchip includes in its newer SoCs, developed by them on the NVDLA base. In its current form, it supports the specific NPU in the RK3588 SoC. The userspace driver is part of Mesa and an initial draft can be found at: https://gitlab.freedesktop.org/

Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-24 Thread Thomas Zimmermann
Hi Am 24.02.25 um 14:40 schrieb Aditya Garg: From: Kerem Karabay The Touch Bars found on x86 Macs support two USB configurations: one where the device presents itself as a HID keyboard and can display predefined sets of keys, and one where the operating system has full control over what is dis

[PATCH v7 1/3] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-02-24 Thread Arun R Murthy
There exists a property IN_FORMATS which exposes the plane supported modifiers/formats to the user. In some platforms when asynchronous flip are used all of modifiers/formats mentioned in IN_FORMATS are not supported. This patch adds a new plane property IN_FORMATS_ASYNC to expose the async flip su

[PATCH v7 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-02-24 Thread Arun R Murthy
Hook up the newly added plane function pointer format_mod_supported_async to populate the modifiers/formats supported by asynchronous flips. v5: Correct the if condition for modifier support check (Chaitanya) v6: Replace uint32_t/uint64_t with u32/u64 (Jani) v7: Move plannar check from intel_async

[PATCH v7 2/3] drm/plane: modify create_in_formats to accommodate async

2025-02-24 Thread Arun R Murthy
create_in_formats creates the list of supported format/modifiers for synchronous flips, modify the same function so as to take the format_mod_supported as argument and create list of format/modifier for async as well. v5: create_in_formats can return -ve value in failure case, correct the if condi

[PATCH] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-24 Thread Mingcong Bai
Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") introduced an internal set of engine registers, however, as part of this change, it has also introduced two duplicate `define' lines for `RING_CTL_SIZE(size)'. This commit was introduced to the tree in v6.8-rc1. While this is

Re: [PATCH v4 1/2] drm/format-helper: Add conversion from XRGB8888 to BGR888

2025-02-24 Thread Thomas Zimmermann
Hi Am 24.02.25 um 15:29 schrieb andriy.shevche...@linux.intel.com: On Mon, Feb 24, 2025 at 01:38:32PM +, Aditya Garg wrote: From: Kerem Karabay Add XRGB emulation helper for devices that only support BGR888. ... +static void drm_fb_xrgb_to_bgr888_line(void *dbuf, const void *sb

Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled

2025-02-24 Thread Philipp Stanner
On Tue, 2025-02-25 at 11:12 +0800, Qianyi Liu wrote: > Hello Philipp, > > Thank you for your patient reply. Let's first clarify the issue and > send a new > patch if necessary. > > As soon as it enters the drm_sched_entity_kill function, the entity > ->last_scheduled reference count is incremente

[PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()

2025-02-24 Thread Dan Carpenter
If msm_gem_address_space_create() fails, then return right away. Otherwise it leads to a Oops when we dereference "aspace" on the next line. Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/msm_kms.c | 1 + 1 fi

Re: [PATCH 1/5] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-24 Thread Mingcong Bai
Hi all, 在 2025/2/25 15:18, Mingcong Bai 写道: Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") introduced an internal set of engine registers, however, as part of this change, it has also introduced two duplicate `define' lines for `RING_CTL_SIZE(size)'. This commit was int

Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled

2025-02-24 Thread Philipp Stanner
On Mon, 2025-02-24 at 10:52 +0100, Philipp Stanner wrote: > Hello, > > subject line: please write "drm/sched" instead of "drm/scheduler". It > has become the norm > > On Fri, 2025-02-21 at 14:27 +0800, qianyi liu wrote: > > Problem: If prev(last_scheduled) was already signaled I encountred > > a

[PATCH 1/5] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-24 Thread Mingcong Bai
Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") introduced an internal set of engine registers, however, as part of this change, it has also introduced two duplicate `define' lines for `RING_CTL_SIZE(size)'. This commit was introduced to the tree in v6.8-rc1. While this is

[syzbot] [fbdev?] KASAN: slab-out-of-bounds Read in fbcon_prepare_logo

2025-02-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d082ecbc71e9 Linux 6.14-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=100c97a458 kernel config: https://syzkaller.appspot.com/x/.config?x=b1635bf4c5557b92 dashboard link: https://syzkaller.ap

[PATCH v6 27/32] drm/xe: Add SVM VRAM migration

2025-02-24 Thread Matthew Brost
Migration is implemented with range granularity, with VRAM backing being a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the TTM BO is limited to when the SVM range is in VRAM (i.e., when a VRAM SVM range is migrated to SRAM, the TTM BO is destroyed). The design choice for usi

Re: [PATCH 2/5] drm/msm/a6xx: Add support for Adreno 623

2025-02-24 Thread Akhil P Oommen
On 2/13/2025 10:51 PM, Konrad Dybcio wrote: > On 13.02.2025 5:10 PM, Akhil P Oommen wrote: >> From: Jie Zhang >> >> Add support for Adreno 623 GPU found in QCS8300 chipsets. >> >> Signed-off-by: Jie Zhang >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 2

Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621

2025-02-24 Thread Akhil P Oommen
On 2/18/2025 11:52 PM, Rob Clark wrote: > On Thu, Feb 13, 2025 at 8:10 AM Akhil P Oommen > wrote: >> >> From: Jie Zhang >> >> Adreno 621 has a different memory map for GPUCC block. So update >> a6xx_gpu_state code to dump the correct set of gpucc registers. >> >> Signed-off-by: Jie Zhang >> Sig

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-24 Thread Kuninori Morimoto
Hi Detlev, again > > Especially those commits: > > ASoC: audio-graph-card2: use __free(device_node) for device node > > ASoC: audio-graph-card: use __free(device_node) for device node > > ASoC: simple-card: use __free(device_node) for device node > > I got same report from our

[PATCH v6 18/32] drm/xe: Enable CPU address mirror uAPI

2025-02-24 Thread Matthew Brost
Support for CPU address mirror bindings in SRAM fully in place, enable the implementation. v3: - s/system allocator/CPU address mirror (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_vm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/dr

Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled

2025-02-24 Thread Matthew Brost
On Mon, Feb 24, 2025 at 10:52:56AM +0100, Philipp Stanner wrote: > Hello, > > subject line: please write "drm/sched" instead of "drm/scheduler". It > has become the norm > > On Fri, 2025-02-21 at 14:27 +0800, qianyi liu wrote: > > Problem: If prev(last_scheduled) was already signaled I encountred

[PATCH v6 32/32] drm/doc: gpusvm: Add GPU SVM documentation

2025-02-24 Thread Matthew Brost
Add documentation for agree upon GPU SVM design principles, current status, and future plans. v4: - Address Thomas's feedback v5: - s/Current/Basline (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- Documentation/gpu/rfc/gpusvm.rst | 84

[PATCH v6 20/32] drm/xe: Add migrate layer functions for SVM support

2025-02-24 Thread Matthew Brost
Add functions which migrate to / from VRAM accepting a single DPA argument (VRAM) and array of dma addresses (SRAM). Used for SVM migrations. v2: - Don't unlock job_mutex in error path of xe_migrate_vram v3: - Kernel doc (Thomas) - Better commit message (Thomas) - s/dword/num_dword (Thomas) -

[PATCH v6 28/32] drm/xe: Basic SVM BO eviction

2025-02-24 Thread Matthew Brost
Wire xe_bo_move to GPU SVM migration via new helper xe_svm_bo_evict. v2: - Use xe_svm_bo_evict - Drop bo->range v3: - Kernel doc (Thomas) v4: - Add missing xe_bo.c code v5: - Add XE_BO_FLAG_CPU_ADDR_MIRROR flag in this patch (Thomas) - Add message on eviction failure v6: - Only compile if C

[PATCH v6 01/32] drm/xe: Retry BO allocation

2025-02-24 Thread Matthew Brost
TTM doesn't support fair eviction via WW locking, this mitigated in by using retry loops in exec and preempt rebind worker. Extend this retry loop to BO allocation. Once TTM supports fair eviction this patch can be reverted. v4: - Keep line break (Stuart) Signed-off-by: Matthew Brost Reviewed-b

[PATCH v6 03/32] mm/migrate: Trylock device page in do_swap_page

2025-02-24 Thread Matthew Brost
Avoid multiple CPU page faults to the same device page racing by trying to lock the page in do_swap_page before taking an extra reference to the page. This prevents scenarios where multiple CPU page faults each take an extra reference to a device page, which could abort migration in folio_migrate_m

[PATCH v6 04/32] drm/pagemap: Add DRM pagemap

2025-02-24 Thread Matthew Brost
From: Thomas Hellström Introduce drm_pagemap ops to map and unmap dma to VRAM resources. In the local memory case it's a matter of merely providing an offset into the device's physical address. For future p2p the map and unmap functions may encode as needed. Similar to how dma-buf works, let the

[PATCH v6 16/32] drm/xe: Add unbind to SVM garbage collector

2025-02-24 Thread Matthew Brost
Add unbind to SVM garbage collector. To facilitate add unbind support function to VM layer which unbinds a SVM range. Also teach PT layer to understand unbinds of SVM ranges. v3: - s/INVALID_VMA/XE_INVALID_VMA (Thomas) - Kernel doc (Thomas) - New GPU SVM range structure (Thomas) - s/DRM_GPUVA_

[PATCH v6 12/32] drm/xe: Add SVM range invalidation and page fault

2025-02-24 Thread Matthew Brost
Add SVM range invalidation vfunc which invalidates PTEs. A new PT layer function which accepts a SVM range is added to support this. In addition, add the basic page fault handler which allocates a SVM range which is used by SVM range invalidation vfunc. v2: - Don't run invalidation if VM is close

[PATCH v6 14/32] drm/xe: Add (re)bind to SVM page fault handler

2025-02-24 Thread Matthew Brost
Add (re)bind to SVM page fault handler. To facilitate add support function to VM layer which (re)binds a SVM range. Also teach PT layer to understand (re)binds of SVM ranges. v2: - Don't assert BO lock held for range binds - Use xe_svm_notifier_lock/unlock helper in xe_svm_close - Use drm_pagem

[PATCH v6 23/32] drm/xe: Add drm_pagemap ops to SVM

2025-02-24 Thread Matthew Brost
From: Thomas Hellström Add support for mapping device pages to Xe SVM by attaching drm_pagemap to a memory region, which is then linked to a GPU SVM devmem allocation. This enables GPU SVM to derive the device page address. v3: - Better commit message (Thomas) - New drm_pagemap.h location v5:

[PATCH v6 25/32] drm/xe: Add Xe SVM populate_devmem_pfn GPU SVM vfunc

2025-02-24 Thread Matthew Brost
Get device pfns from BO's buddy blocks. Used in migrate_* core MM functions called in GPU SVM to migrate between device and system memory. v2: - Use new drm_gpusvm_devmem_ops v3: - Better commit message (Thomas) v5: - s/xe_mem_region/xe_vram_region (Rebase) Signed-off-by: Niranjana Vishwanatha

[PATCH v6 21/32] drm/xe: Add SVM device memory mirroring

2025-02-24 Thread Matthew Brost
Add SVM device memory mirroring which enables device pages for migration. Enabled via CONFIG_XE_DEVMEM_MIRROR Kconfig. Kconfig option defaults to enabled. If not enabled, SVM will work sans migration and KMD memory footprint will be less. v3: - Add CONFIG_XE_DEVMEM_MIRROR v4: - Fix Kconfig (Hima

[PATCH v6 24/32] drm/xe: Add GPUSVM device memory copy vfunc functions

2025-02-24 Thread Matthew Brost
Add GPUSVM device memory copy vfunc functions and connect to migration layer. Used for device memory migration. v2: - Allow NULL device pages in xe_svm_copy - Use new drm_gpusvm_devmem_ops v3: - Prefix defines with XE_ (Thomas) - Change copy chunk size to 8M - Add a bunch of comments to xe_sv

[PATCH v6 19/32] drm/xe/uapi: Add DRM_XE_QUERY_CONFIG_FLAG_HAS_CPU_ADDR_MIRROR

2025-02-24 Thread Matthew Brost
Add the DRM_XE_QUERY_CONFIG_FLAG_HAS_CPU_ADDR_MIRROR device query flag, which indicates whether the device supports CPU address mirroring. The intent is for UMDs to use this query to determine if a VM can be set up with CPU address mirroring. This flag is implemented by checking if the device suppo

[PATCH v6 15/32] drm/xe: Add SVM garbage collector

2025-02-24 Thread Matthew Brost
Add basic SVM garbage collector which destroy a SVM range upon a MMU UNMAP event. The garbage collector runs on worker or in GPU fault handler and is required as locks in the path of reclaim are required and cannot be taken the notifier. v2: - Flush garbage collector in xe_svm_close v3: - Better

[PATCH v6 09/32] drm/xe: Add SVM init / close / fini to faulting VMs

2025-02-24 Thread Matthew Brost
Add SVM init / close / fini to faulting VMs. Minimual implementation acting as a placeholder for follow on patches. v2: - Add close function v3: - Better commit message (Thomas) - Kernel doc (Thomas) - Update chunk array to be unsigned long (Thomas) - Use new drm_gpusvm.h header location (Tho

[PATCH v6 26/32] drm/xe: Add Xe SVM devmem_release GPU SVM vfunc

2025-02-24 Thread Matthew Brost
Implement with a simple BO put which releases the device memory. v2: - Use new drm_gpusvm_devmem_ops v3: - Better commit message (Thomas) v4: - Use xe_bo_put_async (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström Reviewed-by: Himal Prasad Ghimiray --- drivers/gpu/drm/xe/

[PATCH v6 22/32] drm/xe: Add drm_gpusvm_devmem to xe_bo

2025-02-24 Thread Matthew Brost
Add drm_gpusvm_devmem to xe_bo. Required to enable SVM migrations. Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström Reviewed-by: Himal Prasad Ghimiray --- drivers/gpu/drm/xe/xe_bo_types.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_bo_types.h b/drive

[PATCH v6 31/32] drm/xe: Add always_migrate_to_vram modparam

2025-02-24 Thread Matthew Brost
Used to show we can bounce memory multiple times which will happen once a real migration policy is implemented. Can be removed once migration policy is implemented. v3: - Pull some changes into the previous patch (Thomas) - Better commit message (Thomas) Signed-off-by: Matthew Brost Reviewed-b

[PATCH v6 29/32] drm/xe: Add SVM debug

2025-02-24 Thread Matthew Brost
Add some useful SVM debug logging fro SVM range which prints the range's state. v2: - Update logging with latest structure layout v3: - Better commit message (Thomas) - New range structure (Thomas) - s/COLLECTOT/s/COLLECTOR (Thomas) v4: - Drop partial evict message (Thomas) - Use %p for poin

[PATCH v6 30/32] drm/xe: Add modparam for SVM notifier size

2025-02-24 Thread Matthew Brost
Useful to experiment with notifier size and how it affects performance. v3: - Pull missing changes including in following patch (Thomas) v5: - Spell out power of 2 (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström Reviewed-by: Himal Prasad Ghimiray --- drivers/gpu/drm/xe/x

[PATCH v6 08/32] drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR

2025-02-24 Thread Matthew Brost
Add the DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR flag, which is used to create unpopulated virtual memory areas (VMAs) without memory backing or GPU page tables. These VMAs are referred to as CPU address mirror VMAs. The idea is that upon a page fault or prefetch, the memory backing and GPU page tables

[PATCH v6 06/32] drm/gpusvm: Add support for GPU Shared Virtual Memory

2025-02-24 Thread Matthew Brost
This patch introduces support for GPU Shared Virtual Memory (SVM) in the Direct Rendering Manager (DRM) subsystem. SVM allows for seamless sharing of memory between the CPU and GPU, enhancing performance and flexibility in GPU computing tasks. The patch adds the necessary infrastructure for SVM, i

[PATCH v6 11/32] drm/xe: Nuke VM's mapping upon close

2025-02-24 Thread Matthew Brost
Clear root PT entry and invalidate entire VM's address space when closing the VM. Will prevent the GPU from accessing any of the VM's memory after closing. v2: - s/vma/vm in kernel doc (CI) - Don't nuke migration VM as this occur at driver unload (CI) v3: - Rebase and pull into SVM series (Thom

[PATCH v6 07/32] drm/xe: Select DRM_GPUSVM Kconfig

2025-02-24 Thread Matthew Brost
Xe depends on DRM_GPUSVM for SVM implementation, select it in Kconfig. v6: - Don't select DRM_GPUSVM if UML (CI) Signed-off-by: Matthew Brost Reviewed-by: Himal Prasad Ghimiray Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

[PATCH v6 05/32] drm/xe/bo: Introduce xe_bo_put_async

2025-02-24 Thread Matthew Brost
From: Thomas Hellström Introduce xe_bo_put_async to put a bo where the context is such that the bo destructor can't run due to lockdep problems or atomic context. If the put is the final put, freeing will be done from a work item. v5: - Kerenl doc for xe_bo_put_async (Thomas) Signed-off-by: M

[PATCH v6 02/32] mm/migrate: Add migrate_device_pfns

2025-02-24 Thread Matthew Brost
Add migrate_device_pfns which prepares an array of pre-populated device pages for migration. This is needed for eviction of known set of non-contiguous devices pages to cpu pages which is a common case for SVM in DRM drivers using TTM. v2: - s/migrate_device_vma_range/migrate_device_prepopulated_

[PATCH v6 00/32] Introduce GPU SVM and Xe SVM implementation

2025-02-24 Thread Matthew Brost
Version 6 of GPU SVM. Thanks to everyone (especially Sima, Thomas, Alistair, Himal) for their numerous reviews on revision 1, 2, 3 and for helping to address many design issues. This version has been tested with IGT [1] on PVC, BMG, and LNL. Also tested with level0 (UMD) PR [2]. Major changes in

RE: [PATCH V9] drm/xe/uapi: Use hint for guc to set GT frequency

2025-02-24 Thread Upadhyay, Tejas
> -Original Message- > From: De Marchi, Lucas > Sent: Tuesday, February 25, 2025 12:42 AM > To: Upadhyay, Tejas > Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > Belgaumkar, Vinay > Subject: Re: [PATCH V9] drm/xe/uapi: Use hint for guc to set GT frequency > > On

Re: [PATCH v2 2/2] drm/panel: add Raydium RM67200 panel driver

2025-02-24 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 05:21:48PM +0100, Sebastian Reichel wrote: > The Rockchip W552793DBA-V10 display/touchscreen board contains a > Wanchanglong W552793BAA panel, which in turn is using a Raydium > RM67200 MIPI-DSI controller. Add a DSI panel driver for it. > > The W552793BAA panel init sequen

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread H. Peter Anvin
On 2/24/25 14:08, Uros Bizjak wrote: On Mon, Feb 24, 2025 at 10:56 PM H. Peter Anvin wrote: On 2/24/25 07:24, Uros Bizjak wrote: On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations a

Re: [PATCH 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-02-24 Thread Dmitry Baryshkov
On Mon, Feb 24, 2025 at 09:40:23PM +0100, Luca Weiss wrote: > On 23-02-2025 7:25 p.m., Dmitry Baryshkov wrote: > > On Sat, Feb 22, 2025 at 06:58:05PM +0100, Luca Weiss wrote: > > > Himax HX83112B is a display driver IC used to drive LCD DSI panels. > > > Describe it and the Fairphone 3 panel from D

Re: [PATCH v2 05/16] dt-bindings: display/msm: dp-controller: Add SM8750

2025-02-24 Thread Dmitry Baryshkov
On Mon, 24 Feb 2025 at 20:59, Abhinav Kumar wrote: > > > > On 2/19/2025 9:08 AM, Dmitry Baryshkov wrote: > > On Wed, Feb 19, 2025 at 06:02:20PM +0100, Krzysztof Kozlowski wrote: > >> On 17/02/2025 19:58, Dmitry Baryshkov wrote: > >>> On Mon, Feb 17, 2025 at 05:41:26PM +0100, Krzysztof Kozlowski wr

Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled

2025-02-24 Thread Qianyi Liu
Hello Philipp, Thank you for your patient reply. Let's first clarify the issue and send a new patch if necessary. As soon as it enters the drm_sched_entity_kill function, the entity ->last_scheduled reference count is incremented by 1. If there are still jobs in the current entity, it will enter

Re: [PATCH] drm/scheduler: Fix mem leak when last_scheduled signaled

2025-02-24 Thread Qianyi Liu
Thank you for your patient reply. Let's first clarify the issue and send a new patch if necessary. As soon as it enters the drm_sched_entity_kill function, the entity ->last_stchedled reference count is incremented by 1. If there are still jobs in the current entity, it will enter the while loop,

Re: [PATCH v3] drm/amd/display/dc: Refactor remove duplications on command_table files

2025-02-24 Thread Luan Icaro Pinto Arcanjo
Hi, Sorry for the late reply, I have submitted a v4 with the changes to put these functions in the command_table_helper.c rather than adding a new set of files. The mail title of v4 is "[PATCH v4] drm/amd/display/dc: Refactor remove duplications" @alexander.deuc...@amd.com Can you take a look?

[PATCH v4] drm/amd/display/dc: Refactor remove duplications

2025-02-24 Thread Luan Icaro Pinto Arcanjo
From: Luan Arcanjo All dce command_table_helper's shares a copy-pasted collection of copy-pasted functions, which are: phy_id_to_atom, clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom. This patch removes the multiple copy-pasted by moving them to the command_table_helper.c and make

Re: [PATCH v7 10/15] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > @@ -392,11 +393,27 @@ static const struct component_ops > rockchip_dp_component_ops = { > .unbind = rockchip_dp_unbind, > }; > > +static int rockchip_dp_link_panel(struct drm_dp_aux *aux) > +{ > + struct analogix_dp_plat_d

Re: [PATCH v7 03/15] drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > The IRQF_NO_AUTOEN can be used for the drivers that don't want > interrupts to be enabled automatically via devm_request_threaded_irq(). > Using this flag can provide be more robust compared to the way of > calling disable_irq() after dev

Re: [PATCH v7 05/15] drm/bridge: analogix_dp: Remove CONFIG_PM related check in analogix_dp_bind()/analogix_dp_unbind()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > Remove the check related to CONFIG_PM in order to make the code more > concise, as the CONFIG_PM should be a required option for many drivers. > > In addition, it is preferable to use devm_pm_runtime_enable() instead of > manually invokin

Re: [PATCH v7 09/15] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > The main modification is moving the DP AUX initialization from function > analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of > eDP panel during probing, it is also needed to advance PM operations to > ensure that eDP c

Re: [PATCH v7 04/15] drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via > runtime PM"), the PM operations can help enable/disable the clock. The > err_disable_clk label and clk_disable_unprepare() operations are no > longer necessary bec

Re: [PATCH][next] drm/nouveau: Avoid multiple -Wflex-array-member-not-at-end warnings

2025-02-24 Thread Dave Airlie
On Sat, 15 Feb 2025 at 00:34, Danilo Krummrich wrote: > > On Wed, Feb 12, 2025 at 07:31:26PM +1030, Gustavo A. R. Silva wrote: > > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > > getting ready to enable it, globally. > > > > So, in order to avoid ending up with flexible-arr

Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

2025-02-24 Thread Kuninori Morimoto
Hi Detlev Thank you for Cc:ing to me. Sorry for my late response. Monday was holiday in Japan. > I'm really feel like simple_util_clean_reference(card) in simple_probe() > errors path should not be called anymore, since (snip) > I'm adding Kuninori Morimoto in the to list of this thread for ex

[PATCH v3] drm/amdgpu: Trigger a wedged event for ring reset

2025-02-24 Thread André Almeida
Instead of only triggering a wedged event for complete GPU resets, trigger for ring resets. Regardless of the reset, it's useful for userspace to know that it happened because the kernel will reject further submissions from that app. Signed-off-by: André Almeida --- v3: do only for ring resets, n

[PATCH] drm/omap: Remove unused omapdss_find_device_by_node

2025-02-24 Thread linux
From: "Dr. David Alan Gilbert" The last use of omapdss_find_device_by_node() was removed by 2020's commit 811860ddceac ("drm/omap: drop unused DSS next pointer") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/omapdrm/dss/base.c| 12 drivers/gpu/drm/omapd

Re: [PATCH] drm/repaper: fix integer overflows in repeat functions

2025-02-24 Thread Alex Lanzano
On Thu, Jan 16, 2025 at 05:48:01AM -0800, Nikita Zhandarovich wrote: > There are conditions, albeit somewhat unlikely, under which right hand > expressions, calculating the end of time period in functions like > repaper_frame_fixed_repeat(), may overflow. > > For instance, if 'factor10x' in repape

[PATCH 0/1] Refactoring of framebuffer drawing routines

2025-02-24 Thread Zsolt Kajtar
Proper refactoring of the framebuffer drawing routines. This time it's not only the merging of duplicated code. It isn't half finished either so the various combinations of foreign endianness, pixel reversing, bits per pixel, cpu word sizes and byte order should work. Added myself to look after th

Re: [PATCH] drm/bridge: ti-sn65dsi86: Check for CONFIG_PWM using IS_REACHABLE()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 17, 2025 at 9:49 AM Uwe Kleine-König wrote: > > Currently CONFIG_PWM is a bool but I intend to change it to tristate. If > CONFIG_PWM=m in the configuration, the cpp symbol CONFIG_PWM isn't > defined and so the PWM code paths in the ti-sn65dsi86 driver are not > used. > > The corr

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-24 Thread Kajtár Zsolt
Hello Thomas! Wanted to answer earlier but things took time, and a lot more than expected. > First of all, commit 779121e9f175 ("fbdev: Support for byte-reversed > framebuffer formats") isn't super complicated AFAICT. I can be > implemented in the sys_ helpers as well. It seems like you initially

Re: [RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation

2025-02-24 Thread Danilo Krummrich
On Mon, Feb 24, 2025 at 01:45:02PM -0500, Joel Fernandes wrote: > Hi Danilo, > > On Mon, Feb 24, 2025 at 01:11:17PM +0100, Danilo Krummrich wrote: > > On Mon, Feb 24, 2025 at 01:07:19PM +0100, Danilo Krummrich wrote: > > > CC: Gary > > > > > > On Mon, Feb 24, 2025 at 10:40:00AM +0900, Alexandre C

[PATCH 1/1] Refactoring of framebuffer drawing routines

2025-02-24 Thread Zsolt Kajtar
Signed-off-by: Zsolt Kajtar --- MAINTAINERS | 16 + drivers/video/fbdev/core/Kconfig| 10 +- drivers/video/fbdev/core/cfbcopyarea.c | 428 +--- drivers/video/fbdev/core/cfbfillrect.c | 362 + drivers/video/fbdev/core/cfbimgbl

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread Yury Norov
On Mon, Feb 24, 2025 at 02:21:13PM -0800, H. Peter Anvin wrote: > On February 24, 2025 2:17:29 PM PST, Yury Norov wrote: > >On Mon, Feb 24, 2025 at 01:55:28PM -0800, H. Peter Anvin wrote: > >> On 2/24/25 07:24, Uros Bizjak wrote: > >> > > >> > > >> > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: > >

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread H. Peter Anvin
On February 24, 2025 2:17:29 PM PST, Yury Norov wrote: >On Mon, Feb 24, 2025 at 01:55:28PM -0800, H. Peter Anvin wrote: >> On 2/24/25 07:24, Uros Bizjak wrote: >> > >> > >> > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: >> > > Refactor parity calculations to use the standard parity8() helper. This

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread H. Peter Anvin
On February 24, 2025 2:08:05 PM PST, Uros Bizjak wrote: >On Mon, Feb 24, 2025 at 10:56 PM H. Peter Anvin wrote: >> >> On 2/24/25 07:24, Uros Bizjak wrote: >> > >> > >> > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: >> >> Refactor parity calculations to use the standard parity8() helper. This >> >> c

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread Yury Norov
On Mon, Feb 24, 2025 at 01:55:28PM -0800, H. Peter Anvin wrote: > On 2/24/25 07:24, Uros Bizjak wrote: > > > > > > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: > > > Refactor parity calculations to use the standard parity8() helper. This > > > change eliminates redundant implementations and improves

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread Uros Bizjak
On Mon, Feb 24, 2025 at 10:56 PM H. Peter Anvin wrote: > > On 2/24/25 07:24, Uros Bizjak wrote: > > > > > > On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: > >> Refactor parity calculations to use the standard parity8() helper. This > >> change eliminates redundant implementations and improves code > >>

Re: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8()

2025-02-24 Thread H. Peter Anvin
On 2/24/25 07:24, Uros Bizjak wrote: On 23. 02. 25 17:42, Kuan-Wei Chiu wrote: Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. The patch improves parity assembly code in bootflag.o from:   58:

Re: [PATCH 03/14] dt-bindings: arm: fsl: Add GOcontroll Moduline Display

2025-02-24 Thread Rob Herring (Arm)
On Mon, 24 Feb 2025 14:50:53 +0100, Maud Spierings wrote: > Document the compatible strings for the Moduline Display controller. > > Signed-off-by: Maud Spierings > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)

Re: [PATCH 05/14] dt-bindings: trivial-devices: add GOcontroll Moduline IO modules

2025-02-24 Thread Rob Herring
On Mon, Feb 24, 2025 at 02:50:55PM +0100, Maud Spierings wrote: > The main point of the Moduline series of embedded controllers is its > ecosystem of IO modules, these currently are operated through the spidev > interface. Ideally there will be a full dedicated driver in the future. > > Add the go

Re: [PATCH 02/14] dt-bindings: display: simple: Add BOE AV123Z7M-N17 panel

2025-02-24 Thread Rob Herring (Arm)
On Mon, 24 Feb 2025 14:50:52 +0100, Maud Spierings wrote: > Add support for the BOE AV123Z7M-N17 12.3" LVDS panel. > > Signed-off-by: Maud Spierings > --- > .../devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml | 2 > ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob He

Re: [PATCH 06/14] arm64: dts: imx8mp: Add pinctrl config definitions

2025-02-24 Thread Rob Herring (Arm)
On Mon, 24 Feb 2025 14:50:56 +0100, Maud Spierings wrote: > Currently to configure each IOMUXC_SW_PAD_CTL_PAD the raw value of this > register is written in the dts, these values are not obvious. Add defines > which describe the fields of this register which can be or-ed together to > produce rea

Re: [PATCH 2/4] dt-bindings: display: panel: Add Himax HX83112B

2025-02-24 Thread Luca Weiss
On 23-02-2025 7:25 p.m., Dmitry Baryshkov wrote: On Sat, Feb 22, 2025 at 06:58:05PM +0100, Luca Weiss wrote: Himax HX83112B is a display driver IC used to drive LCD DSI panels. Describe it and the Fairphone 3 panel from DJN using it. Signed-off-by: Luca Weiss --- .../bindings/display/panel/h

Re: [PATCH 04/14] dt-bindings: vendor-prefixes: add GOcontroll

2025-02-24 Thread Rob Herring
On Mon, Feb 24, 2025 at 02:50:54PM +0100, Maud Spierings wrote: > GOcontroll produces embedded linux systems and IO modules to use in > these sytems, add its a prefix. s/sytems/systems/ s/ a / / > > Signed-off-by: Maud Spierings > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml |

Re: [PATCH 01/14] dt-bindings: display: simple: add BOE AV101HDT-A10 panel

2025-02-24 Thread Rob Herring (Arm)
On Mon, 24 Feb 2025 14:50:51 +0100, Maud Spierings wrote: > add a compatible string for the BOE AV101HDT-A10 10.1" LVDS panel > > Signed-off-by: Maud Spierings > --- > Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob

Re: [PATCH v3 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-24 Thread Rob Herring
On Mon, Feb 24, 2025 at 01:48:13PM +0200, Svyatoslav Ryhel wrote: > Add bindings for the LM3533 - a complete power source for backlight, keypad > and indicator LEDs in smartphone handsets. The high-voltage inductive boost > converter provides the power for two series LED strings display backlight >

Re: [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable display and GPU

2025-02-24 Thread Konrad Dybcio
On 22.02.2025 6:58 PM, Luca Weiss wrote: > Add the description for the display panel found on this phone. > Unfortunately the LCDB module on PMI632 isn't yet supported upstream so > we need to use a dummy regulator-fixed in the meantime. > > And with this done we can also enable the GPU and set th

Re: [PATCH v7 11/15] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588

2025-02-24 Thread Rob Herring (Arm)
On Mon, 24 Feb 2025 16:13:21 +0800, Damon Ding wrote: > Compared with RK3288/RK3399, the HBR2 link rate support is the main > improvement of RK3588 eDP TX controller, and there are also two > independent eDP display interfaces on RK3588 Soc. > > The newly added 'apb' reset is to ensure the APB b

Re: [PATCH 1/6] dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller

2025-02-24 Thread Rob Herring
On Sun, Feb 23, 2025 at 07:30:24PM +0800, Andy Yan wrote: > From: Andy Yan > > The Rockchip RK3588 SoC integrates the Synopsys DesignWare DPTX > controller. And this DPTX controller need share a USBDP PHY with > the USB 3.0 OTG controller during operation. > > Signed-off-by: Andy Yan > > --- >

Re: [PATCH v2] drm/mipi-dsi: extend "multi" functions and use them in sony-td4353-jdi

2025-02-24 Thread Doug Anderson
Hi, On Wed, Feb 19, 2025 at 8:58 PM Tejas Vipin wrote: > > Removes mipi_dsi_dcs_set_tear_off and replaces it with a > multi version as after replacing it in sony-td4353-jdi, it doesn't > appear anywhere else. sony-td4353-jdi is converted to use multi style > functions, including mipi_dsi_dcs_set_

Re: [PATCH 02/17] bitops: Add generic parity calculation for u64

2025-02-24 Thread Yury Norov
On Mon, Feb 24, 2025 at 12:42:02AM +0800, Kuan-Wei Chiu wrote: > Several parts of the kernel open-code parity calculations using > different methods. Add a generic parity64() helper implemented with the > same efficient approach as parity8(). No reason to add parity32() and parity64() in separate

[PATCH v4] drm/mgag200: Apply upper limit for clock variable

2025-02-24 Thread Murad Masimov
If the value of the clock variable is higher than 80, the value of the variable m, which is used as a divisor, will remain zero, because (clock * testp) will be higher than vcomax in every loop iteration, which leads to skipping every iteration and leaving variable m unmodified. Return -EINVAL

Re: [PATCH] vgaswitcheroo: Fix error checking in vga_switcheroo_register_audio_client()

2025-02-24 Thread Dan Carpenter
On Mon, Feb 24, 2025 at 03:14:33PM +0200, Jani Nikula wrote: > On Wed, 19 Feb 2025, Dan Carpenter wrote: > > The "id" variable is an enum and in this context it's treated as an > > unsigned int so the error handling can never trigger. The > > ->get_client_id() functions do not currently return an

RE: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-24 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Monday, February 24, 2025 5:30 AM > > On Mon, Feb 24, 2025 at 12:38:22AM +, Michael Kelley wrote: > > From: Saurabh Singh Sengar Sent: Sunday, > > February 23, 2025 6:10 AM > > > > > > On Sat, Feb 22, 2025 at 08:16:53PM +, Michael Kelley wrote: > > > >

  1   2   3   4   >