Re: Include ASPEED ast-drm 1.15.1 video driver in kernel tree

2025-02-12 Thread Thomas Zimmermann
Hi Nicolas Am 12.02.25 um 19:58 schrieb Nicolas Baranger: Dear maintener That's mostly me and Jocelyn. I did include ast-drm driver version 1.15.1 (in replacement of version 0.1.0) on the new mainline kernel too (6.14.0-rc2) and I issue a new dkms patch Last DKMS patch had been sucessfu

Re: [PATCH v6 32/42] drm/mediatek: mtk_hdmi: Cleanup function mtk_hdmi_resume()

2025-02-12 Thread 胡俊光

Re: [PATCH v6 31/42] drm/mediatek: mtk_hdmi: Remove driver bound to HDMI print

2025-02-12 Thread 胡俊光

Re: [PATCH v6 29/42] drm/mediatek: mtk_hdmi: Remove ifdef for CONFIG_PM_SLEEP

2025-02-12 Thread 胡俊光

Re: [PATCH v6 25/42] drm/mediatek: mtk_hdmi: Move CEC device parsing in new function

2025-02-12 Thread 胡俊光

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread Thomas Zimmermann
Hi Am 12.02.25 um 20:59 schrieb John Edwards: Hello, Thomas and Hans. On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede wrote: Hi, On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote: Hi Am 12.02.25 um 11:51 schrieb Hans de Goede: Hi Thomas, On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote: Hi Am

Re: [PATCH v6 24/42] drm/mediatek: mtk_hdmi: Use dev_err_probe() in mtk_hdmi_dt_parse_pdata()

2025-02-12 Thread 胡俊光

[PATCH] Documentation: Remove repeated word in docs

2025-02-12 Thread Charles Han
Remove the repeated word "the" in docs. Signed-off-by: Charles Han --- Documentation/gpu/amdgpu/display/dc-debug.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/display/dc-debug.rst b/Documentation/gpu/amdgpu/display/dc-debug.rst index 013f63b271

Re: Unified Type C PHYs and top-level port management

2025-02-12 Thread Peter Chen
On 25-01-14 21:32:11, Hector Martin wrote: > Hi all, > > We're implementing Type C port support for Apple systems and we're > running into impedance mismatches with the existing Linux subsystems. I > want to throw a quick overview of the problem here and see if we can > come up with solutions. >

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-12 Thread Abdiel Janulgue
Hi, On 13/02/2025 05:49, Icenowy Zheng wrote: Sorry, but I did a fact check on this, and I found that the only "reviewer" of DMA MAPPING HELPERS is Robin Murphy, he has only one reply in this thread, and the reply only says "Indeed, FWIW it seems like the appropriate level of abstraction to me,

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-12 Thread Sumit Garg
Hi Boris, On Thu, 13 Feb 2025 at 01:26, Boris Brezillon wrote: > > +Florent, who's working on protected-mode support in Panthor. > > Hi Jens, > > On Tue, 17 Dec 2024 11:07:36 +0100 > Jens Wiklander wrote: > > > Hi, > > > > This patch set allocates the restricted DMA-bufs via the TEE subsystem. >

Re: [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args

2025-02-12 Thread 胡俊光

Re: [PATCH v1 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-12 Thread Svyatoslav Ryhel
ср, 12 лют. 2025 р. о 21:49 Conor Dooley пише: > > On Wed, Feb 12, 2025 at 09:58:41AM +0200, Svyatoslav Ryhel wrote: > > Add bindings for the LM3533 - a complete power source for > > backlight, keypad, and indicator LEDs in smartphone handsets. > > The high-voltage inductive boost converter provid

Re: [PATCH v3 2/2] gpu: nova-core: add initial documentation

2025-02-12 Thread Alistair Popple
On Thu, Feb 13, 2025 at 12:33:21AM +, Benno Lossin wrote: > On 13.02.25 00:27, Alistair Popple wrote: > > On Sun, Feb 09, 2025 at 06:30:25PM +0100, Danilo Krummrich wrote: > > > > [...] > > > >> +FromPrimitive API > >> +- > >> + > >> +Sometimes the need arises to convert a num

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-12 Thread Icenowy Zheng
在 2025-02-10星期一的 11:24 +0100,Danilo Krummrich写道: > On Mon, Feb 10, 2025 at 05:41:30PM +0800, Icenowy Zheng wrote: > > Furtherly, the monorepo nature of Linux kernel means to refactor an > > interface, it's usually the person changing the callee that need to > > change all callers to satify the inte

RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Wednesday, February 12, 2025 7:07 PM > > On Thu, Feb 13, 2025 at 01:35:22AM +, Michael Kelley wrote: > > From: Saurabh Singh Sengar Sent: Monday, > > February 10, 2025 8:52 AM > > > > > [snip] > > > > > > > > > > > > While we are at it, I want to mention th

Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 4:04 PM, Dmitry Baryshkov wrote: On Wed, Feb 12, 2025 at 03:03:47PM -0800, James A. MacInnes wrote: Type-C DisplayPort inoperable due to incorrect porch settings. - Re-used wide_bus_en as flag to prevent porch shifting Unfortunately I don't know enough details to comment on thi

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 3:41 PM, Marijn Suijten wrote: On 2025-02-12 15:03:46, James A. MacInnes wrote: SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable wide_bus operation did not take into account the SDM845 and it got carried over by accident. - Incorrect setting caus

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Saurabh Singh Sengar
On Thu, Feb 13, 2025 at 01:35:22AM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 8:52 AM > > > [snip] > > > > > > > > > > While we are at it, I want to mention that I also observed below WARN > > > > > while removing the hyperv_fb, but that needs a s

[PATCH v5 22/32] drm/xe: Add drm_gpusvm_devmem to xe_bo

2025-02-12 Thread Matthew Brost
Add drm_gpusvm_devmem to xe_bo. Required to enable SVM migrations. Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_bo_types.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_bo_types.h b/drivers/gpu/drm/xe/xe_bo_types.h index 60

[PATCH v5 28/32] drm/xe: Basic SVM BO eviction

2025-02-12 Thread Matthew Brost
Wire xe_bo_move to GPU SVM migration via new helper xe_svm_bo_evict. v2: - Use xe_svm_bo_evict - Drop bo->range v3: - Kernel doc (Thomas) v4: - Add missing xe_bo.c code v5: - Add XE_BO_FLAG_CPU_ADDR_MIRROR flag in this patch (Thomas) - Add message on eviction failure Signed-off-by: Matthew

[PATCH v5 16/32] drm/xe: Add unbind to SVM garbage collector

2025-02-12 Thread Matthew Brost
Add unbind to SVM garbage collector. To facilitate add unbind support function to VM layer which unbinds a SVM range. Also teach PT layer to understand unbinds of SVM ranges. v3: - s/INVALID_VMA/XE_INVALID_VMA (Thomas) - Kernel doc (Thomas) - New GPU SVM range structure (Thomas) - s/DRM_GPUVA_

Re: [PATCH v2 2/3] drm/msm/dsi: Set PHY usescase (and mode) before registering DSI host

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 05:13:08PM -0800, Abhinav Kumar wrote: > Hi Marijn > > On 2/10/2025 2:17 PM, Abhinav Kumar wrote: > > > > > > On 2/10/2025 6:24 AM, Dmitry Baryshkov wrote: > > > On Mon, Feb 10, 2025 at 01:54:29PM +0100, Marijn Suijten wrote: > > > > On 2025-02-10 01:11:59, Dmitry Baryshk

Re: [PATCH] drm: drop i2c subdir from Makefile

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 05:18:03PM -0800, Matthew Brost wrote: > On Thu, Feb 13, 2025 at 02:49:41AM +0200, Dmitry Baryshkov wrote: > > The commit 325ba852d148 ("drm/i2c: move TDA998x driver under > > drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but > > didn't update upper level

Re: [PATCH] drm: drop i2c subdir from Makefile

2025-02-12 Thread Dmitry Baryshkov
On Thu, 13 Feb 2025 02:49:41 +0200, Dmitry Baryshkov wrote: > The commit 325ba852d148 ("drm/i2c: move TDA998x driver under > drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but > didn't update upper level Makefile. Drop corresponding line to fix build > issues. > > Applied to d

[PATCH v5 25/32] drm/xe: Add Xe SVM populate_devmem_pfn GPU SVM vfunc

2025-02-12 Thread Matthew Brost
Get device pfns from BO's buddy blocks. Used in migrate_* core MM functions called in GPU SVM to migrate between device and system memory. v2: - Use new drm_gpusvm_devmem_ops v3: - Better commit message (Thomas) v5: - s/xe_mem_region/xe_vram_region (Rebase) Signed-off-by: Niranjana Vishwanatha

[PATCH v5 11/32] drm/xe: Nuke VM's mapping upon close

2025-02-12 Thread Matthew Brost
Clear root PT entry and invalidate entire VM's address space when closing the VM. Will prevent the GPU from accessing any of the VM's memory after closing. v2: - s/vma/vm in kernel doc (CI) - Don't nuke migration VM as this occur at driver unload (CI) v3: - Rebase and pull into SVM series (Thom

[PATCH v5 32/32] drm/doc: gpusvm: Add GPU SVM documentation

2025-02-12 Thread Matthew Brost
Add documentation for agree upon GPU SVM design principles, current status, and future plans. v4: - Address Thomas's feedback v5: - s/Current/Basline (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- Documentation/gpu/rfc/gpusvm.rst | 84

[PATCH v5 27/32] drm/xe: Add SVM VRAM migration

2025-02-12 Thread Matthew Brost
Migration is implemented with range granularity, with VRAM backing being a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the TTM BO is limited to when the SVM range is in VRAM (i.e., when a VRAM SVM range is migrated to SRAM, the TTM BO is destroyed). The design choice for usi

[PATCH v5 06/32] drm/gpusvm: Add support for GPU Shared Virtual Memory

2025-02-12 Thread Matthew Brost
This patch introduces support for GPU Shared Virtual Memory (SVM) in the Direct Rendering Manager (DRM) subsystem. SVM allows for seamless sharing of memory between the CPU and GPU, enhancing performance and flexibility in GPU computing tasks. The patch adds the necessary infrastructure for SVM, i

[PATCH v5 29/32] drm/xe: Add SVM debug

2025-02-12 Thread Matthew Brost
Add some useful SVM debug logging fro SVM range which prints the range's state. v2: - Update logging with latest structure layout v3: - Better commit message (Thomas) - New range structure (Thomas) - s/COLLECTOT/s/COLLECTOR (Thomas) v4: - Drop partial evict message (Thomas) - Use %p for poin

[PATCH v5 30/32] drm/xe: Add modparam for SVM notifier size

2025-02-12 Thread Matthew Brost
Useful to experiment with notifier size and how it affects performance. v3: - Pull missing changes including in following patch (Thomas) v5: - Spell out power of 2 (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_module.c | 4 drivers/gpu/drm

[PATCH v5 23/32] drm/xe: Add drm_pagemap ops to SVM

2025-02-12 Thread Matthew Brost
From: Thomas Hellström Add support for mapping device pages to Xe SVM by attaching drm_pagemap to a memory region, which is then linked to a GPU SVM devmem allocation. This enables GPU SVM to derive the device page address. v3: - Better commit message (Thomas) - New drm_pagemap.h location v5:

[PATCH v5 17/32] drm/xe: Do not allow CPU address mirror VMA unbind if the GPU has bindings

2025-02-12 Thread Matthew Brost
uAPI is designed with the use case that only mapping a BO to a malloc'd address will unbind a CPU-address mirror VMA. Therefore, allowing a CPU-address mirror VMA to unbind when the GPU has bindings in the range being unbound does not make much sense. This behavior is not supported, as it simplifie

[PATCH v5 15/32] drm/xe: Add SVM garbage collector

2025-02-12 Thread Matthew Brost
Add basic SVM garbage collector which destroy a SVM range upon a MMU UNMAP event. The garbage collector runs on worker or in GPU fault handler and is required as locks in the path of reclaim are required and cannot be taken the notifier. v2: - Flush garbage collector in xe_svm_close v3: - Better

[PATCH v5 31/32] drm/xe: Add always_migrate_to_vram modparam

2025-02-12 Thread Matthew Brost
Used to show we can bounce memory multiple times which will happen once a real migration policy is implemented. Can be removed once migration policy is implemented. v3: - Pull some changes into the previous patch (Thomas) - Better commit message (Thomas) Signed-off-by: Matthew Brost Reviewed-b

[PATCH v5 24/32] drm/xe: Add GPUSVM device memory copy vfunc functions

2025-02-12 Thread Matthew Brost
Add GPUSVM device memory copy vfunc functions and connect to migration layer. Used for device memory migration. v2: - Allow NULL device pages in xe_svm_copy - Use new drm_gpusvm_devmem_ops v3: - Prefix defines with XE_ (Thomas) - Change copy chunk size to 8M - Add a bunch of comments to xe_sv

[PATCH v5 20/32] drm/xe: Add migrate layer functions for SVM support

2025-02-12 Thread Matthew Brost
Add functions which migrate to / from VRAM accepting a single DPA argument (VRAM) and array of dma addresses (SRAM). Used for SVM migrations. v2: - Don't unlock job_mutex in error path of xe_migrate_vram v3: - Kernel doc (Thomas) - Better commit message (Thomas) - s/dword/num_dword (Thomas) -

[PATCH v5 03/32] mm/migrate: Trylock device page in do_swap_page

2025-02-12 Thread Matthew Brost
Avoid multiple CPU page faults to the same device page racing by trying to lock the page in do_swap_page before taking an extra reference to the page. This prevents scenarios where multiple CPU page faults each take an extra reference to a device page, which could abort migration in folio_migrate_m

[PATCH v5 14/32] drm/xe: Add (re)bind to SVM page fault handler

2025-02-12 Thread Matthew Brost
Add (re)bind to SVM page fault handler. To facilitate add support function to VM layer which (re)binds a SVM range. Also teach PT layer to understand (re)binds of SVM ranges. v2: - Don't assert BO lock held for range binds - Use xe_svm_notifier_lock/unlock helper in xe_svm_close - Use drm_pagem

[PATCH v5 07/32] drm/xe: Select DRM_GPUSVM Kconfig

2025-02-12 Thread Matthew Brost
Xe depends on DRM_GPUSVM for SVM implementation, select it in Kconfig. Signed-off-by: Matthew Brost Reviewed-by: Himal Prasad Ghimiray Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/x

[PATCH v5 12/32] drm/xe: Add SVM range invalidation and page fault

2025-02-12 Thread Matthew Brost
Add SVM range invalidation vfunc which invalidates PTEs. A new PT layer function which accepts a SVM range is added to support this. In addition, add the basic page fault handler which allocates a SVM range which is used by SVM range invalidation vfunc. v2: - Don't run invalidation if VM is close

[PATCH v5 19/32] drm/xe/uapi: Add DRM_XE_QUERY_CONFIG_FLAG_HAS_CPU_ADDR_MIRROR

2025-02-12 Thread Matthew Brost
Add the DRM_XE_QUERY_CONFIG_FLAG_HAS_CPU_ADDR_MIRROR device query flag, which indicates whether the device supports CPU address mirroring. The intent is for UMDs to use this query to determine if a VM can be set up with CPU address mirroring. This flag is implemented by checking if the device suppo

[PATCH v5 13/32] drm/gpuvm: Add DRM_GPUVA_OP_DRIVER

2025-02-12 Thread Matthew Brost
Add DRM_GPUVA_OP_DRIVER which allows driver to define their own gpuvm ops. Useful for driver created ops which can be passed into the bind software pipeline. v3: - s/DRM_GPUVA_OP_USER/DRM_GPUVA_OP_DRIVER (Thomas) - Better commit message (Thomas) Cc: Danilo Krummrich Signed-off-by: Matthew Bros

[PATCH v5 26/32] drm/xe: Add Xe SVM devmem_release GPU SVM vfunc

2025-02-12 Thread Matthew Brost
Implement with a simple BO put which releases the device memory. v2: - Use new drm_gpusvm_devmem_ops v3: - Better commit message (Thomas) v4: - Use xe_bo_put_async (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_svm.c | 9 + 1 file chang

[PATCH v5 21/32] drm/xe: Add SVM device memory mirroring

2025-02-12 Thread Matthew Brost
Add SVM device memory mirroring which enables device pages for migration. Enabled via CONFIG_XE_DEVMEM_MIRROR Kconfig. Kconfig option defaults to enabled. If not enabled, SVM will work sans migration and KMD memory footprint will be less. v3: - Add CONFIG_XE_DEVMEM_MIRROR v4: - Fix Kconfig (Hima

[PATCH v5 18/32] drm/xe: Enable CPU address mirror uAPI

2025-02-12 Thread Matthew Brost
Support for CPU address mirror bindings in SRAM fully in place, enable the implementation. v3: - s/system allocator/CPU address mirror (Thomas) Signed-off-by: Matthew Brost Reviewed-by: Thomas Hellström --- drivers/gpu/drm/xe/xe_vm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/dr

[PATCH v5 05/32] drm/xe/bo: Introduce xe_bo_put_async

2025-02-12 Thread Matthew Brost
From: Thomas Hellström Introduce xe_bo_put_async to put a bo where the context is such that the bo destructor can't run due to lockdep problems or atomic context. If the put is the final put, freeing will be done from a work item. v5: - Kerenl doc for xe_bo_put_async (Thomas) Signed-off-by: M

[PATCH v5 10/32] drm/xe: Add dma_addr res cursor

2025-02-12 Thread Matthew Brost
From: Thomas Hellström Add dma_addr res cursor which walks an array of drm_pagemap_dma_addr. Useful for SVM ranges and programing page tables. v3: - Better commit message (Thomas) - Use new drm_pagemap.h location Signed-off-by: Matthew Brost Signed-off-by: Thomas Hellström Reviewed-by: Matt

[PATCH v5 08/32] drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR

2025-02-12 Thread Matthew Brost
Add the DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR flag, which is used to create unpopulated virtual memory areas (VMAs) without memory backing or GPU page tables. These VMAs are referred to as CPU address mirror VMAs. The idea is that upon a page fault or prefetch, the memory backing and GPU page tables

[PATCH v5 04/32] drm/pagemap: Add DRM pagemap

2025-02-12 Thread Matthew Brost
From: Thomas Hellström Introduce drm_pagemap ops to map and unmap dma to VRAM resources. In the local memory case it's a matter of merely providing an offset into the device's physical address. For future p2p the map and unmap functions may encode as needed. Similar to how dma-buf works, let the

[PATCH v5 09/32] drm/xe: Add SVM init / close / fini to faulting VMs

2025-02-12 Thread Matthew Brost
Add SVM init / close / fini to faulting VMs. Minimual implementation acting as a placeholder for follow on patches. v2: - Add close function v3: - Better commit message (Thomas) - Kernel doc (Thomas) - Update chunk array to be unsigned long (Thomas) - Use new drm_gpusvm.h header location (Tho

[PATCH v5 01/32] drm/xe: Retry BO allocation

2025-02-12 Thread Matthew Brost
TTM doesn't support fair eviction via WW locking, this mitigated in by using retry loops in exec and preempt rebind worker. Extend this retry loop to BO allocation. Once TTM supports fair eviction this patch can be reverted. v4: - Keep line break (Stuart) Signed-off-by: Matthew Brost Reviewed-b

[PATCH v5 02/32] mm/migrate: Add migrate_device_pfns

2025-02-12 Thread Matthew Brost
Add migrate_device_pfns which prepares an array of pre-populated device pages for migration. This is needed for eviction of known set of non-contiguous devices pages to cpu pages which is a common case for SVM in DRM drivers using TTM. v2: - s/migrate_device_vma_range/migrate_device_prepopulated_

[PATCH v5 00/32] Introduce GPU SVM and Xe SVM implementation

2025-02-12 Thread Matthew Brost
Version 5 of GPU SVM. Thanks to everyone (especially Sima, Thomas, Alistair, Himal) for their numerous reviews on revision 1, 2, 3 and for helping to address many design issues. This version has been tested with IGT [1] on PVC, BMG, and LNL. Also tested with level0 (UMD) PR [2]. Major changes in

Re: [PATCH v2] drm/msm/dpu: Fix uninitialized variable

2025-02-12 Thread Abhinav Kumar
On 2/11/2025 4:19 PM, Abhinav Kumar wrote: On 2/11/2025 4:13 PM, Dmitry Baryshkov wrote: On Tue, Feb 11, 2025 at 10:23:54AM +0100, Marijn Suijten wrote: On 2025-02-10 14:14:14, Abhinav Kumar wrote: On 2/9/2025 7:51 PM, Ethan Carter Edwards wrote: There is a possibility for an uninitial

RE: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Michael Kelley
From: Saurabh Singh Sengar Sent: Monday, February 10, 2025 8:52 AM > [snip] > > > > > > > > While we are at it, I want to mention that I also observed below WARN > > > > while removing the hyperv_fb, but that needs a separate fix. > > > > > > > > > > > > [ 44.111220] WARNING: CPU: 35 PID: 1882

Re: [PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 12:23 PM, Abhinav Kumar wrote: On 2/11/2025 7:59 PM, Jessica Zhang wrote: Disable pingpong dither in dpu_encoder_helper_phys_cleanup(). This avoids the issue where an encoder unknowingly uses dither after reserving a pingpong block that was previously bound to an encoder that

Re: [PATCH] drm: drop i2c subdir from Makefile

2025-02-12 Thread Matthew Brost
On Thu, Feb 13, 2025 at 02:49:41AM +0200, Dmitry Baryshkov wrote: > The commit 325ba852d148 ("drm/i2c: move TDA998x driver under > drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but > didn't update upper level Makefile. Drop corresponding line to fix build > issues. > > Fixes: 3

Re: [PATCH v2 2/3] drm/msm/dsi: Set PHY usescase (and mode) before registering DSI host

2025-02-12 Thread Abhinav Kumar
Hi Marijn On 2/10/2025 2:17 PM, Abhinav Kumar wrote: On 2/10/2025 6:24 AM, Dmitry Baryshkov wrote: On Mon, Feb 10, 2025 at 01:54:29PM +0100, Marijn Suijten wrote: On 2025-02-10 01:11:59, Dmitry Baryshkov wrote: On Sun, Feb 09, 2025 at 10:42:53PM +0100, Marijn Suijten wrote: Ordering issues

Re: [PATCH v2 drm-dp 7/7] drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-02-12 Thread Dmitry Baryshkov
On Mon, Feb 10, 2025 at 10:49:59PM +0800, Yongbang Shi wrote: > From: Baihan Li > > To realize HPD feature, we have getting hpd status function, registering > irq function, interrupt handler function, and hpd event process function. > And also we use pci_alloc_irq_vectors() to get our msi irq, be

[PATCH] drm: drop i2c subdir from Makefile

2025-02-12 Thread Dmitry Baryshkov
The commit 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but didn't update upper level Makefile. Drop corresponding line to fix build issues. Fixes: 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge") Rep

linux-next: build failure after merge of the drm-misc tree

2025-02-12 Thread Stephen Rothwell
aused by commit 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge") I have used the drm-misc tree from next-20250212 for today. -- Cheers, Stephen Rothwell pgpNIYmmka5as.pgp Description: OpenPGP digital signature

Re: [PATCH v3 2/2] gpu: nova-core: add initial documentation

2025-02-12 Thread Benno Lossin
On 13.02.25 00:27, Alistair Popple wrote: > On Sun, Feb 09, 2025 at 06:30:25PM +0100, Danilo Krummrich wrote: > > [...] > >> +FromPrimitive API >> +- >> + >> +Sometimes the need arises to convert a number to a value of an enum or a >> +structure. >> + >> +A good example from nova-

Re: [PATCH v2 drm-dp 6/7] drm/hisilicon/hibmc: Add drm debugfs functions

2025-02-12 Thread Dmitry Baryshkov
On Mon, Feb 10, 2025 at 10:49:58PM +0800, Yongbang Shi wrote: > From: Baihan Li > > We use the previous two patches as our debug functions and > generate two files. "hibmc-dp" and "color-bar". > hibmc-dp: read only, print the dp link status and dpcd version Please define a generic DP attribute f

Re: [PATCH v2 drm-dp 5/7] drm/hisilicon/hibmc: Get link status and dpcd caps

2025-02-12 Thread Dmitry Baryshkov
On Mon, Feb 10, 2025 at 10:49:57PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Prepare the hibmc_dp_get_foo() functions for debugfs using in > next patch. We also add dpcd's if statement in link training process, > because we have the dpcd. Unrelated, split to a separate patch. > > Signed

Re: [PATCH v2 drm-dp 4/7] drm/hisilicon/hibmc: Add colorbar-cfg: set color bar cfg

2025-02-12 Thread Dmitry Baryshkov
On Mon, Feb 10, 2025 at 10:49:56PM +0800, Yongbang Shi wrote: > From: Baihan Li > > This is a DP IP controller's feature. It can be used as a debug method > which can check DP controller is working good. The colorbar displaying > doesn't rely on other IPs work in the chip, like: GPU or DDR (vram)

Re: [PATCH v2 drm-dp 3/7] drm/hisilicon/hibmc: Getting connector info and edid by using aux channel

2025-02-12 Thread Dmitry Baryshkov
On Mon, Feb 10, 2025 at 10:49:55PM +0800, Yongbang Shi wrote: > From: Baihan Li > > Registering drm_aux and using it to get connector edid with drm functions. > Refactoring some structs to fit aux's register framework. We need change Nit: EDID, AUX. > a lot about getting member of drm_aux, beca

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-02-12 Thread Dmitry Baryshkov
On Thu, Feb 13, 2025 at 01:56:12AM +0200, Ville Syrjälä wrote: > On Thu, Jan 23, 2025 at 01:05:47PM +0200, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 12:05:29PM +0200, Jani Nikula wrote: > > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > > Switch drm_dp_aux_dev.c to use new set of D

Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 03:03:47PM -0800, James A. MacInnes wrote: > Type-C DisplayPort inoperable due to incorrect porch settings. > - Re-used wide_bus_en as flag to prevent porch shifting Unfortunately I don't know enough details to comment on this change. Maybe Abhinav can check it. I can only

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Dmitry Baryshkov
On Thu, Feb 13, 2025 at 12:41:02AM +0100, Marijn Suijten wrote: > On 2025-02-12 15:03:46, James A. MacInnes wrote: > > SDM845 DPU hardware is rev 4.0.0 per hardware documents. > > Original patch to enable wide_bus operation did not take into account > > the SDM845 and it got carried over by acciden

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-02-12 Thread Ville Syrjälä
On Thu, Jan 23, 2025 at 01:05:47PM +0200, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 12:05:29PM +0200, Jani Nikula wrote: > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > > > This might be one of the few places

Re: [PATCH 4/4] arm64: dts: qcom: qcs8300: Add support for stream 1 clk for DP MST

2025-02-12 Thread Konrad Dybcio
On 12.02.2025 8:12 AM, Yongxing Mou wrote: > Add 2 streams MST support for qcs8300. Compatile with qcs8300 dp > controller driver and populate the stream clock for qcs8300 DP0 > controller in MST mode. > > Signed-off-by: Yongxing Mou > --- Please add all required resources for quad-MST operation

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Marijn Suijten
On 2025-02-12 15:03:46, James A. MacInnes wrote: > SDM845 DPU hardware is rev 4.0.0 per hardware documents. > Original patch to enable wide_bus operation did not take into account > the SDM845 and it got carried over by accident. > > - Incorrect setting caused inoperable DisplayPort. > - Corrected

Re: [PATCH v3 2/2] gpu: nova-core: add initial documentation

2025-02-12 Thread Alistair Popple
On Sun, Feb 09, 2025 at 06:30:25PM +0100, Danilo Krummrich wrote: [...] > +FromPrimitive API > +- > + > +Sometimes the need arises to convert a number to a value of an enum or a > +structure. > + > +A good example from nova-core would be the ``Chipset`` enum type, which > defines

[PATCH v2 0/2] drm/msm/dp: Fix Type-C Timing

2025-02-12 Thread James A. MacInnes
(-) --- base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 change-id: 20250212-sdm845_dp-6ed993977a53 Best regards, -- James A. MacInnes

[PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread James A. MacInnes
Type-C DisplayPort inoperable due to incorrect porch settings. - Re-used wide_bus_en as flag to prevent porch shifting Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: James A. MacInnes --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +-

[PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread James A. MacInnes
SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable wide_bus operation did not take into account the SDM845 and it got carried over by accident. - Incorrect setting caused inoperable DisplayPort. - Corrected by separating SDM845 into its own descriptor. Fixes: c7c412

Re: [PATCH v3 0/3] drm/i2c: tda998x: move under drivers/gpu/drm/bridge

2025-02-12 Thread Dmitry Baryshkov
On Mon, 13 Jan 2025 11:53:43 +0200, Dmitry Baryshkov wrote: > TDA998x is the HDMI bridge driver, incorporating drm_connector and > optional drm_encoder (created via the component bind API by the TICLDC > and HDLCD drivers). TDA9950 is an I2C-CEC translator, being present > on-die on the TDA9989 and

Re: [PATCH v2] drm/edid: Implement DisplayID Type IX & X timing blocks parsing

2025-02-12 Thread Egor Vorontsov
On Wed, 2025-02-12 at 11:35 +0200, Jani Nikula wrote: > > + /* TODO: support video-optimized refresh rate */ > > + if (timings->flags & (1 << 4)) > > + return NULL; > > Mmh. I'm not sure I'd go this far. The bit indicates *two* timings, one > for which the below *is* correct, and ano

Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

2025-02-12 Thread John Edwards
Hello, Thomas and Hans. On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede wrote: > > Hi, > > On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote: >> Hi >> >> Am 12.02.25 um 11:51 schrieb Hans de Goede: >>> Hi Thomas, >>> >>> On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote: Hi Am 24.01.25 um 2

Re: [PATCH RESEND] drm/virtio: Align host mapping request to maximum platform page size

2025-02-12 Thread Rob Clark
On Fri, Jan 24, 2025 at 2:52 PM Dmitry Osipenko wrote: > > On 1/25/25 01:01, Sasha Finkelstein via B4 Relay wrote: > > From: Sasha Finkelstein > > > > This allows running different page sizes between host and guest on > > platforms that support mixed page sizes. > > > > Signed-off-by: Sasha Finke

Re: [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup()

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 06:23:48PM +0300, Dan Carpenter wrote: > The drm_writeback_cleanup_job() function frees "pos" so call > list_del(&pos->list_entry) first to avoid a use after free. > > Fixes: 1914ba2b91ea ("drm: writeback: Create drmm variants for > drm_writeback_connector initialization")

Re: [PATCH v7 2/7] drm/i915/xe3: update and store the plane damage clips

2025-02-12 Thread Ville Syrjälä
On Wed, Feb 12, 2025 at 08:14:12PM +, Govindapillai, Vinod wrote: > On Wed, 2025-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > On Wed, Feb 12, 2025 at 03:14:15PM +0200, Vinod Govindapillai wrote: > > > Userspace can pass damage area clips per plane to track > > > changes in a plane and some di

Re: [PATCH 2/2] drm/mediatek/hdmi: Simplify with dev_err_probe

2025-02-12 Thread Krzysztof Kozlowski
On 13/01/2025 14:48, AngeloGioacchino Del Regno wrote: > Il 13/01/25 14:07, Krzysztof Kozlowski ha scritto: >> On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote: >>> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: Use dev_err_probe() to make error code and deferred probe handling s

[PATCH 5/6] drm/xe: Switch from xe to devm actions

2025-02-12 Thread Lucas De Marchi
Now that component drivers are compatible with devm, switch to using it instead of our own. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/display/xe_display.c | 4 ++-- drivers/gpu/drm/xe/xe_gsc_proxy.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

Re: [PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

2025-02-12 Thread Abhinav Kumar
On 2/11/2025 7:59 PM, Jessica Zhang wrote: Disable pingpong dither in dpu_encoder_helper_phys_cleanup(). This avoids the issue where an encoder unknowingly uses dither after reserving a pingpong block that was previously bound to an encoder that had enabled dither. Reported-by: Dmitry Barysh

Re: [PATCH v7 5/7] drm/i915/xe3: avoid calling fbc activate if fbc is active

2025-02-12 Thread Govindapillai, Vinod
On Wed, 2025-02-12 at 20:30 +0200, Ville Syrjälä wrote: > On Wed, Feb 12, 2025 at 03:14:18PM +0200, Vinod Govindapillai wrote: > > If FBC is already active, we don't need to call FBC activate > > routine again. This is more relevant in case of dirty rect > > support in FBC. Xe doesn't support legac

Re: [PATCH v7 2/7] drm/i915/xe3: update and store the plane damage clips

2025-02-12 Thread Govindapillai, Vinod
On Wed, 2025-02-12 at 20:35 +0200, Ville Syrjälä wrote: > On Wed, Feb 12, 2025 at 03:14:15PM +0200, Vinod Govindapillai wrote: > > Userspace can pass damage area clips per plane to track > > changes in a plane and some display components can utilze > > these damage clips for efficiently handling us

[PATCH 2/6] drivers: base: devres: Fix find_group() documentation

2025-02-12 Thread Lucas De Marchi
It returns the last open group, not the last group. Signed-off-by: Lucas De Marchi --- drivers/base/devres.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index b955a2f9520bf..d8a733ea5e1ac 100644 --- a/drivers/base/devres.c

[PATCH 0/6] Make devres cleanup and component compatible

2025-02-12 Thread Lucas De Marchi
While trying to convert the xe driver probe sequence to use more devm, I stumbled upon it not being compatible with component driver that is used by xe to work with mei and audio. First patch makes that possible with the 2nd and 3rd being some drive by improvements. The last 3 patches here are ju

[PATCH 3/6] drivers: base: component: Add debug message for unbind

2025-02-12 Thread Lucas De Marchi
Like when binding component, add a debug message to the unbinding case to make it easy to track the lifecycle. This also includes the component pointer since that is used to open a group in devres, making it easier to track the resources. Signed-off-by: Lucas De Marchi --- drivers/base/component

[PATCH 1/6] drivers: base: devres: Allow to release group on device release

2025-02-12 Thread Lucas De Marchi
When releasing a device, if the release action causes a group to be released, a warning is emitted because it can't find the group. This happens because devres_release_all() moves the entire list to a todo list and also move the group markers. Considering r* normal resource nodes and g1 a group res

[PATCH 4/6] drm/xe: Stop setting drvdata to NULL

2025-02-12 Thread Lucas De Marchi
PCI subsystem is not supposed to call the remove() function when probe fails and doesn't need a protection for that. The only places checking for NULL drvdata, is on 2 sysfs files and they shouldn't be needed since the files are removed and reads on open fds just return an error. Remove the settin

[PATCH 6/6] drm/xe: Drop remove callback support

2025-02-12 Thread Lucas De Marchi
Now that devres supports component driver cleanup during driver removal cleanup, the xe custom support for removal callbacks is not needed anymore. Drop it. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_device.c | 79 drivers/gpu/drm/xe/xe_device.h

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-12 Thread Boris Brezillon
+Florent, who's working on protected-mode support in Panthor. Hi Jens, On Tue, 17 Dec 2024 11:07:36 +0100 Jens Wiklander wrote: > Hi, > > This patch set allocates the restricted DMA-bufs via the TEE subsystem. We're currently working on protected-mode support for Panthor [1] and it looks like

Re: [PATCH v1 1/2] dt-bindings: mfd: Document TI LM3533 MFD

2025-02-12 Thread Conor Dooley
On Wed, Feb 12, 2025 at 09:58:41AM +0200, Svyatoslav Ryhel wrote: > Add bindings for the LM3533 - a complete power source for > backlight, keypad, and indicator LEDs in smartphone handsets. > The high-voltage inductive boost converter provides the > power for two series LED strings display backligh

Re: [PATCH v6 2/6] drm/xe/guc: Don't store capture nodes in xe_devcoredump_snapshot

2025-02-12 Thread Teres Alexis, Alan Previn
alan: I will respin this rev with the changes mentiond below - thanks Zhanjun for the time in reviewing this. :) On Mon, 2025-02-10 at 18:41 -0500, Dong, Zhanjun wrote: > See my comments inline below. > > Regards, > Zhanjun Dong > > On 2025-01-28 1:36 p.m., Alan Previn wrote: > > GuC-Err-Captur

Re: Include ASPEED ast-drm 1.15.1 video driver in kernel tree

2025-02-12 Thread Maarten Lankhorst
Hello Nicolas, Thank you for taking a look at this. It would be nice to have an updated driver. The best way to go forward is to chop the enhancements from the version that you tested into small patches that can be applied to the kernel tree. This way you get all the benefits from the update

Include ASPEED ast-drm 1.15.1 video driver in kernel tree

2025-02-12 Thread Nicolas Baranger
Dear maintener I did include ast-drm driver version 1.15.1 (in replacement of version 0.1.0) on the new mainline kernel too (6.14.0-rc2) and I issue a new dkms patch  Last DKMS patch had been sucessfully tested on mainline. And last ast.ko version 1.15.1 included in linux tree had also been

  1   2   3   >