[PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

2025-01-27 Thread oushixiong1025
From: Shixiong Ou Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(). Signed-off-by: Shixiong Ou --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu

Re: [RFC PATCH] drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference

2025-01-27 Thread Jayesh Choudhary
Hello Tomi, Alexander, On 24/01/25 13:38, Alexander Stein wrote: Hi, Am Donnerstag, 23. Januar 2025, 17:20:34 CET schrieb Tomi Valkeinen: Hi, On 16/01/2025 13:16, Jayesh Choudhary wrote: For the cases we have DRM_BRIDGE_ATTACH_NO_CONNECTOR flag set, Any idea if any other platform than K3 i

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-27 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, January 28, 2025 12:44 AM > To: Borah, Chaitanya Kumar > Cc: Murthy, Arun R ; dri- > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Subject: Re: [PATCH v3 2/5] drm/plane: Ex

Re: [PATCH 1/3] drm: atmel-hlcdc: add support for LVDS encoder type

2025-01-27 Thread Manikandan.M
Hi, A gentle reminder to review this series. On 21/11/24 2:53 pm, Manikandan Muralidharan wrote: > From: Dharma Balasubiramani > > Add support for encoder type "DRM_MODE_ENCODER_LVDS" with the following > bus formats: > - RGB888_1X7X4_SPWG > - RGB888_1X7X4_JEIDA > - RGB666_1X7

Re: [PATCH] drm: atmel-hlcdc: fix atmel_xlcdc_plane_setup_scaler()

2025-01-27 Thread Manikandan.M
Hi, A gentle reminder to merge this patch. On 21/10/24 1:26 pm, Nicolas Ferre wrote: > On 14/10/2024 at 11:49, Manikandan Muralidharan wrote: >> From: Cyrille Pitchen >> >> On SoCs, like the SAM9X75, which embed the XLCDC ip, the registers that >> configure the unified scaling engine were not fi

Re: [PATCH] drm: atmel-hlcdc: update the LCDC_ATTRE register in plane atomic_disable

2025-01-27 Thread Manikandan.M
Hi, A gentle reminder to merge this patch. Let me know if any further changes are needed. On 14/10/24 3:14 pm, Nicolas Ferre wrote: > On 14/10/2024 at 08:46, Manikandan Muralidharan wrote: >> update the LCDC_ATTRE register in drm plane atomic_disable to handle >> the configuration changes of eac

RE: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Srinivas, Vidya
> -Original Message- > From: Cavitt, Jonathan > Sent: 28 January 2025 02:45 > To: Brian Geffon ; intel-...@lists.freedesktop.org > Cc: Wilson, Chris P ; Saarinen, Jani > ; Mistat, Tomasz ; > Srinivas, Vidya ; ville.syrj...@linux.intel.com; > jani.nik...@linux.intel.com; linux-ker...@vger

Re: [PULL] drm-next 6.14 merge window fixes part 1

2025-01-27 Thread pr-tracker-bot
The pull request you sent on Mon, 27 Jan 2025 14:34:14 +0100: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2025-01-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7d6e5b525827c69b6d24716fa3e407441edfcf09 Thank you! -- Deet-doot-dot, I am a bot. ht

[PATCH] drm/amd/display: restore invalid MSA timing check for freesync

2025-01-27 Thread Melissa Wen
This restores the original behavior that gets min/max freq from EDID and only set DP/eDP connector as freesync capable if "sink device is capable of rendering incoming video stream without MSA timing parameters", i.e., `allow_invalid_MSA_timing_params` is true. The condition was mistakenly removed

Re: [PATCH v1 0/2] nouveau/svm: fix + cleanup for nouveau_atomic_range_fault()

2025-01-27 Thread Alistair Popple
On Fri, Jan 24, 2025 at 07:15:22PM +0100, David Hildenbrand wrote: > One fix and a minor cleanup. > > Only compile-tested due to lack of HW, so I'd be happy if someone with > access to HW could test. But not sure how easy this is to trigger. Likely > some concurrent MADV_DONTNEED on the PTE we jus

Re: [Question] Are "device exclusive non-swap entries" / "SVM atomics in Nouveau" still getting used in practice?

2025-01-27 Thread Alistair Popple
On Fri, Jan 24, 2025 at 06:54:02PM +0100, David Hildenbrand wrote: > > > > On integrated the gpu is tied into the coherency > > > > fabric, so there it's not needed. > > > > > > > > I think the more fundamental question with both this function here and > > > > with forced migration to device memor

[PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-27 Thread Paz Zcharya
Add support for pixel format ABGR, which is the default format on Android devices. This will allow us to use VKMS as the default display driver in Android Emulator (Cuttlefish) and increase VKMS adoption. Changes in v2: - Rebased on top of tip of tree because it has been 3 months. - No functio

Re: [PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs

2025-01-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2025-01-27 05:21:04) > DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide > two clocks. The respective clock ID is used by drivers and DTS, so it > should be documented as explicit ABI. > > Signed-off-by: Krzysztof Kozlowski > > --- Acked-by: S

Re: [PATCH 2/2] drm/msm/dsi/phy: Use the header with clock IDs

2025-01-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2025-01-27 05:21:05) > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > index fdb6c648e16f..7541ffde6521 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > @@ -6,6 +6,7 @@ >

Re: [RFC v2 2/8] drm/panthor: Add DEV_QUERY.PERF_INFO handling for Gx10

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > This change adds the IOCTL to query data about the performance counter > setup. Some of this data was available via previous DEV_QUERY calls, > for instance for GPU info, but exposing it via PERF_INFO > minimizes the overhead of creating a single sessio

Re: [RFC v2 5/8] drm/panthor: Introduce sampling sessions to handle userspace clients

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > To allow for combining the requests from multiple userspace clients, an > intermediary layer between the HW/FW interfaces and userspace is > created, containing the information for the counter requests and > tracking of insert and extract indices. Each

Re: [PATCH RFT 0/2] drm/bridge: Use per-client debugfs entry

2025-01-27 Thread Doug Anderson
Hi, On Mon, Jan 27, 2025 at 7:34 AM Dmitry Baryshkov wrote: > > On Mon, Jan 27, 2025 at 08:54:38AM +0100, Wolfram Sang wrote: > > Hi Dmitry, > > > > thanks for the review! > > > > > > The I2C core now offers a debugfs-directory per client. Use it and > > > > remove the custom handling in drm brid

RE: [PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Brian Geffon Sent: Monday, January 27, 2025 12:44 PM To: intel-...@lists.freedesktop.org Cc: Wilson, Chris P ; Saarinen, Jani ; Mistat, Tomasz ; Srinivas, Vidya ; ville.syrj...@linux.intel.com; jani.nik...@linux.intel.com; linux-ker...@vg

Re: [RFC v2 6/8] drm/panthor: Implement the counter sampler and sample handling

2025-01-27 Thread Adrián Larumbe
Resending partial review for patch 6/8 because of typing errors in the previous one. Sorry about the hassle this might've caused. On 11.12.2024 16:50, Lukas Zapolskas wrote: > From: Adrián Larumbe > > The sampler aggregates counter and set requests coming from userspace > and mediates interacti

[PATCH v3] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
When converting to folios the cleanup path of shmem_get_pages() was missed. When a DMA remap fails and the max segment size is greater than PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment size. The cleanup code isn't properly using the folio apis and as a result isn't handlin

Re: [PATCH v2 1/2] drm/bridge: synopsys: Add audio support for dw-hdmi-qp

2025-01-27 Thread Detlev Casanova
On Friday, 24 January 2025 00:01:38 EST Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 05:28:06PM -0500, Detlev Casanova wrote: > > From: Sugar Zhang > > > > Register the dw-hdmi-qp bridge driver as an HDMI audio codec. > > > > The register values computation functions (for n) are based on th

Re: [PATCH 0/6] drm: introduce atomic_needs_modeset() callbacks

2025-01-27 Thread Simona Vetter
On Fri, Jan 24, 2025 at 06:14:23PM +0200, Ville Syrjälä wrote: > On Fri, Jan 24, 2025 at 04:37:39PM +0100, Simona Vetter wrote: > > On Fri, Jan 24, 2025 at 03:12:41PM +0200, Ville Syrjälä wrote: > > > On Fri, Jan 24, 2025 at 01:59:15PM +0100, Simona Vetter wrote: > > > > On Fri, Jan 24, 2025 at 02:

Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Brian Geffon
On Mon, Jan 27, 2025 at 1:47 PM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 10:53:40AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will attempt t

Re: [RFC v2 8/8] drm/panthor: Expose the panthor perf ioctls

2025-01-27 Thread Adrián Larumbe
I don't know what the usual practice is when adding a new DRM driver ioctl(), but wouldn't it make more sense to add the PERF_CONTROL one to the panthor_drm_driver_ioctls array in this patch instead? Other than that: Reviewed-by: Adrián Larumbe On 11.12.2024 16:50, Lukas Zapolskas wrote: > Si

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2025-01-27 Thread Rodrigo Vivi
On Thu, Jan 23, 2025 at 10:16:07PM -0500, Rodrigo Vivi wrote: > On Wed, Jan 22, 2025 at 01:15:31PM +0200, Giedrius Statkevičius wrote: > > Hello, > > > > On Mon, 4 Nov 2024 at 23:28, Rodrigo Vivi wrote: > > > > > > On Mon, Nov 04, 2024 at 02:09:46PM +0200, Giedrius Statkevičius wrote: > > > > Hel

Re: [RFC v2 7/8] drm/panthor: Add suspend/resume handling for the performance counters

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > Signed-off-by: Lukas Zapolskas > --- > drivers/gpu/drm/panthor/panthor_device.c | 3 + > drivers/gpu/drm/panthor/panthor_perf.c | 86 > drivers/gpu/drm/panthor/panthor_perf.h | 2 + > 3 files changed, 91 insertions(+) >

[PATCH v12 2/2] drm/amdgpu: Enable async flip on overlay planes

2025-01-27 Thread André Almeida
amdgpu can handle async flips on overlay planes, so allow it for atomic async checks. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdg

[PATCH v12 1/2] drm/atomic: Let drivers decide which planes to async flip

2025-01-27 Thread André Almeida
Currently, DRM atomic uAPI allows only primary planes to be flipped asynchronously. However, each driver might be able to perform async flips in other different plane types. To enable drivers to set their own restrictions on which type of plane they can or cannot flip, use the existing atomic_async

[PATCH v12 0/2] drm/atomic: Ease async flip restrictions

2025-01-27 Thread André Almeida
Hi, The goal of this work is to find a nice way to allow amdgpu to perform async page flips in the overlay plane as well, not only on the primary one. Currently, when using the atomic uAPI, this is the only type of plane allowed to do async flips, and every driver accepts it. This patchset re-use

Re: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-27 Thread Ville Syrjälä
On Mon, Jan 27, 2025 at 07:25:31AM +, Borah, Chaitanya Kumar wrote: > Hello Ville, > > > -Original Message- > > From: Intel-xe On Behalf Of Murthy, > > Arun R > > Sent: Saturday, January 25, 2025 12:25 PM > > To: Ville Syrjälä > > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.

Re: [PATCH] drm/i915: Remove unused live_context_for_engine

2025-01-27 Thread Rodrigo Vivi
On Sat, Jan 25, 2025 at 12:38:46AM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The last use of live_context_for_engine() was removed in 2021 by > commit 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code") > > Remove it. > Reviewed-by: Rodrigo Vivi > Signe

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-27 Thread Leonardo Brás
On Mon, 2025-01-27 at 13:02 +0530, Vignesh Raman wrote: > Hi Leo, > > On 24/01/25 13:42, Laurent Pinchart wrote: > > On Fri, Jan 24, 2025 at 02:11:26AM -0300, Leonardo Brás wrote: > > > On Thu, 2025-01-23 at 19:23 +0530, Vignesh Raman wrote: > > > > This patch series introduces "kci-gitlab," a Git

Re: [PATCH] drm/amdgpu: restore wait-free fastpath for GEM_WAIT_IDLE

2025-01-27 Thread Christian König
Am 27.01.25 um 17:33 schrieb Lucas Stach: Hi Christian, Am Montag, dem 27.01.2025 um 17:14 +0100 schrieb Christian König: Am 27.01.25 um 17:02 schrieb Lucas Stach: This effectively reverts 0fea2ed61e7f ("drm/amdgpu: Remove call to reservation_object_test_signaled_rcu before wait"), as the prem

Re: [PATCH v2] drm/i915: Fix page cleanup on DMA remap failure

2025-01-27 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 10:53:40AM -0500, Brian Geffon wrote: > When converting to folios the cleanup path of shmem_get_pages() was > missed. When a DMA remap fails and the max segment size is greater than > PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment > size. The cleanup

Re: [RFC PATCH v2 0/3] expose mapping wrprotect, fix fb_defio use

2025-01-27 Thread Lorenzo Stoakes
Hi guys, It'd be good if somebody from the drm side could look at this as you are using fields that are deprecated and will be made unavailable (in a non-optional fashion), and relatively soon :) It'd be good to confirm this works on real hardware (none of mine supports this sadly, I tried 3 sepa

Re: [PATCH v1 1/2] dt-bindings: display: panel: Add compatible for CSOT PNA957QT1-1

2025-01-27 Thread Krzysztof Kozlowski
On 27/01/2025 18:33, Doug Anderson wrote: >> Point us to your DTS so we can validate that you really tested it. > > Krzysztof: not sure what you're asking for here. I assume Langyan is > posting support for this panel for hardware they are trying to bring > up, and the device tree may not be offic

Re: [PATCH v1 2/2] drm/panel: panel-himax-hx83102: support for csot-pna957qt1-1 MIPI-DSI panel

2025-01-27 Thread Doug Anderson
Hi, On Sun, Jan 26, 2025 at 5:46 PM Langyan Ye wrote: > > The csot-pna957qt1-1 is a 10.95" TFT panel. The MIPI controller on this > panel is the same as the other panels here, so add this panel to this > driver. From the datasheet, MIPI needs to keep the LP11 state before > the lcm_reset pin is p

Re: [PATCH v1 1/2] dt-bindings: display: panel: Add compatible for CSOT PNA957QT1-1

2025-01-27 Thread Doug Anderson
Langyan, On Mon, Jan 27, 2025 at 12:43 AM Krzysztof Kozlowski wrote: > > On Mon, Jan 27, 2025 at 09:46:04AM +0800, Langyan Ye wrote: > > Add a new compatible for the panel CSOT PNA957QT1-1. This panel > > uses HX83102 IC, so add the compatible to the hx83102 binding files. > > > > Signed-off-by:

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Daniele Ceraolo Spurio
On 1/23/2025 8:23 AM, Zhanjun Dong wrote: The purpose of synchronize_irq is to wait for any pending IRQ handlers for the interrupt to complete, if synchronize_irq called before interrupt disabled, an tiny timing window created, where no more pending IRQ, but interrupt not disabled yet. Meanwh

Re: [RFC v2 6/8] drm/panthor: Implement the counter sampler and sample handling

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > From: Adrián Larumbe > > The sampler aggregates counter and set requests coming from userspace > and mediates interactions with the FW interface, to ensure that user > sessions cannot override the global configuration. > > From the top-level interfac

Re: [PATCH] drm/amdgpu: restore wait-free fastpath for GEM_WAIT_IDLE

2025-01-27 Thread Lucas Stach
Hi Christian, Am Montag, dem 27.01.2025 um 17:14 +0100 schrieb Christian König: > Am 27.01.25 um 17:02 schrieb Lucas Stach: > > This effectively reverts 0fea2ed61e7f ("drm/amdgpu: Remove call to > > reservation_object_test_signaled_rcu before wait"), as the premise of > > that commit is wrong. dma

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-27 Thread Laurent Pinchart
Hi Nicolas, On Mon, Jan 27, 2025 at 09:43:23AM -0500, Nicolas Dufresne wrote: > Le lundi 27 janvier 2025 à 08:07 +0200, Laurent Pinchart a écrit : > > On Fri, Jan 24, 2025 at 06:12:24PM -0300, Leonardo Brás wrote: > > > On Fri, 2025-01-24 at 10:45 -0500, Nicolas Dufresne wrote: > > > > Le vendredi

Re: [PATCH] drm/amdgpu: restore wait-free fastpath for GEM_WAIT_IDLE

2025-01-27 Thread Christian König
Am 27.01.25 um 17:02 schrieb Lucas Stach: This effectively reverts 0fea2ed61e7f ("drm/amdgpu: Remove call to reservation_object_test_signaled_rcu before wait"), as the premise of that commit is wrong. dma_resv_wait_timeout() without a timeout will not turn into a wait-free dma_resv_test_signaled,

[PATCH] drm/amdgpu: restore wait-free fastpath for GEM_WAIT_IDLE

2025-01-27 Thread Lucas Stach
This effectively reverts 0fea2ed61e7f ("drm/amdgpu: Remove call to reservation_object_test_signaled_rcu before wait"), as the premise of that commit is wrong. dma_resv_wait_timeout() without a timeout will not turn into a wait-free dma_resv_test_signaled, but will wait a jiffy for unsignaled fences

Re: [RFC v2 3/8] drm/panthor: Add panthor_perf_init and panthor_perf_unplug

2025-01-27 Thread adrian . larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > Added the panthor_perf system initialization and unplug code to allow > for the handling of userspace sessions to be added in follow-up patches. > > Signed-off-by: Lukas Zapolskas > --- > drivers/gpu/drm/panthor/panthor_device.c | 7 +++ > drivers/g

Re: [PATCH] drm/i915/selftests: avoid using uninitialized context

2025-01-27 Thread Sebastian Brzezinka
Hi Krzysztof, On Mon Jan 27, 2025 at 11:46 AM UTC, Krzysztof Karas wrote: > There is an error path in igt_ppgtt_alloc(), which leads to ww > object being passed down to i915_gem_ww_ctx_fini() without > initialization. Correct that by zeroing the struct. > > Fixes: 480ae79537b2 ("drm/i915/selftests

Re: [RFC v2 5/8] drm/panthor: Introduce sampling sessions to handle userspace clients

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > To allow for combining the requests from multiple userspace clients, an > intermediary layer between the HW/FW interfaces and userspace is > created, containing the information for the counter requests and > tracking of insert and extract indices. Each

Re: [PATCH v2 2/5] misc: fastrpc: Introduce context params structure

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 10:12:36AM +0530, Ekansh Gupta wrote: > Add structure to invoke context parameterms. This structure is meant Nit: for invoke context parameters. > to carry invoke context specific data. This structure is passed to > internal invocation call to save the data in context. Exa

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Matthew Wilcox
On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > You could have static const within functions too. You get the rodata > protection and function local scope, best of both worlds? timer_active is on the stack, so it can't be static const. Does this really need to be cc'd to such a wid

Re: [PATCH v2 1/5] misc: fastrpc: Move fdlist to invoke context structure

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 10:12:35AM +0530, Ekansh Gupta wrote: > FD list is part of meta buffer which is calulated during put args. > Move fdlist to invoke context structure for better maintenance and > to avoid code duplicacy for calculation of critcal meta buffer > contents that are used by fastrp

Re: [PATCH RFT 0/2] drm/bridge: Use per-client debugfs entry

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 08:54:38AM +0100, Wolfram Sang wrote: > Hi Dmitry, > > thanks for the review! > > > > The I2C core now offers a debugfs-directory per client. Use it and > > > remove the custom handling in drm bridge drivers. I don't have the > > > hardware, so I hope I can find people wil

[PATCH v2] cgroup/dmem: Don't open-code css_for_each_descendant_pre

2025-01-27 Thread Friedrich Vock
The current implementation has a bug: If the current css doesn't contain any pool that is a descendant of the "pool" (i.e. when found_descendant == false), then "pool" will point to some unrelated pool. If the current css has a child, we'll overwrite parent_pool with this unrelated pool on the next

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Andi Shyti
Hi Zhanjun, On Thu, Jan 23, 2025 at 08:23:51AM -0800, Zhanjun Dong wrote: > The purpose of synchronize_irq is to wait for any pending IRQ handlers for the > interrupt to complete, if synchronize_irq called before interrupt disabled, an > tiny timing window created, where no more pending IRQ, but i

Re: [PATCH 2/2] drm/msm/dsi/phy: Use the header with clock IDs

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 02:21:05PM +0100, Krzysztof Kozlowski wrote: > Use the header with clock IDs to bind the interface between driver and > DTS. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 5 ++--- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_10n

Re: [PATCH 15/15] drm/ast: Only look up VBIOS mode on full modesets

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Only look up the VBIOS mode during atomic_check if the display mode changes. For page flips, the previous settings still apply. Avoids the runtime overhead of looking up the VBIOS mode on each page flip. Thanks, it's a nice optimization. Reviewed-b

Re: [PATCH 14/15] drm/ast: Remove struct ast_vbios_mode_info

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The type struct ast_vbios_mode_info used to store information about the color format and display mode. It has outlived its purpose. Inline its fields into struct ast_crtc_state and replace all instances. Thanks, it looks good to me. Reviewed-by: Jo

Re: [PATCH 13/15] drm/ast: astdp: Rework display-mode setting

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: ASTDP requires a mode index, depending on the resolution. Move the look-up code from ast_dp_set_mode() into a separate helper. Inline the rest of the function into its only caller. Rename the variable names and register constants to match the programm

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Jani Nikula
On Mon, 27 Jan 2025, Joel Granados wrote: > On Wed, Jan 22, 2025 at 01:41:35PM +0100, Ard Biesheuvel wrote: >> On Wed, 22 Jan 2025 at 13:25, Joel Granados wrote: >> > >> > On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: >> > > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Gran

Re: [PATCH RFT 2/2] drm/bridge: ti-sn65dsi86: Use per-client debugfs entry

2025-01-27 Thread Geert Uytterhoeven
Hi Wolfram, On Sat, 25 Jan 2025 at 13:53, Wolfram Sang wrote: > The I2C core now offers a debugfs-directory per client. Use it and > remove the custom handling. > > Signed-off-by: Wolfram Sang Thanks for your patch! I gave it a try on Gray Hawk Single. Old location: /sys/kernel/debug/1-0

Re: [PATCH 04/15] drm/ast: Rename support_widescreen to support_wsxga_p

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The flag support_widescreen in struct ast_device selects devices that support resolutions of at least 1680x1050 (WSXGA+). Name it accordingly. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- dri

Re: [PATCH 12/15] drm/ast: Inline ast_get_vbios_mode_info()

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The helper ast_get_vbios_mode_info() retrieves hardware-specific format and display-mode information. Inline the function into its only caller. While at it, also replace a use of struct drm_format_info.cpp with the correct DRM 4CC codes. Thanks, it

Re: [PATCH 11/15] drm/ast: Validate DRM display modes against VBIOS modes

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Test DRM display modes against the list of modes supported by the VBIOS. The helper will respect the supported-modes flags in struct ast_device. Hence only DRM display modes supported by the VBIOS will be reported; without the current duplication of t

Re: [PATCH 10/15] drm/ast: Add helpers for VBIOS mode lookup

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Mode lines are independent from hardware Gen or TX chip, so hide all VBIOS mode tables in ast_vbios.c. Move the look-up code for VBIOS modes from ast_vbios_get_mode_info() to ast_vbios_find_mode(). The new look-up function respects the supported-mode

Re: [PATCH 09/15] drm/ast: Add empty initializer for VBIOS modes

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: VBIOS mode tables are terminated by an entry with a refresh rate of 0xff. The code is hard to read and fragile to use. Therefore create an empty entry with AST_VBIOS_MODE_INVALID to terminate each mode list. Stop at the invalid entry when searching f

Re: [PATCH 08/15] drm/ast: Find VBIOS mode from regular display size

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The ast driver looks up supplied display modes from an internal list of display modes supported by the VBIOS. Do not use the crtc_-prefixed display values from struct drm_display_mode for looking up the VBIOS mode. The fields contain raw values that

Re: [PATCH v1] drm/i915/guc: Always disable interrupt ahead of synchronize_irq

2025-01-27 Thread Sebastian Brzezinka
Hi Zhanjun There is a missing newline at drm-tip/drivers/gpu/drm/i915/gt/intel_rps.c:249 Overall, LGTM. On Thu Jan 23, 2025 at 4:23 PM UTC, Zhanjun Dong wrote: > The purpose of synchronize_irq is to wait for any pending IRQ handlers for the > interrupt to complete, if synchronize_irq called befor

Re: [PATCH 07/15] drm/ast: Always validate H/V sync flags

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The ast driver matches DRM display modes against an internal list of modes supported by the VBIOS. Matching H/V sync flags between modes is preferred, but optional. If sync flags are not matching, the driver would program the VBIOS settings to hardwar

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-27 Thread Nicolas Dufresne
Le lundi 27 janvier 2025 à 08:07 +0200, Laurent Pinchart a écrit : > On Fri, Jan 24, 2025 at 06:12:24PM -0300, Leonardo Brás wrote: > > On Fri, 2025-01-24 at 10:45 -0500, Nicolas Dufresne wrote: > > > Le vendredi 24 janvier 2025 à 15:00 +0200, Laurent Pinchart a écrit : > > > > On Fri, Jan 24, 2025

Re: [PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs

2025-01-27 Thread Krzysztof Kozlowski
On 27/01/2025 14:56, Dmitry Baryshkov wrote: > On Mon, Jan 27, 2025 at 02:21:04PM +0100, Krzysztof Kozlowski wrote: >> DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide >> two clocks. The respective clock ID is used by drivers and DTS, so it >> should be documented as explici

Re: [PATCH 06/15] drm/ast: Add support_wuxga flag to struct ast_device

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Detect support for 1920x1200 (WUXGA) in ast_detect_widescreen(). The flag is cleared by default. The test logic has been taken from existing code in ast_crtc_helper_mode_valid(). The code in that function is being replaced by the new flag. I think a

Re: [PATCH] drm/hisilicon/hibmc: select CONFIG_DRM_DISPLAY_DP_HELPER

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 08:10:02AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without the DP helper code, the newly added displayport support > causes a link failure: > > x86_64-linux-ld: drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.o: in function > `hibmc_dp_aux_init': > dp_aux.c:(.tex

Re: [PATCH 05/15] drm/ast: Add support_fullhd flag to struct ast_device

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Detect support for 1920x1080 (FullHD) in ast_detect_widescreen(). The flag is cleared by default. The test logic has been taken from existing code in ast_crtc_helper_mode_valid(). The code in that function is being replaced by the new flag. For Gen3,

Re: [PATCH 03/15] drm/ast: Reorganize widescreen test around hardware Gens

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Testing for support of widescreen modes mixes up various hardware Gens. First branch by hardware Gen, then do specific tests for each Gen. By default, widesscreen support is disabled. Later patches will add more specific tests for each Gen. I think

Re: [PATCH 02/15] drm/ast: Align naming in widescreen detection code to manual

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: Rename variables and register constants to align with the programming manual. Add new constants where necessary. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c |

Re: [RFC v2 4/8] drm/panthor: Add panthor perf ioctls

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > This patch implements the PANTHOR_PERF_CONTROL ioctl series, and > a PANTHOR_GET_UOBJ wrapper to deal with the backwards and forwards > compatibility of the uAPI. > > Stub function definitions are added to ensure the patch builds on its own, > and will

Re: [PATCH 01/15] drm/ast: Remove 1152x864 from list of widescreen resolutions

2025-01-27 Thread Jocelyn Falempe
On 24/01/2025 08:57, Thomas Zimmermann wrote: The resolution 1152x864 has a ratio of 4:3 and is already handled as such. Remove it from the list of widescreen resolutions. Thanks, yes it's redundant. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/a

Re: [PATCH] drm/ast: astdp: Fix timeout for enabling video signal

2025-01-27 Thread Jocelyn Falempe
On 27/01/2025 14:44, Thomas Zimmermann wrote: The ASTDP transmitter sometimes takes up to second for enabling the video signal, while the timeout is only 200 msec. This results in a kernel error message. Increase the timeout to 1 second. An example of the error message is shown below. [ 697.084

Re: [PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs

2025-01-27 Thread Dmitry Baryshkov
On Mon, Jan 27, 2025 at 02:21:04PM +0100, Krzysztof Kozlowski wrote: > DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide > two clocks. The respective clock ID is used by drivers and DTS, so it > should be documented as explicit ABI. > > Signed-off-by: Krzysztof Kozlowski >

Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-27 Thread Joel Granados
On Wed, Jan 22, 2025 at 01:41:35PM +0100, Ard Biesheuvel wrote: > On Wed, 22 Jan 2025 at 13:25, Joel Granados wrote: > > > > On Tue, Jan 21, 2025 at 02:40:16PM +0100, Alexander Gordeev wrote: > > > On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > > > > > > Hi Joel, > > > > > > > Ad

[PATCH] drm/ast: astdp: Fix timeout for enabling video signal

2025-01-27 Thread Thomas Zimmermann
The ASTDP transmitter sometimes takes up to second for enabling the video signal, while the timeout is only 200 msec. This results in a kernel error message. Increase the timeout to 1 second. An example of the error message is shown below. [ 697.084433] [ cut here ] [ 697

Re: [PATCH] MAINTAINERS: Remove Noralf Trønnes as driver maintainer

2025-01-27 Thread Noralf Trønnes
On 24.01.2025 10:31, Thomas Zimmermann wrote: > > > > Am 23.01.25 um 17:34 schrieb Noralf Trønnes via B4 Relay: >> From: Noralf Trønnes >> >> Remove myself as maintainer for gud, mi0283qt, panel-mipi-dbi and >> repaper. >> My fatigue illness has finally closed the door on doing development o

[PULL] drm-next 6.14 merge window fixes part 1

2025-01-27 Thread Simona Vetter
Hi Linus, The cgroups fix is acked by Tejun. This also includes a recreated version of your drm-next merge commit because we needed v6.13 for a regression fix, and I didn't want to pull in a random point from the merge window. I checked to make sure it matches exactly what you've done. Otherwise

Re: [PATCH] MAINTAINERS: Remove Noralf Trønnes as driver maintainer

2025-01-27 Thread Noralf Trønnes
On 24.01.2025 10:40, Simona Vetter wrote: > Dear Noralf > > On Thu, Jan 23, 2025 at 05:34:25PM +0100, Noralf Trønnes via B4 Relay wrote: >> From: Noralf Trønnes >> >> Remove myself as maintainer for gud, mi0283qt, panel-mipi-dbi and repaper. >> My fatigue illness has finally closed the door on

[PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs

2025-01-27 Thread Krzysztof Kozlowski
DSI phys, from earliest (28 nm) up to newest (3 nm) generation, provide two clocks. The respective clock ID is used by drivers and DTS, so it should be documented as explicit ABI. Signed-off-by: Krzysztof Kozlowski --- Patch for Display tree, although with Ack from clock. --- .../devicetree/b

[PATCH 2/2] drm/msm/dsi/phy: Use the header with clock IDs

2025-01-27 Thread Krzysztof Kozlowski
Use the header with clock IDs to bind the interface between driver and DTS. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 5 ++--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 1 + drivers/gpu/

Re: [PATCH v2 3/3] drm/sched: Update timedout_job()'s documentation

2025-01-27 Thread Danilo Krummrich
On Mon, Jan 27, 2025 at 01:32:40PM +0100, Philipp Stanner wrote: > On Fri, 2025-01-24 at 13:27 +0100, Danilo Krummrich wrote: > > On Tue, Jan 21, 2025 at 04:15:46PM +0100, Philipp Stanner wrote: > > > drm_sched_backend_ops.timedout_job()'s documentation is outdated. > > > It > > > mentions the depr

Re: [PATCH v2] drm/ast: Fix ast_dp connection status

2025-01-27 Thread Jocelyn Falempe
On 27/01/2025 12:55, Thomas Zimmermann wrote: Hi Am 24.01.25 um 15:11 schrieb Jocelyn Falempe: ast_dp_is_connected() used to also check for link training success to report the DP connector as connected. Without this check, the physical_status is always connected. So if no monitor is present, i

Re: [RFC v2 3/8] drm/panthor: Add panthor_perf_init and panthor_perf_unplug

2025-01-27 Thread Adrián Larumbe
On 11.12.2024 16:50, Lukas Zapolskas wrote: > Added the panthor_perf system initialization and unplug code to allow > for the handling of userspace sessions to be added in follow-up patches. > > Signed-off-by: Lukas Zapolskas > --- > drivers/gpu/drm/panthor/panthor_device.c | 7 +++ > drivers/g

Re: [PATCH v2 3/3] drm/sched: Update timedout_job()'s documentation

2025-01-27 Thread Philipp Stanner
On Fri, 2025-01-24 at 13:27 +0100, Danilo Krummrich wrote: > On Tue, Jan 21, 2025 at 04:15:46PM +0100, Philipp Stanner wrote: > > drm_sched_backend_ops.timedout_job()'s documentation is outdated. > > It > > mentions the deprecated function drm_sched_resubmit_job(). > > Furthermore, > > it does not

Re: [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2025-01-27 Thread Pekka Paalanen
On Thu, 23 Jan 2025 15:16:29 -0500 Harry Wentland wrote: > On 2025-01-17 04:06, Pekka Paalanen wrote: > > On Thu, 16 Jan 2025 10:56:22 +0200 > > Pekka Paalanen wrote: > > > >> On Thu, 19 Dec 2024 21:33:37 -0700 > >> Alex Hung wrote: > >> > >>> From: Harry Wentland > >>> > >>> The BT.709 a

Re: [PATCH v2] drm/ast: Fix ast_dp connection status

2025-01-27 Thread Thomas Zimmermann
Hi Am 24.01.25 um 15:11 schrieb Jocelyn Falempe: ast_dp_is_connected() used to also check for link training success to report the DP connector as connected. Without this check, the physical_status is always connected. So if no monitor is present, it will fail to read the EDID and set the defaul

[PATCH] drm/i915/selftests: avoid using uninitialized context

2025-01-27 Thread Krzysztof Karas
There is an error path in igt_ppgtt_alloc(), which leads to ww object being passed down to i915_gem_ww_ctx_fini() without initialization. Correct that by zeroing the struct. Fixes: 480ae79537b2 ("drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal") Signed-off-by: Krzysztof Karas ---

Re: [PATCH v5 20/34] drm/mediatek: mtk_hdmi: Use dev_err_probe() in mtk_hdmi_dt_parse_pdata()

2025-01-27 Thread AngeloGioacchino Del Regno
Il 24/01/25 09:24, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Mon, 2025-01-13 at 15:52 +0100, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Change error prints to use dev_err_probe() instead of

Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

2025-01-27 Thread Louis Chauvet
On 26/01/25 - 18:06, Maxime Ripard wrote: > On Tue, Jan 21, 2025 at 11:48:06AM +0100, Louis Chauvet wrote: > > +static struct yuv_u8_to_argb_u16_case yuv_u8_to_argb_u16_cases[] = { > > + /* > > +* colour.RGB_to_YCbCr(, > > +* K=colour.WEIGHTS_YCBCR["ITU-R BT.601"], > >

Re: [PATCH v6 7/7] drm/msm/hdmi: use DRM HDMI Audio framework

2025-01-27 Thread Maxime Ripard
On Fri, Jan 24, 2025 at 11:47:47PM +0200, Dmitry Baryshkov wrote: > In order to simplify the driver even further and to remove the > boilerplate code, rewrite the audio interface to use the DRM HDMI Audio > framework. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Maxime sign

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-27 Thread Pekka Paalanen
On Wed, 22 Jan 2025 07:22:25 +0200 Raag Jadav wrote: > On Tue, Jan 21, 2025 at 02:14:56AM +0100, Xaver Hugl wrote: > > > +It is the responsibility of the consumer to make sure that the device or > > > +its resources are not in use by any process before attempting recovery. > > I'm not convinced

Re: [PATCH 3/5] drm/sched: stop passing non struct drm_device to drm_err() and friends

2025-01-27 Thread Philipp Stanner
nit: In drm/sched, we start with an upper case -> "drm/sched: Stop […]" On Fri, 2025-01-24 at 13:46 +0200, Jani Nikula wrote: > On Thu, 23 Jan 2025, Simona Vetter wrote: > > On Thu, Jan 23, 2025 at 05:09:10PM +0200, Jani Nikula wrote: > > > The expectation is that the struct drm_device based logg

Re: [RFC v2 2/8] drm/panthor: Add DEV_QUERY.PERF_INFO handling for Gx10

2025-01-27 Thread Adrián Larumbe
Reviewed-by: Adrián Larumbe On 11.12.2024 16:50, Lukas Zapolskas wrote: > This change adds the IOCTL to query data about the performance counter > setup. Some of this data was available via previous DEV_QUERY calls, > for instance for GPU info, but exposing it via PERF_INFO > minimizes the overhe

Re: [RFC v2 1/8] drm/panthor: Add performance counter uAPI

2025-01-27 Thread Adrián Larumbe
Hi Lukas, On 11.12.2024 16:50, Lukas Zapolskas wrote: > This patch extends the DEV_QUERY ioctl to return information about the > performance counter setup for userspace, and introduces the new > ioctl DRM_PANTHOR_PERF_CONTROL in order to allow for the sampling of > performance counters. > > The n

Re: [BUG,BISECTED] WARNING dcn20_find_secondary_pipe

2025-01-27 Thread Imre Deak
On Sun, Jan 26, 2025 at 04:46:49PM +, Chris Bainbridge wrote: > Hardware is HP Pavilion Aero 13 laptop with Dell WD19 dock and three > external monitors. I get a warning with recent kernel builds when > enabling the external monitors with xrandr after initial boot: > > 16:57:49 kernel: WARNING

  1   2   >