Re: [PATCH v4 06/16] drm/msm/dpu: fix mixer number counter on allocation

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:55PM +0800, Jun Nie wrote: > Add the case to reserve multiple pairs mixers for high resolution. > Current code only supports one pair of mixer usage case. To support > quad-pipe usage case, two pairs of mixers are needed. > > Reset the current lm_count to an even numb

Re: [PATCH v4 04/16] drm/msm/dpu: polish log for resource allocation

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:53PM +0800, Jun Nie wrote: > Add resource type info on allocation failure to ease debug. Because > more resources are required in new usage cases, such as quad-pipe case. > It is more likely that resource allocation may fail than existing usage > cases. - Problem desc

Re: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-15 Thread Dmitry Baryshkov
On Thu, 16 Jan 2025 at 09:08, Murthy, Arun R wrote: > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > Display Histogram is an array of bins and can be generated in many > > > ways referred to as modes. > > > Ex: HSV max(RGB), Wighted RGB etc. > > > > > > Understanding the

Re: [PATCH v4 03/16] drm/msm/dpu: configure DSC per number in use

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:52PM +0800, Jun Nie wrote: > Currently if DSC support is requested, the driver only supports using > 2 DSC blocks. We need 4 DSC in quad-pipe topology in future. So Only > configure DSC engines in use, instead of the maximum number of DSC > engines. > > Signed-off-by:

[PATCH v4 04/16] drm/msm/dpu: polish log for resource allocation

2025-01-15 Thread Jun Nie
Add resource type info on allocation failure to ease debug. Because more resources are required in new usage cases, such as quad-pipe case. It is more likely that resource allocation may fail than existing usage cases. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 ++

Re: [PATCH v4 02/16] drm/msm/dpu: Do not fix number of DSC

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:51PM +0800, Jun Nie wrote: > Currently, if DSC is enabled, only 2 DSC engines are supported so far. > More usage cases will be added, such as 4 DSC in 4:4:2 topology. So > get the real number of DSCs to decide whether DSC merging is needed. > > Signed-off-by: Jun Nie

Re: [PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 03:25:50PM +0800, Jun Nie wrote: > Move requreiment check to routine of every pipe check. As sblk > and pipe_hw_caps of r_pipe are not checked in current implementation. Jun, please. I know I might be sounding like a PITA. Please start by providing the problem description.

[PATCH v4 15/16] drm/msm/dpu: Disable SSPP multi-rect mode for every pair

2025-01-15 Thread Jun Nie
Currently, 2 pipes are supported at most. It is enough to check id to know which pipe is in multi-rect mode and disable it. Multiple pairs are used and need to check multirect_index to decide what pipes are in multi-rect mode to disable them. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/d

[PATCH v4 03/16] drm/msm/dpu: configure DSC per number in use

2025-01-15 Thread Jun Nie
Currently if DSC support is requested, the driver only supports using 2 DSC blocks. We need 4 DSC in quad-pipe topology in future. So Only configure DSC engines in use, instead of the maximum number of DSC engines. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++---

[PATCH v4 12/16] drm/msm/dpu: blend pipes per mixer pairs config

2025-01-15 Thread Jun Nie
Currently, only 2 pipes are used at most for a plane. A stage structure describes the configuration for a mixer pair. So only one stage is needed for current usage cases. The quad-pipe case will be added in future and 2 stages are used in the case. So extend the stage to an array with array size ST

[PATCH v4 06/16] drm/msm/dpu: fix mixer number counter on allocation

2025-01-15 Thread Jun Nie
Add the case to reserve multiple pairs mixers for high resolution. Current code only supports one pair of mixer usage case. To support quad-pipe usage case, two pairs of mixers are needed. Reset the current lm_count to an even number instead of completely clearing it. This prevents all pairs from

Re: [PATCH v4 06/25] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 08:13:37PM -0800, Jessica Zhang wrote: > > > On 1/15/2025 1:56 AM, Dmitry Baryshkov wrote: > > On Tue, Jan 14, 2025 at 09:28:50PM -0800, Jessica Zhang wrote: > > > > > > > > > On 12/24/2024 12:00 PM, Dmitry Baryshkov wrote: > > > > On Tue, Dec 24, 2024 at 06:45:07AM +020

[PATCH v4 16/16] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2025-01-15 Thread Jun Nie
Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are enabled. 4 pipes are preferred for dual DSI case for it is power optimal for DSC. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 ++--

[PATCH v4 14/16] drm/msm/dpu: support SSPP assignment for quad-pipe case

2025-01-15 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method. The first 2 pipes can share a set of mixer config and enable multi-rect mode if condition is met. It is also the case for the later 2 pipes. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 63 +

[PATCH v4 11/16] drm/msm/dpu: split PIPES_PER_STAGE definition per plane and mixer

2025-01-15 Thread Jun Nie
Split the PIPES_PER_STAGE definition per plane and mixer pair. Currently, 2 pipes are supported for a plane at most. A stage struct contains configuration for a mixer pair, so pipes per stage are identical to pipes per plane in this case. More pipes will be required for the quad-pipe case in the fu

[PATCH v4 10/16] drm/msm/dpu: handle pipes as array

2025-01-15 Thread Jun Nie
Store pipes in array with removing dedicated r_pipe. There are 2 pipes in a drm plane at most currently, while 4 pipes are required for quad-pipe case. Generalize the handling to pipe pair and ease handling to another pipe pair later. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_

Re: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-15 Thread Dmitry Baryshkov
On Thu, 16 Jan 2025 at 09:08, Murthy, Arun R wrote: > > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to generate > > > the enhanced output image. LUT takes an input value, outputs a new > > > value based on the dat

[PATCH v4 13/16] drm/msm/dpu: support plane splitting in quad-pipe case

2025-01-15 Thread Jun Nie
The content of every half of screen is sent out via one interface in dual-DSI case. The content for every interface is blended by a LM pair in quad-pipe case, thus a LM pair should not blend any content that cross the half of screen in this case. Clip plane into pipes per left and right half screen

[PATCH v4 00/16] drm/msm/dpu: Support quad pipe with dual-DSI

2025-01-15 Thread Jun Nie
2 or more SSPPs and dual-DSI interface are need for super wide DSI panel. And 4 DSC are preferred for power optimal in this case. This patch set extend number of pipes to 4 and revise related mixer blending logic to support quad pipe. All these changes depends on the virtual plane feature to split

[PATCH v4 09/16] drm/msm/dpu: Add pipe as trace argument

2025-01-15 Thread Jun Nie
Add pipe as trace argument in trace_dpu_crtc_setup_mixer() to ease converting pipe into pipe array later. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) dif

[PATCH v4 08/16] drm/msm/dpu: bind correct pingpong for quad pipe

2025-01-15 Thread Jun Nie
There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +-- 1 file changed, 13 insertions(+), 2 d

[PATCH v4 07/16] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-01-15 Thread Jun Nie
Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id so that mixer number can be known in dpu_plane_virtual_assign_resources() via CRTC id for sspp alloation. Because the mixer allocation is done in drm_atomic_helper_check_modeset() as part of CRTC o

[PATCH v4 02/16] drm/msm/dpu: Do not fix number of DSC

2025-01-15 Thread Jun Nie
Currently, if DSC is enabled, only 2 DSC engines are supported so far. More usage cases will be added, such as 4 DSC in 4:4:2 topology. So get the real number of DSCs to decide whether DSC merging is needed. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 -- 1 fil

[PATCH v4 01/16] drm/msm/dpu: check every pipe per capability

2025-01-15 Thread Jun Nie
Move requreiment check to routine of every pipe check. As sblk and pipe_hw_caps of r_pipe are not checked in current implementation. Fixes: ("dbbf57dfd04e6 drm/msm/dpu: split dpu_plane_atomic_check()") Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 71

Re: [PATCH v7 07/14] drm/xe: Add histogram support to Xe builds

2025-01-15 Thread Dmitry Baryshkov
On Thu, 16 Jan 2025 at 09:09, Murthy, Arun R wrote: > > > On Fri, Jan 10, 2025 at 01:15:35AM +0530, Arun R Murthy wrote: > > > Histogram added as part of i915/display driver. Adding the same for xe > > > as well. > > > > > > Signed-off-by: Arun R Murthy > > > Reviewed-by: Suraj Kandpal > > > > I

RE: [PATCH v7 07/14] drm/xe: Add histogram support to Xe builds

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:35AM +0530, Arun R Murthy wrote: > > Histogram added as part of i915/display driver. Adding the same for xe > > as well. > > > > Signed-off-by: Arun R Murthy > > Reviewed-by: Suraj Kandpal > > Is building of the Xe driver broken between the previous commit and thi

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > ImageEnhancemenT(IET) hardware interpolates the LUT value to generate > > the enhanced output image. LUT takes an input value, outputs a new > > value based on the data within the LUT. 1D LUT can remap individual > > input values

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > Display Histogram is an array of bins and can be generated in many > > ways referred to as modes. > > Ex: HSV max(RGB), Wighted RGB etc. > > > > Understanding the histogram data format(Ex: HSV max(RGB)) Histogram is > > just the p

RE: [PATCH v4 01/11] mtd: core: always create master device

2025-01-15 Thread Usyskin, Alexander
> > Create master device without partition when > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > > > This streamlines device tree and allows to anchor > > runtime power management on master device in all cases. > > Please explain in more detail why this is needed. > If this change makes the ov

Re: linux-next: build warning after merge of the amdgpu tree

2025-01-15 Thread Stephen Rothwell
Hi all, On Mon, 13 Jan 2025 15:54:23 +1100 Stephen Rothwell wrote: > > After merging the amdgpu tree, today's linux-next build (htmldocs) > produced this warning: > > drivers/gpu/drm/amd/include/amd_shared.h:352: warning: Enum value > 'DC_DISABLE_HDMI_CEC' not described in enum 'DC_DEBUG_MASK'

RE: [PATCH v2 1/2] mm/memfd: reserve hugetlb folios before allocation

2025-01-15 Thread Kasireddy, Vivek
Hi Andrew, > Subject: Re: [PATCH v2 1/2] mm/memfd: reserve hugetlb folios before > allocation > > > > There are cases when we try to pin a folio but discover that it has > > not been faulted-in. So, we try to allocate it in memfd_alloc_folio() > > but there is a chance that we might encounter a

Re: [PATCH v4 06/25] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2025-01-15 Thread Jessica Zhang
On 1/15/2025 1:56 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025 at 09:28:50PM -0800, Jessica Zhang wrote: On 12/24/2024 12:00 PM, Dmitry Baryshkov wrote: On Tue, Dec 24, 2024 at 06:45:07AM +0200, Dmitry Baryshkov wrote: On Mon, Dec 16, 2024 at 04:43:17PM -0800, Jessica Zhang wrote: Fr

Re: [PATCH 05/35] drm/msm/dpu: inline _setup_ctl_ops()

2025-01-15 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: Inline the _setup_ctl_ops() function, it makes it easier to handle different conditions involving CTL configuration. Nothing really wrong with the change. Like the previous patch, would like to check the other changes to see where we are going

Re: [PATCH v15 4/9] drm/ttm/pool, drm/ttm/tt: Provide a helper to shrink pages

2025-01-15 Thread Matthew Brost
On Tue, Dec 17, 2024 at 03:58:47PM +0100, Thomas Hellström wrote: > Provide a helper to shrink ttm_tt page-vectors on a per-page > basis. A ttm_backup backend could then in theory get away with > allocating a single temporary page for each struct ttm_tt. > > This is accomplished by splitting large

Re: [PATCH 08/12] drm/mediatek: add EXDMA support for MT8196

2025-01-15 Thread 胡俊光

Re: [PATCH v7 07/14] drm/xe: Add histogram support to Xe builds

2025-01-15 Thread Dmitry Baryshkov
On Fri, Jan 10, 2025 at 01:15:35AM +0530, Arun R Murthy wrote: > Histogram added as part of i915/display driver. Adding the same for xe > as well. > > Signed-off-by: Arun R Murthy > Reviewed-by: Suraj Kandpal Is building of the Xe driver broken between the previous commit and this one? In such

Re: [PATCH 01/29] drm/atomic-helper: Fix commit_tail state variable name

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:08PM +0100, Maxime Ripard wrote: > Even though the commit_tail () drm_atomic_state parameter is called > old_state, it's actually the state being committed which is confusing. > > It's even more confusing since the atomic_commit_tail hook being called > by commit_tail

Re: [PATCH v4 8/9] drm/msm/dpu: rework core_perf debugfs overrides

2025-01-15 Thread Abhinav Kumar
On 1/15/2025 5:15 PM, Dmitry Baryshkov wrote: On Wed, Jan 15, 2025 at 04:47:34PM -0800, Abhinav Kumar wrote: On 1/15/2025 4:35 PM, Dmitry Baryshkov wrote: On Wed, Jan 15, 2025 at 11:51:20AM -0800, Abhinav Kumar wrote: On 1/15/2025 12:41 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025

Re: [PATCH 04/35] drm/msm/dpu: drop INTF_SC7280_MASK

2025-01-15 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: The INTF_SC7280_MASK is equal to the INTF_SC7180_MASK. Stop defining a separate symbol and use the INTF_SC7180_MASK instead. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_10_0_sm8650.h| 8 drivers/gpu

Re: [PATCH v4 8/9] drm/msm/dpu: rework core_perf debugfs overrides

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 04:47:34PM -0800, Abhinav Kumar wrote: > > > On 1/15/2025 4:35 PM, Dmitry Baryshkov wrote: > > On Wed, Jan 15, 2025 at 11:51:20AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/15/2025 12:41 AM, Dmitry Baryshkov wrote: > > > > On Tue, Jan 14, 2025 at 02:02:54PM -0800

Re: [PATCH v4 7/9] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 04:40:39PM -0800, Abhinav Kumar wrote: > > > On 1/15/2025 4:32 PM, Dmitry Baryshkov wrote: > > On Wed, Jan 15, 2025 at 11:41:27AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/15/2025 12:27 AM, Dmitry Baryshkov wrote: > > > > On Tue, Jan 14, 2025 at 01:18:26PM -0800

Re: [PATCH 29/29] drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:36PM +0100, Maxime Ripard wrote: > The TI sn65dsi86 driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortuna

Re: [PATCH 26/29] drm/bridge: cdns-csi: Switch to atomic helpers

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:33PM +0100, Maxime Ripard wrote: > The Cadence DSI driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortunat

Re: [PATCH 27/29] drm/bridge: tc358775: Switch to atomic commit

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:34PM +0100, Maxime Ripard wrote: > The tc358775 driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortunately

Re:Re: Re: Re:[PATCH] drm/panel-edp: Add BOE NV140FHM-N4Z panel entry

2025-01-15 Thread Andy Yan
Hi Doug, 在 2025-01-16 01:51:15,"Doug Anderson" 写道: >Hi, > >On Wed, Jan 15, 2025 at 2:15 AM Andy Yan wrote: >> >> >> Hi Doug, >> >> 在 2025-01-15 00:44:41,"Doug Anderson" 写道: >> >Hi, >> > >> >On Tue, Jan 14, 2025 at 1:05 AM Andy Yan wrote: >> >> >> >> >> >> Hi All, >> >> >> >> At 2025-01-13 18:

Re: [PATCH 25/29] drm/bridge: Provide pointers to the connector and crtc in bridge state

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:32PM +0100, Maxime Ripard wrote: > Now that connectors are no longer necessarily created by the bridges > drivers themselves but might be created by drm_bridge_connector, it's > pretty hard for bridge drivers to retrieve pointers to the connector and > CRTC they are at

Re: [PATCH v4 8/9] drm/msm/dpu: rework core_perf debugfs overrides

2025-01-15 Thread Abhinav Kumar
On 1/15/2025 4:35 PM, Dmitry Baryshkov wrote: On Wed, Jan 15, 2025 at 11:51:20AM -0800, Abhinav Kumar wrote: On 1/15/2025 12:41 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025 at 02:02:54PM -0800, Abhinav Kumar wrote: On 1/5/2025 7:07 PM, Dmitry Baryshkov wrote: Currently debugfs prov

Re: [PATCH 23/29] drm/bridge: Provide a helper to retrieve current bridge state

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 10:05:30PM +0100, Maxime Ripard wrote: > The current bridge state is accessible from the drm_bridge structure, > but since it's fairly indirect it's not easy to figure out. > > Provide a helper to retrieve it. > > Signed-off-by: Maxime Ripard > --- > include/drm/drm_brid

Re: [PATCH v4 7/9] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2025-01-15 Thread Abhinav Kumar
On 1/15/2025 4:32 PM, Dmitry Baryshkov wrote: On Wed, Jan 15, 2025 at 11:41:27AM -0800, Abhinav Kumar wrote: On 1/15/2025 12:27 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025 at 01:18:26PM -0800, Abhinav Kumar wrote: On 1/14/2025 3:10 AM, Dmitry Baryshkov wrote: On Mon, Jan 13, 2025

Re: [PATCH v4 8/9] drm/msm/dpu: rework core_perf debugfs overrides

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 11:51:20AM -0800, Abhinav Kumar wrote: > > > On 1/15/2025 12:41 AM, Dmitry Baryshkov wrote: > > On Tue, Jan 14, 2025 at 02:02:54PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/5/2025 7:07 PM, Dmitry Baryshkov wrote: > > > > Currently debugfs provides separate 'mode

Re: [PATCH v4 7/9] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2025-01-15 Thread Dmitry Baryshkov
On Wed, Jan 15, 2025 at 11:41:27AM -0800, Abhinav Kumar wrote: > > > On 1/15/2025 12:27 AM, Dmitry Baryshkov wrote: > > On Tue, Jan 14, 2025 at 01:18:26PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/14/2025 3:10 AM, Dmitry Baryshkov wrote: > > > > On Mon, Jan 13, 2025 at 07:38:16PM -0800

Re: [PATCH 03/35] drm/msm/dpu: stop passing mdss_ver to setup_timing_gen()

2025-01-15 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: As a preparation to further MDSS-revision cleanups stop passing MDSS revision to the setup_timing_gen() callback. Instead store a pointer to it inside struct dpu_hw_intf and use it diretly. It's not that the MDSS revision can chance between dpu_hw

[PATCH 24/29] drm/bridge: Provide a helper to get the global state from a bridge state

2025-01-15 Thread Maxime Ripard
We have access to the global drm_atomic_state from a drm_bridge_state, but since it's fairly indirect it's not as obvious as it can be for other KMS entities. Provide a helper to make it easier to figure out. Signed-off-by: Maxime Ripard --- include/drm/drm_atomic.h | 16 1 fil

Re: [PATCH 02/35] drm/msm/dpu: enable DPU_WB_INPUT_CTRL for DPU 5.x

2025-01-15 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: Several DPU 5.x platforms are supposed to be using DPU_WB_INPUT_CTRL, to bind WB and PINGPONG blocks, but they do not. Change those platforms to use WB_SM8250_MASK, which includes that bit. Fixes: 1f5bcc4316b3 ("drm/msm/dpu: enable writeback on S

Re: [PATCH 01/35] drm/msm/dpu: skip watchdog timer programming through TOP on >= SM8450

2025-01-15 Thread Abhinav Kumar
On 12/13/2024 2:14 PM, Dmitry Baryshkov wrote: The SM8450 and later chips have DPU_MDP_PERIPH_0_REMOVED feature bit set, which means that those platforms have dropped some of the registers, including the WD TIMER-related ones. Stop providing the callback to program WD timer on those platforms.

Re: [PATCHv2 05/11] mm/truncate: Use folio_set_dropbehind() instead of deactivate_file_folio()

2025-01-15 Thread Yu Zhao
On Wed, Jan 15, 2025 at 2:35 PM Matthew Wilcox wrote: > > On Wed, Jan 15, 2025 at 11:31:29AM +0200, Kirill A. Shutemov wrote: > > -static void lru_deactivate_file(struct lruvec *lruvec, struct folio *folio) > > -{ > > - bool active = folio_test_active(folio) || lru_gen_enabled(); > > - lon

Re: [PATCHv2 05/11] mm/truncate: Use folio_set_dropbehind() instead of deactivate_file_folio()

2025-01-15 Thread Matthew Wilcox
On Wed, Jan 15, 2025 at 11:31:29AM +0200, Kirill A. Shutemov wrote: > -static void lru_deactivate_file(struct lruvec *lruvec, struct folio *folio) > -{ > - bool active = folio_test_active(folio) || lru_gen_enabled(); > - long nr_pages = folio_nr_pages(folio); > - > - if (folio_test_unev

Re: [PATCH] drm/msm: Use str_enable_disable-like helpers

2025-01-15 Thread Abhinav Kumar
On 1/14/2025 11:17 AM, Krzysztof Kozlowski wrote: Replace ternary (condition ? "enable" : "disable") syntax with helpers from string_choices.h because: 1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite

[PATCH 29/29] drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer

2025-01-15 Thread Maxime Ripard
The TI sn65dsi86 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. This was due to the fact that we did't have any other alternative to retrieve the CRTC pointer. Fortunately, the crtc pointer is now provided in the bridge state, so we can mov

[PATCH 26/29] drm/bridge: cdns-csi: Switch to atomic helpers

2025-01-15 Thread Maxime Ripard
The Cadence DSI driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. This was due to the fact that we did't have any other alternative to retrieve the CRTC pointer. Fortunately, the crtc pointer is now provided in the bridge state, so we can move

[PATCH 28/29] drm/bridge: tc358768: Convert to atomic helpers

2025-01-15 Thread Maxime Ripard
The tc358768 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. This was due to the fact that we did't have any other alternative to retrieve the CRTC pointer. Fortunately, the crtc pointer is now provided in the bridge state, so we can move to

[PATCH 25/29] drm/bridge: Provide pointers to the connector and crtc in bridge state

2025-01-15 Thread Maxime Ripard
Now that connectors are no longer necessarily created by the bridges drivers themselves but might be created by drm_bridge_connector, it's pretty hard for bridge drivers to retrieve pointers to the connector and CRTC they are attached to. Indeed, the only way to retrieve the CRTC is to follow the

[PATCH 27/29] drm/bridge: tc358775: Switch to atomic commit

2025-01-15 Thread Maxime Ripard
The tc358775 driver follows the drm_encoder->crtc pointer that is deprecated and shouldn't be used by atomic drivers. This was due to the fact that we did't have any other alternative to retrieve the CRTC pointer. Fortunately, the crtc pointer is now provided in the bridge state, so we can move to

[PATCH 22/29] drm/bridge: Rename atomic hooks parameters to drop old prefix

2025-01-15 Thread Maxime Ripard
All the bridge atomic hooks were using the old_bridge_state name for their drm_bridge_state parameter. However, this state is the current state being committed for all of them, which ends up being confusing. Let's rename it to bridge_state for all of them. Signed-off-by: Maxime Ripard --- inclu

[PATCH 21/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_wait_for_flip_done() will wait for pages flips on all CRTCs affected by a given commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as sta

[PATCH 23/29] drm/bridge: Provide a helper to retrieve current bridge state

2025-01-15 Thread Maxime Ripard
The current bridge state is accessible from the drm_bridge structure, but since it's fairly indirect it's not easy to figure out. Provide a helper to retrieve it. Signed-off-by: Maxime Ripard --- include/drm/drm_bridge.h | 17 + 1 file changed, 17 insertions(+) diff --git a/inc

[PATCH 17/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_hw_done() signals hardware completion of a given commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxi

[PATCH 20/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_wait_for_dependencies() is the final part of a commit and signals it completion. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Si

[PATCH 18/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_vblanks()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_wait_for_vblanks() waits for vblank events on all the CRTCs affected by a commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. S

[PATCH 19/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_cleanup_planes() is one of the final part of a commit, and will free up all plane resources used in the previous commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing.

[PATCH 16/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_fake_vblank()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_fake_vblank() fake a vblank event if needed when a new commit is being applied. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Sig

[PATCH 15/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_writebacks() updates all writeback connectors affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Sign

[PATCH 03/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_tail() is the final part of an atomic commit, and is given a parameter with the drm_atomic_state being committed. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime Ri

[PATCH 14/29] drm/bridge: Change parameter name of drm_atomic_bridge_chain_enable()

2025-01-15 Thread Maxime Ripard
drm_atomic_bridge_chain_enable() enables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime

[PATCH 13/29] drm/bridge: Change parameter name of drm_atomic_bridge_chain_pre_enable()

2025-01-15 Thread Maxime Ripard
drm_atomic_bridge_chain_pre_enable() enables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Max

[PATCH 12/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_modeset_enables()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_modeset_enables() enables all outputs affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-b

[PATCH 11/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_planes()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_planes() updates all planes affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime

[PATCH 08/29] drm/bridge: Change parameter name of drm_atomic_bridge_chain_post_disable()

2025-01-15 Thread Maxime Ripard
drm_atomic_bridge_chain_post_disable() disables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by:

[PATCH 09/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_update_legacy_modeset_state()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_update_legacy_modeset_state() updates all the legacy modeset pointers a connector, encoder or CRTC might have with the ones being setup by a given commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_

[PATCH 07/29] drm/bridge: Change parameter name of drm_atomic_bridge_chain_disable()

2025-01-15 Thread Maxime Ripard
drm_atomic_bridge_chain_disable() disables all bridges affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxim

[PATCH 10/29] drm/atomic-helper: Change parameter name of crtc_set_mode()

2025-01-15 Thread Maxime Ripard
crtc_set_mode() deals with calling the modeset related hooks for CRTC, connectors and bridges if and when a new commit changes them. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called as old_state, which is pretty confusing. Let's rename that varia

[PATCH 06/29] drm/atomic-helper: Change parameter name of disable_outputs()

2025-01-15 Thread Maxime Ripard
disable_outputs() disables all connectors and CRTCs affected by a commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Maxime Ripard --- drivers/g

[PATCH 05/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_modeset_disables()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_modeset_disables() disables all the outputs affected by a commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Signed-off-by: Ma

[PATCH 02/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_dependencies()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_wait_for_dependencies() waits for all the dependencies a commit has before going forward with it. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that varia

[PATCH 04/29] drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail_rpm()

2025-01-15 Thread Maxime Ripard
drm_atomic_helper_commit_tail_rpm() is the final part of an atomic commit, and is given the state being committed as a parameter. However, that parameter is named old_state, but documented as the "new modeset state" which is all super confusing. Let's rename that parameter to state. Signed-off-b

[PATCH 01/29] drm/atomic-helper: Fix commit_tail state variable name

2025-01-15 Thread Maxime Ripard
Even though the commit_tail () drm_atomic_state parameter is called old_state, it's actually the state being committed which is confusing. It's even more confusing since the atomic_commit_tail hook being called by commit_tail() parameter is called state. Let's rename the variable from old_state t

[PATCH 00/29] drm/bridge: Various quality of life improvements

2025-01-15 Thread Maxime Ripard
drivers/gpu/drm/drm_bridge.c | 61 --- include/drm/drm_atomic.h | 30 +++ include/drm/drm_bridge.h | 25 ++- 9 files changed, 279 insertions(+), 207 deletions(-) --- base-commit: 573b73e5ac2ce0d58859eace8218f3a7e9212186 change-id: 20250115-b

Re: [PATCHv2 11/11] mm: Rename PG_dropbehind to PG_reclaim

2025-01-15 Thread Yu Zhao
On Wed, Jan 15, 2025 at 2:32 AM Kirill A. Shutemov wrote: > > Now as PG_reclaim is gone, its name can be reclaimed for better > use :) > > Rename PG_dropbehind to PG_reclaim and rename all helpers around it. > > Signed-off-by: Kirill A. Shutemov Acked-by: Yu Zhao

Re: [PATCHv2 09/11] mm: Remove PG_reclaim

2025-01-15 Thread Yu Zhao
On Wed, Jan 15, 2025 at 2:32 AM Kirill A. Shutemov wrote: > > Nobody sets the flag anymore. > > Remove the PG_reclaim, making PG_readhead exclusive user of the page > flag bit. > > Signed-off-by: Kirill A. Shutemov Acked-by: Yu Zhao

Re: [PATCHv2 05/11] mm/truncate: Use folio_set_dropbehind() instead of deactivate_file_folio()

2025-01-15 Thread Yu Zhao
On Wed, Jan 15, 2025 at 2:32 AM Kirill A. Shutemov wrote: > > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > The new flag allows to replace whole deactivate_file_

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Bill O'Donnell
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except for > watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls, > loadpin_sysctl_table and the ones calling register_net_sysctl (./net, > drivers/inifiniband dirs

Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-15 Thread Wei Liu
On Fri, Jan 10, 2025 at 03:16:08PM +0100, Joel Granados wrote: [...] > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 7a35c82976e0..9453f0c26f2a 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -141,7 +141,7 @@ static int sysctl_record_panic_msg = 1; >

Re: [PATCH RFC 1/4] drm/msm/adreno: Add speedbin support for X1-85

2025-01-15 Thread Dmitry Baryshkov
On Thu, Jan 16, 2025 at 01:07:17AM +0530, Akhil P Oommen wrote: > On 1/9/2025 7:27 PM, Konrad Dybcio wrote: > > On 8.01.2025 11:42 PM, Akhil P Oommen wrote: > >> Adreno X1-85 has an additional bit which is at a non-contiguous > >> location in qfprom. Add support for this new "hi" bit along with > >

Re: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-15 Thread Dmitry Baryshkov
On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > ImageEnhancemenT(IET) hardware interpolates the LUT value to generate > the enhanced output image. LUT takes an input value, outputs a new > value based on the data within the LUT. 1D LUT can remap individual > input values to new out

Re: [PATCH v4 8/9] drm/msm/dpu: rework core_perf debugfs overrides

2025-01-15 Thread Abhinav Kumar
On 1/15/2025 12:41 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025 at 02:02:54PM -0800, Abhinav Kumar wrote: On 1/5/2025 7:07 PM, Dmitry Baryshkov wrote: Currently debugfs provides separate 'modes' to override calculated MDP_CLK rate and interconnect bandwidth votes. Change that to allow

Re: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-15 Thread Dmitry Baryshkov
On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > Display Histogram is an array of bins and can be generated in many ways > referred to as modes. > Ex: HSV max(RGB), Wighted RGB etc. > > Understanding the histogram data format(Ex: HSV max(RGB)) > Histogram is just the pixel count. >

Re: [PATCH v4 7/9] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2025-01-15 Thread Abhinav Kumar
On 1/15/2025 12:27 AM, Dmitry Baryshkov wrote: On Tue, Jan 14, 2025 at 01:18:26PM -0800, Abhinav Kumar wrote: On 1/14/2025 3:10 AM, Dmitry Baryshkov wrote: On Mon, Jan 13, 2025 at 07:38:16PM -0800, Abhinav Kumar wrote: On 1/5/2025 7:07 PM, Dmitry Baryshkov wrote: Move perf mode handlin

Re: [PATCH RFC 1/4] drm/msm/adreno: Add speedbin support for X1-85

2025-01-15 Thread Akhil P Oommen
On 1/9/2025 7:27 PM, Konrad Dybcio wrote: > On 8.01.2025 11:42 PM, Akhil P Oommen wrote: >> Adreno X1-85 has an additional bit which is at a non-contiguous >> location in qfprom. Add support for this new "hi" bit along with >> the speedbin mappings. >> --- >> drivers/gpu/drm/msm/adreno/a6xx_catalo

Re: [PATCH v4 01/11] mtd: core: always create master device

2025-01-15 Thread Miquel Raynal
Hi, On 14/01/2025 at 14:05:40 GMT, "Usyskin, Alexander" wrote: >> > > Create master device without partition when >> > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. >> > >> > I don't think you took into consideration my remarks regarding the fact >> > that you would break userspace. If you en

Re: [PATCH v2] drm/msm: Avoid rounding up to one jiffy

2025-01-15 Thread Akhil P Oommen
On 1/13/2025 9:18 PM, Rob Clark wrote: > From: Rob Clark > > If userspace is trying to achieve a timeout of zero, let 'em have it. > Only round up if the timeout is greater than zero. > > Fixes: 4969bccd5f4e ("drm/msm: Avoid rounding down to zero jiffies") > Signed-off-by: Rob Clark Reviewed-b

  1   2   3   >