drm_atomic_helper_wait_for_vblanks() waits for vblank events on all the
CRTCs affected by a commit. It takes the drm_atomic_state being
committed as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Signed-off-by: Maxime Ripard <mrip...@kernel.org>
---
 drivers/gpu/drm/drm_atomic_helper.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_helper.c 
b/drivers/gpu/drm/drm_atomic_helper.c
index 
d642bbc074bd364256409c91649f8d8aa10f5023..581fd0f14ba0aa2a9d0334cad49575de3fb5fb20
 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1656,11 +1656,11 @@ int drm_atomic_helper_wait_for_fences(struct drm_device 
*dev,
 EXPORT_SYMBOL(drm_atomic_helper_wait_for_fences);
 
 /**
  * drm_atomic_helper_wait_for_vblanks - wait for vblank on CRTCs
  * @dev: DRM device
- * @old_state: atomic state object with old state structures
+ * @state: atomic state object being committed
  *
  * Helper to, after atomic commit, wait for vblanks on all affected
  * CRTCs (ie. before cleaning up old framebuffers using
  * drm_atomic_helper_cleanup_planes()). It will only wait on CRTCs where the
  * framebuffers have actually changed to optimize for the legacy cursor and
@@ -1670,44 +1670,44 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_fences);
  * drm_atomic_helper_setup_commit() should look at
  * drm_atomic_helper_wait_for_flip_done() as an alternative.
  */
 void
 drm_atomic_helper_wait_for_vblanks(struct drm_device *dev,
-               struct drm_atomic_state *old_state)
+                                  struct drm_atomic_state *state)
 {
        struct drm_crtc *crtc;
        struct drm_crtc_state *old_crtc_state, *new_crtc_state;
        int i, ret;
        unsigned int crtc_mask = 0;
 
         /*
          * Legacy cursor ioctls are completely unsynced, and userspace
          * relies on that (by doing tons of cursor updates).
          */
-       if (old_state->legacy_cursor_update)
+       if (state->legacy_cursor_update)
                return;
 
-       for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, 
new_crtc_state, i) {
+       for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, 
new_crtc_state, i) {
                if (!new_crtc_state->active)
                        continue;
 
                ret = drm_crtc_vblank_get(crtc);
                if (ret != 0)
                        continue;
 
                crtc_mask |= drm_crtc_mask(crtc);
-               old_state->crtcs[i].last_vblank_count = 
drm_crtc_vblank_count(crtc);
+               state->crtcs[i].last_vblank_count = drm_crtc_vblank_count(crtc);
        }
 
-       for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {
+       for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) {
                if (!(crtc_mask & drm_crtc_mask(crtc)))
                        continue;
 
                ret = wait_event_timeout(dev->vblank[i].queue,
-                               old_state->crtcs[i].last_vblank_count !=
-                                       drm_crtc_vblank_count(crtc),
-                               msecs_to_jiffies(100));
+                                        state->crtcs[i].last_vblank_count !=
+                                               drm_crtc_vblank_count(crtc),
+                                        msecs_to_jiffies(100));
 
                WARN(!ret, "[CRTC:%d:%s] vblank wait timed out\n",
                     crtc->base.id, crtc->name);
 
                drm_crtc_vblank_put(crtc);

-- 
2.47.1

Reply via email to