Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-11-28 Thread Zhang, Julia
Hi all, Sorry for my late reply. I don't know if you still remember this thread, let me give a quick summary: 1. We want to implement the dGPU prime feature in guest VM. But we encountered this issue: virtio-gpu doesn’t have ->get_sg_table implemented which is required by drm_gem_map_attach

Re: [PATCH v1 6/7] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2024-11-28 Thread 胡俊光

Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-11-28 Thread 胡俊光

Re: [git pull] drm fixes for 6.13-rc1

2024-11-28 Thread Sasha Levin
[+cc Alex] On Fri, Nov 29, 2024 at 06:42:18AM +1000, Dave Airlie wrote: Alex Deucher (3): drm/amdgpu/jpeg: cancel the jpeg worker Hi folks, When merging this PR into linus-next I've started the following warning triggered by the commit above: [4.356975] WARNING: CPU: 1 PID: 1 at ker

Re: [PATCH v3 9/9] arm64: dts: qcom: Add display support for QCS615 RIDE board

2024-11-28 Thread fange zhang
On 2024/11/26 6:08, Dmitry Baryshkov wrote: On Mon, 25 Nov 2024 at 09:39, fange zhang wrote: On 2024/11/22 18:22, Dmitry Baryshkov wrote: On Fri, Nov 22, 2024 at 05:56:52PM +0800, Fange Zhang wrote: From: Li Liu Add display MDSS and DSI configuration for QCS615 RIDE board. QCS615 has

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-11-28 Thread Chen-Yu Tsai
On Thu, Nov 28, 2024 at 2:46 AM Sui Jingfeng wrote: > > Hi, > > On 2024/11/27 17:58, Chen-Yu Tsai wrote: > > Revisiting this thread since I just stepped on the same problem on a > > different device. > > > > On Thu, Nov 14, 2024 at 9:12 PM Maxime Ripard wrote: > >> On Tue, Oct 29, 2024 at 10:53:4

[PATCH 2/2] drm/modes: Fix drm_mode_vrefres() docs

2024-11-28 Thread Ville Syrjala
From: Ville Syrjälä We no longer store a cache vrefresh value in the mode. Remove the stale information from drm_vrefresh() docs. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/dri

[PATCH 1/2] drm/modes: Avoid divide by zero harder in drm_mode_vrefresh()

2024-11-28 Thread Ville Syrjala
From: Ville Syrjälä drm_mode_vrefresh() is trying to avoid divide by zero by checking whether htotal or vtotal are zero. But we may still end up with a div-by-zero of vtotal*htotal*... Cc: sta...@vger.kernel.org Reported-by: syzbot+622bba18029bcde67...@syzkaller.appspotmail.com Closes: https://s

[PATCH 0/2] drm/modes: Fix div-by-zero in drm_mode_vrefresh()

2024-11-28 Thread Ville Syrjala
From: Ville Syrjälä Fix a potential div-by-zero in drm_mode_vrefresh() TODO: should probably make drm_mode_setcrtc() not even print the (potentially partially) converted mode, and instead print the original umode.. Test-with: 20241128190927.26033-1-ville.syrj...@linux.intel.com Vil

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-28 Thread Parthiban
On 11/13/24 1:45 PM, John Watts wrote: > It really seems like the code means mixers here. True, I was wrong about my statement. But with A133, the case of independent DE is unique, which I couldn't test yet. > If my thoughts are correct, this would break use of mixer0 and mixer1 at the > same time

Re: [PATCH v1 6/7] drm/mediatek: mtk_hdmi: Split driver and add common probe function

2024-11-28 Thread 胡俊光

Re: [PATCH 1/1] amdgpu fix for gfx1103 queue evict/restore crash

2024-11-28 Thread Mika Laitio
Thanks for the feedback, the problem is anyway real breaking userspace apps if my patch is not in use. I have actually spend this day for investigating and testing another gpu hang bug that has been reported originally by others on gfx1010/AMD RX 5700. I thought originally that the bug is different

Re: [PATCH v1 2/7] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2

2024-11-28 Thread 胡俊光

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-11-28 Thread Damon Ding
Hi Heiko, On 2024/11/27 19:04, Heiko Stübner wrote: Hi Damon, Am Mittwoch, 27. November 2024, 12:00:10 CET schrieb Damon Ding: Hi Heiko: On 2024/11/27 17:29, Heiko Stübner wrote: Hi Damon, Am Mittwoch, 27. November 2024, 08:51:51 CET schrieb Damon Ding: Add basic support for RBR/HBR/HBR2 l

Re: [v4,09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-11-28 Thread Liu Ying
On 11/28/2024, Sui Jingfeng wrote: > Hi, Hi, > > On 2024/11/25 17:33, Liu Ying wrote: >> i.MX8qxp Display Controller display engine consists of all processing >> units that operate in a display clock domain.  Add minimal feature >> support with FrameGen and TCon so that the engine can output dis

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-28 Thread Alistair Popple
Matthew Brost writes: [...] > + * 3) Invalidation driver vfunc. > + * > + * void driver_invalidation(struct drm_gpusvm *gpusvm, > + *struct drm_gpusvm_notifier *notifier, > + *const struct mmu_notifier_range *mmu_range) > + * { > + *

Re: [PATCH v2 03/29] mm/migrate: Trylock device page in do_swap_page

2024-11-28 Thread Alistair Popple
Matthew Brost writes: > Avoid multiple CPU page faults to the same device page racing by trying > to lock the page in do_swap_page before taking an extra reference to the > page. This prevents scenarios where multiple CPU page faults each take > an extra reference to a device page, which could

Re: drm/fbdev-dma: regression

2024-11-28 Thread Nuno Gonçalves
> Here's a first attempt to address this bug. Could you please apply the > attached patch and report on the results? It should work against the > upcoming v6.13-rc1 or against a recent drm-misc-next. Hi. No luck yet. I collected crashes before the patch: BUG: Bad page map in process husband pte

Re: [PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers

2024-11-28 Thread kernel test robot
Hi Arun, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH v2 5/8] drm/panfrost: Handle page mapping failure

2024-11-28 Thread Adrián Larumbe
When mapping the pages of a BO, either a heap type at page fault time or else a non-heap BO at object creation time, if the ARM page table mapping function fails, we unmap what had been mapped so far and bail out. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 44 +++

[PATCH v2 0/8] Some Panfrost fixes and improvements

2024-11-28 Thread Adrián Larumbe
This is v2 of https://lore.kernel.org/dri-devel/20241014233758.994861-1-adrian.laru...@collabora.com/ This patch series is a collection of minor fixes and improvements I came up with while working on driver related stuff. Changelog: v2: - Removed commit that provided an explicit fence cleanup

[PATCH v2 7/8] drm/panfrost: Add forward declaration and types header

2024-11-28 Thread Adrián Larumbe
This is to make LLVM syntactic analysers happy. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_mmu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.h b/drivers/gpu/drm/panfrost/panfrost_mmu.h index e6e6966a0cca..27c3c65ed074 100644

[PATCH v2 3/8] drm/panfrost: Handle job HW submit errors

2024-11-28 Thread Adrián Larumbe
Avoid waiting for the DRM scheduler job timedout handler, and instead, let the DRM scheduler core signal the error fence immediately when HW job submission fails. That means we must also decrement the runtime-PM refcnt for the device, because the job will never be enqueued or inflight. Signed-off

[PATCH v2 2/8] drm/panfrost: Handle inexistent GPU during probe

2024-11-28 Thread Adrián Larumbe
Just in case we're dealing with a yet not recognised device. Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/driver

[PATCH v2 8/8] drm/panfrost: Remove unused device property

2024-11-28 Thread Adrián Larumbe
The as_in_use_mask device state variable is no longer in use. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.h | 1 - drivers/gpu/drm/panfrost/panfrost_mmu.c| 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/

[PATCH v2 6/8] drm/panfrost: Make re-enabling job interrupts at device reset optional

2024-11-28 Thread Adrián Larumbe
Rather than remasking interrupts after a device reset in the main reset path, allow selecting whether to do this with an additional bool parameter. To this end, split reenabling job interrupts into two functions, one that clears the interrupts and another one which unmasks them conditionally. Sig

[PATCH v2 4/8] drm/panfrost: Handle error when allocating AS number

2024-11-28 Thread Adrián Larumbe
If we reach the beginning of the LRU AS list, then return an error. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_job.c | 6 +- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 +++-- drivers/gpu/drm/panfrost/panfrost_mmu.h | 2 +- drivers/gpu/drm/panfrost/panfro

[PATCH v2 1/8] drm/panfrost: Replace DRM driver allocation method with newer one

2024-11-28 Thread Adrián Larumbe
Drop the deprecated DRM driver allocation method in favour of devm_drm_dev_alloc(). Overall just make it the same as in Panthor. Also discard now superfluous generic and platform device pointers inside the main panfrost device structure. Some ancient checkpatch issues unearthed as a result of thes

Re: [PATCH v2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-11-28 Thread Heiko Stuebner
On Fri, 15 Nov 2024 16:11:31 +0100, Heiko Stuebner wrote: > The clock is in Hz while the value checked against is in kHz, so > actual frequencies will never be able to be below to max value. > Fix this by specifying the max-value in Hz too. > > Applied, thanks! [1/1] drm/rockchip: vop2: fix r

[PATCH v6 2/3] drm/xe: Move the coredump registration to the worker thread

2024-11-28 Thread John . C . Harrison
From: John Harrison Adding lockdep checking to the coredump code showed that there was an existing violation. The dev_coredumpm_timeout() call is used to register the dump with the base coredump subsystem. However, that makes multiple memory allocations, only some of which use the GFP_ flags pass

[PATCH] drm/xe: Avoid evicting object of the same vm in none fault mode

2024-11-28 Thread Oak Zeng
BO validation during vm_bind could trigger memory eviction when system runs under memory pressure. Right now we blindly evict BOs of all VMs. This scheme has a problem when system runs in none recoverable page fault mode: even though the vm_bind could be successful by evicting BOs, the later the re

[git pull] drm fixes for 6.13-rc1

2024-11-28 Thread Dave Airlie
Hi Linus, Merge window fixes, mostly amdgpu and xe, with a few other minor ones, all looks fairly normal, Dave. drm-next-2024-11-29: drm fixes for v6.13-rc1 i915: - hdcp: Fix when the first read and write are retried xe: - Wake up waiters after wait condition set to true - Mark the preempt fen

[PATCH v9 1/5] drm: add drm_memory_stats_is_zero

2024-11-28 Thread Yunxiang Li
Add a helper to check if the memory stats is zero, this will be used to check for memory accounting errors. Signed-off-by: Yunxiang Li Reviewed-by: Christian König CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_file.c | 10 ++ include/drm/drm_file.h | 1 + 2 files chan

[PATCH v9 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-28 Thread Yunxiang Li
Define how to handle buffers with multiple possible placement so we don't get incompatible implementations. Callout the resident requirement for drm-purgeable- explicitly. Remove the confusing requirement for there to be only drm-memory- or only drm-resident-, and clarify that drm-memory- is legacy

[PATCH v9 2/5] drm: make drm-active- stats optional

2024-11-28 Thread Yunxiang Li
When memory stats is generated fresh everytime by going though all the BOs, their active information is quite easy to get. But if the stats are tracked with BO's state this becomes harder since the job scheduling part doesn't really deal with individual buffers. Make drm-active- optional to enable

udmabuf: check_memfd_seals() is racy

2024-11-28 Thread Jann Horn
Hi! Julian Orth reported at https://bugzilla.kernel.org/show_bug.cgi?id=219106 that udmabuf_create() checks for F_SEAL_WRITE in a racy way, so a udmabuf can end up holding references to pages in a write-sealed memfd, which theoretically breaks one of the security properties of memfd sealing. See a

Re: drm/fbdev-dma: regression

2024-11-28 Thread Thomas Zimmermann
Hi Am 11.11.24 um 14:42 schrieb Nuno Gonçalves: On Mon, Nov 11, 2024 at 1:22 PM Thomas Zimmermann wrote: The patch in question changes the whole memory management of the affected code. It's also noteworthy that most of it has been reworked for the upcoming v6.12. Maybe this already fixed the p

[PULL] drm-xe-next-fixes

2024-11-28 Thread Thomas Hellstrom
Hi Dave, Simona An all-Matt drm-xe-next-fixes PR this week. Thanks, Thomas drm-xe-next-fixes-2024-11-28: Driver Changes: - Update xe2 graphics name string (Matt Roper) - Fix a couple of guc submit races (Matt Auld) - Fix pat index usage in migrate (Matt Auld) - Ensure non-cached migrate pagetabl

[PATCH v10 0/4] Introduce DRM device wedged event

2024-11-28 Thread Raag Jadav
This series introduces device wedged event in DRM subsystem and uses it in xe and i915 drivers. Detailed description in commit message. This was earlier attempted as xe specific uevent in v1 and v2. https://patchwork.freedesktop.org/series/136909/ Similar work by André Almeida. https://lore.kerne

[PATCH v10 4/4] drm/i915: Use device wedged event

2024-11-28 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/d

[PATCH v10 1/4] drm: Introduce device wedged event

2024-11-28 Thread Raag Jadav
Introduce device wedged event, which notifies userspace of 'wedged' (hanged/unusable) state of the DRM device through a uevent. This is useful especially in cases where the device is no longer operating as expected and has become unrecoverable from driver context. Purpose of this implementation is

[PATCH v10 2/4] drm/doc: Document device wedged event

2024-11-28 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions, prerequisites and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites section (Christian) v10: Clarify mmap cleanup and cons

[PATCH v10 3/4] drm/xe: Use device wedged event

2024-11-28 Thread Raag Jadav
This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. W

[PATCH v3 1/4] tee: add restricted memory allocation

2024-11-28 Thread Jens Wiklander
Add restricted memory allocation to the TEE subsystem. Restricted memory is not be accessible by kernel during normal circumstances. A new ioctl TEE_IOC_RSTMEM_ALLOC is added to allocate these restricted memory buffers. The restricted memory is allocated for a specific use-case, like Secure Video

[PATCH v3 4/4] optee: support restricted memory allocation

2024-11-28 Thread Jens Wiklander
Add support in the OP-TEE backend driver for restricted memory allocation. The restricted memory can be allocated from a static carveout, but also be dynamically allocated from CMA and turned into restricted memory by OP-TEE, inaccessible by the kernel. The restricted memory configuration is depen

[PATCH v3 2/4] optee: account for direction while converting parameters

2024-11-28 Thread Jens Wiklander
The OP-TEE backend driver has two internal function pointers to convert between the subsystem type struct tee_param and the OP-TEE type struct optee_msg_param. The conversion is done from one of the types to the other, which is then involved in some operation and finally converted back to the orig

[PATCH v3 3/4] optee: sync secure world ABI headers

2024-11-28 Thread Jens Wiklander
Update the header files describing the secure world ABI, both with and without FF-A. The ABI is extended to deal with restricted memory, but as usual backward compatible. Signed-off-by: Jens Wiklander --- drivers/tee/optee/optee_ffa.h | 27 ++--- drivers/tee/optee/optee_msg.h | 65 ++

[PATCH v3 0/4] TEE subsystem for restricted dma-buf allocations

2024-11-28 Thread Jens Wiklander
Hi, This patch set allocates the restricted DMA-bufs via the TEE subsystem. This a big update compared to the previous patch set [1]. The TEE subsystem handles the DMA-buf allocations since it is the TEE (OP-TEE, AMD-TEE, TS-TEE, or perhaps a future QTEE) which sets up the restrictions for the me

Re: [WIP RFC v2 32/35] rust: drm/kms: Add Device::num_crtcs()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > A binding for checking drm_device.num_crtcs. We'll need this in a moment > for vblank support, since setting it up requires knowing the number of > CRTCs that a driver has initialized. > > Signed-off-by: Lyude Paul > --- > rust/kernel

Re: [WIP RFC v2 31/35] rust: drm: Add Device::event_lock()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > This is just a crate-private helper to use Lock::from_raw() to provide an > immutable reference to the DRM event_lock, so that it can be used like a > normal rust spinlock. We'll need this for adding vblank related bindings. > > Signed

Re: [WIP RFC v2 30/35] rust: drm/kms: Add DriverCrtc::atomic_enable() and atomic_disable()

2024-11-28 Thread Daniel Almeida
Hi Lyude > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Optional trait methods for implementing the atomic_enable and > atomic_disable callbacks of a CRTC. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/crtc.rs | 76 - > 1 file changed, 74 inser

Re: [WIP RFC v2 29/35] rust: drm/kms: Add DriverCrtc::atomic_begin() and atomic_flush()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Optional trait methods for implementing the atomic_begin and atomic_flush > callbacks for a CRTC. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/crtc.rs | 78 - > 1 file changed, 76 insert

Re: [WIP RFC v2 28/35] rust: drm/kms: Add RawPlane::framebuffer()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Returns the Framebuffer currently assigned in an atomic plane state. A bit unrelated to this patch, but can you have more than one framebuffer active? i.e.: for things like overlays, etc > > Signed-off-by: Lyude Paul > --- > rust

Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti,lvds-vcom

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:57:16AM +0100, Andrej Picej wrote: > Hi Maxime, > > On 28. 11. 24 11:29, Maxime Ripard wrote: > > On Thu, Nov 28, 2024 at 09:46:33AM +0100, Andrej Picej wrote: > > > On 27. 11. 24 16:16, Rob Herring wrote: > > > > On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wr

Re: [WIP RFC v2 27/35] rust: drm/kms: Add drm_framebuffer bindings

2024-11-28 Thread Daniel Almeida
> On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > This adds some very simple bindings for drm_framebuffer. We don't use them > much yet, but we'll eventually be using them when rvkms eventually gets CRC > and writeback support. Just like Connector objects, these use RcModeObject. Yeah, for th

Re: [v4,09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 04:46:53PM +0800, Sui Jingfeng wrote: > Hi, > > On 2024/11/25 17:33, Liu Ying wrote: > > i.MX8qxp Display Controller display engine consists of all processing > > units that operate in a display clock domain. Add minimal feature > > support with FrameGen and TCon so that t

Re: [PATCH v3 6/7] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-28 Thread Neil Armstrong
On 28/11/2024 14:26, Dmitry Baryshkov wrote: On Thu, Nov 28, 2024 at 11:25:46AM +0100, Neil Armstrong wrote: Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8

Re: [WIP RFC v2 26/35] WIP: rust: drm/kms: Add RawPlaneState::atomic_helper_check()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Add a binding for drm_atomic_helper_check_plane_state(). Since we want to > make sure that the user is passing in the new state for a Crtc instead of > an old state, we explicitly ask for a reference to a BorrowedCrtcState. > > Signed-

[PULL] drm-misc-fixes

2024-11-28 Thread Thomas Zimmermann
Hi Dave, Sima, here's the PR of drm-misc-fixes for this week. The first two patches are from last weeks PR drm-misc-fixes-2024-11-21, which should be merged first. Best regards Thomas drm-misc-fixes-2024-11-28: Short summary of fixes pull: dma-buf: - Fix dma_fence_array_signaled() to ensure for

Re: [WIP RFC v2 25/35] rust: drm/kms: Add RawPlaneState::crtc()

2024-11-28 Thread Daniel Almeida
Hi Lyude > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Add a binding for checking drm_plane_state.crtc. Note that we don't have a > way of knowing what DriverCrtc implementation would be used here (and want > to make this function also available on OpaquePlaneState types), so we > return an

Re: [WIP RFC v2 24/35] rust: drm/kms: Add RawCrtcState::active()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > A binding for checking drm_crtc_state.active. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/crtc.rs | 8 > 1 file changed, 8 insertions(+) > > diff --git a/rust/kernel/drm/kms/crtc.rs b/rust/kernel/drm/kms/crtc.rs

Re: [WIP RFC v2 22/35] rust: drm/kms: Add DriverPlane::atomic_update()

2024-11-28 Thread Daniel Almeida
> On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > A mandatory trait method used for implementing DRM's atomic plane update > callback. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/plane.rs | 39 +++- > 1 file changed, 38 insertions(+), 1 deletion(-

Re: [WIP RFC v2 23/35] rust: drm/kms: Add DriverPlane::atomic_check()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > Optional trait method for implementing a plane's atomic_check(). > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/plane.rs | 41 +++- > 1 file changed, 40 insertions(+), 1 deletion(-) > > diff

Re: [WIP RFC v2 22/35] rust: drm/kms: Add DriverPlane::atomic_update()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > A mandatory trait method used for implementing DRM's atomic plane update > callback. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/plane.rs | 39 +++- > 1 file changed, 38 insertions(+), 1 de

Re: [WIP RFC v2 21/35] rust: drm/kms: Introduce DriverCrtc::atomic_check()

2024-11-28 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > An optional trait method for implementing a CRTC's atomic state check. A more thorough explanation like you had in your last patch would be nice here. By `atomic state check` you mean after the state has been duplicated, and mutated,

Re: [PATCH v3 5/7] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:25:45AM +0100, Neil Armstrong wrote: > Now all the DDR bandwidth voting via the GPU Management Unit (GMU) > is in place, declare the Bus Control Modules (BCMs) and the > corresponding parameters in the GPU info struct and add the > GMU_BW_VOTE feature bit to enable it. >

Re: [PATCH v3 7/7] arm64: qcom: dts: sm8650: add interconnect and opp-peak-kBps for GPU

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:25:47AM +0100, Neil Armstrong wrote: > Each GPU OPP requires a specific peak DDR bandwidth, let's add > those to each OPP and also the related interconnect path. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 14 ++ > 1 fil

Re: [PATCH v3 6/7] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:25:46AM +0100, Neil Armstrong wrote: > Each GPU OPP requires a specific peak DDR bandwidth, let's add > those to each OPP and also the related interconnect path. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++ > 1 file c

Re: [PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-28 Thread Dmitry Baryshkov
On Thu, Nov 28, 2024 at 11:25:41AM +0100, Neil Armstrong wrote: > Even if the code uses ARRAY_SIZE() to fill those tables, > it's still a best practice to not use magic values for > tables in structs. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/msm

[PULL] drm-misc-next-fixes

2024-11-28 Thread Maarten Lankhorst
Hi Dave, Simona, A pull request with a single obvious patch in it. Consequently it's very likely to break the world and everything in it. As famous last words I'll add: "the affected source file seems to compile on 32-bits and 64-bits x86". Cheers, ~Maarten drm-misc-next-fixes-2024-11-28: A si

Re: [PATCH 18/22] ceph: Convert timeouts to secs_to_jiffies()

2024-11-28 Thread Alex Markuze
looks good On Fri, Nov 15, 2024 at 11:35 PM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-

Re: [PATCH v2 18/21] ceph: Convert timeouts to secs_to_jiffies()

2024-11-28 Thread Alex Markuze
looks good On Sat, Nov 16, 2024 at 12:32 AM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-

Re: [PATCH RESEND v2] drm/i915: Fix memory leak by correcting cache object name in error handler

2024-11-28 Thread Andi Shyti
Hi Jiasheng, On Wed, Nov 27, 2024 at 08:10:42PM +, Jiasheng Jiang wrote: > From: Jiasheng Jiang > > Replace "slab_priorities" with "slab_dependencies" in the error handler > to avoid memory leak. > > Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") > Cc: # v5.2+ > Re

Re: [RFC 13/13] PM: standby: Add sysfs attribute for modern standby transitions

2024-11-28 Thread Ilpo Järvinen
On Thu, 21 Nov 2024, Antheas Kapenekakis wrote: > Add a sysfs attribute to allow informing the kernel about the current > standby state, those being: "active", "screen_off", "sleep", and > "resume" (to prepare turning the display on). The final modern > standby state DRIPS is omitted, as that is e

Re: [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3

2024-11-28 Thread Steven Price
On 13/11/2024 11:26, AngeloGioacchino Del Regno wrote: > The MediaTek MT8188 SoC has a Mali-G57 MC3 GPU and, similarly to > MT8192, it has yet another special GPU ID. > > Add the GPU ID to the list and treat it as a standard Mali-G57. > > Signed-off-by: AngeloGioacchino Del Regno > Pushed to d

Re: [PATCH v2 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

2024-11-28 Thread kernel test robot
Hi Heiko, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.12 next-20241128] [cannot apply to rockchip/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH v2 4/5] drm/panthor: Be robust against resume failures

2024-11-28 Thread Boris Brezillon
When the runtime PM resume callback returns an error, it puts the device in a state where it can't be resumed anymore. Make sure we can recover from such transient failures by calling pm_runtime_set_suspended() explicitly after a pm_runtime_resume_and_get() failure. v2: - Add a comment explaining

Re: [PATCH 0/3] sn65dsi83: Add LVDS_VCOM option in device-tree

2024-11-28 Thread Andrej Picej
Forgot to CC PHYTEC upstream mailing list. Doing this now. On 27. 11. 24 11:30, Andrej Picej wrote: Hi all, This patch series depends on the patch "[PATCH 11/15] arm64: dts: imx8mm-phyboard-polis: Add support for PEB-AV-10" (https://lore.kernel.org/linux-arm-kernel/20241125081814.397352-12-andr

[PATCH v2 0/5] drm/panthor: Be robust against failures in the resume path

2024-11-28 Thread Boris Brezillon
Hello, Here's a collection of patches improving robustness to failures in the device resume/suspend path. Those failures are pretty hard to reproduce (happens once in a while on a deqp-vk run), so I used a mechanism to fake them. Faking a FW boot failure is kinda tricky though, which means the la

[PATCH v2 3/5] drm/panthor: Ignore devfreq_{suspend, resume}_device() failures

2024-11-28 Thread Boris Brezillon
devfreq_{resume,suspend}_device() don't bother undoing the suspend_count modifications if something fails, so either it assumes failures are harmless, or it's super fragile/buggy. In either case it's not something we can address at the driver level, so let's just assume failures are harmless for no

[PATCH v2 1/5] drm/panthor: Preserve the result returned by panthor_fw_resume()

2024-11-28 Thread Boris Brezillon
WARN() will return true if the condition is true, false otherwise. If we store the return of drm_WARN_ON() in ret, we lose the actual error code. v2: - Add R-b Fixes: 5fe909cae118 ("drm/panthor: Add the device logical block") Signed-off-by: Boris Brezillon Reviewed-by: Steven Price --- drivers

[PATCH v2 2/5] drm/panthor: Be robust against runtime PM resume failures in the suspend path

2024-11-28 Thread Boris Brezillon
The runtime PM resume operation is not guaranteed to succeed, but if it fails, the device should be in a suspended state. Make sure we're robust to resume failures in the unplug path. v2: - Move the bit that belonged in the next commit - Drop the panthor_device_unplug() changes Signed-off-by: Bor

[PATCH v2 5/5] drm/panthor: Fix the fast-reset logic

2024-11-28 Thread Boris Brezillon
If we do a GPU soft-reset, that's no longer fast reset. This also means the slow reset fallback doesn't work because the MCU state is only reset after a GPU soft-reset. Let's move the retry logic to panthor_device_resume() to issue a soft-reset between the fast and slow attempts, and patch panthor

Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti,lvds-vcom

2024-11-28 Thread Andrej Picej
Hi Maxime, On 28. 11. 24 11:29, Maxime Ripard wrote: On Thu, Nov 28, 2024 at 09:46:33AM +0100, Andrej Picej wrote: On 27. 11. 24 16:16, Rob Herring wrote: On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wrote: From: Janine Hagemann Add an optional property to change LVDS output volta

Re: [PATCH v7 2/8] drm/ttm: Add ttm_bo_access

2024-11-28 Thread Rodrigo Vivi
On Wed, Nov 27, 2024 at 02:19:32PM +0100, Christian König wrote: > Am 26.11.24 um 18:46 schrieb Matthew Brost: > > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > > VRAM easily be accessed. Add ttm_bo_access, which is similar to > > ttm_bo_vm_access, to access such memory.

Re: [PATCH v1 2/7] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2

2024-11-28 Thread AngeloGioacchino Del Regno
Il 28/11/24 07:02, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Add a binding for the HDMI TX v2 Encoder found in Medi

Re: [PATCH v1 6/6] drm/mediatek: Add support for MT8195 Digital Parallel Interface

2024-11-28 Thread AngeloGioacchino Del Regno
Il 28/11/24 04:08, CK Hu (胡俊光) ha scritto: On Wed, 2024-11-27 at 13:44 +0100, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Il 27/11/24 10:04, CK Hu (胡俊光) ha scritto: On Wed, 2024-11-27 at 0

Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti,lvds-vcom

2024-11-28 Thread Maxime Ripard
On Thu, Nov 28, 2024 at 09:46:33AM +0100, Andrej Picej wrote: > On 27. 11. 24 16:16, Rob Herring wrote: > > On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wrote: > > > From: Janine Hagemann > > > > > > Add an optional property to change LVDS output voltage. This depends on > > > the conne

[PATCH v3 3/7] drm/msm: adreno: dynamically generate GMU bw table

2024-11-28 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale the ddr bandwidth along the frequency and power domain level, but for now we statically fill the bw_table with values from the downstream driver. Only the first entry is used, which is a disable vote, so we currently rely on scaling via the linux

[PATCH v3 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-28 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. While scaling via the interconnect path was sufficient, newer GPUs like the A750 requires specific vote paremeters and

[PATCH v3 6/7] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU

2024-11-28 Thread Neil Armstrong
Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b

[PATCH v3 5/7] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-11-28 Thread Neil Armstrong
Now all the DDR bandwidth voting via the GPU Management Unit (GMU) is in place, declare the Bus Control Modules (BCMs) and the corresponding parameters in the GPU info struct and add the GMU_BW_VOTE feature bit to enable it. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_catal

[PATCH v3 7/7] arm64: qcom: dts: sm8650: add interconnect and opp-peak-kBps for GPU

2024-11-28 Thread Neil Armstrong
Each GPU OPP requires a specific peak DDR bandwidth, let's add those to each OPP and also the related interconnect path. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi

[PATCH v3 0/7] drm/msm: adreno: add support for DDR bandwidth scaling via GMU

2024-11-28 Thread Neil Armstrong
voted for a same OPP, whatever decision is done by the GMU, it will ensure all resources votes are synchronized. Depends on [1] to avoid crashing when getting OPP bandwidths. [1] https://lore.kernel.org/all/20241128-topic-opp-fix-assert-index-check-v1-0-cb8bd4c03...@linaro.org/ Ran full vulkan-cts

[PATCH v3 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-11-28 Thread Neil Armstrong
The Adreno GPU Management Unit (GMU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, until now we left the OPP core scale the OPP bandwidth via the interconnect path. In order to enable bandwidth voting via the GPU Management Unit (GMU), when an opp is set by devfreq w

[PATCH v3 1/7] drm/msm: adreno: add defines for gpu & gmu frequency table sizes

2024-11-28 Thread Neil Armstrong
Even if the code uses ARRAY_SIZE() to fill those tables, it's still a best practice to not use magic values for tables in structs. Suggested-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletion

Re: [PATCH v4 resend] drm/meson: switch to a managed drm device

2024-11-28 Thread Anastasia Belova
Just a friendly reminder. On 11/12/24 10:00 AM, Anastasia Belova wrote: Switch to a managed drm device to cleanup some error handling and make future work easier. Fix dereference of NULL in meson_drv_bind_master by removing drm_dev_put(drm) before meson_encoder_*_remove and component_unbind_all

Re: [PATCH] drm/panthor: Fix a typo in the FW iface flag definitions

2024-11-28 Thread Boris Brezillon
On Wed, 13 Nov 2024 17:02:57 +0100 Boris Brezillon wrote: > Drop the _RD_ in the flag names. > > Signed-off-by: Boris Brezillon Queued to drm-misc-next. > --- > drivers/gpu/drm/panthor/panthor_fw.c | 62 ++-- > 1 file changed, 31 insertions(+), 31 deletions(-) > > di

Re: [v4,09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-11-28 Thread Sui Jingfeng
Hi, On 2024/11/25 17:33, Liu Ying wrote: i.MX8qxp Display Controller display engine consists of all processing units that operate in a display clock domain. Add minimal feature support with FrameGen and TCon so that the engine can output display timings. The display engine driver as a master b

Re: [PATCH 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add optional property ti,lvds-vcom

2024-11-28 Thread Andrej Picej
Hi Rob, On 27. 11. 24 16:16, Rob Herring wrote: On Wed, Nov 27, 2024 at 11:30:29AM +0100, Andrej Picej wrote: From: Janine Hagemann Add an optional property to change LVDS output voltage. This depends on the connected display specifications. With this property we directly set the LVDS_VCOM (0

  1   2   >