On Fri, Nov 15, 2024 at 09:22:49PM +, Easwar Hariharan wrote:
> diff --git a/samples/livepatch/livepatch-callbacks-busymod.c
> b/samples/livepatch/livepatch-callbacks-busymod.c
> index
> 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba
> 100644
> --- a/sampl
Hi,
在 2024/11/13 23:17, Chuck Lever 写道:
On Mon, Nov 11, 2024 at 11:20:17PM +0800, yangerkun wrote:
在 2024/11/11 22:39, Chuck Lever III 写道:
On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote:
I'm in the cc list ,so I assume you saw my set, then I don't know why
you're ignoring my concerns.
1) nex
On Fri, Nov 15, 2024 at 06:41:59PM +0200, Imre Deak wrote:
> After an error during adding an MST connector the MST port and the
> intel_connector object could be leaked, fix this up.
>
> Signed-off-by: Imre Deak
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/s390/kernel/lgr.c | 3 ++-
arch/s390/kernel/time.c
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit :
> Suggested-by: Anna-Maria Behnsen
> Signed-off-by: Easwar Hariharan
> ---
> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.
rnel.org/all/8734kngfni.fsf@somnus/
>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1:
> https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux
Define how to handle buffers with multiple possible placement so we
don't get incompatible implementations. Callout the resident requirement
for drm-purgeable- explicitly. Remove the requirement for there to be
only drm-memory- or only drm-resident-, it's not what's implemented and
having both is b
When memory stats is generated fresh everytime by going though all the
BOs, their active information is quite easy to get. But if the stats are
tracked with BO's state this becomes harder since the job scheduling
part doesn't really deal with individual buffers.
Make drm-active- optional to enable
Add a helper to check if the memory stats is zero, this will be used to
check for memory accounting errors.
Signed-off-by: Yunxiang Li
Reviewed-by: Christian König
CC: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_file.c | 10 ++
include/drm/drm_file.h | 1 +
2 files chan
On 11/15/2024 2:34 PM, Stephen Rothwell wrote:
> Hi Easwar,
>
> On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan
> wrote:
>>
>> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = {
>> -[SCTP_CONNTRACK_CLOSED] = 10 SECS,
>> -[SCTP_CONNTRACK_COOKIE_WAIT]
On 11/15/2024 2:38 PM, Stephen Rothwell wrote:
> Hi Easwar,
>
> On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan
> wrote:
>>
>> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL
>> (msecs_to_jiffies(1*60*1000)) /* 1 min */
>> -#define SHARPSL_CHARGE_FINISH_TIME
>> (msecs_to_jiffi
On Fri, Nov 15 2024 at 14:15, Easwar Hariharan wrote:
> On 11/15/2024 1:41 PM, Jeff Johnson wrote:
>>
>> How do you expect this series to land since it overlaps a large number of
>> maintainer trees? Do you have a maintainer who has volunteered to take the
>> series and the maintainers should just
On Fri, Nov 15, 2024 at 10:30:12PM +0200, Imre Deak wrote:
> On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote:
> > On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote:
> > > The connector initialization in intel_dp_add_mst_connector() depends on
> > > the device pointer in connect
On 11/15/2024 1:26 PM, Easwar Hariharan wrote:
> Changes made with the following Coccinelle rules:
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * 1000)
> + secs_to_jiffies(C)
>
> @@ constant C; @@
>
> - msecs_to_jiffies(C * MSEC_PER_SEC)
> + secs_to_jiffies(C)
>
> Signed-off-by: Easwar Harih
Hi Easwar,
On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan
wrote:
>
> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL(msecs_to_jiffies(1*60*1000))
> /* 1 min */
> -#define SHARPSL_CHARGE_FINISH_TIME
> (msecs_to_jiffies(10*60*1000)) /* 10 min */
> -#define SHARPSL_BATCHK_TIME
Hi Easwar,
On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan
wrote:
>
> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = {
> - [SCTP_CONNTRACK_CLOSED] = 10 SECS,
> - [SCTP_CONNTRACK_COOKIE_WAIT]= 3 SECS,
> - [SCTP_CONNTRACK_COOKIE_ECHOED]
;>>
>>> ---
>>> Changes in v2:
>>> - EDITME: describe what is new in this series revision.
>>> - EDITME: use bulletpoints and terse descriptions.
>>> - Link to v1:
>>> https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linu
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c |
ps://lore.kernel.org/all/20241030-open-coded-timeouts-v3-0-9ba123fac...@linux.microsoft.com/
>> [2] https://lore.kernel.org/all/8734kngfni.fsf@somnus/
>>
>> ---
>> Changes in v2:
>> - EDITME: describe what is new in this series revision.
>> - EDI
cannot be
> bisected
Thanks for the quick response, indeed this patch is already in tip[1], I
pulled it in for testing the series but missed out on removing it before
sending. Please review v2 that excludes this:
https://lore.kernel.org/all/20241115-converge-secs-to-jiffies-v2-0-911fb7595...@linux.microsoft.com/
[1]: https://git.kernel.org/tip/b35108a51cf7bab58d7eace1267d7965978bcdb8
Thanks,
Easwar
bulletpoints and terse descriptions.
- Link to v1:
https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux.microsoft.com
---
Easwar Hariharan (21):
netfilter: conntrack: Cleanup timeout definitions
coccinelle: misc: Add secs_to_jiffies script
arm: pxa: Convert
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++
1 fil
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
samples/livepatch/livepatch-callbacks-busymod.c | 2 +-
sampl
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/gpu/drm/xe/xe_device.c | 2 +-
1 file changed, 1 inser
Suggested-by: Anna-Maria Behnsen
Signed-off-by: Easwar Hariharan
---
scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +
1 file changed, 21 insertions(+)
diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci
b/scripts/coccinelle/misc/secs_to_jiffies.cocci
new file mo
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
net/bluetooth/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/accel/habanalabs/common/device.c | 2 +-
drive
On Fri, Nov 15, 2024 at 10:49:42AM +0800, Su Hui wrote:
> Clang static checker(scan-build) warning:
> drivers/gpu/drm/xe/xe_hw_engine_group.c: line 134, column 2
> Argument to kfree() is a constant address (18446744073709551604), which
> is not memory allocated by malloc().
>
> kfree() can only ha
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/block/xen-blkback/blkback.c | 2 +-
1 file changed, 1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/pm8001/pm8001_init.c | 2 +-
1 file changed, 1 in
On 11/15/2024 1:22 PM, Easwar Hariharan wrote:
> secs_to_jiffies() is defined in hci_event.c and cannot be reused by
> other call sites. Hoist it into the core code to allow conversion of the
> ~1150 usages of msecs_to_jiffies() that either:
>
> - use a multiplier value of 1000 or equivalently MS
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c |
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
1 file changed, 1 ins
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/lpfc/lpfc_init.c | 18 +-
dr
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/pm8001/pm8001_init.c | 2 +-
1 file changed, 1 in
None of the higher order definitions are used anymore, so remove
definitions for minutes, hours, and days timeouts. Convert the seconds
denominated timeouts to secs_to_jiffies()
Signed-off-by: Easwar Hariharan
---
net/netfilter/nf_conntrack_proto_sctp.c | 21 -
1 file changed
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
fs/ceph/quota.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/wireless/ath/ath11k/debugfs.c | 2 +-
1 file chang
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
sound/usb/line6/toneport.c | 2 +-
1 file changed, 1 insertion
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
1 file changed, 1 ins
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
1 file chang
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +-
1 file change
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/block/xen-blkback/blkback.c | 2 +-
1 file changed, 1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
mm/kmemleak.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/arm/mach-pxa/sharpsl_pm.c | 6 +++---
1 file changed, 3 i
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
samples/livepatch/livepatch-callbacks-busymod.c | 2 +-
sampl
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++
1 fil
secs_to_jiffies() is defined in hci_event.c and cannot be reused by
other call sites. Hoist it into the core code to allow conversion of the
~1150 usages of msecs_to_jiffies() that either:
- use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or
- have timeouts that are denominated in s
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
fs/ceph/quota.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
sound/usb/line6/toneport.c | 2 +-
1 file changed, 1 insertion
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
net/bluetooth/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/scsi/lpfc/lpfc_init.c | 18 +-
dr
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/net/wireless/ath/ath11k/debugfs.c | 2 +-
1 file chang
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/gpu/drm/xe/xe_device.c | 2 +-
1 file changed, 1 inser
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +-
1 file change
None of the higher order definitions are used anymore, so remove
definitions for minutes, hours, and days timeouts. Convert the seconds
denominated timeouts to secs_to_jiffies()
Signed-off-by: Easwar Hariharan
---
net/netfilter/nf_conntrack_proto_sctp.c | 21 -
1 file changed
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
drivers/accel/habanalabs/common/device.c | 2 +-
drive
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
mm/kmemleak.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/s390/kernel/lgr.c | 3 ++-
arch/s390/kernel/time.c
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
1 file chang
Changes made with the following Coccinelle rules:
@@ constant C; @@
- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)
@@ constant C; @@
- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)
Signed-off-by: Easwar Hariharan
---
arch/arm/mach-pxa/sharpsl_pm.c | 6 +++---
1 file changed, 3 i
Suggested-by: Anna-Maria Behnsen
Signed-off-by: Easwar Hariharan
---
scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +
1 file changed, 21 insertions(+)
diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci
b/scripts/coccinelle/misc/secs_to_jiffies.cocci
new file mo
This is a series that follows up on my previous series to introduce
secs_to_jiffies() and convert a few initial users.[1] In the review for
that series, Anna-Maria requested converting other users with
Coccinelle. This is part 1 that converts users of msecs_to_jiffies()
that use the multiply patter
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge
accept const struct drm_display_mode argument. Change the mode_valid
callback of drm_connector to also accept const argument.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 -
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge
accept const struct drm_display_mode argument. Change the mode_valid_ctx
callback of drm_connector to also accept const argument.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
include/drm
Make hda_get_mode_idx() accept const struct drm_display_mode pointer
instead of just raw struct drm_display_mode. This is a preparation to
converting the mode_valid() callback of drm_connector to accept const
struct drm_display_mode argument.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/
Make amdgpu_dm_connector_mode_valid() duplicate the mode during the
test rather than modifying the passed mode. This is a preparation to
converting the mode_valid() callback of drm_connector to accept const
struct drm_display_mode argument.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/amd
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge
accept const struct drm_display_mode argument. Change the mode_valid
callback of drm_encoder_slave to also accept const argument.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
drivers/gpu/d
ase-commit: 7d2faa8dbb7055a115fe0cd6068d7090094a573d
change-id: 20241115-drm-connector-mode-valid-const-ae3db0ef6cb7
Best regards,
--
Dmitry Baryshkov
On Fri, Nov 15, 2024 at 06:41:57PM +0200, Imre Deak wrote:
> Atm when the connector is added to the drm_mode_config::connector_list,
> the connector may not be fully initialized yet. This is not a problem
> for user space, which will see the connector only after it's registered
> later, it could be
On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote:
> On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote:
> > The connector initialization in intel_dp_add_mst_connector() depends on
> > the device pointer in connector to be valid, at least by connector
> > debug printing. The devic
On 11/15/2024 3:54 AM, Dmitry Baryshkov wrote:
> Hello Akhil,
>
> On Thu, 14 Nov 2024 at 20:50, Akhil P Oommen wrote:
>>
>> On 11/1/2024 9:54 PM, Akhil P Oommen wrote:
>>> On 10/25/2024 11:58 AM, Dmitry Baryshkov wrote:
On Thu, Oct 24, 2024 at 12:56:58AM +0530, Akhil P Oommen wrote:
> On
On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote:
> The connector initialization in intel_dp_add_mst_connector() depends on
> the device pointer in connector to be valid, at least by connector
> debug printing. The device pointer is initialized by drm_connector_init(),
> however that funct
On Fri, Nov 15, 2024 at 06:41:58PM +0200, Imre Deak wrote:
> After a connector is added to the drm_mode_config::connector_list, it's
> visible to any in-kernel users looking up connectors via the above list.
> Make sure that the connector is properly initialized before such
> look-ups.
>
> Signed-
On Fri, 15 Nov 2024 at 14:25, Stefan Ekenberg wrote:
>
> On 11/15/24 09:16, Dmitry Baryshkov wrote:
> > On Wed, Nov 13, 2024 at 08:38:11AM +0100, Stefan Ekenberg wrote:
> >> AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1
> >> while updating Audio InfoFrame information and then
On Fri, 15 Nov 2024 at 19:54, Akhil P Oommen wrote:
>
> On 11/15/2024 3:54 AM, Dmitry Baryshkov wrote:
> > Hello Akhil,
> >
> > On Thu, 14 Nov 2024 at 20:50, Akhil P Oommen
> > wrote:
> >>
> >> On 11/1/2024 9:54 PM, Akhil P Oommen wrote:
> >>> On 10/25/2024 11:58 AM, Dmitry Baryshkov wrote:
> >>
On Thu, Nov 14, 2024 at 09:38:43AM +0100, Christian König wrote:
> Am 13.11.24 um 16:34 schrieb Matthew Brost:
> > > > > > > Now the ordering works inherently in dma-resv and the scheduler.
> > > > > > > e.g. No
> > > > > > > need to track the last completion fences explictly in preempt
> > > > >
This includes both DRM objects created to support queues, groups and heaps,
and also objects whose pages are shared between the GPU and the MCU.
However, this doesn't include objects that hold the firmware's binary
regions, since these aren't owned by a render context and are allocated
only once a
The pull request you sent on Sat, 16 Nov 2024 04:43:28 +1000:
> https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-11-16
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f868cd2517763c66783c6000b29d97f0b966b311
Thank you!
--
Deet-doot-dot, I am a bot.
h
Hi Linus,
Final week of fixes, lots of small amdgpu fixes, some i915 and xe
fixes, the nouveau changes fix a recent regression and some laptop
panel black screens, then a couple of other misc ones. It's probably a
little busier than I'd like, but each fix seems fine.
Dave.
drm-fixes-2024-11-16:
On Wed, Nov 13, 2024 at 12:42:35PM +0100, Christian König wrote:
> Am 13.11.24 um 11:44 schrieb Thomas Hellström:
> > On Wed, 2024-11-13 at 09:37 +0100, Christian König wrote:
> > > Am 12.11.24 um 17:33 schrieb Thomas Hellström:
> > > > [SNIP]
> > > > > > > This has been extensively discussed alrea
'struct pci_device_id' is not modified in this driver.
Constifying this structure moves some data to a read-only section, so
increase overall security.
On a x86_64, with allmodconfig:
Before:
==
textdata bss dec hex filename
11984 28672 44 407009efc drivers/g
'struct i2c_device_id' is not modified in this driver.
Constifying this structure moves some data to a read-only section, so
increase overall security.
On a x86_64, with allmodconfig:
Before:
==
textdata bss dec hex filename
12136 822 0 12958329e drivers/g
On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2024-11-08 23:05:18)
> > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote:
> > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49)
> > > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote:
Hi Dave, Simona,
Fixes for 6.13.
The following changes since commit 35a6e15aabc016a241379c09d6c367519709b95b:
Merge tag 'drm-etnaviv-next-2024-11-07' of
https://git.pengutronix.de/git/lst/linux into drm-next (2024-11-08 12:32:06
+1000)
are available in the Git repository at:
https://gitl
'struct i2c_device_id' is not modified in this driver.
Constifying this structure moves some data to a read-only section, so
increase overall security.
On a x86_64, with allmodconfig:
Before:
==
textdata bss dec hex filename
12136 822 0 12958329e drivers/g
After a connector is added to the drm_mode_config::connector_list, it's
visible to any in-kernel users looking up connectors via the above list.
Make sure that the connector is properly initialized before such
look-ups.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 2
The connector initialization in intel_dp_add_mst_connector() depends on
the device pointer in connector to be valid, at least by connector
debug printing. The device pointer is initialized by drm_connector_init(),
however that function also exposes the connector to in-kernel users,
which can't be d
Atm when the connector is added to the drm_mode_config::connector_list,
the connector may not be fully initialized yet. This is not a problem
for user space, which will see the connector only after it's registered
later, it could be a problem for in-kernel users looking up connectors
via the above
After an error during adding an MST connector the MST port and the
intel_connector object could be leaked, fix this up.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i
On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote:
> Am 15.11.24 um 16:27 schrieb Arnd Bergmann:
>>
>> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB
>> tristate
>> depends on DRM
>> select DRM_KMS_HELPER if DRM_FBDEV_EMULATION
>> -select FB_CORE if DRM_FBDEV_EMULATION
>
> Th
From: Arnd Bergmann
The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB,
but there are now configurations that have code calling into fb_core
as built-in even though the client_lib itself is a loadable module:
x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function
`d
The clock reset must be used when the VOP is configured. Skipping it can
put the VOP in an unknown state where the HDMI signal is either lost or
not matching the selected mode.
This adds support for rk3588(s) based SoCs.
Changes since v3:
- Rebased on drm-misc-next
- Reword first patch subject
-
This adds the needed clock resets for all rk3588(s) based SOCs.
Signed-off-by: Detlev Casanova
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
b/arch/arm64/boot/dts/rockchip/rk3588-
At the end of initialization, each VP clock needs to be reset before
they can be used.
Failing to do so can put the VOP in an undefined state where the
generated HDMI signal is either lost or not matching the selected mode.
This issue can be reproduced by switching modes multiple times.
Depending
Add the documentation for VOP2 video ports reset clocks.
One reset can be set per video port.
Reviewed-by: Conor Dooley
Signed-off-by: Detlev Casanova
---
.../display/rockchip/rockchip-vop2.yaml | 40 +++
1 file changed, 40 insertions(+)
diff --git
a/Documentation/device
DSI operation mode is configured to support burst mode, but bridge
driver does not correctly implement it. This results in bad LVDS timings
when bridge is connected to DSI host that sets higher transmission rate
on DSI link, than indicated by CRTC pixel clock.
TC358775 power up sequence is still b
Current tc358775 bridge driver implementation assumes that DSI clock
is used as a source for LVDS pixel clock. Moreover, clock divider
PCLKDIV has a hard-coded value. This means that driver expects DSI
clock to always match a panel pixel clock. With such assumption, LVDS
pixel clock is configured t
1 - 100 of 173 matches
Mail list logo