Re: [PATCH 19/22] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Dan Carpenter
On Fri, Nov 15, 2024 at 09:22:49PM +, Easwar Hariharan wrote: > diff --git a/samples/livepatch/livepatch-callbacks-busymod.c > b/samples/livepatch/livepatch-callbacks-busymod.c > index > 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba > 100644 > --- a/sampl

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-15 Thread Yu Kuai
Hi, 在 2024/11/13 23:17, Chuck Lever 写道: On Mon, Nov 11, 2024 at 11:20:17PM +0800, yangerkun wrote: 在 2024/11/11 22:39, Chuck Lever III 写道: On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: I'm in the cc list ,so I assume you saw my set, then I don't know why you're ignoring my concerns. 1) nex

Re: [PATCH 4/4] drm/i915/dp_mst: Fix error handling while adding a connector

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 06:41:59PM +0200, Imre Deak wrote: > After an error during adding an MST connector the MST port and the > intel_connector object could be leaked, fix this up. > > Signed-off-by: Imre Deak Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 1

[PATCH v2 04/21] s390: kernel: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/s390/kernel/lgr.c | 3 ++- arch/s390/kernel/time.c

Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-15 Thread Christophe JAILLET
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > Suggested-by: Anna-Maria Behnsen > Signed-off-by: Easwar Hariharan > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
rnel.org/all/8734kngfni.fsf@somnus/ > > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: > https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux

[PATCH v8 3/5] Documentation/gpu: Clarify drm memory stats definition

2024-11-15 Thread Yunxiang Li
Define how to handle buffers with multiple possible placement so we don't get incompatible implementations. Callout the resident requirement for drm-purgeable- explicitly. Remove the requirement for there to be only drm-memory- or only drm-resident-, it's not what's implemented and having both is b

[PATCH v8 2/5] drm: make drm-active- stats optional

2024-11-15 Thread Yunxiang Li
When memory stats is generated fresh everytime by going though all the BOs, their active information is quite easy to get. But if the stats are tracked with BO's state this becomes harder since the job scheduling part doesn't really deal with individual buffers. Make drm-active- optional to enable

[PATCH v8 1/5] drm: add drm_memory_stats_is_zero

2024-11-15 Thread Yunxiang Li
Add a helper to check if the memory stats is zero, this will be used to check for memory accounting errors. Signed-off-by: Yunxiang Li Reviewed-by: Christian König CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_file.c | 10 ++ include/drm/drm_file.h | 1 + 2 files chan

Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

2024-11-15 Thread Easwar Hariharan
On 11/15/2024 2:34 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan > wrote: >> >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> -[SCTP_CONNTRACK_CLOSED] = 10 SECS, >> -[SCTP_CONNTRACK_COOKIE_WAIT]

Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
On 11/15/2024 2:38 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan > wrote: >> >> -#define SHARPSL_CHARGE_ON_TIME_INTERVAL >> (msecs_to_jiffies(1*60*1000)) /* 1 min */ >> -#define SHARPSL_CHARGE_FINISH_TIME >> (msecs_to_jiffi

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Thomas Gleixner
On Fri, Nov 15 2024 at 14:15, Easwar Hariharan wrote: > On 11/15/2024 1:41 PM, Jeff Johnson wrote: >> >> How do you expect this series to land since it overlaps a large number of >> maintainer trees? Do you have a maintainer who has volunteered to take the >> series and the maintainers should just

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 10:30:12PM +0200, Imre Deak wrote: > On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote: > > On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > > > The connector initialization in intel_dp_add_mst_connector() depends on > > > the device pointer in connect

Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
On 11/15/2024 1:26 PM, Easwar Hariharan wrote: > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Harih

Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Stephen Rothwell
Hi Easwar, On Fri, 15 Nov 2024 21:22:33 + Easwar Hariharan wrote: > > -#define SHARPSL_CHARGE_ON_TIME_INTERVAL(msecs_to_jiffies(1*60*1000)) > /* 1 min */ > -#define SHARPSL_CHARGE_FINISH_TIME > (msecs_to_jiffies(10*60*1000)) /* 10 min */ > -#define SHARPSL_BATCHK_TIME

Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

2024-11-15 Thread Stephen Rothwell
Hi Easwar, On Fri, 15 Nov 2024 21:26:18 + Easwar Hariharan wrote: > > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT]= 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED]

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
;>> >>> --- >>> Changes in v2: >>> - EDITME: describe what is new in this series revision. >>> - EDITME: use bulletpoints and terse descriptions. >>> - Link to v1: >>> https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linu

[PATCH 21/22] nfp: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1

[PATCH v2 17/21] staging: vc04_services: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c |

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
ps://lore.kernel.org/all/20241030-open-coded-timeouts-v3-0-9ba123fac...@linux.microsoft.com/ >> [2] https://lore.kernel.org/all/8734kngfni.fsf@somnus/ >> >> --- >> Changes in v2: >> - EDITME: describe what is new in this series revision. >> - EDI

Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
cannot be > bisected Thanks for the quick response, indeed this patch is already in tip[1], I pulled it in for testing the series but missed out on removing it before sending. Please review v2 that excludes this: https://lore.kernel.org/all/20241115-converge-secs-to-jiffies-v2-0-911fb7595...@linux.microsoft.com/ [1]: https://git.kernel.org/tip/b35108a51cf7bab58d7eace1267d7965978bcdb8 Thanks, Easwar

[PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux.microsoft.com --- Easwar Hariharan (21): netfilter: conntrack: Cleanup timeout definitions coccinelle: misc: Add secs_to_jiffies script arm: pxa: Convert

[PATCH v2 14/21] gve: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++ 1 fil

[PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- samples/livepatch/livepatch-callbacks-busymod.c | 2 +- sampl

[PATCH v2 08/21] drm/xe: Convert timeout to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 inser

[PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script

2024-11-15 Thread Easwar Hariharan
Suggested-by: Anna-Maria Behnsen Signed-off-by: Easwar Hariharan --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + 1 file changed, 21 insertions(+) diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mo

[PATCH v2 16/21] Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 07/21] accel/habanalabs: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/accel/habanalabs/common/device.c | 2 +- drive

Re: [PATCH v2] drm/xe/hw_engine_group: Fix bad free in xe_hw_engine_setup_groups()

2024-11-15 Thread Matthew Brost
On Fri, Nov 15, 2024 at 10:49:42AM +0800, Su Hui wrote: > Clang static checker(scan-build) warning: > drivers/gpu/drm/xe/xe_hw_engine_group.c: line 134, column 2 > Argument to kfree() is a constant address (18446744073709551604), which > is not memory allocated by malloc(). > > kfree() can only ha

[PATCH 13/22] xen/blkback: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1

[PATCH 12/22] scsi: pm8001: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 file changed, 1 in

Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()

2024-11-15 Thread Jeff Johnson
On 11/15/2024 1:22 PM, Easwar Hariharan wrote: > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > > - use a multiplier value of 1000 or equivalently MS

[PATCH 17/22] staging: vc04_services: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c |

[PATCH 11/22] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 file changed, 1 ins

[PATCH v2 10/21] scsi: lpfc: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/lpfc/lpfc_init.c | 18 +- dr

[PATCH v2 21/21] nfp: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1

[PATCH v2 12/21] scsi: pm8001: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/pm8001/pm8001_init.c | 2 +- 1 file changed, 1 in

[PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions

2024-11-15 Thread Easwar Hariharan
None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan --- net/netfilter/nf_conntrack_proto_sctp.c | 21 - 1 file changed

[PATCH v2 18/21] ceph: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- fs/ceph/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- 1 file chang

[PATCH v2 20/21] ALSA: line6: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 11/21] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 file changed, 1 ins

[PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file chang

[PATCH v2 09/21] drm/etnaviv: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +- 1 file change

[PATCH v2 13/21] xen/blkback: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/block/xen-blkback/blkback.c | 2 +- 1 file changed, 1

[PATCH v2 06/21] mm: kmemleak: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- mm/kmemleak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- 1 file changed, 3 i

[PATCH 19/22] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- samples/livepatch/livepatch-callbacks-busymod.c | 2 +- sampl

[PATCH 14/22] gve: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++ 1 fil

[PATCH 22/22] jiffies: Define secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
secs_to_jiffies() is defined in hci_event.c and cannot be reused by other call sites. Hoist it into the core code to allow conversion of the ~1150 usages of msecs_to_jiffies() that either: - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or - have timeouts that are denominated in s

[PATCH 18/22] ceph: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- fs/ceph/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 20/22] ALSA: line6: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion

[PATCH 16/22] Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 10/22] scsi: lpfc: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/scsi/lpfc/lpfc_init.c | 18 +- dr

[PATCH 15/22] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- 1 file chang

[PATCH 08/22] drm/xe: Convert timeout to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/xe/xe_device.c | 2 +- 1 file changed, 1 inser

[PATCH 09/22] drm/etnaviv: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +- 1 file change

[PATCH 01/22] netfilter: conntrack: Cleanup timeout definitions

2024-11-15 Thread Easwar Hariharan
None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan --- net/netfilter/nf_conntrack_proto_sctp.c | 21 - 1 file changed

[PATCH 07/22] accel/habanalabs: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- drivers/accel/habanalabs/common/device.c | 2 +- drive

[PATCH 06/22] mm: kmemleak: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- mm/kmemleak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH 04/22] s390: kernel: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/s390/kernel/lgr.c | 3 ++- arch/s390/kernel/time.c

[PATCH 05/22] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/powerpc/platforms/pseries/papr_scm.c | 2 +- 1 file chang

[PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan --- arch/arm/mach-pxa/sharpsl_pm.c | 6 +++--- 1 file changed, 3 i

[PATCH 02/22] coccinelle: misc: Add secs_to_jiffies script

2024-11-15 Thread Easwar Hariharan
Suggested-by: Anna-Maria Behnsen Signed-off-by: Easwar Hariharan --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 + 1 file changed, 21 insertions(+) diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mo

[PATCH 00/22] Converge on using secs_to_jiffies()

2024-11-15 Thread Easwar Hariharan
This is a series that follows up on my previous series to introduce secs_to_jiffies() and convert a few initial users.[1] In the review for that series, Anna-Maria requested converting other users with Coccinelle. This is part 1 that converts users of msecs_to_jiffies() that use the multiply patter

[PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-15 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 8 -

[PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode

2024-11-15 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid_ctx callback of drm_connector to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- include/drm

[PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

2024-11-15 Thread Dmitry Baryshkov
Make hda_get_mode_idx() accept const struct drm_display_mode pointer instead of just raw struct drm_display_mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

[PATCH 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

2024-11-15 Thread Dmitry Baryshkov
Make amdgpu_dm_connector_mode_valid() duplicate the mode during the test rather than modifying the passed mode. This is a preparation to converting the mode_valid() callback of drm_connector to accept const struct drm_display_mode argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd

[PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-15 Thread Dmitry Baryshkov
The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge accept const struct drm_display_mode argument. Change the mode_valid callback of drm_encoder_slave to also accept const argument. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- drivers/gpu/d

[PATCH 0/5] drm/connector: make mode_valid() callback accept const mode pointer

2024-11-15 Thread Dmitry Baryshkov
ase-commit: 7d2faa8dbb7055a115fe0cd6068d7090094a573d change-id: 20241115-drm-connector-mode-valid-const-ae3db0ef6cb7 Best regards, -- Dmitry Baryshkov

Re: [PATCH 2/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 06:41:57PM +0200, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for user space, which will see the connector only after it's registered > later, it could be

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Imre Deak
On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote: > On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > > The connector initialization in intel_dp_add_mst_connector() depends on > > the device pointer in connector to be valid, at least by connector > > debug printing. The devic

Re: [PATCH v2 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-11-15 Thread Akhil P Oommen
On 11/15/2024 3:54 AM, Dmitry Baryshkov wrote: > Hello Akhil, > > On Thu, 14 Nov 2024 at 20:50, Akhil P Oommen wrote: >> >> On 11/1/2024 9:54 PM, Akhil P Oommen wrote: >>> On 10/25/2024 11:58 AM, Dmitry Baryshkov wrote: On Thu, Oct 24, 2024 at 12:56:58AM +0530, Akhil P Oommen wrote: > On

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > The connector initialization in intel_dp_add_mst_connector() depends on > the device pointer in connector to be valid, at least by connector > debug printing. The device pointer is initialized by drm_connector_init(), > however that funct

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 06:41:58PM +0200, Imre Deak wrote: > After a connector is added to the drm_mode_config::connector_list, it's > visible to any in-kernel users looking up connectors via the above list. > Make sure that the connector is properly initialized before such > look-ups. > > Signed-

Re: [PATCH] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

2024-11-15 Thread Dmitry Baryshkov
On Fri, 15 Nov 2024 at 14:25, Stefan Ekenberg wrote: > > On 11/15/24 09:16, Dmitry Baryshkov wrote: > > On Wed, Nov 13, 2024 at 08:38:11AM +0100, Stefan Ekenberg wrote: > >> AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1 > >> while updating Audio InfoFrame information and then

Re: [PATCH v2 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-11-15 Thread Dmitry Baryshkov
On Fri, 15 Nov 2024 at 19:54, Akhil P Oommen wrote: > > On 11/15/2024 3:54 AM, Dmitry Baryshkov wrote: > > Hello Akhil, > > > > On Thu, 14 Nov 2024 at 20:50, Akhil P Oommen > > wrote: > >> > >> On 11/1/2024 9:54 PM, Akhil P Oommen wrote: > >>> On 10/25/2024 11:58 AM, Dmitry Baryshkov wrote: > >>

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-15 Thread Matthew Brost
On Thu, Nov 14, 2024 at 09:38:43AM +0100, Christian König wrote: > Am 13.11.24 um 16:34 schrieb Matthew Brost: > > > > > > > Now the ordering works inherently in dma-resv and the scheduler. > > > > > > > e.g. No > > > > > > > need to track the last completion fences explictly in preempt > > > > >

[PATCH v2] drm/panthor: register size of internal objects through fdinfo

2024-11-15 Thread Adrián Larumbe
This includes both DRM objects created to support queues, groups and heaps, and also objects whose pages are shared between the GPU and the MCU. However, this doesn't include objects that hold the firmware's binary regions, since these aren't owned by a render context and are allocated only once a

Re: [git pull] drm fixes for 6.12-rc8

2024-11-15 Thread pr-tracker-bot
The pull request you sent on Sat, 16 Nov 2024 04:43:28 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-11-16 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f868cd2517763c66783c6000b29d97f0b966b311 Thank you! -- Deet-doot-dot, I am a bot. h

[git pull] drm fixes for 6.12-rc8

2024-11-15 Thread Dave Airlie
Hi Linus, Final week of fixes, lots of small amdgpu fixes, some i915 and xe fixes, the nouveau changes fix a recent regression and some laptop panel black screens, then a couple of other misc ones. It's probably a little busier than I'd like, but each fix seems fine. Dave. drm-fixes-2024-11-16:

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-15 Thread Matthew Brost
On Wed, Nov 13, 2024 at 12:42:35PM +0100, Christian König wrote: > Am 13.11.24 um 11:44 schrieb Thomas Hellström: > > On Wed, 2024-11-13 at 09:37 +0100, Christian König wrote: > > > Am 12.11.24 um 17:33 schrieb Thomas Hellström: > > > > [SNIP] > > > > > > > This has been extensively discussed alrea

[PATCH] drm/radeon: Constify struct pci_device_id

2024-11-15 Thread Christophe JAILLET
'struct pci_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: == textdata bss dec hex filename 11984 28672 44 407009efc drivers/g

[PATCH v2] drm/i2c: tda9950: Constify struct i2c_device_id

2024-11-15 Thread Christophe JAILLET
'struct i2c_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: == textdata bss dec hex filename 12136 822 0 12958329e drivers/g

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-15 Thread Dmitry Baryshkov
On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote:

[pull] amdgpu, amdkfd drm-next-6.13

2024-11-15 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.13. The following changes since commit 35a6e15aabc016a241379c09d6c367519709b95b: Merge tag 'drm-etnaviv-next-2024-11-07' of https://git.pengutronix.de/git/lst/linux into drm-next (2024-11-08 12:32:06 +1000) are available in the Git repository at: https://gitl

[PATCH] drm/i2c: tda9950: Constify struct i2c_device_id

2024-11-15 Thread Christophe JAILLET
'struct i2c_device_id' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: == textdata bss dec hex filename 12136 822 0 12958329e drivers/g

[PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-15 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2

[PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Imre Deak
The connector initialization in intel_dp_add_mst_connector() depends on the device pointer in connector to be valid, at least by connector debug printing. The device pointer is initialized by drm_connector_init(), however that function also exposes the connector to in-kernel users, which can't be d

[PATCH 2/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-15 Thread Imre Deak
Atm when the connector is added to the drm_mode_config::connector_list, the connector may not be fully initialized yet. This is not a problem for user space, which will see the connector only after it's registered later, it could be a problem for in-kernel users looking up connectors via the above

[PATCH 4/4] drm/i915/dp_mst: Fix error handling while adding a connector

2024-11-15 Thread Imre Deak
After an error during adding an MST connector the MST port and the intel_connector object could be leaked, fix this up. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i

Re: [PATCH] drm: rework FB_CORE dependency

2024-11-15 Thread Arnd Bergmann
On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote: > Am 15.11.24 um 16:27 schrieb Arnd Bergmann: >> >> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB >> tristate >> depends on DRM >> select DRM_KMS_HELPER if DRM_FBDEV_EMULATION >> -select FB_CORE if DRM_FBDEV_EMULATION > > Th

[PATCH] [v2] drm: rework FB_CORE dependency

2024-11-15 Thread Arnd Bergmann
From: Arnd Bergmann The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, but there are now configurations that have code calling into fb_core as built-in even though the client_lib itself is a loadable module: x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `d

[PATCH v4 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-15 Thread Detlev Casanova
The clock reset must be used when the VOP is configured. Skipping it can put the VOP in an unknown state where the HDMI signal is either lost or not matching the selected mode. This adds support for rk3588(s) based SoCs. Changes since v3: - Rebased on drm-misc-next - Reword first patch subject -

[PATCH v4 3/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-11-15 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-

[PATCH v4 2/3] drm/rockchip: vop2: Add clock resets support

2024-11-15 Thread Detlev Casanova
At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. This issue can be reproduced by switching modes multiple times. Depending

[PATCH v4 1/3] dt-bindings: display: vop2: Add VP clock resets

2024-11-15 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Reviewed-by: Conor Dooley Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation/device

[PATCH 0/1] drm/bridge: tc358775: Remove burst mode support

2024-11-15 Thread Daniel Semkowicz
DSI operation mode is configured to support burst mode, but bridge driver does not correctly implement it. This results in bad LVDS timings when bridge is connected to DSI host that sets higher transmission rate on DSI link, than indicated by CRTC pixel clock. TC358775 power up sequence is still b

[PATCH 1/1] drm/bridge: tc358775: Remove burst mode support

2024-11-15 Thread Daniel Semkowicz
Current tc358775 bridge driver implementation assumes that DSI clock is used as a source for LVDS pixel clock. Moreover, clock divider PCLKDIV has a hard-coded value. This means that driver expects DSI clock to always match a panel pixel clock. With such assumption, LVDS pixel clock is configured t

  1   2   >