Re: [PATCH v2] drm/syncobj: ensure progress for syncobj queries

2024-11-04 Thread Christian König
Am 04.11.24 um 22:32 schrieb Chia-I Wu: On Tue, Oct 22, 2024 at 10:24 AM Chia-I Wu wrote: On Tue, Oct 22, 2024 at 9:53 AM Christian König wrote: Am 22.10.24 um 18:18 schrieb Chia-I Wu: Userspace might poll a syncobj with the query ioctl. Call dma_fence_enable_sw_signaling to ensure dma_fen

Re: [PATCH v4] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-11-04 Thread Lucas De Marchi
On Mon, Nov 04, 2024 at 12:04:30PM -0600, Lucas De Marchi wrote: On Sat, Nov 02, 2024 at 11:22:03AM +0900, Gyeyoung Baek wrote: if CONFIG_DRM_USE_DYNAMIC_DEBUG is set, 'drm_dbg' function is replaced with '__dynamic_func_call_cls', which is replaced with a do while statement. so in the previous c

Re: [PATCH V3 drm-dp 3/4] drm/hisilicon/hibmc: add dp hw moduel in hibmc

2024-11-04 Thread Yongbang Shi
On Fri, Nov 01, 2024 at 06:50:27PM +0800, Yongbang Shi wrote: From: baihan li Build a dp level that hibmc driver can enable dp by calling their functions. Signed-off-by: baihan li Signed-off-by: yongbang shi --- ChangeLog: v2 -> v3: - fix build errors reported by kernel test robot C

Re: [PATCH 0/1] On DRM -> stable process

2024-11-04 Thread Greg Kroah-Hartman
On Mon, Nov 04, 2024 at 05:55:28PM +0300, Fedor Pchelkin wrote: > On Tue, 29. Oct 18:12, Fedor Pchelkin wrote: > > On Tue, 29. Oct 10:20, Sasha Levin wrote: > > > On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: > > > > BTW, a question to the stable-team: what Git magic (3-way-merge?

Re: [PATCH] drm: Use of_property_present() for non-boolean properties

2024-11-04 Thread Dragan Simic
Hello Rob, On 2024-11-04 20:06, Rob Herring (Arm) wrote: The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) Looking good to me, thanks for the patch! Reviewed-by:

Re: [PATCH V3 drm-dp 4/4] drm/hisilicon/hibmc: add dp module in hibmc

2024-11-04 Thread Yongbang Shi
I will accept your advices in all the patchs. Thanks, Baihan. On Fri, Nov 01, 2024 at 06:50:28PM +0800, Yongbang Shi wrote: From: baihan li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. Signed-off-by: baihan li Signed-off-by: yongbang shi --

[PATCH 7/7] drm: panel: nv3052c: Add YLM-LBV0400001X-V1 panel

2024-11-04 Thread Hironori KIKUCHI
The YLM-LBV041X-V1 panel is a display panel used in the Anbernic RG40XX series (H and V), a handheld gaming device from Anbernic. It is 4.00 inches in size (diagonally) with a resolution of 640x480. It's similar to YLM-LBV0345001H-V2, but different in size and its init-sequence. So add entry f

[PATCH 6/7] dt-bindings: display: panel: Add YLM-LBV0400001X-V1 panel

2024-11-04 Thread Hironori KIKUCHI
The YLM-LBV041X-V1 panel is a display panel used in the Anbernic RG40XX series (H and V), a handheld gaming device from Anbernic. It is 4.00 inches in size (diagonally) with a resolution of 640x480. Signed-off-by: Hironori KIKUCHI --- .../panel/anbernic,ylm-lbv041x-v1.yaml| 65 ++

[PATCH 4/7] dt-bindings: display: panel: Add YLM-LBV0345001H-V2 panel

2024-11-04 Thread Hironori KIKUCHI
The YLM-LBV0345001H-V2 panel is a display panel used in the recent revision of Anbernic RG35XX Plus, a handheld gaming device from Anbernic. It is 3.45 inches in size (diagonally) with a resolution of 640x480. Signed-off-by: Hironori KIKUCHI --- .../panel/anbernic,ylm-lbv0345001h-v2.yaml| 68

[PATCH 5/7] drm: panel: nv3052c: Add YLM-LBV0345001H-V2 panel

2024-11-04 Thread Hironori KIKUCHI
The YLM-LBV0345001H-V2 panel is a display panel used in the recent revision of Anbernic RG35XX Plus, a handheld gaming device from Anbernic. It is 3.45 inches in size (diagonally) with a resolution of 640x480. It has the same interface (pins and connector) as WL-355608-A8, the panel of the former

[PATCH 0/7] drm/panel: nv3052c: Fix Anbernic RG35XX panel support (and add RG40XX panel)

2024-11-04 Thread Hironori KIKUCHI
Fix support for panels used in the Anbernic RG35XX series. We previously decided to use the integrated vendor and device name for the panel, but the recent revision of the RG35XX series has a different panel that is not compatible with the old panel. Unfortunately, these two RG35XX models have t

[PATCH 3/7] drm: panel: nv3052c: Fix size of WL-355608-A8

2024-11-04 Thread Hironori KIKUCHI
It is 3.45 inches in size (diagonally). Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c i

[PATCH 2/7] drm: panel: nv3052c: Rename rg35xx-plus-panel back to WL-355608-A8

2024-11-04 Thread Hironori KIKUCHI
A panel assembly is changed in the recent revision of Anbernic RG35XX Plus, so the `anbernic,rg35xx-plus-panel` identifier is neither suitable nor unique for the panel anymore. Fortunately, the panel can be distinguished by a label printed on the FPC cable, so use the label "WL-355608-A8" as an id

[PATCH 1/7] dt-bindings: display: panel: Rename rg35xx-plus-panel back to WL-355608-A8

2024-11-04 Thread Hironori KIKUCHI
A panel assembly is changed in the recent revision of Anbernic RG35XX Plus, so the `anbernic,rg35xx-plus-panel` identifier is neither suitable nor unique for the panel anymore. Fortunately, the panel can be distinguished by a label printed on the FPC cable, so use the label "WL-355608-A8" as an id

Re: [PATCH v1 10/10] uapi: linux: add mediatek isp_7x camsys user api

2024-11-04 Thread 胡俊光

Re: [PATCH bpf-next 2/2] bpf: Switch bpf arena to use drm_mm instead of maple_tree

2024-11-04 Thread kernel test robot
/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20241101235453.63380-3-alexei.starovoitov%40gmail.com patch subject: [PATCH bpf-next 2/2] bpf: Switch bpf arena to use drm_mm instead of maple_tree config: i386-randconfig-003-20241104 (https://download.01.org/0day-ci

Re: [PATCH v2 3/3] iommu: Add a kdoc to iommu_unmap()

2024-11-04 Thread kernel test robot
Hi Jason, kernel test robot noticed the following build warnings: [auto build test WARNING on 8e929cb546ee42c9a61d24fae60605e9e3192354] url: https://github.com/intel-lab-lkp/linux/commits/Jason-Gunthorpe/iommu-io-pgtable-arm-Remove-split-on-unmap-behavior/20241105-014356 base: 8e929cb546ee

Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

2024-11-04 Thread 胡俊光

UAPI Question: State of Lease after DRM Master is Lost/Regained

2024-11-04 Thread Eduardo Hopperdietzel
Hello, I have two questions related to leases that I couldn't find answers to in the kernel documentation: 1. Does drmModeRevokeLease() close the previously obtained file descriptor? 2. If a lease is created and then the DRM master is lost and then regained, is the lease still valid? If not, are

Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

2024-11-04 Thread 胡俊光

linux-next: manual merge of the amdgpu tree with the drm tree

2024-11-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_job.c between commit: b2ef808786d9 ("drm/sched: add optional errno to drm_sched_start()") from the drm tree and commit: 35984fd4a093 ("drm/amdgpu: add ring reset messages") from the

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Martin K. Petersen
Thomas, > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. Enforce this by marking the argument > as const. > > As there are not many callback implementers perform this change > throughout the tree at once. For scsi: Acked-by: Martin K. Petersen

Re: [PATCH v1] drm/i915/guc: Flush ct receive tasklet during reset preparation

2024-11-04 Thread Daniele Ceraolo Spurio
On 10/30/2024 3:38 PM, Zhanjun Dong wrote: GuC to host communication is interrupt driven, the handling has 3 parts: interrupt context, tasklet and request queue worker. During GuC reset prepare, interrupt is disabled before destroy contexts steps start. The IRQ and worker flushed to finish in

[PATCH] drm/panthor: Be stricter about IO mapping flags

2024-11-04 Thread Jann Horn
M_WRITE | VM_EXEC))) return -EINVAL; + vm_flags_clear(vma, VM_MAYWRITE); break; --- base-commit: d78f0ee0406803cda8801fd5201746ccf89e5e4a change-id: 20241104-panthor-flush-page-fixes-fe4202bb18c0 -- Jann Horn

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 07:59:10PM +0100, Thomas Hellström wrote: > On Mon, 2024-11-04 at 09:21 -0800, Matthew Brost wrote: > > On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > > > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > > > > Continued review. > > > > > >

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Thu, Oct 31, 2024 at 07:58:45PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > This patch introduces support for GPU Shared Virtual Memory (SVM) in > > the > > Direct Rendering Manager (DRM) subsystem. SVM allows for seamless > > sharing of memory be

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Rodrigo Vivi
On Mon, Nov 04, 2024 at 01:30:41PM -0800, Matthew Brost wrote: > On Mon, Nov 04, 2024 at 08:47:01PM +0100, Christian König wrote: > > Am 01.11.24 um 00:43 schrieb Matthew Brost: > > > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > > > Non-contiguous VRAM cannot easily be mapped

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 08:28:34PM +0100, Christian König wrote: > Am 04.11.24 um 18:34 schrieb Rodrigo Vivi: > > On Thu, Oct 31, 2024 at 04:43:19PM -0700, Matthew Brost wrote: > > > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > > > Non-contiguous VRAM cannot easily be mapped i

[PATCH v2] drm/i915/guc: Flush ct receive tasklet during reset preparation

2024-11-04 Thread Zhanjun Dong
GuC to host communication is interrupt driven, the handling has 3 parts: interrupt context, tasklet and request queue worker. During GuC reset prepare, interrupt is disabled before destroy contexts steps start. The IRQ and worker are flushed to finish any outstanding in-progress message handling. B

Re: [PATCH v2] drm/syncobj: ensure progress for syncobj queries

2024-11-04 Thread Chia-I Wu
On Tue, Oct 22, 2024 at 10:24 AM Chia-I Wu wrote: > > On Tue, Oct 22, 2024 at 9:53 AM Christian König > wrote: > > > > Am 22.10.24 um 18:18 schrieb Chia-I Wu: > > > Userspace might poll a syncobj with the query ioctl. Call > > > dma_fence_enable_sw_signaling to ensure dma_fence_is_signaled retur

Re: [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests

2024-11-04 Thread Rodrigo Vivi
On Sun, Nov 03, 2024 at 02:49:36PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > execlists_unwind_incomplete_requests() is unused since 2021's > commit eb5e7da736f3 ("drm/i915/guc: Reset implementation for new GuC > interface") > > Remove it. > > Signed-off-by: Dr. David

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 08:47:01PM +0100, Christian König wrote: > Am 01.11.24 um 00:43 schrieb Matthew Brost: > > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > > > VRAM easily be accessed. Add ttm_bo_ac

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2024-11-04 Thread Rodrigo Vivi
On Mon, Nov 04, 2024 at 02:09:46PM +0200, Giedrius Statkevičius wrote: > Hello, > > Kind ping. There was a pipe underun in CI... I honestly don't believe this patch is causing it, but anyway I decided to trigger a retest there before I push this. Thanks for the patch and review. > > > On Thu,

Re: [PATCH 01/10] mtd: add driver for intel graphics non-volatile memory device

2024-11-04 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:10PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. > > CC: Rodrigo Vivi > CC: Lucas De Marchi > Co-developed-by: Tomas Winkler > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin Re

Re: [PATCH 09/10] drm/xe/nvm: add on-die non-volatile memory device

2024-11-04 Thread Rodrigo Vivi
On Mon, Oct 28, 2024 at 10:48:48AM -0400, Rodrigo Vivi wrote: > On Tue, Oct 22, 2024 at 01:41:18PM +0300, Alexander Usyskin wrote: > > Enable access to internal non-volatile memory on DGFX > > with GSC/CSC devices via a child device. > > The nvm child device is exposed via auxiliary bus. > > I loo

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-04 Thread Rodrigo Vivi
On Tue, Oct 29, 2024 at 11:24:36AM +, Usyskin, Alexander wrote: > > -Original Message- > > From: Gupta, Anshuman > > Sent: Monday, October 28, 2024 5:02 PM > > To: Vivi, Rodrigo ; Usyskin, Alexander > > ; Deak, Imre > > Cc: Miquel Raynal ; Richard Weinberger > > ; Vignesh Raghavendra

Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-11-04 Thread André Almeida
Hi Christopher, Em 03/11/2024 03:36, Christopher Snowhill escreveu: On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote: Currently, DRM atomic uAPI allows only primary planes to be flipped asynchronously. However, each driver might be able to perform async flips in other different plane typ

Re: [PATCH] drm: Use of_property_present() for non-boolean properties

2024-11-04 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Mon, Nov 04, 2024 at 01:06:35PM -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) Revie

[PATCH v2] drm/vmwgfx: Add common resolutions to the connector mode list

2024-11-04 Thread Ian Forbes
We replaced our custom list of resolutions with the noedid list, which is based on the VESA DMT standard, in the referenced fixes commit. The reason for this was that the user can technically set any resolution they want by using Autofit or the vmwgfxctl utility. Unfortunately the Autofit feature

Re: [PATCH v2 2/3] iommu/io-pgtable-arm-v7s: Remove split on unmap behavior

2024-11-04 Thread Jason Gunthorpe
On Mon, Nov 04, 2024 at 07:53:46PM +, Robin Murphy wrote: > On 2024-11-04 5:41 pm, Jason Gunthorpe wrote: > > A minority of page table implementations (arm_lpae, armv7) are unique in > > how they handle partial unmap of large IOPTEs. > > > > Other implementations will unmap the large IOPTE and

[etnaviv-next v2 3/3] drm/etnaviv: Improve VA, PA, SIZE alignment checking

2024-11-04 Thread Sui Jingfeng
We only need checking the alignment on the upper caller function, if those address and/or sizes are pass the check. Those address will certainly pass the same test under the etnaviv_context_unmap() function. Remove redundant alignment tests in etnaviv_context_unmap() and move the alignment tests t

[etnaviv-next v2 2/3] drm/etnaviv: Fix the debug log of the etnaviv_iommu_map()

2024-11-04 Thread Sui Jingfeng
The value of the 'iova' variable is the base GPU virtual address that is going to be mapped, its value won't get updated when etnaviv_context_map() is running under the "for_each_sgtable_dma_sg(sgt, sg, i) {}" loop. Replace it with the 'da' variable, reflect the actual status that GPUVA is being m

[etnaviv-next v2 0/3] drm/etnaviv: Trivial mmu map and ummap cleanups

2024-11-04 Thread Sui Jingfeng
The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. But it seems that nearly all helper functions we are using will hardcode it to ZERO. Under such a case, it seems that take the 'offset' into accounts are just intoduce extra overhead. Waste CPU circles

[etnaviv-next v2 1/3] drm/etnaviv: Drop offset in page manipulation

2024-11-04 Thread Sui Jingfeng
The 'offset' data member of the 'struct scatterlist' denotes the offset into a SG entry in bytes. But under drm subsystem, there has nearly NO drivers that actually tough the 'offset' data member of SG anymore. Especially for drivers that could contact with drm/etnaviv. This means that all DMA addr

Re: [PATCH v2 2/3] iommu/io-pgtable-arm-v7s: Remove split on unmap behavior

2024-11-04 Thread Robin Murphy
On 2024-11-04 5:41 pm, Jason Gunthorpe wrote: A minority of page table implementations (arm_lpae, armv7) are unique in how they handle partial unmap of large IOPTEs. Other implementations will unmap the large IOPTE and return it's length. For example if a 2M IOPTE is present and the first 4K is

[PATCH] drm/i915: Use sg_set_buf(), sg_dma_address() helper

2024-11-04 Thread Sui Jingfeng
This patch switch to use sg_set_buf() and sg_dma_address() helpers, no function change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/i915/i915_gpu_error.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i9

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Christian König
Am 01.11.24 um 00:43 schrieb Matthew Brost: On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible VRAM easily be accessed. Add ttm_bo_access, which is similar to ttm_bo_vm_access, to access such memory. v4: - Fix

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Christian König
Am 04.11.24 um 18:34 schrieb Rodrigo Vivi: On Thu, Oct 31, 2024 at 04:43:19PM -0700, Matthew Brost wrote: On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible VRAM easily be accessed. Add ttm_bo_access, which is si

Re: [PATCH] drm: Use of_property_present() for non-boolean properties

2024-11-04 Thread Abhinav Kumar
On 11/4/2024 11:06 AM, Rob Herring (Arm) wrote: The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) --- drivers/gpu/drm/bridge/ite-it66121.c | 2 +- drivers/gpu/d

[PATCH 5.15.y] drm/i915: Fix potential context UAFs

2024-11-04 Thread Sherry Yang
From: Rob Clark commit afce71ff6daa9c0f852df0727fe32c6fb107f0fa upstream. gem_context_register() makes the context visible to userspace, and which point a separate thread can trigger the I915_GEM_CONTEXT_DESTROY ioctl. So we need to ensure that nothing uses the ctx ptr after this. And we need t

[PATCH] drm: Use of_property_present() for non-boolean properties

2024-11-04 Thread Rob Herring (Arm)
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) --- drivers/gpu/drm/bridge/ite-it66121.c | 2 +- drivers/gpu/drm/bridge/sii902x.c | 2 +- drivers/gpu/drm/drm_pan

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Thomas Hellström
On Mon, 2024-11-04 at 09:21 -0800, Matthew Brost wrote: > On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > > > Continued review. > > > > > > > > +/** > > > + * struct drm_gpusvm_zdd - GPU SVM zone device data > > >

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Remove split on unmap behavior

2024-11-04 Thread Liviu Dudau
On Mon, Nov 04, 2024 at 01:41:29PM -0400, Jason Gunthorpe wrote: > A minority of page table implementations (arm_lpae, armv7) are unique in > how they handle partial unmap of large IOPTEs. > > Other implementations will unmap the large IOPTE and return it's > length. For example if a 2M IOPTE is p

Re: [PATCH v2 3/3] iommu: Add a kdoc to iommu_unmap()

2024-11-04 Thread Liviu Dudau
On Mon, Nov 04, 2024 at 01:41:31PM -0400, Jason Gunthorpe wrote: > Describe the most conservative version of the driver implementations. > All drivers should support this. > > Many drivers support extending the range if a large page is hit, but > let's not make that officially approved API. The ma

Re: [PATCH v1] drm/i915/guc: Flush ct receive tasklet during reset preparation

2024-11-04 Thread Teres Alexis, Alan Previn
Just some minor nits on header. Otherwise, LGTM: Reviewed-by: Alan Previn On Wed, 2024-10-30 at 15:38 -0700, Zhanjun Dong wrote: > GuC to host communication is interrupt driven, the handling has 3 > parts: interrupt context, tasklet and request queue worker. > During GuC reset prepare, interrupt

Re: [PATCH v4] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-11-04 Thread Lucas De Marchi
On Sat, Nov 02, 2024 at 11:22:03AM +0900, Gyeyoung Baek wrote: if CONFIG_DRM_USE_DYNAMIC_DEBUG is set, 'drm_dbg' function is replaced with '__dynamic_func_call_cls', which is replaced with a do while statement. so in the previous code, there are the following build errors. include/linux/dynamic_

[PATCH v2 3/3] iommu: Add a kdoc to iommu_unmap()

2024-11-04 Thread Jason Gunthorpe
Describe the most conservative version of the driver implementations. All drivers should support this. Many drivers support extending the range if a large page is hit, but let's not make that officially approved API. The main point is to document explicitly that split is not supported. Signed-off

[PATCH v2 1/3] iommu/io-pgtable-arm: Remove split on unmap behavior

2024-11-04 Thread Jason Gunthorpe
A minority of page table implementations (arm_lpae, armv7) are unique in how they handle partial unmap of large IOPTEs. Other implementations will unmap the large IOPTE and return it's length. For example if a 2M IOPTE is present and the first 4K is requested to be unmapped then unmap will remove

[PATCH v2 2/3] iommu/io-pgtable-arm-v7s: Remove split on unmap behavior

2024-11-04 Thread Jason Gunthorpe
A minority of page table implementations (arm_lpae, armv7) are unique in how they handle partial unmap of large IOPTEs. Other implementations will unmap the large IOPTE and return it's length. For example if a 2M IOPTE is present and the first 4K is requested to be unmapped then unmap will remove

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Rodrigo Vivi
On Thu, Oct 31, 2024 at 04:43:19PM -0700, Matthew Brost wrote: > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > > VRAM easily be accessed. Add ttm_bo_access, which is similar to > > ttm_bo_vm_access, to acc

[PATCH v2 0/3] Remove split on unmap behavior

2024-11-04 Thread Jason Gunthorpe
This is the result of the discussion on removing split. We agreed that split is not required, and no application should ask for anything that would not unmap a full large IOPTE. Instead of split the two ARM drivers will now WARN_ON and return 0. This is in contrast to what several other drivers do

Re: [PATCH] drm/rockchip: avoid 64-bit division

2024-11-04 Thread Nathan Chancellor
s this function is not performance criticial, just Use the div_u64() helper. > > Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output support") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor Can someone please pick this up? It is still broken in

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Matthew Brost
On Mon, Nov 04, 2024 at 04:25:38PM +0100, Thomas Hellström wrote: > On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: > > Continued review. > > > > > +/** > > + * struct drm_gpusvm_zdd - GPU SVM zone device data > > + * > > + * @refcount: Reference count for the zdd > > + * @destroy_work:

[pull] drm/msm: drm-msm-next-2024-11-04 for v6.13

2024-11-04 Thread Rob Clark
Hi Dave, Simona, A second late pull for v6.13, mainly to get in big/churny but mechanical (mass dp symbol renames and kerneldoc cleanups) changes to avoid merge conflicts in the next cycle. The following changes since commit 4a6fd06643afa99989a0e6b848e125099674227b: Merge remote-tracking branc

Re: [PATCH v5 08/13] dt-bindings: display: Document dual-link LVDS display common properties

2024-11-04 Thread Rob Herring (Arm)
On Mon, 04 Nov 2024 11:28:01 +0800, Liu Ying wrote: > Dual-link LVDS displays receive odd pixels and even pixels separately from > dual LVDS links. One link receives odd pixels and the other receives even > pixels. Some of those displays may also use only one LVDS link to receive > all pixels,

Re: [PATCH v2 3/6] drm/vc4: use drm_hdmi_connector_mode_valid()

2024-11-04 Thread Dave Stevenson
On Fri, 1 Nov 2024 at 00:25, Dmitry Baryshkov wrote: > > Use new drm_hdmi_connector_mode_valid() helper instead of a > module-specific copy. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Dmitry Baryshkov Acked-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +--- > 1 file chan

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-11-04 Thread neil . armstrong
On 11/10/2024 22:29, Akhil P Oommen wrote: ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce the power consumption. In some chipsets, it is also a requirement to support higher GPU frequencies. This patch adds support for GPU ACD by sending necessary data to GMU and AOSS. T

Re: [PATCH v4 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-11-04 Thread Ahmad Fatoum
On 01.11.24 14:54, Fabio Estevam wrote: > From: Fabio Estevam > > The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. > > Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep > "fsl,imx28-lcdif" for DT compatibility. > > Signed-off-by: Fabio Estevam Reviewed-by: A

Re: [PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-11-04 Thread Ahmad Fatoum
On 01.11.24 14:54, Fabio Estevam wrote: > From: Fabio Estevam > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compat

Re: [PATCH v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-11-04 Thread Ahmad Fatoum
On 01.11.24 14:54, Fabio Estevam wrote: > From: Fabio Estevam > > mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > > This causes dt-schema warnings as the current binding only > allow 'fsl,imx6sx-lcdif' as fallback. > > ['f

Re: [PATCH v4 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-11-04 Thread Rob Herring (Arm)
On Fri, 01 Nov 2024 10:54:05 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > > This causes dt-schema warnings as the current binding only > allow 'fsl,imx6sx-lcdif' as

Re: [PATCH v4 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-11-04 Thread Rob Herring (Arm)
On Fri, 01 Nov 2024 10:54:04 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long >

Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1

2024-11-04 Thread Rob Herring
On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. Describe "why", not what the changes are. I can read the diff. Why is

Re: [PATCH v5 5/6] drm/log: Implement suspend/resume

2024-11-04 Thread John Ogness
On 2024-11-04, Petr Mladek wrote: > I wonder whether console_start()/console_stop() should really > manipulate CON_ENABLE flag. It might be historical solution when > @console_suspended was a global variable. > > But it has changed with the commit 9e70a5e109a4a2336 ("printk: Add > per-console susp

Re: [PATCH v2 05/29] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-11-04 Thread Thomas Hellström
On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote: Continued review. > > +/** > + * struct drm_gpusvm_zdd - GPU SVM zone device data > + * > + * @refcount: Reference count for the zdd > + * @destroy_work: Work structure for asynchronous zdd destruction > + * @devmem_allocation: device memor

Re: [PATCH 0/1] On DRM -> stable process

2024-11-04 Thread Alex Deucher
On Mon, Nov 4, 2024 at 9:55 AM Fedor Pchelkin wrote: > > On Tue, 29. Oct 18:12, Fedor Pchelkin wrote: > > On Tue, 29. Oct 10:20, Sasha Levin wrote: > > > On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: > > > > BTW, a question to the stable-team: what Git magic (3-way-merge?) let >

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Ira Weiny
Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the tree at once. > > Signed-off-by: Thomas W

Re: [PATCH 0/1] On DRM -> stable process

2024-11-04 Thread Fedor Pchelkin
On Tue, 29. Oct 18:12, Fedor Pchelkin wrote: > On Tue, 29. Oct 10:20, Sasha Levin wrote: > > On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: > > > BTW, a question to the stable-team: what Git magic (3-way-merge?) let the > > > duplicate patch be applied successfully? The patch conte

Re: [PATCH v5 5/6] drm/log: Implement suspend/resume

2024-11-04 Thread Jocelyn Falempe
On 04/11/2024 15:15, Petr Mladek wrote: On Mon 2024-11-04 11:52:33, John Ogness wrote: On 2024-11-04, Jocelyn Falempe wrote: I looked at what serial drivers are doing, because they can also have their clock gated in suspend. Would calling console_stop() in the suspend and console_start() in r

Re: [PATCH RFC 1/3] drm/msm/adreno: Add support for ACD

2024-11-04 Thread Konrad Dybcio
On 22.10.2024 12:09 AM, Akhil P Oommen wrote: > On Mon, Oct 21, 2024 at 11:38:41AM +0200, Konrad Dybcio wrote: >> On 11.10.2024 10:29 PM, Akhil P Oommen wrote: >>> ACD a.k.a Adaptive Clock Distribution is a feature which helps to reduce >>> the power consumption. In some chipsets, it is also a requ

Re: [PATCH v5 5/6] drm/log: Implement suspend/resume

2024-11-04 Thread Petr Mladek
On Mon 2024-11-04 11:52:33, John Ogness wrote: > On 2024-11-04, Jocelyn Falempe wrote: > > I looked at what serial drivers are doing, because they can also have > > their clock gated in suspend. > > > > Would calling console_stop() in the suspend and console_start() in > > resume work ? > > Yes

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Jason Gunthorpe
On Sun, Nov 03, 2024 at 05:03:34PM +, Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the

Re: [PATCH 3/3] drm/panthor: Prevent potential overwrite of buffer objects

2024-11-04 Thread Boris Brezillon
On Mon, 4 Nov 2024 12:49:56 + Akash Goel wrote: > On 11/4/24 11:16, Boris Brezillon wrote: > > Hi Akash, > > > > On Thu, 31 Oct 2024 21:42:27 + > > Akash Goel wrote: > > > >> I assume you also reckon that there is a potential problem here for arm64. > >> > > > > It impacts any sy

Re: [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build

2024-11-04 Thread Jani Nikula
On Mon, 04 Nov 2024, Jonathan Gray wrote: > On Mon, Nov 04, 2024 at 12:16:44PM +0200, Jani Nikula wrote: >> On Sun, 03 Nov 2024, Jonathan Gray wrote: >> > intel_pxp_gsccs_is_ready_for_sessions() is gated by CONFIG_DRM_I915_PXP >> > but called from intel_pxp.c which isn't. Provide a fallback inli

[PULL] drm-intel-next

2024-11-04 Thread Jani Nikula
Hi Dave & Sima - The final drm-intel-next pull towards v6.13. The big item is Pantherlake display enabling. The platform itself is only supported by the xe driver, but display support comes from i915 display. We're also making continuous progress on separating i915 display from i915 core code,

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Ilpo Järvinen
On Sun, 3 Nov 2024, Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the tree at once. > > Si

Re: [PATCH v2] drm/v3d: Add DRM_IOCTL_V3D_PERFMON_SET_GLOBAL

2024-11-04 Thread Christian Gmeiner
Hi Maíra, > On 31/10/24 17:51, Christian Gmeiner wrote: > > From: Christian Gmeiner > > > > Add a new ioctl, DRM_IOCTL_V3D_PERFMON_SET_GLOBAL, to allow > > configuration of a global performance monitor (perfmon). > > Use the global perfmon for all jobs to ensure consistent > > performance trackin

Re: [PATCH v2] drm/v3d: Add DRM_IOCTL_V3D_PERFMON_SET_GLOBAL

2024-11-04 Thread Christian Gmeiner
Hi Maíra, > > Thanks for your patch! Just some small nits. > Thanks for your review. > On 31/10/24 17:51, Christian Gmeiner wrote: > > From: Christian Gmeiner > > > > Add a new ioctl, DRM_IOCTL_V3D_PERFMON_SET_GLOBAL, to allow > > configuration of a global performance monitor (perfmon). > > Use

Re: [PATCH 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-11-04 Thread Markus Elfring
… > +++ b/drivers/media/platform/mediatek/isp/isp_7x/camsys/mtk_cam.c > @@ -0,0 +1,4168 @@ … > +void mtk_cam_dev_req_try_queue(struct mtk_cam_device *cam) > +{ … > + spin_lock(&cam->running_job_lock); > + job_count = cam->running_job_count; > + spin_unlock(&cam->running_job_lock); … Un

Re: [PATCH] drm/bridge: it6505: Fix inverted reset polarity

2024-11-04 Thread Chen-Yu Tsai
On Tue, 29 Oct 2024 17:54:10 +0800, Chen-Yu Tsai wrote: > The IT6505 bridge chip has a active low reset line. Since it is a > "reset" and not an "enable" line, the GPIO should be asserted to > put it in reset and deasserted to bring it out of reset during > the power on sequence. > > The polarit

Re: [PATCH 3/3] drm/panthor: Prevent potential overwrite of buffer objects

2024-11-04 Thread Akash Goel
On 11/4/24 11:16, Boris Brezillon wrote: Hi Akash, On Thu, 31 Oct 2024 21:42:27 + Akash Goel wrote: I assume you also reckon that there is a potential problem here for arm64. It impacts any system that's not IO-coherent I would say, and this comment seems to prove this is a known iss

Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header

2024-11-04 Thread Arnd Bergmann
On Mon, Nov 4, 2024, at 13:24, Dmitry Baryshkov wrote: > On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote: >> On Mon, Oct 28, 2024 at 04:35:07PM +, Arnd Bergmann wrote: >>> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y") >> > I can pick it up. > > However I

[GIT PULL] mediatek drm next for 6.13

2024-11-04 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add support for OF graphs 2. Fix child node refcount handling and use scoped Regards, Chun-Kuang. The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository

Re: [PATCH 0/2] drm/mediatek: Fix child node refcount handling and use scoped macro

2024-11-04 Thread Chun-Kuang Hu
Hi, Javier: Javier Carrasco 於 2024年10月12日 週六 上午3:22寫道: > > This series fixes a wrong handling of the child node within the > for_each_child_of_node() by adding the missing call to of_node_put() to > make it compatible with stable kernels that don't provide the scoped > variant of the macro, which

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2024-11-04 Thread Giedrius Statkevičius
Hello, Kind ping. On Thu, 17 Oct 2024 at 10:57, Giedrius Statkevičius wrote: > > Avoid hardcoding the LSPCON settle timeout because it takes a longer > time on certain chips made by certain vendors. Use the function that > already exists to determine the timeout. > > Reviewed-by: Ankit Nautiyal

Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header

2024-11-04 Thread Dmitry Baryshkov
On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote: > Hi Arnd, > > On Mon, Oct 28, 2024 at 04:35:07PM +, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Compile-testing random configurations leads to failures in > > dcss-kms.c from a missing declaration: > > > > drivers/gp

Re: [REGRESSION] GM20B pmu timeout

2024-11-04 Thread Diogo Ivo
Hello, On Tue Oct 15, 2024 at 7:13 PM WEST, Linux regression tracking (Thorsten Leemhuis) wrote: > Hi, Thorsten here, the Linux kernel's regression tracker. > > On 10.10.24 15:32, Diogo Ivo wrote: > > > > Somewhere between 6.11-rc4 and 6.11-rc5 the following error message is > > displayed > > w

Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header

2024-11-04 Thread Laurentiu Palcu
Hi Arnd, On Mon, Oct 28, 2024 at 04:35:07PM +, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing random configurations leads to failures in > dcss-kms.c from a missing declaration: > > drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier > 'drm_bridge_

Re: [PATCH v5 04/13] media: uapi: Add MEDIA_BUS_FMT_RGB101010_1X7X5_{SPWG, JEIDA}

2024-11-04 Thread Dmitry Baryshkov
On Mon, Nov 04, 2024 at 11:27:57AM +0800, Liu Ying wrote: > Add two media bus formats that identify 30-bit RGB pixels transmitted > by a LVDS link with five differential data pairs, serialized into 7 > time slots, using standard SPWG/VESA or JEIDA data mapping. > > Signed-off-by: Liu Ying > --- >

Re: [PATCH v4 0/3] drm/nouveau: Add drm_panic support for nv50+

2024-11-04 Thread Jocelyn Falempe
On 31/10/2024 21:29, Lyude Paul wrote: Reviewed-by: Lyude Paul I just pushed it to drm-misc-next. Thanks & Best regards, -- Jocelyn

  1   2   >