Re: [PATCH] drm/vblank: Require a driver register vblank support for 0 or all CRTCs

2024-10-09 Thread kernel test robot
Hello, kernel test robot noticed "BUG:kernel_NULL_pointer_dereference,address" on: commit: 8e1a430cf308254a61a2317a0dfc4d8f4b3e13cb ("[PATCH] drm/vblank: Require a driver register vblank support for 0 or all CRTCs") url: https://github.com/intel-lab-lkp/linux/commits/Lyude-Paul/drm-vblank-Re

Re: [PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk

2024-10-09 Thread Thomas Weißschuh
On 2024-09-16 15:43:35-0400, Harry Wentland wrote: > On 2024-08-26 12:57, Mario Limonciello wrote: > > On 8/24/2024 13:33, Thomas Weißschuh wrote: > >> Not all platforms provide the full range of PWM backlight capabilities > >> supported by the hardware through ATIF. > >> Use the generic drm panel

Re: [PATCH v2] dma-buf: fix S_IRUGO to 0444, block comments, func declaration

2024-10-09 Thread Pintu Agarwal
Hi, On Sat, 5 Oct 2024 at 23:40, Pintu Kumar wrote: > > These warnings/errors are reported by checkpatch. > Fix them with minor changes to make it clean. > No other functional changes. > > WARNING: Block comments use * on subsequent lines > + /* only support discovering the end of the buffe

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Liu Ying
On 10/09/2024, Marek Vasut wrote: > On 10/8/24 12:07 PM, Isaac Scott wrote: >> On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: >>> On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, >>> >>> Hi, >>> On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wrote: > On 6/24/24 11:19 AM, Alexan

Re: [PATCH 2/3] dma-buf/heaps: replace kmap_atomic with kmap_local_page

2024-10-09 Thread Pintu Agarwal
On Wed, 2 Oct 2024 at 02:54, T.J. Mercier wrote: > > On Tue, Oct 1, 2024 at 7:51 PM Pintu Kumar wrote: > > > > Use of kmap_atomic/kunmap_atomic is deprecated, use > > kmap_local_page/kunmap_local instead. > > > > This is reported by checkpatch. > > Also fix repeated word issue. > > > > WARNING: D

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-09 Thread Ekansh Gupta
On 10/7/2024 2:23 PM, Greg KH wrote: > On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: >> +struct fastrpc_invoke_v2 { >> +struct fastrpc_invoke inv; >> +__u64 crc; >> +__u32 reserved[16]; > I'm sure we have been over this before, but if you have a reserved > field, you

Re: [PATCH 1/2] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-10-09 Thread Liu Ying
On 10/09/2024, Marek Vasut wrote: > The media_ldb_root_clk supply LDB serializer. These clock are usually > shared with the LCDIFv3 pixel clock and supplied by the Video PLL on > i.MX8MP, but the LDB clock run at either x7 or x14 rate of the LCDIFv3 > pixel clock. Allow the LDB to reconfigure Video

linux-next: build warnings after merge of the drm-misc tree

2024-10-09 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: include/drm/ttm/ttm_device.h:255: warning: Incorrect use of kernel-doc format: * @unevictable Buffer objects which are pinned or swapped and as such include/drm/ttm/ttm_device.h:270: wa

linux-next: build warnings after merge of the drm-misc tree

2024-10-09 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Excess function parameter 'dsi' description in 'mipi_dsi_compression_mode_multi' drivers/gpu/drm/drm_mipi_dsi.c:1533: warning: Function parameter or

Reversed order of iGPU and dGPU causing primary selection issues

2024-10-09 Thread Luke Jones
Hi all, I'll attempt to summarise this as best as I can: I have an ASUS GA605W laptop, this has an AMD APU, and NVIDIA dGPU. The dGPU comes before AMD on the PCI bus, making it /dev/dri/card0, and /dev/dri/renderD128. Additionally the attribute `boot_vga` is set for the NVIDIA gpu. This means

[PATCH] drm/msm/dpu: don't always program merge_3d block

2024-10-09 Thread Jessica Zhang
Only program the merge_3d block for the video phys encoder when the 3d blend mode is not NONE Fixes: 3e79527a33a8 ("drm/msm/dpu: enable merge_3d support on sm8150/sm8250") Suggested-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- 1

[PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-09 Thread Jessica Zhang
_pp->merge_3d) + if (mode_3d && hw_ctl->ops.update_pending_flush_merge_3d && + hw_pp && hw_pp->merge_3d) hw_ctl->ops.update_pending_flush_merge_3d(hw_ctl, hw_pp->merge_3d->idx); --- base-commit: a20a91fb1bfac5d05ec5bcf9afe0c9363f6c8c93 change-id: 20241009-mode3d-fix-4c3c114ffeb9 Best regards, -- Jessica Zhang

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Marek Vasut
On 10/9/24 5:58 PM, Isaac Scott wrote: [...] media_mipi_phy1_ref  0   0    0 23036364 0  0 5  N  deviceless no_co     media_mipi_phy1_ref_root 0   0    0 23036364    0  0 5  N 32ec.blk

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-09 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 06:10写道: > > On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > > > Only 2 DSC engines are allowed, or no DSC is involved currently. > > Can't parse this phrase. How about this: If DSC is enabled, the only case is with 2 DSC engines so far. > > > We need 4 DSC in q

Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support

2024-10-09 Thread Lizhi Hou
On 10/9/24 09:22, Lizhi Hou wrote: On 10/4/24 11:33, Jeffrey Hugo wrote: On 9/11/2024 12:06 PM, Lizhi Hou wrote: User application may allocate a debug buffer and attach it to an NPU context through the driver. Then the NPU firmware prints its debug information to this buffer for debugging.

Re: [PATCH v8 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-10-09 Thread Cristian Ciocaltea
Hi Jonas, On 9/29/24 3:34 AM, Jonas Karlman wrote: > Hi Cristian, > > On 2024-09-29 00:36, Cristian Ciocaltea wrote: >> The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1 >> Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a >> Samsung IP block. >> >> Add

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-09 Thread Adrián Larumbe
Hi Tvrtko, On 04.10.2024 14:41, Tvrtko Ursulin wrote: > > Hi Adrian, > > On 03/10/2024 00:45, Adrián Larumbe wrote: > > Some drivers must allocate a considerable amount of memory for bookkeeping > > structures and GPU's MCU-kernel shared communication regions. These are > > often created as a re

Re: [PATCH v1] drm/i915/gt: Retry RING_HEAD reset until it sticks

2024-10-09 Thread Andi Shyti
Hi Nitin, On Thu, Oct 03, 2024 at 07:40:44PM +0530, Nitin Gote wrote: > From: Chris Wilson > > On Haswell, in particular, we see an issue where resets fails because > the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD > doesn't point to the remaining requests to re-run, but may

[PATCH v9 3/3] drm/rockchip: Add basic RK3588 HDMI output support

2024-10-09 Thread Cristian Ciocaltea
The RK3588 SoC family integrates the newer Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller IP and a HDMI/eDP TX Combo PHY based on a Samsung IP block. Add just the basic support for now, i.e. RGB output up to 4K@60Hz, without audio, CEC or any of the HDMI 2.1 specific features. Co-deve

[PATCH v9 1/3] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-10-09 Thread Cristian Ciocaltea
The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller IP supports the following features, among others: * Fixed Rate Link (FRL) * Display Stream Compression (DSC) * 4K@120Hz and 8K@60Hz video modes * Variable Refresh Rate (VRR) including Quick Media Switching (QMS), aka Cinema VRR * Fas

[PATCH v9 0/3] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-10-09 Thread Cristian Ciocaltea
The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite different from those used in the previous generations of Rockchip SoCs. The controller supports the following features, among others: * Fixed Rate Link (FRL) *

[PATCH v9 2/3] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-10-09 Thread Cristian Ciocaltea
Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller IP. Since this is a new IP block, quite different from those used in the previous generations of Rockchip SoCs, add a dedicated binding file. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Cristian Cio

Re: [PATCH v4 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-09 Thread Dmitry Baryshkov
On Wed, 9 Oct 2024 at 17:34, Mahadevan wrote: > > This series introduces support to enable the Mobile Display Subsystem (MDSS) > and Display Processing Unit (DPU) for the Qualcomm SA8775P target. It > includes the addition of the hardware catalog, compatible string, > relevant device tree changes,

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-09 Thread Dmitry Baryshkov
On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > Only 2 DSC engines are allowed, or no DSC is involved currently. Can't parse this phrase. > We need 4 DSC in quad-pipe topology in future. So let's only configure > DSC engines in use, instread of maximum number of DSC engines. Nit: instead > > S

[PATCH] Documentation/gpu: Fix Panthor documentation build warnings

2024-10-09 Thread Adrián Larumbe
Fix Panthor documentation build errors uncovered by the makedocs target when building with extra warnings enabled. Signed-off-by: Adrián Larumbe Fixes: f25044688b04 ("drm/panthor: add sysfs knob for enabling job profiling") Reported-by: Stephen Rothwell --- Documentation/gpu/drivers.rst

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Isaac Scott
On Wed, 2024-10-09 at 17:47 +0200, Marek Vasut wrote: > On 10/9/24 11:55 AM, Isaac Scott wrote: > > On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: > > > On 10/8/24 12:07 PM, Isaac Scott wrote: > > > > On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: > > > > > On 10/7/24 7:01 PM, Isaac S

Question about possible NULL Pointer Dereference in hx83102_get_modes()

2024-10-09 Thread Zichen Xie
Dear Developers for DRM PANEL DRIVERS, We are developing a static analyzer for Linux Kernel, and we are curious about the function drm_mode_duplicate() in hx83102_get_modes(). https://elixir.bootlin.com/linux/v6.12-rc2/source/drivers/gpu/drm/panel/panel-himax-hx83102.c#L567 ``` struct drm_displa

Re: [PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

2024-10-09 Thread Rob Herring
On Wed, Oct 09, 2024 at 07:15:42PM +0800, Shu-hsiang Yang wrote: > 1. Add camera isp7x module device document > 2. Add camera interface device document > > Signed-off-by: Shu-hsiang Yang > --- > .../media/mediatek/mediatek,cam-raw.yaml | 169 ++ > .../media/mediatek/mediatek

Re: [PATCH][next] drm/xe/guc: Fix dereference before Null check

2024-10-09 Thread Everest K.C.
On Wed, Oct 9, 2024 at 2:35 PM Dan Carpenter wrote: > > On Wed, Oct 09, 2024 at 12:49:49PM -0600, Everest K.C. wrote: > > The pointer list->list was derefrenced before the Null check > > resulting in possibility of Null pointer derefrencing. > > This patch moves the Null check outside the for loop

Re: [PATCH][next] drm/xe/guc: Fix dereference before Null check

2024-10-09 Thread Dan Carpenter
On Wed, Oct 09, 2024 at 12:49:49PM -0600, Everest K.C. wrote: > The pointer list->list was derefrenced before the Null check > resulting in possibility of Null pointer derefrencing. > This patch moves the Null check outside the for loop, so that > the check is performed before the derefrencing. >

Re: [PATCH v4 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

2024-10-09 Thread Rob Herring (Arm)
x27; was unexpected) from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm8650-dpu.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009-patchv3_1-v4-2-cd683a9ca...@quicinc.com The base for the series

Re: [PATCH v1 3/3] drm/ci: add sm8350-hdk

2024-10-09 Thread Abhinav Kumar
On 10/4/2024 6:31 AM, Vignesh Raman wrote: Add job that executes the IGT test suite for sm8350-hdk. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/arm64.config | 7 +- drivers/gpu/drm/ci/build.sh | 1 + drivers/gpu/drm/ci/test.yml

Re: [PATCH v2 1/1] drm/edp-panel: Add panels used by Dell XPS 13 9345

2024-10-09 Thread Doug Anderson
Hi, On Tue, Oct 8, 2024 at 12:30 AM Aleksandrs Vinarskis wrote: > > Introduce low-res IPS and OLED panels for mentioned device. > > SHP panel's timings were picked experimentally, without this patch or with > `delay_200_500_e50` panel sometimes fails to boot/stays black on startup. > > LGD panel'

[PATCH][next] drm/xe/guc: Fix dereference before Null check

2024-10-09 Thread Everest K.C.
The pointer list->list was derefrenced before the Null check resulting in possibility of Null pointer derefrencing. This patch moves the Null check outside the for loop, so that the check is performed before the derefrencing. This issue was reported by Coverity Scan. Signed-off-by: Everest K.C.

[PULL] drm-misc-next

2024-10-09 Thread Maarten Lankhorst
Hi Dave, Simona, Here's drm-misc-next for v6.13! drm-misc-next-2024-10-09: drm-misc-next for v6.13: UAPI Changes: - Add drm fdinfo support to panthor, and add sysfs knob to toggle. Cross-subsystem Changes: - Convert fbdev drivers to use backlight power constants. - Some small dma-fence fixes. -

[PATCH] drm/xe: Enlarge the invalidation timeout from 150 to 500

2024-10-09 Thread Shuicheng Lin
There is error message like below during stress test. "[ 31.004009] xe :03:00.0: [drm] ERROR GT0: Global invalidation timeout" And change the timeout value from 150 to 500, could help avoid this error message in the stress test. xe_mmio_wait32() is implemented as wait 10us at beginning, then

Re: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter

2024-10-09 Thread Dmitry Baryshkov
On Wed, 9 Oct 2024 at 11:32, Liu Ying wrote: > > On 09/30/2024, Biju Das wrote: > > Hi Liu, > > Hi Biju, > > > > >> -Original Message- > >> From: Biju Das > >> Sent: Monday, September 30, 2024 10:16 AM > >> Subject: RE: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter > >> > >

Re: [PATCH][next] drm/xe/guc: Fix inverted logic on snapshot->copy check

2024-10-09 Thread John Harrison
On 10/9/2024 09:05, Colin Ian King wrote: Currently the check to see if snapshot->copy has been allocated is inverted and ends up dereferencing snapshot->copy when free'ing objects in the array when it is null or not free'ing the objects when snapshot->copy is allocated. Fix this by using the cor

Re: [PATCH V3 11/11] accel/amdxdna: Add firmware debug buffer support

2024-10-09 Thread Lizhi Hou
On 10/4/24 11:33, Jeffrey Hugo wrote: On 9/11/2024 12:06 PM, Lizhi Hou wrote: User application may allocate a debug buffer and attach it to an NPU context through the driver. Then the NPU firmware prints its debug information to this buffer for debugging. I feel like I must be missing someth

Re: [PATCH V3 10/11] accel/amdxdna: Add query functions

2024-10-09 Thread Lizhi Hou
On 10/4/24 11:23, Jeffrey Hugo wrote: On 9/11/2024 12:06 PM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_error.c b/drivers/accel/amdxdna/aie2_error.c index 3b8223420f5b..9dc44ecf2adb 100644 --- a/drivers/accel/amdxdna/aie2_error.c +++ b/drivers/accel/amdxdna/aie2_error.c @@ -3,6

Re: [PATCH V4 2/2] drm/vc4: v3d: add PM suspend/resume support

2024-10-09 Thread Stefan Wahren
Hi Maíra, Am 09.10.24 um 14:16 schrieb Maíra Canal: Hi Stefan, On 10/8/24 13:05, Stefan Wahren wrote: Hi Maíra, Am 08.10.24 um 15:49 schrieb Maíra Canal: Hi Stefan, On 10/3/24 09:41, Stefan Wahren wrote: Add suspend/resume support for the VC4 V3D component in order to handle suspend to idl

[PATCH][next] drm/xe/guc: Fix inverted logic on snapshot->copy check

2024-10-09 Thread Colin Ian King
Currently the check to see if snapshot->copy has been allocated is inverted and ends up dereferencing snapshot->copy when free'ing objects in the array when it is null or not free'ing the objects when snapshot->copy is allocated. Fix this by using the correct non-null pointer check logic. Fixes: d

Re: [PATCH linux-next] drm: Fix for kernel doc warning

2024-10-09 Thread Jani Nikula
On Thu, 03 Oct 2024, R Sundar wrote: > Added colon in kernel-doc comment to fix the warning. > > ./include/drm/drm_drv.h:372: warning: Incorrect use of kernel-doc format: > * @fbdev_probe > ./include/drm/drm_drv.h:435: warning: Function parameter or struct member > 'fbdev_probe' not des

Re: [PATCH 1/2] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-10-09 Thread Marek Vasut
On 10/9/24 1:40 PM, Abel Vesa wrote: On 24-10-09 00:38:19, Marek Vasut wrote: The media_ldb_root_clk supply LDB serializer. These clock are usually shared with the LCDIFv3 pixel clock and supplied by the Video PLL on i.MX8MP, but the LDB clock run at either x7 or x14 rate of the LCDIFv3 pixel cl

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Marek Vasut
On 10/9/24 11:55 AM, Isaac Scott wrote: On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: On 10/8/24 12:07 PM, Isaac Scott wrote: On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: On 10/7/24 7:01 PM, Isaac Scott wrote: Hi Marek, Hi, On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut w

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-09 Thread Marek Vasut
On 10/9/24 12:27 PM, Isaac Scott wrote: On Wed, 2024-10-09 at 00:38 +0200, Marek Vasut wrote: The LDB serializer clock operate at either x7 or x14 rate of the input LCDIFv3 scanout engine clock. Make sure the serializer clock and their upstream Video PLL are configured early in .mode_set to the

[PATCH][next] fbdev: clps711x-fb: remove redundant call to unregister_framebuffer

2024-10-09 Thread Colin Ian King
Currently the call to unregister_framebuffer is unreachable code because the previous statement returns from the function. The call is redundant and can be removed. Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev") Signed-off-by: Colin Ian King ---

Re: [PATCH v2 1/1] drm/mediatek: Fix potential KP on 0 bytes nvmem cell read

2024-10-09 Thread Guillaume Ranquet
On Fri, 27 Sep 2024 11:03, Liankun Yang wrote: >If the len is 0, kernel crash will occur when performing operations. >Add the len check conditions to prevent kernel crash. > >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") >Signed-off-by: Liankun Yang >--- >Changes in

[RFC PATCH] drm/amd/display/dc: Refactor remove duplications

2024-10-09 Thread Luan Icaro Pinto Arcanjo
From: LipArcanjo All dce command_table_helper's shares a copy-pasted collection of copy-pasted functions, which are: phy_id_to_atom, clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom. This patch removes the multiple copy-pasted by creating a common command table and make the command_

Re: [PATCH] drm/imx: add forward declarations for types

2024-10-09 Thread Jani Nikula
On Wed, 09 Oct 2024, Philipp Zabel wrote: > On Mi, 2024-10-09 at 17:04 +0300, Jani Nikula wrote: >> The imx.h header does not forward declare the types it uses, and the >> header is not self-contained. Fix it. >> >> Fixes: cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings >> D

Re: [PATCH 2/2] MAINTAINERS: Fix VC4's mailing lists

2024-10-09 Thread Dave Stevenson
Hi Maíra On Wed, 9 Oct 2024 at 15:12, Maíra Canal wrote: > > VC4 has two relevant mailing list: kernel-l...@raspberrypi.com and > dri-devel@lists.freedesktop.org. Therefore, list those two mailing > lists in the VC4 section. dri-devel@lists.freedesktop.org is automatically picked up by get_maint

[PATCH v7 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi

2024-10-09 Thread Dzmitry Sankouski
mipi_dsi_compression_mode_multi can help with error handling. Reviewed-by: Neil Armstrong Signed-off-by: Dzmitry Sankouski --- Changes in v7: - fix kernel doc --- drivers/gpu/drm/drm_mipi_dsi.c | 16 include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 18 insertions(+) dif

[PATCH v7 3/3] drm/panel: Add support for S6E3HA8 panel driver

2024-10-09 Thread Dzmitry Sankouski
Add support for MIPI-DSI based S6E3HA8 AMOLED panel driver. This panel has 1440x2960 resolution, 5.8-inch physical size, and can be found in starqltechn device. Brightness regulation is not yet supported. Reviewed-by: Neil Armstrong Signed-off-by: Dzmitry Sankouski --- Changes for v6: - return c

[PATCH v7 2/3] dt-bindings: panel: add Samsung s6e3ha8

2024-10-09 Thread Dzmitry Sankouski
Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. Reviewed-by: Conor Dooley Signed-off-by: Dzmitry Sankouski --- Changes for v5: - fix required properties order - fix example indentation Changes in v4: - change dts example intendation from tabs to spaces - remove reset-gpios d

[PATCH v7 0/3] Add Samsung S6E3HA8 panel driver

2024-10-09 Thread Dzmitry Sankouski
The s6e3ha8 is a 1440x2960 DPI AMOLED display panel from Samsung Mobile Displays (SMD) Signed-off-by: Dzmitry Sankouski --- Changes in v7: - fix kernel doc - Link to v6: https://lore.kernel.org/r/20241006-starqltechn_integration_upstream-v6-0-8336b9cd6...@gmail.com Changes in v6: - add new pa

Re: [PATCH 0/5] dt-bindings: mfd: convert zii,rave-sp.txt and child txt to yaml format

2024-10-09 Thread Rob Herring
On Tue, Oct 08, 2024 at 06:00:56PM -0400, Frank Li wrote: > Fixed below warnings: > > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb: > /soc@0/bus@3080/serial@3089/mcu: failed to match any schema with > compatible: ['zii,rave-sp-rdu2'] > arch/arm64/boot/dts/freescale/imx8mq-zii-

Re: [PATCH 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-09 Thread Rob Herring
On Wed, Oct 09, 2024 at 03:27:58PM +0100, Daniel Thompson wrote: > On Tue, Oct 08, 2024 at 06:00:58PM -0400, Frank Li wrote: > > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > > Additional Changes: > > - Remove mfd parent node at example. > > - Ref to backlight's common

Re: [PATCH 1/2] MAINTAINERS: Add Maíra to VC4 reviewers

2024-10-09 Thread Dave Stevenson
On Wed, 9 Oct 2024 at 15:12, Maíra Canal wrote: > > Although I don't hold expertise on the display side of VC4, I'd like to > help reviewing patches that are related to the 3D side of the VC4 driver. > As V3D maintainer, I hold some expertise with Broadcom GPUs and I'm > constantly testing kernels

Re: (subset) [PATCH] backlight: Remove notifier

2024-10-09 Thread Lee Jones
On Fri, 20 Sep 2024 00:27:58 +0100, li...@treblig.org wrote: > backlight_register_notifier and backlight_unregister_notifier have > been unused since > commit 6cb634d0dc85 ("ACPI: video: Remove code to unregister acpi_video > backlight when a native backlight registers") > > With those not being

Re: [PATCH 1/2] MAINTAINERS: Add Maíra to VC4 reviewers

2024-10-09 Thread Maxime Ripard
On Wed, 9 Oct 2024 11:12:05 -0300, Maíra Canal wrote: > Although I don't hold expertise on the display side of VC4, I'd like to > help reviewing patches that are related to the 3D side of the VC4 driver. > As V3D maintainer, I hold some expertise with Broadcom GPUs and I'm > constantly testing ker

[PATCH v4 5/5] arm64: dts: qcom: sa8775p: add display dt nodes for MDSS0 and DPU

2024-10-09 Thread Mahadevan
Add devicetree changes to enable MDSS0 display-subsystem its display-controller(DPU) for Qualcomm SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 89 +++ 1 file changed, 89 insertions(+) diff -

[PATCH v4 4/5] drm/msm/dpu: Add SA8775P support

2024-10-09 Thread Mahadevan
Add definitions for the display hardware used on the Qualcomm SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- .../drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h| 485 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/

[PATCH v4 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-09 Thread Mahadevan
This series introduces support to enable the Mobile Display Subsystem (MDSS) and Display Processing Unit (DPU) for the Qualcomm SA8775P target. It includes the addition of the hardware catalog, compatible string, relevant device tree changes, and their YAML bindings. --- In this series - PATCH 1:

[PATCH v4 3/5] drm/msm: mdss: Add SA8775P support

2024-10-09 Thread Mahadevan
Add Mobile Display Subsystem (MDSS) support for the SA8775P platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Mahadevan --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v4 2/5] dt-bindings: display/msm: Document the DPU for SA8775P

2024-10-09 Thread Mahadevan
Document the DPU for Qualcomm SA8775P platform. Signed-off-by: Mahadevan --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindi

[PATCH v4 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-10-09 Thread Mahadevan
Document the MDSS hardware found on the Qualcomm SA8775P platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Mahadevan --- .../bindings/display/msm/qcom,sa8775p-mdss.yaml| 241 + 1 file changed, 241 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

Re: [PATCH] drm/file: fix client_name_lock kernel-doc warning

2024-10-09 Thread Christian König
Am 09.10.24 um 16:23 schrieb Dmitry Osipenko: On 10/9/24 17:03, Jani Nikula wrote: It's client_name_lock, not name_lock. Also unify style while at it. Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20241009172650.29169...@canb.auug.org.au Fixes: 56c594d8df64 ("drm: add DRM_SET

Re: [PATCH 8/8] drm/client: s/unsigned int i/int i/

2024-10-09 Thread Jani Nikula
On Tue, 08 Oct 2024, Ville Syrjälä wrote: > On Mon, Oct 07, 2024 at 09:43:47AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 03.10.24 um 13:33 schrieb Ville Syrjala: >> > From: Ville Syrjälä >> > >> > Replace the 'unsigned int i' footguns with plain old signed >> > int. Avoids accidents if/when

Re: [PATCH] drm: xlnx: zynqmp_dpsub: also call drm_helper_hpd_irq_event

2024-10-09 Thread Steffen Dirkwinkel
Hi Laurent, On Wed, 2024-09-25 at 19:36 +0300, Laurent Pinchart wrote: > Hi Steffen, > > On Wed, Sep 25, 2024 at 09:54:18AM +0200, Steffen Dirkwinkel wrote: > > On Tue, 2024-09-24 at 21:43 +0300, Laurent Pinchart wrote: > > > On Mon, Sep 23, 2024 at 09:48:03AM +0200, li...@steffen.cc wrote: > >

Re: [PATCH 2/5] dt-bindings: backlight: convert zii,rave-sp-backlight.txt to yaml

2024-10-09 Thread Daniel Thompson
On Tue, Oct 08, 2024 at 06:00:58PM -0400, Frank Li wrote: > Convert device tree binding doc zii,rave-sp-backlight.txt to yaml format. > Additional Changes: > - Remove mfd parent node at example. > - Ref to backlight's common.yaml > > Signed-off-by: Frank Li > --- > .../leds/backlight/zii,rave-sp-

Re: [PATCH] drm/file: fix client_name_lock kernel-doc warning

2024-10-09 Thread Dmitry Osipenko
On 10/9/24 17:03, Jani Nikula wrote: > It's client_name_lock, not name_lock. Also unify style while at it. > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/r/20241009172650.29169...@canb.auug.org.au > Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") > Cc: Tvrtko Ursul

Re: [PATCH] drm/imx: add forward declarations for types

2024-10-09 Thread Philipp Zabel
On Mi, 2024-10-09 at 17:04 +0300, Jani Nikula wrote: > The imx.h header does not forward declare the types it uses, and the > header is not self-contained. Fix it. > > Fixes: cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings > DT node") > Cc: Philipp Zabel > Cc: Dmitry Baryshk

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-09 Thread Thomas Hellström
On Wed, 2024-10-09 at 15:39 +0200, Thomas Hellström wrote: > On Mon, 2024-10-07 at 11:08 +0200, Christian König wrote: > > Hi Thomas, > > > > I'm on sick leave, but I will try to answer questions and share > > some > > thoughts on this to unblock you. > > > > Am 18.09.24 um 14:57 schrieb Thomas

[PATCH 2/2] MAINTAINERS: Fix VC4's mailing lists

2024-10-09 Thread Maíra Canal
VC4 has two relevant mailing list: kernel-l...@raspberrypi.com and dri-devel@lists.freedesktop.org. Therefore, list those two mailing lists in the VC4 section. Actually, Raspberry Pi Kernel Maintenance was already listed in the VC4 section, but it was listed as a reviewer. List it as a mailing li

[PATCH 1/2] MAINTAINERS: Add Maíra to VC4 reviewers

2024-10-09 Thread Maíra Canal
Although I don't hold expertise on the display side of VC4, I'd like to help reviewing patches that are related to the 3D side of the VC4 driver. As V3D maintainer, I hold some expertise with Broadcom GPUs and I'm constantly testing kernels on RPi 3-5. Signed-off-by: Maíra Canal --- MAINTAINERS

Re: [PATCH 4/8] drm/client: Make copies of modes

2024-10-09 Thread kernel test robot
ry.h:617) [ 12.756757][ T116] ? drm_mode_copy (kbuild/src/consumer/drivers/gpu/drm/drm_modes.c:1422) drm The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20241009/202410091649.1353a717-oliver.s...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

[PATCH] drm/imx: add forward declarations for types

2024-10-09 Thread Jani Nikula
The imx.h header does not forward declare the types it uses, and the header is not self-contained. Fix it. Fixes: cc3e8a216d6b ("drm/imx: add internal bridge handling display-timings DT node") Cc: Philipp Zabel Cc: Dmitry Baryshkov Cc: i...@lists.linux.dev Cc: linux-arm-ker...@lists.infradead.o

[PATCH] drm/file: fix client_name_lock kernel-doc warning

2024-10-09 Thread Jani Nikula
It's client_name_lock, not name_lock. Also unify style while at it. Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20241009172650.29169...@canb.auug.org.au Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") Cc: Tvrtko Ursulin Cc: Dmitry Osipenko Cc: Pierre-Eric Pelloux-

Re: [PATCH v2] drm/amdgpu: prevent BO_HANDLES error from being overwritten

2024-10-09 Thread Pierre-Eric Pelloux-Prayer
Thanks for the updated patch, looks good to me. Le 09/10/2024 à 14:31, Christian König a écrit : Am 09.10.24 um 14:28 schrieb Mohammed Anees: Before this patch, if multiple BO_HANDLES chunks were submitted, the error -EINVAL would be correctly set but could be overwritten by the return value fr

Re: [PATCH] backlight: Remove notifier

2024-10-09 Thread Daniel Thompson
On Wed, Oct 09, 2024 at 11:22:30AM +0100, Lee Jones wrote: > On Tue, 24 Sep 2024, Simona Vetter wrote: > > > On Fri, Sep 20, 2024 at 12:27:58AM +0100, li...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > backlight_register_notifier and backlight_unregister_notifier have > > >

Re: [PATCH v2] locking/ww_mutex: Adjust to lockdep nest_lock requirements

2024-10-09 Thread Thomas Hellström
On Wed, 2024-10-09 at 15:10 +0200, Peter Zijlstra wrote: > On Wed, Oct 09, 2024 at 11:20:31AM +0200, Thomas Hellström wrote: > > When using mutex_acquire_nest() with a nest_lock, lockdep refcounts > > the > > number of acquired lockdep_maps of mutexes of the same class, and > > also > > keeps a poi

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-10-09 Thread Thomas Hellström
On Mon, 2024-10-07 at 11:08 +0200, Christian König wrote: > Hi Thomas, > > I'm on sick leave, but I will try to answer questions and share some > thoughts on this to unblock you. > > Am 18.09.24 um 14:57 schrieb Thomas Hellström: > > Sima, Christian > > > > I've updated the shrinker series now

Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()

2024-10-09 Thread Rafael J. Wysocki
On Wed, Oct 9, 2024 at 2:48 PM Richard Fitzgerald wrote: > > On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote: > > On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote: > >> > >> On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart > >> wrote: > >>> > >>> Hi Ulf, > >>> > >>> On Tue, Oct 08, 2024 at 12:08:24

[PATCH v1 09/10] media: platform: mediatek: add isp_7x build config

2024-10-09 Thread Shu-hsiang Yang
Add Kconfig and Makefile to include MTK ISP CAMSYS, integrating the driver into the kernel build and configuration process. Signed-off-by: Shu-hsiang Yang --- drivers/media/platform/mediatek/Kconfig | 1 + drivers/media/platform/mediatek/Makefile | 2 ++ drivers/media/platform/media

[PATCH v1 10/10] uapi: linux: add mediatek isp_7x camsys user api

2024-10-09 Thread Shu-hsiang Yang
Add UAPI for MediaTek ISP platform, providing user-space interfaces for the new camsys driver. Signed-off-by: Shu-hsiang Yang --- include/uapi/linux/mtkisp_camsys.h | 227 + 1 file changed, 227 insertions(+) create mode 100644 include/uapi/linux/mtkisp_camsys.h diff

Re: [PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-10-09 Thread Isaac Scott
On Tue, 2024-10-08 at 23:48 +0200, Marek Vasut wrote: > On 10/8/24 12:07 PM, Isaac Scott wrote: > > On Mon, 2024-10-07 at 20:06 +0200, Marek Vasut wrote: > > > On 10/7/24 7:01 PM, Isaac Scott wrote: > > > > Hi Marek, > > > > > > Hi, > > > > > > > On Sat, 2024-07-06 at 02:16 +0200, Marek Vasut wro

[PATCH v1 03/10] media: platform: mediatek: add isp_7x seninf unit

2024-10-09 Thread Shu-hsiang Yang
Introduces the driver of the MediaTek Sensor Interface, focusing on integration with the MediaTek ISP CAMSYS. The seninf device bridges camera sensors and the ISP system, providing management for sensor data routing and processing. Key features include V4L2 framework control, and dynamic handling o

[PATCH v1 00/10] Add MediaTek ISP7 camera system driver

2024-10-09 Thread Shu-hsiang Yang
Based on linux-next/master, tag: next-20241008 The patch set adds the MediaTek ISP7.x camera system hardware driver. This driver sets up ISP hardware, handles interrupts, and initializes V4L2 device nodes and functions. Moreover, implement V4L2 standard video driver that utilizes media framework

[PATCH v1 01/10] dt-bindings: media: mediatek: add camsys device

2024-10-09 Thread Shu-hsiang Yang
1. Add camera isp7x module device document 2. Add camera interface device document Signed-off-by: Shu-hsiang Yang --- .../media/mediatek/mediatek,cam-raw.yaml | 169 ++ .../media/mediatek/mediatek,cam-yuv.yaml | 148 +++ .../media/mediatek/mediatek,camisp.ya

[PATCH v1 07/10] media: platform: mediatek: add isp_7x video ops

2024-10-09 Thread Shu-hsiang Yang
Introduces the V4L2 video interface and feature management for the MediaTek ISP7x CAMSYS. These interfaces include various functionalities, such as video operation initialization and registration. They also manage MediaTek-specific formats and handle buffers for MediaTek camera video devices. This

[PATCH v1 08/10] media: platform: mediatek: add isp_7x state ctrl

2024-10-09 Thread Shu-hsiang Yang
Introduces state management and debugging mechanisms for the MediaTek ISP7.x camsys platform. State management establishes control over ISP operations and events, defining distinct states for request handling, sensor control, and frame synchronization, ensuring event processing. The debugging mecha

Re: [PATCH 2/2] drm: bridge: ldb: Configure LDB clock in .mode_set

2024-10-09 Thread Isaac Scott
On Wed, 2024-10-09 at 00:38 +0200, Marek Vasut wrote: > The LDB serializer clock operate at either x7 or x14 rate of the > input > LCDIFv3 scanout engine clock. Make sure the serializer clock and > their > upstream Video PLL are configured early in .mode_set to the x7 or x14 > rate of pixel clock,

[PATCH v4] drm/meson: switch to a managed drm device

2024-10-09 Thread Anastasia Belova
Switch to a managed drm device to cleanup some error handling and make future work easier. Fix dereference of NULL in meson_drv_bind_master by removing drm_dev_put(drm) before meson_encoder_*_remove and component_unbind_all where drm is dereferenced. Co-developed by Linux Verification Center (lin

Re: [PATCH 00/51] treewide: Switch to __pm_runtime_put_autosuspend()

2024-10-09 Thread Richard Fitzgerald
On 08/10/2024 7:24 pm, Rafael J. Wysocki wrote: On Tue, Oct 8, 2024 at 12:35 AM Ulf Hansson wrote: On Tue, 8 Oct 2024 at 00:25, Laurent Pinchart wrote: Hi Ulf, On Tue, Oct 08, 2024 at 12:08:24AM +0200, Ulf Hansson wrote: On Mon, 7 Oct 2024 at 20:49, Laurent Pinchart wrote: On Fri, Oct 04

Re: [PATCH v2] locking/ww_mutex: Adjust to lockdep nest_lock requirements

2024-10-09 Thread Peter Zijlstra
On Wed, Oct 09, 2024 at 11:20:31AM +0200, Thomas Hellström wrote: > When using mutex_acquire_nest() with a nest_lock, lockdep refcounts the > number of acquired lockdep_maps of mutexes of the same class, and also > keeps a pointer to the first acquired lockdep_map of a class. That pointer > is then

Re: [PATCH v1 02/10] media: platform: mediatek: add seninf controller

2024-10-09 Thread AngeloGioacchino Del Regno
Il 09/10/24 13:15, Shu-hsiang Yang ha scritto: Introduces support for the sensor interface in the MediaTek SoC, with the focus on CSI and stream control. The key functionalities include parameter control, metering and maintaining status information, interrupt handling, and debugging. These featur

Re: RESEND Re: [PATCH v4 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-10-09 Thread Thomas Hellström
On Mon, 2024-10-07 at 10:54 +0200, Christian König wrote: > My r-b still hold for this series. Please merge it through whatever > branch you are comfortable with. > > And sorry for the delay, I'm still on sick leave (dentist problems). > > Regards, > Christian. Thanks. Pushed to drm-misc-next.

Re: [PATCH v6 1/3] drm/mipi-dsi: add mipi_dsi_compression_mode_multi

2024-10-09 Thread Neil Armstrong
-8.3 (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuulll-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241009/202410092245.tfsuulll-...@intel.com/reproduce) If you fix the issue in a

Re: [PATCH v2] drm/amdgpu: prevent BO_HANDLES error from being overwritten

2024-10-09 Thread Christian König
Am 09.10.24 um 14:28 schrieb Mohammed Anees: Before this patch, if multiple BO_HANDLES chunks were submitted, the error -EINVAL would be correctly set but could be overwritten by the return value from amdgpu_cs_p1_bo_handles(). This patch ensures that if there are multiple BO_HANDLES, we stop. C

Re: [PATCH] drm/amdgpu: prevent BO_HANDLES error from being overwritten

2024-10-09 Thread Mohammed Anees
Hi, I have sent the v2 Patch reflecting these changes along with the Cc tag as suggested by Christian. Thanks

  1   2   >