Re: [PATCH 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-23 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 11:51:46AM GMT, Pin-yen Lin wrote: > The bridge might miss the display change events when it's powered off. > This happens when a user changes the external monitor when the system > is suspended and the embedded controller doesn't not wake AP up. > > It's also observed that

Re: [PATCH 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-23 Thread Dmitry Baryshkov
On Tue, Sep 24, 2024 at 11:51:47AM GMT, Pin-yen Lin wrote: > The bridge might miss the display change events when it's powered off. > This happens when a user changes the external monitor when the system > is suspended and the embedded controller doesn't not wake AP up. > > It's also observed that

Re: [PATCH v1] docs/gpu: ci: update flake tests requirements

2024-09-23 Thread Dmitry Baryshkov
On Tue, 24 Sept 2024 at 04:26, Vignesh Raman wrote: > > Update the documentation to require linking to a relevant GitLab > issue for each new flake entry instead of an email report. Added > specific GitLab issue URLs for i915, xe and other drivers. > > Signed-off-by: Vignesh Raman > --- > Docume

Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-09-23 Thread Dmitry Baryshkov
On Mon, 23 Sept 2024 at 22:05, Akhil P Oommen wrote: > > On Wed, Sep 18, 2024 at 12:27:03AM +0300, Dmitry Baryshkov wrote: > > On Wed, Sep 18, 2024 at 02:08:43AM GMT, Akhil P Oommen wrote: > > > From: Puranam V G Tejaswi > > > > > > Add gpu and gmu nodes for sa8775p based platforms. > > > > Which

Re: [PATCH v6 11/11] drm/v3d: Expose Super Pages capability

2024-09-23 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El lun, 23-09-2024 a las 10:55 -0300, Maíra Canal escribió: > Add a new V3D parameter to expose the support of Super Pages to > userspace. The userspace might want to know this information to > apply optimizations that are specific to kernels with Super Pages > ena

Re: [PATCH v6 01/11] drm/v3d: Address race-condition in MMU flush

2024-09-23 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El lun, 23-09-2024 a las 10:55 -0300, Maíra Canal escribió: > We must first flush the MMU cache and then, flush the TLB, not the > other > way around. Currently, we can see a race condition between the MMU > cache > and the TLB when running multiple rendering proce

[PATCH 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-23 Thread Pin-yen Lin
The bridge might miss the display change events when it's powered off. This happens when a user changes the external monitor when the system is suspended and the embedded controller doesn't not wake AP up. It's also observed that one DP-to-HDMI bridge doesn't work correctly when there is no EDID r

[PATCH 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-23 Thread Pin-yen Lin
The bridge might miss the display change events when it's powered off. This happens when a user changes the external monitor when the system is suspended and the embedded controller doesn't not wake AP up. It's also observed that one DP-to-HDMI bridge doesn't work correctly when there is no EDID r

[PATCH 0/2] Drop EDID cache for it6505/anx7625 when the bridge is powered off

2024-09-23 Thread Pin-yen Lin
This mainly fixes the use case when the user changes the external monitor when the system is suspended. Without this series, both of the bridges will skip the EDID read and returned the cached one after resume. Apart from that, we also observed a DP-to-HDMI bridge expects an EDID read after it's p

RE: [PATCH v3 3/3] drm/bridge: it6505: Add MCCS support

2024-09-23 Thread Hermes.Wu
>On Mon, Sep 23, 2024 at 05:48:29PM GMT, Hermes Wu wrote: >> From: Hermes Wu >> >> Changes in v3: >> -remove non used definition for aux i2x cmd reply >> >> Add Aux-I2C functionality to support MCCS. >> >> Signed-off-by: Hermes Wu >> --- >> drivers/gpu/drm/bridge/ite-it6505.c | 174 >> +

Re: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Pin-yen Lin
On Tue, Sep 24, 2024 at 10:57 AM wrote: > > >On Mon, Sep 23, 2024 at 10:45:49AM GMT, hermes...@ite.com.tw wrote: > >> >On Mon, Sep 23, 2024 at 05:48:28PM GMT, Hermes Wu wrote: > >> >> From: Hermes Wu > >> >> > >> >> Changes in v3: > >> >> -add detials about fail item and changes. > >> >> > >> >>

RE: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Hermes.Wu
>On Mon, Sep 23, 2024 at 10:45:49AM GMT, hermes...@ite.com.tw wrote: >> >On Mon, Sep 23, 2024 at 05:48:28PM GMT, Hermes Wu wrote: >> >> From: Hermes Wu >> >> >> >> Changes in v3: >> >> -add detials about fail item and changes. >> >> >> >> >> >> Fix HDCP CTS fail items on UNIGRAF DRP-100 >> >>

[PATCH v1] docs/gpu: ci: update flake tests requirements

2024-09-23 Thread Vignesh Raman
Update the documentation to require linking to a relevant GitLab issue for each new flake entry instead of an email report. Added specific GitLab issue URLs for i915, xe and other drivers. Signed-off-by: Vignesh Raman --- Documentation/gpu/automated_testing.rst | 15 ++- 1 file chang

Re: [PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread zhaoxiong lv
On Tue, Sep 24, 2024 at 5:14 AM Jessica Zhang wrote: > > > > On 9/23/2024 6:42 AM, Zhaoxiong Lv wrote: > > In MTK chips, if the system starts suspending before the DRM runtime > > resume has not completed, there is a possibility of a black screen > > after waking the machine. Reduce the disable de

radeon ARUBA NULL pointer dereference

2024-09-23 Thread Arthur Marsh
Using current Linus git head kernel, I was able to save the dmesg output: [ 17.218724] [drm] radeon kernel modesetting enabled. [ 17.218778] radeon :00:01.0: vgaarb: deactivate vga console [ 17.219509] Console: switching to colour dummy device 80x25 [ 17.219700] [drm] initializing kern

[PATCH v4] drm/mediatek: ovl: Add fmt_convert function pointer to driver data

2024-09-23 Thread Jason-JH . Lin
OVL_CON_CLRFMT_MAN is a configuration for extending color format settings of DISP_REG_OVL_CON(n). It will change some of the original color format settings. Take the settings of (3 << 12) for example. - If OVL_CON_CLRFMT_MAN = 0 means OVL_CON_CLRFMT_RGBA. - If OVL_CON_CLRFMT_MAN = 1 means OVL_

Re: [PATCH] drm/gpuvm: merge adjacent gpuva range during a map operation

2024-09-23 Thread Matthew Brost
On Tue, Sep 24, 2024 at 01:41:31AM +0200, Danilo Krummrich wrote: > (adding dri-devel) > > On Mon, Sep 23, 2024 at 02:24:02PM +, Zeng, Oak wrote: > > > > This patch is an old one in my back log. I roughly remember I ran into > > > a situation where there were two duplicated VMAs covering > > >

Re: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-23 Thread kernel test robot
Hi Liankun, kernel test robot noticed the following build errors: [auto build test ERROR on pza/reset/next] [also build test ERROR on linus/master v6.11 next-20240923] [cannot apply to pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()

2024-09-23 Thread Thorsten Blum
Since kvfree() already checks if its argument is NULL, an additional check before calling kvfree() is unnecessary and can be removed. Remove both and the following Coccinelle/coccicheck warnings reported by ifnullfree.cocci: WARNING: NULL check before some freeing functions is not needed WARN

Re: [PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-23 Thread kernel test robot
Hi Liankun, kernel test robot noticed the following build errors: [auto build test ERROR on pza/reset/next] [also build test ERROR on linus/master v6.11 next-20240923] [cannot apply to pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] drm/gpuvm: merge adjacent gpuva range during a map operation

2024-09-23 Thread Danilo Krummrich
(adding dri-devel) On Mon, Sep 23, 2024 at 02:24:02PM +, Zeng, Oak wrote: > > > This patch is an old one in my back log. I roughly remember I ran into > > a situation where there were two duplicated VMAs covering > > > Same virtual address range are kept in gpuvm's RB-tree. One VMA > > was act

Re: [PATCH v2] drm/sched: Fix dynamic job-flow control race

2024-09-23 Thread Danilo Krummrich
On Fri, Sep 13, 2024 at 01:23:01PM -0700, Rob Clark wrote: > From: Rob Clark > > Fixes a race condition reported here: > https://github.com/AsahiLinux/linux/issues/309#issuecomment-2238968609 > > The whole premise of lockless access to a single-producer-single- > consumer queue is that there is

Re: [PATCH] MAINTAINERS: drm/sched: Add new maintainers

2024-09-23 Thread Danilo Krummrich
On Mon, Sep 16, 2024 at 08:07:27PM +, Matthew Brost wrote: > On Mon, Sep 16, 2024 at 08:52:00PM +0200, Philipp Stanner wrote: > > DRM's GPU scheduler is arguably in need of more intensive maintenance. > > Danilo and Philipp volunteer to help with the maintainership. > > > > Signed-off-by: Phil

[PATCH v8 5/5] drm/panthor: add sysfs knob for enabling job profiling

2024-09-23 Thread Adrián Larumbe
This commit introduces a DRM device sysfs attribute that lets UM control the job accounting status in the device. The knob variable had been brought in as part of a previous commit, but now we're able to fix it manually. As sysfs files are part of a driver's uAPI, describe its legitimate input val

[PATCH v8 4/5] drm/panthor: enable fdinfo for memory stats

2024-09-23 Thread Adrián Larumbe
Implement drm object's status callback. Also, we consider a PRIME imported BO to be resident if its matching dma_buf has an open attachment, which means its backing storage had already been allocated. Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price Reviewed-by: Liviu Dudau Reviewed-by:

[PATCH v8 3/5] drm/panthor: add DRM fdinfo support

2024-09-23 Thread Adrián Larumbe
Drawing from the FW-calculated values in a previous commit, we can increase the numbers for an open file by collecting them from finished jobs when updating their group synchronisation objects. Display of fdinfo key-value pairs is governed by a bitmask that is by default unset in the present commi

[PATCH v8 2/5] drm/panthor: record current and maximum device clock frequencies

2024-09-23 Thread Adrián Larumbe
In order to support UM in calculating rates of GPU utilisation, the current operating and maximum GPU clock frequencies must be recorded during device initialisation, and also during OPP state transitions. Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price Reviewed-by: Boris Brezillon ---

[PATCH v8 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Adrián Larumbe
Enable calculations of job submission times in clock cycles and wall time. This is done by expanding the boilerplate command stream when running a job to include instructions that compute said times right before and after a user CS. A separate kernel BO is created per queue to store those values.

[PATCH v8 0/5] Support fdinfo runtime and memory stats on Panthor

2024-09-23 Thread Adrián Larumbe
This patch series enables userspace utilities like gputop and nvtop to query a render context's fdinfo file and figure out rates of engine and memory utilisation. Previous discussion can be found at https://lore.kernel.org/dri-devel/20240920234436.207563-1-adrian.laru...@collabora.com/ Changelog

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Jani Nikula
On Mon, 23 Sep 2024, Andy Shevchenko wrote: > On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote: >> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: >> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > ... > >> > > +extern const char *const wedge_recovery_o

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Helge Deller
On 9/23/24 23:30, Ville Syrjälä wrote: On Mon, Sep 23, 2024 at 11:04:55PM +0200, Helge Deller wrote: On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fb

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2024 at 11:04:55PM +0200, Helge Deller wrote: > On 9/23/24 17:57, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Currently setting cursor_blink attribute to 0 before any fb > > devices are around does absolutely nothing. When fb devices appear > > and fbcon becomes active the

Re: [PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Jessica Zhang
On 9/23/2024 5:25 AM, Tejas Vipin wrote: Changes the elida-kd35t133 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Hi Tejas, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang --- Changes in v2: - Changed mipi_dsi_dcs_write to mipi_dsi_d

Re: [PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the att

Re: [PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Jessica Zhang
On 9/23/2024 6:42 AM, Zhaoxiong Lv wrote: In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, Hi Zhaoxiong, Do you mean "if the system

[PATCH v2 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. v2: Rebase due to corrected 'fbcon_cursor_blink' initial value Acked-by: Helge Deller Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+), 11

[PATCH v2 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place v2: Set the initial value to 1 to keep the same default behaviour (Helge) Cc: Helge Deller Signed-off-by:

Re: [PATCH v7 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Adrián Larumbe
On 23.09.2024 10:07, Steven Price wrote: >On 21/09/2024 00:43, Adrián Larumbe wrote: >> Enable calculations of job submission times in clock cycles and wall >> time. This is done by expanding the boilerplate command stream when running >> a job to include instructions that compute said times right

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-23 Thread Adrián Larumbe
Hi Steve, On 23.09.2024 09:55, Steven Price wrote: >On 20/09/2024 23:36, Adrián Larumbe wrote: >> Hi Steve, thanks for the review. > >Hi Adrián, > >> I've applied all of your suggestions for the next patch series revision, so >> I'll >> only be answering to your question about the calc_profiling_

Re: [PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjälä
On Mon, Sep 23, 2024 at 09:46:03PM +0200, Helge Deller wrote: > On 9/23/24 17:57, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: > > - it matches the sysfs attribute exactly > > - avoids having to do these NOT operations all over t

Re: [PATCH] drm/nouveau/i2c: rename aux.c and aux.h to auxch.c and auxch.h

2024-09-23 Thread Szőke Benjamin
2024. 06. 03. 11:15 keltezéssel, egyszer...@freemail.hu írta: From: Benjamin Szőke The goal is to clean-up Linux repository from AUX file names, because the use of such file names is prohibited on other operating systems such as Windows, so the Linux repository cannot be cloned and edited on th

Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-09-23 Thread Akhil P Oommen
On Wed, Sep 18, 2024 at 12:27:03AM +0300, Dmitry Baryshkov wrote: > On Wed, Sep 18, 2024 at 02:08:43AM GMT, Akhil P Oommen wrote: > > From: Puranam V G Tejaswi > > > > Add gpu and gmu nodes for sa8775p based platforms. > > Which platforms? The commit adds nodes to the SoC and the single RIDE > p

Re: [PATCH 0/3] DRM/MSM: Support for Adreno 663 GPU

2024-09-23 Thread Akhil P Oommen
On Wed, Sep 18, 2024 at 12:34:32AM +0300, Dmitry Baryshkov wrote: > On Wed, Sep 18, 2024 at 02:08:40AM GMT, Akhil P Oommen wrote: > > This series adds support for Adreno 663 gpu found in SA8775P chipsets. > > The closest gpu which is currently supported in drm-msm is A660. > > Following are the maj

Re: [PATCH 1/3] drm/msm/a6xx: Add support for A663

2024-09-23 Thread Akhil P Oommen
On Wed, Sep 18, 2024 at 06:51:50PM +0100, Connor Abbott wrote: > On Tue, Sep 17, 2024 at 9:39 PM Akhil P Oommen > wrote: > > > > From: Puranam V G Tejaswi > > > > Add support for Adreno 663 found on sa8775p based platforms. > > > > Signed-off-by: Puranam V G Tejaswi > > Signed-off-by: Akhil P O

Re: [PATCH 4/6] fbcon: fbcon_is_inactive() -> fbcon_is_active()

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Invert fbcon_is_inactive() into fbcon_is_active(). Much easier on the poor brain when you don't have to do dobule negations all over the place. Agreed. Acked-by: Helge Deller Signed-off-by: Ville Syrjälä --- drivers/video/fbdev

Re: [PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c |

Re: [PATCH 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. Signed-off-by: Ville Syrjälä Looks good. Acked-by: Helge Deller Helge --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+),

Re: [PATCH v4 09/11] drm/msm/A6XX: Add a flag to allow preemption to submitqueue_create

2024-09-23 Thread Akhil P Oommen
On Fri, Sep 20, 2024 at 10:29:44AM -0700, Rob Clark wrote: > On Fri, Sep 20, 2024 at 9:54 AM Akhil P Oommen > wrote: > > > > On Tue, Sep 17, 2024 at 01:14:19PM +0200, Antonino Maniscalco wrote: > > > Some userspace changes are necessary so add a flag for userspace to > > > advertise support for p

Re: [PATCH 5/6] fbcon: Introduce get_{fg,bg}_color()

2024-09-23 Thread Helge Deller
On 9/23/24 17:57, Ville Syrjala wrote: From: Ville Syrjälä Make the code more legible by adding get_{fg,bg}_color() which hide the obscure 'is_fg' parameter of get_color() from the caller. Signed-off-by: Ville Syrjälä Nice cleanup. Acked-by: Helge Deller --- drivers/video/fbdev/core/f

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/23/24 21:09, Dmitry Osipenko wrote: >> Sure, I can do that if others prefer this way too. > Note that in the other email I suggested to use strndup_user(), that > will remove the name-length limitation, but then the name var will > remain to be a string pointer. To me best option would be to r

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Dmitry Osipenko
On 9/23/24 19:29, Pierre-Eric Pelloux-Prayer wrote: ... >>> @@ -78,12 +78,13 @@ static int drm_clients_info(struct seq_file *m, >>> void *data) >>>   kuid_t uid; >>>     seq_printf(m, >>> -   "%20s %5s %3s master a %5s %10s\n", >>> +   "%20s %5s %3s master a %5s %10s %20s\n"

Re: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings

2024-09-23 Thread Marek Vasut
On 9/23/24 3:57 PM, Lukasz Majewski wrote: Up till now the fsl,lcdif.yaml was requiring the "port" property as a must have to specify the display interface on iMX devices. However, it shall also be possible to specify the display only with passing its timing parameters (h* and v* ones) via "disp

Re: [PATCH v3 1/6] drm: add DRM_SET_NAME ioctl

2024-09-23 Thread Pierre-Eric Pelloux-Prayer
Hi Dmitry, Le 23/09/2024 à 12:28, Dmitry Osipenko a écrit : On 9/20/24 12:06, Pierre-Eric Pelloux-Prayer wrote: Giving the opportunity to userspace to associate a free-form name with a drm_file struct is helpful for tracking and debugging. This is similar to the existing DMA_BUF_SET_NAME ioctl

[PATCH v7 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-09-23 Thread Alex Lanzano
Add support for the monochrome Sharp Memory LCDs. Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Dmitry Baryshkov --- MAINTAINERS | 6 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile

[PATCH v7 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-09-23 Thread Alex Lanzano
Add device tree bindings for the monochrome Sharp Memory LCD Co-developed-by: Mehdi Djait Signed-off-by: Mehdi Djait Signed-off-by: Alex Lanzano Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/sharp,ls010b7dh04.yaml | 92 +++ 1 file changed, 92 insertions(+) creat

[PATCH v7 0/2] Add driver for Sharp Memory LCD

2024-09-23 Thread Alex Lanzano
This patch series add support for the monochrome Sharp Memory LCD panels. This series is based off of the work done by Mehdi Djait. References: https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.dj...@bootlin.com/ https://www.sharpsde.com/fileadmin/prod

[PATCH 6/6] fbcon: Use 'bool' where appopriate

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Use 'bool' type where it makes more sense than 'int'. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/

[PATCH 4/6] fbcon: fbcon_is_inactive() -> fbcon_is_active()

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_is_inactive() into fbcon_is_active(). Much easier on the poor brain when you don't have to do dobule negations all over the place. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 30 +++--- 1 file changed, 15 insertio

[PATCH 5/6] fbcon: Introduce get_{fg,bg}_color()

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Make the code more legible by adding get_{fg,bg}_color() which hide the obscure 'is_fg' parameter of get_color() from the caller. Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-

[PATCH 3/6] fbcon: fbcon_cursor_noblink -> fbcon_cursor_blink

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Invert fbcon_cursor_noblink into fbcon_cursor_blink so that: - it matches the sysfs attribute exactly - avoids having to do these NOT operations all over the place Signed-off-by: Ville Syrjälä --- drivers/video/fbdev/core/fbcon.c | 8 1 file changed, 4 insertions(+

[PATCH 2/6] fbcon: Add sysfs attributes before registering the device

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Currently fbcon adds the attributes after registering the device, which means the attributes may not be there by the time udev gets the ADD uevent. Fix the race by switching over to device_create_with_groups(). With this one can reliably turn off the power wasting cursor blin

[PATCH 1/6] fbcon: Make cursor_blink=0 work when configured before fb devices appear

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Currently setting cursor_blink attribute to 0 before any fb devices are around does absolutely nothing. When fb devices appear and fbcon becomes active the cursor starts blinking. Fix the problem by recoding the desired state of the attribute even if no fb devices are present

[PATCH 0/6] fbcon: Fix 'cursor_blink' sysfs attribute

2024-09-23 Thread Ville Syrjala
From: Ville Syrjälä Make the 'cursor_blink' sysfs attribute actually usable from udev rules. I also took the opportinity to some cleanups t the code after getting annoyed by it. Ville Syrjälä (6): fbcon: Make cursor_blink=0 work when configured before fb devices appear fbcon: Add sysfs a

Re: [PATCH 3/3] drm/rockchip: vop: Split rk3288-vop into big and lit

2024-09-23 Thread Krzysztof Kozlowski
On 23/09/2024 11:01, Jonas Karlman wrote: >>> 0, 0, >>> @@ -1245,8 +1253,13 @@ static const struct of_device_id >>> vop_driver_dt_match[] = { >>> .data = &rk3066_vop }, >>> { .compatible = "rockchip,rk3188-vop", >>> .data = &rk3188_vop }, >>> + { .compatible = "rockchip,rk328

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-09-23 Thread Christian König
Am 20.09.24 um 15:26 schrieb Philipp Stanner: On Fri, 2024-09-20 at 12:33 +0200, Christian König wrote: Am 20.09.24 um 10:57 schrieb Philipp Stanner: On Wed, 2024-09-18 at 15:39 +0200, Christian König wrote: Tearing down the scheduler with jobs still on the pending list can lead to use after f

[PATCH] drm/v3d: Use v3d_perfmon_find(..)

2024-09-23 Thread Christian Gmeiner
From: Christian Gmeiner Replace the open coded v3d_perfmon_find(..) with the real thing. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/v3d/v3d_perfmon.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Andy Shevchenko
On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote: > On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: > > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: ... > > > +extern const char *const wedge_recovery_opts[]; > > > > It's not NULL terminated. How users wi

Re: [PATCH v2] drm/sched: Further optimise drm_sched_entity_push_job

2024-09-23 Thread Tvrtko Ursulin
Ping Christian and Philipp - reasonably happy with v2? I think it's the only unreviewed patch from the series. Regards, Tvrtko On 16/09/2024 18:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having removed one re-lock cycle on the entity->lock in a patch titled "drm/sched: Optimise drm_s

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Raag Jadav
On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in ca

[PATCH v6 10/11] drm/v3d: Add modparam for turning off Big/Super Pages

2024-09-23 Thread Maíra Canal
Add a modparam for turning off Big/Super Pages to make sure that if an user doesn't want Big/Super Pages enabled, it can disabled it by setting the modparam to false. Signed-off-by: Maíra Canal Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_drv.c | 7 +++ drivers/gpu/drm/v3d/v3d_

[PATCH v6 09/11] drm/v3d: Use gemfs/THP in BO creation if available

2024-09-23 Thread Maíra Canal
Although Big/Super Pages could appear naturally, it would be quite hard to have 1MB or 64KB allocated contiguously naturally. Therefore, we can force the creation of large pages allocated contiguously by using a mountpoint with "huge=within_size" enabled. Therefore, as V3D has a mountpoint with "h

[PATCH v6 08/11] drm/v3d: Support Big/Super Pages when writing out PTEs

2024-09-23 Thread Maíra Canal
The V3D MMU also supports 64KB and 1MB pages, called big and super pages, respectively. In order to set a 64KB page or 1MB page in the MMU, we need to make sure that page table entries for all 4KB pages within a big/super page must be correctly configured. In order to create a big/super page, we n

[PATCH v6 06/11] drm/gem: Create shmem GEM object in a given mountpoint

2024-09-23 Thread Maíra Canal
Create a function `drm_gem_shmem_create_with_mnt()`, similar to `drm_gem_shmem_create()`, that has a mountpoint as a argument. This function will create a shmem GEM object in a given tmpfs mountpoint. This function will be useful for drivers that have a special mountpoint with flags enabled. Sign

[PATCH v6 07/11] drm/v3d: Reduce the alignment of the node allocation

2024-09-23 Thread Maíra Canal
Currently, we are using an alignment of 128 kB to insert a node, which ends up wasting memory as we perform plenty of small BOs allocations (<= 4 kB). We require that allocations are aligned to 128Kb so for any allocation smaller than that, we are wasting the difference. This implies that we canno

[PATCH v6 05/11] drm/v3d: Introduce gemfs

2024-09-23 Thread Maíra Canal
Create a separate "tmpfs" kernel mount for V3D. This will allow us to move away from the shmemfs `shm_mnt` and gives the flexibility to do things like set our own mount options. Here, the interest is to use "huge=", which should allow us to enable the use of THP for our shmem-backed objects. Signe

[PATCH v6 11/11] drm/v3d: Expose Super Pages capability

2024-09-23 Thread Maíra Canal
Add a new V3D parameter to expose the support of Super Pages to userspace. The userspace might want to know this information to apply optimizations that are specific to kernels with Super Pages enabled. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 3 +++ include/uapi/drm/v3d_dr

[PATCH v6 04/11] drm/gem: Create a drm_gem_object_init_with_mnt() function

2024-09-23 Thread Maíra Canal
For some applications, such as applications that uses huge pages, we might want to have a different mountpoint, for which we pass mount flags that better match our usecase. Therefore, create a new function `drm_gem_object_init_with_mnt()` that allow us to define the tmpfs mountpoint where the GEM

[PATCH v6 03/11] drm/v3d: Fix return if scheduler initialization fails

2024-09-23 Thread Maíra Canal
If the scheduler initialization fails, GEM initialization must fail as well. Therefore, if `v3d_sched_init()` fails, free the DMA memory allocated and return the error value in `v3d_gem_init()`. Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- drivers/gpu/drm/v3d/v3d_gem.c | 3 ++-

[PATCH v6 02/11] drm/v3d: Flush the MMU before we supply more memory to the binner

2024-09-23 Thread Maíra Canal
We must ensure that the MMU is flushed before we supply more memory to the binner, otherwise we might end up with invalid MMU accesses by the GPU. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- d

[PATCH v6 00/11] drm/v3d: Enable Big and Super Pages

2024-09-23 Thread Maíra Canal
This series introduces support for big and super pages in V3D. The V3D MMU has support for 64KB and 1MB pages, called big pages and super pages, which are currently not used. Therefore, this patchset has the intention to enable big and super pages in V3D. The advantage of enabling big and super pag

[PATCH v6 01/11] drm/v3d: Address race-condition in MMU flush

2024-09-23 Thread Maíra Canal
We must first flush the MMU cache and then, flush the TLB, not the other way around. Currently, we can see a race condition between the MMU cache and the TLB when running multiple rendering processes at the same time. This is evidenced by MMU errors triggered by the IRQ. Fix the MMU flush order by

Re: [PATCH] dma-buf: Add syntax highlighting to code listings in the document

2024-09-23 Thread Christian König
Nothing wrong with this, I just didn't had time to double check it myself and then forgotten about it. Going to push it to drm-misc-next. Regards, Christian. Am 23.09.24 um 11:22 schrieb Tommy Chiang: Ping. Please let me know if I'm doing something wrong. On Mon, Feb 19, 2024 at 11:00 AM To

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 09:38:59PM GMT, zhaoxiong lv wrote: > On Mon, Sep 23, 2024 at 8:07 PM Dmitry Baryshkov > wrote: > > > > On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > > > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > > > wrote: > > > > > > > > Same comment as the one t

[PATCH v2 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Zhaoxiong Lv
In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight off" and "disp

[PATCH v2 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Zhaoxiong Lv
In MTK chips, if the system starts suspending before the DRM runtime resume has not completed, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight off" and "disp

[PATCH v2 0/2] Modify the timing of three panels

2024-09-23 Thread Zhaoxiong Lv
Modify the power-off sequence of the Kingdisplay/Starry/Melfas panel. Changes between V2 and V1: - PATCH 1/2: Modify the commit message -Modify the value of backlight_off_to_display_off_delay_ms. - PATCH 2/2: Modify the commit message. -Delete the value of backlight_off_to

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread zhaoxiong lv
On Mon, Sep 23, 2024 at 8:07 PM Dmitry Baryshkov wrote: > > On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > > wrote: > > > > > > Same comment as the one that I've provided to the other patch, plus: > > > > > > On Sun, 15 Sept 2024

Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread zhaoxiong lv
On Mon, Sep 23, 2024 at 8:05 PM Dmitry Baryshkov wrote: > > On Mon, Sep 23, 2024 at 05:22:11PM GMT, zhaoxiong lv wrote: > > On Mon, Sep 16, 2024 at 1:11 PM Dmitry Baryshkov > > wrote: > > > > > > On Sun, 15 Sept 2024 at 10:10, Zhaoxiong Lv > > > wrote: > > > > > > > > In order to meet the timing

[PATCH v1 1/1] drm/mediatek: dp: Add sdp path reset

2024-09-23 Thread Liankun Yang
When using type-c to type-c to connect to the monitor, the sound plays normally. If you unplug the type-c and connect the type-c to hdmi dongle to the monitor, there will be noise. By capturing the audio data, it is found that the data position is messy, and there is no error in the data. Through

[PATCH v5 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-23 Thread Liankun Yang
Update efuse data for MT8188 displayport. The DP monitor can not display when DUT connected to USB-c to DP dongle. Analysis view is invalid DP efuse data. Fixes: 350c3fe907fb ("drm/mediatek: dp: Add support MT8188 dp/edp function") Reviewed-by: Matthias Brugger Reviewed-by: AngeloGioacchino Del

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-23 Thread Mark Brown
On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > Just do normal open coded allocations, the reference counting is just > > obscure. > T

Re: [PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:55:58PM GMT, Tejas Vipin wrote: > Changes the elida-kd35t133 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Changed mipi_dsi_dcs_write to mipi_dsi_dcs_write_buffer_multi > - Cleaned up

Re: [PATCH] fbdev: pxa3xx-gcu: Convert comma to semicolon

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 02, 2024 at 03:57:24PM GMT, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni > --- > drivers/video/fbdev/pxa3xx-gcu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best

[PATCH v2] drm/panel: elida-kd35t133: transition to mipi_dsi wrapped functions

2024-09-23 Thread Tejas Vipin
Changes the elida-kd35t133 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- Changes in v2: - Changed mipi_dsi_dcs_write to mipi_dsi_dcs_write_buffer_multi - Cleaned up error handling Link to v1: https://lore.kernel.org/all/20240917071710.125

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-09-23 Thread Dmitry Baryshkov
x27;s patch - patch > >>>>>> 2/2 - > >>>>>> will only fix the dpi version of the edid_read()? > >>>>>> > >>>>>> The bridge already has the capability to distinguish a DSI input > >>>>>> from a > &g

Re: [PATCH] drm: writeback: Introduce drm managed helpers

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 11:54:57AM GMT, Louis Chauvet wrote: > Le 22/09/24 - 18:31, Dmitry Baryshkov a écrit : > > On Fri, Sep 06, 2024 at 07:28:17PM GMT, Louis Chauvet wrote: > > > Currently drm_writeback_connector are created by > > > drm_writeback_connector_init or drm_writeback_connector_init_w

Re: [PATCH v1 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:22:20PM GMT, zhaoxiong lv wrote: > On Mon, Sep 16, 2024 at 1:15 PM Dmitry Baryshkov > wrote: > > > > Same comment as the one that I've provided to the other patch, plus: > > > > On Sun, 15 Sept 2024 at 10:11, Zhaoxiong Lv > > wrote: > > > > > > In order to meet the timi

Re: [PATCH v1 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:22:11PM GMT, zhaoxiong lv wrote: > On Mon, Sep 16, 2024 at 1:11 PM Dmitry Baryshkov > wrote: > > > > On Sun, 15 Sept 2024 at 10:10, Zhaoxiong Lv > > wrote: > > > > > > In order to meet the timing, remove the delay between "backlight off" > > > and "display off" > > > >

Re: [PATCH] drm: Consistently use struct drm_mode_rect for FB_DAMAGE_CLIPS

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 09:58:14AM GMT, Thomas Zimmermann wrote: > FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI > should only use UAPI types. Hence replace struct drm_rect with > struct drm_mode_rect in drm_atomic_plane_set_property(). Both types > are identical in practice, so

Re: [PATCH v3 3/3] drm/bridge: it6505: Add MCCS support

2024-09-23 Thread Dmitry Baryshkov
On Mon, Sep 23, 2024 at 05:48:29PM GMT, Hermes Wu wrote: > From: Hermes Wu > > Changes in v3: > -remove non used definition for aux i2x cmd reply > > Add Aux-I2C functionality to support MCCS. > > Signed-off-by: Hermes Wu > --- > drivers/gpu/drm/bridge/ite-it6505.c | 174

  1   2   >