Re: [PATCH 5/6] fbcon: Introduce get_{fg,bg}_color()

[Helge Deller]

On 9/23/24 17:57, Ville Syrjala wrote:

From: Ville Syrjälä <ville.syrj...@linux.intel.com>

Make the code more legible by adding get_{fg,bg}_color()
which hide the obscure 'is_fg' parameter of get_color()
from the caller.

Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>

Nice cleanup.
Acked-by: Helge Deller <del...@gmx.de>

---
  drivers/video/fbdev/core/fbcon.c | 24 ++++++++++++++++++------
  1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 2a78cca3e9de..17540cdf1edf 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -356,6 +356,16 @@ static int get_color(struct vc_data *vc, struct fb_info 
*info,
        return color;
  }

+static int get_fg_color(struct vc_data *vc, struct fb_info *info, u16 c)
+{
+       return get_color(vc, info, c, 1);
+}
+
+static int get_bg_color(struct vc_data *vc, struct fb_info *info, u16 c)
+{
+       return get_color(vc, info, c, 0);
+}
+
  static void fb_flashcursor(struct work_struct *work)
  {
        struct fbcon_ops *ops = container_of(work, struct fbcon_ops, 
cursor_work.work);
@@ -387,8 +397,9 @@ static void fb_flashcursor(struct work_struct *work)

        c = scr_readw((u16 *) vc->vc_pos);
        enable = ops->cursor_flash && !ops->cursor_state.enable;
-       ops->cursor(vc, info, enable, get_color(vc, info, c, 1),
-                   get_color(vc, info, c, 0));
+       ops->cursor(vc, info, enable,
+                   get_fg_color(vc, info, c),
+                   get_bg_color(vc, info, c));
        console_unlock();

        queue_delayed_work(system_power_efficient_wq, &ops->cursor_work,
@@ -1297,8 +1308,8 @@ static void fbcon_putcs(struct vc_data *vc, const u16 *s, 
unsigned int count,

        if (fbcon_is_active(vc, info))
                ops->putcs(vc, info, s, count, real_y(p, ypos), xpos,
-                          get_color(vc, info, scr_readw(s), 1),
-                          get_color(vc, info, scr_readw(s), 0));
+                          get_fg_color(vc, info, scr_readw(s)),
+                          get_bg_color(vc, info, scr_readw(s)));
  }

  static void fbcon_clear_margins(struct vc_data *vc, int bottom_only)
@@ -1331,8 +1342,9 @@ static void fbcon_cursor(struct vc_data *vc, bool enable)
        if (!ops->cursor)
                return;

-       ops->cursor(vc, info, enable, get_color(vc, info, c, 1),
-                   get_color(vc, info, c, 0));
+       ops->cursor(vc, info, enable,
+                   get_fg_color(vc, info, c),
+                   get_bg_color(vc, info, c));
  }

  static int scrollback_phys_max = 0;