Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-02 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:02PM +0800, Jianeng Ceng wrote: > Add an entry for the MT8186 based Ponyta Chromebook (custom lable). > > Signed-off-by: Jianeng Ceng > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/D

[PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-02 Thread sikkamukul
From: Bob Zhou [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] Check return value and conduct null pointer handling to avoid null pointer dereference. Signed-off-by: Bob Zhou Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Mukul Sik

[PATCH v2] drm: drm_fourcc: adding 10/12/14 bit formats

2024-09-02 Thread Yulia Garbovich
Adding the following formats - DRM_FORMAT_RX106 - DRM_FORMAT_GXRX106106 - DRM_FORMAT_RX124 - DRM_FORMAT_GXRX124124 - DRM_FORMAT_AXBXGXRX124124124124 - DRM_FORMAT_RX142 - DRM_FORMAT_GXRX142142 - DRM_FORMAT_AXBXGXRX142142142142 They are useful for communicatin

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-02 Thread Mikhail Gavrilov
On Sun, Aug 25, 2024 at 2:12 AM Mikhail Gavrilov wrote: > > Hi, > Is anyone trying to look into it? > I continue to reproduce this issue on fresh kernel builds 6.11-rc4+. > In addition to the RenPy engine, the problem also reproduces on games > from Ubisoft, such as Far Cry 4. > A very important n

[PATCH v2 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-02 Thread Jianeng Ceng
MT8186 ponyta, known as huaqin custom lable, is a MT8186 based laptop. It is based on the "corsola" design. It includes LTE, touchpad combinations. Signed-off-by: Jianeng Ceng --- arch/arm64/boot/dts/mediatek/Makefile | 2 + .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++

[PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-02 Thread Jianeng Ceng
Add an entry for the MT8186 based Ponyta Chromebook (custom lable). Signed-off-by: Jianeng Ceng --- Documentation/devicetree/bindings/arm/mediatek.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree

[PATCH v2 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-02 Thread Jianeng Ceng
This is v2 of the MT8186 Chromebook device tree series. Jianeng Ceng (2): dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks .../devicetree/bindings/arm/mediatek.yaml | 11 + arch/arm64/boot/dts/mediatek/Makefile | 2

Re: [PATCH v1 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-02 Thread kernel test robot
Hi Jianeng, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.11-rc6 next-20240902] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-02 Thread Sandor Yu
mutex_lock(&mhdp->mbox_mutex); > > + ret = phy_configure(mhdp->phy, &phy_cfg); > > + mutex_unlock(&mhdp->mbox_mutex); > > + if (ret) { > > + dev_err(mhdp->dev, "%s: phy_configure() failed: %

RE: [EXT] Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-02 Thread Sandor Yu
> > Le 02/07/2024 à 14:22, Sandor Yu a écrit : > > Add a new DRM DisplayPort and HDMI bridge driver for Candence > MHDP8501 > > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort > > standards according embedded Firmware running in the uCPU. > > > > For iMX8MQ SOC, the DisplayPort/H

RE: [PATCHv2 3/5] Add crtc properties for global histogram

2024-09-02 Thread Kulkarni, Vandita
+dri-devel > -Original Message- > From: Kulkarni, Vandita > Sent: Tuesday, September 3, 2024 10:54 AM > To: Arun R Murthy ; intel- > g...@lists.freedesktop.org; drm-devel@lists.freedesktop > Cc: Murthy, Arun R > Subject: RE: [PATCHv2 3/5] Add crtc properties for global histogram > > > --

Re: [PATCH 1/2] drm/amd/display: Avoid race between dcn10_set_drr() and dc_state_destruct()

2024-09-02 Thread Christopher Snowhill
On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote: > From: Tobias Jakobi > > dc_state_destruct() nulls the resource context of the DC state. The pipe > context passed to dcn10_set_drr() is a member of this resource context. > > If dc_state_destruct() is called parallel to the IRQ processing (which

Re: [PATCH v1 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-02 Thread kernel test robot
Hi Jianeng, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.11-rc6 next-20240902] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[PATCH v6 14/15] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-09-02 Thread Dmitry Baryshkov
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_fo

[PATCH v6 11/15] drm/msm/dpu: make dpu_format_populate_addrs return void

2024-09-02 Thread Dmitry Baryshkov
The function msm_framebuffer_iova() can not fail, it always returns a valid address. Drop the useless checks (that were already performed at the time) and make dpu_format_populate_addrs() return void. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_e

[PATCH v6 10/15] drm/msm/dpu: split dpu_format_populate_layout

2024-09-02 Thread Dmitry Baryshkov
Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

[PATCH v6 15/15] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-09-02 Thread Dmitry Baryshkov
Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov ---

[PATCH v6 13/15] drm/msm/dpu: check for the plane pitch overflow

2024-09-02 Thread Dmitry Baryshkov
Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +

[PATCH v6 12/15] drm/msm/dpu: move layout setup population out of dpu_plane_prepare_fb()

2024-09-02 Thread Dmitry Baryshkov
Move the call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. At the same time move the call to dpu_format_populate_addrs() to dpu_plane_sspp_atomic_update(). This way the all layout management is performed

[PATCH v6 08/15] drm/msm/dpu: pass drm_framebuffer to _dpu_format_get_plane_sizes()

2024-09-02 Thread Dmitry Baryshkov
Instead of passing width / height / pitches, pass drm_framebuffer directly. This allows us to drop the useless check for !pitches, since an array can not be NULL. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 73 ++--

[PATCH v6 03/15] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-09-02 Thread Dmitry Baryshkov
Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/m

[PATCH v6 05/15] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-09-02 Thread Dmitry Baryshkov
The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v6 09/15] drm/msm/dpu: move pitch check to _dpu_format_get_plane_sizes_linear()

2024-09-02 Thread Dmitry Baryshkov
The _dpu_format_get_plane_sizes_linear() already compares pitches of the framebuffer with the calculated pitches. Move the check to the same place, demoting DPU_ERROR to DPU_DEBUG to prevent user from spamming the kernel log. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- driver

[PATCH v6 02/15] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_check

2024-09-02 Thread Dmitry Baryshkov
Historically CRTC resources (LMs and CTLs) were assigned in dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw resource tracking to crtc state") simply moved resources to struct dpu_crtc_state, without changing the code sequence. Later on the commit b107603b4ad0 ("drm/msm/dpu:

[PATCH v6 07/15] drm/msm/dpu: drop msm_format from struct dpu_hw_fmt_layout

2024-09-02 Thread Dmitry Baryshkov
The struct dpu_hw_fmt_layout defines hardware data layout (addresses, sizes and pitches. Drop format field from this structure as it's not a part of the data layout. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 31 +++---

[PATCH v6 06/15] drm/msm/dpu: drop extra aspace checks in dpu_formats

2024-09-02 Thread Dmitry Baryshkov
The DPU driver isn't expected to be used without an IOMMU. Thus the aspace will be always present. Not to mention that mdp4/mdp5 drivers call msm_framebuffer_iova() without such checks, as the whole msm_framebuffer layer is expected to support both IOMMU and IOMMU-less configurations. Drop these u

[PATCH v6 04/15] drm/msm/dpu: drop dpu_format_check_modified_format

2024-09-02 Thread Dmitry Baryshkov
The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/ms

[PATCH v6 01/15] drm/msm/dpu: make sure phys resources are properly initialized

2024-09-02 Thread Dmitry Baryshkov
The commit b954fa6baaca ("drm/msm/dpu: Refactor rm iterator") removed zero-init of the hw_ctl array, but didn't change the error condition, that checked for hw_ctl[i] being NULL. At the same time because of the early returns in case of an error dpu_encoder_phys might be left with the resources assi

[PATCH v6 00/15] drm/msm/dpu: be more friendly to X.org

2024-09-02 Thread Dmitry Baryshkov
Unlike other compositors X.org allocates a single framebuffer covering the whole screen space. This is not an issue with the single screens, but with the multi-monitor setup 5120x4096 becomes a limiting factor. Check the hardware-bound limitations and lift the FB max size to 16383x16383. Signed-of

Re: [PATCH v5 03/16] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_mode_set

2024-09-02 Thread Dmitry Baryshkov
On Wed, 17 Jul 2024 at 01:40, Abhinav Kumar wrote: > > > > On 6/24/2024 2:13 PM, Dmitry Baryshkov wrote: > > Historically CRTC resources (LMs and CTLs) were assigned in > > dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw > > resource tracking to crtc state") simply moved re

[PATCH] drm/i915: convert comma to semicolon

2024-09-02 Thread Chen Ni
Replace a comma between expression statements by a semicolon. Signed-off-by: Chen Ni --- drivers/gpu/drm/i915/display/intel_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index

[PATCH v3] drm/etnaviv: Request pages from DMA32 zone on addressing_limited

2024-09-02 Thread Xiaolei Wang
Remove __GFP_HIGHMEM when requesting a page from DMA32 zone, and since all vivante GPUs in the system will share the same DMA constraints, move the check of whether to get a page from DMA32 to etnaviv_bind(). Fixes: b72af445cd38 ("drm/etnaviv: request pages from DMA32 zone when needed") Suggested-

[PATCH v5 3/3] drm/bridge-connector: reset the HDMI connector state

2024-09-02 Thread Dmitry Baryshkov
On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI IGT chokes on the max_bpc property in several kms_properties tests due to the drm_bridge_connector failing to reset HDMI-related properties. Call __drm_atomic_helper_connector_hdmi_reset() if the drm_bridge_connector has brid

[PATCH v5 0/3] drm: fix two issues related to HDMI Connector implementation

2024-09-02 Thread Dmitry Baryshkov
Running IGT tests on Qualcomm Dragonboard820c uncovered two issues with the HDMI Connector implementation and with its integration into the drm_bridge_connector. Fix those issues. Note, I'm not fully satisfied with the drm_bridge_connector move. Maybe it's better to add drm_bridge_funcs::connector

[PATCH v5 2/3] drm/bridge-connector: move to DRM_DISPLAY_HELPER module

2024-09-02 Thread Dmitry Baryshkov
drm_bridge_connector is a "leaf" driver, belonging to the display helper, rather than the "CRTC" drm_kms_helper module. Move the driver to the drm/display and add necessary Kconfig selection clauses. Suggested-by: Maxime Ripard Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- MAINTA

[PATCH v5 1/3] drm/display: stop depending on DRM_DISPLAY_HELPER

2024-09-02 Thread Dmitry Baryshkov
Kconfig symbols should not declare dependency on DRM_DISPLAY_HELPER. Move all parts of DRM_DISPLAY_HELPER to an if DRM_DISPLAY_HELPER block. It is not possible to make those symbols select DRM_DISPLAY_HELPER because of the link issues when a part of the helper is selected to be built-in, while oth

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

2024-09-02 Thread Ryan Walklin
On Fri, 30 Aug 2024, at 7:56 PM, Neil Armstrong wrote: Thanks Neil, > > The only valid compatible with anbernic would be to use the exact > device in use and not a wildcard, > so you said the 3 devices using this panel are: > anbernic,rg35xx-2024 > anbernic,rg35xx-plus > anbernic,rg35xx-h

[PATCH RESEND] drm/nouveau: fix a possible null pointer dereference

2024-09-02 Thread Ma Ke
In ch7006_encoder_get_modes(), the return value of drm_mode_duplicate() is used directly in drm_mode_probed_add(), which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: 6ee738610f41 ("drm/nouveau: Add DRM drive

Re: [v2] drm/etnaviv: Clear the __GFP_HIGHMEM bit in GFP_HIGHUSER with 32 address

2024-09-02 Thread wang xiaolei
On 8/31/24 8:03 AM, Sui Jingfeng wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hi, Xiaolei Thanks for your nice catch! I have more to say. On 2024/8/16 09:55, Wang,

[PATCH -next] drm/msm: Remove unneeded semicolon

2024-09-02 Thread Yang Li
./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852 Signed-off-by: Yang Li --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-09-02 Thread Matthew Brost
On Mon, Sep 02, 2024 at 02:48:55PM +0200, Daniel Vetter wrote: > On Thu, Aug 29, 2024 at 10:12:53PM +, Matthew Brost wrote: > > On Thu, Aug 29, 2024 at 01:02:54PM +0200, Daniel Vetter wrote: > > > On Thu, Aug 29, 2024 at 11:53:58AM +0200, Thomas Hellström wrote: > > > > But as Sima pointed out

Re: [PATCH v5 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-09-02 Thread Cristian Ciocaltea
On 9/2/24 4:09 AM, Shimrra Shai wrote: > Cristian Ciocaltea wrote: >> On 8/31/24 9:13 AM, Krzysztof Kozlowski wrote: >>> >>> Please define all clocks. >> >> The other clocks are defined in the common binding, should we reiterate >> them? > > I would suggest yes, they should be reduplicated, if onl

Re: [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-02 Thread Cristian Ciocaltea
On 9/2/24 10:36 AM, Maxime Ripard wrote: > On Sat, Aug 31, 2024 at 01:21:48AM GMT, Cristian Ciocaltea wrote: >> On 8/27/24 11:58 AM, Maxime Ripard wrote: >>> On Mon, Aug 19, 2024 at 01:29:29AM GMT, Cristian Ciocaltea wrote: +static irqreturn_t dw_hdmi_qp_main_hardirq(int irq, void *dev_id) >>>

Re: WARNING: CPU: 0 PID: 8 at drivers/video/fbdev/core/fbmem.c:467 unregister_framebuffer+0x45/0x160

2024-09-02 Thread Helge Deller
On 9/2/24 20:56, V, Narasimhan wrote: From: Thomas Zimmermann Seeing the following warning and bug on boot with linux-next-20240829 WARNING: CPU: 0 PID: 8 at drivers/video/fbdev/core/fbmem.c:467 unregister_framebuffer+0x45/0x160 BUG: kernel NULL pointer dereference, address:

Re: [git pull] drm fixes for 6.11-rc6

2024-09-02 Thread Linus Torvalds
On Mon, 2 Sept 2024 at 03:34, Christian König wrote: > > Am 02.09.24 um 11:32 schrieb Thomas Hellström: > > > > The remap_pfn_range was last tried, at least in the context of the i915 > > driver IIRC by Christoph Hellwig but had to be ripped out since it > > requires the mmap_lock in write mode. H

Re: [PATCH 13/21] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-02 Thread Dmitry Baryshkov
On Mon, Sep 02, 2024 at 03:36:11PM GMT, Daniel Vetter wrote: > On Thu, Aug 29, 2024 at 01:48:34PM -0700, Jessica Zhang wrote: > > If the clone mode enabled status is changing, a modeset needs to happen > > so that the resources can be reassigned > > > > Signed-off-by: Jessica Zhang > > --- > > d

Re: WARNING: CPU: 0 PID: 8 at drivers/video/fbdev/core/fbmem.c:467 unregister_framebuffer+0x45/0x160

2024-09-02 Thread V, Narasimhan
[AMD Official Use Only - AMD Internal Distribution Only] Hi, From: Thomas Zimmermann Sent: Monday, September 2, 2024 05:11 PM To: Borislav Petkov; V, Narasimhan Cc: Linux Next Mailing List; Daniel Vetter; Helge Deller; linux-fb...@vger.kernel.org; dri-d

Re: [PATCH -next 2/3] drm/amdgpu: use clamp() in amdgpu_vm_adjust_size()

2024-09-02 Thread Alex Deucher
Applied amdgpu patches. Thanks! On Fri, Aug 30, 2024 at 10:19 AM Christian König wrote: > > Am 30.08.24 um 03:22 schrieb Li Zetao: > > When it needs to get a value within a certain interval, using clamp() > > makes the code easier to understand than min(max()). > > > > Signed-off-by: Li Zetao >

Re: [PATCH] drm/amdgpu: enable gfxoff quirk on HP 705G4

2024-09-02 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 30, 2024 at 3:27 AM Lu Yao wrote: > > From: Peng Liu > > Enabling gfxoff quirk results in perfectly usable > graphical user interface on HP 705G4 DM with R5 2400G. > > Without the quirk, X server is completely unusable as > every few seconds there is gpu reset due t

Re: [PATCH] drm/amdgpu: add raven1 gfxoff quirk

2024-09-02 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 30, 2024 at 3:26 AM Lu Yao wrote: > > From: Peng Liu > > Fix screen corruption with openkylin. > > Link: https://bbs.openkylin.top/t/topic/171497 > Signed-off-by: Peng Liu > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH][next] drm/amd/display: Fix spelling mistake "recompte" -> "recompute"

2024-09-02 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 28, 2024 at 5:43 AM Colin Ian King wrote: > > There is a spelling mistake in a DRM_DEBUG_DRIVER message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-02 Thread Matthew Brost
On Mon, Sep 02, 2024 at 01:53:14PM +0200, Daniel Vetter wrote: > On Thu, Aug 29, 2024 at 05:27:13PM +, Matthew Brost wrote: > > On Thu, Aug 29, 2024 at 11:45:08AM +0200, Daniel Vetter wrote: > > > On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > > > > This patch introduces suppo

[PATCH] drm/panel: hx83112a: Switch to wrapped mipi_dsi functions

2024-09-02 Thread Abhishek Tamboli
Use the new mipi_dsi_*_multi wrapped function in hx83112a_on and hx83112a_disable function. Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/panel/panel-himax-hx83112a.c | 136 --- 1 file changed, 58 insertions(+), 78 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-hima

[PATCH] drm/tegra: fix potential uninitialized variable use

2024-09-02 Thread Jani Nikula
It's likely either output->drm_edid or output->ddc is non-NULL, but avoid the uninitialized variable usage anyway. Reported-by: kernel test robot Closes: https://lore.kernel.org/r/ZtXLyXxew7z6H2bD@stanley.mountain Fixes: 98365ca74cbf ("drm/tegra: convert to struct drm_edid") Cc: Thierry Reding C

Re: [PATCH -next v2] drm/imagination: Use memdup_user() helper

2024-09-02 Thread Markus Elfring
> > Switching to memdup_user(), which combines kmalloc() and copy_from_user(), > > and it can simplfy code. > > Applied, thanks! > > [1/1] drm/imagination: Use memdup_user() helper > commit: 2872a57c7ad427d428c6d12e95e55b32bdc8e3b8 Do you find any previous contributions still similarly inter

Re: [PATCH v2 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-09-02 Thread Daniel Vetter
On Wed, Jun 19, 2024 at 01:31:37AM +0200, Danilo Krummrich wrote: > From: Asahi Lina > > DRM drivers need to be able to declare which driver-specific ioctls they > support. Add an abstraction implementing the required types and a helper > macro to generate the ioctl definition inside the DRM driv

Re: [PATCH v2 0/8] DRM Rust abstractions and Nova

2024-09-02 Thread Daniel Vetter
On Wed, Jun 19, 2024 at 01:31:36AM +0200, Danilo Krummrich wrote: > This patch series implements some basic DRM Rust abstractions and a stub > implementation of the Nova GPU driver. > > Nova is intended to be developed upstream, starting out with just a stub > driver > to lift some initial requir

Re: [PATCH v2 3/8] rust: drm: add driver abstractions

2024-09-02 Thread Daniel Vetter
On Wed, Jun 19, 2024 at 01:31:39AM +0200, Danilo Krummrich wrote: > Implement the DRM driver abstractions. > > The `Driver` trait provides the interface to the actual driver to fill > in the driver specific data, such as the `DriverInfo`, driver features > and IOCTLs. > > Co-developed-by: Asahi L

Re: [PATCH v3 26/81] drm/mediatek: Run DRM default client setup

2024-09-02 Thread Matthias Brugger
On 30/08/2024 10:40, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. The mediatek driver specifies a preferred color mode of 32. As this is the

[pull] drm/msm: drm-msm-next-2024-09-02 for v6.12

2024-09-02 Thread Rob Clark
Hi Dave, Sima, This is the main pull for v6.12. It ended a bit smaller this time, there are a few series on the dpu and gpu side that weren't quite ready to go this time around. Further description below. The following changes since commit 6d0ebb3904853d18eeec7af5e8b4ca351b6f9025: Merge tag

Re: [PATCH v4 3/3] arm64: dts: mediatek: mt8186: Add svs node

2024-09-02 Thread Matthias Brugger
On 30/08/2024 10:45, Rohit Agarwal wrote: Add clock/irq/efuse setting in svs nodes for mt8186 SoC. Signed-off-by: Rohit Agarwal Applied, thanks --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/mediat

Re: [PATCH v4 2/3] arm64: dts: mediatek: mt8186: Add power domain for DPI

2024-09-02 Thread Matthias Brugger
On 30/08/2024 10:45, Rohit Agarwal wrote: Add power domain phandle to the DPI controller in mediatek mt8186 SoC. Signed-off-by: Rohit Agarwal Applied, thanks --- arch/arm64/boot/dts/mediatek/mt8186.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/m

[PATCH 2/2] drm/ttm: Move pinned objects off LRU lists when pinning

2024-09-02 Thread Thomas Hellström
The ttm_bo_pin() and ttm_bo_unpin() functions weren't moving their resources off the LRU list to the unevictable list. Make sure that happens so that pinned objects don't accidently linger on the LRU lists, and also make sure to move them back once they are unpinned. Cc: Christian König Cc: Matt

[PATCH 1/2] drm/ttm: Move swapped objects off the manager's LRU list

2024-09-02 Thread Thomas Hellström
Resources of swapped objects remains on the TTM_PL_SYSTEM manager's LRU list, which is bad for the LRU walk efficiency. Rename the device-wide "pinned" list to "unevictable" and move also resources of swapped-out objects to that list. An alternative would be to create an "UNEVICTABLE" priority to

[PATCH 0/2] drm/ttm: Really use a separate LRU list for swapped- and pinned objects

2024-09-02 Thread Thomas Hellström
Resources of swapped objects were never moved off their LRU list when swapped, and also resources of pinned objects might remain on their LRU list unless the driver moved them to the device pinned list after pinning. Rename the device "pinned" list to "unevictable" and ensure that resources of obj

Re: [PATCH v4 3/3] soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu Acked-by: Matthias Brugger --- drivers/soc/mediatek/mtk-cmdq-helper.c | 22 --

Re: [PATCH v4 2/3] media: platform: mtk-mdp3: Use cmdq_pkt_create() and cmdq_pkt_destroy()

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: Use cmdq_pkt_create() and cmdq_pkt_destroy() common function instead of implementing mdp3 version. Signed-off-by: Chun-Kuang Hu --- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c| 46 ++- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.h

Re: [PATCH v2] drm/panthor: flush FW AS caches in slow reset path

2024-09-02 Thread Boris Brezillon
On Mon, 2 Sep 2024 16:11:51 +0100 Steven Price wrote: > On 02/09/2024 14:02, Adrián Larumbe wrote: > > In the off-chance that waiting for the firmware to signal its booted status > > timed out in the fast reset path, one must flush the cache lines for the > > entire FW VM address space before rel

Re: [PATCH v2] drm/panthor: flush FW AS caches in slow reset path

2024-09-02 Thread Steven Price
On 02/09/2024 14:02, Adrián Larumbe wrote: > In the off-chance that waiting for the firmware to signal its booted status > timed out in the fast reset path, one must flush the cache lines for the > entire FW VM address space before reloading the regions, otherwise stale > values eventually lead to

Re: [PATCH v4 1/3] media: platform: mtk-mdp3: Get fine-grain control of cmdq_pkt_finalize()

2024-09-02 Thread Matthias Brugger
On 01/09/2024 16:32, Chun-Kuang Hu wrote: In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 3 ++- dri

Re: [PATCH v2 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-02 Thread Matthias Brugger
On 02/09/2024 15:36, Liankun Yang wrote: Update efuse data for MT8188 displayport. The DP monitor can not display when DUT connected to USB-c to DP dongle. Analysis view is invalid DP efuse data. Fixes: 350c3fe907fb ("drm/mediatek: dp: Add support MT8188 dp/edp function") Changes in V2: - A

Re: [PATCH 1/2] drm/amd/display: Avoid race between dcn10_set_drr() and dc_state_destruct()

2024-09-02 Thread raoul . van . rueschen
> From: Tobias Jakobi > > dc_state_destruct() nulls the resource context of the DC state. The > pipe > context passed to dcn10_set_drr() is a member of this resource > context. > > If dc_state_destruct() is called parallel to the IRQ processing > (which > calls dcn10_set_drr() at some point), we c

[PATCH v1 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-02 Thread Jianeng Ceng
MT8186 ponyta, known as huaqin custom lable, is a MT8186 based laptop. It is based on the "corsola" design. It includes LTE, touchpad combinations. Signed-off-by: Jianeng Ceng --- arch/arm64/boot/dts/mediatek/Makefile | 2 + .../mediatek/mt8186-corsola-ponyta-sku0.dts | 24 ++

Re: [PATCH 1/2] drm/amd/display: Avoid race between dcn10_set_drr() and dc_state_destruct()

2024-09-02 Thread Raoul van Rüschen
> From: Tobias Jakobi > > dc_state_destruct() nulls the resource context of the DC state. The > pipe > context passed to dcn10_set_drr() is a member of this resource > context. > > If dc_state_destruct() is called parallel to the IRQ processing > (which > calls dcn10_set_drr() at some point), we c

[PATCH v1 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-02 Thread Jianeng Ceng
This is v1 of the MT8186 Chromebook device tree series. Jianeng Ceng (2): dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks .../devicetree/bindings/arm/mediatek.yaml | 11 + arch/arm64/boot/dts/mediatek/Makefile | 2

[PATCH v1 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-02 Thread Jianeng Ceng
Add an entry for the MT8186 based Ponyta Chromebook (custom lable). Signed-off-by: Jianeng Ceng --- Documentation/devicetree/bindings/arm/mediatek.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-02 Thread Christian König
Am 02.09.24 um 15:23 schrieb Daniel Vetter: On Mon, Sep 02, 2024 at 12:43:45PM +0200, Christian König wrote: Am 30.08.24 um 23:43 schrieb Matthew Brost: On Fri, Aug 30, 2024 at 10:14:18AM +0200, Christian König wrote: Am 29.08.24 um 19:12 schrieb Boris Brezillon: dma_fence objects created by

[PATCH v2] drm/imagination: properly support stopping LAYOUT_MARS = 1 cores

2024-09-02 Thread Icenowy Zheng
Some new Rogue GPU cores have an extra MARS power domain, which controlls the power of the firmware core and allows the firmware core to power down most parts of the GPU. Adapt to this by ignoring power domains that should be powered down by the fiwmare and checking MARS idle status instead. The

Re: [RFC PATCH] drm/sched: Make sure drm_sched_fence_ops don't vanish

2024-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2024 at 12:58:54PM +0200, Christian König wrote: > Am 31.08.24 um 00:28 schrieb Matthew Brost: > > On Fri, Aug 30, 2024 at 12:40:57PM +0200, Boris Brezillon wrote: > > > dma_fence objects created by drm_sched might hit other subsystems, which > > > means the fence object might poten

Re: [PATCH] drm/imagination: properly support stopping LAYOUT_MARS = 1 cores

2024-09-02 Thread Icenowy Zheng
在 2024-09-02星期一的 09:24 +,Matt Coster写道: > On 11/08/2024 09:28, Icenowy Zheng wrote: > > Some new Rogue GPU cores have an extra MARS power domain, which > > controlls the power of the firmware core and allows the firmware > > core to > > power down most parts of the GPU. > > > > Adapt to this b

[PATCH v2 1/1] drm/mediatek: Fix get efuse issue for MT8188 DPTX

2024-09-02 Thread Liankun Yang
Update efuse data for MT8188 displayport. The DP monitor can not display when DUT connected to USB-c to DP dongle. Analysis view is invalid DP efuse data. Fixes: 350c3fe907fb ("drm/mediatek: dp: Add support MT8188 dp/edp function") Changes in V2: - Add Fixes tag. - Update the commit title. - Upd

Re: [PATCH 13/21] drm/msm/dpu: Require modeset if clone mode status changes

2024-09-02 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 01:48:34PM -0700, Jessica Zhang wrote: > If the clone mode enabled status is changing, a modeset needs to happen > so that the resources can be reassigned > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++ > 1 file changed, 6 ins

Re: [RFC PATCH] drm/sched: Fix a UAF on drm_sched_fence::sched

2024-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2024 at 12:43:45PM +0200, Christian König wrote: > Am 30.08.24 um 23:43 schrieb Matthew Brost: > > On Fri, Aug 30, 2024 at 10:14:18AM +0200, Christian König wrote: > > > Am 29.08.24 um 19:12 schrieb Boris Brezillon: > > > > dma_fence objects created by an entity might outlive the >

[PATCH -next] drm/i915/gt: Make use of __assign_bit() API

2024-09-02 Thread Hongbo Li
We have for some time the __assign_bit() API to replace open coded if (foo) __set_bit(n, bar); else __clear_bit(n, bar); Use this API to simplify the code. No functional change intended. Signed-off-by: Hongbo Li --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 5 +

Re: [RFC PATCH 24/28] drm/xe: Basic SVM BO eviction

2024-09-02 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 03:55:56PM +, Matthew Brost wrote: > On Thu, Aug 29, 2024 at 12:14:53PM +0200, Daniel Vetter wrote: > > On Tue, Aug 27, 2024 at 07:48:57PM -0700, Matthew Brost wrote: > > > Wire xe_bo_move to GPUSVM migration to SRAM with trylocking of mmap > > > lock. > > > > > > Signe

[PATCH v2] drm/panthor: flush FW AS caches in slow reset path

2024-09-02 Thread Adrián Larumbe
In the off-chance that waiting for the firmware to signal its booted status timed out in the fast reset path, one must flush the cache lines for the entire FW VM address space before reloading the regions, otherwise stale values eventually lead to a scheduler job timeout. Fixes: 647810ec2476 ("drm

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-09-02 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 09:48:11PM +, Matthew Brost wrote: > On Thu, Aug 29, 2024 at 11:24:26AM +0200, Christian König wrote: > >Am 28.08.24 um 18:06 schrieb Daniel Vetter: > > > > A lot to unpack here. Will try to address as much as I can in this > single reply to both of you (Daniel, Ch

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2024 at 01:01:45PM +0200, Christian König wrote: > Am 30.08.24 um 00:12 schrieb Matthew Brost: > > On Thu, Aug 29, 2024 at 01:02:54PM +0200, Daniel Vetter wrote: > > > On Thu, Aug 29, 2024 at 11:53:58AM +0200, Thomas Hellström wrote: > > > > But as Sima pointed out in private commun

Re: [RFC PATCH 23/28] drm/xe: Add SVM VRAM migration

2024-09-02 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 10:12:53PM +, Matthew Brost wrote: > On Thu, Aug 29, 2024 at 01:02:54PM +0200, Daniel Vetter wrote: > > On Thu, Aug 29, 2024 at 11:53:58AM +0200, Thomas Hellström wrote: > > > But as Sima pointed out in private communication, exhaustive eviction > > > is not really neede

Re: [PATCH -next 3/3] drm/mcde: Enable module autoloading

2024-09-02 Thread Linus Walleij
On Mon, Sep 2, 2024 at 1:41 PM Liao Chen wrote: > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > on the alias from of_device_id table. > > Signed-off-by: Liao Chen Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-02 Thread Daniel Vetter
Jumping in here in the middle, since I think it's a solid place to drop my idea of "align with core mm" gpusvm locking ... On Thu, Aug 29, 2024 at 08:56:23PM +, Matthew Brost wrote: > On Thu, Aug 29, 2024 at 09:18:29PM +0200, Thomas Hellström wrote: > Issues with removing a SVM range: > > - X

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-02 Thread Tomi Valkeinen
Hi, On 02/09/2024 13:50, Daniel Vetter wrote: On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: Hi, On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: On 25/07/2024 14:28, Maxime Ripard wrote: On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote: On 02/07/202

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-02 Thread Daniel Vetter
On Fri, Aug 30, 2024 at 11:16:53AM +0200, Thomas Hellström wrote: > Hi, Matthew > > On Tue, 2024-08-27 at 19:48 -0700, Matthew Brost wrote: > > +/** > > + * DOC: Overview > > + * > > + * GPU Shared Virtual Memory (GPU SVM) layer for the Direct > > Rendering Manager (DRM) > > + * > > + * The GPU SV

Re: [PATCH] drm/xe: Fix merge fails related to display runtime PM

2024-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2024 at 01:20:02PM +0200, Maarten Lankhorst wrote: > The most recent merge commits introduced some fails to drm/drm-next, > I've noticed these when looking at the xe patches. > > Solve it! > > Signed-off-by: Maarten Lankhorst I dropped the first hunk, since that was broken in dr

Re: [PATCH] fbdev: imsttfb: convert comma to semicolon

2024-09-02 Thread Helge Deller
On 9/2/24 10:47, Chen Ni wrote: Replace a comma between expression statements by a semicolon. Signed-off-by: Chen Ni I've applied your 3 comma-to-semicolon patches to the fbdev git tree. Thanks! Helge

Re: [RFC PATCH 05/28] drm/gpusvm: Add support for GPU Shared Virtual Memory

2024-09-02 Thread Daniel Vetter
On Thu, Aug 29, 2024 at 05:27:13PM +, Matthew Brost wrote: > On Thu, Aug 29, 2024 at 11:45:08AM +0200, Daniel Vetter wrote: > > On Tue, Aug 27, 2024 at 07:48:38PM -0700, Matthew Brost wrote: > > > This patch introduces support for GPU Shared Virtual Memory (SVM) in the > > > Direct Rendering Ma

[PATCH -next 0/3] drm: Enable module autoloading

2024-09-02 Thread Liao Chen
This patch enables the autoloading feature of drm module. By registering MDT, the kernel is allowed to automatically bind modules to devices that match the specified compatible strings. Liao Chen (3): drm/bridge: it6505: Enable module autoloading drm/tegra: Enable module autoloading drm/mcd

[PATCH -next 1/3] drm/bridge: it6505: Enable module autoloading

2024-09-02 Thread Liao Chen
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen --- drivers/gpu/drm/bridge/ite-it6505.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it

[PATCH -next 2/3] drm/tegra: Enable module autoloading

2024-09-02 Thread Liao Chen
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen --- drivers/gpu/drm/tegra/drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 03d1c76aec2d

[PATCH -next 3/3] drm/mcde: Enable module autoloading

2024-09-02 Thread Liao Chen
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen --- drivers/gpu/drm/mcde/mcde_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index

  1   2   >