[PATCH v2 2/2] drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

2024-08-12 Thread Tejas Vipin
Changes the jdi-fhd-r63452 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 150 ++- 1 file changed, 49 insertions(+), 101 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r

[PATCH v2 1/2] drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi

2024-08-12 Thread Tejas Vipin
mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being converted to a multi style function as it is often called in the context of similar functions. Reviewed-by: Douglas Anderson Signed-off-by: Tejas Vipin --- drivers/gpu/drm/drm_mipi_dsi.c | 31 +++ in

[PATCH v2 0/2] extend "multi" functions and use them in jdi-fhd-r63452

2024-08-12 Thread Tejas Vipin
This patch adds mipi_dsi_dcs_set_tear_scanline_multi to the list of multi functions and uses it with other multi functions in the jdi-fhd-r63452 panel. This patch uses functions introduced in [1] and must be applied after it. [1] https://lore.kernel.org/all/20240806135949.468636-1-tejasvipi...@gm

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Raag Jadav
On Mon, Aug 12, 2024 at 03:50:47PM +0200, Andi Shyti wrote: > Hi Raag, > > > +static int > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + struct hwm_fan_info *fi = &ddat->fi; > > + u64 rotations, time_now, time; > > +

Re: [PATCH v6] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-12 Thread 胡俊光

Re: [PATCH v3 1/5] workqueue: Split alloc_workqueue into internal function and lockdep init

2024-08-12 Thread kernel test robot
ect.c:240) [ 11.900074][ T131] kobject_add (kbuild/src/consumer/lib/kobject.c:430) The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20240812/202408121610.d1cdf757-oliver.s...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Raag Jadav
On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote: > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensor

Re: [PATCH v1] drm/ci: enable lockdep detection

2024-08-12 Thread Vignesh Raman
Hi Helen, On 13/08/24 01:47, Helen Mae Koike Fornazier wrote: Hi Vignesh, Thanks for your patch. On Mon, 12 Aug 2024 08:20:28 -0300 Vignesh Raman wrote --- > We have enabled PROVE_LOCKING (which enables LOCKDEP) in drm-ci. > This will output warnings when kernel locking errors are

[PATCH v2 0/5] drm/virtio: Import scanout buffers from other devices

2024-08-12 Thread Vivek Kasireddy
Having virtio-gpu import scanout buffers (via prime) from other devices means that we'd be adding a head to headless GPUs assigned to a Guest VM or additional heads to regular GPU devices that are passthrough'd to the Guest. In these cases, the Guest compositor can render into the scanout buffer us

[PATCH v2 5/5] drm/virtio: Add prepare and cleanup routines for imported dmabuf obj

2024-08-12 Thread Vivek Kasireddy
When an imported dmabuf obj is used as part of an atomic commit, we need to pin it as part of prepare and unpin it during cleanup of the associated FB, to make sure that it does not move until the commit is completed (and also while it is being used on the Host). Cc: Gerd Hoffmann Cc: Dmitry Osip

[PATCH v2 4/5] drm/virtio: Import prime buffers from other devices as guest blobs

2024-08-12 Thread Vivek Kasireddy
By importing scanout buffers from other devices, we should be able to use the virtio-gpu driver in KMS only mode. Note that we attach dynamically and register a move_notify() callback so that we can let the VMM know of any location changes associated with the backing store of the imported object by

[PATCH v2 3/5] drm/virtio: Add helpers to initialize and free the imported object

2024-08-12 Thread Vivek Kasireddy
The imported object can be considered a guest blob resource; therefore, we use create_blob cmd while creating it. These helpers are used in the next patch which does the actual import. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek K

[PATCH v2 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-08-12 Thread Vivek Kasireddy
This helper would be used when first initializing the object as part of import and also when updating the plane where we need to ensure that the imported object's backing is valid. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek Kasir

[PATCH v2 1/5] drm/virtio: Implement VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING cmd

2024-08-12 Thread Vivek Kasireddy
This cmd is useful to let the VMM (i.e, Qemu) know that the backing store associated with a resource is no longer valid, so that the VMM can perform any cleanup or unmap operations. The fence related changes and virtio_gpu_object_detach()/ virtio_gpu_detach_object_fenced() routines are extracted f

Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-12 Thread Frank Li
On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote: > On 08/13/2024, Frank Li wrote: > > Replace additionalProperties with unevaluatedProperties because it ref to > > panel-common.yaml. > > This would allow all properties in panel-common.yaml, which is not expected. > Isn't adding 'panel-timi

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-12 Thread Matthew Brost
On Mon, Aug 12, 2024 at 04:45:32PM +0200, Daniel Vetter wrote: > On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > > Hi Daniel, > > > > On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote: > > > On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote: > > > > On Fri, Aug 0

Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-12 Thread Liu Ying
On 08/13/2024, Frank Li wrote: > Replace additionalProperties with unevaluatedProperties because it ref to > panel-common.yaml. This would allow all properties in panel-common.yaml, which is not expected. Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough? > > Remove propertie

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/13/24 00:57, Jakub Kicinski wrote: On Mon, 12 Aug 2024 20:10:39 +0100 Pavel Begunkov wrote: 1. Drivers need to be able to say "I support unreadable netmem". Failure to report unreadable netmem support should cause the netlink API to fail when the user tries to bind dmabuf/io uring memory.

[PATCH v6] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-12 Thread Shuijing Li
Adding the per-frame lp function of mt8188, which can keep HFP in HS and reduce the time required for each line to enter and exit low power. Per Frame LP: |<--One Active Frame>| --_____ ^HSA+HBP^^RGB^^HFP^^HSA+HBP^^RGB^^HFP

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/13/24 01:15, Jakub Kicinski wrote: On Mon, 12 Aug 2024 20:04:41 +0100 Pavel Begunkov wrote: Also don't see the upside of the explicit "non-capable" flag, but I haven't thought of that. Is there any use? Or maybe I don't get what you're asking, I explained why to have that "PP_IGNORE_PROVI

Re: [PATCH v5] drm/mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-08-12 Thread 胡俊光

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread kernel test robot
Hi Raag, kernel test robot noticed the following build errors: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on linus/master v6.11-rc3 next-20240812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2024 20:04:41 +0100 Pavel Begunkov wrote: > >> Also don't see the upside of the explicit "non-capable" flag, > >> but I haven't thought of that. Is there any use? > > Or maybe I don't get what you're asking, I explained > why to have that "PP_IGNORE_PROVIDERS" on top of the flag >

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2024 20:10:39 +0100 Pavel Begunkov wrote: > > 1. Drivers need to be able to say "I support unreadable netmem". > > Failure to report unreadable netmem support should cause the netlink > > API to fail when the user tries to bind dmabuf/io uring memory. > > > > 2. Drivers need to be a

Re: [PATCH V2 14/16] WIP: usb: dwc2: Implement recovery after PM domain off

2024-08-12 Thread Stefan Wahren
Hi Doug, Am 28.07.24 um 15:00 schrieb Stefan Wahren: DO NOT MERGE According to the dt-bindings there are some platforms, which have a dedicated USB power domain for DWC2 IP core supply. If the power domain is switched off during system suspend then all USB register will lose their settings. So

Re: [PATCH 2/2] drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions

2024-08-12 Thread Doug Anderson
Hi, On Fri, Aug 9, 2024 at 9:55 PM Tejas Vipin wrote: > > @@ -41,79 +41,41 @@ static void jdi_fhd_r63452_reset(struct jdi_fhd_r63452 > *ctx) > static int jdi_fhd_r63452_on(struct jdi_fhd_r63452 *ctx) > { > struct mipi_dsi_device *dsi = ctx->dsi; > - struct device *dev = &dsi->dev

Re: [PATCH 1/2] drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi

2024-08-12 Thread Doug Anderson
Hi, On Fri, Aug 9, 2024 at 9:55 PM Tejas Vipin wrote: > > mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being > converted to a multi style function as it is often called in the context of > similar functions. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/drm_mipi_dsi.c

Re: [PATCH 0/2] add more multi functions for streamlined error handling

2024-08-12 Thread Doug Anderson
Hi, On Fri, Aug 9, 2024 at 9:55 PM Tejas Vipin wrote: > > This patch adds mipi_dsi_dcs_set_tear_scanline_multi to the list of multi > functions and uses it with other multi functions in the jdi-fhd-r63452 > panel. > > Tejas Vipin (2): > drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi >

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread kernel test robot
Hi Raag, kernel test robot noticed the following build errors: [auto build test ERROR on groeck-staging/hwmon-next] [also build test ERROR on linus/master v6.11-rc3 next-20240812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/bridge: dw-hdmi: Simplify clock handling

2024-08-12 Thread Cristian Ciocaltea
Make use of devm_clk_get_enabled() to replace devm_clk_get() and clk_prepare_enable() for isfr and iahb clocks, and drop the now unnecessary calls to clk_disable_unprepare(). Similarly, use devm_clk_get_optional_enabled() helper for cec clock, which additionally allows to remove the -ENOENT test.

[PATCH 4/4] drm/rockchip: dw_hdmi: Drop superfluous assignments of mpll_cfg, cur_ctr and phy_config

2024-08-12 Thread Cristian Ciocaltea
The mpll_cfg, cur_ctr and phy_config members in struct dw_hdmi_plat_data are only used to configure the Synopsys PHYs supported internally by DW HDMI transmitter driver (gpu/drm/bridge/synopsys/dw-hdmi.c), via hdmi_phy_configure_dwc_hdmi_3d_tx(), which is further invoked from dw_hdmi_phy_init(). T

[PATCH 3/4] drm/rockchip: dw_hdmi: Use devm_regulator_get_enable()

2024-08-12 Thread Cristian Ciocaltea
The regulators are only enabled at bind() and disabled at unbind(), hence replace the boilerplate code by making use of devm_regulator_get_enable() helper. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 + 1 file changed, 6 inse

[PATCH 2/4] drm/rockchip: dw_hdmi: Simplify clock handling

2024-08-12 Thread Cristian Ciocaltea
Make use of devm_clk_get_optional_enabled() to replace devm_clk_get() and clk_prepare_enable() for ref_clk and drop the now unnecessary calls to clk_disable_unprepare(). Additionally, use devm_clk_get_optional() helper for grf_clk to replace the open coding call to devm_clk_get() followed by the -

[PATCH 0/4] Rockchip DW HDMI driver cleanup/improvements

2024-08-12 Thread Cristian Ciocaltea
insertions(+), 66 deletions(-) --- base-commit: 9e6869691724b12e1f43655eeedc35fade38120c change-id: 20240812-dw-hdmi-rockchip-cleanup-33b8c16f65ce

[PATCH 1/4] drm/rockchip: dw_hdmi: Use modern drm_device based logging

2024-08-12 Thread Cristian Ciocaltea
Prefer drm_{err|info|dbg}() over deprecated DRM_DEV_{ERROR|INFO|DEBUG}() logging macros. Conversion done with the help of the following semantic patch, followed by a few minor indentation adjustments: @@ identifier T; @@ ( -DRM_DEV_ERROR(T->dev, +drm_err(T, ...) | -DRM_DEV_INFO(T->dev, +drm_info

Re: [PATCH V2 05/16] pmdomain: raspberrypi-power: set flag GENPD_FLAG_ACTIVE_WAKEUP

2024-08-12 Thread Stefan Wahren
Hi, Am 28.07.24 um 13:41 schrieb Stefan Wahren: Set flag GENPD_FLAG_ACTIVE_WAKEUP to rpi_power genpd, then when a device is set as wakeup source using device_set_wakeup_enable, the power domain could be kept on to make sure the device could wakeup the system. Signed-off-by: Stefan Wahren I kn

Re: [PATCH V2 02/16] mailbox: bcm2835: Fix timeout during suspend mode

2024-08-12 Thread Stefan Wahren
Hi Jassi, Am 28.07.24 um 13:41 schrieb Stefan Wahren: During noirq suspend phase the Raspberry Pi power driver suffer of firmware property timeouts. The reason is that the IRQ of the underlying BCM2835 mailbox is disabled and rpi_firmware_property_list() will always run into a timeout [1]. Sinc

Re: [PATCH V2 01/16] firmware: raspberrypi: Improve timeout warning

2024-08-12 Thread Stefan Wahren
Hi Florian, Am 28.07.24 um 13:41 schrieb Stefan Wahren: Recent work on raspberry-power driver showed that even the stacktrace on firmware property timeout doesn't provide enough information. So add the first tag name to the warning to be in line with a status error. Signed-off-by: Stefan Wahren

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-12 12:41:40) > > I just retained the same convention that was used earlier. It seems like > a mix and match right now. sc7180, sm6115 and qcm2290 were using 0x. > > I can post a separate change to change all of them. Sounds good.

[PATCH v4 2/3] drm: panel-backlight-quirks: Add Framework 13 matte panel

2024-08-12 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a quirk to override that the minimum backlight PWM to "0" which leads to a much lower minimum brightness, which is still visible. Tested on a Framework AM

[PATCH v4 1/3] drm: Add panel backlight quirks

2024-08-12 Thread Thomas Weißschuh
Panels using a PWM-controlled backlight source without an do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may grow stale if an older device can be retrofitted w

[PATCH v4 3/3] drm/amd/display: Add support for minimum backlight quirk

2024-08-12 Thread Thomas Weißschuh
Not all platforms provide correct PWM backlight capabilities through ATIF. Use the generic drm panel minimum backlight quirk infrastructure to override the capabilities where necessary. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/Kconfig| 1 + drivers/gpu/drm/

[PATCH v4 0/3] drm: Minimum backlight overrides and implementation for amdgpu

2024-08-12 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Introduce a quirk to override "min_input_signal" to "0" which leads to a much lower minimum brightness, which is still readable even in daylight. Tested on a

Re: [PATCH v1] drm/ci: enable lockdep detection

2024-08-12 Thread Helen Mae Koike Fornazier
Hi Vignesh, Thanks for your patch. On Mon, 12 Aug 2024 08:20:28 -0300 Vignesh Raman wrote --- > We have enabled PROVE_LOCKING (which enables LOCKDEP) in drm-ci. > This will output warnings when kernel locking errors are encountered > and will continue executing tests. To detect if

Re: [PATCH RESEND] drm/rockchip: Unregister platform drivers in reverse order

2024-08-12 Thread Cristian Ciocaltea
Hi Andy, On 8/12/24 5:14 AM, Andy Yan wrote: > > Hi Cristian, > > At 2024-08-08 19:58:02, "Cristian Ciocaltea" > wrote: >> Move rockchip_drm_platform_driver unregistration after its sub-drivers, >> which ensures all drivers are unregistered in the reverse order used >> when they were registere

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Abhinav Kumar
On 8/12/2024 11:40 AM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-08-08 16:52:27) sc7180 programs the ubwc settings as 0x1e as that would mean a highest bank bit of 14 which matches what the GPU sets as well. However, the highest_bank_bit field of the msm_mdss_data which is being used t

[PATCH v2] gpu: ipu-v3: Add cleanup attribute for prg_node for auto cleanup

2024-08-12 Thread Abhinav Jain
Hello, Can this be kindly reviewed? Thanks.

[PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-12 Thread Frank Li
Replace additionalProperties with unevaluatedProperties because it ref to panel-common.yaml. Remove properties (backlight, enable-gpios and power-supply), which defined in panel-common.yaml. Fix below warning: arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing

[PATCH 3/3] drm/vmwgfx: Add support for older define commands for userspace surfaces

2024-08-12 Thread Maaz Mombasawala
Older HW versions of the svga device will only support older versions of DefineGBSurface command. Allow userspace to submit v3 and v2 of the DefineGBSurface command for userspace managed surfaces. The first version of the command is not supported since it is only used for pre-dx hardware. Signed-o

[PATCH 2/3] drm/vmwgfx: Support hw_destroy for userspace managed surfaces

2024-08-12 Thread Maaz Mombasawala
A userspace may create a userspace managed surface but not destroy it, add hw_destroy function for userspace surfaces so that vmwgfx records the destroy command and submits it when the userspace context is destroyed. Signed-off-by: Maaz Mombasawala --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |

[PATCH 1/3] drm/vmwgfx: Introduce userspace managed surfaces

2024-08-12 Thread Maaz Mombasawala
The kernel currently exposes both mobs and surfaces to userspace through ioctls. We would like to move to a model where kernel would only expose mobs and have userspace manage surfaces. This would simplify kernel paths for surfaces since these userspace managed surfaces will not support prime trans

[PATCH 0/3] drm/vmwgfx: Add support for userspace managed surfaces.

2024-08-12 Thread Maaz Mombasawala
This series introduces basic support for userspace managed surfaces. The lifetime and id's of these surfaces is managed by userspace submitted commands instead of relying on the kernel to manage them. Maaz Mombasawala (3): drm/vmwgfx: Introduce userspace managed surfaces drm/vmwgfx: Support hw

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 19:55, Mina Almasry wrote: On Mon, Aug 12, 2024 at 1:57 PM Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" direc

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 3:05 PM Alex Deucher wrote: > > On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > > > Remove the implementation of struct drm_driver.lastclose. The hook > > was only necessary before in-kernel DRM clients existed, but is now > > obsolete. The code in amdgpu_driv

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > Remove the implementation of struct drm_driver.lastclose. The hook > was only necessary before in-kernel DRM clients existed, but is now > obsolete. The code in amdgpu_driver_lastclose_kms() is performed by > drm_lastclose(). > > v2: > -

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from drm_lastclose(), so that the > driver functions can finally be removed. Only PCI devices with enabled > switcheroo do the dela

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 19:57, Pavel Begunkov wrote: On 8/12/24 18:57, Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" directly to core (v

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 18:57, Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" directly to core (via the queue-api or what not), and we che

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Mina Almasry
On Mon, Aug 12, 2024 at 1:57 PM Jakub Kicinski wrote: > > On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: > > > I think we're talking about 2 slightly different flags, AFAIU.> > > > Pavel and I are suggesting the driver reports "I support memory > > > providers" directly to core (via the

Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

2024-08-12 Thread Danilo Krummrich
On 8/12/24 2:34 PM, Thomas Zimmermann wrote: Hi Am 12.08.24 um 14:17 schrieb Danilo Krummrich: On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM clie

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 10:40 AM Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 12, 2024 at 10:28:22AM +0

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-08 16:52:27) > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch configuration

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-08 16:52:27) > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch configuration

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-08-12 Thread Rob Clark
On Thu, Aug 8, 2024 at 4:16 AM Dmitry Osipenko wrote: > > On 8/5/24 19:24, Rob Clark wrote: > > On Wed, Jul 24, 2024 at 12:00 PM Dmitry Osipenko > > wrote: > >> > >> On 7/23/24 14:49, Sergio Lopez wrote: > >>> There's an incresing number of machines supporting multiple page sizes > >>> and on the

Re: [PATCH V2 00/10] AMD XDNA driver

2024-08-12 Thread Lizhi Hou
On 8/9/24 08:21, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Rob Clark
On Thu, Aug 8, 2024 at 4:52 PM Abhinav Kumar wrote: > > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch co

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: > > I think we're talking about 2 slightly different flags, AFAIU.> > > Pavel and I are suggesting the driver reports "I support memory > > providers" directly to core (via the queue-api or what not), and we > > check that flag directly in ne

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-12 Thread Alex Deucher
Are there any objections to this series? We have been running into this limit as a problem for a while now on big servers. Alex On Mon, Jul 24, 2023 at 5:15 PM Michał Winiarski wrote: > > 64 DRM device nodes is not enough for everyone. > Upgrade it to ~512K (which definitely is more than enough

[Bug 219152] 6.11 regression: AMD 7950x iGPU fails to initialize (with bisect)

2024-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219152 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[PATCH] drm/panel: ili9341: Add comments for ILI9341 register

2024-08-12 Thread Abhishek Tamboli
TODO : Add missing comments for ILI9341 register definition. Signed-off-by: Abhishek Tamboli --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/p

[Bug 219152] New: 6.11 regression: AMD 7950x iGPU fails to initialize (with bisect)

2024-08-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219152 Bug ID: 219152 Summary: 6.11 regression: AMD 7950x iGPU fails to initialize (with bisect) Product: Drivers Version: 2.5 Hardware: AMD OS: Linux

[PATCH 6.10 246/263] drm/mgag200: Bind I2C lifetime to DRM device

2024-08-12 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit eb1ae34e48a09b7a1179c579aed042b032e408f4 upstream. Managed cleanup with devm_add_action_or_reset() will release the I2C adapter when the underlying Linux device goes a

[PATCH 6.10 245/263] drm/mgag200: Set DDC timeout in milliseconds

2024-08-12 Thread Greg Kroah-Hartman
6.10-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit ecde5db1598aecab54cc392282c15114f526f05f upstream. Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 milliseco

[PATCH 6.6 164/189] drm/mgag200: Set DDC timeout in milliseconds

2024-08-12 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit ecde5db1598aecab54cc392282c15114f526f05f upstream. Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 millisecon

[PATCH 6.6 165/189] drm/mgag200: Bind I2C lifetime to DRM device

2024-08-12 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit eb1ae34e48a09b7a1179c579aed042b032e408f4 upstream. Managed cleanup with devm_add_action_or_reset() will release the I2C adapter when the underlying Linux device goes aw

[PATCH 6.1 128/150] drm/mgag200: Bind I2C lifetime to DRM device

2024-08-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit eb1ae34e48a09b7a1179c579aed042b032e408f4 upstream. Managed cleanup with devm_add_action_or_reset() will release the I2C adapter when the underlying Linux device goes aw

[PATCH 6.1 127/150] drm/mgag200: Set DDC timeout in milliseconds

2024-08-12 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit ecde5db1598aecab54cc392282c15114f526f05f upstream. Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 millisecon

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-12 Thread Lizhi Hou
On 8/9/24 08:24, Carl Vanderlip wrote: On 8/5/2024 10:39 AM, Lizhi Hou wrote: > +static int aie2_init(struct amdxdna_dev *xdna) > +{ > +    struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); > +    struct amdxdna_dev_hdl *ndev; > +    struct psp_config psp_conf; > +    const struct firmware *fw

Re: [PATCH v3 1/2] drm/panel: jd9365da: Move "exit sleep mode" and "set display on" cmds

2024-08-12 Thread Doug Anderson
Jessica, On Thu, Aug 8, 2024 at 3:56 PM Jessica Zhang wrote: > > > > On 8/7/2024 3:04 AM, Zhaoxiong Lv wrote: > > Move the "exit sleep mode" and "set display on" command from > > enable() to init() function. > > > > As mentioned in the patch: > > https://lore.kernel.org/all/20240624141926.5250-2-

Re: [PATCH 2/2] drm/v3d: Appease lockdep while updating GPU stats

2024-08-12 Thread Maíra Canal
Hi Tvrtko, On 8/12/24 06:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Lockdep thinks our seqcount_t usage is unsafe because the update path can be both from irq and worker context: [ ] [ ] WARNING: inconsistent lock state [ ] 6.10.3-v8-16k-numa #159 Ta

Re: [PATCH 1/2] drm/v3d: Disable preemption while updating GPU stats

2024-08-12 Thread Maíra Canal
Hi Tvrtko, On 8/12/24 06:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We forgot to disable preemption around the write_seqcount_begin/end() pair while updating GPU stats: [ ] WARNING: CPU: 2 PID: 12 at include/linux/seqlock.h:221 __seqprop_assert.isra.0+0x128/0x150 [v3d] [ ] Workqueu

Re: [PATCH] drm/v3d: Fix out-of-bounds read in `v3d_csd_job_run()`

2024-08-12 Thread Maíra Canal
Hi Iago, On 8/12/24 04:01, Iago Toral wrote: El vie, 09-08-2024 a las 12:18 -0300, Maíra Canal escribió: When enabling UBSAN on Raspberry Pi 5, we get the following warning: [  387.894977] UBSAN: array-index-out-of-bounds in drivers/gpu/drm/v3d/v3d_sched.c:320:3 [  387.903868] index 7 is out o

[PATCH v5 2/2] drm/bridge: add support for TI TDP158

2024-08-12 Thread Marc Gonzalez
TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. It supports DVI 1.0, HDMI 1.4b and 2.0b. It supports 4 TMDS channels, HPD, and a DDC interface. It supports dual power supply rails (1.1V on VDD, 3.3V on VCC) for power reduction. Several methods of power management are implemented

[PATCH v5 0/2] Basic support for TI TDP158

2024-08-12 Thread Marc Gonzalez
TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. Like the TFP410, the TDP158 can be set up in 2 different ways: 1) hard-coding its configuration settings using pin-strapping resistors 2) placing it on an I2C bus, and defer set-up until run-time The mode is selected by pin 8 = I

[PATCH v5 1/2] dt-bindings: display: bridge: add TI TDP158

2024-08-12 Thread Marc Gonzalez
TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. It supports DVI 1.0, HDMI 1.4b and 2.0b. It supports 4 TMDS channels, HPD, and a DDC interface. It supports dual power supply rails (1.1V on VDD, 3.3V on VCC) for power reduction. Several methods of power management are implemented

Re: [PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-12 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 01:51:30PM +0200, Andi Shyti wrote: > Hi Daniel, > > On Mon, Aug 12, 2024 at 11:11:21AM +0200, Daniel Vetter wrote: > > On Fri, Aug 09, 2024 at 11:20:56AM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 10:53:38AM +0200, Daniel Vetter wrote: > > > > On Wed, Aug 07, 2

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

2024-08-12 Thread Daniel Vetter
On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > > > > Amdgpu and nouveau call vga_sw

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jani Nikula
On Mon, 12 Aug 2024, Jocelyn Falempe wrote: > On 12/08/2024 15:49, Jani Nikula wrote: >> On Mon, 12 Aug 2024, Jocelyn Falempe wrote: >>> Check if two rectangles overlap. >>> It's a bit similar to drm_rect_intersect() but this won't modify >>> the rectangle. >>> Simplifies a bit drm_panic. >> >>

[RESEND 1/2] drm/i915/gvt: stop using drm_edid_block_valid()

2024-08-12 Thread Jani Nikula
We'll want to stop drm_edid_block_valid() usage. KVMGT is the last user. Replace with drm_edid_valid(), which unfortunately requires an allocated drm_edid. However, on the plus side, this would be required to handle the TODO comment about EDID extension block support. Acked-by: Zhi Wang Signed-of

[RESEND 2/2] drm/edid: make drm_edid_block_valid() static

2024-08-12 Thread Jani Nikula
drm_edid_block_valid() is no longer used outside of drm_edid.c. Make it static. Acked-by: Zhi Wang Signed-off-by: Jani Nikula --- Cc: Zhenyu Wang Cc: Zhi Wang Cc: intel-gvt-...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jocelyn Falempe
On 12/08/2024 15:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true f

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Hamza Mahfooz
On 8/12/24 09:49, Jani Nikula wrote: On Mon, 12 Aug 2024, Jocelyn Falempe wrote: Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true for *an

Re: [PATCH v7 0/6] HDMI TX support in msm8998

2024-08-12 Thread Marc Gonzalez
Hello Rob, Abhinav, Dmitry, This series might be ready this time? Are all the patches supposed to go through https://gitlab.freedesktop.org/drm/msm.git ? (Probably not... patches 5 & 6 are probably supposed to go through Bjorn's tree?) Regards On 24/07/2024 17:01, Marc Gonzalez wrote: > DT bi

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Andi Shyti
Hi Raag, > +static int > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > +{ > + struct i915_hwmon *hwmon = ddat->hwmon; > + struct hwm_fan_info *fi = &ddat->fi; > + u64 rotations, time_now, time; > + intel_wakeref_t wakeref; > + u32 reg_val, pulses; > + int r

Re: [PATCH v6 2/4] drm/rect: Add drm_rect_overlap()

2024-08-12 Thread Jani Nikula
On Mon, 12 Aug 2024, Jocelyn Falempe wrote: > Check if two rectangles overlap. > It's a bit similar to drm_rect_intersect() but this won't modify > the rectangle. > Simplifies a bit drm_panic. Based on the name, I'd expect drm_rect_overlap() to return true for *any* overlap, while this one seems

Re: [PATCH v6 1/9] Get rid of __get_task_comm()

2024-08-12 Thread Yafang Shao
On Mon, Aug 12, 2024 at 4:05 PM Alejandro Colomar wrote: > > Hi Yafang, > > On Mon, Aug 12, 2024 at 10:29:25AM GMT, Yafang Shao wrote: > > We want to eliminate the use of __get_task_comm() for the following > > reasons: > > > > - The task_lock() is unnecessary > > Quoted from Linus [0]: > > :

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Andy Shevchenko
On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: > Add hwmon support for fan1_input attribute, which will expose fan speed > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > $ sensors > i915-pci-0300 > Adapter: PCI adapter > in0: 653.00 mV > fan1:

Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c

2024-08-12 Thread Hamza Mahfooz
On 8/8/24 23:23, Daniel Yang wrote: Fix the unexpected indentation errors. drm_connector.c has some kerneldoc comments that were missing newlines. This results in the following warnings when running make htmldocs: ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING:

Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-12 Thread kernel test robot
Hi Hui-Ping, kernel test robot noticed the following build warnings: [auto build test WARNING on mtd/nand/next] [also build test WARNING on linus/master v6.11-rc3 next-20240812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/hisilicon: Remove unused delarations

2024-08-12 Thread Zhang Zekun
hibmc_mm_init() has been removed since commit 28645ae064d1 ("drm/hisilicon/hibmc: Remove hibmc_ttm.c"), but remain the declaration untouched in the header files. So, let's remove this unused declaration. Signed-off-by: Zhang Zekun --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - 1 file

  1   2   >