Re: [PATCH v1 4/4] mfd: lm3533: Remove the driver

2024-05-31 Thread kernel test robot
Hi Andy, kernel test robot noticed the following build errors: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on lee-backlight/for-backlight-fixes linus/master v6.10-rc1 next-20240531] [cannot apply to lee-backlight/for-backlight-next] [If your patch is applied to the wrong

Re: [PATCH v1 4/4] mfd: lm3533: Remove the driver

2024-05-31 Thread kernel test robot
Hi Andy, kernel test robot noticed the following build errors: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on lee-backlight/for-backlight-fixes linus/master v6.10-rc1 next-20240531] [cannot apply to lee-backlight/for-backlight-next pavel-leds/for-next] [If your patch is

Re: [git pull] drm fixes for 6.10-rc2

2024-05-31 Thread pr-tracker-bot
The pull request you sent on Sat, 1 Jun 2024 06:46:21 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-01 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc8ed4d0a8486c7472cd72ec3c19957e509dc68c Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] kernel/resource: optimize find_next_iomem_res

2024-05-31 Thread Chia-I Wu
On Fri, May 31, 2024 at 1:57 AM Andy Shevchenko < andriy.shevche...@linux.intel.com> wrote: > On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote: > > We can skip children resources when the parent resource does not cover > > the range. > > > > This should help vmf_insert_* users on x86, suc

Re: [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'

2024-05-31 Thread Jeffrey Hugo
On 5/31/2024 8:20 AM, Shuah Khan wrote: On 5/31/24 00:09, Danish Prakash wrote: (as part of LFX Linux Mentorship program) Please add proper commit log for this change. Looks like a good fix, and I'd love to take it, but the commit log needs some content. Signed-off-by: Danish Prakash

[git pull] drm fixes for 6.10-rc2

2024-05-31 Thread Dave Airlie
Hi Linus, This is the weekly fixes pull. Lots of small fixes across the board, one BUG_ON fix in shmem seems most important, otherwise amdgpu, i915, xe mostly with small fixes to all the other drivers. Dave. drm-fixes-2024-06-01: drm fixes for 6.10-rc2 shmem: - fix BUG_ON in COW handling - Warn

[PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-05-31 Thread Marek Vasut
Document default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

[PATCH 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-05-31 Thread Marek Vasut
Make the default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

[PATCH 4/6] drm/bridge: tc358767: Disable MIPI_DSI_CLOCK_NON_CONTINUOUS

2024-05-31 Thread Marek Vasut
The MIPI_DSI_CLOCK_NON_CONTINUOUS causes visible artifacts in high resolution modes, disable it. Namely, in DSI->DP mode 1920x1200 24 bpp 59.95 Hz, with DSI bus at maximum 1 Gbps per lane setting, the image contains jittering empty lines. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Dani

[PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-05-31 Thread Marek Vasut
This line_pixel_subtract is no longer needed now that the bridge can request and obtain specific pixel clock on input to the bridge, with clock frequency that matches the Pixel PLL frequency. The line_pixel_subtract is now always 0, so drop it entirely. The line_pixel_subtract was not reliable as

[PATCH 5/6] drm/bridge: tc358767: Set LSCLK divider for SYSCLK to 1

2024-05-31 Thread Marek Vasut
The only information in the datasheet regarding this divider is a note in SYS_PLLPARAM register documentation which states that when LSCLK is 270 MHz, LSCLK_DIV should be 1. What should LSCLK_DIV be set to when LSCLK is 162 MHz (for DP 1.62G mode) is unclear, but empirical test confirms using LSCLK

[PATCH 6/6] Revert "drm/bridge: tc358767: Set default CLRSIPO count"

2024-05-31 Thread Marek Vasut
This reverts commit 01338bb82fed40a6a234c2b36a92367c8671adf0. With clock improvements in place, this seems to be no longer necessary. Set the CLRSIPO to default setting recommended by manufacturer. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej

[PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-05-31 Thread Marek Vasut
Use tc_pxl_pll_calc() to find out the exact clock frequency generated by the Pixel PLL. Use the Pixel PLL frequency as adjusted_mode clock frequency and pass it down the display pipeline to obtain exactly this frequency on input into this bridge. The precise input frequency that matches the Pixel

[PATCH 1/6] drm/bridge: tc358767: Split tc_pxl_pll_en() into parameter calculation and enablement

2024-05-31 Thread Marek Vasut
Split tc_pxl_pll_en() into tc_pxl_pll_calc() which does only Pixel PLL parameter calculation and tc_pxl_pll_en() which calls tc_pxl_pll_calc() and then configures the Pixel PLL register. This is a preparatory patch for further rework, where tc_pxl_pll_calc() will also be used to find out the exact

[PATCH 0/2] drm bridge: drop drm_bridge_chain_mode_fixup.

2024-05-31 Thread Sam Ravnborg via B4 Relay
/mediatek/mtk_hdmi.c | 11 --- include/drm/drm_bridge.h| 3 --- 3 files changed, 51 deletions(-) --- base-commit: c9402efe492bb46ccbf94fedc4783eb8f8747567 change-id: 20240531-bridge_chain_mode-9ed8528e92cd Best regards, -- Sam Ravnborg

[PATCH 1/2] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2024-05-31 Thread Sam Ravnborg via B4 Relay
From: Sam Ravnborg The mode_valid implementation had a call to drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is not allowed to change anything - only to validate the mode. As the next bridge is often/always a connector the call had no effect anyway. So drop it. >From the

[PATCH 2/2] drm/bridge: Drop drm_bridge_chain_mode_fixup

2024-05-31 Thread Sam Ravnborg via B4 Relay
From: Sam Ravnborg There are no users left of drm_bridge_chain_mode_fixup() and we do not want to have this function available, so drop it. Signed-off-by: Sam Ravnborg Reviewed-by: Maxime Ripard Reviewed-by: Laurent Pinchart Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Maxime Ripard Cc:

[PATCH] drm/vmwgfx: Don't destroy Screen Target when CRTC is enabled but inactive

2024-05-31 Thread Ian Forbes
drm_crtc_helper_funcs::atomic_disable can be called even when the CRTC is still enabled. This can occur when the mode changes or the CRTC is set as inactive. In the case where the CRTC is being set as inactive we only want to blank the screen. The Screen Target should remain intact as long as the

[PATCH] drm/bridge: tc358767: Check if fully initialized before signalling HPD event via IRQ

2024-05-31 Thread Marek Vasut
Make sure the connector is fully initialized before signalling any HPD events via drm_kms_helper_hotplug_event(), otherwise this may lead to NULL pointer dereference. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc:

[PATCH] drm/bridge: tc358767: Fix comment in tc_edp_mode_valid

2024-05-31 Thread Marek Vasut
Fix comment copy-paste error in tc_edp_mode_valid(), this function is validating DP/eDP clock, not DPI clock frequency. Update the comment to match. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman

[PATCH] dt-bindings: display: bridge: tc358767: Keep enum sorted

2024-05-31 Thread Marek Vasut
Keep the list sorted numerically. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc: Maxime

[PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-05-31 Thread Marek Vasut
In case an upstream bridge modified the required clock frequency in its .atomic_check callback by setting adjusted_mode.clock , make sure that clock frequency is generated by the LCDIFv3 block. This is useful e.g. when LCDIFv3 feeds DSIM which feeds TC358767 with (e)DP output, where the TC358767 e

[PATCH v4 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-05-31 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 11 --- 3 files changed, 1

[PATCH v4 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-05-31 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 44 ++--- drivers/gpu/drm/msm/hdmi/hdmi.

[PATCH v4 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-05-31 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33 ++--- 1 f

[PATCH v4 0/9] drm/msm: make use of the HDMI connector infrastructure

2024-05-31 Thread Dmitry Baryshkov
This patchset sits on top Maxime's HDMI connector patchset ([1]). Currently this is an RFC exploring the interface between HDMI bridges and HDMI connector code. This has been lightly verified on the Qualcomm DB820c, which has native HDMI output. If this approach is considered to be acceptable, I'l

[PATCH v4 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-05-31 Thread Dmitry Baryshkov
Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. While the HDMI block has special block to send HVS InfoFrame, use GENERIC0 block instead. VENSPEC_INFO registers pack frame data in a way that requires manual repacking in the driver, while GENERIC0 doesn't have such format require

[PATCH v4 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-05-31 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display/hdmi

[PATCH v4 2/9] drm/bridge-connector: switch to using drmm allocations

2024-05-31 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Acked-by: Maxime Ripard Signed-off-by: Dmitry

[PATCH v4 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-05-31 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH v4 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-05-31 Thread Dmitry Baryshkov
In order to let bridge chains implement HDMI connector infrastructure, add necessary glue code to the drm_bridge_connector. In case there is a bridge that sets DRM_BRIDGE_OP_HDMI, drm_bridge_connector will register itself as a HDMI connector and provide proxy drm_connector_hdmi_funcs implementation

[PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-05-31 Thread Dmitry Baryshkov
Allow passing NULL as audio infoframe as a way to disable Audio Infoframe generation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_hel

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-05-31 Thread Dmitry Baryshkov
On Sun, Mar 10, 2024 at 11:04:00PM +0100, tjak...@math.uni-bielefeld.de wrote: > From: Tobias Jakobi > > Similar to the other Aya Neo devices this one features > again a portrait screen, here with a native resolution > of 1600x2560. > > Signed-off-by: Tobias Jakobi > --- > drivers/gpu/drm/drm_

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 12:20:24PM -0700, Abhinav Kumar wrote: > > > On 5/31/2024 1:16 AM, Dmitry Baryshkov wrote: > > On Fri, 31 May 2024 at 04:02, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > > > Max upscale / downscale factors are cons

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Abhinav Kumar
On 5/31/2024 1:16 AM, Dmitry Baryshkov wrote: On Fri, 31 May 2024 at 04:02, Abhinav Kumar wrote: On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Max upscale / downscale factors are constant between platforms. In preparation to adding support for virtual planes and allocating SSPP blocks on

[linux-next:master] BUILD REGRESSION 0e1980c40b6edfa68b6acf926bab22448a6e40c9

2024-05-31 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0e1980c40b6edfa68b6acf926bab22448a6e40c9 Add linux-next specific files for 20240531 Unverified Error/Warning (likely false positive, please contact us if interested): drivers/gpu/drm/xe

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-05-31 Thread Tobias Jakobi
On 3/10/24 23:04, tjak...@math.uni-bielefeld.de wrote: From: Tobias Jakobi Similar to the other Aya Neo devices this one features again a portrait screen, here with a native resolution of 1600x2560. Signed-off-by: Tobias Jakobi --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-05-31 Thread Jani Nikula
On Mon, 27 May 2024, Maxime Ripard wrote: > Let me know what you think, Sorry to report that this series generates a bunch of kernel-doc warnings in include/drm/drm_connector.h. Documenting nested struct members doesn't work as smoothly as you'd expect: ../include/drm/drm_connector.h:1138: warni

Re: [PATCH v11 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Randy Dunlap
Hi, On 5/31/24 10:12 AM, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and difference, > 32-bit division related macros and functions exported by math.h header > file. > I don't see any kernel-doc for division functions in this header file. Do some division fu

Re: [PATCH][next] drm/amd/display: Fix a handful of spelling mistakes

2024-05-31 Thread Alex Deucher
Applied. Thanks! Alex On Fri, May 31, 2024 at 11:37 AM Randy Dunlap wrote: > > > > On 5/31/24 2:32 AM, Colin Ian King wrote: > > There are a few spelling mistakes in dml2_printf messages. Fix them. > > > > Signed-off-by: Colin Ian King > > > Reviewed-by: Randy Dunlap > > Thanks. > > > --- > >

Re: [PATCH v2 2/2] drm: panel: nv3052c: Add WL-355608-A8 panel

2024-05-31 Thread Jessica Zhang
On 5/30/2024 1:22 AM, Ryan Walklin wrote: The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Limited information is available online however the panel timing values (below) have been obtained from the vendor

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Jeffrey Hugo
On 5/31/2024 11:43 AM, Dmitry Baryshkov wrote: On Fri, May 31, 2024 at 10:18:07AM -0600, Jeffrey Hugo wrote: On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: There are two ways to describe an eDP panel in device tree. The recommended way is to add a device on the AUX bus, ideally using the edp-pan

Re: [PATCH v11 09/11] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 10:46:28PM +0530, Devarsh Thakkar wrote: > Add tests for round_closest_up/down and roundclosest macros which round > to nearest multiple of specified argument. These are tested with kunit > tool as shared here [1]. > > [1]: https://gist.github.com/devarsht/3f9042825be3da4e1

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 10:18:07AM -0600, Jeffrey Hugo wrote: > On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally using the > > edp-panel compatible. The legacy way is to d

Re: [PATCH v11 06/11] math.h: Add macros for rounding to closest value

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 10:41:36PM +0530, Devarsh Thakkar wrote: > Add below rounding related macros: > > round_closest_up(x, y) : Rounds x to closest multiple of y where y is a > power of 2, with a preference to round up in case two nearest values are > possible. > > round_closest_down(x, y) : R

Re: [PATCH v11 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 10:42:20PM +0530, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and difference, > 32-bit division related macros and functions exported by math.h header > file. As long as it renders correctly, fine to me Reviewed-by: Andy Shevchenko --

Re: [PATCH v11 08/11] lib: add basic KUnit test for lib/math

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 10:43:05PM +0530, Devarsh Thakkar wrote: > From: Daniel Latypov > > Add basic test coverage for files that don't require any config options: > * part of math.h (what seem to be the most commonly used macros) > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignore

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 06:15:46PM +0100, Lee Jones wrote: > On Fri, 31 May 2024, Andy Shevchenko wrote: > > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote: > > > Driver is quite outdated from the Linux kernel internal APIs > > > perspective. In particular GPIO code is using legacy

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Doug Anderson
Hi, On Fri, May 31, 2024 at 9:51 AM Jeffrey Hugo wrote: > > On 5/31/2024 10:20 AM, Doug Anderson wrote: > > Hi, > > > > On Fri, May 31, 2024 at 9:18 AM Jeffrey Hugo wrote: > >> > >> On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: > >>> There are two ways to describe an eDP panel in device tree. Th

[PATCH v11 11/11] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-31 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh Thak

[PATCH v11 10/11] media: imagination: Round to closest multiple for cropping region

2024-05-31 Thread Devarsh Thakkar
If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives preference to rounding down in case two nearest val

Re: [PATCH v6 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-31 Thread Jessica Zhang
On 5/29/2024 10:56 PM, Jun Nie wrote: Enable compression bit in cfg2 register for DSC in the DSI case per hardware version. Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Dmi

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Andy Shevchenko
+Cc: Johan (via kernel.org) On Fri, May 31, 2024 at 08:14:43PM +0300, Andy Shevchenko wrote: > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote: > > Driver is quite outdated from the Linux kernel internal APIs > > perspective. In particular GPIO code is using legacy calls, > > that

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 06:14:25PM +0100, Lee Jones wrote: > Making sure Johan is aware of this with his new address. Right, in any case this is not the final version (a couple of leftovers). I have mentioned this series in the original thread. -- With Best Regards, Andy Shevchenko

[PATCH v11 09/11] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-31 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V11 (No change, pa

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Lee Jones
On Fri, 31 May 2024, Andy Shevchenko wrote: > On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote: > > Driver is quite outdated from the Linux kernel internal APIs > > perspective. In particular GPIO code is using legacy calls, > > that started being replaced by a new API ca. 2014, i.e

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Andy Shevchenko
On Fri, May 31, 2024 at 07:56:12PM +0300, Andy Shevchenko wrote: > Driver is quite outdated from the Linux kernel internal APIs > perspective. In particular GPIO code is using legacy calls, > that started being replaced by a new API ca. 2014, i.e. ten > years ago. > > Suggested-by: Linus Walleij

Re: [PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Lee Jones
Making sure Johan is aware of this with his new address. On Fri, 31 May 2024, Andy Shevchenko wrote: > Driver is quite outdated from the Linux kernel internal APIs > perspective. In particular GPIO code is using legacy calls, > that started being replaced by a new API ca. 2014, i.e. ten > years a

[PATCH v11 08/11] lib: add basic KUnit test for lib/math

2024-05-31 Thread Devarsh Thakkar
From: Daniel Latypov Add basic test coverage for files that don't require any config options: * part of math.h (what seem to be the most commonly used macros) * gcd.c * lcm.c * int_sqrt.c * reciprocal_div.c (Ignored int_pow.c since it's a simple textbook algorithm.) These tests aren't particular

[PATCH v11 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Devarsh Thakkar
Add documentation for rounding, scaling, absolute value and difference, 32-bit division related macros and functions exported by math.h header file. Signed-off-by: Devarsh Thakkar --- V11: Fix title for math function header V10: Patch introduced V1->V9 (No change) --- Documentation/core-api/kern

[PATCH v11 06/11] math.h: Add macros for rounding to closest value

2024-05-31 Thread Devarsh Thakkar
Add below rounding related macros: round_closest_up(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to round up in case two nearest values are possible. round_closest_down(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to

[PATCH v1 3/4] leds: lm3533: Remove the driver

2024-05-31 Thread Andy Shevchenko
The driver has no in kernel users and requires a board file to be instantiated. Remove basically a dead code. If ever needed, it can be reinstantiated and converted to one that uses firmware node interfaces. Signed-off-by: Andy Shevchenko --- drivers/leds/Kconfig | 13 - drivers/leds/Mak

[PATCH v1 0/4] lm3533: Remove the outdated drivers

2024-05-31 Thread Andy Shevchenko
Driver is quite outdated from the Linux kernel internal APIs perspective. In particular GPIO code is using legacy calls, that started being replaced by a new API ca. 2014, i.e. ten years ago. Suggested-by: Linus Walleij Andy Shevchenko (4): backlight: lm3533_bl: Remove the driver iio: light:

[PATCH v1 1/4] backlight: lm3533_bl: Remove the driver

2024-05-31 Thread Andy Shevchenko
The driver has no in kernel users and requires a board file to be instantiated. Remove basically a dead code. If ever needed, it can be reinstantiated and converted to one that uses firmware node interfaces. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/Kconfig | 11 - drivers

[PATCH v1 2/4] iio: light: lm3533-als: Remove the driver

2024-05-31 Thread Andy Shevchenko
The driver has no in kernel users and requires a board file to be instantiated. Remove basically a dead code. If ever needed, it can be reinstantiated and converted to one that uses firmware node interfaces. Signed-off-by: Andy Shevchenko --- drivers/iio/light/Kconfig | 17 - drivers/iio/

[PATCH v1 4/4] mfd: lm3533: Remove the driver

2024-05-31 Thread Andy Shevchenko
The driver has no in kernel users and requires a board file to be instantiated. Remove basically a dead code. If ever needed, it can be reinstantiated and converted to one that uses firmware node interfaces. Signed-off-by: Andy Shevchenko --- drivers/mfd/lm3533-core.c | 645 ---

[PATCH v11 00/11] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-31 Thread Devarsh Thakkar
This adds support for V4L2 M2M based driver for E5010 JPEG Encoder which is a stateful JPEG encoder from Imagination technologies and is present in TI AM62A SoC. While adding support for it, following additional framework changes were made: - Moved reference quantization and huffman tables provid

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Jeffrey Hugo
On 5/31/2024 10:20 AM, Doug Anderson wrote: Hi, On Fri, May 31, 2024 at 9:18 AM Jeffrey Hugo wrote: On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: There are two ways to describe an eDP panel in device tree. The recommended way is to add a device on the AUX bus, ideally using the edp-panel com

Re: [PATCH v5 00/10] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-05-31 Thread Sean Anderson
On 5/3/24 15:29, Sean Anderson wrote: > This series cleans up the zyqnmp_dp IRQ and locking situation. Once > that's done, it adds debugfs support. The intent is to enable compliance > testing or to help debug signal-integrity issues. > > Last time I discussed converting the HPD work(s) to a threa

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Doug Anderson
Hi, On Fri, May 31, 2024 at 9:18 AM Jeffrey Hugo wrote: > > On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally using the > > edp-panel compatible. The legacy way is to def

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Jeffrey Hugo
On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: There are two ways to describe an eDP panel in device tree. The recommended way is to add a device on the AUX bus, ideally using the edp-panel compatible. The legacy way is to define a top-level platform device for the panel. Document that adding sup

Re: [PATCH] MAINTAINERS: Update Xe driver maintainers

2024-05-31 Thread Lucas De Marchi
On Fri, May 31, 2024 at 04:10:51PM GMT, Thomas Hellström wrote: Add Rodrigo Vivi as an Xe driver maintainer. Cc: David Airlie Cc: Daniel Vetter Cc: Rodrigo Vivi Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org shouldn't have a blank line here. Otherwise git doesn't cons

Re: [PATCH][next] drm/amd/display: Fix a handful of spelling mistakes

2024-05-31 Thread Randy Dunlap
On 5/31/24 2:32 AM, Colin Ian King wrote: > There are a few spelling mistakes in dml2_printf messages. Fix them. > > Signed-off-by: Colin Ian King Reviewed-by: Randy Dunlap Thanks. > --- > .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 6 +++--- > .../display/dc/dml2/dml21

Re: [PATCH] kernel/resource: optimize find_next_iomem_res

2024-05-31 Thread Andy Shevchenko
On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote: > We can skip children resources when the parent resource does not cover > the range. > This should help vmf_insert_* users on x86, such as several DRM drivers. vmf_insert_*() > On my AMD Ryzen 5 7520C, when streaming data from cpu memor

Re: [PATCH] MAINTAINERS: Update Xe driver maintainers

2024-05-31 Thread Rodrigo Vivi
On Fri, May 31, 2024 at 04:10:51PM +0200, Thomas Hellström wrote: > Add Rodrigo Vivi as an Xe driver maintainer. > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Rodrigo Vivi Cc: Lucas De Marchi Acked-by: Rodrigo Vivi > Cc: dri-devel@lists.freedesktop.org > Cc: linux-ker...@vger.kernel.org >

Re: [PATCH 1/6] dt-bindings: clock: mediatek: Add mt8173 mfgtop

2024-05-31 Thread Conor Dooley
On Fri, May 31, 2024 at 03:29:06PM +0800, Chen-Yu Tsai wrote: > On Thu, May 30, 2024 at 11:43 PM Conor Dooley wrote: > > > > On Thu, May 30, 2024 at 04:35:00PM +0800, Chen-Yu Tsai wrote: > > > +#include > > > +#include > > > + > > > +mfgtop: clock-controller@13fff000 { >

Re: [PATCH] drm/tegra: fix a possible null pointer dereference

2024-05-31 Thread Thierry Reding
On Fri May 31, 2024 at 3:56 PM CEST, Huai-Yuan Liu wrote: > In malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but > no check is performed. Before calling __drm_atomic_helper_crtc_reset, > mw_state should be checked to prevent possible null pointer dereferene. Please check that al

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-05-31 Thread Adam Ford
On Fri, May 31, 2024 at 8:37 AM Frank Binns wrote: > > Hi ChenYu, > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one > > of the Series6XT GPUs, another sub-family of the Rogue family. > > I've added Adam Ford who sent

Re: [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'

2024-05-31 Thread Shuah Khan
On 5/31/24 00:09, Danish Prakash wrote: (as part of LFX Linux Mentorship program) Please add proper commit log for this change. Signed-off-by: Danish Prakash --- Documentation/accel/qaic/qaic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/accel/q

Re: [PATCH v6 0/2] backlight: Add new lm3509 backlight driver

2024-05-31 Thread Lee Jones
On Sun, 26 May 2024 12:51:28 +0200, Patrick Gansterer wrote: > This is a general driver for LM3509 backlight chip of TI. > LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with > Dual Current Sinks. This driver supports OLED/White LED select, brightness > control and sub/main con

[PATCH] MAINTAINERS: Update Xe driver maintainers

2024-05-31 Thread Thomas Hellström
Add Rodrigo Vivi as an Xe driver maintainer. Cc: David Airlie Cc: Daniel Vetter Cc: Rodrigo Vivi Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Thomas Hellström --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-31 Thread Sui Jingfeng
Hi, Jayesh On 5/31/24 21:33, Sam Ravnborg wrote: Hi Jayesh, + static const struct drm_bridge_funcs sii902x_bridge_funcs = { .attach = sii902x_bridge_attach, .mode_set = sii902x_bridge_mode_set, @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs =

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-05-31 Thread Frank Binns
Hi ChenYu, On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one > of the Series6XT GPUs, another sub-family of the Rogue family. I've added Adam Ford who sent out some DT related patches [1] for the Renesas variant of GX6250

Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-31 Thread Sam Ravnborg
Hi Jayesh, > > + > > static const struct drm_bridge_funcs sii902x_bridge_funcs = { > > .attach = sii902x_bridge_attach, > > .mode_set = sii902x_bridge_mode_set, > > @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs > > sii902x_bridge_funcs = { > > .atomic_destroy_state = drm_

Re: [PATCH v2 00/10] drm: move Intel drm headers to a subdirectory

2024-05-31 Thread Jani Nikula
On Thu, 30 May 2024, Jani Nikula wrote: > We've accumulated enough Intel specific header files under include/drm > that they warrant a subdirectory of their own. Clean up the top drm > header directory by moving the Intel files under include/drm/intel. > > Since i915 is most impacted, I suggest me

Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-31 Thread Sui Jingfeng
Hi, On 5/30/24 17:29, Jayesh Choudhary wrote: Currently, mode_valid hook returns all mode as valid and it is defined only in drm_connector_helper_funcs. With the introduction of 'DRM_BRIDGE_ATTACH_NO_CONNECTOR', connector is not initialized in bridge_attach call for cases when the encoder has t

Re: [PATCH v6,15/24] media: mediatek: vcodec: Add one plane format

2024-05-31 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 20:20 +0800, Yunfei Dong a écrit : > Adding capture formats to support V4L2_PIX_FMT_MS21. This format has > one plane and only be used for secure video playback at current period. Please, replace "one plane" with "single allocation". This should disambiguate the message a li

Re: [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory

2024-05-31 Thread Nicolas Dufresne
Hi, Le jeudi 23 mai 2024 à 18:36 +0800, Chen-Yu Tsai a écrit : > On Thu, May 23, 2024 at 6:14 PM Andrzej Pietrasiewicz > wrote: > > > > Hi, > > > > I'm having second thoughts, please see inline, > > > > W dniu 22.05.2024 o 14:26, Andrzej Pietrasiewicz pisze: > > > Hi Yunfei, > > > > > > W dni

Re: [PATCH v4 0/2] Add mode_valid and atomic_check hooks for sii902x bridge

2024-05-31 Thread Sui Jingfeng
Hi, On 5/30/24 17:29, Jayesh Choudhary wrote: Move the mode_valid hook to drm_bridge_funcs structure to take care of the case when the encoder attaches the bridge chain with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is not initialized in the bridge's attach call and mo

Re: MAINTAINERS: drm: Drop sam as panel reviewer

2024-05-31 Thread Sui Jingfeng
Hi, On 5/31/24 05:14, Sam Ravnborg wrote: Drop myself as reviewer of panel patches, to reflect the reality. We lost one kindness reviewer for drivers of panel, unhappy! Not sure if it is proper to give you a NAK here. :( Best regards, Sui Signed-off-by: Sam Ravnborg Cc: Neil Armstrong --

Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

2024-05-31 Thread Tomer Tayar
On 31/05/2024 13:46, Thorsten Blum wrote: > Use kvfree() to fix the following Coccinelle/coccicheck warning reported > by kfree_mismatch.cocci: > > WARNING kvmalloc is used to allocate this memory at line 10398 > > Signed-off-by: Thorsten Blum Reviewed-by: Tomer Tayar > --- > drivers/ac

[PATCH 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-05-31 Thread Jani Nikula
Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- Side note, it baffles me why amdgpu has a copy of this instead of plumbing it into drm mst code. --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 ++--

[PATCH 1/3] drm/mst: switch to guid_t type for GUID

2024-05-31 Thread Jani Nikula
The kernel has a guid_t type for GUIDs. Switch to using it, but avoid any functional changes here. Signed-off-by: Jani Nikula --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/display/drm_dp_mst_topology.c | 67 +++ include/drm/display/drm_dp_mst_helper.h

[PATCH 2/3] drm/mst: switch to guid_gen() to generate valid GUIDs

2024-05-31 Thread Jani Nikula
Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topolog

[PATCH 0/3] drm/mst & drm/amd/display: switch to using guid_t

2024-05-31 Thread Jani Nikula
We have a guid_t type for GUIDs, switch to using it instead of hand rolling buffers. Convert to guid_gen() in separate patches to pinpoint the functional changes. BR, Jani. Jani Nikula (3): drm/mst: switch to guid_t type for GUID drm/mst: switch to guid_gen() to generate valid GUIDs drm/amd

Re: [PATCH 4/6] drm/imagination: Add compatible string entry for Series6XT

2024-05-31 Thread Frank Binns
On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is part > of the Series6XT, another variation of the Rogue family of GPUs. > > Signed-off-by: Chen-Yu Tsai > --- > drivers/gpu/drm/imagination/pvr_drv.c | 1 + > 1 file changed,

Re: [PATCH 2/6] clk: mediatek: Add mt8173-mfgtop driver

2024-05-31 Thread Frank Binns
On Thu, 2024-05-30 at 18:16 +0800, Chen-Yu Tsai wrote: > On Thu, May 30, 2024 at 5:59 PM AngeloGioacchino Del Regno > wrote: > > Il 30/05/24 10:35, Chen-Yu Tsai ha scritto: > > > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP > > > in the datasheet, that contains clock gat

Re: [PATCH 0/6] powervr: MT8173 GPU support

2024-05-31 Thread Frank Binns
Hi ChenYu, On Fri, 2024-05-31 at 12:00 +0800, Chen-Yu Tsai wrote: > On Thu, May 30, 2024 at 4:35 PM Chen-Yu Tsai wrote: > > Hi everyone, > > > > This series enables the PowerVR GPU found in the MT8173 SoC, found in > > some Chromebooks. Thank you for the patches, I'm really happy to see these!

Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

2024-05-31 Thread Devarsh Thakkar
Hi Randy, Thanks for the review. On 31/05/24 04:14, Randy Dunlap wrote: > > > On 5/30/24 10:17 AM, Devarsh Thakkar wrote: >> Add documentation for rounding, scaling, absolute value and difference, >> 32-bit division related macros and functions exported by math.h header >> file. >> >> Signed-of

[RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

2024-05-31 Thread Thorsten Blum
Use kvfree() to fix the following Coccinelle/coccicheck warning reported by kfree_mismatch.cocci: WARNING kvmalloc is used to allocate this memory at line 10398 Signed-off-by: Thorsten Blum --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

  1   2   >