Re: [PATCH v4 00/10] backlight: Replace struct fb_info in interfaces

2024-03-12 Thread Uwe Kleine-König
Hello Thomas, On Tue, Mar 05, 2024 at 05:22:33PM +0100, Thomas Zimmermann wrote: > Backlight drivers implement struct backlight_ops.check_fb, which > uses struct fb_info in its interface. Replace the callback with one > that does not use fb_info. > > In DRM, we have several drivers that implement

Re: [PATCH v2] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

2024-03-12 Thread Qiang Ma
On Wed, 31 Jan 2024 15:57:03 +0800 Qiang Ma wrote: Hello everyone, please help review this patch. Qiang Ma > Problem: > The computer in the bios initialization process, unplug the HDMI > display, wait until the system up, plug in the HDMI display, did not > enter the hotplug interrupt functio

[PATCH v18 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-12 Thread Mitul Golani
Compute vrr_vsync_start/end, which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit) - Updated bit fields of VRR_VSYNC_START/END. (Ankit) --v3: - Add PIPE_CONF_CHECK_I(vrr.

Re: [PATCH v2 7/8] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-12 Thread Rob Herring
g type definition /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/xlnx/xlnx,v-tpg.yaml: xlnx,bridge: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240312-dp-live-fmt-v2-7-a9c35dc

RE: [EXT] [PATCH v15 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ

2024-03-12 Thread Sandor Yu
Hi Alexander, Thanks for your combine HDMI and DP PHY driver into one driver. Basically, the HDMI and DP PHY initialize process and configuration same as V14. I have verify the DP and HDMI function with the patch set. I'm OK for the patch. B.R Sandor > > > From: Sandor Yu > > Add Cadence H

Re: [PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-12 Thread Doug Anderson
Hi, On Tue, Mar 12, 2024 at 5:47 PM Guenter Roeck wrote: > > On Tue, Mar 12, 2024 at 5:14 PM Douglas Anderson > wrote: > > > > As documented in the description of the transfer() function of > > "struct drm_dp_aux", the transfer() function can be called at any time > > regardless of the state of

[PATCH v2 2/8] drm: xlnx: zynqmp_dpsub: Update live format defines

2024-03-12 Thread Anatoliy Klymenko
Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register layout. Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h b/drivers/gpu/drm/xl

[PATCH v2 8/8] drm: xlnx: Intoduce TPG CRTC driver

2024-03-12 Thread Anatoliy Klymenko
DO NOT MERGE. REFERENCE ONLY. Add CRTC driver based on AMD/Xilinx Video Test Pattern Generator IP. TPG based FPGA design represents minimalistic harness useful for testing links between FPGA based CRTC and external DRM encoders, both FPGA and hardened IP based. Add driver for AMD/Xilinx Video Tim

[PATCH v2 7/8] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-12 Thread Anatoliy Klymenko
DO NOT MERGE. REFERENCE ONLY. Add binding for AMD/Xilinx Video Timing Controller and Test Pattern Generator. Copy media-bus-formats.h into dt-bindings/media to suplement TPG DT node. Signed-off-by: Anatoliy Klymenko --- .../bindings/display/xlnx/xlnx,v-tpg.yaml | 87 ++ .../d

[PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag

2024-03-12 Thread Anatoliy Klymenko
Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer context. This flag signals whether the driver runs in DRM CRTC or DRM bridge mode, assuming that all display layers share the same live or non-live mode of operation. Using per-layer mode instead of global flag will siplify future s

[PATCH v2 6/8] drm/atomic-helper: Add select_output_bus_format callback

2024-03-12 Thread Anatoliy Klymenko
Add optional drm_crtc_helper_funcs.select_output_bus_format callback. This callback allows to negotiate compatible media bus format on the link between CRTC and connected DRM encoder or DRM bridge chain. A good usage example is the CRTC implemented as FPGA soft IP. This kind of CRTC will most certa

[PATCH v2 3/8] drm: xlnx: zynqmp_dpsub: Anounce supported input formats

2024-03-12 Thread Anatoliy Klymenko
DPSUB in bridge mode supports multiple input media bus formats. Announce the list of supported input media bus formats via drm_bridge.atomic_get_input_bus_fmts callback. Introduce a set of live input formats, supported by DPSUB. Rename zynqmp_disp_layer_drm_formats() to zynqmp_disp_layer_formats()

[PATCH v2 5/8] drm: xlnx: zynqmp_dpsub: Set input live format

2024-03-12 Thread Anatoliy Klymenko
Program live video input format according to selected media bus format. In the bridge mode of operation, DPSUB is connected to FPGA CRTC which almost certainly supports a single media bus format as its output. Expect this to be delivered via the new bridge atomic state. Program DPSUB registers acc

[PATCH v2 1/8] drm: xlnx: zynqmp_dpsub: Set layer mode during creation

2024-03-12 Thread Anatoliy Klymenko
Set layer mode of operation (live or dma-based) during layer creation. Each DPSUB layer mode of operation is defined by corresponding DT node port connection, so it is possible to assign it during layer object creation. Previously it was set in layer enable functions, although it is too late as se

[PATCH v2 0/8] Setting live video input format for ZynqMP DPSUB

2024-03-12 Thread Anatoliy Klymenko
Implement live video input format setting for ZynqMP DPSUB. ZynqMP DPSUB can operate in 2 modes: DMA-based and live. In the live mode, DPSUB receives a live video signal from FPGA-based CRTC. DPSUB acts as a DRM encoder bridge in such a scenario. To properly tune into the incoming video signal, D

Re: [PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-12 Thread Guenter Roeck
On Tue, Mar 12, 2024 at 5:14 PM Douglas Anderson wrote: > > As documented in the description of the transfer() function of > "struct drm_dp_aux", the transfer() function can be called at any time > regardless of the state of the DP port. Specifically if the kernel has > the DP AUX character device

[PATCH 3/3] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-12 Thread Douglas Anderson
Before the introduction of the wait_hpd_asserted() callback in commit 841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux") the API between panel drivers and DP AUX bus drivers was that it was up to the AUX bus driver to wait for HPD in the transfer() function. Now wait_hp

[PATCH 2/3] drm/msm/dp: Account for the timeout in wait_hpd_asserted() callback

2024-03-12 Thread Douglas Anderson
The DP wait_hpd_asserted() callback is passed a timeout which indicates how long we should wait for HPD. This timeout was being ignored in the MSM DP implementation and instead a hardcoded 500 ms timeout was used. Fix it to use the proper timeout. As part of this we move the hardcoded 500 ms numbe

[PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-12 Thread Douglas Anderson
As documented in the description of the transfer() function of "struct drm_dp_aux", the transfer() function can be called at any time regardless of the state of the DP port. Specifically if the kernel has the DP AUX character device enabled and userspace accesses "/dev/drm_dp_auxN" directly then th

[PATCH 0/3] drm/msm/dp: Improve DP AUX transfer vs. HPD interactions

2024-03-12 Thread Douglas Anderson
The main goal of this patch series is to avoid problems running "fwupd" on Qualcomm devices. Right now several of the plugins used with fwupd try talking over all DP AUX busses and this results in a very long timeout on Qualcomm devices. As part of fixing this, I noticed a case where the MSM DP

Re: [PATCH] drm/i915/guc: Update w/a 14019159160

2024-03-12 Thread Lucas De Marchi
On Tue, Mar 12, 2024 at 04:43:06PM -0700, John Harrison wrote: On 3/12/2024 09:24, Matt Roper wrote: diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index 0c67d674c94de..4c3dae98656af 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c +++ b/drivers/

Re: [PATCH 1/5] drm/i915: Drop WA 16015675438

2024-03-12 Thread Lucas De Marchi
On Tue, Mar 12, 2024 at 03:54:09PM -0700, Matt Roper wrote: On Wed, Mar 06, 2024 at 11:36:39AM -0800, Lucas De Marchi wrote: With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done becaus

Re: [PATCH] drm/i915/guc: Update w/a 14019159160

2024-03-12 Thread John Harrison
On 3/12/2024 09:24, Matt Roper wrote: On Thu, Mar 07, 2024 at 06:01:29PM -0800, john.c.harri...@intel.com wrote: From: John Harrison An existing workaround has been extended in both platforms affected and implementation complexity. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/u

Re: [PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-12 Thread Lucas De Marchi
On Tue, Mar 12, 2024 at 03:58:19PM -0700, Matt Roper wrote: On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote: PCI IDs for XEHPSDV were never added and platform always marked with force_probe. Drop what's not used and rename some places to either be xehp or dg2, depending on the pl

Re: [PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-12 Thread Matt Roper
On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote: > PCI IDs for XEHPSDV were never added and platform always marked with > force_probe. Drop what's not used and rename some places to either be > xehp or dg2, depending on the platform/IP checks. > > The registers not used anymore are

Re: [PATCH 1/5] drm/i915: Drop WA 16015675438

2024-03-12 Thread Matt Roper
On Wed, Mar 06, 2024 at 11:36:39AM -0800, Lucas De Marchi wrote: > With dynamic load-balancing disabled on the compute side, there's no > reason left to enable WA 16015675438. Drop it from both PVC and DG2. > Note that this can be done because now the driver always set a fixed > partition of EUs du

Re: [PATCH 41/43] drm/tiny/st7735r: Use fbdev-dma

2024-03-12 Thread David Lechner
On 3/12/24 10:45 AM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by st7735r. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc:

Re: [PATCH 34/43] drm/tiny/ili9225: Use fbdev-dma

2024-03-12 Thread David Lechner
On 3/12/24 10:45 AM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by ili9225. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc:

Re: [PATCH 40/43] drm/tiny/st7586: Use fbdev-dma

2024-03-12 Thread David Lechner
On 3/12/24 10:45 AM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by st7586. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc:

Re: [PATCH 04/14] kunit: Add documentation for warning backtrace suppression API

2024-03-12 Thread Kees Cook
On Tue, Mar 12, 2024 at 10:02:59AM -0700, Guenter Roeck wrote: > Document API functions for suppressing warning backtraces. > > Signed-off-by: Guenter Roeck Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 03/14] kunit: Add test cases for backtrace warning suppression

2024-03-12 Thread Kees Cook
On Tue, Mar 12, 2024 at 10:02:58AM -0700, Guenter Roeck wrote: > Add unit tests to verify that warning backtrace suppression works. > > If backtrace suppression does _not_ work, the unit tests will likely > trigger unsuppressed backtraces, which should actually help to get > the affected architect

Re: [PATCH 02/14] kunit: bug: Count suppressed warning backtraces

2024-03-12 Thread Kees Cook
On Tue, Mar 12, 2024 at 10:02:57AM -0700, Guenter Roeck wrote: > Count suppressed warning backtraces to enable code which suppresses > warning backtraces to check if the expected backtrace(s) have been > observed. > > Using atomics for the backtrace count resulted in build errors on some > archite

Re: [PATCH 01/14] bug/kunit: Core support for suppressing warning backtraces

2024-03-12 Thread Kees Cook
On Tue, Mar 12, 2024 at 10:02:56AM -0700, Guenter Roeck wrote: > Some unit tests intentionally trigger warning backtraces by passing > bad parameters to API functions. Such unit tests typically check the > return value from those calls, not the existence of the warning backtrace. > > Such intentio

[PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-12 Thread Samuel Thibault
This remains relatively simple by just enlarging integers. It wouldn't be that simple to get to the console's 64x128 maximum, as it would require 128b integers. Signed-off-by: Samuel Thibault Index: linux-6.4/drivers/video/fbdev/core/fbcon.c =

Re: [PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

2024-03-12 Thread Dixit, Ashutosh
On Tue, 12 Mar 2024 13:34:25 -0700, Janusz Krzysztofik wrote: > Hi Janusz, > On Tuesday, 12 March 2024 17:25:14 CET Dixit, Ashutosh wrote: > > On Mon, 11 Mar 2024 13:34:58 -0700, Janusz Krzysztofik wrote: > > > > > > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > > >

Re: [PATCH v5 2/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-12 Thread Andi Shyti
On Tue, Mar 12, 2024 at 10:08:33AM -0700, Matt Roper wrote: > On Fri, Mar 08, 2024 at 09:22:17PM +0100, Andi Shyti wrote: > > For the upcoming changes we need a cleaner way to build the list > > of uabi engines. > > > > Suggested-by: Tvrtko Ursulin > > Signed-off-by: Andi Shyti > > Cc: # v6.2+

Re: [PATCH v5 1/4] drm/i915/gt: Disable HW load balancing for CCS

2024-03-12 Thread Andi Shyti
Hi Matt, ... > > #define GEN12_RCU_MODE _MMIO(0x14800) > > #define GEN12_RCU_MODE_CCS_ENABLEREG_BIT(0) > > +#define XEHP_RCU_MODE_FIXED_SLICE_CCS_MODE REG_BIT(1) > > Nitpick: we usually order register bits in descending order. Aside from >

Re: [PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

2024-03-12 Thread Janusz Krzysztofik
On Tuesday, 12 March 2024 18:09:37 CET Andi Shyti wrote: > Hi Janusz, > > On Mon, Mar 11, 2024 at 09:34:58PM +0100, Janusz Krzysztofik wrote: > > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > > rpm wakeref. That results in lock inversion: > > > > <4> [197.079335] ==

Re: [PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

2024-03-12 Thread Janusz Krzysztofik
Hi Ashutosh, On Tuesday, 12 March 2024 17:25:14 CET Dixit, Ashutosh wrote: > On Mon, 11 Mar 2024 13:34:58 -0700, Janusz Krzysztofik wrote: > > > > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > > rpm wakeref. That results in lock inversion: > > > > <4> [197.079335] ==

Re: [PATCH 0/7] Additions to "Reimplement line-per-line pixel conversion for plane reading" series

2024-03-12 Thread Melissa Wen
On 03/08, Maíra Canal wrote: > Hi Arthur, > > Would it be possible for you to coordinate with Louis and create a > single series with all the modification? > > I don't see a reason to submit fixes to a series that it is still > on review. I agree. Moreover, the fix for drm_fixp2int_round() shoul

Re: [PATCH 2/7] drm/vkms: Add comments

2024-03-12 Thread Melissa Wen
On 03/06, Arthur Grillo wrote: Hi, can you describe better the scope of your changes? Limiting the scope in the commit message and also describing in the body a summary of what you are documenting and reasons. Thanks, Melissa > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/vkms/vkms_fo

Re: [PATCH 6/7] drm/vkms: Change the gray RGB representation

2024-03-12 Thread Melissa Wen
On 03/06, Arthur Grillo wrote: > Using the drm_fixed calls, this needs to be changed. Which in fact is > more correct, colour.YCbCr_to_RGB() gives 0x8080 for same the yuv > parameters. Hi Arthur, For consistency, shouldn't this change be together with the previous patch that uses the drm_fixed ap

Re: [PATCH] drm: Don't return unsupported formats in drm_mode_legacy_fb_format

2024-03-12 Thread Frej Drejhammar
Hi Thomas, Thomas Zimmermann writes: > Am 11.03.24 um 20:34 schrieb Frej Drejhammar: > >> What I can't really see is what "switch all fbdev code over to >> drm_driver_legacy_fb_format" would entail [...] > > Your patch modifies drm_mode_legacy_fb_format() in a number of > *_fbdev_*.c files. In t

RE: [PATCH 29/43] drm/renesas/rz-du: Use fbdev-dma

2024-03-12 Thread Biju Das
Hi Thomas, > -Original Message- > From: Thomas Zimmermann > Sent: Tuesday, March 12, 2024 3:45 PM > To: dan...@ffwll.ch; airl...@gmail.com; del...@gmx.de; javi...@redhat.com > Cc: linux-fb...@vger.kernel.org; dri-devel@lists.freedesktop.org; Thomas > Zimmermann > ; Biju Das > Subject: [

Re: [RFC PATCH v4 07/42] drm/vkms: Avoid reading beyond LUT array

2024-03-12 Thread Melissa Wen
On 02/26, Harry Wentland wrote: > When the floor LUT index (drm_fixp2int(lut_index) is the last > index of the array the ceil LUT index will point to an entry > beyond the array. Make sure we guard against it and use the > value of the floor LUT index. > > v3: > - Drop bits from commit descriptio

Re: [RFC PATCH v4 05/42] drm/vkms: Create separate Kconfig file for VKMS

2024-03-12 Thread Melissa Wen
On 02/26, Harry Wentland wrote: > This aligns with most other DRM drivers and will allow > us to add new VKMS config options without polluting > the DRM Kconfig. > > v3: > - Change SPDX to GPL-2.0-only to match DRM KConfig >SPDX (Simon) > > Signed-off-by: Harry Wentland > Reviewed-by: Simon

Re: [PATCH 1/7] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-12 Thread Melissa Wen
On 03/06, Arthur Grillo wrote: > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > To round a number, you need to add 0.5 to the number and floor that, > drm_fixp2int_round() is adding 0.076. Make it add 0.5. > > [1]: > https://lore.kernel.org/all/20240301135327.22efe0

Re: [PATCH 11/43] drm/hyperv: Use fbdev-shmem

2024-03-12 Thread Deepak Rawat
Reviewed-by: Deepak Rawat On Tue, Mar 12, 2024 at 8:48 AM Thomas Zimmermann wrote: > > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Deepak Rawat > --- > drive

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-12 Thread Alexandre Mergnat
On 26/02/2024 17:09, Mark Brown wrote: On Mon, Feb 26, 2024 at 03:01:50PM +0100, amerg...@baylibre.com wrote: index ..13e95c227114 --- /dev/null +++ b/sound/soc/codecs/mt6357.c @@ -0,0 +1,1805 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * MT6357 ALSA SoC audio codec driver + *

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-12 Thread Abhinav Kumar
On 3/12/2024 9:59 AM, Johan Hovold wrote: On Tue, Mar 12, 2024 at 05:41:23PM +0100, Johan Hovold wrote: On Tue, Mar 12, 2024 at 11:09:11AM +0100, Johan Hovold wrote: On Fri, Mar 08, 2024 at 01:45:32PM -0800, Abhinav Kumar wrote: @@ -466,6 +466,8 @@ static int dp_display_notify_disconnect(

Re: [PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

2024-03-12 Thread Andi Shyti
Hi Janusz, On Mon, Mar 11, 2024 at 09:34:58PM +0100, Janusz Krzysztofik wrote: > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > rpm wakeref. That results in lock inversion: > > <4> [197.079335] == > <4> [197.085473]

Re: [PATCH v5 2/4] drm/i915/gt: Refactor uabi engine class/instance list creation

2024-03-12 Thread Matt Roper
On Fri, Mar 08, 2024 at 09:22:17PM +0100, Andi Shyti wrote: > For the upcoming changes we need a cleaner way to build the list > of uabi engines. > > Suggested-by: Tvrtko Ursulin > Signed-off-by: Andi Shyti > Cc: # v6.2+ I don't really see why we need patches 2 & 3 in this series. If we want

[PATCH 12/14] sh: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 14/14] powerpc: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 13/14] riscv: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 11/14] s390: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 04/14] kunit: Add documentation for warning backtrace suppression API

2024-03-12 Thread Guenter Roeck
Document API functions for suppressing warning backtraces. Signed-off-by: Guenter Roeck --- Documentation/dev-tools/kunit/usage.rst | 30 - 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kun

[PATCH 10/14] parisc: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 09/14] loongarch: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 07/14] x86: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 08/14] arm64: Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Add name of functions triggering warning backtraces to the __bug_table object section to enable support for suppressing WARNING backtraces. To limit image size impact, the pointer to the function name is only added to the __bug_table section if both CONFIG_KUNIT and CONFIG_DEBUG_BUGVERBOSE are ena

[PATCH 06/14] net: kunit: Suppress lock warning noise at end of dev_addr_lists tests

2024-03-12 Thread Guenter Roeck
dev_addr_lists_test generates lock warning noise at the end of tests if lock debugging is enabled. There are two sets of warnings. WARNING: CPU: 0 PID: 689 at kernel/locking/mutex.c:923 __mutex_unlock_slowpath.constprop.0+0x13c/0x368 DEBUG_LOCKS_WARN_ON(__owner_task(owner) != __get_current()) WA

[PATCH 03/14] kunit: Add test cases for backtrace warning suppression

2024-03-12 Thread Guenter Roeck
Add unit tests to verify that warning backtrace suppression works. If backtrace suppression does _not_ work, the unit tests will likely trigger unsuppressed backtraces, which should actually help to get the affected architectures / platforms fixed. Signed-off-by: Guenter Roeck --- lib/kunit/Mak

[PATCH 05/14] drm: Suppress intentional warning backtraces in scaling unit tests

2024-03-12 Thread Guenter Roeck
The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid clogging the kernel log

[PATCH 02/14] kunit: bug: Count suppressed warning backtraces

2024-03-12 Thread Guenter Roeck
Count suppressed warning backtraces to enable code which suppresses warning backtraces to check if the expected backtrace(s) have been observed. Using atomics for the backtrace count resulted in build errors on some architectures due to include file recursion, so use a plain integer for now. Sign

[PATCH 01/14] bug/kunit: Core support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Some unit tests intentionally trigger warning backtraces by passing bad parameters to API functions. Such unit tests typically check the return value from those calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful for a

[PATCH 00/14] Add support for suppressing warning backtraces

2024-03-12 Thread Guenter Roeck
Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API functions. Such unit tests typically check the return value from such calls, not the existence of the warning backtrace. Such intentionally generated warning backtraces are neither desirable nor useful

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-12 Thread Johan Hovold
On Tue, Mar 12, 2024 at 05:41:23PM +0100, Johan Hovold wrote: > On Tue, Mar 12, 2024 at 11:09:11AM +0100, Johan Hovold wrote: > > On Fri, Mar 08, 2024 at 01:45:32PM -0800, Abhinav Kumar wrote: > > > > @@ -466,6 +466,8 @@ static int dp_display_notify_disconnect(struct device > > > *dev) > > > { >

Re: [PATCH v5 1/4] drm/i915/gt: Disable HW load balancing for CCS

2024-03-12 Thread Matt Roper
On Fri, Mar 08, 2024 at 09:22:16PM +0100, Andi Shyti wrote: > The hardware should not dynamically balance the load between CCS > engines. Wa_14019159160 recommends disabling it across all > platforms. > > Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") > Signed-off-by: Andi Shyt

Re: [v9,9/9] drm/ast: Add drm_panic support

2024-03-12 Thread Sui Jingfeng
On 2024/3/7 17:14, Jocelyn Falempe wrote: Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v7 * Use drm_for_each_primary_visible_plane() v8: * Replace get_scanout_buffer() logic with drm_panic_set_buffer() (Thomas Zimmermann) v9:

Re: [v9,5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

2024-03-12 Thread Sui Jingfeng
Hi, I'm get attracted by your patch, so I want to comment. Please correct or ignore me if I say something wrong. On 2024/3/7 17:14, Jocelyn Falempe wrote: This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. v8: * Replace get_scanout_buffer() logic with d

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-12 Thread Johan Hovold
On Tue, Mar 12, 2024 at 11:09:11AM +0100, Johan Hovold wrote: > On Fri, Mar 08, 2024 at 01:45:32PM -0800, Abhinav Kumar wrote: > > @@ -466,6 +466,8 @@ static int dp_display_notify_disconnect(struct device > > *dev) > > { > > struct dp_display_private *dp = dev_get_dp_display_private(dev); >

Re: [PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-12 Thread Lucas De Marchi
On Mon, Mar 11, 2024 at 11:16:06AM -0400, Rodrigo Vivi wrote: On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote: PCI IDs for XEHPSDV were never added and platform always marked with force_probe. Drop what's not used and rename some places to either be xehp or dg2, depending on the

Re: [PATCH v2] drm/i915/hwmon: Fix locking inversion in sysfs getter

2024-03-12 Thread Dixit, Ashutosh
On Mon, 11 Mar 2024 13:34:58 -0700, Janusz Krzysztofik wrote: > > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an > rpm wakeref. That results in lock inversion: > > <4> [197.079335] == > <4> [197.085473] WARNING: possibl

Re: [PATCH] drm/i915/guc: Update w/a 14019159160

2024-03-12 Thread Matt Roper
On Thu, Mar 07, 2024 at 06:01:29PM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > An existing workaround has been extended in both platforms affected > and implementation complexity. > > Signed-off-by: John Harrison > --- > drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 3

Re: [PATCH 08/43] drm/fbdev: Add fbdev-shmem

2024-03-12 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Mar 12, 2024 at 4:48 PM Thomas Zimmermann wrote: > Add an fbdev emulation for SHMEM-based memory managers. The code is > similar to fbdev-generic, but does not require an addition shadow > buffer for mmap(). Fbdev-shmem operates directly on the buffer object's > SHMEM pages. Fb

Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-03-12 Thread Konrad Dybcio
On 2/23/24 23:48, Trilok Soni wrote: On 2/23/2024 1:21 PM, Konrad Dybcio wrote: + /* Wait 50us for PLL_LOCK_DET bit to go high */ + usleep_range(50, 55); + + /* Enable PLL output */ + regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL); +} +EXPORT_SYMBO

Re: [RFC PATCH v4 10/42] drm/colorop: Add TYPE property

2024-03-12 Thread Pekka Paalanen
On Tue, 12 Mar 2024 15:15:13 + Simon Ser wrote: > On Tuesday, March 12th, 2024 at 16:02, Pekka Paalanen > wrote: > > > This list here is the list of all values the enum could take, right? > > Should it not be just the one value it's going to have? It'll never > > change, and it can never b

Re: [RFC PATCH v4 22/42] drm/vkms: Use s32 for internal color pipeline precision

2024-03-12 Thread Pekka Paalanen
On Mon, 26 Feb 2024 16:10:36 -0500 Harry Wentland wrote: > Certain operations require us to preserve values below 0.0 and > above 1.0 (0x0 and 0x respectively in 16 bpc unorm). One > such operation is a BT709 encoding operation followed by its > decoding operation, or the reverse. > > We'll

[PATCH 41/43] drm/tiny/st7735r: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7735r. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner --- drivers/gpu/drm/tiny/st7735r.c | 4 ++

[PATCH 39/43] drm/tiny/repaper: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by repaper. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/repaper.c | 4

[PATCH 33/43] drm/tiny/ili9163: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9163. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ili9163.c | 4 ++-- 1 file changed,

[PATCH 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-03-12 Thread Thomas Zimmermann
Only TTM-based drivers use fbdev-generic. Rename it to fbdev-ttm and change the symbol infix from _generic_ to _ttm_. Link the source file into TTM helpers, so that it is only build if TTM-based drivers have been selected. Select DRM_TTM_HELPER for loongson. Signed-off-by: Thomas Zimmermann ---

[PATCH 35/43] drm/tiny/ili9341: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9341.c |

[PATCH 37/43] drm/tiny/mi0283qt: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by mi0283qt. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/mi0283qt.c |

[PATCH 32/43] drm/tiny/hx8357d: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by hx8357d. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/hx8357d.c | 4 ++-- 1 file changed,

[PATCH 17/43] drm/tiny/simpledrm: Use fbdev-shmem

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 25/43] drm/ingenic: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-d

[PATCH 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/tiny/gm12u320.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 30/43] drm/renesas/shmobile: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by shmobile. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Geert Uytterhoeven --- drivers/g

[PATCH 40/43] drm/tiny/st7586: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7586. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner --- drivers/gpu/drm/tiny/st7586.c | 4 ++--

[PATCH 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-03-12 Thread Thomas Zimmermann
Add support for damage handling and deferred I/O to fbdev-dma. This enables fbdev-dma to support all DMA-memory-based DRM drivers, even such with a dirty callback in their framebuffers. The patch adds the code for deferred I/O and also sets a dedicated helper for struct fb_ops.fb_mmap that support

[PATCH 24/43] drm/imx/lcdc: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by lcdc. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc

[PATCH 31/43] drm/rockchip: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rockchip. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- dri

[PATCH 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rcar-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham --- drivers/gpu/dr

[PATCH 38/43] drm/tiny/panel-mipi-dbi: Use fbdev-dma

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-mipi-dbi. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" --- drivers/gpu/drm/tiny/panel-

[PATCH 20/43] drm/vkms: Use fbdev-shmem

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_

[PATCH 43/43] drm/fbdev: Clean up fbdev documentation

2024-03-12 Thread Thomas Zimmermann
Rewrite some docs that are not up-to-date any longer. Remove the TODO item for fbdev-generic conversion, as the helper has been replaced. Make documentation for DMA, SHMEM and TTM emulation available. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet --- Documentation/gpu/drm-kms-helpers.rst

[PATCH 11/43] drm/hyperv: Use fbdev-shmem

2024-03-12 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

2024-03-12 Thread Thomas Zimmermann
Add a callback for drivers to provide framebuffer pages to fbdev's deferred-I/O helpers. Implementations need to acquire a reference on the page before returning it. Returning NULL generates a SIGBUS signal. This will be useful for DRM's fbdev emulation with GEM-shemem buffer objects. Signed-off-

  1   2   >