Re: [PATCH 3/3] drm/sun4i: Fix layer zpos change/atomic modesetting

2024-02-23 Thread Jernej Škrabec
On Saturday, February 24, 2024 3:20:43 AM CET Ondřej Jirman wrote: > On Thu, Feb 22, 2024 at 09:02:53PM +0100, Jernej Škrabec wrote: > > Dne sreda, 21. februar 2024 ob 14:45:20 CET je Maxime Ripard napisal(a): > > > Hi, > > > > > > On Fri, Feb 16, 2024 at 08:04:26PM +0100, Ondřej Jirman wrote: > >

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-23 Thread Mikko Perttunen
On 2/23/24 03:06, Thierry Reding wrote: On Thu Feb 22, 2024 at 2:05 AM CET, Mikko Perttunen wrote: From: Mikko Perttunen On Tegra186, secure world applications may need to access host1x during suspend/resume, and rely on the kernel to keep Host1x out of reset during the suspend cycle. As such,

Re: [PATCH 3/3] drm/sun4i: Fix layer zpos change/atomic modesetting

2024-02-23 Thread Ondřej Jirman
On Thu, Feb 22, 2024 at 09:02:53PM +0100, Jernej Škrabec wrote: > Dne sreda, 21. februar 2024 ob 14:45:20 CET je Maxime Ripard napisal(a): > > Hi, > > > > On Fri, Feb 16, 2024 at 08:04:26PM +0100, Ondřej Jirman wrote: > > > From: Ondrej Jirman > > > > > > Identical configurations of planes can l

Re: [PATCH 13/13] accel/habanalabs: modify pci health check

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Ofir Bitton Today we read PCI VENDOR-ID in order to make sure PCI link is healthy. Apparently the VENDOR-ID might be stored on host and hence, when we read it we might not access the PCI bus. In order to make sure PCI health check is reliable, we w

Re: [PATCH 12/13] accel/habanalabs: keep explicit size of reserved memory for FW

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tomer Tayar The reserved memory for FW is currently saved in an ASIC property in units of MB, just like the value that comes from FW. Except the fact that it is not clear from the property's name, it means also that a calculation to actual size is

Re: [PATCH 11/13] accel/habanalabs: handle reserved memory request when working with full FW

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tomer Tayar Currently the reserved memory request from FW is handled when running with preboot only, but this request is relevant also when running with full FW. Modify to always handle this reservation request. Signed-off-by: Tomer Tayar Reviewe

Re: [PATCH 10/13] accel/habanalabs/hwmon: rate limit errors user can generate

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Ofir Bitton Fetching sensor data can fail due to various reasons. In order not to pollute the kernel log, those error prints must be rate limited. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Car

Re: [PATCH 09/13] accel/habanalabs/gaudi2: drain event lacks rd/wr indication

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Ofir Bitton Due to a H/W issue, AXI drain event does not include a read/write indication, hence we remove this print. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Carl Vanderlip

Re: [PATCH 08/13] accel/habanalabs: fix error print

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Dani Liberman The unmasking is for event and it can be other event than RAZWI. Signed-off-by: Dani Liberman Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Carl Vanderlip

Re: [PATCH 07/13] accel/habanalabs: initialize maybe-uninitialized variables

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tal Risin Prevent static analysis warning. Signed-off-by: Tal Risin Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Carl Vanderlip

Re: [PATCH 06/13] accel/habanalabs: fix debugfs files permissions

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Avri Kehat debugfs files are created with permissions that don't align with the access requirements. Signed-off-by: Avri Kehat Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: Carl Vanderlip

Re: [PATCH 05/13] accel/habanalabs: fix glbl error cause handling

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tomer Tayar The glbl error cause handling has a wrong assumption that all error bits are consecutive. Fix the handling to check all relevant error bits per ASIC. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay R

Re: [PATCH 04/13] accel/habanalabs/gaudi2: check extended errors according to PCIe addr_dec interrupt info

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tomer Tayar The FW interrupt info for a PCIe addr_dec event is set correctly, so check for either global errors or razwi according to the indications there. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Review

Re: [PATCH 03/13] accel/habanalabs: modify print for skip loading linux FW to debug log

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Tomer Tayar Skip loading a linux FW image into the device with the current supported ASICs is done for test purposes only. Moreover, for future supported ASICs it is possible that there won't be a need to load such an image. The print in such a c

Re: [PATCH 02/13] accel/habanalabs: remove hop size from asic properties

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote: From: Farah Kassabri The hop size related properties is a MMU properties and not asic properties. As for PMMU and HMMU we could have different sizes. Signed-off-by: Farah Kassabri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Reviewed-by: C

[PATCH 2/2] drm/panel: panel-edp: Match with panel hash for overridden modes

2024-02-23 Thread Hsin-Yi Wang
It's found that some panels have variants that they share the same panel id although their EDID and names are different. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should

[PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-02-23 Thread Hsin-Yi Wang
It's found that some panels have variants that they share the same panel id although their EDID and names are different. Besides panel id, now we need the hash of entire EDID base block to distinguish these panel variants. Add drm_edid_get_base_block to returns the EDID base block, so caller can f

[PATCH 0/2] Match panel hash for overridden mode

2024-02-23 Thread Hsin-Yi Wang
This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add auo_b116xa3_mode""). It's found that 2 different AUO panels use the same product id. One of them requires an overridden mode, while the other should use the mode directly from edid. Since product id match is no longer suffici

Re: [PATCH 01/13] accel/habanalabs/gaudi2: use single function to compare FW versions

2024-02-23 Thread Carl Vanderlip
On 2/20/2024 8:01 AM, Oded Gabbay wrote:> From: Ohad Sharabi > > Currently, the code contains 2 types of FW version comparison functions: > - hl_is_fw_sw_ver_[below/equal_or_greater]() > - gaudi2 specific function of the type >gaudi2_is_fw_ver_[below/above]x_y_z() > > Moreover, some function

Re: [PATCH v2 00/21] drm/i915: Add Display Port tunnel BW allocation support

2024-02-23 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:18:20PM +0200, Imre Deak wrote: > This is v2 of [1], with the following changes: > > - Several functional/typo/formatting fixes, detailed in the patches. > - Move the BW allocation from encoder hooks to > intel_atomic_commit_tail() fixing the allocation for MST streams

Re: [PATCH v2 11/21] drm/i915/dp: Add way to get active pipes with syncing commits

2024-02-23 Thread Ville Syrjälä
On Sat, Feb 24, 2024 at 12:09:41AM +0200, Imre Deak wrote: > On Fri, Feb 23, 2024 at 11:11:45PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 20, 2024 at 11:18:31PM +0200, Imre Deak wrote: > > > Add a way to get the active pipes through a given DP port by syncing > > > against a related pending non-b

Re: [PATCH v2 11/21] drm/i915/dp: Add way to get active pipes with syncing commits

2024-02-23 Thread Imre Deak
On Fri, Feb 23, 2024 at 11:11:45PM +0200, Ville Syrjälä wrote: > On Tue, Feb 20, 2024 at 11:18:31PM +0200, Imre Deak wrote: > > Add a way to get the active pipes through a given DP port by syncing > > against a related pending non-blocking commit. Atm > > intel_dp_get_active_pipes() will only try t

Re: [PATCH v2 12/21] drm/i915/dp: Add support for DP tunnel BW allocation

2024-02-23 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:18:32PM +0200, Imre Deak wrote: > +static void queue_retry_work(struct intel_atomic_state *state, > + struct drm_dp_tunnel *tunnel, > + const struct intel_crtc_state *crtc_state) > +{ > + struct drm_i915_private *i915

Re: [PATCH v2 02/21] drm/dp: Add support for DP tunneling

2024-02-23 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:18:22PM +0200, Imre Deak wrote: > +static inline void drm_dp_tunnel_ref_put(struct drm_dp_tunnel_ref > *tunnel_ref) > +{ > + drm_dp_tunnel_put(tunnel_ref->tunnel, &tunnel_ref->tracker); Should we set tunnel_ref->tunnel=NULL here? -- Ville Syrjälä Intel

Re: [PATCH v2 16/21] drm/i915/dp: Allocate/free DP tunnel BW in the encoder enable/disable hooks

2024-02-23 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:18:36PM +0200, Imre Deak wrote: > Allocate and free the DP tunnel BW required by a stream while > enabling/disabling the stream during a modeset. > > v2: > - Move the allocation up from encoder hooks to > intel_atomic_commit_tail(). Subject should be adjusted to match

Re: [PATCH v2 4/7] drm/msm/adreno: Add missing defines for A702

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 23:21, Konrad Dybcio wrote: > > Add some defines required for A702. Can be substituted with a header > sync after merging mesa!27665 [1]. > > [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27665 > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adre

Re: [PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 23:21, Konrad Dybcio wrote: > > Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") > introduced an entry to the alpha offsets array, but diving into QCM2290 > downstream and some documentation, it turned out that the name Huayra > apparently has been used quite

[PATCH] drm/mediatek: Fix a null pointer crash in mtk_drm_crtc_finish_page_flip

2024-02-23 Thread Hsin-Yi Wang
It's possible that mtk_crtc->event is NULL in mtk_drm_crtc_finish_page_flip(). pending_needs_vblank value is set by mtk_crtc->event, but in mtk_drm_crtc_atomic_flush(), it's is not guarded by the same lock in mtk_drm_finish_page_flip(), thus a race condition happens. Consider the following case:

[PATCH v2 7/7] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-23 Thread Konrad Dybcio
Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). [1] https://docs.qualcomm.com/bundle/publicresource/87-61720-1_REV_A_QUALCOMM_ROBOTICS_RB1_PLATFORM__QUALCOMM_QRB2210__PRODUCT_BRIEF.pdf Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/

[PATCH v2 6/7] arm64: dts: qcom: qcm2290: Add GPU nodes

2024-02-23 Thread Konrad Dybcio
Describe the GPU hardware on the QCM2290. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 154 ++ 1 file changed, 154 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/q

[PATCH v2 5/7] drm/msm/adreno: Add A702 support

2024-02-23 Thread Konrad Dybcio
The A702 is a weird mix of 600 and 700 series.. Perhaps even a testing ground for some A7xx features with good ol' A6xx silicon. It's basically A610 that's been beefed up with some new registers and hw features (like APRIV!), that was then cut back in size, memory bus and some other ways. Add supp

[PATCH v2 2/7] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-23 Thread Konrad Dybcio
Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") introduced an entry to the alpha offsets array, but diving into QCM2290 downstream and some documentation, it turned out that the name Huayra apparently has been used quite liberally across many chips, even with noticeably different h

[PATCH v2 3/7] clk: qcom: Add QCM2290 GPU clock controller driver

2024-02-23 Thread Konrad Dybcio
Add a driver for the GPU clock controller block found on the QCM2290 SoC. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/Kconfig | 9 + drivers/clk/qcom/Makefile| 1 + drivers/clk/qcom/gpucc-qcm2290.c | 423 +++

[PATCH v2 4/7] drm/msm/adreno: Add missing defines for A702

2024-02-23 Thread Konrad Dybcio
Add some defines required for A702. Can be substituted with a header sync after merging mesa!27665 [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27665 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 18 ++ 1 file changed, 18 insertion

[PATCH v2 1/7] dt-bindings: clock: Add Qcom QCM2290 GPUCC

2024-02-23 Thread Konrad Dybcio
Add device tree bindings for graphics clock controller for Qualcomm Technology Inc's QCM2290 SoCs. Signed-off-by: Konrad Dybcio --- .../bindings/clock/qcom,qcm2290-gpucc.yaml | 77 ++ include/dt-bindings/clock/qcom,qcm2290-gpucc.h | 32 + 2 files changed,

[PATCH v2 0/7] A702 support

2024-02-23 Thread Konrad Dybcio
Bit of a megaseries, bunched together for your testing convenience.. Needs mesa!27665 [1] on the userland part, kmscube happily spins. I'm feeling quite lukewarm about the memory barriers in patch 3.. Patch 1 for Will/smmu, 5-6 for drm/msm, rest for qcom [1] https://gitlab.freedesktop.org/mesa/m

Re: [PATCH] drm/i915: convert remaining intel_dp_vsc_sdp_pack

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 14:15:48 -0500, Rodrigo Vivi wrote: > Commit 47f419e07111 ("drm/dp: move intel_dp_vsc_sdp_pack() to generic helper") > and commit b55b88d86fec ("drm/dp: drop the size parameter from > drm_dp_vsc_sdp_pack()") > were based on top of a tree containing the > commit 31a5b6ed88c7 ("d

Re: [PATCH v2 11/21] drm/i915/dp: Add way to get active pipes with syncing commits

2024-02-23 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:18:31PM +0200, Imre Deak wrote: > Add a way to get the active pipes through a given DP port by syncing > against a related pending non-blocking commit. Atm > intel_dp_get_active_pipes() will only try to sync a given pipe and if > that would block ignore the pipe. A follow

[PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-02-23 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/

[PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL

2024-02-23 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. v2: Fix bug in WA KLV implementation (offset not being reset to start of list). Add better comment to prep patch about how KLVs can be added. Add a module parameter override and disable the w/a by

[PATCH v3 2/3] drm/i915/guc: Add support for w/a KLVs

2024-02-23 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h

[PATCH v3 1/3] drm/i915: Enable Wa_16019325821

2024-02-23 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19 +++---

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote: > > > > On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: > > The DPU driver provides support for 4:2:0 planar YCbCr plane formats. > > Extend it to also support 4:2:2 and 4:4:4 plat formats. > > > > I checked myself and also internally on this. On sm

Re: [PATCH] drm/i915: convert remaining intel_dp_vsc_sdp_pack

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 21:15, Rodrigo Vivi wrote: > > Commit 47f419e07111 ("drm/dp: move intel_dp_vsc_sdp_pack() to generic helper") > and commit b55b88d86fec ("drm/dp: drop the size parameter from > drm_dp_vsc_sdp_pack()") > were based on top of a tree containing the > commit 31a5b6ed88c7 ("drm/

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-02-23 Thread Abhinav Kumar
On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: The DPU driver provides support for 4:2:0 planar YCbCr plane formats. Extend it to also support 4:2:2 and 4:4:4 plat formats. I checked myself and also internally on this. On sm8250, the DPU planes do not support YUV444 and YUV422 (and the corr

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 13:46:53 -0500 Steven Rostedt wrote: > Now one thing I could do is to not remove the parameter, but just add: > > WARN_ON_ONCE((src) != __data_offsets->item##_ptr_); > > in the __assign_str() macro to make sure that it's still the same that is > assigned. But I'm not s

[PATCH] drm/i915/guc: Correct capture of EIR register on hang

2024-02-23 Thread John . C . Harrison
From: John Harrison The EIR register (0x20B0) was being included in the engine class list for render and compute as the absolute register address. However, it is actually a ring register available on all engines at an offset of (base) + 0xB0. As it was included as an RCS engine but with the absol

[PATCH v3] drm/i915/guc: Simplify/extend platform check for Wa_14018913170

2024-02-23 Thread John . C . Harrison
From: John Harrison The above w/a is required for every platform that the i915 driver supports. It is fixed on the latest platforms but they are only supported by Xe instead of i915. So just remove the platform check completely and keep the code simple. v2: Add extra comment (review feedback fro

Re: i915 build error on drm-misc-next

2024-02-23 Thread Abhinav Kumar
On 2/23/2024 11:35 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 09:47:11AM -0800, Abhinav Kumar wrote: CC Dmitry Hi Rodrigo On 2/23/2024 9:00 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: With the x86_64_defconfig I see the following when buildin

Re: [PATCH] drm/i915: convert remaining intel_dp_vsc_sdp_pack

2024-02-23 Thread Abhinav Kumar
On 2/23/2024 11:15 AM, Rodrigo Vivi wrote: Commit 47f419e07111 ("drm/dp: move intel_dp_vsc_sdp_pack() to generic helper") and commit b55b88d86fec ("drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()") were based on top of a tree containing the commit 31a5b6ed88c7 ("drm/i915/display: U

RE: Making drm_gpuvm work across gpu devices

2024-02-23 Thread Zeng, Oak
Hi Christian, I go back this old email to ask a question. Quote from your email: “Those ranges can then be used to implement the SVM feature required for higher level APIs and not something you need at the UAPI or even inside the low level kernel memory management.” “SVM is a high level concept

Re: [PATCH] drm/v3d: Enable V3D to use different PAGE_SIZE

2024-02-23 Thread Maíra Canal
Hi Iago, On 2/20/24 03:35, Iago Toral wrote: El lun, 19-02-2024 a las 10:00 -0300, Maíra Canal escribió: Hi Iago, On 2/19/24 09:56, Iago Toral wrote: Hi Maíra, El mié, 14-02-2024 a las 16:34 -0300, Maíra Canal escribió: Currently, the V3D driver uses PAGE_SHIFT over the assumption that PAGE

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 14:50:49 -0500 Kent Overstreet wrote: > Tangentially related though, what would make me really happy is if we > could create the string with in the TP__fast_assign() section. I have to > have a bunch of annoying wrappers right now because the string length > has to be known wh

Re: i915 build error on drm-misc-next

2024-02-23 Thread Rodrigo Vivi
On Fri, Feb 23, 2024 at 09:47:11AM -0800, Abhinav Kumar wrote: > CC Dmitry > > Hi Rodrigo > > On 2/23/2024 9:00 AM, Rodrigo Vivi wrote: > > On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: > > > With the x86_64_defconfig I see the following when building drm-misc-next: > > > > > >

Re: [PATCH] drm/i915/guc: Add Compute context hint

2024-02-23 Thread Rodrigo Vivi
On Fri, Feb 23, 2024 at 10:31:41AM -0800, Belgaumkar, Vinay wrote: > > On 2/23/2024 12:51 AM, Tvrtko Ursulin wrote: > > > > On 22/02/2024 23:31, Belgaumkar, Vinay wrote: > > > > > > On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote: > > > > > > > > On 21/02/2024 21:28, Rodrigo Vivi wrote: > > > > > On

Re: [PATCH] drm/amd/display: clean unnecessary braces

2024-02-23 Thread Tulio Moreira Fernandes
Hi, Christian! Ok, thanks for clarifying this for me. I'll continue analyzing the files here, now based on these points. Best regards Em qui., 22 de fev. de 2024 às 06:33, Christian König escreveu: > > Am 21.02.24 um 19:01 schrieb Rodrigo Siqueira Jordao: > > [SNIP] > >> diff --git > >> a/dri

Re: [PATCH] drm: ci: uprev IGT

2024-02-23 Thread Rob Clark
On Wed, Feb 21, 2024 at 6:36 PM Dmitry Baryshkov wrote: > > On Tue, 20 Feb 2024 at 16:31, Helen Koike wrote: > > > > > > > > On 20/02/2024 09:17, Dmitry Baryshkov wrote: > > > Bump IGT revision to pick up Rob Clark's fixes for the msm driver: > > > > > > - msm_submit@invalid-duplicate-bo-submit,F

[PATCH] drm/i915: convert remaining intel_dp_vsc_sdp_pack

2024-02-23 Thread Rodrigo Vivi
Commit 47f419e07111 ("drm/dp: move intel_dp_vsc_sdp_pack() to generic helper") and commit b55b88d86fec ("drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()") were based on top of a tree containing the commit 31a5b6ed88c7 ("drm/i915/display: Unify VSC SPD preparation") but landed in a tree

Re: [PATCH v2 0/9] Add Chameleon v3 video support

2024-02-23 Thread Conor Dooley
Hey, On Wed, Feb 21, 2024 at 04:02:06PM +, Paweł Anikiel wrote: > media: dt-bindings: Add Chameleon v3 framebuffer > media: dt-bindings: Add Intel Displayport RX IP I'm happy with both of these patches, but I would like others to look, so I'll hold off leaving R-b tags until someone else

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 10:30:45 -0800 Jeff Johnson wrote: > On 2/23/2024 9:56 AM, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > [ > >This is a treewide change. I will likely re-create this patch again in > >the second week of the merge window of v6.9 and submit it then.

Re: [git pull] drm fixes for 6.8-rc6

2024-02-23 Thread pr-tracker-bot
The pull request you sent on Fri, 23 Feb 2024 11:32:09 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/06b7ef70b1f29de685ea80f0c1b8f0a0b0e16d18 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Jeff Johnson
On 2/23/2024 9:56 AM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will cause to a minimum. >

Re: [PATCH] drm/i915/guc: Add Compute context hint

2024-02-23 Thread Belgaumkar, Vinay
On 2/23/2024 12:51 AM, Tvrtko Ursulin wrote: On 22/02/2024 23:31, Belgaumkar, Vinay wrote: On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote: On 21/02/2024 21:28, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Vinay Belgaumkar wrote: A

[linux-next:master] BUILD REGRESSION 33e1d31873f87d119e5120b88cd350efa68ef276

2024-02-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 33e1d31873f87d119e5120b88cd350efa68ef276 Add linux-next specific files for 20240223 Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | `-- drivers-gpu-drm

Re: [PATCH 2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00

2024-02-23 Thread Conor Dooley
On Fri, Feb 23, 2024 at 02:45:16PM +0100, Jérémie Dautheribes wrote: > Add Crystal Clear Technology CMT430B19N00 4.3" 480x272 TFT-LCD panel > compatible string. > > Signed-off-by: Jérémie Dautheribes Acked-by: Conor Dooley Cheers, Conor. > --- > .../devicetree/bindings/display/panel/panel-si

Re: [PATCH 1/3] dt-bindings: Add Crystal Clear Technology vendor prefix

2024-02-23 Thread Conor Dooley
On Fri, Feb 23, 2024 at 02:45:15PM +0100, Jérémie Dautheribes wrote: > Update Documentation/devicetree/bindings/vendor-prefixes.yaml to > include "cct" as a vendor prefix for "Crystal Clear Technology". CCT is > the vendor of the CMT430B19N00 TFT-LCD panel. > Acked-by: Conor Dooley And add a Li

Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-02-23 Thread Steven Rostedt
On Fri, 23 Feb 2024 12:56:34 -0500 Steven Rostedt wrote: > Note, the same updates will need to be done for: > > __assign_str_len() > __assign_rel_str() > __assign_rel_str_len() Correction: The below macros do not pass in their source to the entry macros, so they will not need to be update

Re: i915 build error on drm-misc-next

2024-02-23 Thread Abhinav Kumar
CC Dmitry Hi Rodrigo On 2/23/2024 9:00 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: With the x86_64_defconfig I see the following when building drm-misc-next: CC drivers/gpu/drm/i915/display/intel_crt.o CC drivers/gpu/drm/i915/display/i

[PATCH] drm/i915/display: Save a few bytes of memory in intel_backlight_device_register()

2024-02-23 Thread Christophe JAILLET
'name' may still be "intel_backlight" when backlight_device_register() is called. In such a case, using kstrdup_const() saves a memory duplication when dev_set_name() is called in backlight_device_register(). Use kfree_const() accordingly. Signed-off-by: Christophe JAILLET --- Compile tested onl

Re: [PATCH v8 2/7] drm: atmel-hlcdc: Define XLCDC specific registers

2024-02-23 Thread Lee Jones
On Wed, 21 Feb 2024, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > The register address of the XLCDC IP used in SAM9X7 SoC family > are different from the previous HLCDC. Defining those address > space with valid macros. > > Signed-off-by: Durai Manickam KR > [manikanda...@micro

Re: (subset) [PATCH 0/4] Various fixes for the lm3630a backlight driver

2024-02-23 Thread Lee Jones
On Tue, 20 Feb 2024 00:11:18 +0100, Luca Weiss wrote: > On the MSM8974 Nexus 5 and OnePlus One phones (latter doesn't have > display upstream) the display backlight was turning off whenever you > would write a brightness to sysfs since a recent commit to the driver > (kernel v6.5). > > backlight

Re: [PATCH] drm/nouveau: use dedicated wq for fence uevents work

2024-02-23 Thread Danilo Krummrich
On Fri, Feb 23, 2024 at 10:14:53AM +1000, Dave Airlie wrote: > On Fri, 23 Feb 2024 at 00:45, Danilo Krummrich wrote: > > > > Using the kernel global workqueue to signal fences can lead to > > unexpected deadlocks. Some other work (e.g. from a different driver) > > could directly or indirectly depe

Re: i915 build error on drm-misc-next

2024-02-23 Thread Rodrigo Vivi
On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: > With the x86_64_defconfig I see the following when building drm-misc-next: > > CC drivers/gpu/drm/i915/display/intel_crt.o > CC drivers/gpu/drm/i915/display/intel_cx0_phy.o > CC drivers/gpu/drm/i915/display/intel_

Re: [PATCH 1/3] drm/amdgpu: Refuse to create a KMS FB for non-P2P exported dma-bufs

2024-02-23 Thread Michel Dänzer
On 2024-02-23 11:04, Michel Dänzer wrote: > On 2024-02-23 10:34, Christian König wrote: >> Am 23.02.24 um 09:11 schrieb Michel Dänzer: >>> On 2024-02-23 08:06, Christian König wrote: Am 22.02.24 um 18:28 schrieb Michel Dänzer: > From: Michel Dänzer > > Pinning the BO storage to VR

Re: [PATCH RESEND 0/4] Ensure all backlight drivers zero the properties structure

2024-02-23 Thread Lee Jones
On Tue, 20 Feb 2024, Daniel Thompson wrote: > [Sorry for the RESEND so soon... embarrassingly I got Lee's e-mail > address wrong the first time!] > > Luca Weiss recently shared a patch to zero the properties structure for > lm3630a... and shortly afterwards I realized I should probably scan for

Re: (subset) [PATCH] dt-bindings: backlight: qcom-wled: Fix bouncing email addresses

2024-02-23 Thread Lee Jones
On Fri, 02 Feb 2024 11:01:51 -0700, Jeffrey Hugo wrote: > Bjorn is no longer at Linaro. Update his email address to @kernel to > match the .mailmap entry. > > The servers for @codeaurora are long retired and messages sent there > will bounce. Update Kiran's email address to match the .mailmap en

Re: (subset) [PATCH RESEND 4/4] backlight: mp3309c: Fully initialize backlight_properties during probe

2024-02-23 Thread Lee Jones
On Tue, 20 Feb 2024 15:35:27 +, Daniel Thompson wrote: > props is stack allocated and, although this driver initializes all the > fields that are not "owned" by the framework, we'd still like to ensure > it is zeroed to avoid problems from this driver if the fields change. > > Applied, thank

Re: [PATCH] accel/qaic: Constify aic100_channels

2024-02-23 Thread Jeffrey Hugo
On 2/22/2024 6:06 PM, Jeff Johnson wrote: MHI allows the channel configs to be const, so constify aic100_channels to prevent runtime modification. Signed-off-by: Jeff Johnson Applied to drm-misc-next -Jeff

Re: [linux-next:master] BUILD REGRESSION e31185ce00a96232308300008db193416ceb9769

2024-02-23 Thread John Paul Adrian Glaubitz
On Fri, 2024-02-23 at 07:46 -0800, Kees Cook wrote: > > arch/sh/boot/compressed/../../../../lib/decompress_unxz.c:350:(.text+0x20b4): > > undefined reference to `__ubsan_handle_out_of_bounds' > > sh4-linux-ld: > > arch/sh/boot/compressed/../../../../lib/xz/xz_dec_lzma2.c:751:(.text+0x904): > > u

Re: [PATCH v2 0/2] leds: expresswire: Fix dependencies

2024-02-23 Thread Lee Jones
On Fri, 16 Feb 2024 22:15:42 +0100, Duje Mihanović wrote: > LEDS_EXPRESSWIRE does not depend on NEW_LEDS in practice but still does > in Kconfig. Fix up its Kconfig entry to reflect this and fix a Kconfig > warning. > > Applied, thanks! [1/2] Revert "leds: Only descend into leds directory when

i915 build error on drm-misc-next

2024-02-23 Thread Jeffrey Hugo
With the x86_64_defconfig I see the following when building drm-misc-next: CC drivers/gpu/drm/i915/display/intel_crt.o CC drivers/gpu/drm/i915/display/intel_cx0_phy.o CC drivers/gpu/drm/i915/display/intel_ddi.o CC drivers/gpu/drm/i915/display/intel_ddi_buf_trans.o CC

Re: [linux-next:master] BUILD REGRESSION e31185ce00a96232308300008db193416ceb9769

2024-02-23 Thread Kees Cook
On February 22, 2024 8:29:28 PM PST, kernel test robot wrote: >tree/branch: >https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >branch HEAD: e31185ce00a9623230838db193416ceb9769 Add linux-next specific >files for 20240222 > >Error/Warning reports: > >https://lore

Re: [PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-23 Thread Javier Martinez Canillas
Thierry Reding writes: Hello Thierry, > From: Thierry Reding > > Tegra DRM doesn't support display on Tegra234 and later, so make sure > not to remove any existing framebuffers in that case. > > v2: - add comments explaining how this situation can come about > - clear DRIVER_MODESET and DRI

[PATCH v7 3/6] iio: core: Add new DMABUF interface infrastructure

2024-02-23 Thread Nuno Sa
From: Paul Cercueil Add the necessary infrastructure to the IIO core to support a new optional DMABUF based interface. With this new interface, DMABUF objects (externally created) can be attached to a IIO buffer, and subsequently used for data transfer. A userspace application can then use this

Re: [PATCH] accel/qaic: Constify aic100_channels

2024-02-23 Thread Jeffrey Hugo
On 2/22/2024 6:06 PM, Jeff Johnson wrote: MHI allows the channel configs to be const, so constify aic100_channels to prevent runtime modification. Signed-off-by: Jeff Johnson Reviewed-by: Jeffrey Hugo I plan to apply to drm-misc-next before the rc6 freeze.

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 16:55, Neil Armstrong wrote: > > On 23/02/2024 15:52, Johan Hovold wrote: > > On Fri, Feb 23, 2024 at 03:38:13PM +0100, Neil Armstrong wrote: > >> On 23/02/2024 15:21, Johan Hovold wrote: > > > >>> But it is *not* standalone as I tried to explain above. > >>> > >>> So you ha

Re: (subset) [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Dmitry Baryshkov
On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: > Starting with 6.8-rc1 the internal display sometimes fails to come up on > machines like the Lenovo ThinkPad X13s and the logs indicate that this > is due to a regression in the DRM subsystem [1]. > > This series fixes a race in the pmic_gl

[PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-23 Thread Thierry Reding
From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. v2: - add comments explaining how this situation can come about - clear DRIVER_MODESET and DRIVER_ATOMIC feature bits Signed-off-by: Thierry Redin

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 15:52, Johan Hovold wrote: On Fri, Feb 23, 2024 at 03:38:13PM +0100, Neil Armstrong wrote: On 23/02/2024 15:21, Johan Hovold wrote: But it is *not* standalone as I tried to explain above. So you have to drop it again as the later patches depend on it and cannot be merged (throu

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 17/02/2024 16:02, Johan Hovold wrote: Starting with 6.8-rc1 the internal display sometimes fails to come up on machines like the Lenovo ThinkPad X13s and the logs indicate that this is due to a regression in the DRM subsystem [1]. This series fixes a race in the pmic_glink_altmode driver whic

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Johan Hovold
On Fri, Feb 23, 2024 at 03:38:13PM +0100, Neil Armstrong wrote: > On 23/02/2024 15:21, Johan Hovold wrote: > > But it is *not* standalone as I tried to explain above. > > > > So you have to drop it again as the later patches depend on it and > > cannot be merged (through a different tree) without

Re: (subset) [PATCH] backlight: ktd2801: make timing struct static

2024-02-23 Thread Lee Jones
On Sat, 10 Feb 2024 17:16:17 +0100, Duje Mihanović wrote: > The struct containing the KTD2801 timing can be made static as it's not > referenced outside the KTD2801 driver. Do this to prevent sparse > complaints. > > Applied, thanks! [1/1] backlight: ktd2801: make timing struct static com

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 15:21, Johan Hovold wrote: On Fri, Feb 23, 2024 at 02:52:28PM +0100, Neil Armstrong wrote: On 23/02/2024 13:51, Johan Hovold wrote: On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: On 23/02/2024 12:02, Neil Armstrong wrote: Thanks, Applied to https://anongit.fre

Re: [PATCH v2 02/21] drm/dp: Add support for DP tunneling

2024-02-23 Thread Imre Deak
On Fri, Feb 23, 2024 at 08:25:38AM +0200, Shankar, Uma wrote: > [...] > > diff --git a/drivers/gpu/drm/display/Kconfig > > b/drivers/gpu/drm/display/Kconfig > > index 09712b88a5b83..c0f56888c3280 100644 > > --- a/drivers/gpu/drm/display/Kconfig > > +++ b/drivers/gpu/drm/display/Kconfig > [...] > >

Re: [PATCH 1/2] drm/ttm: improve idle/busy handling v4

2024-02-23 Thread Christian König
Am 06.02.24 um 13:56 schrieb Christian König: Am 06.02.24 um 13:53 schrieb Thomas Hellström: Hi, Christian, On Fri, 2024-01-26 at 15:09 +0100, Christian König wrote: Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those wer

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Johan Hovold
On Fri, Feb 23, 2024 at 04:18:08PM +0200, Dmitry Baryshkov wrote: > On Fri, 23 Feb 2024 at 15:52, Neil Armstrong > wrote: > > On 23/02/2024 13:51, Johan Hovold wrote: > > > On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > > >> On 23/02/2024 12:02, Neil Armstrong wrote: > > >>> T

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Johan Hovold
On Fri, Feb 23, 2024 at 02:52:28PM +0100, Neil Armstrong wrote: > On 23/02/2024 13:51, Johan Hovold wrote: > > On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > >> On 23/02/2024 12:02, Neil Armstrong wrote: > >>> Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.g

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 15:52, Neil Armstrong wrote: > > On 23/02/2024 13:51, Johan Hovold wrote: > > On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: > >> On 23/02/2024 12:02, Neil Armstrong wrote: > >>> Hi, > >>> > >>> On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: >

[PATCH v7 6/6] Documentation: iio: Document high-speed DMABUF based API

2024-02-23 Thread Nuno Sa
From: Paul Cercueil Document the new DMABUF based API. Signed-off-by: Paul Cercueil Signed-off-by: Nuno Sa --- Documentation/iio/dmabuf_api.rst | 54 Documentation/iio/index.rst | 2 ++ 2 files changed, 56 insertions(+) diff --git a/Documentatio

Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-23 Thread Neil Armstrong
On 23/02/2024 13:51, Johan Hovold wrote: On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote: On 23/02/2024 12:02, Neil Armstrong wrote: Hi, On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote: Starting with 6.8-rc1 the internal display sometimes fails to come up on machines lik

  1   2   >