Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Lazar, Lijo
On 8/21/2023 12:17 PM, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Lazar, Lijo
On 8/21/2023 12:17 PM, Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches.

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-08-21 Thread Kasireddy, Vivek
Hi Alistair, > >> > > > No, adding HMM_PFN_REQ_WRITE still doesn't help in fixing the > issue. > >> > > > Although, I do not have THP enabled (or built-in), shmem does not > evict > >> > > > the pages after hole punch as noted in the comment in > >> shmem_fallocate(): > >> > > > >> > > This is the

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 11:40 PM, Alex Deucher wrote: On Mon, Aug 21, 2023 at 1:54 PM Yadav, Arvind wrote: On 8/21/2023 9:52 PM, Alex Deucher wrote: On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This c

Re: [RFC PATCH v2 06/11] page-pool: add device memory support

2023-08-21 Thread Mina Almasry
On Sat, Aug 19, 2023 at 2:51 AM Jesper Dangaard Brouer wrote: > > > > On 10/08/2023 03.57, Mina Almasry wrote: > > Overload the LSB of struct page* to indicate that it's a page_pool_iov. > > > > Refactor mm calls on struct page * into helpers, and add page_pool_iov > > handling on those helpers. M

RE: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA

2023-08-21 Thread Kasireddy, Vivek
Hi Jason, > > This patch series adds support for migrating pages associated with > > a udmabuf out of the movable zone or CMA to avoid breaking features > > such as memory hotunplug. > > > > The first patch exports check_and_migrate_movable_pages() function > > out of GUP so that the udmabuf drive

RE: [PATCH v14 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-08-21 Thread Ying Liu
Hi, > On Friday, January 6, 2023 1:50 PM Ying Liu wrote: > > Hi, > > > This is the v14 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) > DRM support. > > DPU is comprised of a blit engine for 2D graphics, a display controller > and a command sequencer. Outside of DPU, optional pr

[PATCH v2] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-21 Thread Dmitry Osipenko
Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead developer of the Panfrost Mesa driver and main developer behind the upcoming Panthor kernel driver that will serve next-gen Mali GPUs. Remove Tomeu and Alyssa, who left Collabora and stepped down from working on Panfrost. Acke

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Lazar, Lijo
On 8/21/2023 12:17 PM, Arvind Yadav wrote: This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Power profile once job finished. - Here, the *_w

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-21 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 25205087df1ffe06ccea9302944ed1f77dc68c6f] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-drm_exec-build-always-builtin/20230821-123143 base

[PATCH v6, 1/4] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2023-08-21 Thread Shuijing Li
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Acked-by: Krzysztof Kozlowski --- Changes in v2: add a mediatek,mt8188-edp-tx compatible per suggestion from the previ

[PATCH v6, 2/4] drm/mediatek: dp: Add the audio packet flag to mtk_dp_data struct

2023-08-21 Thread Shuijing Li
The audio packet arrangement function is to only arrange audio packets into the Hblanking area. In order to align with the HW default setting of mt8195, this function needs to be turned off. Signed-off-by: Shuijing Li --- Changes in v6: Move mt8188 related code to another patch per suggestion fro

[PATCH v6,0/4] Add compatible to increase MT8188 audio control

2023-08-21 Thread Shuijing Li
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. Mainly add the following two flag: 1.The audio packet arrangement function is to only arrange audio packets into the Hblanking area. In order to align with the HW default setting of g1200, this function needs to be turned off. 2.Due t

[PATCH v6, 3/4] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-08-21 Thread Shuijing Li
Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li --- Changes in v6: Move MT8188 defintion to patch[4/4]. per suggestion from the previous thread: https://lore.kernel.org/all/60ba1ab40fc943f1abf3e78b0b32223be402302c.ca...@mediatek.com/ Changes in v4: list

[PATCH v6,4/4] drm/mediatek: dp: Add support MT8188 dp/edp function

2023-08-21 Thread Shuijing Li
Add support MT8188 dp/edp function Signed-off-by: Shuijing Li --- Changes in v6: Move audio function to patch [2/4]. per suggestion from the previous thread: https://lore.kernel.org/all/1d41747060c613ca0ae8e3b6395cc33bfa4d9056.ca...@mediatek.com/ Changes in v5: Separate mt8188 related code into m

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread suijingfeng
Hi, On 2023/8/22 01:38, Bjorn Helgaas wrote: On Fri, Aug 18, 2023 at 12:09:29PM +0800, suijingfeng wrote: On 2023/8/18 06:08, Bjorn Helgaas wrote: On Wed, Aug 16, 2023 at 06:05:27AM +0800, Sui Jingfeng wrote: Currently, the vga_is_firmware_default() function only works on x86 and ia64, it is

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-21 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 25205087df1ffe06ccea9302944ed1f77dc68c6f] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-drm_exec-build-always-builtin/20230821-123143 base

Re: [PATCH v2] drm/amdgpu: Avoid possible buffer overflow

2023-08-21 Thread Su Hui
On 2023/8/21 17:31, Christian König wrote: Am 21.08.23 um 09:37 schrieb Su Hui: smatch error: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1257 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use. change the assignment order to avoid buffer overflo

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-21 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 25205087df1ffe06ccea9302944ed1f77dc68c6f] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-drm_exec-build-always-builtin/20230821-123143 base

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread suijingfeng
Hi, On 2023/8/22 01:33, Bjorn Helgaas wrote: On Fri, Aug 18, 2023 at 09:48:46AM +0800, suijingfeng wrote: On 2023/8/18 06:08, Bjorn Helgaas wrote: + if (resource_type(res) != IORESOURCE_MEM) + continue; + + if (!res->start || !res->end) +

Re: [RFC PATCH v2 06/11] page-pool: add device memory support

2023-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2023 at 5:31 PM Jakub Kicinski wrote: > > On Sat, 19 Aug 2023 12:12:16 -0400 Willem de Bruijn wrote: > > :-) For the record, there is a prior version that added a separate type. > > > > I did not like the churn it brought and asked for this. > > It does end up looking cleaner that

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread vitaly prosyak
Hi Christian, On 2023-08-21 07:03, Christian König wrote: > Am 20.08.23 um 11:51 schrieb Christophe JAILLET: >> This serie simplifies amdgpu_bo_list_create() and usage of the 'struct >> amdgpu_bo_list'. > Oh, yes please. That's something I always wanted to cleanup as well. > >> It is compile test

Re: [PATCH v1] drivers: gpu: drm: i915: intel_huc: fix formatting warnings

2023-08-21 Thread Jani Nikula
On Mon, 21 Aug 2023, Nikita B wrote: > Fix formatting warnings when run "make htmldocs": > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: WARNING: Unexpected indentation. > ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends > without a blank line; unexpected unindent. > ./driver

Re: [PATCH] drm: renesas: rcar-du: use proper naming for R-Car

2023-08-21 Thread Kieran Bingham
Quoting Wolfram Sang (2023-08-16 11:56:41) > Not RCAR, but R-Car. > Reviewed-by: Kieran Bingham > Signed-off-by: Wolfram Sang > --- > drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_d

Re: [RFC PATCH v2 06/11] page-pool: add device memory support

2023-08-21 Thread Jakub Kicinski
On Sat, 19 Aug 2023 12:12:16 -0400 Willem de Bruijn wrote: > :-) For the record, there is a prior version that added a separate type. > > I did not like the churn it brought and asked for this. It does end up looking cleaner that I personally expected, FWIW. > > Use of the LSB (or bits depending

Re: [PATCH] gpu: drm: i915: fix documentation style

2023-08-21 Thread Ceraolo Spurio, Daniele
On 8/21/2023 9:22 AM, Jani Nikula wrote: On Mon, 21 Aug 2023, "Ricardo B. Marliere" wrote: This patch fixes the following sphinx warnings in the htmldocs make target: Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: ERROR: Unexpected indentation. Documentation/gpu/i

Re: [PATCH] dt-bindings: display: msm/dp: restrict opp-table to objects

2023-08-21 Thread Rob Herring
On Sun, 20 Aug 2023 10:05:43 +0200, Krzysztof Kozlowski wrote: > Simple 'opp-table:true' accepts a boolean property as opp-table, so > restrict it to object to properly enforce real OPP table nodes. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/display/msm/dp-controlle

Re: Implement svm without BO concept in xe driver

2023-08-21 Thread Felix Kuehling
On 2023-08-21 15:41, Zeng, Oak wrote: I have thought about emulating BO allocation APIs on top of system SVM. This was in the context of KFD where memory management is not tied into command submissions APIs, which would add a whole other layer of complexity. The main unsolved (unsolvable?) prob

[PATCH 6.4 221/234] Revert "drm/edid: Fix csync detailed mode parsing"

2023-08-21 Thread Greg Kroah-Hartman
From: Jani Nikula commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream. This reverts commit ca62297b2085b5b3168bd891ca24862242c635a1. Commit ca62297b2085 ("drm/edid: Fix csync detailed mode parsing") fixed EDID detailed mode sync parsing. Unfortunately, there are quite a few displays out th

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-08-21 Thread André Almeida
Hi Michel, Em 17/08/2023 07:37, Michel Dänzer escreveu: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida [

[PATCH] drm/prime: Support page array >= 4GB

2023-08-21 Thread Philip Yang
Without unsigned long typecast, the size is passed in as zero if page array size >= 4GB, nr_pages >= 0x10, then sg list converted will have the first and the last chunk lost. Signed-off-by: Philip Yang --- drivers/gpu/drm/drm_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v2 00/12] drm/bridge: tc358768: Fixes and timings improvements

2023-08-21 Thread Péter Ujfalusi
On 16/08/2023 14:25, Tomi Valkeinen wrote: > This series contains various fixes and cleanups for TC358768. The target > of this work is to get TC358768 working on Toradex's AM62 based board, > which has the following display pipeline: > > AM62 DPI -> TC358768 -> LT8912B -> HDMI connector > > T

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Faith Ekstrand
On Mon, Aug 21, 2023 at 1:13 PM Christian König wrote: > Am 21.08.23 um 20:01 schrieb Danilo Krummrich: > > On 8/21/23 16:07, Christian König wrote: > >> Am 18.08.23 um 13:58 schrieb Danilo Krummrich: > >>> [SNIP] > I only see two possible outcomes: > 1. You return -EBUSY (or similar) e

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Felix > Kuehling > Sent: August 21, 2023 3:18 PM > To: Zeng, Oak ; Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; > Welty, Brian ; dri-devel@lists.freedesktop.org; > Christian > König ; Vishwanathapura, Niranjana

Re: Implement svm without BO concept in xe driver

2023-08-21 Thread Felix Kuehling
On 2023-08-21 11:10, Zeng, Oak wrote: Accidently deleted Brian. Add back. Thanks, Oak -Original Message- From: Zeng, Oak Sent: August 21, 2023 11:07 AM To: Dave Airlie Cc: Brost, Matthew ; Thomas Hellström ; Philip Yang ; Felix Kuehling ; dri-devel@lists.freedesktop.org; intel- x...

Re: [PATCH drm-misc-next 1/3] drm: drm_exec: build always builtin

2023-08-21 Thread Danilo Krummrich
On 8/21/23 11:49, Christian König wrote: Am 20.08.23 um 23:53 schrieb Danilo Krummrich: drm_exec must always be builtin for the DRM GPUVA manager to depend on it. You should probably go the other way around and not always build in the GPUVA manager. Yes, I think that's reasonable. Currently

Re: [PATCH v5 06/11] drm/radeon: Use RMW accessors for changing LNKCTL

2023-08-21 Thread Bjorn Helgaas
On Fri, Aug 18, 2023 at 04:12:57PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Ilpo Järvinen > > Sent: Monday, July 17, 2023 8:05 AM > > To: linux-...@vger.kernel.org; Bjorn Helgaas ; Lorenzo > > Pieralisi ; Rob Herring ; > > Krzysztof Wilczyński ; Emmanuel Grumbach >

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Danilo Krummrich
On 8/21/23 20:12, Christian König wrote: Am 21.08.23 um 20:01 schrieb Danilo Krummrich: On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't re

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-21 Thread Christian König
I'm not sure about that. On the one hand it might generate some noise. I know tons of cases where logic is: Ok if we see the updated value immediately it will optimize things, but if not it's unproblematic because there is another check after the next memory barrier. On the other hand we pro

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread Arunpravin Paneer Selvam
Hi Christian, I ran GLMark2, unigine heaven and Tomb Raider on steam. I didn't observe any issues. Regards, Arun. On 8/21/2023 4:33 PM, Christian König wrote: Am 20.08.23 um 11:51 schrieb Christophe JAILLET: This serie simplifies amdgpu_bo_list_create() and usage of the 'struct amdgpu_bo_li

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Christian König
Am 21.08.23 um 20:01 schrieb Danilo Krummrich: On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previousl

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Alex Deucher
On Mon, Aug 21, 2023 at 1:54 PM Yadav, Arvind wrote: > > > On 8/21/2023 9:52 PM, Alex Deucher wrote: > > On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: > >> This patch adds a function which will change the GPU > >> power profile based on a submitted job. This can optimize > >> the power perf

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 11:36 PM, Alex Deucher wrote: On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set an

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Alex Deucher
On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: > > This patch adds a function which will change the GPU > power profile based on a submitted job. This can optimize > the power performance when the workload is on. > > v2: > - Splitting workload_profile_set and workload_profile_put > into two

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Danilo Krummrich
On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your drive

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-21 Thread Robin Murphy
On 2023-08-14 12:18, Steven Price wrote: On 11/08/2023 20:26, Robin Murphy wrote: On 2023-08-11 17:56, Daniel Stone wrote: Hi, On 11/08/2023 17:35, Robin Murphy wrote: On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o FWIW I still think it would be nice to

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 9:52 PM, Alex Deucher wrote: On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and

Re: [PATCH 1/3] drm/buddy: Fix contiguous memory allocation issues

2023-08-21 Thread Matthew Auld
Hi, On 21/08/2023 11:14, Arunpravin Paneer Selvam wrote: The way now contiguous requests are implemented such that the size rounded up to power of 2 and the corresponding order block picked from the freelist. In addition to the older method, the new method will rounddown the size to power of 2

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread Bjorn Helgaas
On Fri, Aug 18, 2023 at 12:09:29PM +0800, suijingfeng wrote: > On 2023/8/18 06:08, Bjorn Helgaas wrote: > > On Wed, Aug 16, 2023 at 06:05:27AM +0800, Sui Jingfeng wrote: > > > Currently, the vga_is_firmware_default() function only works on x86 and > > > ia64, it is a no-op on ARM, ARM64, PPC, RISC-

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread Bjorn Helgaas
On Fri, Aug 18, 2023 at 09:48:46AM +0800, suijingfeng wrote: > On 2023/8/18 06:08, Bjorn Helgaas wrote: > > > + if (resource_type(res) != IORESOURCE_MEM) > > > + continue; > > > + > > > + if (!res->start || !res->end) > > > + continue; > > > + > > > +

Re: [PATCH v2 2/2] doc: uapi: Add document describing dma-buf semantics

2023-08-21 Thread Simon Ser
Pushed to drm-misc-next with minor edits. Thanks!

Re: [PATCH 5/6] dt-bindings: timer: add imx7d compatible

2023-08-21 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:50 +0200, Alexander Stein wrote: > Currently the dtbs_check for imx6ul generates warnings like this: > > ['fsl,imx7d-gpt', 'fsl,imx6sx-gpt'] is too long > > The driver has no special handling for fsl,imx7d-gpt, so fsl,imx6sx-gpt is > used. Therefore make imx7d GPT comp

Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

2023-08-21 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote: > MAC address can be provided by a nvmem-cell, thus allow referencing a > source for the address. Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names', > 'nvmem-cells' do not match any of the reg

Re: [PATCH 3/6] dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'

2023-08-21 Thread Rob Herring
On Thu, Aug 10, 2023 at 04:44:48PM +0200, Alexander Stein wrote: > Although defined in synopsys,dw-hdmi.yaml, they need to explicitly allowed > in fsl,imx6-hdmi.yaml. Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: hdmi@12: 'interrupts', > 'reg' do not match any of the regexes:

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-21 Thread Daniel Thompson
On Sun, Aug 20, 2023 at 11:41:18AM +0200, Julius Zint wrote: > The HID spec defines the following Usage IDs (p. 345 ff): > > - Monitor Page (0x80) -> Monitor Control (0x01) > - VESA Virtual Controls Page (0x82) -> Brightness (0x10) > > Apple made use of them in their Apple Studio Display and most l

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Alex Deucher
On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: > > This patch adds a function which will change the GPU > power profile based on a submitted job. This can optimize > the power performance when the workload is on. > > v2: > - Splitting workload_profile_set and workload_profile_put > into two

Re: [PATCH] gpu: drm: i915: fix documentation style

2023-08-21 Thread Jani Nikula
On Mon, 21 Aug 2023, "Ricardo B. Marliere" wrote: > This patch fixes the following sphinx warnings in the htmldocs make target: > > Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: > ERROR: Unexpected indentation. > Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/

Re: [PATCH v3 2/5] dt-bindings: display: tegra: nvidia,tegra20-dc: Add parallel RGB output port node

2023-08-21 Thread Rob Herring
On Mon, Aug 07, 2023 at 05:35:12PM +0300, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Either this node, which is optional, or the nvidia,panel property can be > present. > > Signed-off-by: Maxim Schwalm > Signed-off-by: Svyatoslav Ryhel > --- > .../display/tegra/nvidia,tegra20-dc.yaml

Re: [PATCH v2 05/15] drm/panthor: Add the GPU logical block

2023-08-21 Thread Robin Murphy
On 2023-08-14 11:54, Steven Price wrote: [...] +/** + * panthor_gpu_l2_power_on() - Power-on the L2-cache + * @ptdev: Device. + * + * Return: 0 on success, a negative error code otherwise. + */ +int panthor_gpu_l2_power_on(struct panthor_device *ptdev) +{ + u64 core_mask = U64_MAX; + +

Re: [PATCH 2/2] drm/panfrost: Add drm memory stats display through fdinfo

2023-08-21 Thread Steven Price
On 08/08/2023 23:22, Adrián Larumbe wrote: > For drm_show_memory_stats to produce a more accurate report, provide a new > Panfrost DRM object callback that decides whether an object is resident in > memory or eligible for purging. > > Signed-off-by: Adrián Larumbe > --- > drivers/gpu/drm/panfros

Re: [PATCH 1/2] drm/panfrost: Add fdinfo support to Panfrost

2023-08-21 Thread Steven Price
On 08/08/2023 23:22, Adrián Larumbe wrote: > We calculate the amount of time the GPU spends on a job with ktime samples, > and then add it to the cumulative total for the open DRM file, which is > what will be eventually exposed through the 'fdinfo' DRM file descriptor. > > Signed-off-by: Adrián L

Re: [PATCH 1/1] drm/fourcc: Add documentation about software color conversion.

2023-08-21 Thread Maxime Ripard
Hi Pekka, Thanks for answering On Fri, Aug 18, 2023 at 04:24:15PM +0300, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 09:45:27 +0200 > Maxime Ripard wrote: > > On Mon, Aug 07, 2023 at 03:45:15PM +0200, Jocelyn Falempe wrote: > > > After discussions on IRC, the consensus is that the DRM drivers sh

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
Accidently deleted Brian. Add back. Thanks, Oak > -Original Message- > From: Zeng, Oak > Sent: August 21, 2023 11:07 AM > To: Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; Vis

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Dave > Airlie > Sent: August 20, 2023 6:21 PM > To: Zeng, Oak > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; Welty, Brian ; dri- > de...@lists.freedesktop.org; intel...@lists.freedesktop.org; Vishwanathapura

Re: [PATCH] drm/panfrost: Skip speed binning on EOPNOTSUPP

2023-08-21 Thread Steven Price
On 16/08/2023 10:45, Steven Price wrote: > On 16/08/2023 02:42, David Michael wrote: >> Encountered on an ARM Mali-T760 MP4, attempting to read the nvmem >> variable can also return EOPNOTSUPP instead of ENOENT when speed >> binning is unsupported. >> >> Cc: >> Fixes: 7d690f936e9b ("drm/panfrost:

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:09 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Powe

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Jason Gunthorpe
On Mon, Aug 21, 2023 at 04:36:49PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 09:51:13AM -0300, Jason Gunthorpe wrote: > > So now that Joerg has dropped it - what is your big idea to make the > > locking actually work right? > > I am not opposed to the general idea. Well, I think Robin

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Joerg Roedel
On Mon, Aug 21, 2023 at 09:51:13AM -0300, Jason Gunthorpe wrote: > So now that Joerg has dropped it - what is your big idea to make the > locking actually work right? I am not opposed to the general idea. When putting it into the tree I wasn't aware how many users still need to be adapted to prope

Re: [PATCH v2] drm/doc: document DRM_IOCTL_MODE_CREATE_DUMB

2023-08-21 Thread Pekka Paalanen
On Mon, 21 Aug 2023 13:15:56 + Simon Ser wrote: > The main motivation is to repeat that dumb buffers should not be > abused for anything else than basic software rendering with KMS. > User-space devs are more likely to look at the IOCTL docs than to > actively search for the driver-oriented "

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-21 Thread Dmitry Baryshkov
On Fri, 18 Aug 2023 at 16:55, Pekka Paalanen wrote: > > On Fri, 18 Aug 2023 14:03:14 +0300 > Dmitry Baryshkov wrote: > > > On 18/08/2023 13:51, Pekka Paalanen wrote: > > > On Fri, 4 Aug 2023 16:59:00 +0300 > > > Dmitry Baryshkov wrote: > > > > > >> On Fri, 4 Aug 2023 at 16:44, Sebastian Wick >

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-21 Thread Mirsad Todorovac
Hi Christian, Thank you for the update. Should I continue reporting what KCSAN gives? I will try to filter these to save your time for evaluation ... Kind regards, Mirsad On 8/21/23 15:20, Christian König wrote: Hi Mirsad, well this is a false positive. That drm_sched_entity_is_ready() doe

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 16:12, Yadav, Arvind wrote: On 8/21/2023 7:24 PM, Shashank Sharma wrote: On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup funct

Re: [PATCH v5 5/5] drm/amdgpu: Create version number for coredumps

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Even if there's nothing currently parsing amdgpu's coredump files, if we eventually have such tools they will be glad to find a version field to properly read the file. Create a version number to be displayed on top of coredump file, to be incremented

Re: [PATCH v5 4/5] drm/amdgpu: Move coredump code to amdgpu_reset file

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Giving that we use codedump just for device resets, move it's functions and structs to a more semantic file, the amdgpu_reset.{c, h}. Signed-off-by: André Almeida --- v5: no change --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 --- drivers/gp

Re: [PATCH v5 3/5] drm/amdgpu: Encapsulate all device reset info

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: To better organize struct amdgpu_device, keep all reset information related fields together in a separated struct. Signed-off-by: André Almeida --- v5: new patch, as requested by Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34 +

Re: [PATCH v5 2/5] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Signed-off-by: André Almeida --- v5: no change v4

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:24 PM, Shashank Sharma wrote: On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splittin

Re: [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname()

2023-08-21 Thread Steven Price
On 03/08/2023 05:03, Ruan Jinjie wrote: > It is not possible for platform_get_irq_byname() to return 0. > Use the return value from platform_get_irq_byname(). > > Signed-off-by: Ruan Jinjie Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > drivers/gpu/drm/pan

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-21 Thread Andi Shyti
Hi Zhanjun, On Fri, Aug 11, 2023 at 11:20:11AM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed > work and intel_gt_reset. > When intel_gt_reset was called, task will hold a lock. > To cacel delayed work here, the _sync version will also acquire

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Christian König
Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your driver crash because you accidentally overwrite

Re: [PATCH v2 00/15] drm: Add a driver for FW-based Mali GPUs

2023-08-21 Thread Rob Herring
On Thu, Aug 10, 2023 at 10:44 AM Boris Brezillon wrote: > > Hello Rob, > > On Wed, 9 Aug 2023 14:22:59 -0600 > Rob Herring wrote: > > > On Wed, Aug 9, 2023 at 10:53 AM Boris Brezillon > > wrote: > > > > > > I tried to Cc anyone that was involved in any development of the code > > > I picked from

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new

Re: [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:16 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signe

Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:13 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koen

Re: [PATCH v2 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-21 Thread Shashank Sharma
Someone from MM should also confirm on this, but: Acked-by: Shashank Sharma On 21/08/2023 08:47, Arvind Yadav wrote: This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_workload_profile* api is added to switch on/off profile mode. These new api will a

Re: [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_am

Re: [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/a

Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yad

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Power profile once job finished. - Here, the *_work

Re: [PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-21 Thread Rob Herring
On Mon, Jul 17, 2023 at 3:17 AM Dmitry Osipenko wrote: > > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyssa,

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Chr

Re: [RFC][PATCH 0/2] drm/panic: Add a drm panic handler

2023-08-21 Thread Jocelyn Falempe
On 13/08/2023 04:20, nerdopolis wrote: On Wednesday, August 9, 2023 3:17:27 PM EDT Jocelyn Falempe wrote: This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when

Re: [PATCH v2 2/2] doc: uapi: Add document describing dma-buf semantics

2023-08-21 Thread Daniel Vetter
On Thu, Aug 03, 2023 at 04:47:29PM +0100, Daniel Stone wrote: > Since there's a lot of confusion around this, document both the rules > and the best practice around negotiating, allocating, importing, and > using buffers when crossing context/process/device/subsystem boundaries. > > This ties up a

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-21 Thread Christian König
Hi Mirsad, well this is a false positive. That drm_sched_entity_is_ready() doesn't see the data written by drm_sched_entity_push_job() is part of the logic here. Regards, Christian. Am 18.08.23 um 15:44 schrieb Mirsad Todorovac: On 8/17/23 21:54, Mirsad Todorovac wrote: Hi, This is your f

[PATCH v2] drm/doc: document DRM_IOCTL_MODE_CREATE_DUMB

2023-08-21 Thread Simon Ser
The main motivation is to repeat that dumb buffers should not be abused for anything else than basic software rendering with KMS. User-space devs are more likely to look at the IOCTL docs than to actively search for the driver-oriented "Dumb Buffer Objects" section. v2: reference DRM_CAP_DUMB_BUFF

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-21 Thread Christian König
Am 18.08.23 um 15:13 schrieb Matthew Brost: On Fri, Aug 18, 2023 at 07:27:33AM +0200, Christian König wrote: Am 17.08.23 um 19:54 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 03:39:40PM +0200, Christian König wrote: Am 11.08.23 um 04:31 schrieb Matthew Brost: Rather than call free_job and r

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches. - Add

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by:

Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-21 Thread Danilo Krummrich
On 8/21/23 10:30, Donald Robson wrote: Hi Danilo, Thanks for the feedback. On the subject of locking, I have dma_resv locking in another branch where I'm trying to enable bind queues, but I didn't think I needed locking for the single, synchronous operations seen here. Would a mutex on the gem

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread Shashank Sharma
+ Amar should be able to help. Amar, Can you please check this patch (series if required) with a few IGTs and probably with Xonotic as well ? Regards Shashank On 21/08/2023 13:03, Christian König wrote: Am 20.08.23 um 11:51 schrieb Christophe JAILLET: This serie simplifies amdgpu_bo_list

  1   2   >