On Fri, Aug 18, 2023 at 04:12:57PM +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Ilpo Järvinen <ilpo.jarvi...@linux.intel.com>
> > Sent: Monday, July 17, 2023 8:05 AM
> > To: linux-...@vger.kernel.org; Bjorn Helgaas <bhelg...@google.com>; Lorenzo
> > Pieralisi <lorenzo.pieral...@arm.com>; Rob Herring <r...@kernel.org>;
> > Krzysztof Wilczyński <k...@linux.com>; Emmanuel Grumbach
> > <emmanuel.grumb...@intel.com>; Rafael J . Wysocki <raf...@kernel.org>;
> > Heiner Kallweit <hkallwe...@gmail.com>; Lukas Wunner <lu...@wunner.de>;
> > Andy Shevchenko <andriy.shevche...@linux.intel.com>; Deucher, Alexander
> > <alexander.deuc...@amd.com>; Koenig, Christian
> > <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David
> > Airlie <airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; amd-
> > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-
> > ker...@vger.kernel.org
> > Cc: Dean Luick <dean.lu...@cornelisnetworks.com>; Jonas Dreßler
> > <ver...@v0yd.nl>; Ilpo Järvinen <ilpo.jarvi...@linux.intel.com>;
> > sta...@vger.kernel.org
> > Subject: [PATCH v5 06/11] drm/radeon: Use RMW accessors for changing
> > LNKCTL
> >
> > Don't assume that only the driver would be accessing LNKCTL. ASPM policy
> > changes can trigger write to LNKCTL outside of driver's control.
> > And in the case of upstream bridge, the driver does not even own the device
> > it's changing the registers for.
> >
> > Use RMW capability accessors which do proper locking to avoid losing
> > concurrent updates to the register value.
> >
> > Fixes: 8a7cd27679d0 ("drm/radeon/cik: add support for pcie gen1/2/3
> > switching")
> > Fixes: b9d305dfb66c ("drm/radeon: implement pcie gen2/3 support for SI")
> > Suggested-by: Lukas Wunner <lu...@wunner.de>
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvi...@linux.intel.com>
> > Cc: sta...@vger.kernel.org
>
> For this and the amdgpu patch:
> Acked-by: Alex Deucher <alexander.deuc...@amd.com>
> I'm not sure if this is stable material however. Is there some issue today?
Added your ack, thanks! I dropped the stable tag on the whole series.
Bjorn
