Re: [RFT][PATCH v1 6/6] vfio: Replace phys_pfn with phys_page for vfio_pin_pages()

2022-06-17 Thread Nicolin Chen
On Fri, Jun 17, 2022 at 01:54:05AM -0700, Christoph Hellwig wrote: > There is a bunch of code an comments in the iommu type1 code that > suggest we can pin memory that is not page backed. Would you mind explaining the use case for pinning memory that isn't page backed? And do we have such use ca

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy

2022-06-17 Thread Nicolin Chen
On Fri, Jun 17, 2022 at 01:44:30AM -0700, Christoph Hellwig wrote: > On Thu, Jun 16, 2022 at 04:52:11PM -0700, Nicolin Chen wrote: > > The pinned PFN list returned from vfio_pin_pages() is simply converted > > using page_to_pfn() without protection, so direct access via memcpy() > > will crash on S

Re: [RFT][PATCH v1 3/6] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-06-17 Thread Nicolin Chen
On Fri, Jun 17, 2022 at 01:42:42AM -0700, Christoph Hellwig wrote: > On Thu, Jun 16, 2022 at 04:52:09PM -0700, Nicolin Chen wrote: > > + ret = vfio_unpin_pages(&vgpu->vfio_device, gfn << PAGE_SHIFT, npage); > > + drm_WARN_ON(&i915->drm, ret != npage); > > The shifting of gfn seems to happen bo

[PATCH] dt-bindings: display: delete ilitek,ili9341.txt

2022-06-17 Thread Conor Dooley
From: Conor Dooley ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt binding was not deleted. Do so. Signed-off-by: Conor Dooley --- .../bindings/display/ilitek,ili9341.txt | 27 --- 1 file changed, 27 deletions(-) delete mode 100644 Documentation/device

Re: [PATCH] drm/amd/display: Remove unused variable 'abo'

2022-06-17 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH] video: fbdev: Fix refcount leak bug in valkyriefb.c

2022-06-17 Thread Liang He
In valkyriefb_init(), of_find_node_by_name() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He --- drivers/video/fbdev/valkyriefb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

[PATCH] drm/amd/display: Remove unused variable 'abo'

2022-06-17 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9143:27: warning: variable 'abo' set but not used [-Wunused-but-set-variable] Remove the unused variable. Reported-by: Kernel test robot Signed-off-by: Souptick

[PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state()

2022-06-17 Thread Brian Norris
It's possible for users to try to duplicate the CRTC state even when the state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other users of __drm_atomic_helper_crtc_duplicate_state()) already guard this with a WARN_ON() instead of crashing, so let's do that here too. Signed-off-by:

[PATCH v6 4/4] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Dmitry Baryshkov
The array of CRTC in the struct msm_drm_private duplicates a list of CRTCs in the drm_device. Drop it and use the existing list for CRTC enumeration. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/disp/mdp

[PATCH v6 3/4] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v6 1/4] drm/msm: clean event_thread->worker in case of an error

2022-06-17 Thread Dmitry Baryshkov
If worker creation fails, nullify the event_thread->worker, so that msm_drm_uninit() doesn't try accessing invalid memory location. While we are at it, remove duplicate assignment to the ret variable. Fixes: 1041dee2178f ("drm/msm: use kthread_create_worker instead of kthread_run") Signed-off-by:

[PATCH v6 2/4] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v6 0/4] drm/msm: convet to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
This patchseries replaces drm_handle_vblank() with drm_crtc_handle_vblank(). As a bonus result of this conversion it is possible to drop the stored array of allocated CRTCs and use the core CRTC iterators. Changes since v5: - Clean up the event_thread->worker in case of an error to fix possible

Re: [Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-06-17 Thread Lucas De Marchi
On Thu, Apr 14, 2022 at 11:19:23AM -0700, Michael Cheng wrote: Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. humn... and now we know it is backed by struct p

Re: [PATCH] dt-bindings: display: delete ilitek,ili9341.txt

2022-06-17 Thread Rob Herring
On Fri, Jun 17, 2022 at 10:37:07PM +0100, Conor Dooley wrote: > From: Conor Dooley > > ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt panel/ilitek,ili9341.yaml > binding was not deleted. Do so. > > Signed-off-by: Conor Dooley > --- > .../bindings/display/ilitek,ili9341.t

[PATCH v2 3/3] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

2022-06-17 Thread Dmitry Baryshkov
Remove unused dp_display_en/disable prototypes. While we are at it, remove extra 'data' argument that is unused. Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Rebased and dropped the dp_display_enable() chunk --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +++-- 1 file changed, 3 inse

[PATCH v2 2/3] drm/msm/dp: rename second dp_display_enable()'s argument

2022-06-17 Thread Dmitry Baryshkov
To follow up recent changes, rename (and change type of) second dp_display_enable()'s argument from generic u32 data to bool force_link_train, which is later passed to dp_ctrl_on_stream(). Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Added patch --- drivers/gpu/drm/msm/dp/dp_display.

[PATCH v2 1/3] drm/msm/dp: remove unused stubs

2022-06-17 Thread Dmitry Baryshkov
Refactoring DP code transformed several functions into empty stubs. Remove them. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 35 - 1 file changed, 35 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.

Re: [PATCH v2 2/2] vfio: Replace the iommu notifier with a device list

2022-06-17 Thread Alex Williamson
On Tue, 7 Jun 2022 20:02:12 -0300 Jason Gunthorpe wrote: > Instead of bouncing the function call to the driver op through a blocking > notifier just have the iommu layer call it directly. > > Register each device that is being attached to the iommu with the lower > driver which then threads the

Re: [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight

2022-06-17 Thread Krzysztof Kozlowski
On 17/06/2022 03:35, ChiaEn Wu wrote: > +- 3: 6 >> >> Nope, I said last time: >> "In any case you cannot have values mapping" >> >> Please use proper real world value, not some register bits. The property >> name also needs fixing. > > I so apologized for misunderstanding your meaning... >

Re: [PATCH v2 02/15] dt-bindings: power: supply: Add Mediatek MT6370 Charger

2022-06-17 Thread Krzysztof Kozlowski
On 17/06/2022 03:19, ChiaEn Wu wrote: > Hi Krzysztof, > > Thanks for your helpful comments! I have so some questions want to ask > you below. > > Krzysztof Kozlowski 於 2022年6月17日 週五 清晨5:05寫道: >> >> On 13/06/2022 04:11, ChiaEn Wu wrote: >>> From: ChiaEn Wu >>> >>> Add Mediatek MT6370 Charger bin

Re: [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-17 Thread Dmitry Baryshkov
On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_m

[PATCH v2 2/2] drm/i915/gt: Re-do the intel-gtt split

2022-06-17 Thread Lucas De Marchi
Re-do what was attempted in commit 7a5c922377b4 ("drm/i915/gt: Split intel-gtt functions by arch"). The goal of that commit was to split the handlers for older hardware that depend on intel-gtt.ko so i915 can be built for non-x86 archs, after some more patches. Other archs do not need intel-gtt.ko.

[PATCH v2 1/2] agp/intel: Rename intel-gtt symbols

2022-06-17 Thread Lucas De Marchi
Exporting the symbols like intel_gtt_* creates some confusion inside i915 that has symbols named similarly. In an attempt to isolate platforms needing intel-gtt.ko, commit 7a5c922377b4 ("drm/i915/gt: Split intel-gtt functions by arch") moved way too much inside gt/intel_gt_gmch.c, even the function

Re: [PATCH 02/10] drm: selftest: refactor drm_cmdline_parser

2022-06-17 Thread Shuah Khan
On 6/15/22 7:58 AM, Maíra Canal wrote: From: Arthur Grillo Refactor the tests by modularizing the functions to avoid code repetition. Tell me more about the refactor and how does it help. This patch seems to combine refactor with some other formatting changes that aren't necessary and making

Re: [PATCH 1/3] drm/msm/dp: Reorganize code to avoid forward declaration

2022-06-17 Thread Dmitry Baryshkov
On 17/06/2022 23:47, Stephen Boyd wrote: Let's move these functions around to avoid having to forward declare dp_ctrl_on_stream_phy_test_report(). Also remove dp_ctrl_reinitialize_mainlink() forward declaration because we're doing that sort of task. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd

Re: [PATCH v2 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-06-17 Thread Alex Williamson
On Fri, 17 Jun 2022 16:42:30 -0600 Alex Williamson wrote: > On Tue, 7 Jun 2022 20:02:11 -0300 > Jason Gunthorpe wrote: > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > > index 61e71c1154be67..f005b644ab9e69 100644 > > --- a/drivers/vfio/vfio.c > > +++ b/drivers/vfio/vfio.c > > @@ -1

Re: [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370

2022-06-17 Thread Rob Herring
On Fri, Jun 17, 2022 at 07:15:49PM +0800, ChiaEn Wu wrote: > Hi Rob, > > Rob Herring 於 2022年6月13日 週一 晚上9:33寫道: > > > > On Mon, 13 Jun 2022 19:11:37 +0800, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > > > Add Mediatek MT6370 binding documentation. > > > > > > Signed-off-by: ChiYuan Huang >

Re: [PATCH v2 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-06-17 Thread Alex Williamson
On Tue, 7 Jun 2022 20:02:11 -0300 Jason Gunthorpe wrote: > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index 61e71c1154be67..f005b644ab9e69 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -1077,8 +1077,20 @@ static void vfio_device_unassign_container(struct > vfi

[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 --- Comment #4 from Erhard F. (erhar...@mailbox.org) --- Ok, seems to be commit 94f4c4965e5513ba624488f4b601d6b385635aec drm/amdgpu: partial revert "remove ctx->lock" v2 specifically. Reverting it on top of v5.19-rc2 gives me working X again

[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 --- Comment #3 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301199 --> https://bugzilla.kernel.org/attachment.cgi?id=301199&action=edit bisect.log -- You may reply to this email to add a comment. You are receiving this mail be

[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 --- Comment #2 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301198 --> https://bugzilla.kernel.org/attachment.cgi?id=301198&action=edit Xorg.0.log -- You may reply to this email to add a comment. You are receiving this mail be

[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 --- Comment #1 from Erhard F. (erhar...@mailbox.org) --- Created attachment 301197 --> https://bugzilla.kernel.org/attachment.cgi?id=301197&action=edit kernel .config (kernel 5.19-rc2, AMD Ryzen 9 5950X) -- You may reply to this email to add a

[Bug 216143] New: [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

2022-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216143 Bug ID: 216143 Summary: [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Re-do the intel-gtt split

2022-06-17 Thread Lucas De Marchi
On Fri, Jun 17, 2022 at 12:15:51PM -0700, Matt Roper wrote: On Thu, Jun 16, 2022 at 03:49:43PM -0700, Lucas De Marchi wrote: Re-do what was attempted in commit 7a5c922377b4 ("drm/i915/gt: Split intel-gtt functions by arch"). The goal of that commit was to split the handlers for older hardware th

[PATCH] drm/i915: Add global forcewake request to drpc

2022-06-17 Thread Vinay Belgaumkar
We have seen multiple RC6 issues where it is useful to know which global forcewake bits are set. Add this to the 'drpc' debugfs output. v2: Review comments (Ashutosh) Reviewed-by: Ashutosh Dixit Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 8 ++-- 1 f

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-17 Thread David Hildenbrand
On 17.06.22 21:27, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/17/2022 12:33 PM, David Hildenbrand wrote: >> On 17.06.22 19:20, Sierra Guiza, Alejandro (Alex) wrote: >>> On 6/17/2022 4:40 AM, David Hildenbrand wrote: On 31.05.22 22:00, Alex Sierra wrote: > Device memory that is cache c

Re: [PATCH] drm/i915: Add global forcewake status to drpc

2022-06-17 Thread Belgaumkar, Vinay
On 6/17/2022 1:53 PM, Dixit, Ashutosh wrote: On Fri, 17 Jun 2022 13:25:34 -0700, Vinay Belgaumkar wrote: We have seen multiple RC6 issues where it is useful to know which global forcewake bits are set. Add this to the 'drpc' debugfs output. A couple of optional nits below to look at but other

Re: [PATCH] drm/i915: Add global forcewake status to drpc

2022-06-17 Thread Dixit, Ashutosh
On Fri, 17 Jun 2022 13:25:34 -0700, Vinay Belgaumkar wrote: > > We have seen multiple RC6 issues where it is useful to know > which global forcewake bits are set. Add this to the 'drpc' > debugfs output. A couple of optional nits below to look at but otherwise this is: Reviewed-by: Ashutosh Dixit

Re: [PATCH v5 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Dmitry Baryshkov
On Fri, 17 Jun 2022 at 23:52, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-17 12:14:29) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > index 44485363f37a..567e77dae43b 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.c > > +++ b/drivers/gpu/drm/msm/msm_

Re: [PATCH 3/3] arm64: dts: qcom: msm8996: add #clock-cells to the HDMI PHY node

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 03:36:08) > Add #clock-cells property to the HDMI PHY device node to let other nodes > resolve the hdmipll clock. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/3] drm/msm/hdmi: make hdmi_phy_8996 OF clk provider

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 03:36:07) > On MSM8996 the HDMI PHY provides the PLL clock to the MMCC. As we are > preparing to convert the MSM8996 to use DT clocks properties (rather > than global clock names), register the OF clock provider. > > Signed-off-by: Dmitry Baryshkov > --- Revie

Re: [PATCH] drm/msm/hdmi: support attaching the "next" bridge

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-16 01:50:57) > There might be a chain of bridges attached to the HDMI node > (including but not limited to the display-connector bridge). Add support > for attaching them right to the HDMI bridge chain. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Steph

Re: [PATCH] drm/msm/hdmi: drop empty bridge callbacks

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-16 01:50:54) > Drop empty callbacks msm_hdmi_bridge_enable() and > msm_hdmi_bridge_disable(). > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:29) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 44485363f37a..567e77dae43b 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -427,20 +428,23 @@ static int msm_drm_init(struct de

Re: [PATCH v5 2/3] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:28) > Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() > instead. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:14:27) > Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() > instead. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH 3/3] drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report()

2022-06-17 Thread Stephen Boyd
This API isn't really more than a couple lines now that we don't store the pixel_rate to the struct member. Inline it into the caller. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 40 1 file changed, 15 insertions(+), 25 de

[PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-17 Thread Stephen Boyd
This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_maintenance() was storing the pixel_rate but

[PATCH 1/3] drm/msm/dp: Reorganize code to avoid forward declaration

2022-06-17 Thread Stephen Boyd
Let's move these functions around to avoid having to forward declare dp_ctrl_on_stream_phy_test_report(). Also remove dp_ctrl_reinitialize_mainlink() forward declaration because we're doing that sort of task. Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 10

[PATCH 0/3] drm/msm/dp: More cleanups for force link train

2022-06-17 Thread Stephen Boyd
These patches do a little cleanup on the v9 patch from Kuogee. Stephen Boyd (3): drm/msm/dp: Reorganize code to avoid forward declaration drm/msm/dp: Remove pixel_rate from struct dp_ctrl drm/msm/dp: Get rid of dp_ctrl_on_stream_phy_test_report() drivers/gpu/drm/msm/dp/dp_ctrl.c | 145

Re: [PATCH 2/2] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

2022-06-17 Thread Dmitry Baryshkov
On 17/06/2022 23:15, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 12:49:21) Remove unused dp_display_en/disable prototypes. While we are at it, remove extra 'data' argument that is unused. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 13 +

[PATCH] drm/i915: Add global forcewake status to drpc

2022-06-17 Thread Vinay Belgaumkar
We have seen multiple RC6 issues where it is useful to know which global forcewake bits are set. Add this to the 'drpc' debugfs output. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --g

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-17 Thread Maíra Canal
On 6/17/22 04:55, David Gow wrote: > On Fri, Jun 17, 2022 at 6:41 AM Maíra Canal wrote: >> >> Hi David, >> >> Thank you for your feedback! >> >> On 6/16/22 11:39, David Gow wrote: >>> On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote: >> As kunit_test_suites() defines itself as an init_m

Re: [PATCH 1/2] drm/msm/dp: remove unused stubs

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:49:20) > Refactoring DP code transformed several functions into empty stubs. > Remove them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/2] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

2022-06-17 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 12:49:21) > Remove unused dp_display_en/disable prototypes. While we are at it, > remove extra 'data' argument that is unused. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 + > 1 file changed, 5 insertions(+)

[PATCH 2/2] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

2022-06-17 Thread Dmitry Baryshkov
Remove unused dp_display_en/disable prototypes. While we are at it, remove extra 'data' argument that is unused. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_dis

[PATCH 1/2] drm/msm/dp: remove unused stubs

2022-06-17 Thread Dmitry Baryshkov
Refactoring DP code transformed several functions into empty stubs. Remove them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 35 - 1 file changed, 35 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-17 Thread Sierra Guiza, Alejandro (Alex)
On 6/17/2022 12:33 PM, David Hildenbrand wrote: On 17.06.22 19:20, Sierra Guiza, Alejandro (Alex) wrote: On 6/17/2022 4:40 AM, David Hildenbrand wrote: On 31.05.22 22:00, Alex Sierra wrote: Device memory that is cache coherent from device and CPU point of view. This is used on platforms that

Re: [PATCH 2/2] drm/i915/gt: Re-do the intel-gtt split

2022-06-17 Thread Matt Roper
On Thu, Jun 16, 2022 at 03:49:43PM -0700, Lucas De Marchi wrote: > Re-do what was attempted in commit 7a5c922377b4 ("drm/i915/gt: Split > intel-gtt functions by arch"). The goal of that commit was to split the > handlers for older hardware that depend on intel-gtt.ko so i915 can > be built for non-

[PATCH v5 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Dmitry Baryshkov
The array of CRTC in the struct msm_drm_private duplicates a list of CRTCs in the drm_device. Drop it and use the existing list for CRTC enumeration. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/disp/mdp

[PATCH v5 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp

[PATCH v5 2/3] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp

[PATCH v5 0/3] drm/msm: convet to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
This patchseries replaces drm_handle_vblank() with drm_crtc_handle_vblank(). As a bonus result of this conversion it is possible to drop the stored array of allocated CRTCs and use the core CRTC iterators. Changes since v4: - Removed the duplicate word 'duplicate' from the last patch'es commit

Re: [PATCH v2] dt-bindings: display: Add Arm virtual platforms display

2022-06-17 Thread Rob Herring
On Mon, 13 Jun 2022 08:57:09 -0600, Rob Herring wrote: > 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP). > The binding has been in use for a long time, but was never documented. > > Some users and an example have a 'panel-dpi' compatible, but that's not > needed without a

[PATCH v6 08/10] drm/i915: allow memory region creators to alloc and free the region

2022-06-17 Thread Robert Beckett
add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15 insertions(+),

[PATCH v6 06/10] drm/i915: sanitize mem_flags for stolen buffers

2022-06-17 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by: Robert

[PATCH v6 07/10] drm/i915: ttm move/clear logic fix

2022-06-17 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[PATCH v6 09/10] drm/i915/ttm: add buffer pin on alloc flag

2022-06-17 Thread Robert Beckett
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback op

[PATCH v6 10/10] drm/i915: stolen memory use ttm backend

2022-06-17 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[PATCH v6 05/10] drm/i915: instantiate ttm ranger manager for stolen memory

2022-06-17 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++

[PATCH v6 02/10] drm/i915: limit ttm to dma32 for i965G[M]

2022-06-17 Thread Robert Beckett
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915

[PATCH v6 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

2022-06-17 Thread Robert Beckett
During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftest

[PATCH v6 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-06-17 Thread Robert Beckett
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-of

[PATCH v6 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-06-17 Thread Robert Beckett
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after

[PATCH v6 00/10] drm/i915: ttm for stolen

2022-06-17 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

Re: [PATCH] drm/msm/dpu: limit wb modes based on max_mixer_width

2022-06-17 Thread Dmitry Baryshkov
On 16/06/2022 22:26, Abhinav Kumar wrote: As explained in [1], using max_linewidth to limit the modes does not seem to remove 4K modes on chipsets such as sm8250 where the max_linewidth actually supports 4k. This would have been alright if dual SSPP support was present but otherwise fails the pe

[PATCH v4 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Dmitry Baryshkov
Handling the array of CRTC duplicate the struct msm_drm_private duplicates a list of CRTCs in the drm_device. Drop it and use the existing list for CRTC enumeration. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/

[PATCH v4 2/3] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp

[PATCH v4 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp

[PATCH v4 0/3] drm/msm: convet to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
This patchseries replaces drm_handle_vblank() with drm_crtc_handle_vblank(). As a bonus result of this conversion it is possible to drop the stored array of allocated CRTCs and use the core CRTC iterators. Changes since v3: - In msm_drm_init simplify the code by using an interim var for the ev

[PATCH v3 2/3] drm/msm/mdp5: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp

[PATCH v3 3/3] drm/msm: stop storing the array of CRTCs in struct msm_drm_private

2022-06-17 Thread Dmitry Baryshkov
Handling the array of CRTC duplicate the struct msm_drm_private duplicates a list of CRTCs in the drm_device. Drop it and use the existing list for CRTC enumeration. Reported-by: kernel test robot Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/

[PATCH v3 1/3] drm/msm/mdp4: convert to drm_crtc_handle_vblank()

2022-06-17 Thread Dmitry Baryshkov
Stop using deprecated drm_handle_vblank(), use drm_crtc_handle_vblank() instead. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp

Re: [PATCH v2 2/2] drm/i915/gt: Cleanup interface for MCR operations

2022-06-17 Thread Harish Chegondi
On Tue, Jun 14, 2022 at 05:10:19PM -0700, Matt Roper wrote: > Let's replace the assortment of intel_gt_* and intel_uncore_* functions > that operate on MCR registers with a cleaner set of interfaces: > > * intel_gt_mcr_read -- unicast read from specific instance > * intel_gt_mcr_read_any[_fw]

Re: [PATCH v8 2/2] drm/msm/dp: clean up pixel_rate from dp_ctrl.c

2022-06-17 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Kuogee-Hsieh/force-link-training-for-display-resolution-change/20220617-00 b

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-17 Thread David Hildenbrand
On 17.06.22 19:20, Sierra Guiza, Alejandro (Alex) wrote: > > On 6/17/2022 4:40 AM, David Hildenbrand wrote: >> On 31.05.22 22:00, Alex Sierra wrote: >>> Device memory that is cache coherent from device and CPU point of view. >>> This is used on platforms that have an advanced system bus (like CAPI

Re: [PATCH v5 01/13] mm: add zone device coherent type memory support

2022-06-17 Thread Sierra Guiza, Alejandro (Alex)
On 6/17/2022 4:40 AM, David Hildenbrand wrote: On 31.05.22 22:00, Alex Sierra wrote: Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. Howe

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

2022-06-17 Thread ChiaEn Wu
Hi Lee, Thanks for your helpful comments, we have some questions and replies below. Lee Jones 於 2022年6月16日 週四 清晨6:49寫道: > > On Mon, 13 Jun 2022, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add Mediatek MT6370 MFD support. > > > > Signed-off-by: ChiYuan Huang > > --- > > drivers/mfd/Kc

Re: [Intel-gfx] [PATCH 1/2] iosys-map: Add per-word read

2022-06-17 Thread Lucas De Marchi
On Fri, Jun 17, 2022 at 01:52:03AM -0700, Lucas De Marchi wrote: Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them po

[PATCH v4] drm/i915: Improve on suspend / resume time with VT-d enabled

2022-06-17 Thread Thomas Hellström
When DMAR / VT-d is enabled, the display engine uses overfetching, presumably to deal with the increased latency. To avoid display engine errors and DMAR faults, as a workaround the GGTT is populated with scatch PTEs when VT-d is enabled. However starting with gen10, Write-combined writing of scrat

Re: [PATCH v2 8/9] drm/i915/xehpsdv: Store lmem region in gt

2022-06-17 Thread Andi Shyti
Hi, On Thu, Jun 16, 2022 at 05:31:05PM +0530, Anshuman Gupta wrote: > From: Tvrtko Ursulin > > Store a pointer to respective local memory region in intel_gt so it can be > used when memory local to a GT needs to be allocated. > > Cc: Andi Shyti > Signed-off-by: Tvrtko Ursulin > Signed-off-by:

Re: [Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

2022-06-17 Thread Thomas Hellström
On 5/25/22 20:43, Matthew Auld wrote: With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jorda

Re: [Intel-gfx] [PATCH 04/10] drm/i915: remove intel_memory_region avail

2022-06-17 Thread Thomas Hellström
On 5/25/22 20:43, Matthew Auld wrote: No longer used. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm/i915/intel_memory_regi

Re: [PATCH v2 2/2] drm/i915/gt: Cleanup interface for MCR operations

2022-06-17 Thread Matt Roper
On Fri, Jun 17, 2022 at 06:57:20AM -0700, Harish Chegondi wrote: > On Tue, Jun 14, 2022 at 05:10:19PM -0700, Matt Roper wrote: > > Let's replace the assortment of intel_gt_* and intel_uncore_* functions > > that operate on MCR registers with a cleaner set of interfaces: > > > > * intel_gt_mcr_re

Re: [Intel-gfx] [PATCH 06/10] drm/i915/uapi: add NEEDS_CPU_ACCESS hint

2022-06-17 Thread Intel
On 5/25/22 20:43, Matthew Auld wrote: If set, force the allocation to be placed in the mappable portion of I915_MEMORY_CLASS_DEVICE. One big restriction here is that system memory (i.e I915_MEMORY_CLASS_SYSTEM) must be given as a potential placement for the object, that way we can always spill

Re: [Intel-gfx] [PATCH 07/10] drm/i915/error: skip non-mappable pages

2022-06-17 Thread Intel
On 5/25/22 20:43, Matthew Auld wrote: Skip capturing any lmem pages that can't be copied using the CPU. This in now only best effort on platforms that have small BAR. Testcase: igt@gem-exec-capture@capture-invisible Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc:

Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

2022-06-17 Thread Hsin-Yi Wang
nd > > in drm-misc. With this series applied, we can add this patch to give > > the correct default orientation for mt8183 kukui devices. > > I didn't send this patch again with the series, since they might land > > in different trees. > > > > I had a look o

Re: [PATCH] drm/aperture: Run fbdev removal before internal helpers

2022-06-17 Thread Alex Williamson
On Fri, 17 Jun 2022 14:41:01 +0200 Thomas Zimmermann wrote: > Hi > > Am 17.06.22 um 14:29 schrieb Javier Martinez Canillas: > > [adding Zack and Alex to Cc list] > > > > Hello Thomas, > > > > Thanks a lot for tracking this down and figuring out the root cause! > > > > On 6/17/22 14:10, Thomas

Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

2022-06-17 Thread Matthias Brugger
trees. I had a look on Linux next (next-20220617) and wasn't able to find the mtk_dsi.c changes. What is the status of this? Regards, Matthias Thanks. arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/

  1   2   >