[PATCH 1/3] drm/i915/guc: Do error capture asynchronously

2021-10-22 Thread Matthew Brost
An error capture allocates memory, memory allocations depend on resets, and resets need to flush the G2H handlers to seal several races. If the error capture is done from the G2H handler this creates a circular dependency. To work around this, do a error capture in a work queue asynchronously from

[PATCH 2/3] drm/i915/guc: Flush G2H work queue during reset

2021-10-22 Thread Matthew Brost
It isn't safe to scrub for missing G2H or continue with the reset until all G2H processing is complete. Flush the G2H work queue during reset to ensure it is done running. No need to call the IRQ handler directly either as the scrubbing code can deal with any missing G2H. Signed-off-by: Matthew Br

[PATCH 0/3] Do error capture async, flush G2H processing on reset

2021-10-22 Thread Matthew Brost
Rather allocating an error capture in nowait context to break a lockdep splat [1], do the error capture async compared to the G2H processing. v2: Fix Docs warning v3: Rebase, resend for CI v4: Resend for CI Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/patch/451415/?series=

[PATCH 3/3] drm/i915/guc: Refcount context during error capture

2021-10-22 Thread Matthew Brost
From: John Harrison When i915 receives a context reset notification from GuC, it triggers an error capture before resetting any outstanding requsts of that context. Unfortunately, the error capture is not a time bound operation. In certain situations it can take a long time, particularly when mul

Re: [PATCH v5 2/7] dt-bindings: mediatek, dp: Add Display Port binding

2021-10-22 Thread Rob Herring
On Thu, 21 Oct 2021 11:27:02 +0200, Markus Schneider-Pargmann wrote: > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The controller can have two forms, as a n

Re: [PATCH 1/5] xen: add "not_essential" flag to struct xenbus_driver

2021-10-22 Thread Andrew Cooper
On 22/10/2021 07:47, Juergen Gross wrote: > When booting the xenbus driver will wait for PV devices to have > connected to their backends before continuing. The timeout is different > between essential and non-essential devices. > > Non-essential devices are identified by their nodenames directly i

Re: [Freedreno] [PATCH v3 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once

Re: [PATCH 03/13] drm: add Makefile support for drm buddy

2021-10-22 Thread Arunpravin
On 20/10/21 1:51 pm, Thomas Zimmermann wrote: > Hi > > Am 20.10.21 um 00:53 schrieb Arunpravin: >> - Include drm buddy to DRM root Makefile >> - Add drm buddy init and exit function calls >>to drm core > > Is there a hard requirement to have this code in the core? > > IMHO there's already

Re: [Freedreno] [PATCH v3 09/14] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul A couple more useless checks to remove in dpu_encoder. Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run #v1 Link:

Re: [Freedreno] [PATCH v3 03/14] drm/hdcp: Update property value on content type and user changes

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch updates the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new c

Re: [Freedreno] [PATCH v3 01/14] drm/hdcp: Add drm_hdcp_atomic_check()

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul This patch moves the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Signed-off-by: Sean Paul For the drm/hdcp pieces

Re: [PATCH v3 10/14] drm/msm/dpu: Remove encoder->enable() hack

2021-10-22 Thread abhinavk
On 2021-10-01 08:11, Sean Paul wrote: From: Sean Paul encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer.

Re: linux-next: Tree for Oct 22 (drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c)

2021-10-22 Thread Randy Dunlap
On 10/22/21 2:15 AM, Stephen Rothwell wrote: Hi all, Changes since 20211021: on x86_64: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c: In function ‘i915_gem_object_get_pages_dmabuf’: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function ‘wbinvd_on_all

Re: [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal

2021-10-22 Thread Marek Vasut
On 10/21/21 9:39 AM, Maxime Ripard wrote: Commit 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach callback") moved the unregistration of the bridge DSI device and bridge itself to the detach callback. While this is correct for the DSI device detach and unregistration, the bridge is add

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, On Fri, Oct 22, 2021 at 09:32:08PM +0200, Sam Ravnborg wrote: > On Fri, Oct 22, 2021 at 09:42:37PM +0300, Laurent Pinchart wrote: > > On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > > > Hi Laurent, > > > > > > > From a quick look only cadence/cdns-mhdp8546 subclass > > > >

Re: [PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-22 Thread Navare, Manasi
Hi Ville, Could you take a look at this, this addresses teh review comments from prev version Manasi On Mon, Oct 04, 2021 at 04:59:13AM -0700, Manasi Navare wrote: > In case of a modeset where a mode gets split across mutiple CRTCs > in the driver specific implementation (bigjoiner in i915) w

Re: [PATCH v2 3/7] drm/bridge: Add drm_atomic_get_new_crtc_for_bridge() helper

2021-10-22 Thread Sam Ravnborg
Hi Maxime, On Fri, Oct 22, 2021 at 01:03:55PM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Oct 20, 2021 at 08:18:57PM +0200, Sam Ravnborg wrote: > > drm_atomic_get_new_crtc_for_bridge() will be used by bridge > > drivers to provide easy access to the mode from the > > drm_bridge_funcs operations

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, On Fri, Oct 22, 2021 at 09:42:37PM +0300, Laurent Pinchart wrote: > Hi Sam, > > On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > > Hi Laurent, > > > > > From a quick look only cadence/cdns-mhdp8546 subclass > > > drm_bridge_state and I wonder if the right thing to do w

Re: Revert "arm64: dts: qcom: sm8250: remove bus clock from the mdss node for sm8250 target"

2021-10-22 Thread Amit Pundir
On Fri, 15 Oct 2021 at 02:53, Dmitry Baryshkov wrote: > > On Thu, 14 Oct 2021 at 19:54, Vladimir Zapolskiy > wrote: > > > > Hi Dmitry, > > > > On 10/14/21 4:54 PM, Dmitry Baryshkov wrote: > > > From: Amit Pundir > > > > > > This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4. > > > > >

Re: [PATCH 2/2] drm/msm/dpu: Remove dynamic allocation from atomic context

2021-10-22 Thread Jessica Zhang
On 10/22/2021 10:20 AM, Rob Clark wrote: From: Rob Clark We know the upper bound on # of mixers (ie. two), so lets just allocate this on the stack. Fixes: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:201 in_atomic(): 1, irqs_disabled(): 128, non_bloc

Re: [PATCH 1/2] drm/msm/dpu: Remove impossible NULL check

2021-10-22 Thread Jessica Zhang
On 10/22/2021 10:20 AM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 04:40:40PM +0200, Javier Martinez Canillas wrote: > The simpledrm driver allows to use the frame buffer that was set-up by the > firmware. This gives early video output before the platform DRM driver is > probed and takes over. > > But it would be useful to have a way to di

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Thomas Zimmermann
Hi, thanks for sending the patch out quickly. Am 22.10.21 um 16:40 schrieb Javier Martinez Canillas: The simpledrm driver allows to use the frame buffer that was set-up by the firmware. This gives early video output before the platform DRM driver is probed and takes over. But it would be usefu

[PATCH] drm/msm/a5xx: Add support for Adreno 506 GPU

2021-10-22 Thread Vladimir Lypak
This GPU is found on SoCs such as MSM8953(650MHz), SDM450(600MHz), SDM632(725MHz). Signed-off-by: Vladimir Lypak --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 34 ++ drivers/gpu/drm/msm/adreno/adreno_device.c | 18 drivers/gpu/drm/msm/adreno/adreno_gpu.h|

[PATCH] drm/msm/a5xx: Eliminate condition on setup of SMMU CP_PROTECT

2021-10-22 Thread Vladimir Lypak
Only GPU that has larger SMMU region size (0x8000 dwords) is A530. All other GPUs have 0x4000 SMMU region. However those GPUs work correctly with larger range protected because there is no known registers after SMMU region. This patch needs to be backported to stable releases because A540 GPU was f

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Neal Gompa
On Fri, Oct 22, 2021 at 11:16 AM Javier Martinez Canillas wrote: > > Hello Neal, > > Thanks for your feedback. > > On 10/22/21 16:56, Neal Gompa wrote: > > On Fri, Oct 22, 2021 at 10:40 AM Javier Martinez Canillas > > wrote: > >> > >> The simpledrm driver allows to use the frame buffer that was s

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Neal Gompa
On Fri, Oct 22, 2021 at 10:40 AM Javier Martinez Canillas wrote: > > The simpledrm driver allows to use the frame buffer that was set-up by the > firmware. This gives early video output before the platform DRM driver is > probed and takes over. > > But it would be useful to have a way to disable t

Linux >= 5.14.12 and 5.15-rc5 fail to show anything on the screen with CONFIG_DRM_SIMPLEDRM=y

2021-10-22 Thread Artem S. Tashkinov
Hello, Kernel 5.14.12 introduced this change, git commit ec7cc3f74b4236860ce612656aa5be7936d1c594: --- a/linux-5.14.11/drivers/video/fbdev/Kconfig +++ b/linux-5.14.12/drivers/video/fbdev/Kconfig @@ -2191,8 +2191,9 @@ config FB_HYPERV This framebuffer driver supports Microsoft Hyper-V Synth

Re: [PATCH v2] drm/ttm: Do not put non-struct page memory into PUD/PMDs

2021-10-22 Thread Jason Gunthorpe
On Thu, Oct 21, 2021 at 01:40:30PM +0200, Daniel Vetter wrote: > On Wed, Oct 20, 2021 at 11:09:58AM -0300, Jason Gunthorpe wrote: > > On Wed, Oct 20, 2021 at 08:34:33AM +0200, Thomas Hellström wrote: > > > > > Follow up question: If we resurrect this in the proper way (and in that > > > case > >

Re: [PATCH v2] drm/ttm: Do not put non-struct page memory into PUD/PMDs

2021-10-22 Thread Jason Gunthorpe
On Thu, Oct 21, 2021 at 01:41:39PM +0200, Daniel Vetter wrote: > On Wed, Oct 20, 2021 at 04:37:02PM -0300, Jason Gunthorpe wrote: > > On Wed, Oct 20, 2021 at 08:41:24AM +0200, Christian König wrote: > > > > > > I think the patch subject needs updating to reflect that we're disabling > > > > PUD/PM

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, On Fri, Oct 22, 2021 at 07:13:58PM +0200, Sam Ravnborg wrote: > Hi Laurent, > > > From a quick look only cadence/cdns-mhdp8546 subclass > > drm_bridge_state and I wonder if the right thing to do would be to > > implement fallback to the helpers if the bridge driver do not set > > any of t

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-22 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit 48737ac4d70faffeb516e2a9847e24f9a7eee05f: drm/amdgpu/psp: add some missing cases to psp_check_pmfw_centralized_cstate_management (2021-10-13 22:51:41 -0400) are available in the Git repository at: https://gitlab.freedeskt

Re: [PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-22 Thread John Harrison
On 10/22/2021 10:03, Matthew Brost wrote: On Fri, Oct 22, 2021 at 08:23:55AM +0200, Thomas Hellström wrote: On 10/21/21 22:37, Matthew Brost wrote: On Thu, Oct 21, 2021 at 08:15:49AM +0200, Thomas Hellström wrote: Hi, Matthew, On Mon, 2021-10-11 at 16:47 -0700, Matthew Brost wrote: The hangc

Re: [PATCH] drm/msm/a5xx: Add support for Adreno 506 GPU

2021-10-22 Thread Bjorn Andersson
On Fri 22 Oct 04:43 PDT 2021, Vladimir Lypak wrote: > This GPU is found on SoCs such as MSM8953(650MHz), SDM450(600MHz), > SDM632(725MHz). > > Signed-off-by: Vladimir Lypak > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 34 ++ > drivers/gpu/drm/msm/adreno/adreno_device

[PATCH] mediatek: Set default value for Panel Orientation connector prop.

2021-10-22 Thread Mark Yacoub
From: Mark Yacoub [Why] Creating the prop uses UNKNOWN as the initial value, which is not a supported value if the props is to be supported. [How] Set the panel orientation default value to NORMAL right after creating the prop. Tested on Jacuzzi(MTK) Fixes IGT@kms_properties@get_properties-sani

[PATCH 2/2] drm/msm/dpu: Remove dynamic allocation from atomic context

2021-10-22 Thread Rob Clark
From: Rob Clark We know the upper bound on # of mixers (ie. two), so lets just allocate this on the stack. Fixes: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:201 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0 INFO: lockde

[PATCH 1/2] drm/msm/dpu: Remove impossible NULL check

2021-10-22 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index e91568d4f09a..0ae397044310 100644 --- a/drivers/gpu/drm/msm/di

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, > > >From a quick look only cadence/cdns-mhdp8546 subclass > drm_bridge_state and I wonder if the right thing to do would be to > implement fallback to the helpers if the bridge driver do not set > any of the .atomic_duplicate_state(), .atomic_destroy_state(), or > .atomic_reset(). >

Re: [PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-22 Thread Matthew Brost
On Fri, Oct 22, 2021 at 08:23:55AM +0200, Thomas Hellström wrote: > > On 10/21/21 22:37, Matthew Brost wrote: > > On Thu, Oct 21, 2021 at 08:15:49AM +0200, Thomas Hellström wrote: > > > Hi, Matthew, > > > > > > On Mon, 2021-10-11 at 16:47 -0700, Matthew Brost wrote: > > > > The hangcheck selftest

Re: [PATCH v2 06/17] drm/i915/xehpsdv: support 64K GTT pages

2021-10-22 Thread Matthew Auld
On 21/10/2021 15:26, Ramalingam C wrote: From: Matthew Auld XEHPSDV optimises 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly.

Re: [PATCH v2 07/17] drm/i915: Add vm min alignment support

2021-10-22 Thread Matthew Auld
On 21/10/2021 15:26, Ramalingam C wrote: From: Bommu Krishnaiah Replace the hard coded 4K alignment value with vm->min_alignment. Cc: Wilson Chris P Signed-off-by: Bommu Krishnaiah Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld Although likely want to squash patch patches 3, 7 an

[PATCH] drm/mediatek: Set Rotation default value to 1.

2021-10-22 Thread Mark Yacoub
From: Mark Yacoub [Why] The Rotation prob is a bitmask value. It must always have a valid value. A default NO rotation is equal to 1 not 0. [How] 1. At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of all planes

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Sam Ravnborg
Hi Laurent, > > @@ -508,8 +510,8 @@ static const struct drm_bridge_funcs > > ps8640_bridge_funcs = { > > .attach = ps8640_bridge_attach, > > .detach = ps8640_bridge_detach, > > .get_edid = ps8640_bridge_get_edid, > > - .post_disable = ps8640_post_disable, > > - .pre_enable = ps864

[PATCH 2/2] drm/i915/gtt: stop caching the scratch page

2021-10-22 Thread Matthew Auld
Normal users shouldn't be hitting this, likely this would indicate a userspace bug. So don't bother caching, which should be safe now that we manually flush the page. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Chris Wilson Cc: Ramalingam C --- drivers/gpu

[PATCH 1/2] drm/i915/gtt: flush the scratch page

2021-10-22 Thread Matthew Auld
The scratch page is directly visible in the users address space, and while this is forced as CACHE_LLC, by the kernel, we still have to contend with things like "Bypass-LLC" MOCS. So just flush no matter what. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Chris Wilson Cc: Ramalingam C -

Re: [PATCH 00/47] GuC submission support

2021-10-22 Thread Matthew Brost
On Fri, Oct 22, 2021 at 12:35:04PM +0300, Joonas Lahtinen wrote: > Hi Matt & John, > > Can you please queue patches with the right Fixes: references to convert > all the GuC tracepoints to be protected by the LOW_LEVEL_TRACEPOINTS > protection for now. Please do so before next Wednesday so we get

Re: [PATCH 19/30] drm/i915: Add an i915_gem_vm_lookup helper

2021-10-22 Thread Jani Nikula
On Thu, 08 Jul 2021, Jason Ekstrand wrote: > This is the VM equivalent of i915_gem_context_lookup. It's only used > once in this patch but future patches will need to duplicate this lookup > code so it's better to have it in a helper. > > Signed-off-by: Jason Ekstrand > Reviewed-by: Daniel Vette

Re: [RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Javier Martinez Canillas
Hello Neal, Thanks for your feedback. On 10/22/21 16:56, Neal Gompa wrote: > On Fri, Oct 22, 2021 at 10:40 AM Javier Martinez Canillas > wrote: >> >> The simpledrm driver allows to use the frame buffer that was set-up by the >> firmware. This gives early video output before the platform DRM driv

[RFC PATCH] drm/aperture: Add param to disable conflicting framebuffers removal

2021-10-22 Thread Javier Martinez Canillas
The simpledrm driver allows to use the frame buffer that was set-up by the firmware. This gives early video output before the platform DRM driver is probed and takes over. But it would be useful to have a way to disable this take over by the real DRM drivers. For example, there may be bugs in the

Re: [PATCH v2 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-10-22 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wed, Oct 20, 2021 at 08:18:55PM +0200, Sam Ravnborg wrote: > The atomic variants of enable/disable in drm_bridge_funcs are the > preferred operations - introduce these. > > The ps8640 driver used the non-atomic variants of the > drm_bridge_chain_pre_enable/ >

[PATCH 8/9] drm/simpledrm: Support virtual screen sizes

2021-10-22 Thread Thomas Zimmermann
Add constants for the maximum size of the shadow-plane surface size. Useful for shadow planes with virtual screen sizes. The current sizes are 4096 scanlines with 4096 pixels each. This seems reasonable for current hardware, but can be increased as necessary. In simpledrm, set the maximum framebuf

[PATCH 3/9] drm/format-helper: Add destination-buffer pitch to drm_fb_swab()

2021-10-22 Thread Thomas Zimmermann
Add destination-buffer pitch as argument to drm_fb_swab(). Done for consistency with the rest of the interface. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 19 +++ drivers/gpu/drm/drm_mipi_dbi.c | 2 +- drivers/gpu/drm/gud/gud_pipe.c | 2

[PATCH 7/9] drm/simpledrm: Enable FB_DAMAGE_CLIPS property

2021-10-22 Thread Thomas Zimmermann
Enable the FB_DAMAGE_CLIPS property to reduce display-update overhead. Also fixes a warning in the kernel log. simple-framebuffer simple-framebuffer.0: [drm] drm_plane_enable_fb_damage_clips() not called Fix the computation of the blit rectangle. This wasn't an issue so far, as simpledrm alway

[PATCH 2/9] drm/format-helper: Rework format-helper memcpy functions

2021-10-22 Thread Thomas Zimmermann
Move destination-buffer clipping from all format-helper memcpy function into callers. Support destination-buffer pitch. Only distinguish between system and I/O memory, but use same logic everywhere. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 35 +++

[PATCH 4/9] drm/format-helper: Rework format-helper conversion functions

2021-10-22 Thread Thomas Zimmermann
Move destination-buffer clipping from all format-helper conversion functions into callers. Support destination-buffer pitch. Only distinguish between system and I/O memory, but use same logic everywhere. Simply harmonize the interface and semantics of the existing code. Not all conversion helpers

[PATCH 5/9] drm/format-helper: Streamline blit-helper interface

2021-10-22 Thread Thomas Zimmermann
Move destination-buffer clipping from format-helper blit function into caller. Rename drm_fb_blit_rect_dstclip() to drm_fb_blit_toio(). Done for consistency with the rest of the interface. Remove drm_fb_blit_dstclip(), which isn't required. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/dr

[PATCH 1/9] drm/format-helper: Export drm_fb_clip_offset()

2021-10-22 Thread Thomas Zimmermann
Provide a function that computes the offset into a blit destination buffer. This will allow to move destination-buffer clipping into the format-helper callers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 10 -- include/drm/drm_format_helper.h | 4

[PATCH 9/9] drm: Clarify semantics of struct drm_mode_config.{min, max}_{width, height}

2021-10-22 Thread Thomas Zimmermann
Add additional information on the semantics of the size fields in struct drm_mode_config. Also add a TODO to review all driver for correct usage of these fields. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst| 15 +++ include/drm/drm_mode_config.h | 13 ++

[PATCH 6/9] drm/fb-helper: Allocate shadow buffer of surface height

2021-10-22 Thread Thomas Zimmermann
Allocating a shadow buffer of the height of the buffer object does not support fbdev overallocation. Use surface height instead. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.

[PATCH 0/9] drm/simpledrm: Enable damage clips and virtual screens

2021-10-22 Thread Thomas Zimmermann
Enable FB_DAMAGE_CLIPS with simpledrm for improved performance and/or less overhead. With this in place, add support for virtual screens (i.e., framebuffers that are larger than the display resolution). This also enables fbdev panning and page flipping. After the discussion and bug fixing wrt to f

Re: [PATCH v9 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

2021-10-22 Thread Rob Herring
On Tue, 14 Sep 2021 22:05:36 +0200, Paul Kocialkowski wrote: > The Xylon LogiCVC is a display controller implemented as programmable > logic in Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > Acked-by: Rob Herring > --- > .../display/xylon,logicvc-display.yaml| 302

Re: [PATCH 26/28] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-10-22 Thread Christian König
Am 13.10.21 um 16:29 schrieb Daniel Vetter: On Tue, Oct 05, 2021 at 01:37:40PM +0200, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +-

Re: [PATCH v5 6/7] phy: phy-mtk-dp: Add driver for DP phy

2021-10-22 Thread Markus Schneider-Pargmann
Hi Vinod, On Fri, Oct 22, 2021 at 10:42:30AM +0530, Vinod Koul wrote: > On 21-10-21, 11:27, Markus Schneider-Pargmann wrote: > > This is a new driver that supports the integrated DisplayPort phy for > > mediatek SoCs, especially the mt8195. The phy is integrated into the > > DisplayPort controller

Re: Linux >= 5.14.12 and 5.15-rc5 fail to show anything on the screen with CONFIG_DRM_SIMPLEDRM=y

2021-10-22 Thread Arnd Bergmann
On Fri, Oct 22, 2021 at 2:15 PM Artem S. Tashkinov wrote: > Kernel 5.14.12 introduced this change, git commit > ec7cc3f74b4236860ce612656aa5be7936d1c594: > > --- a/linux-5.14.11/drivers/video/fbdev/Kconfig > +++ b/linux-5.14.12/drivers/video/fbdev/Kconfig > @@ -2191,8 +2191,9 @@ config FB_HYPERV >

Re: Linux >= 5.14.12 and 5.15-rc5 fail to show anything on the screen with CONFIG_DRM_SIMPLEDRM=y

2021-10-22 Thread Thomas Zimmermann
Hi Am 22.10.21 um 14:15 schrieb Artem S. Tashkinov: Hello, Kernel 5.14.12 introduced this change, git commit ec7cc3f74b4236860ce612656aa5be7936d1c594: --- a/linux-5.14.11/drivers/video/fbdev/Kconfig +++ b/linux-5.14.12/drivers/video/fbdev/Kconfig @@ -2191,8 +2191,9 @@ config FB_HYPERV   T

Re: [Intel-gfx] [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 03:01:52PM +0300, Ville Syrjälä wrote: > On Fri, Oct 22, 2021 at 12:25:33PM +0200, Claudio Suarez wrote: > > On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > > > drm_get_edid() internally

[PATCH] drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR

2021-10-22 Thread Kai Song
Fix inconsistent IS_ERR and PTR_ERR in i915_gem_dmabuf.c Signed-off-by: Kai Song --- drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/selft

Re: [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Ville Syrjälä
On Fri, Oct 22, 2021 at 12:25:33PM +0200, Claudio Suarez wrote: > On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > > drm_get_edid() internally calls to drm_connector_update_edid_property() > > > and then drm_add_d

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

2021-10-22 Thread Christian König
Am 21.10.21 um 18:24 schrieb Sumit Semwal: Hi Christian, On Thu, 21 Oct 2021 at 19:55, Alex Deucher > wrote: On Thu, Oct 21, 2021 at 10:19 AM Christian König mailto:ckoenig.leichtzumer...@gmail.com>> wrote: > > Those members where renamed, update t

Re: [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-22 Thread Claudio Suarez
On Thu, Oct 21, 2021 at 04:49:59PM +0300, Ville Syrjälä wrote: > On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > > drm_get_edid() internally calls to drm_connector_update_edid_property() > > and then drm_add_display_info(), which parses the EDID. > > This happens in the function i

Re: [Freedreno] [PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane

2021-10-22 Thread Dmitry Baryshkov
Hi, On Fri, 22 Oct 2021 at 02:53, wrote: > > On 2021-09-30 07:00, Dmitry Baryshkov wrote: > > In preparations of virtualizing the dpu_plane rip out debugfs support > > from dpu_plane (as it is mostly used to expose plane's pipe registers). > > Also move disable_danger file to danger/ debugfs subd

Re: [Intel-gfx] [PATCH 25/28] drm/i915: Require object lock when freeing pages during destruction

2021-10-22 Thread Matthew Auld
On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst wrote: > > TTM already requires this, and we require it for delayed destroy. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 10/28] drm/i915: Change shrink ordering to use locking around unbinding.

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 18:12 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst > wrote: >> Call drop_pages with the gem object lock held, instead of the other >> way around. This will allow us to drop the vma bindings with the >> gem object lock held. >> >> We plan to require the o

Re: [PATCH v2 3/7] drm/bridge: Add drm_atomic_get_new_crtc_for_bridge() helper

2021-10-22 Thread Maxime Ripard
Hi, On Wed, Oct 20, 2021 at 08:18:57PM +0200, Sam Ravnborg wrote: > drm_atomic_get_new_crtc_for_bridge() will be used by bridge > drivers to provide easy access to the mode from the > drm_bridge_funcs operations. > > The helper will be useful in the conversion to the atomic > operations of struct

Re: [PATCH 08/28] drm/i915: Create a full object for mock_ring, v2.

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 17:57 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: >> This allows us to finally get rid of all the assumptions that vma->obj is >> NULL. >> >> Changes since v1: >> - Ensure the mock_ring vma is pinned to prevent a fault. >> - Pin it high to avo

Re: [Intel-gfx] [PATCH 13/28] drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members

2021-10-22 Thread Matthew Auld
On Thu, 21 Oct 2021 at 18:30, Matthew Auld wrote: > > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: > > > > Big delta, but boils down to moving set_pages to i915_vma.c, and removing > > the special handling, all callers use the defaults anyway. We only remap > > in ggtt, so default cas

Re: [PATCH v11 15/16] drm/mediatek: add MERGE support for mediatek-drm

2021-10-22 Thread Jason-JH Lin
Hi Angelo, thanks for the review. On Thu, 2021-10-14 at 16:27 +0200, AngeloGioacchino Del Regno wrote: > Il 21/09/21 17:52, jason-jh.lin ha scritto: > > Add MERGE engine file: [snip] > > +int mtk_merge_clk_enable(struct device *dev) > > +{ > > + int ret = 0; > > + struct mtk_disp_merge *pri

Re: [PATCH v11 09/16] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-10-22 Thread Jason-JH Lin
Hi Angelo, Thanks for the reviews. On Thu, 2021-10-14 at 16:05 +0200, AngeloGioacchino Del Regno wrote: > > Add mt8195 vdosys0 clock driver name and routing table to > > the driver data of mtk-mmsys. > > [snip] > > > > --- > > Hello Jason, > thanks for the patch! However, there are a few t

Re: [PATCH 2/5] xen: flag xen_drm_front to be not essential for system boot

2021-10-22 Thread Oleksandr Andrushchenko
Hi, Juergen! On 22.10.21 09:47, Juergen Gross wrote: > Similar to the virtual frame buffer (vfb) the pv display driver is not > essential for booting the system. Set the respective flag. > > Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm/xen/xen_drm_f

Re: [PATCH 2/2] drm/i915/dmabuf: drop the flush on discrete

2021-10-22 Thread Matthew Auld
On 22/10/2021 10:26, Thomas Hellström wrote: Hi, Matt On 10/21/21 14:53, Matthew Auld wrote: We were overzealous here; even though discrete is non-LLC, it should still be always coherent. Signed-off-by: Matthew Auld Cc: Thomas Hellström ---   drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++

Re: [PATCH 00/47] GuC submission support

2021-10-22 Thread Joonas Lahtinen
Hi Matt & John, Can you please queue patches with the right Fixes: references to convert all the GuC tracepoints to be protected by the LOW_LEVEL_TRACEPOINTS protection for now. Please do so before next Wednesday so we get it queued in drm-intel-next-fixes. There's the orthogonal track to discuss

Re: [PATCH 2/2] drm/i915/dmabuf: drop the flush on discrete

2021-10-22 Thread Thomas Hellström
Hi, Matt On 10/21/21 14:53, Matthew Auld wrote: We were overzealous here; even though discrete is non-LLC, it should still be always coherent. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[PATCH] cmdq: fix gce_num of mt8192 driver data

2021-10-22 Thread jason-jh . lin
Because mt8192 only have 1 gce, the gce_num should be 1. Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for mt8195") Signed-off-by: jason-jh.lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-

Re: [PATCH] drm/i915/selftests: Properly reset mock object propers for each test

2021-10-22 Thread Daniel Vetter
On Thu, Oct 21, 2021 at 10:20:48PM +0200, Daniel Vetter wrote: > I forgot to do this properly in > > commit 6f11f37459d8f9f74ff1c299c0bedd50b458057a > Author: Daniel Vetter > Date: Fri Jul 23 10:34:55 2021 +0200 > > drm/plane: remove drm_helper_get_plane_damage_clips > > intel-gfx CI didn

Re: [Intel-gfx] [PATCH] drm/i915: remove CNL leftover

2021-10-22 Thread Ville Syrjälä
On Thu, Oct 21, 2021 at 02:32:13PM -0700, Lucas De Marchi wrote: > On Thu, Oct 21, 2021 at 10:05:40PM +0300, Ville Syrjälä wrote: > >On Thu, Oct 21, 2021 at 11:18:47AM -0700, Lucas De Marchi wrote: > >> We left the definition IS_CANNONLAKE() macro while removing it from the > >> tree due to having

RE: [PATCH 4/4] drm/amd/display: Add DP 2.0 MST DM Support

2021-10-22 Thread Lin, Wayne
[AMD Official Use Only] Hi Bhawan, Just a nitpick below. With that fixed, feel free to add: Reviewed-by: Wayne Lin Thanks! Regards, Wayne > -Original Message- > From: Bhawanpreet Lakha > Sent: Thursday, October 21, 2021 3:47 AM > To: Zuo, Jerry ; dri-devel@lists.freedesktop.org; > ly.

Re: drm/virtio: not pin pages on demand

2021-10-22 Thread Maksym Wezdecki
On 10/21/21 6:42 PM, Chia-I Wu wrote: > On Thu, Oct 21, 2021 at 4:52 AM Gerd Hoffmann wrote: >> On Thu, Oct 21, 2021 at 11:55:47AM +0200, Maksym Wezdecki wrote: >>> I get your point. However, we need to make resource_create ioctl, >>> in order to create corresponding resource on the host. >> That

Re: drm/virtio: not pin pages on demand

2021-10-22 Thread Maksym Wezdecki
Once again with all lists and receivers. I'm sorry for that. On 10/21/21 6:42 PM, Chia-I Wu wrote: > On Thu, Oct 21, 2021 at 4:52 AM Gerd Hoffmann wrote: >> On Thu, Oct 21, 2021 at 11:55:47AM +0200, Maksym Wezdecki wrote: >>> I get your point. However, we need to make resource_create ioctl, >>> i

Re: [Intel-gfx] [PATCH 19/28] drm/i915: Pass trylock context to callers

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 20:03 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst > wrote: >> Signed-off-by: Maarten Lankhorst > Needs a proper commit message. What about this? drm/i915: Pass trylock context to callers We are moving away from short term pinning, and need a way to

Re: [PATCH 03/28] drm/i915: Remove dma_resv_prune

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 16:43 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:36, Maarten Lankhorst > wrote: >> The signaled bit is already used for quick testing if a fence is signaled. > Why do we need this change? Can you add some more details to the commit > please? It's a terrible abuse of dma-f

RE: [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-22 Thread Lin, Wayne
[Public] Hi Bhawan, It looks good to me. Thanks! Reviewed-by: Wayne Lin Regards, Wayne > -Original Message- > From: Bhawanpreet Lakha > Sent: Thursday, October 21, 2021 11:16 PM > To: Zuo, Jerry ; dri-devel@lists.freedesktop.org; > ly...@redhat.com > Cc: intel-...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 18/28] drm/i915: Take trylock during eviction, v2.

2021-10-22 Thread Maarten Lankhorst
Op 21-10-2021 om 19:59 schreef Matthew Auld: > On Thu, 21 Oct 2021 at 11:37, Maarten Lankhorst > wrote: >> Now that freeing objects takes the object lock when destroying the >> backing pages, we can confidently take the object lock even for dead >> objects. >> >> Use this fact to take the object l

Re: [Intel-gfx] [PATCH] drm/i195: Remove some dead struct fwd decl from i915_drv.h

2021-10-22 Thread Matthew Auld
On Fri, 22 Oct 2021 at 09:22, Daniel Vetter wrote: > > Gone with userptr rewrite by Maarten in ed29c2691188 ("drm/i915: Fix > userptr so we do not have to worry about obj->mm.lock, v7.") > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst s/i195/i915/ Reviewed-by: Matthew Auld > --- >

[PATCH] drm/i195: Remove some dead struct fwd decl from i915_drv.h

2021-10-22 Thread Daniel Vetter
Gone with userptr rewrite by Maarten in ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.") Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915

[PATCH v2] dma-buf: heaps: init heaps in subsys_initcall

2021-10-22 Thread Shuosheng Huang
Some built-in modules will failed to use dma-buf heap to allocate memory if the heap drivers are too late to be initialized. To fix this issue, move initialization of dma-buf heap drivers in subsys_initcall() which is more earlier to be called. Signed-off-by: Shuosheng Huang --- drivers/dma-buf/

Re: [next] [dragonboard 410c] Unable to handle kernel paging request at virtual address 00000000007c4240

2021-10-22 Thread Vlastimil Babka
On 10/22/21 05:38, Andrew Morton wrote: > On Thu, 21 Oct 2021 19:51:20 +0200 Vlastimil Babka wrote: > >> >> Then we have to figure out how to order a fix between DRM and mmotm... >> > >> > That is the question! The problem exists only in the merge of the >> > two. On current DRM side stack_depot

Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices

2021-10-22 Thread Juergen Gross
On 22.10.21 09:24, Jan Beulich wrote: On 22.10.2021 08:47, Juergen Gross wrote: Today the non-essential pv devices are hard coded in the xenbus driver and this list is lacking multiple entries. This series reworks the detection logic of non-essential devices by adding a flag for that purpose to

Re: [PATCH v6 10/16] soc: mediatek: add mtk-mutex support for mt8195 vdosys1

2021-10-22 Thread Nancy . Lin
Hi Angelo, Thanks for the review. On Thu, 2021-10-14 at 17:01 +0200, AngeloGioacchino Del Regno wrote: > > Add mtk-mutex support for mt8195 vdosys1. > > The vdosys1 path component contains ovl_adaptor, merge5, > > and dp_intf1. Ovl_adaptor is composed of several sub-elements, > > so change it to

Re: [PATCH 0/5] xen: cleanup detection of non-essential pv devices

2021-10-22 Thread Jan Beulich
On 22.10.2021 08:47, Juergen Gross wrote: > Today the non-essential pv devices are hard coded in the xenbus driver > and this list is lacking multiple entries. > > This series reworks the detection logic of non-essential devices by > adding a flag for that purpose to struct xenbus_driver. I'm won

Re: [Intel-gfx] [PATCH 16/28] drm/i915: Rework context handling in hugepages selftests

2021-10-22 Thread kernel test robot
Hi Maarten, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.15-rc6 next-20211021] [If your patch is applied to the wrong git tree, kindly

  1   2   >