Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread John Hubbard
On 10/3/20 2:45 AM, Daniel Vetter wrote: On Sat, Oct 3, 2020 at 12:39 AM John Hubbard wrote: On 10/2/20 10:53 AM, Daniel Vetter wrote: For $reasons I've stumbled over this code and I'm not sure the change to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: convert get_user_pages(

[PATCH] drm/gma500: fix double free of gma_connector

2020-10-03 Thread trix
From: Tom Rix clang static analysis reports this problem: cdv_intel_dp.c:2101:2: warning: Attempt to free released memory kfree(gma_connector); ^~~~ In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off() fails, the handler calls cdv_intel_dp_destro

Re: [PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas

2020-10-03 Thread Guido Günther
Hi, On Fri, Oct 02, 2020 at 05:59:24PM -0500, Rob Herring wrote: > Some DSI controllers are missing a reference to the recently added > dsi-controller.yaml schema. Add it and we can drop the duplicate > parts. For the NWL part: Reviewed-by: Guido Günther > > Cc: Maxime Ripard > Cc: Chen-Yu T

Re: [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-03 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 9:27 PM Rob Clark wrote: > > On Fri, Oct 2, 2020 at 11:54 AM Daniel Vetter wrote: > > > > On Fri, Oct 02, 2020 at 10:22:42AM -0700, Rob Clark wrote: > > > On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > > > > > > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar >

[Bug 203439] amdgpu: [REG 4.20 -> 5.0] Brightness minimum level is too high

2020-10-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203439 --- Comment #5 from acom...@gmail.com --- I forgot to mention about my device. I'm using HP Envy 13 x360(ag). -- You are receiving this mail because: You are watching the assignee of the bug. ___ d

[Bug 203439] amdgpu: [REG 4.20 -> 5.0] Brightness minimum level is too high

2020-10-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203439 acom...@gmail.com changed: What|Removed |Added CC||acom...@gmail.com --- Comment #4 from

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread Daniel Vetter
On Sat, Oct 3, 2020 at 12:39 AM John Hubbard wrote: > > On 10/2/20 10:53 AM, Daniel Vetter wrote: > > For $reasons I've stumbled over this code and I'm not sure the change > > to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: > > convert get_user_pages() --> pin_user_pages()") was e

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread Daniel Vetter
On Sat, Oct 3, 2020 at 1:31 AM Jason Gunthorpe wrote: > > On Fri, Oct 02, 2020 at 08:16:48PM +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > > > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > > > For $reasons I've stumbled over this code

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-03 Thread Maxime Ripard
Hi Tim, On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > VCO to support a core-frequency of 550 MHz which is the minimum > frequency required by the HVS at 4Kp60. The side effect is that if the > display clock requ

Re: WARNING in ieee80211_bss_info_change_notify

2020-10-03 Thread syzbot
syzbot has bisected this issue to: commit 135f971181d779c96ff3725c1a350a721785cc66 Author: Alex Deucher Date: Mon Nov 20 22:49:53 2017 + drm/amdgpu: don't skip attributes when powerplay is enabled bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=120f55bd90 start commit

[PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-03 Thread Kuogee Hsieh
Connection state is set incorrectly happen at either failure of link train or cable plugged in while suspended. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 52 ++

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread Jason Gunthorpe
On Fri, Oct 02, 2020 at 08:16:48PM +0200, Daniel Vetter wrote: > On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > > For $reasons I've stumbled over this code and I'm not sure the change > > > to the new gup functions in 55

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-03 Thread Guenter Roeck
On 10/2/20 4:41 PM, Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Stephen Boyd > Cc: Shawn Guo > Cc: Bjorn Andersson > C

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-03 Thread Jassi Brar
On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > CMDQ helper provide timer to detect execution timeout, but DRM driver > could have a better way to detect execution timeout by vblank IRQ. > For DRM, CMDQ command should execute in vblank, so if it fail to > execute in next 2 vblank, timeout

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread Jason Gunthorpe
On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > For $reasons I've stumbled over this code and I'm not sure the change > to the new gup functions in 55a650c35fea ("mm/gup: frame_vector: > convert get_user_pages() --> pin_user_pages()") was entirely correct. > > This here is used fo

Re: [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-02 15:09:19) > Connection state is set incorrectly happen at either failure of link train > or cable plugged in while suspended. This patch fixes these problems. > This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. > > Signed-off-by: Kuogee Hsieh Any Fi

Re: [PATCH] drm/atomic: Make the kerneldoc a bit clearer

2020-10-03 Thread Maxime Ripard
Hi, On Fri, Oct 02, 2020 at 09:56:20AM +0200, Daniel Vetter wrote: > Crank up the warning a notch and point at the right set of locking > functions for atomic drivers. > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc

Re: [PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-03 Thread Jason Gunthorpe
On Sun, Sep 27, 2020 at 09:46:44AM +0300, Leon Romanovsky wrote: > +struct scatterlist *__sg_alloc_table_from_pages(struct sg_table *sgt, > + struct page **pages, unsigned int n_pages, unsigned int offset, > + unsigned long size, unsigned int max_segment, > + str

Re: [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-03 Thread Jonathan Marek
On 10/2/20 3:53 AM, Christoph Hellwig wrote: @@ -8,6 +8,7 @@ #include #include #include +#include NAK, dma-noncoherent.h is not for driver use. And will in fact go away in 5.10. Not actually used, so can be removed. #include @@ -808,6 +809,20 @@ int msm_gem_cpu_fini(stru

[PATCH] drm/stm: Fix bus_flags handling

2020-10-03 Thread Marek Vasut
The drm_display_mode_to_videomode() does not populate DISPLAY_FLAGS_DE_LOW or DISPLAY_FLAGS_PIXDATA_NEGEDGE flags in struct videomode. Therefore, no matter what polarity the next bridge or display might require, these flags are never set, and thus the LTDC GCR_DEPOL and GCR_PCPOL bits are never set

Re: [PATCH] drm/atomic: Make the kerneldoc a bit clearer

2020-10-03 Thread Maxime Ripard
On Fri, Oct 02, 2020 at 02:37:25PM +0200, Daniel Vetter wrote: > On Fri, Oct 2, 2020 at 2:31 PM Maxime Ripard wrote: > > On Fri, Oct 02, 2020 at 09:56:20AM +0200, Daniel Vetter wrote: > > > Crank up the warning a notch and point at the right set of locking > > > functions for atomic drivers. > > >

[RFC][PATCH] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2020-10-03 Thread Marek Vasut
The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to select input pixel data sampling edge. Add DT property "pixelclk-active", same as the one used by display timings, and configure bus flags based on this DT property. Signed-off-by: Marek Vasut Cc: Alexandre Torgue Cc: Andr

Re: [PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-03 Thread Jason Gunthorpe
On Fri, Oct 02, 2020 at 07:11:33PM +0300, Maor Gottlieb wrote: > > On 10/2/2020 6:02 PM, Jason Gunthorpe wrote: > > On Sun, Sep 27, 2020 at 09:46:44AM +0300, Leon Romanovsky wrote: > > > +struct scatterlist *__sg_alloc_table_from_pages(struct sg_table *sgt, > > > + struct page **pages, uns

Re: [PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-03 Thread Maor Gottlieb
On 10/2/2020 6:02 PM, Jason Gunthorpe wrote: On Sun, Sep 27, 2020 at 09:46:44AM +0300, Leon Romanovsky wrote: +struct scatterlist *__sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, unsigned int offset, + unsigned long siz

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-03 Thread Qais Yousef
On 09/30/20 14:17, Rob Clark wrote: > From: Rob Clark > > The android userspace treats the display pipeline as a realtime problem. > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > it is. (See https://lwn.net/Articles/809545/ for the best explaination > that I found.) >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-03 Thread Oded Gabbay
On Sat, Oct 3, 2020 at 2:31 AM Jason Gunthorpe wrote: > > On Fri, Oct 02, 2020 at 08:16:48PM +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > > > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > > > For $reasons I've stumbled over this code

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-03 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 05:06:54PM +0200, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 02.10.2020 o 16:02, Greg Kroah-Hartman pisze: > > On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote: > > > Hi, > > > > > > W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: > > > > On Tu

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-03 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 06:41:43PM -0500, Rob Herring wrote: > Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Stephen Boyd > Cc: Shawn Guo > Cc