Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops

2020-09-28 Thread Thomas Zimmermann
Hi Sam Am 25.09.20 um 23:55 schrieb Sam Ravnborg: > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") > introduced the following build error: > > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here > 304 | .vm_ops = &drm_gem_cma_vm_ops, > |

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-28 Thread Geert Uytterhoeven
Hi Prabhakar, On Mon, Sep 28, 2020 at 9:52 AM Prabhakar Mahadev Lad wrote: > > On Sun, Sep 27, 2020 at 10:04 PM Laurent Pinchart > > wrote: > > > On Sun, Sep 27, 2020 at 02:01:50PM +0100, Lad, Prabhakar wrote: > > > > On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > > > > On Thu, Aug

Re: [PATCH 30/45] drm/ttm: add a new invalidate notify callback.

2020-09-28 Thread Dave Airlie
On Thu, 24 Sep 2020 at 22:25, Christian König wrote: > > Am 24.09.20 um 07:18 schrieb Dave Airlie: > > From: Dave Airlie > > > > Signed-off-by: Dave Airlie > > NAK, completely unnecessary. > > We should rather do the remaining accounting in the already existing > release_notify() callback. > > T

[PATCH AUTOSEL 4.14 2/9] drm/sun4i: mixer: Extend regmap max_register

2020-09-28 Thread Sasha Levin
From: Martin Cerveny [ Upstream commit 74ea06164cda81dc80e97790164ca533fd7e3087 ] Better guess. Secondary CSC registers are from 0xF. Signed-off-by: Martin Cerveny Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200906162140

[PATCH AUTOSEL 4.19 02/11] drm/sun4i: mixer: Extend regmap max_register

2020-09-28 Thread Sasha Levin
From: Martin Cerveny [ Upstream commit 74ea06164cda81dc80e97790164ca533fd7e3087 ] Better guess. Secondary CSC registers are from 0xF. Signed-off-by: Martin Cerveny Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200906162140

[PATCH AUTOSEL 5.8 07/29] drm/sun4i: mixer: Extend regmap max_register

2020-09-28 Thread Sasha Levin
From: Martin Cerveny [ Upstream commit 74ea06164cda81dc80e97790164ca533fd7e3087 ] Better guess. Secondary CSC registers are from 0xF. Signed-off-by: Martin Cerveny Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200906162140

[PATCH AUTOSEL 5.4 04/18] drm/sun4i: mixer: Extend regmap max_register

2020-09-28 Thread Sasha Levin
From: Martin Cerveny [ Upstream commit 74ea06164cda81dc80e97790164ca533fd7e3087 ] Better guess. Secondary CSC registers are from 0xF. Signed-off-by: Martin Cerveny Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200906162140

Re: [GIT PULL] mediatek drm next for 5.10

2020-09-28 Thread Dave Airlie
On Tue, 29 Sep 2020 at 01:55, Chun-Kuang Hu wrote: > > Hi, Dave & Daniel: > > I does not see these patches in drm-next branch. Does these patches > have any problem? > Sorry just got caught in the queue, should be all landed now. Thanks, Dave. ___ dri-

Re: [PATCH] drm/msm: fix 32b build warns

2020-09-28 Thread abhinavk
On 2020-09-28 17:19, Rob Clark wrote: From: Rob Clark Neither of these code-paths apply to older 32b devices, but it is rude to introduce warnings. Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/dsi/pll/dsi_pll

[PATCH] drm/msm: fix 32b build warns

2020-09-28 Thread Rob Clark
From: Rob Clark Neither of these code-paths apply to older 32b devices, but it is rude to introduce warnings. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [pull] drm/msm: msm-next for 5.10

2020-09-28 Thread Dave Airlie
Assuming I merged it right, 32-bit builds adds warning In file included from /home/airlied/devel/kernel/dim/src/include/linux/bitops.h:5, from /home/airlied/devel/kernel/dim/src/include/linux/kernel.h:12, from /home/airlied/devel/kernel/dim/src/include/linux/ascii

Re: [External] Re: [PATCH 2/2] sched: mark PRINTK_DEFERRED_CONTEXT_MASK in __schedule()

2020-09-28 Thread Sergey Senozhatsky
On (20/09/28 12:25), Peter Zijlstra wrote: [..] > > printk > >   vprintk_emit > >     console_unlock > >       vt_console_print > >         hide_cursor > >           bit_cursor > >             soft_cursor > >               queue_work_on > >                 __queue_work > >                   try_to_

[PATCH tip/core/rcu 11/15] drm/i915: Cleanup PREEMPT_COUNT leftovers

2020-09-28 Thread paulmck
From: Thomas Gleixner CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be removed. Cleanup the leftovers before doing so. Signed-off-by: Thomas Gleixner Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: intel-...@lists.freedesktop.org C

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Matt Roper
On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: > On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: > > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" > > wrote: > > > This is a good example of a potential trap that having > > > IS_ELKHARTLAKE() cover both

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Lucas De Marchi
On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: This is a good example of a potential trap that having IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder might change the if ladder to have IS_

Re: [PATCH] drm/amd/display: make two symbols static

2020-09-28 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland wrote: > > On 2020-09-27 10:35 p.m., Jason Yan wrote: > > This addresses the following sparse warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: > > warning: symbol 'dce110_set_curs

Re: [PATCH] drm/amd/display: make get_color_space_type() static

2020-09-28 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland wrote: > > On 2020-09-27 10:36 p.m., Jason Yan wrote: > > This addresses the following sparse warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26: > > warning: symbol 'get_color_space_type' was n

Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks

2020-09-28 Thread abhinavk
On 2020-09-28 12:16, Stephen Boyd wrote: Printk messages need newlines. Add it here. Cc: Abhinav Kumar Cc: Jeykumar Sankaran Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Stephen Boyd Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--

Re: [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present

2020-09-28 Thread Sam Ravnborg
Hi Alex. On Mon, Sep 28, 2020 at 12:35:01PM -0500, Alex G. wrote: > On 9/26/20 1:49 PM, Sam Ravnborg wrote: > > Hi Alexandru > > > > On Thu, Sep 24, 2020 at 03:05:05PM -0500, Alexandru Gagniuc wrote: > > > On the SII9022, the IOVCC and CVCC12 supplies must reach the correct > > > voltage before t

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Matt Roper wrote: > Why are we adding IS_JASPERLAKE at all? EHL/JSL are documented as the > same graphics IP, but are paired with different PCHs in the final SoCs, > which is what causes the minor differences in programming. My > understanding is that the voltage programming

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Surendrakumar Upadhyay, TejaskumarX
From: Matt Roper Sent: Monday, September 28, 2020 10:54 PM To: Jani Nikula Cc: Surendrakumar Upadhyay, TejaskumarX ; Vivi, Rodrigo ; airl...@linux.ie ; dan...@ffwll.ch ; intel-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.k

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Matt Roper
On Mon, Sep 28, 2020 at 08:14:02PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" > wrote: > > > > From: Jani Nikula > > Sent: Monday, September 28, 2020 7:07 PM > > To: Surendrakumar Upadhyay, TejaskumarX > > ; Vivi, Rodr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Ville Syrjälä wrote: > On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: >> On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, Tejas Upadhyay >> > wrote: >> > > JSL has update in vswing table for eDP >> > >> > I've thought the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > This is a good example of a potential trap that having > IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder > might change the if ladder to have IS_ELKHARTLAKE() first, and the > subsequent IS_JASPERLAKE(

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > > From: Jani Nikula > Sent: Monday, September 28, 2020 7:07 PM > To: Surendrakumar Upadhyay, TejaskumarX > ; Vivi, Rodrigo > ; airl...@linux.ie ; > dan...@ffwll.ch ; intel-...@lists.freedeskto

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Surendrakumar Upadhyay, TejaskumarX
From: Jani Nikula Sent: Monday, September 28, 2020 7:13 PM To: Surendrakumar Upadhyay, TejaskumarX ; Vivi, Rodrigo ; airl...@linux.ie ; dan...@ffwll.ch ; intel-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; Ausm

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Surendrakumar Upadhyay, TejaskumarX
From: Jani Nikula Sent: Monday, September 28, 2020 7:07 PM To: Surendrakumar Upadhyay, TejaskumarX ; Vivi, Rodrigo ; airl...@linux.ie ; dan...@ffwll.ch ; intel-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org ; Ausm

Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-09-28 Thread Rob Herring
On Mon, Sep 28, 2020 at 3:17 AM Maxime Ripard wrote: > > Hi! > > On Mon, Sep 28, 2020 at 02:27:35PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > The Unisoc DRM master device is a virtual device needed to list all > > DPU devices or other display interface nodes that comprise the > > grap

Re: CONFIG_AMDGPU triggers full rebuild

2020-09-28 Thread Felix Kuehling
If I had to guess, I'd say something HMM-related. There has been some back-and-forth between kernel releases. So I won't say anything more specific without knowing exactly which branch or release you're on. Regards,   Felix Am 2020-09-25 um 10:29 a.m. schrieb Thomas Zimmermann: > Hi, > > whenever

[Bug 209417] kernel-5.8*, amdgpu - Blank screen shortly after boot, "fixed" with suspend and wake up

2020-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209417 --- Comment #1 from Juan (juantxor...@gmail.com) --- Created attachment 292701 --> https://bugzilla.kernel.org/attachment.cgi?id=292701&action=edit boot log 5.7.17 fedora - working This is the boot log of a boot with the kernel 5.7.17 with fedo

[Bug 209417] New: kernel-5.8*, amdgpu - Blank screen shortly after boot, "fixed" with suspend and wake up

2020-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209417 Bug ID: 209417 Summary: kernel-5.8*, amdgpu - Blank screen shortly after boot, "fixed" with suspend and wake up Product: Drivers Version: 2.5 Kernel Version: >=5.8 Hard

Re: [PATCHv5 4/6] drm/msm/a6xx: Add support for using system cache(LLC)

2020-09-28 Thread Jordan Crouse
On Mon, Sep 28, 2020 at 05:56:55PM +0530, Sai Prakash Ranjan wrote: > Hi Jordan, > > On 2020-09-23 20:33, Jordan Crouse wrote: > >On Tue, Sep 22, 2020 at 11:48:17AM +0530, Sai Prakash Ranjan wrote: > >>From: Sharat Masetty > >> > >>The last level system cache can be partitioned to 32 different >

[PATCH] dt-bindings: Fix 'reg' size issues in zynqmp examples

2020-09-28 Thread Rob Herring
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples: Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c:reg:0: [0, 4249616384, 0, 4096] is too long From schema: /usr/local/lib/

Re: [GIT PULL] mediatek drm next for 5.10

2020-09-28 Thread Chun-Kuang Hu
Hi, Dave & Daniel: I does not see these patches in drm-next branch. Does these patches have any problem? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年9月15日 週二 上午7:12寫道: > > Hi, Dave & Daniel: > > This includes: > > 1. Move Mediatek HDMI PHY driver from DRM folder to PHY folder > 2. Convert mtk-dpi

Re: [PATCH] linux-firmware: Update firmware for Cadence MHDP8546 DP bridge

2020-09-28 Thread Josh Boyer
Applied and pushed out. josh On Wed, Sep 23, 2020 at 11:14 AM Swapnil Jakhade wrote: > > Update firmware for Cadence MHDP8546 DP bridge to version 2.0.0. > The firmware source code now complies with MISRA2012 and HIS > rules and directives. Also, there are some improvements in AUX > channel comm

[Bug 208647] persistent amdgpu: [mmhub] page faults

2020-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208647 --- Comment #7 from Stefan Winter (m...@stefan-winter.de) --- Created attachment 292697 --> https://bugzilla.kernel.org/attachment.cgi?id=292697&action=edit dmesg on 5.9.0-RC7 dmesg -- You are receiving this mail because: You are watching the

[Bug 208647] persistent amdgpu: [mmhub] page faults

2020-09-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208647 Stefan Winter (m...@stefan-winter.de) changed: What|Removed |Added CC||m...@stefan-winter

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Ville Syrjälä
On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: > On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > > On Mon, 28 Sep 2020, Tejas Upadhyay > > wrote: > > > JSL has update in vswing table for eDP > > > > I've thought the TLA for Jasper Lake is JSP, not JSL. At least we h

Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-28 Thread Guido Günther
Hi Thierry, On Mon, Sep 28, 2020 at 08:50:39AM +0200, Thierry Reding wrote: > On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > > We need to reset both for the panel to show an image. > > > > > >

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE

2020-09-28 Thread Will Deacon
On Tue, Sep 22, 2020 at 03:16:48PM +0100, Robin Murphy wrote: > Midgard GPUs have ACE-Lite master interfaces which allows systems to > integrate them in an I/O-coherent manner. It seems that from the GPU's > viewpoint, the rest of the system is its outer shareable domain, and so > even when snoop s

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread James Ausmus
On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, Tejas Upadhyay > wrote: > > JSL has update in vswing table for eDP > > I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have > PCH_JSP for Jasper Lake PCH. JSP == Point (the PCH), JSL == Lake -

Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-28 Thread Harry Wentland
On 2020-09-28 10:06 a.m., Jason Yan wrote: > ping... > Fix by YueHaibing is already merged for this: commit 73b1acd54e13686fbb002afdf892c670177f0c57 Author: YueHaibing Date: Thu Sep 10 11:13:52 2020 +0800 drm/amd/display: Create trigger_hotplug entry Add trigger_hotplug debugfs entr

Re: [PATCH] drm/amd/display: make get_color_space_type() static

2020-09-28 Thread Harry Wentland
On 2020-09-27 10:36 p.m., Jason Yan wrote: > This addresses the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26: > warning: symbol 'get_color_space_type' was not declared. Should it be > static? > If you have multiple fixes of the same or simi

Re: [PATCH] drm/amd/display: make two symbols static

2020-09-28 Thread Harry Wentland
On 2020-09-27 10:35 p.m., Jason Yan wrote: > This addresses the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: > warning: symbol 'dce110_set_cursor_position' was not declared. Should it > be static? > drivers/gpu/drm/amd/amdgpu/../displa

Re: [PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-28 Thread Peter Xu
On Mon, Sep 28, 2020 at 12:35:07PM +0200, Jason A. Donenfeld wrote: > It seems likely this block was pasted from internal_get_user_pages_fast, > which is not passed an mm struct and therefore uses current's. But > __get_user_pages_locked is passed an explicit mm, and current->mm is not > always val

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Pekka Paalanen
On Mon, 28 Sep 2020 12:24:28 +0200 Gerd Hoffmann wrote: > Hi, > > > > I don't quite remember where exactly this was implemented. It was not a > > > shared buffer, though. IIRC the buffer allocation code in one of the > > > libs rounded the size towards multiples of 64. I remember thinking that

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Tejas Upadhyay wrote: > JSL has update in vswing table for eDP I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have PCH_JSP for Jasper Lake PCH. > > BSpec: 21257 > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 67 ++

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Tejas Upadhyay wrote: > Split the basic platform definition, macros, and PCI IDs to > differentiate between EHL and JSL platforms. > > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/i915_drv.h | 4 +++- > drivers/gpu/drm/i915/i915_pci.c | 9 +++

Re: [PATCH] drm/nouveau/kms/nv50-: Fix clock checking algorithm in nv50_dp_mode_valid()

2020-09-28 Thread Ville Syrjälä
On Tue, Sep 22, 2020 at 05:05:10PM -0400, Lyude Paul wrote: > While I thought I had this correct (since it actually did reject modes > like I expected during testing), Ville Syrjala from Intel pointed out > that the logic here isn't correct. max_clock refers to the max symbol > rate supported by th

Re: [PATCH v10 0/8] Asynchronous flip implementation for i915

2020-09-28 Thread Ville Syrjälä
On Mon, Sep 21, 2020 at 04:32:02PM +0530, Karthik B S wrote: > Without async flip support in the kernel, fullscreen apps where game > resolution is equal to the screen resolution, must perform an extra blit > per frame prior to flipping. > > Asynchronous page flips will also boost the FPS of Mesa

Re: [PATCH 05/18] ARM/dma-mapping: Switch to iommu_dma_ops

2020-09-28 Thread Marek Szyprowski
Hi Robin, On 20.08.2020 17:08, Robin Murphy wrote: > With the IOMMU ops now looking much the same shape as iommu_dma_ops, > switch them out in favour of the iommu-dma library, currently enhanced > with temporary workarounds that allow it to also sit underneath the > arch-specific API. With that in

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-28 Thread Christian König
Am 28.09.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 28.09.20 um 08:50 schrieb Christian König: Am 27.09.20 um 21:16 schrieb Sam Ravnborg: Hi Thomas. struct simap {     union {     void __iomem *vaddr_iomem;     void *vaddr;     };     bool is_iomem;

Re: [PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-28 Thread Chris Wilson
Quoting Jason A. Donenfeld (2020-09-28 11:35:07) > It seems likely this block was pasted from internal_get_user_pages_fast, > which is not passed an mm struct and therefore uses current's. But > __get_user_pages_locked is passed an explicit mm, and current->mm is not > always valid. This was hit wh

Re: [PATCH] drm: prime: Potential Oops in drm_gem_map_dma_buf()

2020-09-28 Thread Christian König
Hi Dan, Am 28.09.20 um 11:07 schrieb Dan Carpenter: This code doesn't check if the call to ->get_sg_table() fails so it could dereference an error pointer and Oops. Fixes: c614d7e66c6a ("drm: remove prime sg_table caching") Signed-off-by: Dan Carpenter this patch is based on outdated code, p

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Sam Ravnborg
On Mon, Sep 28, 2020 at 10:48:31AM +0200, Thomas Zimmermann wrote: > Hi > > Am 28.09.20 um 10:40 schrieb Sam Ravnborg: > > Hi Thomas. > > On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: > >> Include to get drm_gem_cma_vm_ops. Fallout > >> from the recent conversion to GEM objec

Re: [External] Re: [PATCH 2/2] sched: mark PRINTK_DEFERRED_CONTEXT_MASK in __schedule()

2020-09-28 Thread Peter Zijlstra
On Mon, Sep 28, 2020 at 06:04:23PM +0800, Chengming Zhou wrote: > Well, you are lucky. So it's a problem in our printk implementation. Not lucky; I just kicked it in the groin really hard: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git debug/experimental > The deadlock path i

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Gerd Hoffmann
Hi, > > I don't quite remember where exactly this was implemented. It was not a > > shared buffer, though. IIRC the buffer allocation code in one of the > > libs rounded the size towards multiples of 64. I remember thinking that > > it was probably done for tiled rendering. Happens when running

Re: remove alloc_vm_area v2

2020-09-28 Thread Joonas Lahtinen
+ Dave and Daniel + Stephen Quoting Christoph Hellwig (2020-09-26 09:29:59) > On Fri, Sep 25, 2020 at 07:43:49PM -0700, Andrew Morton wrote: > > On Thu, 24 Sep 2020 15:58:42 +0200 Christoph Hellwig wrote: > > > > > this series removes alloc_vm_area, which was left over from the big > > > vmalloc

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:50 schrieb Daniel Vetter: > On Mon, Sep 28, 2020 at 10:40 AM Thomas Zimmermann > wrote: >> >> Hi >> >> Am 29.06.20 um 11:27 schrieb Daniel Vetter: >>> On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: Platform devices might operate on firmware framebuff

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:53 schrieb Daniel Vetter: > On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann wrote: >> >> Hi >> >> Am 26.09.20 um 18:42 schrieb Daniel Vetter: >>> On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann >>> wrote: Hi Am 29.06.20 um 10:40 schrieb Daniel Vetter

[PATCH] drm: prime: Potential Oops in drm_gem_map_dma_buf()

2020-09-28 Thread Dan Carpenter
This code doesn't check if the call to ->get_sg_table() fails so it could dereference an error pointer and Oops. Fixes: c614d7e66c6a ("drm: remove prime sg_table caching") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_prime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

Re: [PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 9:06 AM Maxime Ripard wrote: > > There's cross-talk on the RPi4 between the 2.4GHz channels used by the WiFi > chip and some resolutions, most notably 1440p at 60Hz. > > In such a case, we can either reject entirely the mode, or lower slightly > the pixel frequency to remov

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann wrote: > > Hi > > Am 26.09.20 um 18:42 schrieb Daniel Vetter: > > On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 29.06.20 um 10:40 schrieb Daniel Vetter: > >>> On Thu, Jun 25, 2020 at 02:00:03PM +0200, Thom

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 10:40 AM Thomas Zimmermann wrote: > > Hi > > Am 29.06.20 um 11:27 schrieb Daniel Vetter: > > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: > >> Platform devices might operate on firmware framebuffers, such as VESA or > >> EFI. Before a native driver for

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:40 schrieb Sam Ravnborg: > Hi Thomas. > On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: >> Include to get drm_gem_cma_vm_ops. Fallout >> from the recent conversion to GEM object functions. >> >> Signed-off-by: Thomas Zimmermann >> Reported-by: kernel test

Re: [PATCH] drm/hisilicon: Using the to_hibmc_drm_private to convert

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:32 schrieb Tian Tao: > Using the to_hibmc_drm_private to convert over all uses of dev_private > over to the function, and fix a little formatting issue. Sounds strange to me. Maybe remove "over to the function" and it should be better. > > Signed-off-by: Tian Tao Reviewed

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Sam Ravnborg
Hi Thomas. On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: > Include to get drm_gem_cma_vm_ops. Fallout > from the recent conversion to GEM object functions. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > Fixes: 0d590af3140d ("drm/rockchip: Convert to

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Thomas Zimmermann
Hi Am 29.06.20 um 11:27 schrieb Daniel Vetter: > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: >> Platform devices might operate on firmware framebuffers, such as VESA or >> EFI. Before a native driver for the graphics hardware can take over the >> device, it has to remove any

[PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Tejas Upadhyay
JSL has update in vswing table for eDP BSpec: 21257 Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/display/intel_ddi.c | 67 ++-- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/in

[PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Tejas Upadhyay
Split the basic platform definition, macros, and PCI IDs to differentiate between EHL and JSL platforms. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 9 + drivers/gpu/drm/i915/intel_device_info.c | 1 + dr

[PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Thomas Zimmermann
Include to get drm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions. Signed-off-by: Thomas Zimmermann Reported-by: kernel test robot Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Christian König Cc:

[PATCH 0/2] drm/i915/jsl: Update JasperLake Voltage swing table

2020-09-28 Thread Tejas Upadhyay
Patch series covers following things: 1. Split and differentiate between EhlkhartLake and JasperLake platfrom 2. Update voltage swing table for eDP on JasperLake platform BSpec: 21257 Tejas Upadhyay (2): drm/i915/jsl: Split EHL/JSL platform info and PCI ids drm/i915/edp/jsl: Update vswing

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 4:51 PM, Sam Ravnborg wrote: > Hi Yannick. > > On Fri, Sep 25, 2020 at 12:22:33PM +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. > The patchs filas to drop the include mentioned here. > >> Remove useless dsi_color_from_mipi

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 08:50 schrieb Christian König: > Am 27.09.20 um 21:16 schrieb Sam Ravnborg: >> Hi Thomas. >> struct simap {     union {     void __iomem *vaddr_iomem;     void *vaddr;     };     bool is_iomem; }; Wh

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 2:02 PM, Joe Perches wrote: > On Fri, 2020-09-25 at 12:22 +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. >> Remove useless dsi_color_from_mipi function. > [] >> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> b/drivers

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-28 Thread Geert Uytterhoeven
Hi Prabhakar, On Sun, Sep 27, 2020 at 10:04 PM Laurent Pinchart wrote: > On Sun, Sep 27, 2020 at 02:01:50PM +0100, Lad, Prabhakar wrote: > > On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > > On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > > > > The iwg21d comes with a

Re: [PATCH 3/9] drm: Add simplekms driver

2020-09-28 Thread Thomas Zimmermann
Hi Am 25.09.20 um 17:14 schrieb Maxime Ripard: > Hi Thomas, > > On Fri, Sep 25, 2020 at 05:01:23PM +0200, Thomas Zimmermann wrote: + ARRAY_SIZE(simplekms_formats), + simplekms_format_modifiers, +

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Thomas Zimmermann
Hi Am 26.09.20 um 18:42 schrieb Daniel Vetter: > On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 29.06.20 um 10:40 schrieb Daniel Vetter: >>> On Thu, Jun 25, 2020 at 02:00:03PM +0200, Thomas Zimmermann wrote: The memcpy's destination buffer might have a different p

[RESEND PATCH v5 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-09-28 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack,

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Peilin Ye
On Sun, Sep 27, 2020 at 05:28:12PM +0900, Tetsuo Handa wrote: > Well, vt_io_ioctl(PIO_FONT) initializes "struct console_font_op op;" with > > op.width = 8; > op.height = 0; > op.charcount = 256; > > and calls con_font_set() from con_font_op(). But the "/* Need to guess font > height [compa

[PATCH] drm/vc4: hdmi: Block odd horizontal timings

2020-09-28 Thread Maxime Ripard
The FIFO between the pixelvalve and the HDMI controller runs at 2 pixels per clock cycle, and cannot deal with odd timings. Let's reject any mode with such timings. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 file

Re: [PATCH v2 0/7] Ingenic-drm improvements + new pixel formats

2020-09-28 Thread Paul Cercueil
Hi, Le sam. 26 sept. 2020 à 20:25, Sam Ravnborg a écrit : Hi Paul. On Sat, Sep 26, 2020 at 07:04:54PM +0200, Paul Cercueil wrote: Hi, This is a V2 of my small patchset "Small improvements to ingenic-drm" that I sent about two weeks ago. In that time, I worked on new improvements, so I

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-28 Thread Lad, Prabhakar
Hi Laurent, On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > > The iwg21d comes with a 7" capacitive touch screen, therefore > > add support for it. > > > > Signed-off-by: La

[PATCH RFC v7 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-09-28 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. RFC v7: - Fix DTC unit name warnings - Fix the problem of maintainers Cc: Orson Zhai Cc: Chunyan Zhang Signed

KASAN: global-out-of-bounds Read in bit_putcs (2)

2020-09-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=126e918d90 kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7 das

[PATCH v3 1/1] drm/ingenic: Add support for paletted 8bpp

2020-09-28 Thread Paul Cercueil
On JZ4725B and newer, the F0 plane supports paletted 8bpp with a 256-entry palette. Add support for it. v3: Only accept a full 256-entry palette. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 66 +-- 1 file changed, 62 insertions(+), 4 deletion

RE: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-28 Thread Swapnil Kashinath Jakhade
Hi Tomi, Thank you for the patch. > -Original Message- > From: Tomi Valkeinen > Sent: Wednesday, September 23, 2020 2:01 PM > To: dri-devel@lists.freedesktop.org; Swapnil Kashinath Jakhade > ; Yuti Suresh Amonkar > Cc: Stephen Rothwell ; Dave Airlie > ; Laurent Pinchart ; > Tomi Valkein

Re: [PATCH 3/9] drm: Add simplekms driver

2020-09-28 Thread Maxime Ripard
Hi Thomas, On Fri, Sep 25, 2020 at 05:01:23PM +0200, Thomas Zimmermann wrote: > >> + ARRAY_SIZE(simplekms_formats), > >> + simplekms_format_modifiers, > >> + connector); > >> + if (ret) > >

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Peilin Ye
On Sun, Sep 27, 2020 at 01:25:17AM +0900, Tetsuo Handa wrote: > A simplified reproducer and debug printk() patch shown below reported that > vc_font.height is increased to 9 via ioctl(VT_RESIZEX) after it was once > decreased from 16 to 2 via ioctl(PIO_FONT). > > > > Since vc_resize() with v.v_r

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-28 Thread Peilin Ye
On Fri, Sep 25, 2020 at 03:25:51PM +0200, Daniel Vetter wrote: > I think the only way to make this work is that we have one place which > takes in the userspace uapi struct, and then converts it once into a > kernel_console_font. With all the error checking. Ah, I didn't think of that! When trying

[RESEND PATCH v5 0/2] Add a Himax HX8837 display controller driver

2020-09-28 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. The only change since the previous version is the Reviewed-by tag in DT bindings. Compared to v3 the bindings have been con

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Maor Gottlieb
On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index 0a1464181226..4899359a31ac 100644 +++ b/tools/testing/scatterlist/main.c @@ -55,14 +55,13 @@ int

[PATCH v3 0/1] 8bpp support for Ingenic-drm

2020-09-28 Thread Paul Cercueil
Final (?) version of my "small improvements to ingenic-drm" patchset. Most of the patches of V2 have been merged to drm-misc-next, except this one which required some more work. In the CRTC's .atomic_check callback, the size of the gamma LUT property is now checked, so that only a complete 256-en

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Tetsuo Handa
A simplified reproducer and debug printk() patch shown below reported that vc_font.height is increased to 9 via ioctl(VT_RESIZEX) after it was once decreased from 16 to 2 via ioctl(PIO_FONT). Since vc_resize() with v.v_rows == 0 preserves current vc->vc_rows value, this reproducer is bypassing

[PATCH v3] drm/hisilicon: Deleted the drm_device declaration

2020-09-28 Thread Tian Tao
drm_framebuffer.h already declares struct drm_device, so there's no need to declare it in hibm_drm_drv.h v2: fixed spelling errors in commit message. v3: rewrite the commit message. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --

[PATCH v2 4/7] drm/ingenic: Support handling different pixel formats in F0/F1 planes

2020-09-28 Thread Paul Cercueil
Until now the ingenic-drm driver supported the same pixel formats on the F0 and F1 planes, and across all SoCs. However, the F0 plane does support paletted 8bpp, while the F1 plane doesn't. Furthermore, the three SoCs currently supported all have different pixel formats available; 24bpp was added

[PATCH v2 0/7] Ingenic-drm improvements + new pixel formats

2020-09-28 Thread Paul Cercueil
Hi, This is a V2 of my small patchset "Small improvements to ingenic-drm" that I sent about two weeks ago. In that time, I worked on new improvements, so I thought I'd just add them to the patchset, since I needed a V2 anyway. Sam: the patches you acked have been all slightly modified, I kept you

[PATCH] drm/vc4: Deleted the drm_device declaration

2020-09-28 Thread Tian Tao
drm_modeset_lock.h already declares struct drm_device, so there's no need to declare it in vc4_drv.h Signed-off-by: Tian Tao --- drivers/gpu/drm/vc4/vc4_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 8c8d96b..8717a1c 1

[PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2020-09-28 Thread Tetsuo Handa
syzbot is reporting UAF/OOB read at bit_putcs()/soft_cursor() [1][2], for vt_resizex() from ioctl(VT_RESIZEX) allows setting font height larger than actual font height calculated by con_font_set() from ioctl(PIO_FONT). Since fbcon_set_font() from con_font_set() allocates minimal amount of memory ba

Re: [PATCH v2] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

2020-09-28 Thread Stephen Boyd
Quoting Abhinav Kumar (2020-09-25 19:55:12) > Fix the incorrect function prototype for dp_debug_get() > in the dp_debug module to address compilation warning. > Also add prototype for msm_dp_debugfs_init() for fixing compilation > issue with other defconfigs. > > changes in v2: > - add pro

  1   2   >