Re: [Intel-gfx][PATCH v2] drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid()

2020-09-10 Thread Zhenyu Wang
On 2020.09.08 20:11:21 +0200, Alejandro Sior wrote: > In the function intel_vgpu_reg_rw_edid of kvmgt.c, pos can be equal > to NULL for GPUs that do not properly support EDID. In those cases, when > pos gets passed to the handle_edid functions, it gets added a short offset > then it's dereferenced

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Joe Perches
On Thu, 2020-09-10 at 15:21 +0100, Robin Murphy wrote: > On 2020-09-09 21:06, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the next label is case or default and the

[Bug 209015] Clocks are no longer reported for R9 390 GPU

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209015 HenryJiM (henryjm11...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Deepak Rawat
On Thu, 2020-09-10 at 08:19 +, Tang, Shaofeng wrote: > Hi Deepak, > > Do you have a new version of this patch now? > I take a try with it. and meet some typo and “incompatible pointer” > error. > If you have a new version, could you share it with us? > Hi Shaofeng, It seems you are running

Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-10 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto > > > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto (snip) > Missing "iommus = <&ipmmu_vc0 16>;" (snip) > Missing "iommus = <&ipmmu_vi0

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Laurent Pinchart
Hi Morimoto-san, On Fri, Sep 11, 2020 at 08:20:56AM +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > > > Signed-off-by: Kuninori Morimoto

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto > > > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch was tested on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > > du: display@feb0 { > > +

RE: [PATCH v7 0/4] Add support for KeemBay DRM driver

2020-09-10 Thread Chrisanthus, Anitha
Hi Daniel, Thanks for your review. I have requested drm-next access here https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/291 Will address your comments in next emails. thanks, Anitha > -Original Message- > From: Daniel Vetter > Sent: Thursday, September 10, 2020 1:42 AM

Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-09-10 Thread Rob Clark
On Thu, Sep 10, 2020 at 3:00 PM Bjorn Andersson wrote: > > On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote: > > > From: Krishna Manikandan > > > > Move the bus clock to mdp device node,in order > > to facilitate bus band width scaling on sc7180 > > target. > > > > The parent device MDSS will not

Re: [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 16:55 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > > faci

Re: [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Lyude Paul
On Thu, 2020-09-10 at 17:46 +0300, Ville Syrjälä wrote: > On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > > - DPCD 1.0 -> as

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 2:07 p.m., Vitaly Prosyak wrote: On 2020-09-10 1:51 p.m., Laurent Pinchart wrote: Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Th

[PATCH v5 4/5] drm/msm/dp: signal the hotplug disconnect in the event handler

2020-09-10 Thread Abhinav Kumar
Signal the hotplug disconnect event to the audio side in the event handler so that they are notified earlier and have more time to process the disconnect event. Changes in v2: none Changes in v3: none Changes in v4: rebase on top of latest patchset of dependency Changes in v5: rebase on top of lat

[PATCH v5 2/5] drm/msm/dp: add audio support for Display Port on MSM

2020-09-10 Thread Abhinav Kumar
Introduce audio support for Display Port on MSM chipsets. This change integrates DP audio sub-module with the main Display Port platform driver. In addition, this change leverages hdmi_codec_ops to expose the operations to the audio driver. Changes in v2: fix up a compilation issue on drm-next br

[PATCH v5 5/5] drm/msm/dp: wait for audio notification before disabling clocks

2020-09-10 Thread Abhinav Kumar
In the current implementation, there is a very small window for the audio side to safely signal the hdmi_code_shutdown() before the clocks are disabled. Add some synchronization between the DP display and DP audio module to safely disable the clocks to avoid unclocked access from audio side. In a

[PATCH v5 1/5] drm/msm/dp: store dp_display in the driver data

2020-09-10 Thread Abhinav Kumar
Store the dp_display in the platform driver data instead of the dp_display_private. This is required to allow other sub-modules to reuse the platform driver data. Changes in v3: none Changes in v4: none Changes in v5: none Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c |

[PATCH v5 3/5] drm/msm/dp: add hook_plugged_cb hdmi-codec op for MSM DP driver

2020-09-10 Thread Abhinav Kumar
Add the hook_plugged_cb op for the MSM DP driver to signal connect and disconnect events to the hdmi-codec driver which in-turn shall notify the audio subsystem to start a new or teardown an existing session. Changes in v2: none Changes in v3: none Changes in v4: rebase on top of latest patchset o

[PATCH v5 0/5] Add audio support for MSM DisplayPort driver

2020-09-10 Thread Abhinav Kumar
This series adds audio support for DP on MSM chipsets. It leverages the hdmi-codec interface [1] to communicate between the Display Port driver and the audio subsystem. These changes depend on the series [2] which adds Display Port support to MSM chipsets. [1] https://patchwork.kernel.org/project/

Re: [PATCH 4/4] drm/ttm: nuke memory type flags

2020-09-10 Thread Dave Airlie
I like it, For all 4, Reviewed-by: Dave Airlie On Thu, 10 Sep 2020 at 21:49, Christian König wrote: > > It's not supported to specify more than one of those flags. > So it never made sense to make this a flag in the first place. > > Nuke the flags and specify directly which memory type to use.

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-09-10 Thread Sam Ravnborg
Hi Laurentiu > > > I've tested this together with a hacked up eDP bridge driver stack on > > > my boards. The testing hasn't been really in-depth, but things seem to > > > work fine. I have now pushed the whole series into drm-misc-next. > > > > Something doesn't compile too well > > > > ERROR:

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Sam Ravnborg
Hi Daniel. > > + } > > + > > + /* Initialize MIPI DSI */ > > + ret = kmb_dsi_init(drm, adv_bridge); > > Split up isn't correct here, this won't compile since the dsi code isn't > in this patch yet. So you need to have this ordered the other way round. I have explicit asked for a simple fil

Re: [PATCH v4] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-09-10 Thread Sam Ravnborg
Hi Paul. On Wed, Sep 09, 2020 at 03:26:52PM +0200, Paul Cercueil wrote: > Any love for my patch? I have more pending :) I have looked through the patch a few times. And I did not find any spelling errors. But the memory magic was beyond me so I hope someone more knowledgeable can chime in here.

RE: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-10 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Daniel Vetter > Sent: Monday, September 7, 2020 3:15 AM > To: Jan Kiszka ; amd-gfx list g...@lists.freedesktop.org>; Wentland, Harry ; > Kazlauskas, Nicholas > Cc: dri-devel ; intel-gfx g...@lists.freedesktop.org>;

Re: [PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'

2020-09-10 Thread Hyun Kwon
Hi Jason, On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning: > ‘scaling_factors_666’ defined but not used [-Wunused-const-variable=] > 245 | static const u32 scaling_facto

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 1:51 p.m., Laurent Pinchart wrote: Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrot

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: > On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: > > On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > >> On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: > >>> On Thu, Sep 10, 2020 at 11:50:26AM

Re: [PATCH] V2: Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and get the slower speed even the mst hub can run in the faster speed.

2020-09-10 Thread Lyude Paul
The commit message should be shorter and follow the format other commits for drm usually do, in this case something like: drm/dp_mst: Retrieve extended DPCD caps for topology manager On Thu, 2020-09-10 at 14:36 +0800, Koba Ko wrote: > As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRES

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Vitaly Prosyak
On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: Hi Pekka, On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: On Thu, 10 Sep 2020 09:52:26 +0200 Daniel Vette

[Bug 209225] [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 Arthur Borsboom (arthurborsb...@gmail.com) changed: What|Removed |Added See Also||https://bugzi

[Bug 209225] [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 --- Comment #1 from Arthur Borsboom (arthurborsb...@gmail.com) --- Possibly related to this fix: https://bugzilla.kernel.org/show_bug.cgi?id=203905 If I looked well at kernel.org, it seemed that this fix is included in kernel 5.7.8 (the one in t

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/am

[Bug 209091] i915: drm:fw_domains_get [i915] *ERROR* render: timed out waiting for forcewake ack request.

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209091 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Status|NEW |RESOLVED Re

Re: [PATCH v2 07/18] drm/dp: Pimp drm_dp_downstream_max_bpc()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 01:51:56PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Deal with more cases in drm_dp_downstream_max_bpc(): > > - DPCD 1.0 -> assume 8bpc for non-DP > > - DPCD 1.1+ DP (or DP++ with DP sink) -> allow an

[Bug 209225] New: [AMDGPU] oops each boot: dc_link_set_backlight_level

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209225 Bug ID: 209225 Summary: [AMDGPU] oops each boot: dc_link_set_backlight_level Product: Drivers Version: 2.5 Kernel Version: 5.8.7, 5.8.8 Hardware: x86-64 OS: Linux

Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'

2020-09-10 Thread Gustavo A. R. Silva
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res". > Return "0" on line 1450 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Acked-by: Gustavo A. R. Silva Tha

Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-10 Thread Felix Kuehling
Am 2020-09-10 um 3:50 a.m. schrieb YueHaibing: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_device_info = {

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Robin Murphy
On 2020-09-09 21:06, Joe Perches wrote: fallthrough to a separate case/default label break; isn't very readable. Convert pseudo-keyword fallthrough; statements to a simple break; when the next label is case or default and the only statement in the next label block is break; Found using: $ grep

Re: [PATCH v2 10/18] drm/dp: Add drm_dp_downstream_{min,max}_tmds_clock()

2020-09-10 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 02:08:17PM -0400, Lyude Paul wrote: > On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add helpers to get the TMDS clock limits for HDMI/DVI downstream > > facing ports. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/

Re: [PATCH] drm/panfrost: Ensure GPU quirks are always initialised

2020-09-10 Thread Steven Price
On 09/09/2020 13:29, Steven Price wrote: The GPU 'CONFIG' registers used to work around hardware issues are cleared on reset so need to be programmed every time the GPU is reset. However panfrost_device_reset() failed to do this. To avoid this in future instead move the call to panfrost_gpu_init

Re: [PATCH] drm/panfrost: Set DMA max segment size

2020-09-10 Thread Steven Price
On 03/09/2020 14:59, Robin Murphy wrote: Since all we do with scatterlists is map them in the MMU, we don't have any hardware constraints on how they're laid out. Let the DMA layer know so it won't warn when DMA API debugging is enabled. Signed-off-by: Robin Murphy Applied to drm-misc-next S

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

2020-09-10 Thread Ezequiel Garcia
On Thu, 10 Sep 2020 at 04:54, H. Nikolaus Schaller wrote: > > Hi Ezequiel, > > > Am 27.08.2020 um 09:21 schrieb H. Nikolaus Schaller : > > > > Hi Ezequiel, > > > >> Am 24.08.2020 um 19:38 schrieb Ezequiel Garcia > >> : > >> > >> On Mon, 24 Aug 2020 at 13:05, H. Nikolaus Schaller > >> wrote: > >

[PATCH 4/4] drm/ttm: nuke memory type flags

2020-09-10 Thread Christian König
It's not supported to specify more than one of those flags. So it never made sense to make this a flag in the first place. Nuke the flags and specify directly which memory type to use. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 24 +++--- drivers/gpu/drm/amd

[PATCH 2/4] drm/nouveau: stop using TTM placement flags

2020-09-10 Thread Christian König
Those are going to be removed, stop using them here. Instead use the GEM flags from the UAPI. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv04/crtc.c| 9 ++- drivers/gpu/drm/nouveau/dispnv04/disp.c| 5 +- drivers/gpu/drm/nouveau/dispnv04/overlay.c | 4 +- drivers/g

[PATCH 1/4] drm/vram-helper: stop using TTM placement flags

2020-09-10 Thread Christian König
Those are going to be removed, stop using them here. Instead define separate flags for the helper. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 14 +- include/drm/drm_gem_vram_helper.h | 7 +++ 2 files changed, 12 insertions(+), 9 deletions(-)

[PATCH 3/4] drm/vmwgfx: stop setting multiple domain flags

2020-09-10 Thread Christian König
Setting more than one placement flag is illegal. Fix this by using the current flags. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Ville Syrjälä
On Thu, Sep 10, 2020 at 10:18:36AM +0200, Daniel Vetter wrote: > On Thu, Sep 10, 2020 at 07:50:59AM +, Simon Ser wrote: > > On Wednesday, September 9, 2020 12:57 PM, Laurentiu Palcu > > wrote: > > > > > Hi all, > > > > > > I was wondering whether you could give me an advise on how to proceed

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-10 Thread Geert Uytterhoeven
Hi Kieran, On Thu, Sep 10, 2020 at 12:34 PM Kieran Bingham wrote: > On 10/09/2020 10:44, Geert Uytterhoeven wrote: > > On Mon, Sep 7, 2020 at 5:55 PM Kieran Bingham > > wrote: > >> On 07/09/2020 03:59, Kuninori Morimoto wrote: > >>> From: Kuninori Morimoto > >>> > >>> This patch adds VSP device

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
Hi Pekka, On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: > > On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > > > On Thu, 10 Sep 2020 09:52:26 +0200 Daniel Vetter wrote: > > > > On Thu, Sep 10, 2020 at 10

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
Hi Pekka, On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > On Thu, 10 Sep 2020 09:52:26 +0200 Daniel Vetter wrote: > > > On Thu, Sep 10, 2020 at 10:25:43AM +0300, Pekka Paalanen wrote: > > > On Wed, 9 Sep 2020 13:57:28 +0300 Laurentiu Palcu wrote: > > > > > > > Hi all, > > > >

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurentiu Palcu
Hi Pekka, On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > On Thu, 10 Sep 2020 12:30:09 +0300 > Laurentiu Palcu wrote: > > > Hi Pekka, > > > > On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > > > On Thu, 10 Sep 2020 09:52:26 +0200 > > > Daniel Vetter wrote: >

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-10 Thread Kieran Bingham
Hi Geert, On 10/09/2020 10:44, Geert Uytterhoeven wrote: > Hi Kieran, > > On Mon, Sep 7, 2020 at 5:55 PM Kieran Bingham > wrote: >> On 07/09/2020 03:59, Kuninori Morimoto wrote: >>> From: Kuninori Morimoto >>> >>> This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. >>> This patch i

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Pekka Paalanen
On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: > Hi Pekka, > > On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > > On Thu, 10 Sep 2020 09:52:26 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Sep 10, 2020 at 10:25:43AM +0300, Pekka Paalanen wrote: > > > > On Wed

Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit

2020-09-10 Thread Laurentiu Palcu
Hi Lucas, On Thu, Sep 10, 2020 at 12:24:44PM +0200, Lucas Stach wrote: > On Do, 2020-09-10 at 13:21 +0300, Laurentiu Palcu wrote: > > On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote: > > > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu > > > wrote: > > > > When compiling for 32bit

Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit

2020-09-10 Thread Lucas Stach
On Do, 2020-09-10 at 13:21 +0300, Laurentiu Palcu wrote: > On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote: > > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu > > wrote: > > > When compiling for 32bit platforms, the compilation fails with: > > > > > > ERROR: modpost: "__aeabi_ldiv

Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit

2020-09-10 Thread Laurentiu Palcu
On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote: > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu > wrote: > > > > When compiling for 32bit platforms, the compilation fails with: > > > > ERROR: modpost: "__aeabi_ldivmod" > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! > > ERR

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Matthias Brugger
On 09/09/2020 22:06, Joe Perches wrote: diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c index 09f931d4598c..778be26d329f 100644 --- a/drivers/net/wireless/mediatek/mt7601u/dma.c +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c @@ -193,11

[PATCH][next] drm/i915: Fix inconsistent IS_ERR and PTR_ERR

2020-09-10 Thread Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in i915_gem_object_copy_blt(). The proper pointer to be passed as argument to PTR_ERR() is vma[1]. This bug was detected with the help of Coccinelle. Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.") Signed-

[PATCH] drm/vc4: hdmi: Fix NULL vs IS_ERR() checks in vc5_hdmi_init_resources()

2020-09-10 Thread Dan Carpenter
The devm_ioremap() function never returns error pointers, it returns NULL. Fixes: 8323989140f3 ("drm/vc4: hdmi: Support the BCM2711 HDMI controllers") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vc4/vc4_hdmi.c | 32 1 file changed, 16 insertions(+), 16 delet

[PATCH] drm/vc4: hdmi: Fix off by ones in vc4_hdmi_read/write()

2020-09-10 Thread Dan Carpenter
The variant->registers[] has ->num_registers elements so the > comparison needs to be changes to >= to prevent an out of bounds access. Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 4 ++-- 1

Re: [PATCH] drm/imx/dcss: fix compilation issue on 32bit

2020-09-10 Thread Daniel Vetter
On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu wrote: > > When compiling for 32bit platforms, the compilation fails with: > > ERROR: modpost: "__aeabi_ldivmod" > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! > ERROR: modpost: "__aeabi_uldivmod" > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefi

Re: [PATCH v2 09/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Display support

2020-09-10 Thread Geert Uytterhoeven
On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch enables HDMI Display on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

[PATCH] drm/imx/dcss: fix compilation issue on 32bit

2020-09-10 Thread Laurentiu Palcu
When compiling for 32bit platforms, the compilation fails with: ERROR: modpost: "__aeabi_ldivmod" [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! This patch adds a dependency on ARM64 since no 32bit SoCs have D

Re: [PATCH v2 08/10] arm64: dts: renesas: r8a77961: Add HDMI device nodes

2020-09-10 Thread Geert Uytterhoeven
On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds HDMI device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven Gr{oetje,eetin

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Geert Uytterhoeven
Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto > --- > arch/arm64/boot/dts/rene

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Geert Uytterhoeven
On Tue, Sep 8, 2020 at 2:35 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}

Re: [PATCH v10 30/30] videobuf2: use sgtable-based scatterlist wrappers

2020-09-10 Thread Tomasz Figa
On Thu, Sep 10, 2020 at 11:17 AM Hans Verkuil wrote: > > On 04/09/2020 15:17, Marek Szyprowski wrote: > > Use recently introduced common wrappers operating directly on the struct > > sg_table objects and scatterlist page iterators to make the code a bit > > more compact, robust, easier to follow a

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-10 Thread Geert Uytterhoeven
Hi Kieran, On Mon, Sep 7, 2020 at 5:55 PM Kieran Bingham wrote: > On 07/09/2020 03:59, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > > > This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch is test on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kun

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-10 Thread Geert Uytterhoeven
On Mon, Sep 7, 2020 at 4:59 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch is test on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-10 Thread Geert Uytterhoeven
Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto > --- a/arch/arm64/boot/dts/ren

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Neil Armstrong
On 31/08/2020 22:02, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> ADV bridge > > Only 10

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurentiu Palcu
Hi Pekka, On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > On Thu, 10 Sep 2020 09:52:26 +0200 > Daniel Vetter wrote: > > > On Thu, Sep 10, 2020 at 10:25:43AM +0300, Pekka Paalanen wrote: > > > On Wed, 9 Sep 2020 13:57:28 +0300 > > > Laurentiu Palcu wrote: > > > > > > > Hi al

[RFC PATCH 2/3] drm/atomic-helper: add REQUIRE_MATCHING_FB flag

2020-09-10 Thread Stefan Agner
Add flag which checks that the framebuffer size matches the plane size exactly. This is useful for display controller which can't handle framebuffers other than the plane/CRTC size. Signed-off-by: Stefan Agner --- drivers/gpu/drm/drm_atomic_helper.c | 7 +++ drivers/gpu/drm/sel

[RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-10 Thread Stefan Agner
To improve readability and make it easier to add further optional checks replace the boolean parameters with a single flag bitfield as parameter of drm_atomic_helper_check_plane_state. The regular call sites have been converted using a simple coccinelle patch. virtual patch @@ expression e1, e2,

[RFC PATCH 3/3] drm: mxsfb: enforce framebuffer size matches plane size

2020-09-10 Thread Stefan Agner
The plane size must match the CRTC already (enforced by not setting the CAN_POSTION flag). However, the controller also requires the framebuffer to be exactly the CRTC size. Make use of the new flag DRM_PLANE_REQUIRE_MATCHING_FB to match the plane size. Signed-off-by: Stefan Agner --- drivers/gp

Re: [PATCH v10 29/30] media: pci: fix common ALSA DMA-mapping related codes

2020-09-10 Thread Hans Verkuil
On 04/09/2020 15:17, Marek Szyprowski wrote: > The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the > numer of the created entries in the DMA address space. However the numer -> number > subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be > called with the

Re: [PATCH v10 30/30] videobuf2: use sgtable-based scatterlist wrappers

2020-09-10 Thread Hans Verkuil
On 04/09/2020 15:17, Marek Szyprowski wrote: > Use recently introduced common wrappers operating directly on the struct > sg_table objects and scatterlist page iterators to make the code a bit > more compact, robust, easier to follow and copy/paste safe. > > No functional change, because the code

Re: [PATCH] drm/mm: prevent a potential null-pointer dereference

2020-09-10 Thread Christian König
Am 10.09.20 um 04:38 schrieb Jing Xiangfeng: The macro 'DECLARE_NEXT_HOLE_ADDR' may hit a potential null-pointer dereference. So use 'entry' after checking it. I don't see a potential null-pointer dereference here. Where should that be? Christian. Fixes: 5fad79fd66ff ("drm/mm: cleanup and

Re: [PATCH -next] drm/ttm/agp: Fix Wunused-variable warning

2020-09-10 Thread Christian König
Am 10.09.20 um 04:33 schrieb YueHaibing: If CONFIG_AGP is not set, gcc warns: drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_ttm_tt_bind’: drivers/gpu/drm/radeon/radeon_ttm.c:692:24: warning: unused variable ‘rdev’ [-Wunused-variable] struct radeon_device *rdev = radeon_get_rdev(bd

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Pekka Paalanen
On Thu, 10 Sep 2020 09:52:26 +0200 Daniel Vetter wrote: > On Thu, Sep 10, 2020 at 10:25:43AM +0300, Pekka Paalanen wrote: > > On Wed, 9 Sep 2020 13:57:28 +0300 > > Laurentiu Palcu wrote: > > > > > Hi all, > > > > > > I was wondering whether you could give me an advise on how to proceed > >

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Felipe Balbi
Hi, Joe Perches writes: > drivers/usb/dwc3/core.c | 2 +- > drivers/usb/gadget/legacy/inode.c | 2 +- > drivers/usb/gadget/udc/pxa25x_udc.c | 4 ++-- > drivers/usb/phy/phy-fsl-usb.c |

Re: [PATCH v7 0/4] Add support for KeemBay DRM driver

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:48PM -0700, Anitha Chrisanthus wrote: > This is a new DRM driver for Intel's KeemBay SOC. > The SoC couples an ARM Cortex A53 CPU with an Intel > Movidius VPU. > > This driver is tested with the KMB EVM board which is the refernce baord > for Keem Bay SOC. The SOC's d

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> AD

[Bug 209163] amdgpu: The CS has been cancelled because the context is lost

2020-09-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209163 --- Comment #9 from Christian König (christian.koe...@amd.com) --- Try amdgpu.vramlimit=512 on the kernel command line to limit the available VRAM to 512MB. The problem is certainly some kind of memory leak. You need to test an up to date kernel

Re: [PATCH v7 3/4] drm/kmb: Mipi DSI part of the display driver

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:51PM -0700, Anitha Chrisanthus wrote: > Initializes Mipi DSI and sets up connects to ADV bridge > > v2: removed license text > upclassed dev_private, removed HAVE_IRQ. (Sam) > > v3: Squashed all 59 commits to one > > v4: review changes from Sam Ravnborg >

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Daniel Vetter
On Mon, Aug 31, 2020 at 01:02:50PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->mipi DSI-> AD

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Simon Ser
On Thursday, September 10, 2020 10:18 AM, Daniel Vetter wrote: > On Thu, Sep 10, 2020 at 07:50:59AM +, Simon Ser wrote: > > > On Wednesday, September 9, 2020 12:57 PM, Laurentiu Palcu > > laurentiu.pa...@oss.nxp.com wrote: > > > > > Hi all, > > > I was wondering whether you could give me an

Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2020-09-10 Thread Tang, Shaofeng
Hi Deepak, Do you have a new version of this patch now? I take a try with it. and meet some typo and "incompatible pointer" error. If you have a new version, could you share it with us? BR, Shaofeng ___ dri-devel mailing list dri-devel@lists.freedesktop

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Daniel Vetter
On Thu, Sep 10, 2020 at 07:50:59AM +, Simon Ser wrote: > On Wednesday, September 9, 2020 12:57 PM, Laurentiu Palcu > wrote: > > > Hi all, > > > > I was wondering whether you could give me an advise on how to proceed > > further > > with the following issue as I'm preparing to upstream the n

[PULL] scatterlists related fixes

2020-09-10 Thread Marek Szyprowski
Hi Dave & Daniel, Please pull a set of fixes for various DRM drivers that finally resolve incorrect usage of the scatterlists (struct sg_table nents and orig_nents entries), what causes issues when IOMMU is used. Best regards Marek Szyprowski, PhD Samsung R&D Institute Poland The following chan

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-09-10 Thread Laurentiu Palcu
Hi Daniel, On Thu, Sep 10, 2020 at 08:47:34AM +0200, Daniel Vetter wrote: > On Wed, Sep 9, 2020 at 5:03 PM Lucas Stach wrote: > > > > Hi Laurentiu, > > > > On Mo, 2020-08-31 at 14:24 +0300, Laurentiu Palcu wrote: > > > Hi Lucas, Sam, > > > > > > On Mon, Aug 31, 2020 at 12:37:23PM +0200, Lucas Sta

Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-10 Thread Huang Rui
On Thu, Sep 10, 2020 at 03:50:06PM +0800, YueHaibing wrote: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_de

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Daniel Vetter
On Thu, Sep 10, 2020 at 10:25:43AM +0300, Pekka Paalanen wrote: > On Wed, 9 Sep 2020 13:57:28 +0300 > Laurentiu Palcu wrote: > > > Hi all, > > > > I was wondering whether you could give me an advise on how to proceed > > further > > with the following issue as I'm preparing to upstream the next

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Simon Ser
On Wednesday, September 9, 2020 12:57 PM, Laurentiu Palcu wrote: > Hi all, > > I was wondering whether you could give me an advise on how to proceed further > with the following issue as I'm preparing to upstream the next set of patches > for the iMX8MQ display controller(DCSS). The display cont

[PULL] drm-intel-fixes

2020-09-10 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2020-09-10: drm/i915 fixes for v5.9-rc5: - Fix regression leading to audio probe failure BR, Jani. The following changes since commit f4d51dffc6c01a9e94650d95ce0104964f8ae822: Linux 5.9-rc4 (2020-09-06 17:11:40 -0700) are available in the Git repository a

Re: [PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation

2020-09-10 Thread Daniel Vetter
On Wed, Sep 09, 2020 at 05:03:37PM +0200, Daniel Vetter wrote: > On Wed, Sep 9, 2020 at 4:45 PM Daniel Thompson > wrote: > > > > On Mon, Sep 07, 2020 at 09:50:18AM +0200, Daniel Vetter wrote: > > > On Fri, Sep 04, 2020 at 12:38:22PM +0100, Daniel Thompson wrote: > > > > On Mon, Jul 20, 2020 at 09:

Re: [PATCH -next] drm/amdkfd: Fix -Wunused-const-variable warning

2020-09-10 Thread Huang Rui
On Thu, Sep 10, 2020 at 10:55:32AM +0800, YueHaibing wrote: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: > ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_de

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Pekka Paalanen
On Wed, 9 Sep 2020 13:57:28 +0300 Laurentiu Palcu wrote: > Hi all, > > I was wondering whether you could give me an advise on how to proceed further > with the following issue as I'm preparing to upstream the next set of patches > for the iMX8MQ display controller(DCSS). The display controller h

[PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread YueHaibing
If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [PATCH v5 27/36] memory: tegra-mc: Register as interconnect provider

2020-09-10 Thread Georgi Djakov
On 8/14/20 03:06, Dmitry Osipenko wrote: > Now memory controller is a memory interconnection provider. This allows us > to use interconnect API in order to change memory configuration. > > Signed-off-by: Dmitry Osipenko Thanks Dmitry! Looks good to me. Acked-by: Georgi Djakov _

  1   2   >