Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-04 Thread Roger Pau Monné
On Fri, Sep 04, 2020 at 09:00:18AM +0200, Jürgen Groß wrote: > On 03.09.20 18:38, Roger Pau Monné wrote: > > On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: > > > On 01.09.20 10:33, Roger Pau Monne wrote: > > > > To be used in order to create foreign mappings. This is based on the > >

[PATCH v6 3/4] arm: dts: mt7623: add display subsystem related device nodes

2020-09-04 Thread Frank Wunderlich
From: Ryder Lee Add display subsystem related device nodes for MT7623. Cc: Chun-Kuang Hu Signed-off-by: chunhui dai Signed-off-by: Bibby Hsieh Signed-off-by: Ryder Lee Signed-off-by: Frank Wunderlich Tested-by: Frank Wunderlich --- changed v5->v6: change compatible of hdmi-node because o

[PATCH]] drm/dp check aux_dev before use in drm_dp_aux_dev_get_by_minor()

2020-09-04 Thread Zwane Mwaikambo
I observed this when unplugging a DP monitor whilst a computer is asleep and then waking it up. This left DP chardev nodes still being present on the filesystem and accessing these device nodes caused an oops because drm_dp_aux_dev_get_by_minor() assumes a device exists if it is opened. This ca

Re: [PATCH v16 20/20] arm: dts: qcom: sc7180: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Rob Clark > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- > arch/arm64/boot/dts/qcom/

Re: [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header

2020-09-04 Thread Joerg Roedel
On Fri, Aug 28, 2020 at 07:12:11PM +0300, Andy Shevchenko wrote: > Static analyzer is not happy about intel_iommu_gfx_mapped declaration: > > .../drivers/iommu/intel/iommu.c:364:5: warning: symbol > 'intel_iommu_gfx_mapped' was not declared. Should it be static? > > Move its declaration to Intel

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-04 Thread Jian-Hong Pan
Hi Maxime, Thanks for version 5 patch series! I applied it based on linux-next tag next-20200828 and build it with the config [1] to test on RPi 4 However, It fails to get HDMI state machine clock and pixel bcb clock. Then, vc4-drm probes failed. Full dmseg [2]: [2.552675] [drm:vc5_hdmi_init

Re: [PATCH v16 19/20] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson

Re: [git pull] drm fixes for 5.9-rc4

2020-09-04 Thread Harald Arnesen
Linus Torvalds [04.09.2020 21:02]: > On Thu, Sep 3, 2020 at 8:53 PM Dave Airlie wrote: >> >> Not much going on this week, nouveau has a display hw bug workaround, >> amdgpu has some PM fixes and CIK regression fixes, one single radeon >> PLL fix, and a couple of i915 display fixes. > > Any movem

Re: [PATCH v2 (resend)] video: fbdev: fix OOB read in vga_8planes_imageblit()

2020-09-04 Thread Tetsuo Handa
Hello, Greg. Since nobody is interested in this bug, can you directly pick up this obvious patch without waiting for maintainer's response? On 2020/08/31 19:37, Tetsuo Handa wrote: > syzbot is reporting OOB read at vga_8planes_imageblit() [1], for > "cdat[y] >> 4" can become a negative value due

Re: [PATCH] drm/sun4i: Fix DE2 YVU handling

2020-09-04 Thread Maxime Ripard
On Wed, Sep 02, 2020 at 12:03:05AM +0200, Jernej Skrabec wrote: > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode > but due to inproper return type (bool instead of u32) it returns just 0 > or 1. Colors are wrong for YVU formats because of that. > > Fixes: daab3d0e8e2b ("drm/

[PATCH v6 1/4] drm/mediatek: disable tmds on mt2701

2020-09-04 Thread Frank Wunderlich
From: chunhui dai Without that patch if you use specific resolutions like 1280x1024, I can see distortion in the output. It seems as if the frequency for updating the pixel of the image is out of sync. For initialization tmds needs to be active, but can be disabled after init to fix blurry displ

[PATCH 2/3] drm/msm/dsi: add DSI config for sm8150 and sm8250

2020-09-04 Thread Jonathan Marek
This allows DSI driver to work with sm8150 and sm8250. The sdm845 config is re-used as the config is the same. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 5 - drivers/gpu/drm/msm/dsi/dsi_cfg.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 0/3] drm/msm/dsi: support SM8150 and SM8250

2020-09-04 Thread Jonathan Marek
Add support for SM8150 and SM8250 DSI. Note I haven't tested SM8150 recently, but DSI is almost identical to SM8250. Jonathan Marek (3): drm/msm/dsi: remove unused clk_pre/clk_post in msm_dsi_dphy_timing drm/msm/dsi: add DSI config for sm8150 and sm8250 drm/msm/dsi: add support for 7nm DSI

Re: [PATCH 1/2] drm/sun4i: backend: Support alpha property on lowest plane

2020-09-04 Thread Maxime Ripard
On Sat, Aug 29, 2020 at 02:56:58PM +0800, Chen-Yu Tsai wrote: > On Tue, Jul 28, 2020 at 9:48 PM Maxime Ripard wrote: > > > > Unlike what we previously thought, only the per-pixel alpha is broken on > > the lowest plane and the per-plane alpha isn't. Remove the check on the > > alpha property being

[PATCH 1/3] drm/msm/dsi: remove unused clk_pre/clk_post in msm_dsi_dphy_timing

2020-09-04 Thread Jonathan Marek
The clk_pre/clk_post values in shared_timings are used instead, and these are unused. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h index

[PATCH v5] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-09-04 Thread Kuogee Hsieh
add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done successfully. Changes in v2: - Fix potential deadlock by removing redundant connect_mutex - C

Re: [PATCH] drm: xlnx: fix build warning & errors when DMADEVICES is not set

2020-09-04 Thread Randy Dunlap
On 9/3/20 9:41 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kconfig warnings & build errors caused by DRM_ZYNQMP_DPSUB. > > Any driver that selects DMA_ENGINE should make sure that > DMADEVICES is already enabled. > As is, this causes build errors in many other drivers. > > See https://

Aw: Re: [PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-09-04 Thread Frank Wunderlich
Tested-By: Frank Wunderlich regards Frank ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/3] drm/msm/dsi: add support for 7nm DSI PHY/PLL

2020-09-04 Thread Jonathan Marek
This adds support for the 7nm ("V4") DSI PHY/PLL for sm8150 and sm8250. Implementation is based on 10nm driver, but updated based on the downstream 7nm driver. Signed-off-by: Jonathan Marek --- .../devicetree/bindings/display/msm/dsi.txt | 6 +- drivers/gpu/drm/msm/Kconfig

Re: [PATCH v16 14/20] iommu/arm-smmu: Prepare for the adreno-smmu implementation

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Do a bit of prep work to add the upcoming adreno-smmu implementation. > > Add an hook to allow the implementation to choose which context banks > to allocate. > > Move some of the common structs to arm-smmu.h in anticipat

[PATCH v6 0/4] make hdmi work on bananapi-r2

2020-09-04 Thread Frank Wunderlich
From: Frank Wunderlich This Patch-Series adds missing Patches/Bugfixes to get hdmi working on BPI-R2 v5->v6: - drop parts already merged to mediatek-drm-next - include lima-regulator-patch - rebase on changes in mediatek-drm-next tree (hdmi/hdmi-phy patches) - fix compatible of hdmi0 because

[PATCH v6 4/4] arm: dts: mt7623: add lima related regulator

2020-09-04 Thread Frank Wunderlich
From: Alex Ryabchenko GPU needs additional regulator, add it to devicetree of bpi-r2 Signed-off-by: Alex Ryabchenko Signed-off-by: Frank Wunderlich --- arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v6 2/4] arm: dts: mt7623: move display nodes to separate mt7623n.dtsi

2020-09-04 Thread Frank Wunderlich
From: Frank Wunderlich mt7623a has no graphics support so move nodes from generic mt7623.dtsi to mt7623n.dtsi Fixes: 1f6ed224594 ("arm: dts: mt7623: add Mali-450 device node") Suggested-by: David Woodhouse Signed-off-by: Frank Wunderlich --- arch/arm/boot/dts/mt7623.dtsi | 123

Re: [PATCH 00/20] iommu/arm-smmu + drm/msm: per-process GPU pgtables

2020-09-04 Thread Joerg Roedel
On Mon, Aug 17, 2020 at 03:01:25PM -0700, Rob Clark wrote: > Jordan Crouse (12): > iommu/arm-smmu: Pass io-pgtable config to implementation specific > function > iommu/arm-smmu: Add support for split pagetables > iommu/arm-smmu: Prepare for the adreno-smmu implementation > iommu/arm-smm

Re: [PATCH v6 1/3] drm/vkms: Decouple crc operations from composer

2020-09-04 Thread Melissa Wen
Hi, On 08/30, Rodrigo Siqueira wrote: > In the vkms_composer.c, some of the functions related to CRC and compose > have interdependence between each other. This patch reworks some > functions inside vkms_composer to make crc and composer computation > decoupled. > > This patch is preparation work

[pull] drm/msm: drm-msm-fixes-2020-09-04

2020-09-04 Thread Rob Clark
Hi Dave, A few fixes for a potential RPTR corruption issue. The following changes since commit 5e0c22d4a9ddae4e784a3e171b9d3d452b37aeb2: drm/msm/a6xx: fix frequency not always being restored on GMU resume (2020-08-22 10:56:45 -0700) are available in the Git repository at: https://gitlab.fr

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

2020-09-04 Thread Joe Perches
On Fri, 2020-09-04 at 12:42 +0100, Kieran Bingham wrote: > I'm pleased to see this is treewide ;-) > Definitely prefer this. These are only the comma uses in if/do/while blocks that would also need braces as separate statements. There a multiple dozens more just with single statements terminated

Re: [PATCH v6 2/3] drm/vkms: Compute CRC without change input data

2020-09-04 Thread Melissa Wen
On 08/30, Rodrigo Siqueira wrote: > The compute_crc() function is responsible for calculating the > framebuffer CRC value; due to the XRGB format, this function has to > ignore the alpha channel during the CRC computation. Therefore, > compute_crc() set zero to the alpha channel directly in the inp

Re: [git pull] drm fixes for 5.9-rc4

2020-09-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Sep 2020 13:52:56 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-09-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cf85f5de83b19361c3d575fa0ea05d8194bb0d05 Thank you! -- Deet-doot-dot, I am a bot. https://ko

[PATCH v5 2/2] drm/nouveau/kms/nv50-: Log SOR/PIOR caps

2020-09-04 Thread Lyude Paul
Since I'm almost certain I didn't get capability checking right for pre-volta chipsets, let's start logging any caps we find to make things like this obvious in the future. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++ 1 file changed, 10 insertions(+) di

[PATCH v5 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-09-04 Thread Lyude Paul
Not entirely sure why this never came up when I originally tested this (maybe some BIOSes already have this setup?) but the ->caps_init vfunc appears to cause the display engine to throw an exception on driver init, at least on my ThinkPad P72: nouveau :01:00.0: disp: chid 0 mthd 008c data 000

Re: [PATCH v2 00/18] drm/i915: Pimp DP DFP handling

2020-09-04 Thread Lyude Paul
Will try to look at this today, if I don't have the time though I'll definitely have the time on Tuesday On Fri, 2020-09-04 at 14:53 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Attempt to deal with DP downstream facing ports (DFP) more > thoroughly. This involves reading more of the po

Re: [git pull] drm fixes for 5.9-rc4

2020-09-04 Thread Linus Torvalds
On Thu, Sep 3, 2020 at 8:53 PM Dave Airlie wrote: > > Not much going on this week, nouveau has a display hw bug workaround, > amdgpu has some PM fixes and CIK regression fixes, one single radeon > PLL fix, and a couple of i915 display fixes. Any movement on the i915 relocation issue? I've only se

[PATCH] udmabuf: Add missing compact_ioctl

2020-09-04 Thread Kristian H. Kristensen
From: "Kristian H. Kristensen" Make sure we can use this on mixed systems. Signed-off-by: Kristian H. Kristensen --- drivers/dma-buf/udmabuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 9635897458a0..6f4ff6ede050 100644 --

Re: [PULL] topic/nouveau-i915-dp-helpers-and-cleanup

2020-09-04 Thread Lyude Paul
On Fri, 2020-09-04 at 09:24 -0400, Rodrigo Vivi wrote: > On Mon, Aug 31, 2020 at 07:38:57PM -0400, Lyude Paul wrote: > > topic/nouveau-i915-dp-helpers-and-cleanup-2020-08-31-1: > > UAPI Changes: > > > > None > > > > Cross-subsystem Changes: > > > > * Moves a bunch of miscellaneous DP code from t

[PATCH 3/3] drm/panel: simple: Add YTC700TLAG-05-201C

2020-09-04 Thread Jagan Teki
Add panel timings for YTC700TLAG-05-201C 7" TFT LCD panel from Yes Optoelectronics Co.,Ltd. Signed-off-by: Jagan Teki --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm

[PATCH 2/3] dt-bindings: display: simple: Add YTC700TLAG-05-201C

2020-09-04 Thread Jagan Teki
Add dt-bindings for YTC700TLAG-05-201C 7" TFT LCD panel from Yes Optoelectronics Co.,Ltd. Signed-off-by: Jagan Teki --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH 1/3] dt-bindings: vendor-prefixes: Add Yes Optoelectronics

2020-09-04 Thread Jagan Teki
Add vendor dt-bindings for Yes Optoelectronics Co.,Ltd. Signed-off-by: Jagan Teki --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-pr

Re: [PATCH 0/5] Add new features to nwl-dsi driver

2020-09-04 Thread Guido Günther
Hi Robert, On Fri, Aug 28, 2020 at 02:13:27PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > This patch-set adds the new following features to the nwl-dsi bridge driver: > > 1. Control Video PLL from nwl-dsi driver > > Add support for the Video PLL into the nwl-dsi driver, in order

Re: [PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl,clock-drop-level property

2020-09-04 Thread Guido Günther
Hi, On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 > 1 file changed, 4

Re: [PATCH 1/5] drm/bridge: nwl-dsi: Add support for video_pll

2020-09-04 Thread Guido Günther
Hi Robert, On Fri, Aug 28, 2020 at 02:13:28PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > This patch adds support for a new clock 'video_pll' in order to better > set the video_pll clock to a clock-rate that satisfies a mode's clock. > The video PLL, on i.MX8MQ, can drive both DC

Re: [PATCH 5/5] drm/bridge: nwl-dsi: add support for DCSS

2020-09-04 Thread Guido Günther
Hi, On Fri, Aug 28, 2020 at 02:13:32PM +0300, Robert Chiras (OSS) wrote: > From: Laurentiu Palcu > > DCSS needs active low VSYNC and HSYNC. Also, move the input selection in > the probe function, as this will not change at runtime. > > Signed-off-by: Laurentiu Palcu > Signed-off-by: Robert Chir

Re: [PATCH 00/20] iommu/arm-smmu + drm/msm: per-process GPU pgtables

2020-09-04 Thread Rob Clark
On Fri, Sep 4, 2020 at 2:11 AM Joerg Roedel wrote: > > On Mon, Aug 17, 2020 at 03:01:25PM -0700, Rob Clark wrote: > > Jordan Crouse (12): > > iommu/arm-smmu: Pass io-pgtable config to implementation specific > > function > > iommu/arm-smmu: Add support for split pagetables > > iommu/arm-

[PATCH 1/2] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings

2020-09-04 Thread Neil Armstrong
This add the bindings for the 1024*600 tl070wsh30 DSI panel. Signed-off-by: Neil Armstrong --- .../display/panel/tdo,tl070wsh30.yaml | 58 +++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml diff -

[PATCH 0/2] drm: panel: add support for TDO tl070wsh30 panel

2020-09-04 Thread Neil Armstrong
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel module shipped with the Amlogic S400 Development Kit. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller. Neil Arm

[PATCH 2/2] drm: panel: add TDO tl070wsh30 panel driver

2020-09-04 Thread Neil Armstrong
This adds support for the TDO TL070WSH30 TFT-LCD panel module. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig

[PATCH v2 08/11] drm/amd/display: Set DC options from modifiers.

2020-09-04 Thread Bas Nieuwenhuizen
This sets the DC tiling options from the modifier, if modifiers are used for the FB. This patch by itself does not expose the support yet though. There is not much validation yet to limit the scope of this patch, but the current validation is at the same level as the BO metadata path. v2: Add mod

[PATCH v2 09/11] drm/amd/display: Add formats for DCC with 2/3 planes.

2020-09-04 Thread Bas Nieuwenhuizen
For DCC we will use 2/3 planes to avoid X rendering to the frontbuffer with DCC compressed images. To make this work with the core KMS validation we need to add extra formats with the extra planes. However, due to flexibility we set bpp = 0 for the extra planes and do the validation ourselves. Si

[PATCH v2 03/11] drm/amd/display: Honor the offset for plane 0.

2020-09-04 Thread Bas Nieuwenhuizen
With modifiers I'd like to support non-dedicated buffers for images. Signed-off-by: Bas Nieuwenhuizen Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/am

[PATCH v2 10/11] drm/amd/display: Expose modifiers.

2020-09-04 Thread Bas Nieuwenhuizen
This expose modifier support on GFX9+. Only modifiers that can be rendered on the current GPU are added. This is to reduce the number of modifiers exposed. The HW could expose more, but the best mechanism to decide what to expose without an explosion in modifiers is still to be decided, and in th

[PATCH v2 07/11] drm/amd/display: Refactor surface tiling setup.

2020-09-04 Thread Bas Nieuwenhuizen
Prepare for inserting modifiers based configuration, while sharing a bunch of DCC validation & initializing the device-based configuration. Signed-off-by: Bas Nieuwenhuizen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 211 ++ 1 file changed, 116 insertions(+), 95 deletions

[PATCH v2 00/11] amd/display: Add GFX9+ modifier support.

2020-09-04 Thread Bas Nieuwenhuizen
This adds modifier support to radeonsi. It has been tested on - VEGA10, RAVEN, NAVI14 - weston, sway, X with xf86-video-amdgpu (i.e. legacy path still works) and includes some basic testing of the layout code. The main goal is to keep it somewhat simple and regression free, so on the display sid

[PATCH v2 06/11] drm/amd/display: Convert tiling_flags to modifiers.

2020-09-04 Thread Bas Nieuwenhuizen
This way the modifier path gets exercised all the time, improving testing. Furthermore, for modifiers this is required as getfb2 will always return the modifier if the driver sets allow_fb_modifiers. This only triggers once allow_fb_modifiers is set. Signed-off-by: Bas Nieuwenhuizen --- drivers

[PATCH v2 11/11] drm/amd/display: Clean up GFX9 tiling_flags path.

2020-09-04 Thread Bas Nieuwenhuizen
We're unconditionally using modifiers internally for GFX9+ now. Signed-off-by: Bas Nieuwenhuizen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 74 ++- 1 file changed, 7 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers

[PATCH v2 05/11] drm/amd/display: Store tiling_flags in the framebuffer.

2020-09-04 Thread Bas Nieuwenhuizen
This moves the tiling_flags to the framebuffer creation. This way the time of the "tiling" decision is the same as it would be with modifiers. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 48 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 3

[PATCH v2 04/11] drm/fourcc: Add AMD DRM modifiers.

2020-09-04 Thread Bas Nieuwenhuizen
This adds modifiers for GFX9+ AMD GPUs. As the modifiers need a lot of parameters I split things out in getters and setters. - Advantage: simplifies the code a lot - Disadvantage: Makes it harder to check that you're setting all the required fields. The tiling modes seem to

[PATCH v2 02/11] drm/amd: Init modifier field of helper fb.

2020-09-04 Thread Bas Nieuwenhuizen
Otherwise the field ends up being used uninitialized when enabling modifiers, failing validation with high likelyhood. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v2 01/11] drm/amd/display: Do not silently accept DCC for multiplane formats.

2020-09-04 Thread Bas Nieuwenhuizen
Silently accepting it could result in corruption. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/

Re: [PATCH] MAINTAINERS: add entry for VKMS

2020-09-04 Thread Rodrigo Siqueira
On 09/04, Melissa Wen wrote: > Add myself as maintainer of VKMS driver > > Signed-off-by: Melissa Wen > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 01fb9ee6b951..d4277824a01c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -56

Re: [PATCH v5 79/80] drm/vc4: drv: Support BCM2711

2020-09-04 Thread Dave Stevenson
Hi Maxime On Thu, 3 Sep 2020 at 09:03, Maxime Ripard wrote: > > The BCM2711 has a reworked display pipeline, and the load tracker needs > some adjustment to operate properly. Let's add a compatible for BCM2711 > and disable the load tracker until properly supported. > > Tested-by: Chanwoo Choi >

Re: [PATCH v5 56/80] drm/vc4: hdmi: Add a set_timings callback

2020-09-04 Thread Dave Stevenson
Hi Maxime On Thu, 3 Sep 2020 at 09:03, Maxime Ripard wrote: > > Similarly to the previous patches, the timings setup in the HDMI controller > of the BCM2711 is slightly different, mostly because it supports higher > resolutions and thus needed more spaces for the various timings, resulting > in t

Re: [PATCH v5 55/80] drm/vc4: hdmi: Add a CSC setup callback

2020-09-04 Thread Dave Stevenson
Hi Maxime On Thu, 3 Sep 2020 at 09:03, Maxime Ripard wrote: > > Similarly to the previous patches, the CSC setup is slightly different in > the BCM2711 than in the previous generations. Let's add a callback for it. > > Tested-by: Chanwoo Choi > Tested-by: Hoegeun Kwon > Tested-by: Stefan Wahren

Re: [PATCH v5 13/80] drm/vc4: kms: Convert to for_each_new_crtc_state

2020-09-04 Thread Dave Stevenson
Hi Maxime On Thu, 3 Sep 2020 at 09:02, Maxime Ripard wrote: > > The vc4 atomic commit loop has an handrolled loop that is basically > identical to for_each_new_crtc_state, let's convert it to that helper. > > Tested-by: Chanwoo Choi > Tested-by: Hoegeun Kwon > Tested-by: Stefan Wahren > Signed

Re: [PATCH v2 (resend)] video: fbdev: fix OOB read in vga_8planes_imageblit()

2020-09-04 Thread Greg Kroah-Hartman
On Fri, Sep 04, 2020 at 11:53:16PM +0900, Tetsuo Handa wrote: > Hello, Greg. > > Since nobody is interested in this bug, can you directly pick up > this obvious patch without waiting for maintainer's response? I'll pick it up now. thanks, greg k-h ___

Re: [PATCH] MAINTAINERS: add entry for VKMS

2020-09-04 Thread Daniel Vetter
On Fri, Sep 4, 2020 at 3:06 PM Melissa Wen wrote: > > Add myself as maintainer of VKMS driver > > Signed-off-by: Melissa Wen Acked-by: Daniel Vetter Congrats! -Daniel > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 01fb9ee6b951..

Re: [PATCH 11/24] drm/arc: Stop using drm_device->dev_private

2020-09-04 Thread Daniel Vetter
On Fri, Sep 4, 2020 at 4:40 PM Daniel Vetter wrote: > > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Cc: Eugeniy Paltsev > Signed-off-by: Daniel Vetter > Cc: Alexey Brodkin >From the old thread Sam just confirmed he's ok with dev_

Re: [PATCH 10/13] arm64: dts: imx8mq: Add missing interrupts to GPC

2020-09-04 Thread Lucas Stach
On Fr, 2020-09-04 at 16:53 +0200, Krzysztof Kozlowski wrote: > The i.MX General Power Controller v2 device node was missing interrupts > property necessary to route its interrupt to GIC. This also fixes the > dbts_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpc@30

Re: [PATCH 09/13] arm64: dts: imx8mp-evk: Align pin configuration group names with schema

2020-09-04 Thread Lucas Stach
On Fr, 2020-09-04 at 16:53 +0200, Krzysztof Kozlowski wrote: > Device tree schema expects pin configuration groups to end with 'grp' > suffix, otherwise dtbs_check complain with a warning like: > > ... 'usdhc3grp-100mhz', 'usdhc3grp-200mhz' do not match any of the regexes: > 'grp$', 'pinctrl-[0

Re: [PATCH 05/13] dt-bindings: gpu: vivante,gc: Remove trailing whitespace

2020-09-04 Thread Lucas Stach
On Fr, 2020-09-04 at 16:53 +0200, Krzysztof Kozlowski wrote: > Remove whitespace at the end of line. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Lucas Stach > --- > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 01/13] dt-bindings: power: fsl,imx-gpcv2: Document interrupt controller properties

2020-09-04 Thread Lucas Stach
On Fr, 2020-09-04 at 16:53 +0200, Krzysztof Kozlowski wrote: > The i.MX General Power Controller v2 is also an interrupt controller so > document additional properties to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpc@303a: > '#interrupt-cells', '

Re: [PATCH 04/13] dt-bindings: gpu: vivante,gc: Add common properties

2020-09-04 Thread Lucas Stach
On Fr, 2020-09-04 at 16:53 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (cooling-cells, assigned-clocks > and others) to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpu@3800: > '#cooling-cells', 'assigned-clock-paren

[PATCH 12/13] arm64: dts: imx8mq-librem5: Drop interrupt-names in PMIC

2020-09-04 Thread Krzysztof Kozlowski
The 'interrupt-names' property is not described in dtschema, not used by the driver and does not really make sense as its value is simple 'irq'. Drop it to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dt.yaml: pmic@4b: 'interrupt-names' does not match any

[PATCH 11/13] arm64: dts: imx8mq-librem5: Align regulator names with schema

2020-09-04 Thread Krzysztof Kozlowski
Device tree schema expects regulator names to be lowercase. This fixes dtbs_check warnings like: pmic@4b: regulators:LDO1:regulator-name:0: 'LDO1' does not match '^ldo[1-7]$' Signed-off-by: Krzysztof Kozlowski --- .../boot/dts/freescale/imx8mq-librem5.dtsi| 30 +-- 1 file

[PATCH 07/13] dt-bindings: mfd: rohm, bd71847-pmic: Add common clock-names

2020-09-04 Thread Krzysztof Kozlowski
Add common 'clock-names' property which might appear in DTSes. This makes it consistent with rohm,bd71837-pmic dtschema. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devic

[PATCH 08/13] arm64: dts: imx8mm-var-som-symphony: Use newer interrupts property

2020-09-04 Thread Krzysztof Kozlowski
The int-gpios was deprecated in favor of generic interrupts property. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts b/

[PATCH 10/13] arm64: dts: imx8mq: Add missing interrupts to GPC

2020-09-04 Thread Krzysztof Kozlowski
The i.MX General Power Controller v2 device node was missing interrupts property necessary to route its interrupt to GIC. This also fixes the dbts_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpc@303a: {'compatible': ... '$nodename': ['gpc@303a']} is not va

[PATCH 13/13] arm64: dts: imx8mq-librem5: Add interrupt-names to ti, tps6598x

2020-09-04 Thread Krzysztof Kozlowski
The ti,tps6598x binding requires interrupt-names property. The driver does not really use it but the hardware could have more interrupt lines connected. This fixes dtbs_check warning: arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: usb-pd@3f: 'interrupt-names' is a required property

[PATCH 09/13] arm64: dts: imx8mp-evk: Align pin configuration group names with schema

2020-09-04 Thread Krzysztof Kozlowski
Device tree schema expects pin configuration groups to end with 'grp' suffix, otherwise dtbs_check complain with a warning like: ... 'usdhc3grp-100mhz', 'usdhc3grp-200mhz' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/fre

[PATCH 05/13] dt-bindings: gpu: vivante, gc: Remove trailing whitespace

2020-09-04 Thread Krzysztof Kozlowski
Remove whitespace at the end of line. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpu/vivante,gc.yaml b/Documentation/devicetree/bindings/gpu/vi

[PATCH 04/13] dt-bindings: gpu: vivante,gc: Add common properties

2020-09-04 Thread Krzysztof Kozlowski
Add common properties appearing in DTSes (cooling-cells, assigned-clocks and others) to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpu@3800: '#cooling-cells', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the

[PATCH 00/13] iMX 8 - Another round of cleanups

2020-09-04 Thread Krzysztof Kozlowski
Hi, This is an another round of cleanups of i.MX 8 DTS and binings. No dependencies. Best regards, Krzysztof Krzysztof Kozlowski (13): dt-bindings: power: fsl,imx-gpcv2: Document interrupt controller properties dt-bindings: display: bridge: nwl-dsi: Add common properties dt-bindings:

[PATCH 06/13] dt-bindings: mfd: rohm, bd71837-pmic: Add common properties

2020-09-04 Thread Krzysztof Kozlowski
Add common properties appearing in DTSes (clock-names, clock-output-names) to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozl

[PATCH 03/13] dt-bindings: arm: fsl: Fix matching Purism Librem5 phones

2020-09-04 Thread Krzysztof Kozlowski
All Purism Librem5 phones have three compatibles so they need their own entry to fix dbts_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: /: compatible: ['purism,librem5r2', 'purism,librem5', 'fsl,imx8mq'] is not valid under any of the given schemas arch/arm

[PATCH 02/13] dt-bindings: display: bridge: nwl-dsi: Add common properties

2020-09-04 Thread Krzysztof Kozlowski
Add common properties appearing in DTSes (assigned-clocks and others) to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: mipi-dsi@30a0: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: '^panel@[0-9]+$',

[PATCH 01/13] dt-bindings: power: fsl, imx-gpcv2: Document interrupt controller properties

2020-09-04 Thread Krzysztof Kozlowski
The i.MX General Power Controller v2 is also an interrupt controller so document additional properties to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mq-evk.dt.yaml: gpc@303a: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+

Re: [PATCH 40/59] drm/arcpgu: Stop using drm_device->dev_private

2020-09-04 Thread Sam Ravnborg
Hi Daniel. On Fri, Sep 04, 2020 at 03:42:44PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 6:46 PM Sam Ravnborg wrote: > > > > Hi Daniel. > > > > On Wed, Apr 15, 2020 at 09:40:15AM +0200, Daniel Vetter wrote: > > > Upcasting using a container_of macro is more typesafe, faster and > > > e

[PATCH 15/24] drm/arc: Drop surplus connector registration

2020-09-04 Thread Daniel Vetter
drm_connector_register does nothing before drm_dev_register(), it is meant for hotpluggable connectors only. Same for the unregister side. Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_sim.c | 2 -- 1 file changed, 2

[PATCH 19/24] drm/arc: Drop crtc check in arc_pgu_update

2020-09-04 Thread Daniel Vetter
It's redundant, drm core guarantees that state->fb is set iff state->crtc is set. v2: I had a misconception about simple helpers here and thought they filter this out. They don't. Issue reported by Eugeniy. Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/dr

[PATCH 10/24] drm/arc: Switch to devm_drm_dev_alloc

2020-09-04 Thread Daniel Vetter
- Need to embedded the drm_device, but for now we keep the usual pointer chasing. - No more devm_kzalloc, which fixes a lifetime issues on driver remove. - No more drm_dev_put, that's done by devm_ now. Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodk

[PATCH 12/24] drm/arc: Delete arcpgu_priv->fb

2020-09-04 Thread Daniel Vetter
Leftover from the conversion to the generic fbdev emulation. Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/arc/arcpgu.h b/drivers/gpu/drm/arc/arcpgu.h index 87821c91a00c..e

[PATCH 24/24] drm/arc: Move to drm/tiny

2020-09-04 Thread Daniel Vetter
Because it is. v2: Delete now unused crtc funcs (0day) Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- MAINTAINERS | 2 +- drivers/gpu/drm/Kconfig | 2 -- drivers/gpu/drm/Makefile

[PATCH 21/24] drm/arc: Inline arcpgu_drm_hdmi_init

2020-09-04 Thread Daniel Vetter
Really not worth the function, much less the separate file now that almost all the code is gone. Cc: Eugeniy Paltsev Cc: Alexey Brodkin Signed-off-by: Daniel Vetter --- drivers/gpu/drm/arc/Makefile | 2 +- drivers/gpu/drm/arc/arcpgu.h | 1 - drivers/gpu/drm/arc/arcpgu_drv.c | 12 +

[PATCH 22/24] drm/arc: Inline remaining files

2020-09-04 Thread Daniel Vetter
At less than 500 lines total feels like the right thing to do. Also noticed that the simple wrapper around drm_connector_cleanup can be dropped. Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Cc: Alexey Brodkin Signed-off-by: Daniel Vetter --- drivers/gpu/drm/arc/Makefile | 2 +- drivers/

[PATCH 20/24] drm/arc: Inline arcpgu_crtc.c

2020-09-04 Thread Daniel Vetter
Really not big anymore. Note that we no longer clamp all errors to ENODEV, highlighted by Sam. v2: Fixup update function, bug reported by Eugeniy v3: Delete now unused crtc funcs (0day) v4: Move encoder removal to right patch (Sam). Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Sam Ra

[PATCH 16/24] drm/arc: Use drmm_mode_config_cleanup

2020-09-04 Thread Daniel Vetter
With autocleanup through drm_device management we can delete all the code. Possible now that there's no confusion against devm_kzalloc'ed structures anymore. I inlined arcpgu_setup_mode_config because it's tiny and the newly needed return value handling would have been more ... Acked-by: Sam Ravn

[PATCH 06/24] drm/xlnx: Use devm_drm_dev_alloc

2020-09-04 Thread Daniel Vetter
Gets rid of drmm_add_final_kfree, which I want to unexport so that it stops confusion people about this transitional state of rolling drm managed memory out. This also fixes the missing drm_dev_put in the error path of the probe code. Signed-off-by: Daniel Vetter Cc: Hyun Kwon Cc: Laurent Pinch

[PATCH 14/24] drm/arc: Embedd a drm_connector for sim case

2020-09-04 Thread Daniel Vetter
Removes the last devm_kzalloc, which means we're now prepared to use drmm_mode_config_cleanup! Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu.h | 1 + drivers/gpu/drm/arc/arcpgu_sim.c | 14 +- 2 files

[PATCH 11/24] drm/arc: Stop using drm_device->dev_private

2020-09-04 Thread Daniel Vetter
Upcasting using a container_of macro is more typesafe, faster and easier for the compiler to optimize. Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu.h | 2 ++ drivers/gpu/drm/arc/arcpgu_crtc.c | 4 ++-- drivers/gpu/drm/arc/arcpgu_drv.c

[PATCH 23/24] drm/arc: Initialize sim connector before display pipe

2020-09-04 Thread Daniel Vetter
That way we can get rid of this final piece of init code, and use the simple pipe helpers as intended. v2: Fix indent (Sam) Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_drv.c | 53 ++-- 1

[PATCH 08/24] drm/i915/selftests: align more to real device lifetimes

2020-09-04 Thread Daniel Vetter
The big change is device_add so that device_del can auto-cleanup devres resources. This allows us to use devm_drm_dev_alloc, which removes the last user of drm_dev_init. v2: Rebased v3: use devres_open/release_group so we can use devm without real hacks in the driver core or having to create an e

  1   2   3   >