Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

Hi, Yongqiang: Chun-Kuang Hu 於 2020年8月9日 週日 上午8:56寫道： > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道： > > > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma > > > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 > > Remove c

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道： > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 Remove change-id. > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/

Re: [RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h

Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道： > > mmsys is the driver which control the routing of these ddp component, > so the definition of mtk_ddp_comp_id should be placed in mtk-mmsys.h > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_com

Re: [RESEND v7, PATCH 0/7] add drm support for MT8183

Hi, Yongqiang: This series is 'v8', not 'RESEND v7' Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道： > > This series are based on 5.8-rc1 and provide 7 patch > to support mediatek SOC MT8183 > > Change since v6 > - move ddp component define into mtk_mmsys.h > - add mmsys private data to support different

Re: [RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183

Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道： > > This patch add support for mediatek SOC MT8183 > 1. add ovl private data > 2. add rdma private data > 3. add mutes private data > 4. add main and external path module for crtc create > > Signed-off-by: Yongqiang Niu [snip] > + > stati

[PATCH] drm/panel-notatek-nt35510: Fix MTP read init

In order to successfully read ID of the MTP panel the panel MTP control page must be unlocked. Previously this wasn't encountered because in the setup with this panel the power wasn't ever really dropped. When power gets dropped from the panel, MTP needs to be unlocked. Cc: newby...@protonmail.com

[PATCH 4/4 v2] drm/mcde: Enable the DSI link with display

The MCDE DSI link hardware which is modeled like a bridge in DRM, connected further to the panel bridge, creating a pipeline. We have been using the .pre_enable(), .enable(), .disable() and .post_disable() callbacks from the bridge to set this up in a chained manner: first the display controller g

[PATCH 3/4 v2] drm/mcde: Fix display pipeline restart

To make sure that the MCDE is in a reasonable state during set-up, perform a reset by power cycling the block by dropping the on-chip regulator reference after probe. The display subsystem (DSS) has no dedicated reset line so dropping the EPOD regulator is the only real way of resetting it. We int

[PATCH 1/4 v2] drm/mcde: Improve pixel fetcher FIFO depth setting

The pixel fetcher FIFO depth was just hardcoded to 48 which works fine as long as the framebuffer is 32BPP and the DSI output is RGB888. We will need more elaborate handling for some buffer formats and displays, so start to improve this function by setting reasonable defaults for 32, 24 and 16 BPP

[PATCH 2/4 v2] drm/mcde: Support using DSI in LP mode

It is possible to set a flag in the struct mipi_dsi_device so the panel is handled in low power (LP) mode. Some displays only support this mode and it is also good for testing. Cc: newby...@protonmail.com Cc: Stephan Gerhold Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 10

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

Hi Vinay, On Fri, Aug 07, 2020 at 06:22:59PM +0530, Vinay Simha B N wrote: > Hi All, > > Please Review the patch I'm afraid I won't have time for at least a couple of weeks. > On Wed, Jul 29, 2020 at 6:01 PM Vinay Simha B N wrote: > > > Hi All, > > > > Please Review the patch > > > > On Fri,

Re: [PATCH 7/7] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:54PM +0100, Lad Prabhakar wrote: > The iwg21d comes with a 7" capacitive touch screen, therefore > add support for it. I can't review most of this properly as I don't have access to the schematics. Is there a way to get it ? >

Re: [PATCH 5/7] ARM: dts: r8a7742: Add DU support

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:52PM +0100, Lad Prabhakar wrote: > Add du node to r8a7742 SoC DT. Boards that want to enable the DU > need to specify the output topology. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-b

Re: [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:53PM +0100, Lad Prabhakar wrote: > Add LVDS encoder node to r8a7742 SoC DT. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > arch/arm/boot/dts/r8a7742.dtsi | 54 +

Re: [PATCH 4/7] drm: rcar-du: lvds: Add r8a7742 support

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:51PM +0100, Lad Prabhakar wrote: > The LVDS encoders on RZ/G1H SoC is identical to the R-Car Gen2 family. Add > support for RZ/G1H (R8A7742) SoC to the LVDS encoder driver. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Maria

Re: [PATCH 3/7] dt-bindings: display: renesas, lvds: Document r8a7742 bindings

On Sun, Aug 09, 2020 at 12:03:27AM +0300, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:50PM +0100, Lad Prabhakar wrote: > > Document the RZ/G1H (R8A7742) LVDS bindings. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Marian-Cristia

Re: [PATCH 3/7] dt-bindings: display: renesas, lvds: Document r8a7742 bindings

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:50PM +0100, Lad Prabhakar wrote: > Document the RZ/G1H (R8A7742) LVDS bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Laurent Pinchart > --- > .../devicetree/bindings/disp

Re: [PATCH 2/7] drm: rcar-du: Add r8a7742 support

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > Add direct support for the r8a7742 (RZ/G1H). > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > (R-Car H2) so that device info structure is reused, the only difference

Re: [PATCH 1/7] dt-bindings: display: renesas,du: Document the r8a7742 bindings

Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:48PM +0100, Lad Prabhakar wrote: > Document the RZ/G1H (R8A7742) SoC in the R-Car DU bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Laurent Pinchart > --- > Documentation

Re: [PATCH 0/7] r8a7742: Enable DU and LVDS

Hi Prabhakar, Thank you for the patches. On Fri, Aug 07, 2020 at 06:49:47PM +0100, Lad Prabhakar wrote: > Hi All, > > This patch series adds support for DU and LVDS to r8a7742 > SoC and enables LCD support on r8a7742-iwg21d-q7 board. > > This patch series applies on top of [1]. > > [1] https:/

[PATCH] drm/msm/a6xx: fix crashdec section name typo

From: Rob Clark Backport note: maybe wait some time for the crashdec MR[1] to look for both the old typo'd name and the corrected name to land in mesa 20.2 [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6242 Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state") Signed-off-by:

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

On Sat, Aug 8, 2020 at 1:28 PM Greg KH wrote: > > On Sat, Aug 08, 2020 at 01:02:34PM +0200, Daniel Vetter wrote: > > On Sat, Aug 8, 2020 at 12:24 PM Greg KH wrote: > > > > > > On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > > > > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann

[PATCH v3] drm/vkms: guarantee vblank when capturing crc

VKMS needs vblank interrupts enabled to capture CRC. When vblank is disabled, tests like kms_cursor_crc and kms_pipe_crc_basic getting stuck waiting for a capture that will not occur until vkms wakes up. This patch adds a helper to set composer and ensure that vblank remains enabled as long as the

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

On Sat, Aug 08, 2020 at 01:02:34PM +0200, Daniel Vetter wrote: > On Sat, Aug 8, 2020 at 12:24 PM Greg KH wrote: > > > > On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > > > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann > > > wrote: > > > > > > > > Hi > > > > > > > > Am 07.08.2

Re: [PATCH v1 02/12] fbdev: lxfb: use generic power management

Hi Vaibhav On Wed, Aug 05, 2020 at 11:37:12PM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic p

Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management

Hi Vaibhav On Wed, Aug 05, 2020 at 11:37:11PM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic p

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

On Sat, Aug 8, 2020 at 12:24 PM Greg KH wrote: > > On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann > > wrote: > > > > > > Hi > > > > > > Am 07.08.20 um 15:30 schrieb gre...@linuxfoundation.org: > > > > The patch below was submit

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: > > > > Hi > > > > Am 07.08.20 um 15:30 schrieb gre...@linuxfoundation.org: > > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > > > I fail to see h

Re: [PATCH] drm/panel-notatek-nt35510: Fix enable/disable sequence

On Wed, Aug 5, 2020 at 4:28 PM Linus Walleij wrote: > The driver was relying on only prepare()/unprepare() to > enable/disable the display. > > This does not work because prepare() will be called > before the DSI host/bridge is ready to send any DSI > commands and disable() will be called after t

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

Hi Daniel. On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote: > On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: > > > > Hi > > > > Am 07.08.20 um 15:30 schrieb gre...@linuxfoundation.org: > > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > > > I f

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann wrote: > > Hi > > Am 07.08.20 um 15:30 schrieb gre...@linuxfoundation.org: > > The patch below was submitted to be applied to the 5.8-stable tree. > > > > I fail to see how this patch meets the stable kernel rules as found at > > Documentation/proce

Re: [PATCH V2] drm: Remove unnecessary drm_panel_attach and drm_panel_detach

Hi Joe. On Sun, Aug 02, 2020 at 07:34:13PM +0200, Sam Ravnborg wrote: > Hi Joe. > > On Sun, Aug 02, 2020 at 09:43:59AM -0700, Joe Perches wrote: > > These functions are now empty and no longer > > useful so remove the functions and their uses. > > > > Signed-off-by: Joe Perches > > --- > > > >