Re: Threaded submission & semaphore sharing

On 02/08/2019 09:10, Koenig, Christian wrote: Am 02.08.2019 07:38 schrieb Lionel Landwerlin : On 02/08/2019 08:21, Koenig, Christian wrote: Am 02.08.2019 07:17 schrieb Lionel Landwerlin : On 02/08/2019 08:08,

Re: Threaded submission & semaphore sharing

Am 02.08.2019 07:38 schrieb Lionel Landwerlin : On 02/08/2019 08:21, Koenig, Christian wrote: Am 02.08.2019 07:17 schrieb Lionel Landwerlin : On 02/08/2019 08:08, Koenig, Christian wrote: Hi Lionel, Well that looks more like your test case is buggy. Acco

[Bug 111281] When the s admin try to create different types of question in various difficulty level by single upload mode database error occurred

https://bugs.freedesktop.org/show_bug.cgi?id=111281 dhrisya changed: What|Removed |Added CC||dhrisyasb...@gmail.com Status|NEW

Re: Threaded submission & semaphore sharing

On 02/08/2019 08:21, Koenig, Christian wrote: Am 02.08.2019 07:17 schrieb Lionel Landwerlin : On 02/08/2019 08:08, Koenig, Christian wrote: Hi Lionel, Well that looks more like your test case is buggy. According to the code the ctx1 queue always waits for sem1

Re: [Intel-gfx] [linux-next] mm/i915: i915_gemfs_init() NULL dereference

On (08/01/19 18:30), Chris Wilson wrote: > Quoting Sergey Senozhatsky (2019-07-31 17:48:29) > > @@ -36,19 +38,35 @@ int i915_gemfs_init(struct drm_i915_private *i915) [..] > > + if (!fc->ops->parse_monolithic) > > + goto err; > > + > > + err = fc->o

[PATCH v4 05/17] drm/amdgpu: use embedded gem object

Drop drm_gem_object from amdgpu_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH v4 08/17] drm/ttm: use gem vma_node

Drop vma_node from ttm_buffer_object, use the gem struct (base.vma_node) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/qxl/qxl_object.h | 2 +- drivers/gpu/drm/radeon/radeon_object.h | 2 +-

[PATCH v4 04/17] drm/radeon: use embedded gem object

Drop drm_gem_object from radeon_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon.h | 3 +-- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_display.

[PATCH v4 16/17] drm/virtio: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl

[PATCH v4 10/17] drm/ttm: switch ttm core from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_driver.h| 12 ++-- drivers/gpu/drm/ttm/ttm_bo.c | 96 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 16 ++--- drivers/gpu/drm/ttm/ttm_bo_vm.c| 6 +- drivers/gpu/d

[PATCH v4 07/17] drm/ttm: use gem reservation object

Drop ttm_resv from ttm_buffer_object, use the gem reservation object (base._resv) instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 39 ++- drivers/gpu/drm/ttm/ttm_bo_u

[PATCH v4 00/17] drm/ttm: make ttm bo a gem bo subclass

v4: - rebase to latest drm-misc-next, adapt to vram helper changes. v3: - comment updates - rebased on daniels resv series (https://patchwork.freedesktop.org/series/62735/) v2: - build fixes. - also drop ttm_buffer_object->resv Gerd Hoffmann (17): drm/ttm: add gem base object drm/vram:

[PATCH v4 11/17] drm/radeon: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/radeon/radeon_benchmark.c | 4 ++-- drivers/gpu/drm/radeon/radeon_cs.c| 2 +- drivers/gpu/drm/radeon/radeon_display.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c | 6 +++--- drivers/gpu/drm/radeon/radeo

[PATCH v4 13/17] drm/amdgpu: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/g

[PATCH v4 09/17] drm/ttm: set both resv and base.resv pointers

Initialize both ttm_buffer_object->resv and ttm_buffer_object->base.resv pointers. This allows to move users from the former to the latter. When all users are moved we can drop ttm_buffer_object->resv. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c

[PATCH v4 06/17] drm/nouveau: use embedded gem object

Drop drm_gem_object from nouveau_bo, use the ttm_buffer_object.base instead. Build tested only. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.h | 5 - drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +- drivers/gpu/drm/nouveau/nouveau_ab

[PATCH v4 15/17] drm/qxl: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_debugfs.c | 2 +- drivers/gpu/drm/qxl/qxl_release.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_debugfs.c b/drivers/gpu/drm/qxl/qxl_debugfs.c index bdb5ac098

[PATCH v4 01/17] drm/ttm: add gem base object

Add drm_gem_object struct to ttm_buffer_object, so ttm objects are a gdm object superclass. Add a function to check whenever a given bo actually uses the embedded drm_gem_object. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 23 +++

[PATCH v4 02/17] drm/vram: use embedded gem object

Drop drm_gem_object from drm_gem_vram_object, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König Acked-by: Thomas Zimmermann --- include/drm/drm_gem_vram_helper.h | 3 +-- drivers/gpu/drm/ast/ast_main.c | 2 +- drivers/gpu

[PATCH v4 03/17] drm/qxl: use embedded gem object

Drop drm_gem_object from qxl_bo, use the ttm_buffer_object.base instead. Signed-off-by: Gerd Hoffmann Acked-by: Christian König --- drivers/gpu/drm/qxl/qxl_drv.h | 6 +++--- drivers/gpu/drm/qxl/qxl_object.h | 4 ++-- drivers/gpu/drm/qxl/qxl_cmd.c | 4 ++-- drivers/gpu/drm/qxl/qxl_de

[PATCH v4 14/17] drm/nouveau: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 5 ++--- drivers/gpu/drm/nouveau/nouveau_fence.c | 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 4 files changed, 5 insertions(+), 6 del

[PATCH v4 17/17] drm/ttm: drop ttm_buffer_object->resv

All users moved to ttm_buffer_object->base.resv Signed-off-by: Gerd Hoffmann Reviewed-by: Christian König --- include/drm/ttm/ttm_bo_api.h | 1 - drivers/gpu/drm/ttm/ttm_bo.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index

[PATCH v4 12/17] drm/vmwgfx: switch driver from bo->resv to bo->base.resv

Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 8 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) di

Re: Threaded submission & semaphore sharing

Am 02.08.2019 07:17 schrieb Lionel Landwerlin : On 02/08/2019 08:08, Koenig, Christian wrote: Hi Lionel, Well that looks more like your test case is buggy. According to the code the ctx1 queue always waits for sem1 and ctx2 queue always waits for sem2. That's supposed to be the same underlyi

Re: Threaded submission & semaphore sharing

On 02/08/2019 08:08, Koenig, Christian wrote: Hi Lionel, Well that looks more like your test case is buggy. According to the code the ctx1 queue always waits for sem1 and ctx2 queue always waits for sem2. That's supposed to be the same underlying syncobj because it's exported from one VkDe

Re: Threaded submission & semaphore sharing

Hi Lionel, Well that looks more like your test case is buggy. According to the code the ctx1 queue always waits for sem1 and ctx2 queue always waits for sem2. This way there can't be any Synchronisation between the two. Regards, Christian. Am 02.08.2019 06:55 schrieb Lionel Landwerlin : Hey C

Re: Threaded submission & semaphore sharing

Hey Christian, The problem boils down to the fact that we don't immediately create dma fences when calling vkQueueSubmit(). This is delayed to a thread. From a single application thread, you can QueueSubmit() to 2 queues from 2 different devices. Each QueueSubmit to one queue has a dependency

Re: Threaded submission & semaphore sharing

Hi Lionel, Well could you describe once more what the problem is? Cause I don't fully understand why a rather normal tandem submission with two semaphores should fail in any way. Regards, Christian. Am 02.08.2019 06:28 schrieb Lionel Landwerlin : There aren't CTS tests covering the issue I was

Re: Threaded submission & semaphore sharing

There aren't CTS tests covering the issue I was mentioning. But we could add them. I don't have all the details regarding your implementation but even with the "semaphore thread", I could see it running into the same issues. What if a mix of binary & timeline semaphores are handed to vkQueueSub

[Bug 111282] When the s admin try to create different types of question in various difficulty level by bulk mode multiple answer accepted in single choice and t/f.And in multiple choice single answe

https://bugs.freedesktop.org/show_bug.cgi?id=111282 dhrisya changed: What|Removed |Added URL||http://westkutt-testnew.tar

[Bug 111282] When the s admin try to create different types of question in various difficulty level by bulk mode multiple answer accepted in single choice and t/f.And in multiple choice single answe

https://bugs.freedesktop.org/show_bug.cgi?id=111282 dhrisya changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail beca

[Bug 111282] When the s admin try to create different types of question in various difficulty level by bulk mode multiple answer accepted in single choice and t/f.And in multiple choice single answe

https://bugs.freedesktop.org/show_bug.cgi?id=111282 Bug ID: 111282 Summary: When the s admin try to create different types of question in various difficulty level by bulk mode multiple answer accepted in single choice and t/f.And

[Bug 111281] When the s admin try to create different types of question in various difficulty level by single upload mode database error occurred

https://bugs.freedesktop.org/show_bug.cgi?id=111281 Bug ID: 111281 Summary: When the s admin try to create different types of question in various difficulty level by single upload mode database error occurred Product: DRI

RE: Threaded submission & semaphore sharing

Hi Lionel, By the Queue thread is a heavy thread, which is always resident in driver during application running, our guys don't like that. So we switch to Semaphore Thread, only when waitBeforeSignal of timeline happens, we spawn a thread to handle that wait. So we don't have your this issue. B

drm fixes for 5.3-rc3

Hi Linus, Thanks to Daniel for handling the email the last couple of weeks, flus and break-ins combined to derail me. Surprised nothing materialised today to take me out again. I've also tried embedding the summary into the signed pull request, since all the cool kids seemed to be doing it, it's

[Bug 204181] NULL pointer dereference regression in amdgpu

https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #26 from Sergey Kondakov (virtuous...@gmail.com) --- Created attachment 284083 --> https://bugzilla.kernel.org/attachment.cgi?id=284083&action=edit dmesg_2019-08-02-amdgpu_fail_on_patched_5.2.5 (In reply to Nicholas Kazlauskas from

Re: [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks

From: Alex Deucher Sent: Friday, August 2, 2019 2:53 AM To: Colin King Cc: Wang, Kevin(Yang) ; Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-gfx list ; Maling list - DRI developers

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

From: amd-gfx on behalf of Colin King Sent: Thursday, August 1, 2019 4:39 PM To: Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesk

[Bug 107020] Dolphin freezes only with OpenGL

https://bugs.freedesktop.org/show_bug.cgi?id=107020 --- Comment #3 from John --- Nope, AmdGpu driver Issue at the time. Using Nvidia, no issues now. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dr

[PATCH -next] drm/vgem: Fix wrong pointer passed to PTR_ERR()

PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vgem/vgem_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[Bug 106056] weird artifacts in top right corner when rendering with firefox or unigine heaven

https://bugs.freedesktop.org/show_bug.cgi?id=106056 Timothy Arceri changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[PATCH v5 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*() varia

[PATCH v5 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

From: John Hubbard Changes since v4: * Christophe Hellwig's review applied: deleted siw_free_plist() and __qib_release_user_pages(), now that put_user_pages_dirty_lock() does what those routines were doing. * Applied Bjorn's ACK for net/xdp, and Christophe's Reviewed-by for patch #1. Cha

[PATCH v5 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v5 3/3] net/xdp: convert put_page() to put_user_page*()

From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

Re: [Nouveau] [PATCH] drm/nouveau: Only release VCPI slots on mode changes

On Fri, 2 Aug 2019 at 08:02, Lyude Paul wrote: > > Looks like a regression got introduced into nv50_mstc_atomic_check() > that somehow didn't get found until now. If userspace changes > crtc_state->active to false but leaves the CRTC enabled, we end up > calling drm_dp_atomic_find_vcpi_slots() usi

[Bug 100802] [regression] mostly blank graphics on Faeria

https://bugs.freedesktop.org/show_bug.cgi?id=100802 Timothy Arceri changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Bug 107020] Dolphin freezes only with OpenGL

https://bugs.freedesktop.org/show_bug.cgi?id=107020 --- Comment #2 from Timothy Arceri --- Is this still an issues? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org htt

[PATCH] drm/nouveau: Only release VCPI slots on mode changes

Looks like a regression got introduced into nv50_mstc_atomic_check() that somehow didn't get found until now. If userspace changes crtc_state->active to false but leaves the CRTC enabled, we end up calling drm_dp_atomic_find_vcpi_slots() using the PBN calculated in asyh->dp.pbn. However, if the dis

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-01 11:59:57) > > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > > wrote: > > > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > > > > To be honest I do not fully understand KUnit design. I

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

Quoting Brendan Higgins (2019-08-01 11:59:57) > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > wrote: > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > > To be honest I do not fully understand KUnit design. I am not > > > completely sure how the tested code is isolated from th

Threaded submission & semaphore sharing

Hi Christian, David, Sorry to report this so late in the process, but I think we found an issue not directly related to syncobj timelines themselves but with a side effect of the threaded submissions. Essentially we're failing a test in crucible : func.sync.semaphore-fd.opaque-fd This test c

[PULL] drm-intel-next

Hi Dave and Daniel, Here goes the first pull request targeting 5.4. It mostly comes with a lot of platform enabling patches and reworks and simplification around locking mechanisms, ppgtt allocation, engines and intel_gt in general. There were 2 silent backmerges that should be transparent for y

[RESEND PULL] msm-fixes

Hi Team, Sorry I pulled the trigger a bit early on the last email. This one is the same tag, but cc's the appropriate lists/people. Since I handed drm-misc back to Maarten this week, I'll send msm fixes from the msm tree. Not too heavy, but fixes some important regressions in 5.3. Thanks, Sean

Re: [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

On 8/1/19 8:52 AM, Noralf Trønnes wrote: Move the driver to drm/panel and take advantage of the new panel support in drm_mipi_dbi. Change the file name to match the naming standard in drm/panel. The DRM driver name is kept since it is ABI. Add missing MAINTAINERS entry. Cc: David Lechner Signe

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

On Thu, 2019-08-01 at 15:02 -0400, Alex Deucher wrote: > Applied. thanks! > > Alex > > On Thu, Aug 1, 2019 at 4:39 AM Colin King wrote: > > From: Colin Ian King > > > > There are a few spelling mistakes "unknow" -> "unknown" and > > "enabeld" -> "enabled". Fix these. [] > > diff --git a/drive

Re: [PATCH 3/4] drm/tiny/mi0283qt: Move driver to panel-ilitek-ili9341

On 8/1/19 8:52 AM, Noralf Trønnes wrote: The MI0283QT panels use a ILI9341 controller so it makes sense to merge it with the other ili9341 code. The DRM driver name is ABI, so that is retained. Cc: David Lechner Signed-off-by: Noralf Trønnes --- ... @@ -216,6 +339,10 @@ static int ili9341

Re: [PATCH][drm-next] drm/amdgpu: fix unsigned variable instance compared to less than zero

On Thu, Aug 1, 2019 at 7:01 AM Colin King wrote: > > From: Colin Ian King > > Currenly the error check on variable instance is always false because > it is a uint32_t type and this is never less than zero. Fix this by > making it an int type. > > Addresses-Coverity: ("Unsigned compared against 0"

Re: [4/4] drm/panel/ili9341: Support DPI panels

On 8/1/19 8:52 AM, Noralf Trønnes wrote: Add support for panels that use the DPI interface. ILI9341 has onboard RAM so the assumption made here is that all such panels support pixel upload over DBI. The presence/absense of the Device Tree 'port' node decides which interface is used for pixel tra

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

Applied. thanks! Alex On Thu, Aug 1, 2019 at 4:39 AM Colin King wrote: > > From: Colin Ian King > > There are a few spelling mistakes "unknow" -> "unknown" and > "enabeld" -> "enabled". Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins wrote: > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > > > On Thu 2019-07-25 13:21:12, Brendan Higgins wrote: > > > On Wed, Jul 24, 2019 at 12:31 AM Petr Mladek wrote: > > > > > > > > On Mon 2019-07-22 16:54:10, Stephen Boyd wrote: > > >

Re: [PATCH] gpu: drm: radeon: Fix a possible null-pointer dereference in radeon_connector_set_property()

On Mon, Jul 29, 2019 at 11:08 AM Jia-Ju Bai wrote: > > In radeon_connector_set_property(), there is an if statement on line 743 > to check whether connector->encoder is NULL: > if (connector->encoder) > > When connector->encoder is NULL, it is used on line 755: > if (connector->encoder->cr

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote: > > On Thu 2019-07-25 13:21:12, Brendan Higgins wrote: > > On Wed, Jul 24, 2019 at 12:31 AM Petr Mladek wrote: > > > > > > On Mon 2019-07-22 16:54:10, Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-07-22 15:30:49) > > > > > On Mon, Jul

Re: [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks

On Thu, Aug 1, 2019 at 7:15 AM Colin King wrote: > > From: Colin Ian King > > There are two occurrances of off-by-one upper bound checking of indexes > causing potential out-of-bounds array reads. Fix these. > > Addresses-Coverity: ("Out-of-bounds read") > Fixes: cb33363d0e85 ("drm/amd/powerplay:

[Bug 110413] GPU crash and failed reset leading to deadlock on Polaris 22 XL [Radeon RX Vega M GL]

https://bugs.freedesktop.org/show_bug.cgi?id=110413 Utku Helvacı (tuxutku) changed: What|Removed |Added CC||proje@outlook.com --- Comm

Re: [Intel-gfx] [RFC][PATCH 0/2] drm: PATH prop for all connectors?

On 2019-08-01 5:51 a.m., Pekka Paalanen wrote: > On Tue, 16 Jul 2019 14:59:58 + > "Li, Sun peng (Leo)" wrote: > >> On 2019-07-11 3:29 a.m., Pekka Paalanen wrote: >>> Wait, one can write udev rules for connectors and stuff? >>> How? What can they do? >> >> I was using it to generate user-f

Re: [Intel-gfx] [linux-next] mm/i915: i915_gemfs_init() NULL dereference

Quoting Sergey Senozhatsky (2019-07-31 17:48:29) > @@ -36,19 +38,35 @@ int i915_gemfs_init(struct drm_i915_private *i915) > struct super_block *sb = gemfs->mnt_sb; > /* FIXME: Disabled until we get W/A for read BW issue. */ > char options[] = "huge=ne

Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

On 8/1/19 5:38 AM, Kevin Brodsky wrote: > This patch series only changes what is allowed or not at the syscall > interface. It does not change the address space size. On arm64, TBI (Top > Byte Ignore) has always been enabled for userspace, so it has never been > possible to use the upper 8 bits of

[PATCH] drm/radeon: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- This is the same patch as in the series: https://www.spinics.net/lists/dri-devel/msg220128.html but this time without a bug. radeon_add_legacy_connector() uses a local ddc variable, but it has not b

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

On Thu, Aug 1, 2019 at 8:34 AM Chris Wilson wrote: > > Quoting Rob Clark (2019-08-01 16:18:45) > > On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson > > wrote: > > > > > > Quoting Sean Paul (2019-07-31 20:23:31) > > > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > > > > On Wed, J

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

On 8/1/19 5:48 AM, Andrey Konovalov wrote: > On Thu, Aug 1, 2019 at 2:11 PM Kevin Brodsky wrote: >> On 31/07/2019 17:50, Dave Hansen wrote: >>> On 7/23/19 10:58 AM, Andrey Konovalov wrote: The mmap and mremap (only new_addr) syscalls do not currently accept tagged addresses. Architecture

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

Quoting Rob Clark (2019-08-01 16:18:45) > On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson wrote: > > > > Quoting Sean Paul (2019-07-31 20:23:31) > > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > > > On Wed, Jul 17, 2019 at 02:15:37PM -0700, Rob Clark wrote: > > > > > From: Rob C

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson wrote: > > Quoting Sean Paul (2019-07-31 20:23:31) > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > > On Wed, Jul 17, 2019 at 02:15:37PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > drm_cflush_pages() is no-op on

Re: [PATCH] drm: rcar_lvds: Fix dual link mode operations

Hello Jacopo, Thank you for the patch. On Tue, Jul 23, 2019 at 06:57:00PM +0200, Jacopo Mondi wrote: > The R-Car LVDS encoder units support dual-link operations by splitting > the pixel output between the primary encoder and the companion one. s/the companion one/its companion/ > > In order fo

Re: [PATCH 2/2] drm: gm12u320: Use DRM_DEV_ERROR everywhere

On Tue, Jul 30, 2019 at 03:38:57PM +0200, Hans de Goede wrote: > Previously the driver was using a mix of DRM_ERROR and dev_err, be > consisent and use DRM_DEV_ERROR everywhere instead. > > Cc: Sam Ravnborg > Suggested-by: Sam Ravnborg > Signed-off-by: Hans de Goede Reviewed-by: Sam Ravnborg

Re: [PATCH 1/2] drm: gm12u320: Some minor cleanups

Hi Hans. On Tue, Jul 30, 2019 at 03:38:56PM +0200, Hans de Goede wrote: > 3 small cleanups: > > 1) Drop unused DRIVER_PATCHLEVEL > 2) We do not set mode_config.preferred_depth, so instead of passing the >unset mode_config.preferred_depth to drm_fbdev_generic_setup >simply pass 0 > 3) Use

Re: [PATCH] drm/komeda: Adds error event print functionality

Hi Lowry, On Thursday, 1 August 2019 12:37:15 BST Lowry Li (Arm Technology China) wrote: > From: "Lowry Li (Arm Technology China)" > > Adds to print the event message when error happens and the same event > will not be printed until next vsync. > > Changes since v1: > 1. Handling the event prin

Re: [PATCH 1/3] drm: msm: a6xx: Mark expected switch fall-through

On Fri, Jul 26, 2019 at 01:27:46PM +0200, Anders Roxell wrote: > When fall-through warnings was enabled by default the following warning > was starting to show up: > > ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function ‘a6xx_submit’: > ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:116:7: warning: th

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #21 from Jason Playne --- (In reply to Connor Abbott from comment #20) > I wanted to make sure that improving the NIR path to reach parity with TGSI > in local variable handling wouldn't break things, so I investigated this a > bit m

[Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega

https://bugs.freedesktop.org/show_bug.cgi?id=104602 --- Comment #20 from Connor Abbott --- I wanted to make sure that improving the NIR path to reach parity with TGSI in local variable handling wouldn't break things, so I investigated this a bit more. It seems this is triggered by the fact that o

Re: [PATCH] drm/syncobj: remove boring message

Am 01.08.19 um 15:45 schrieb Lionel Landwerlin: > Just had a few exchanges with Chris about this. > Chris suggests that if we're about to add a point to the timeline in > an unordered fashion, actually better not add it at all. > > What's your take on this? That is a clear NAK. See not adding a p

[PATCH 4/4] drm/panel/ili9341: Support DPI panels

Add support for panels that use the DPI interface. ILI9341 has onboard RAM so the assumption made here is that all such panels support pixel upload over DBI. The presence/absense of the Device Tree 'port' node decides which interface is used for pixel transfer. Signed-off-by: Noralf Trønnes ---

[PATCH 3/4] drm/tiny/mi0283qt: Move driver to panel-ilitek-ili9341

The MI0283QT panels use a ILI9341 controller so it makes sense to merge it with the other ili9341 code. The DRM driver name is ABI, so that is retained. Cc: David Lechner Signed-off-by: Noralf Trønnes --- MAINTAINERS | 9 +- drivers/gpu/drm/panel/Kconfig

[PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

Move the driver to drm/panel and take advantage of the new panel support in drm_mipi_dbi. Change the file name to match the naming standard in drm/panel. The DRM driver name is kept since it is ABI. Add missing MAINTAINERS entry. Cc: David Lechner Signed-off-by: Noralf Trønnes --- MAINTAINERS

[PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

This adds a function that registers a DRM driver for use with MIPI DBI panels in command mode. That is, framebuffer upload over DBI. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_mipi_dbi.c | 92 ++ include/drm/drm_mipi_dbi.h | 34 + 2 file

[PATCH 0/4] drm/mipi-dbi: Support panel drivers

This series adds drm_panel support to drm_mipi_dbi. This avoids having 2 drivers for the same controller, one per interface DPI/DBI. Some display controllers like the ILI9341 support both interfaces and some displays/panels make both these interfaces available. Some info about why MIPI DBI is spec

Re: [PATCH] drm/komeda: Adds error event print functionality

On Thu, Aug 01, 2019 at 11:37:15AM +, Lowry Li (Arm Technology China) wrote: > From: "Lowry Li (Arm Technology China)" > > Adds to print the event message when error happens and the same event > will not be printed until next vsync. > > Changes since v1: > 1. Handling the event print by CONF

Re: [PATCH] drm/syncobj: remove boring message

Just had a few exchanges with Chris about this. Chris suggests that if we're about to add a point to the timeline in an unordered fashion, actually better not add it at all. What's your take on this? I'm fine with this, but rather than add another variant of add_point() maybe we change change

Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

On 2019-08-01 8:19 a.m., Rong Chen wrote: > Hi, > > On 7/31/19 6:21 PM, Michel Dänzer wrote: >> On 2019-07-31 11:25 a.m., Huang, Ying wrote: >>> Hi, Daniel, >>> >>> Daniel Vetter writes: >>> On Tue, Jul 30, 2019 at 10:27 PM Dave Airlie wrote: > On Wed, 31 Jul 2019 at 05:00, Daniel Vette

Re: [PATCH v2 0/6] Unmappable DRM client buffers for fbdev emulation

On Thu, Aug 01, 2019 at 01:38:18PM +0200, Daniel Vetter wrote: > On Thu, Aug 1, 2019 at 9:04 AM Gerd Hoffmann wrote: > > > > Hi, > > > > > and removes a large amount of framebuffer code from these drivers. For > > > bochs, a problem was reported where the driver could not display the > > > cons

[PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64"

commit 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") broke all of the !llc i915-vgem coherency tests in CI, and left the HW very, very unhappy (which is even more scary). Fixes: 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") Signed-off-by: Chris Wilson Cc: D

Re: [PATCH] drm/vgem: fix cache synchronization on arm/arm64

Quoting Sean Paul (2019-07-31 20:23:31) > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote: > > On Wed, Jul 17, 2019 at 02:15:37PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > drm_cflush_pages() is no-op on arm/arm64. But instead we can use > > > dma_sync API. > > > >

Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable

Hi Andrzej, I had to revert the previous patch, so you should re-spin it entirely : After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_conne

Re: [PATCH 2/2] drm: bridge: adv7511: Add support for ADV7535

Hi Laurent, Thnk you for your review. On Wed, 2019-07-31 at 12:14 +0300, Laurent Pinchart wrote: > [External] > > Hi Bogdan, > > Thank you for the patch. > > On Tue, Jul 30, 2019 at 04:17:36PM +0300, Bogdan Togorean wrote: > > ADV7535 is a DSI to HDMI bridge chip like ADV7533 but it allows > >

Re: [PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

On 01/08/2019 14:01, Daniel Vetter wrote: > On Thu, Aug 1, 2019 at 1:53 PM Neil Armstrong wrote: >> >> This reverts commit bed7a2182de6833f5d0f990a656bffb1c6000c70. >> >> It causes the following build error: >> ../drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector': >> ../drm

Re: [PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

On Thu, Aug 1, 2019 at 1:53 PM Neil Armstrong wrote: > > This reverts commit bed7a2182de6833f5d0f990a656bffb1c6000c70. > > It causes the following build error: > ../drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector': > ../drm/radeon/radeon_connectors.c:2433:5: error: 'ddc' u

Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

Hi Am 01.08.19 um 13:25 schrieb Feng Tang: > Hi Thomas, > > On Thu, Aug 01, 2019 at 11:59:28AM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 01.08.19 um 10:37 schrieb Feng Tang: >>> On Thu, Aug 01, 2019 at 02:19:53PM +0800, Rong Chen wrote: > > commit: 90f479ae51afa45efab

[PATCH 2/3] drm/ast: Map fbdev framebuffer while it's being displayed

The generic fbdev emulation will map and unmap the framebuffer's memory if required. As consoles are most often updated while being on screen, we map the fbdev buffer while it's being displayed. This avoids frequent map/unmap operations in the fbdev code. The original fbdev code in ast used the sam

[PATCH 0/3] drm/vram-helper: Fix performance regression in fbdev

Generic fbdev emulation maps and unmaps the console BO for updating it's content from the shadow buffer. Drivers using VRAM helpers may see reduced performance as the mapping operations can create significant overhead. A report of this problem is at [1]. This patch set fixes the problem by adding

[PATCH 1/3] drm/vram-helpers: Add kmap ref-counting to GEM VRAM objects

The kmap and kunmap operations of GEM VRAM buffers can now be called in interleaving pairs. The first call to drm_gem_vram_kmap() maps the buffer's memory to kernel address space and the final call to drm_gem_vram_kunmap() unmaps the memory. Intermediate calls to these functions increment or decrem

  1   2   >