On Thu, Aug 1, 2019 at 7:01 AM Colin King <colin.k...@canonical.com> wrote:
>
> From: Colin Ian King <colin.k...@canonical.com>
>
> Currenly the error check on variable instance is always false because
> it is a uint32_t type and this is never less than zero. Fix this by
> making it an int type.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 7d0e6329dfdc ("drm/amdgpu: update more sdma instances irq support")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index a33bd867287e..92257f2bf171 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -1962,7 +1962,8 @@ static int sdma_v4_0_process_trap_irq(struct
> amdgpu_device *adev,
> static int sdma_v4_0_process_ras_data_cb(struct amdgpu_device *adev,
> struct amdgpu_iv_entry *entry)
> {
> - uint32_t instance, err_source;
> + uint32_t err_source;
> + int instance;
>
> instance = sdma_v4_0_irq_id_to_seq(entry->client_id);
> if (instance < 0)
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
