[PATCH -fixes 2/2] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-19 Thread Thomas Hellstrom
From: Thomas Zimmermann When calling vmw_fb_set_par(), the mode stored in par->set_mode gets free'd twice. The first free is in vmw_fb_kms_detach(), the second is near the end of vmw_fb_set_par() under the name of 'old_mode'. The mode-setting code only works correctly if the mode doesn't actually

[PATCH -fixes 1/2] drm/vmwgfx: Return 0 when gmrid::get_node runs out of ID's

2019-03-19 Thread Thomas Hellstrom
From: Deepak Rawat If it's not a system error and get_node implementation accommodate the buffer object then it should return 0 with memm::mm_node set to NULL. v2: Test for id != -ENOMEM instead of id == -ENOSPC. Cc: Fixes: 4eb085e42fde ("drm/vmwgfx: Convert to new IDA API") Signed-off-by: Dee

Re: [21/21] drm/bridge: tc358767: implement naive HPD handling

2019-03-19 Thread Tomi Valkeinen
On 19/03/2019 20:18, Andrey Smirnov wrote: > TC358767 has two GPIO pins that can be used for HPD signal. I think > instead of hardcoding GPIO0 here it would be more flexible to expose > boths gpios as a gpiochip and use gpiolib API to query the value of > HPD as well as use "hpd-gpios" binidng in

Re: [PATCH] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-03-19 Thread CK Hu
Hi, Hsin-yi: On Wed, 2019-03-20 at 13:39 +0800, Hsin-Yi Wang wrote: > On Wed, Mar 20, 2019 at 11:09 AM CK Hu wrote: > > > > Hi, Hsin-yi: > > > > On Mon, 2019-03-18 at 12:09 +0800, Hsin-Yi Wang wrote: > > > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), > > > which needs > >

RE: [v5 02/13] drm: Parse HDR metadata info from EDID

2019-03-19 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Friday, March 15, 2019 12:56 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; dri- >de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; emil.l.veli...@gmail.com; brian.star...@arm.com; >liviu.du...@arm.com >Subj

RE: [v5 01/13] drm: Add HDR source metadata property

2019-03-19 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Friday, March 15, 2019 12:39 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; dri- >de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; emil.l.veli...@gmail.com; brian.star...@arm.com; >liviu.du...@arm.com >Subj

[PATCH 9/9] drm/amdgpu: update version for timeline syncobj support in amdgpu

2019-03-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 8a0732088640..4d8db87048d3 100644 --- a/drivers/gpu/drm/amd/amdgp

[PATCH 8/9] drm/syncobj: add timeline signal ioctl for syncobj v4

2019-03-19 Thread Chunming Zhou
v2: individually allocate chain array, since chain node is free independently. v3: all existing points must be already signaled before cpu perform signal operation, so add check condition for that. v4: remove v3 change and add checking to prevent out-of-order Signed-off-by: Chunming Zhou Cc:

[PATCH 5/9] drm/syncobj: use the timeline point in drm_syncobj_find_fence v4

2019-03-19 Thread Chunming Zhou
From: Christian König Implement finding the right timeline point in drm_syncobj_find_fence. v2: return -EINVAL when the point is not submitted yet. v3: fix reference counting bug, add flags handling as well v4: add timeout for find fence Signed-off-by: Christian König Cc: Lionel Landwerlin --

[PATCH 7/9] drm/syncobj: add transition iotcls between binary and timeline v2

2019-03-19 Thread Chunming Zhou
we need to import/export timeline point. v2: unify to one transfer ioctl Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 74 ++ include/uapi/drm

[PATCH 3/9] drm/syncobj: add support for timeline point wait v8

2019-03-19 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become available v4: rebase v5: add comment for xxx_WAIT_AVAI

[PATCH 6/9] drm/amdgpu: add timeline support in amdgpu CS v3

2019-03-19 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. v2: separate to two kinds in/out_deps functions v3: fix checking for timeline syncobj Signed-off-by: Chunming Zhou Cc: Tobias Hector Cc: Jason Ekstrand Cc: Dave Airlie Cc: Chris Wilson Cc: Lionel Landwerlin --- drivers/gpu/dr

[PATCH 4/9] drm/syncobj: add timeline payload query ioctl v6

2019-03-19 Thread Chunming Zhou
user mode can query timeline payload. v2: check return value of copy_to_user v3: handle querying entry by entry v4: rebase on new chain container, simplify interface v5: query last signaled timeline point, not last point. v6: add unorder point check Signed-off-by: Chunming Zhou Cc: Tobias Hector

[PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-19 Thread Chunming Zhou
From: Christian König Lockless container implementation similar to a dma_fence_array, but with only two elements per node and automatic garbage collection. v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno, drop prev reference during garbage collection if it's no

[PATCH 2/9] drm/syncobj: add new drm_syncobj_add_point interface v4

2019-03-19 Thread Chunming Zhou
From: Christian König Use the dma_fence_chain object to create a timeline of fence objects instead of just replacing the existing fence. v2: rebase and cleanup v3: fix garbage collection parameters v4: add unorder point check, print a warn calltrace Signed-off-by: Christian König Cc: Lionel La

[Bug 110201] mesa 19.0.0 breaks rendering in kitty

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110201 --- Comment #1 from Kovid Goyal --- Created attachment 143737 --> https://bugs.freedesktop.org/attachment.cgi?id=143737&action=edit api trace output of running kitty on mesa 19 -- You are receiving this mail because: You are the assignee for

[Bug 110201] mesa 19.0.0 breaks rendering in kitty

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110201 Bug ID: 110201 Summary: mesa 19.0.0 breaks rendering in kitty Product: Mesa Version: 19.0 Hardware: Other OS: All Status: NEW Severity: normal

Re: [PATCH 8/9] drm/syncobj: add timeline signal ioctl for syncobj v3

2019-03-19 Thread zhoucm1
On 2019年03月19日 19:54, Lionel Landwerlin wrote: On 15/03/2019 12:09, Chunming Zhou wrote: v2: individually allocate chain array, since chain node is free independently. v3: all existing points must be already signaled before cpu perform signal operation, so add check condition for that.

Re: [PATCH] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-03-19 Thread CK Hu
Hi, Hsin-yi: On Mon, 2019-03-18 at 12:09 +0800, Hsin-Yi Wang wrote: > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which > needs > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is cal

[PATCH libdrm] tests/amdgpu: minor fix for dispatch/draw test

2019-03-19 Thread Cui, Flora
1. clear cmd buffer 2. make amdgpu_memcpy_dispatch_test static 3. tab/space fix Change-Id: Idf55f8881f66458b585092eccb55b6042520e4ad Signed-off-by: Flora Cui --- tests/amdgpu/basic_tests.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tests/amdgpu/basi

[Bug 110142] "Oops: Kernel access of bad area sig 7" on Kernel 5.0.0 PPC64LE when loading amdgpu, xorg hangs after being unable to load after OS boots.

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110142 --- Comment #9 from Peter Easton --- (In reply to Michel Dänzer from comment #7) > Please try https://patchwork.freedesktop.org/patch/292720/ , it should fix > the problem. Splice the mainbrace! It worked like a charm! It worked, xfce4 starte

RE: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-19 Thread Pan, Xinhui
these two enumerated types are same for now. both of them might change in the future. I have not used clang, but would .block_id = (int)head->block fix your warning? If such change is acceptable, I can make one then. Thanks xinhui -Original Message- From: Nathan Chancellor Sent: 2

[Bug 110142] "Oops: Kernel access of bad area sig 7" on Kernel 5.0.0 PPC64LE when loading amdgpu, xorg hangs after being unable to load after OS boots.

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110142 --- Comment #8 from Peter Easton --- Great, I'll go try it on 5.0.2 and report back, thanks! -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-de

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread John Stultz
On Tue, Mar 19, 2019 at 2:58 PM Rob Clark wrote: > > On Tue, Mar 19, 2019 at 1:00 PM Andrew F. Davis wrote: > > > > On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > > > Le mer. 13 mars 2019 à 23:31, John Stultz a > > > écrit : > > >> > > >> On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: > > >

[RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-03-19 Thread Maxime Ripard
V4L2 uses different fourcc's than DRM, and has a different set of formats. For now, let's add the v4l2 fourcc's for the already existing formats. Signed-off-by: Maxime Ripard --- include/linux/image-formats.h | 9 +- lib/image-formats.c | 67 -

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread Rob Clark
On Tue, Mar 19, 2019 at 1:00 PM Andrew F. Davis wrote: > > On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > > Le mer. 13 mars 2019 à 23:31, John Stultz a écrit : > >> > >> On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: > >>> On Tue, 5 Mar 2019, John Stultz wrote: > > Eventual TODOS: >

[RFC PATCH 14/20] drm/omap: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/omapdrm/dss/dispc.c | 9 + drivers/gpu/drm/omapdrm/omap_fb.c | 7 --- 2 files changed, 9 insertions(+), 7 del

[RFC PATCH 19/20] lib: image-formats: Add more functions

2019-03-19 Thread Maxime Ripard
V4L2 drivers typically need a few more helpers compared to DRM drivers, so let's add them. Signed-off-by: Maxime Ripard --- include/linux/image-formats.h | 4 +++- lib/image-formats.c | 42 - 2 files changed, 46 insertions(+) diff --git a/include/l

[RFC PATCH 16/20] drm/tegra: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tegra/plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/plane.c b/drivers/

[RFC PATCH 17/20] drm/fourcc: Remove old DRM format API

2019-03-19 Thread Maxime Ripard
Now that all the clients of the old drm_format* API have been converted to the generic one, let's remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 1 +- drivers/gpu/drm/drm_fourcc.c| 253 + drivers/gpu/drm/sel

[RFC PATCH 20/20] media: sun6i: Convert to the image format API

2019-03-19 Thread Maxime Ripard
The image format API allows us to remove some of the computation we need to handle the various video formats. Signed-off-by: Maxime Ripard --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 88 +++ drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 46 + 2 files chang

[RFC PATCH 08/20] drm/malidp: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_drv.c | 3 ++- drivers/gpu/drm/arm/malidp_hw.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff -

[RFC PATCH 06/20] lib: Add video format information library

2019-03-19 Thread Maxime Ripard
Move the DRM formats API to turn this into a more generic image formats API to be able to leverage it into some other places of the kernel, such as v4l2 drivers. Signed-off-by: Maxime Ripard --- include/linux/image-formats.h | 240 +++- lib/Kconfig | 7 +- lib/Makefil

[RFC PATCH 13/20] drm/msm: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6 -- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 ++- drivers/gpu/drm/msm/disp/mdp5/

[RFC PATCH 09/20] drm/client: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert the rest of the DRM core to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm

[RFC PATCH 03/20] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp

2019-03-19 Thread Maxime Ripard
So far, the drm_format_plane_cpp function was operating on the format's fourcc and was doing a lookup to retrieve the drm_format_info structure and return the cpp. However, this is inefficient since in most cases, we will have the drm_format_info pointer already available so we shouldn't have to p

[RFC PATCH 05/20] drm: Replace instances of drm_format_info by drm_get_format_info

2019-03-19 Thread Maxime Ripard
drm_get_format_info directly calls into drm_format_info, but takes directly a struct drm_mode_fb_cmd2 pointer, instead of the fourcc directly. It's shorter to not dereference it, and we can customise the behaviour at the driver level if we want to, so let's switch to it where it makes sense. Signe

[RFC PATCH 15/20] drm/rockchip: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/ro

[RFC PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-03-19 Thread Maxime Ripard
Hi, DRM comes with an extensive format support to retrieve the various parameters associated with a given format (such as the subsampling, or the bits per pixel), as well as some helpers and utilities to ease the driver development. v4l2, on the other side, doesn't provide such facilities, leavin

[RFC PATCH 01/20] drm: Remove users of drm_format_num_planes

2019-03-19 Thread Maxime Ripard
drm_format_num_planes() is basically a lookup in the drm_format_info table plus an access to the num_planes field of the appropriate entry. Most drivers are using this function while having access to the entry already, which means that we will perform an unnecessary lookup. Removing the call to dr

[RFC PATCH 11/20] drm/i915: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_sprite.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-

[RFC PATCH 02/20] drm: Remove users of drm_format_(horz|vert)_chroma_subsampling

2019-03-19 Thread Maxime Ripard
drm_format_horz_chroma_subsampling and drm_format_vert_chroma_subsampling are basically a lookup in the drm_format_info table plus an access to the hsub and vsub fields of the appropriate entry. Most drivers are using this function while having access to the entry already, which means that we will

[RFC PATCH 07/20] drm/fb: Move from drm_format_info to image_format_info

2019-03-19 Thread Maxime Ripard
Start converting the DRM drivers by changing the struct drm_framebuffer structure to hold a pointer to image_format_info instead, and converting everyone that depends on it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 1 +- drivers/gpu/drm/amd/amdgpu/amdgp

[RFC PATCH 12/20] drm/ipuv3: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/ipu-v3/ipu-pre.c | 3 ++- drivers/gpu/ipu-v3/ipu-prg.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dr

[RFC PATCH 04/20] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height

2019-03-19 Thread Maxime Ripard
So far, the drm_format_plane_height/width functions were operating on the format's fourcc and was doing a lookup to retrieve the drm_format_info structure and return the cpp. However, this is inefficient since in most cases, we will have the drm_format_info pointer already available so we shouldn'

[RFC PATCH 10/20] drm/exynos: Convert to generic image format library

2019-03-19 Thread Maxime Ripard
Now that we have a generic image format libary, let's convert drivers to use it so that we can deprecate the old DRM one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/exynos/exynos_drm_ipp.c| 2 +- drivers/gpu/drm/exynos/exynos_drm_ipp.h| 4 +++- drivers/gpu/drm/exynos/exynos_drm_sca

Re: [PATCH] pci/quirks: Add quirk to reset nvgpu at boot for the Lenovo ThinkPad P50

2019-03-19 Thread Lyude Paul
Bump, sorry to bug you but is there any update on this or any information you still need from me which would help get this upstream? On Wed, 2019-03-13 at 18:25 -0400, Lyude Paul wrote: > [note to David Ober: you -should- be able to reply to this, hopefully, but I > haven't actually tested that so

Re: randr: Virtual monitor not present with MST display

2019-03-19 Thread Wentland, Harry
On 2019-03-18 5:58 p.m., Paul Menzel wrote: > > Dear Harry, > ... snip ... >> >> Michel, do you know if this is supposed to work with >> xf86-video-amdgpu? When I've tried it before I didn't have any luck but >> didn't have time to look into it. > > Sorry, what is your question. With the com

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #69 from Bastian --- Distro/Kernel: Ubuntu 18.04.2/5.0.2 GPU AMD: Readon RX570 - Mesa 19.0 Display: Iiyama G23530HSU 75hz Desktop: Gnome video: https://www.youtube.com/watch?v=gNJ2kJ8hsHA Have the same problem as

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #10 from Alex Deucher --- (In reply to L.S.S. from comment #9) > Just tested... it seems if I connect to the monitor directly the problem > doesn't occur. > > Guess the KVM does play a part in this. However, I still need the KVM as

[Bug 110199] [amdgpu] Screen flickering when using a 75Hz monitor paired with an RX 480 GPU

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110199 Maxim Ivanov changed: What|Removed |Added Priority|medium |high -- You are receiving this mail bec

[Bug 110199] [amdgpu] Screen flickering when using a 75Hz monitor paired with an RX 480 GPU

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110199 Bug ID: 110199 Summary: [amdgpu] Screen flickering when using a 75Hz monitor paired with an RX 480 GPU Product: DRI Version: XOrg git Hardware: x86-64 (AMD64)

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #9 from L.S.S. --- Just tested... it seems if I connect to the monitor directly the problem doesn't occur. Guess the KVM does play a part in this. However, I still need the KVM as I've four PCs connected to this monitor. It's not a

Re: [PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-19 Thread Thomas Hellstrom
Hi, Deepak, On Mon, 2019-03-18 at 09:59 -0700, Deepak Singh Rawat wrote: > Hi Thomas, > > Thanks for doing this and somehow I missed the last patch, sorry > about > that. Have some questions below otherwise the patch looks good to me. > > Reviewed-by: Deepak Rawat > > I will include your chang

[Bug 108917] gamma adjustments cause stuttering with amdgpu.dc=1, especially problematic with RedShift etc.

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108917 --- Comment #10 from tempel.jul...@gmail.com --- Thanks for the information, really a relief to know that this is being worked on. Does this aim to achieve as good performance as with "legacy DC" for every window operation as well? Would it work

Re: [PATCH, RESEND] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-19 Thread Thomas Zimmermann
Hi Deepak Am 18.03.19 um 17:59 schrieb Deepak Singh Rawat: > Hi Thomas, > > Thanks for doing this and somehow I missed the last patch, sorry about > that. Have some questions below otherwise the patch looks good to me. > > Reviewed-by: Deepak Rawat > > I will include your changes in vmwgfx-nex

Re: [PATCH v3] drm/fourcc: add ARM GPU tile modifier

2019-03-19 Thread Alyssa Rosenzweig
> We don't know if this is a "category" per-se, or just a single Utgard > tiling format - as discussed I'm trying to get an answer for that. FWIW, as I think I mentioned on an message, this format is used on Midgard as well, and presumably also Bifrost. On Midgard, when a texture is uploaded (jus

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-19 Thread Måns Rullgård
Maxime Ripard writes: > On Mon, Mar 18, 2019 at 04:23:56PM +, Måns Rullgård wrote: >> Maxime Ripard writes: >> >> > On Thu, Mar 14, 2019 at 04:09:13PM +, Måns Rullgård wrote: >> >> Maxime Ripard writes: >> >> >> >> > On Mon, Mar 11, 2019 at 04:11:06PM +, Måns Rullgård wrote: >> >> >

[PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 13

[PATCH] fbdev: fix divide error in fb_var_to_videomode

2019-03-19 Thread shile . zhang
From: Shile Zhang To fix following divide-by-zero error found by Syzkaller: divide error: [#1] SMP PTI CPU: 7 PID: 8447 Comm: test Kdump: loaded Not tainted 4.19.24-8.al7.x86_64 #1 Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2

Aw: Re: Re: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device

2019-03-19 Thread Frank Wunderlich
Hi, i try to get hdmi running on bananapi-r2 with 5.1 but also without CK Hu's frambuffer-Patch i get no x-server working my codebase: https://github.com/frank-w/BPI-R2-4.14/commits/5.1-hdmi reused some Patches working on 5.0 (here X-server is working, but not fbcon) WARNING: CPU: 2 PID: 895 at

Re: [PATCH] drm: etnaviv: fix strncpy sizeof argument

2019-03-19 Thread Bo YU
On Tue, Mar 19, 2019 at 6:22 PM Russell King - ARM Linux admin wrote: > > On Mon, Mar 18, 2019 at 10:57:55PM -0400, Bo YU wrote: > > Calling strncpy with a maximum size argument of 64 bytes on destination > > array "domain->name" of size 64 bytes might leave the destination string > > unterminated

Re: [PATCH v8 02/15] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-03-19 Thread Sergey Suloev
Hi, guys, On 3/19/19 1:53 PM, Maxime Ripard wrote: On Mon, Mar 11, 2019 at 09:36:27PM +0530, Jagan Teki wrote: On Mon, Mar 11, 2019 at 9:08 PM Maxime Ripard wrote: On Mon, Mar 11, 2019 at 07:06:24PM +0530, Jagan Teki wrote: pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical M

[PATCH 2/2] drm/omap: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 ++ 1 file changed, 6 insertions(+

Re: [linux-sunxi] [PATCH v3 02/28] clk: sunxi-ng: Adjust MP clock parent rate when allowed

2019-03-19 Thread Priit Laes
On Mon, Jan 21, 2019 at 07:13:07PM +0100, Jernej Škrabec wrote: > Dne ponedeljek, 21. januar 2019 ob 14:34:33 CET je Priit Laes napisal(a): > > On Mon, Jan 21, 2019 at 08:37:29AM +, Priit Laes wrote: > > > On Fri, Jan 18, 2019 at 10:51:10PM +0100, Jernej Škrabec wrote: > > > > Dne četrtek, 17.

Re: [PATCH v2 7/8] drm/meson: Add YUV420 output support

2019-03-19 Thread Maxime Jourdan
Hi Neil, On Fri, Feb 1, 2019 at 1:08 PM Neil Armstrong wrote: > > This patch adds support for the YUV420 output from the Amlogic Meson SoCs > Video Processing Unit to the HDMI Controller. > > The YUV420 is obtained by generating a YUV444 pixel stream like > the classic HDMI display modes, but the

[Bug 109338] hdmi/displayport audio is a semitone lower when amdgpu driver is used

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109338 --- Comment #1 from Thanos Apostolou --- Still present with linux 5.0.x -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop

Re: [PATCH 1/2] drm/doc: fix kerneldoc syntax

2019-03-19 Thread Luca Ceresoli
On 14/03/19 11:41, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 04:35:36PM +0100, Luca Ceresoli wrote: >> The probe() reference renders incorrectly and without a link, fix it. >> >> Also fix a typo reported by checkpatch in the context lines. >> >> Signed-off-by: Luca Ceresoli >> --- >> drivers

[Bug 108323] RX580 starts doing a constant noise after setting fans to a fixed value, then back to auto

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108323 bmil...@gmail.com changed: What|Removed |Added Priority|medium |high Severity|normal

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread Andrew F. Davis
On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > Le mer. 13 mars 2019 à 23:31, John Stultz a écrit : >> >> On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: >>> On Tue, 5 Mar 2019, John Stultz wrote: Eventual TODOS: * Reimplement page-pool for system heap (working on this) * Add

Re: Indirect call in vesafb driver

2019-03-19 Thread Alan Cox
On Wed, 13 Mar 2019 17:54:18 +0300 Alexander Pateenok wrote: > Hi, > > There're several indirect calls in inline assembly in vesafb driver > (drivers/video/fbdev/vesafb.c), and these calls cannot be automatically > changed to retpolines. It's in vesafb_pan_display(): > >73__asm__ __

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread Benjamin Gaignard
Le mer. 13 mars 2019 à 23:31, John Stultz a écrit : > > On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: > > On Tue, 5 Mar 2019, John Stultz wrote: > > > > > > Eventual TODOS: > > > * Reimplement page-pool for system heap (working on this) > > > * Add stats accounting to system/cma heaps > > > *

[Bug 108917] gamma adjustments cause stuttering with amdgpu.dc=1, especially problematic with RedShift etc.

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108917 --- Comment #9 from Nicholas Kazlauskas --- (In reply to tempel.julian from comment #8) > Unfortunately, Linux 5.0.3 with > > drm: Block fb changes for async plane updates > commit 25dc194b34dd5919dd07b8873ee338182e15df9d > > hasn't changed th

[Bug 108917] gamma adjustments cause stuttering with amdgpu.dc=1, especially problematic with RedShift etc.

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108917 --- Comment #8 from tempel.jul...@gmail.com --- Unfortunately, Linux 5.0.3 with drm: Block fb changes for async plane updates commit 25dc194b34dd5919dd07b8873ee338182e15df9d hasn't changed the situation, as far as I can tell. :( -- You are re

Re: [PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-19 Thread Ville Syrjälä
On Tue, Mar 19, 2019 at 05:06:36PM +0100, Maarten Lankhorst wrote: > Op 19-03-2019 om 14:02 schreef Ville Syrjälä: > > On Tue, Mar 19, 2019 at 01:17:02PM +0100, Maarten Lankhorst wrote: > >> There has unfortunately been a conflict with the following 3 commits: > >> > >> commit e9961ab95af81b8d29054

Re: [PATCH v4 01/10] drm/fourcc: Add AFBC yuv fourccs for Mali

2019-03-19 Thread Maarten Lankhorst
Hey, Op 19-03-2019 om 00:27 schreef Ayan Halder: > On Mon, Mar 18, 2019 at 07:12:24PM +0100, Maarten Lankhorst wrote: >> Op 18-03-2019 om 16:40 schreef Brian Starkey: >>> Hi, >>> >>> On Mon, Mar 18, 2019 at 11:17:55AM +0100, Maarten Lankhorst wrote: >>> >>> >>> Hey.. There's a conf

Re: [PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-19 Thread Maarten Lankhorst
Op 19-03-2019 om 14:02 schreef Ville Syrjälä: > On Tue, Mar 19, 2019 at 01:17:02PM +0100, Maarten Lankhorst wrote: >> There has unfortunately been a conflict with the following 3 commits: >> >> commit e9961ab95af81b8d29054361cd5f0c575102cf87 >> Author: Ayan Kumar Halder >> Date: Fri Nov 9 17:21:

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-19 Thread Andrew F. Davis
On 3/19/19 7:08 AM, Brian Starkey wrote: > Hi John, > > On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: >> From: "Andrew F. Davis" > > [snip] > >> + >> +#define NUM_HEAP_MINORS 128 >> +static DEFINE_IDR(dma_heap_idr); >> +static DEFINE_MUTEX(minor_lock); /* Protect idr accesses */

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-19 Thread Andrew F. Davis
On 3/15/19 4:06 AM, Christoph Hellwig wrote: >> +ret = remap_pfn_range(vma, addr, page_to_pfn(page), len, >> + vma->vm_page_prot); > > So the same chunk could be mapped to userspace and vmap, and later on > also DMA mapped. Who is going to take care of

Re: [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss

2019-03-19 Thread Brian Starkey
On Tue, Mar 05, 2019 at 12:54:32PM -0800, John Stultz wrote: > This adds a CMA heap, which allows userspace to allocate > a dma-buf of contiguous memory out of a CMA region. > > This code is an evolution of the Android ION implementation, so > thanks to its original author and maintainters: > Be

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-03-19 Thread Liviu Dudau
On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: > [ +Sudeep - just FYI ] > > Hi Liviu, > > On 27/02/2019 09:40, Liviu Dudau wrote: > > Hi Robin, > > > > Sorry for the delay in reviewing this patch, I am drowning a bit this > > week in meetings :) > > > > On Mon, Feb 25, 2019 at 02

Re: [PATCH v4 5/6] dt-bindings: display: sii902x: Add HDMI audio bindings

2019-03-19 Thread Jyri Sarha
On 17/03/2019 18:16, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Thu, Mar 14, 2019 at 01:27:51PM +0200, Jyri Sarha wrote: >> The sii902x chip family supports also HDMI audio. Add binding for >> describing the necessary i2s and mclk wiring for it. >> >> Signed-off-by: Jy

[Bug 110184] kernel BUG at drivers/dma-buf/reservation.c:172 (kernel 5.0.2)

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110184 Alex Deucher changed: What|Removed |Added Component|DRM/AMDgpu |DRM/Radeon -- You are receiving this ma

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-19 Thread Brian Starkey
Hi John, On Tue, Mar 05, 2019 at 12:54:30PM -0800, John Stultz wrote: ... > + > +void dma_heap_buffer_destroy(struct dma_heap_buffer *heap_buffer) > +{ > + struct heap_helper_buffer *buffer = to_helper_buffer(heap_buffer); > + > + if (buffer->kmap_cnt > 0) { > + pr_warn_once(

Re: [PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-19 Thread Ayan Halder
On Tue, Mar 19, 2019 at 01:17:02PM +0100, Maarten Lankhorst wrote: > There has unfortunately been a conflict with the following 3 commits: > > commit e9961ab95af81b8d29054361cd5f0c575102cf87 > Author: Ayan Kumar Halder > Date: Fri Nov 9 17:21:12 2018 + > drm: Added a new format DRM_FORM

[Bug 107731] radeon (amdgpu) DisplayPort loss of max-resolution on DP monitor (after monitor power saving / idle)

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107731 --- Comment #8 from Harry Wentland --- (In reply to L.S.S. from comment #7) > from what I could find out. Before using a KVM (that I'm swapping between > its HDMI and DP inputs that were connected to different places), whenever I > switch the a

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-19 Thread Kazlauskas, Nicholas
On 3/19/19 9:23 AM, Kazlauskas, Nicholas wrote: > On 3/18/19 1:19 PM, Mario Kleiner wrote: >> In VRR mode, proper vblank/pageflip timestamps can only be computed >> after the display scanout position has left front-porch. Therefore >> delay calls to drm_crtc_handle_vblank(), and thereby calls to >>

[PATCH] ARM: dts: exynos: Increase minimal ACLK400_DISP1 frequency on Exynos542x

2019-03-19 Thread Marek Szyprowski
ACLK400_DISP1 bus feeds some internal buses of the display subsystem, some of which are also related to TV/Mixer hardware modules. When that bus is set to 120MHz, Exynos Mixer is not able to properly handle two XRGB display planes at FullHD-60MHz. DMA underrun happens, which in turn might result in

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-19 Thread Kazlauskas, Nicholas
On 3/18/19 1:19 PM, Mario Kleiner wrote: > In VRR mode, proper vblank/pageflip timestamps can only be computed > after the display scanout position has left front-porch. Therefore > delay calls to drm_crtc_handle_vblank(), and thereby calls to > drm_update_vblank_count() and pageflip event delivery

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-03-19 Thread Robin Murphy
[ +Sudeep - just FYI ] Hi Liviu, On 27/02/2019 09:40, Liviu Dudau wrote: Hi Robin, Sorry for the delay in reviewing this patch, I am drowning a bit this week in meetings :) On Mon, Feb 25, 2019 at 02:39:13PM +, Robin Murphy wrote: When __drm_atomic_helper_disable_all() tries to commit th

Re: [PATCH 4/4] drm/amd/display: Make pageflip event delivery compatible with VRR.

2019-03-19 Thread Kazlauskas, Nicholas
On 3/18/19 1:19 PM, Mario Kleiner wrote: > We want vblank counts and timestamps of flip completion as sent > in pageflip completion events to be consistent with the vblank > count and timestamp of the vblank of flip completion, like in non > VRR mode. > > In VRR mode, drm_update_vblank_count() - a

[PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-19 Thread Andrzej Hajda
MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 to update internal state (shadow registers). Apparently the driver implements it incorrectly. The rule should be as follows: - do not request updating registers until previous request was finished, ie. MXR_CFG_LAYER_UPDATE_C

Re: [PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-19 Thread Ville Syrjälä
On Tue, Mar 19, 2019 at 01:17:02PM +0100, Maarten Lankhorst wrote: > There has unfortunately been a conflict with the following 3 commits: > > commit e9961ab95af81b8d29054361cd5f0c575102cf87 > Author: Ayan Kumar Halder > Date: Fri Nov 9 17:21:12 2018 + > drm: Added a new format DRM_FORM

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-19 Thread Maxime Ripard
On Mon, Mar 18, 2019 at 04:23:56PM +, Måns Rullgård wrote: > Maxime Ripard writes: > > > On Thu, Mar 14, 2019 at 04:09:13PM +, Måns Rullgård wrote: > >> Maxime Ripard writes: > >> > >> > On Mon, Mar 11, 2019 at 04:11:06PM +, Måns Rullgård wrote: > >> >> Maxime Ripard writes: > >> >>

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v5

2019-03-19 Thread Christian König
Am 19.03.19 um 13:27 schrieb Lionel Landwerlin: On 15/03/2019 12:09, Chunming Zhou wrote: [SNIP] +/** + * struct dma_fence_chain - fence to represent an node of a fence chain + * @base: fence base class + * @lock: spinlock for fence handling + * @prev: previous fence of the chain + * @prev_seqno

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v5

2019-03-19 Thread Lionel Landwerlin
On 15/03/2019 12:09, Chunming Zhou wrote: From: Christian König Lockless container implementation similar to a dma_fence_array, but with only two elements per node and automatic garbage collection. v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno, drop prev r

[PATCH] drm/fourcc: Fix conflicting Y41x definitions

2019-03-19 Thread Maarten Lankhorst
There has unfortunately been a conflict with the following 3 commits: commit e9961ab95af81b8d29054361cd5f0c575102cf87 Author: Ayan Kumar Halder Date: Fri Nov 9 17:21:12 2018 + drm: Added a new format DRM_FORMAT_XVYU2101010 commit 7ba0fee247ee7a36b3bfbed68f6988d980aa3aa3 Author: Brian S

Re: [PATCH v3] drm/fourcc: add ARM GPU tile modifier

2019-03-19 Thread Brian Starkey
On Tue, Mar 19, 2019 at 08:05:32PM +0800, Qiang Yu wrote: > Hi Brian, > > > Since your first patch set, I did raise this internally. The request > > has been making it's way through: > > > > - GPU engineering, to determine what exactly this format is, and > >what other variants there might be

[Bug 108323] RX580 starts doing a constant noise after setting fans to a fixed value, then back to auto

2019-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108323 --- Comment #5 from jpalacios...@gmail.com --- (In reply to bmilreu from comment #3) > Yes, seems like the same issue. It would be useful to know if someone with a > non-Sapphire RX580 has the same problem. MSI RX 480 Gaming X is also affected.

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-19 Thread Brian Starkey
Hi John, On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > From: "Andrew F. Davis" [snip] > + > +#define NUM_HEAP_MINORS 128 > +static DEFINE_IDR(dma_heap_idr); > +static DEFINE_MUTEX(minor_lock); /* Protect idr accesses */ I saw that Matthew Wilcox is trying to nuke idr: https://

  1   2   >