>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
>>
>
> This one is fine
This kind of feedback is nice.
> except for the commit message.
Would you like to support Unicode chara
On 2017年10月24日 21:55, Christian König wrote:
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
Signed-off-by: Christian König
---
drivers/dma-buf/res
> But anyways I guess other people sometimes disagree with me.
Am I one of them? ;-)
> Unwinding is for when you allocate five things in a row.
This is a general issue.
I find that it is also needed in this function as usual.
> You have to undo four if the last allocation fails.
Concrete
From: Dave Airlie
We don't want fbcon to get used on non-desktop dislays,
don't pass them as enabled connectors to the fb helper setup.
This prevents my HMD from getting disorted fbcon, and from
affecting other displays console.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/drm_fb_helper.c |
From: Dave Airlie
This uses the EDID info from my HTC Vive to mark it as
non-desktop.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 1e24d5d9..2e8fb51 100644
--- a/dr
From: Dave Airlie
This adds the infrastructure needed to quirk displays
using edid and to mark them as non-desktop to denote
that userspace shouldn't display a standard desktop on them.
A non-desktop display is one which doesn't work like
a normal rectangular monitor or requires some transformat
On Tue, Oct 24, 2017 at 06:02:30PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 17:47:37 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl” pointed information out like the followi
This is a subtle thing but my preference on this type of thing is the
way the original code is written. I'm still slightly annoyed that
someone once made me rewrite a patch using the new style... But anyways
I guess other people sometimes disagree with me.
Unwinding is for when you allocate five
On 10/25/2017 1:13 AM, Andrey Grodzovsky wrote:
On 10/24/2017 12:06 PM, Michel Dänzer wrote:
On 24/10/17 06:00 PM, Andrey Grodzovsky wrote:
On 10/24/2017 11:43 AM, Michel Dänzer wrote:
On 24/10/17 04:58 PM, Andrey Grodzovsky wrote:
On 10/24/2017 10:36 AM, S, Shirish wrote:
On 10/24/2017
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #18 from Shih-Yuan Lee ---
(In reply to Mike Lothian from comment #16)
> Do you also see the issue with amdgpu rather than using the radeon kernel
> driver?
amdgpu doesn't support on this AMD graphics with the kernel parameters
"amd
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #17 from Shih-Yuan Lee ---
Created attachment 135027
--> https://bugs.freedesktop.org/attachment.cgi?id=135027&action=edit
Xorg.0.log
(In reply to Mike Lothian from comment #15)
> Are there any changes when you boot the system wit
This patch adds the mipi_dsi1 related needed information.
e.g.: interrupts, grf, clocks, ports and so on.
Signed-off-by: Nickey Yang
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3
This patch add dual mipi channel support:
1.add definition of dsi1 register and grf operation.
2.dsi0 and dsi1 will work in master and slave mode
when driving dual mipi panel.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377
drivers/g
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_r
This patch correct Feedback divider setting:
1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN
2、Due to the use of a "by 2 pre-scaler," the range of the
feedback multiplication Feedback divider is limited to even
division numbers, and Feedback divider must be greater than
12, less than 1000.
3、Make
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0>
should depend on frequency,so fix it.
Reviewed-by: Sean Paul
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 --
1 file changed, 70 insertions(+)
Replace the hardcoded register address numerical values with macros to
clarify the code.
Signed-off-by: Nickey Yang
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++---
1 file changed, 85 insertions(+), 44 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi
2017-10-25 7:40 GMT+08:00 Rob Herring :
> EGL, gralloc, and HWC must all have a common definition of fd's and int's
> in native_handle_t to share the fd and width, height, format, etc.
> of a dmabuf.
>
> Move the definition into HWC so we aren't dependent on a specific gralloc
> implementation and
2017-10-25 8:06 GMT+08:00 Rob Herring :
> Linking to libraries will add necessary include paths, so we don't need to
> list them explicitly.
>
> Still need libsync for sw_sync.h until this dependency is removed.
>
> Signed-off-by: Rob Herring
> ---
> Android.mk | 6 +-
> 1 file changed, 1 ins
https://bugs.freedesktop.org/show_bug.cgi?id=91375
--- Comment #12 from hkian...@gmail.com ---
Also experiencing this bug on a fresh install of Ubuntu 17.10. I'm using a
Radeon HD 7850.
harry@harry-ubuntu:~$ uname -a
Linux harry-ubuntu 4.13.0-16-generic #19-Ubuntu SMP Wed Oct 11 18:35:14 UTC
2017
Linking to libraries will add necessary include paths, so we don't need to
list them explicitly.
Still need libsync for sw_sync.h until this dependency is removed.
Signed-off-by: Rob Herring
---
Android.mk | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/Android.mk b/And
EGL, gralloc, and HWC must all have a common definition of fd's and int's
in native_handle_t to share the fd and width, height, format, etc.
of a dmabuf.
Move the definition into HWC so we aren't dependent on a specific gralloc
implementation and so we don't have to create an importer just for
dif
On Tue, Oct 24, 2017 at 9:39 AM, Noralf Trønnes wrote:
>
> Den 23.10.2017 23.32, skrev Kristian Høgsberg:
>>
>> On Mon, Oct 23, 2017 at 9:47 AM, Noralf Trønnes
>> wrote:
>>>
>>> Add debugfs file that dumps info about the framebuffers and its planes.
>>> Also dump info about any connected gem obje
On 10/24/2017 12:06 PM, Michel Dänzer wrote:
On 24/10/17 06:00 PM, Andrey Grodzovsky wrote:
On 10/24/2017 11:43 AM, Michel Dänzer wrote:
On 24/10/17 04:58 PM, Andrey Grodzovsky wrote:
On 10/24/2017 10:36 AM, S, Shirish wrote:
On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote:
On 10/24/2017 09
Thanks for the patch! Actually I would prefer that we can have different error
messages here. E.g. like copy_gma_to_hva fail in which part of ring buffer. Or
we can directly remove the error message since usually if it fails it means a
bug of MPT module when GVT-g is accessing the guest memory b
From: Markus Elfring
Date: Tue, 24 Oct 2017 19:21:24 +0200
Return the code "-EPROBE_DEFER" directly in one if branch
without assigning it to the local variable "err" before.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/tegra/output.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Markus Elfring
Date: Tue, 24 Oct 2017 19:12:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/tegra/output.c | 10 ++
From: Markus Elfring
Date: Tue, 24 Oct 2017 19:29:39 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code
Use an error code directly
drivers/gpu/drm/tegra/output.c | 13 +++--
1 file changed, 7 ins
https://bugzilla.kernel.org/show_bug.cgi?id=193651
--- Comment #27 from Milo (milo...@gmail.com) ---
i have added it /etc/default/grub as follows:
GRUB_CMDLINE_LINUX_DEFAULT="nointremap quiet amdgpu.audio=0"
and then ran update-grub
however it still takes more than 5 minutes to boot
On Mon, Oct
Warn when refcount > 0 in drm_vblank_cleanup.
Signed-off-by: PrasannaKumar Muralidharan
---
No change in v2.
drivers/gpu/drm/drm_vblank.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 70f2b95..3e61aeb 100644
--- a/drivers
In i915 driver unload drm_vblank_get is added to test whether
drm_vblank_cleanup refcount validation patch is working.
Signed-off-by: PrasannaKumar Muralidharan
---
Changes in v2:
Use drm_crtc_vblank_get instead of _put. In previous patch _put was wrongly
used.
drivers/gpu/drm/i915/i915_drv.c |
Den 24.10.2017 17.42, skrev Sean Paul:
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote:
Rename tinydrm_of_find_backlight to of_find_backlight and move
it to linux/backlight.c so that it can be used by other drivers.
Signed-off-by: Meghana Madhyastha
---
Changes in v14:
-s
Den 23.10.2017 23.32, skrev Kristian Høgsberg:
On Mon, Oct 23, 2017 at 9:47 AM, Noralf Trønnes wrote:
Add debugfs file that dumps info about the framebuffers and its planes.
Also dump info about any connected gem object(s).
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/drm_debugfs.c
On Tue, Oct 17, 2017 at 08:18:03PM +0800, Chen-Yu Tsai wrote:
> From: Jonathan Liu
>
> The video PLLs are used directly by the HDMI controller. Export them so
> that we can use them in our DT node.
>
> Signed-off-by: Jonathan Liu
> Signed-off-by: Chen-Yu Tsai
> ---
> drivers/clk/sunxi-ng/ccu-
On Tue, Oct 17, 2017 at 08:18:02PM +0800, Chen-Yu Tsai wrote:
> From: Jonathan Liu
>
> The A20 display pipeline has 2 frontends, 2 backends, and 2 TCONs.
> This patch adds support (or a compatible string in the frontend's
> case) for these components.
>
> The TCONs support directly outputting to
On Tue, Oct 17, 2017 at 08:18:02PM +0800, Chen-Yu Tsai wrote:
> From: Jonathan Liu
>
> The A20 display pipeline has 2 frontends, 2 backends, and 2 TCONs.
> This patch adds support (or a compatible string in the frontend's
> case) for these components.
>
> The TCONs support directly outputting to
On Tue, Oct 17, 2017 at 08:18:01PM +0800, Chen-Yu Tsai wrote:
> The A10 display pipeline has 2 frontends, 2 backends, and 2 TCONs.
> This patch adds support (or a compatible string in the frontend's
> case) for these components.
>
> The TCONs support directly outputting to CPU/RGB/LVDS LCD panels,
On Tue, Oct 17, 2017 at 08:18:00PM +0800, Chen-Yu Tsai wrote:
> The HDMI controller in the A10 SoC is the same as the one currently
> supported in the A10s. It has slightly different setup parameters.
> Since these parameters are not thoroughly understood, we add support
> for this variant by copyi
Quoting Kees Cook (2017-10-24 16:13:44)
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
On 10/24/2017 11:43 AM, Michel Dänzer wrote:
[ Adding the dri-devel list ]
On 24/10/17 04:58 PM, Andrey Grodzovsky wrote:
On 10/24/2017 10:36 AM, S, Shirish wrote:
On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote:
On 10/24/2017 09:51 AM, S, Shirish wrote:
From: Shirish S
On some systems am
On Mon, Oct 23, 2017 at 05:55:37PM +0200, Benjamin Gaignard wrote:
> Instead a getting only one common device "/dev/ion" for
> all the heaps this patch allow to create one device
> entry ("/dev/ionX") per heap.
> Getting an entry per heap could allow to set security rules
> per heap and global ones
On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 15:40:47 +0200
>
> Adjust jump targets so that a specific error code assignment
> will be in the implementation only at the end of this function.
This is not an issue that needs to be "fixed".
>
> This
On 24/10/17 06:00 PM, Andrey Grodzovsky wrote:
> On 10/24/2017 11:43 AM, Michel Dänzer wrote:
>> On 24/10/17 04:58 PM, Andrey Grodzovsky wrote:
>>> On 10/24/2017 10:36 AM, S, Shirish wrote:
On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote:
> On 10/24/2017 09:51 AM, S, Shirish wrote:
>> F
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:47:37 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pl
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:16:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c
On Tue, Oct 17, 2017 at 08:17:59PM +0800, Chen-Yu Tsai wrote:
> From: Jonathan Liu
>
> The A10 has two TCONs that are similar to the ones found on other SoCs.
> Like the A31, TCON0 has a register used to mux the TCON outputs to the
> downstream encoders. The bit fields are slightly different.
>
From: Markus Elfring
Date: Tue, 24 Oct 2017 17:55:43 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code in rcar_du_encoders_init()
Adjust 14 checks for null pointers
drivers/gpu/drm/rcar-du/rcar_du_crtc.
On 24/10/17 16:38, Sean Paul wrote:
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote:
Rename tinydrm_of_find_backlight to of_find_backlight and move
it to linux/backlight.c so that it can be used by other drivers.
Signed-off-by: Meghana Madhyastha
---
Changes in v14:
-s/bac
On Tue, Oct 24, 2017 at 10:09:15AM +0200, Neil Armstrong wrote:
> On 24/10/2017 00:46, Rob Herring wrote:
> > On Tue, Oct 17, 2017 at 10:07:42AM +0200, Neil Armstrong wrote:
> >> On reference boards and derivatives, the HDMI Logic is powered by an
> >> external
> >> 5V regulator.
> >> This regulat
[ Adding the dri-devel list ]
On 24/10/17 04:58 PM, Andrey Grodzovsky wrote:
> On 10/24/2017 10:36 AM, S, Shirish wrote:
>> On 10/24/2017 7:48 PM, Andrey Grodzovsky wrote:
>>> On 10/24/2017 09:51 AM, S, Shirish wrote:
From: Shirish S
On some systems amdgpu_bo_gpu_offset seems to b
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote:
> Rename tinydrm_of_find_backlight to of_find_backlight and move
> it to linux/backlight.c so that it can be used by other drivers.
>
> Signed-off-by: Meghana Madhyastha
> ---
> Changes in v14:
> -s/backlight_get/of_find_backlig
On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote:
> Rename tinydrm_of_find_backlight to of_find_backlight and move
> it to linux/backlight.c so that it can be used by other drivers.
>
> Signed-off-by: Meghana Madhyastha
> ---
> Changes in v14:
> -s/backlight_get/of_find_backlig
On Sat, Oct 21, 2017 at 05:26:33PM +0530, Meghana Madhyastha wrote:
> Move the helper functions enable_backlight and disable_backlight
> from tinydrm-helpers.c to backlight.h as static inline functions so
> that they can be used by other drivers.
>
> Signed-off-by: Meghana Madhyastha
Reviewed-by
On Tue, Oct 24, 2017 at 01:51:45PM +0100, Daniel Thompson wrote:
> On 24/10/17 13:16, Sean Paul wrote:
> > On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote:
> > > On 20/10/17 18:20, Sean Paul wrote:
> > > > On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha
> > > > wrote:
> > > > >
>> Do you prefer to delegate the proposed software refactoring
>> only to a corresponding optimiser?
>
> yes.
Will any applications around the semantic patch language
(Coccinelle software) fit also in the preferred tool category?
Regards,
Markus
___
dr
On Tue, 2017-10-24 at 16:51 +0200, SF Markus Elfring wrote:
> Do you prefer to delegate the proposed software refactoring
> only to a corresponding optimiser?
yes.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/m
>> … It's just that two out of three error
>> messages happened to be the same and Markus wants to save a bit of
>> memory by using the same string. The memory savings is not so big that
>> it's worth making the code less readable.
>
> I agree with Dan.
>
> It doesn't save any real memory eithe
On Tue, 2017-10-24 at 17:26 +0300, Dan Carpenter wrote:
> The point of unwind code is to undo what was done earlier. If a
> function allocates a list of things, using standard unwind style makes
> it simpler, safer and more readable.
>
> This isn't the case here. Instead of making the code more
> This isn't the case here.
I find your view interesting for further clarification somehow.
> Instead of making the code more readable, we're making it more convoluted.
Can the shown software refactoring usually help here?
> It's just that two out of three error messages happened to be the sa
https://bugs.freedesktop.org/show_bug.cgi?id=103384
--- Comment #4 from Max ---
Created attachment 135021
--> https://bugs.freedesktop.org/attachment.cgi?id=135021&action=edit
X.Org log file req
--
You are receiving this mail because:
You are the assignee for the bug._
The point of unwind code is to undo what was done earlier. If a
function allocates a list of things, using standard unwind style makes
it simpler, safer and more readable.
This isn't the case here. Instead of making the code more readable,
we're making it more convoluted. It's just that two out
From: Markus Elfring
Date: Tue, 24 Oct 2017 15:40:47 +0200
Adjust jump targets so that a specific error code assignment
will be in the implementation only at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/i
From: Markus Elfring
Date: Tue, 24 Oct 2017 15:15:20 +0200
A jump was specified for a location which was directly behind.
Thus remove such an unnecessary goto statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/i915/intel_dp.c
From: Markus Elfring
Date: Tue, 24 Oct 2017 15:54:32 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an unnecessary goto statement in intel_dp_sink_crc()
Use common error handling code in intel_dp_sink_crc_stop()
drivers/gpu
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects should
be fixed by now.
Optimize the handling by replacing a signaled fence when adding a new
shared one.
Signed-off-by: Christian König
---
drivers/dma-buf/reservation.c | 18 +++---
1
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
Signed-off-by: Christian König
---
drivers/dma-buf/reservation.c | 31 +--
1
Markus,
I normally keep quiet on threads like this. I half agree with you. Yes, perhaps
a reportError function would be a good idea, but it seems that what you are
suggesting is trading an inline subroutine call for a spaghetti-code vondition.
The goto is used only if you do not have any code
Note we need to move update_fences() to after msm_rd_dump_submit(),
otherwise the bo's referenced by the submit may no longer be valid.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gpu.c | 52 +--
1 file changed, 30 insertions(+), 22 deletions(-)
We need this if we want to dump the submit after cleanup (ie. from hang
or fault). But in the backoff/unpin case we want to clear them. So add
a flag so we can skip clearing the IOVAs in at cleanup.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem_submit.c | 11 ++-
1 file chan
For faults or hangs, it is nice to be able to include a bit more
information.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.h | 3 ++-
drivers/gpu/drm/msm/msm_gpu.c | 2 +-
drivers/gpu/drm/msm/msm_rd.c | 15 +--
3 files changed, 16 insertions(+), 4 deletions(-)
diff --
Now that freedreno gallium driver defaults to using submit_queue task
(render reordering), just showing task->comm is not so useful (ie. it is
always "flush_queue:0"), so also dump the cmdline. This should also be
more useful for piglit/shader_runner.
Signed-off-by: Rob Clark
---
drivers/gpu/dr
Prep work for adding a debugfs file that dumps just submits which
trigger hangs/faults. In this case the bo may already be in the
MADV_DONTNEED state, but will be still on the active list (since
the submit hasn't completed yet). So the normal check that the
bo is in the WILLNEED state does not ap
Split into two instances, the existing $debugfs/rd which continues to
dump all submits, and $debugfs/hangrd which will be used to dump just
submits that cause gpu hangs (and eventually faults, but that will
require some iommu framework enhancements).
Signed-off-by: Rob Clark
---
drivers/gpu/drm/
Something that I've been using locally for a while, and found quite
helpful for debugging gallium driver issues:
1) Better messages about what process triggered a crash, which is
in particular particularly useful for piglit
2) Mechanism to dump just submits which triggered GPU hangs.
Eventu
>> Add a jump target so that a call of the function "gvt_vgpu_err" is stored
>> only once at the end of this function implementation.
>> Replace two calls by goto statements.
>>
>> This issue was detected by using the Coccinelle software.
>
> I don't think this is an issue or an improvement.
Do y
On 24/10/17 13:16, Sean Paul wrote:
On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote:
On 20/10/17 18:20, Sean Paul wrote:
On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha
wrote:
On Mon, Oct 16, 2017 at 02:26:00PM -0400, Sean Paul wrote:
On Fri, Oct 13, 2017 at 6:42 PM, Nora
On Tue, 24 Oct 2017, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 14:20:06 +0200
>
> Add a jump target so that a call of the function "gvt_vgpu_err" is stored
> only once at the end of this function implementation.
> Replace two calls by goto statements.
>
> This issue
From: Markus Elfring
Date: Tue, 24 Oct 2017 14:20:06 +0200
Add a jump target so that a call of the function "gvt_vgpu_err" is stored
only once at the end of this function implementation.
Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Signed-off-b
On Mon, Oct 23, 2017 at 11:35:42AM +0100, Daniel Thompson wrote:
> On 20/10/17 18:20, Sean Paul wrote:
> > On Wed, Oct 18, 2017 at 1:11 PM, Meghana Madhyastha
> > wrote:
> > > On Mon, Oct 16, 2017 at 02:26:00PM -0400, Sean Paul wrote:
> > > > On Fri, Oct 13, 2017 at 6:42 PM, Noralf Trønnes
> > >
On Tue, Oct 17, 2017 at 06:49:57AM -0400, Rob Clark wrote:
> We already have, as a result of upstreaming the gpu bindings,
> msm_clk_get() which will try to get the clock both without and with a
> "_clk" suffix. Use this in HDMI code so we can drop the "_clk" suffix
> in bindings while maintaing b
On Tue, Oct 17, 2017 at 06:49:56AM -0400, Rob Clark wrote:
> We already have, as a result of upstreaming the gpu bindings,
> msm_clk_get() which will try to get the clock both without and with a
> "_clk" suffix. Use this in eDP code so we can drop the "_clk" suffix
> in bindings while maintaing ba
On Tue, Oct 17, 2017 at 06:49:55AM -0400, Rob Clark wrote:
> We already have, as a result of upstreaming the gpu bindings,
> msm_clk_get() which will try to get the clock both without and with a
> "_clk" suffix. Use this in DSI code so we can drop the "_clk" suffix
> in bindings while maintaing ba
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #16 from Mike Lothian ---
Do you also see the issue with amdgpu rather than using the radeon kernel
driver?
--
You are receiving this mail because:
You are the assignee for the bug.___
dr
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #15 from Mike Lothian ---
Are there any changes when you boot the system with radeon.runpm=0, this will
mean the card never powers down
What distro are you running?
You mention trying older kernel version, did you try older mesa ve
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #14 from Shih-Yuan Lee ---
Yup, this is a new system. `DRI_PRIME=1 glxgears` never worked properly before.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #13 from Mike Lothian ---
I was meaning, is this a regression, as in it used to work with an older kernel
or mesa. If it's a new system perhaps not.
--
You are receiving this mail because:
You are the assignee for the bug._
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #12 from Shih-Yuan Lee ---
BTW, this is a new Dell laptop in the development.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel
On Tue, Oct 24, 2017 at 01:11:07PM +0300, Jani Nikula wrote:
> On Tue, 24 Oct 2017, Dan Carpenter wrote:
> > We accidentally inverted an if statement and turned amd_powerplay_reset()
> > into a no-op.
> >
> > Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in
> > amd_powerplay.c (v3)"
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #11 from Shih-Yuan Lee ---
(In reply to Mike Lothian from comment #10)
> Did this ever work for you?
What do you mean by this?
--
You are receiving this mail because:
You are the assignee for the bug.__
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #10 from Mike Lothian ---
Did this ever work for you?
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel@lists.freedesktop.org
h
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #9 from Shih-Yuan Lee ---
I have tried acpi_osi="Windows 2009", "Windows 2012", "Windows 2013" and
"Windows 2015" on the latest mainline kernel 4.14rc6, and they all have the
same errors and halt the system.
The BIOS is also up to da
On Mon, Oct 23, 2017 at 12:47 PM, Aastha Gupta
wrote:
> For drivers which could have multiple instances, it is necessary to
> differentiate between which is which in the logs. Since
> DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
> make this differentiation. We now have DRM_
On Tue, 24 Oct 2017, Dan Carpenter wrote:
> We accidentally inverted an if statement and turned amd_powerplay_reset()
> into a no-op.
>
> Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in
> amd_powerplay.c (v3)")
For some reason I looked up that commit, and it has *two* cases where
On Tue, 24 Oct 2017, David Binderman wrote:
> Hello there,
>
>
> Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
>
> up to date.
>
>
> I did a further check on github.com/torvalds/linux and the code
>
> looks wrong there, too.
>
>
> So I don't see the fix you mentioned in e
We accidentally inverted an if statement and turned amd_powerplay_reset()
into a no-op.
Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c
(v3)")
Signed-off-by: Dan Carpenter
---
IMHO, tidying unreadable double negatives is tricky and error prone but
still worth it in
https://bugs.freedesktop.org/show_bug.cgi?id=103393
Samuel Pitoiset changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder
>> *encoder)
>> dsi->state &= ~DSIM_STATE_ENABLED;
>> exynos_dsi_set_display_enable(dsi, false);
>> drm_panel_unprepare(dsi->panel);
>> - pm_runtime_put_sync(ds
2017-10-23 17:25 GMT+02:00 Ville Syrjala :
> From: Ville Syrjälä
>
> Since commit 632c6e4edef1 ("drm/vblank: Fix flip event vblank count")
> even drivers that don't implement accurate vblank timestamps will end
> up using drm_crtc_accurate_vblank_count(). That leads to a WARN every
> time drm_crtc
On Mon, 23 Oct 2017, David Binderman wrote:
> Hello there,
>
> Source code is
>
> if ((temp & PIPEACONF_PIPE_STATE) == 1)
> break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF
From: Markus Elfring
Date: Tue, 24 Oct 2017 10:20:20 +0200
The script "checkpatch.pl" pointed misspelled words out.
Thus fix the affected places.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 +-
drivers/gpu/drm/
1 - 100 of 126 matches
Mail list logo
