Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 06:14:49PM +0100, Gerd Hoffmann wrote: > Hi, > > > drm-misc runs with the committer model, i.e. a few maintainers to do pull > > requests and backmerges, a big pile of people directly pushing patches. > > [ looked at docs too meanwhile ] > > Sounds good. I guess switch

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 11:15:34AM +0100, Boris Brezillon wrote: > Hi Daniel, > > On Thu, 26 Jan 2017 18:08:42 +0100 > Daniel Vetter wrote: > > > Hi all, > > > > We've discussed this a bit at LCA (with Dave and Eric), and it's > > probably best if I just summarize all the questions and opens an

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 03:42:17PM +0100, Maarten Lankhorst wrote: > Op 30-01-17 om 09:17 schreef Daniel Vetter: > > On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: > >> On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: > >>> On Fri, Jan 27, 2017 at 02:31:55PM +, Chri

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 08:43:17AM -0800, Dave Hansen wrote: > On 01/30/2017 01:12 AM, Daniel Vetter wrote: > > On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: > ... > >> And, yeah, I think it just gets the connected status wrong. The > >> connector is still there. > > > > Hm, I thou

Re: [PATCH 01/10] drm/etnaviv: add uapi for register read feature

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 11:45:59PM +, Russell King - ARM Linux wrote: > On Mon, Jan 30, 2017 at 09:18:25PM +0100, Thierry Reding wrote: > > On Fri, Dec 09, 2016 at 12:21:22PM +0100, Christian Gmeiner wrote: > > > @@ -167,6 +174,9 @@ struct drm_etnaviv_gem_submit { > > > __u64 bos;

[Bug 99275] Kernel 4.9: amdgpu regression; gui flickers; amd radeon rx 460

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99275 --- Comment #15 from Michel Dänzer --- There are two basic explanations for not getting consistent bisection results: * In each case, at least one bad commit was accidentally marked as good. Test longer / more times before declaring a commit as

[Bug 99444] [radeonsi] The Witcher 3 (GOG/1.31) [Wine] starting menu is distorted

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99444 --- Comment #11 from Shmerl --- I just replayed my trace (recorder on radeonsi / RX480), and I see this in the log: 120612: message: major api error 2: GL_INVALID_ENUM in glActiveTexture(texture=GL_COMBINER0_NV) 120612 @1 glActiveTexture(texture

[PATCH] drm: remove unnecessary fault wrappers

2017-01-30 Thread Ross Zwisler
The fault wrappers drm_vm_fault(), drm_vm_shm_fault(), drm_vm_dma_fault() and drm_vm_sg_fault() used to provide extra logic beyond what was in the "drm_do_*" versions of these functions, but as of this commit: commit ca0b07d9a969 ("drm: convert drm from nopage to fault.") They are just unnecessar

[PATCH v2] drm: remove unnecessary fault wrappers

2017-01-30 Thread Ross Zwisler
The fault wrappers drm_vm_fault(), drm_vm_shm_fault(), drm_vm_dma_fault() and drm_vm_sg_fault() used to provide extra logic beyond what was in the "drm_do_*" versions of these functions, but as of this commit: commit ca0b07d9a969 ("drm: convert drm from nopage to fault.") They are just unnecessar

Re: [PATCH 01/10] drm/etnaviv: add uapi for register read feature

2017-01-30 Thread Russell King - ARM Linux
On Mon, Jan 30, 2017 at 09:18:25PM +0100, Thierry Reding wrote: > On Fri, Dec 09, 2016 at 12:21:22PM +0100, Christian Gmeiner wrote: > > @@ -167,6 +174,9 @@ struct drm_etnaviv_gem_submit { > > __u64 bos;/* in, ptr to array of submit_bo's */ > > __u64 relocs; /* in, ptr t

[PATCH] Gpu: drm: exynos - Fix possible NULL derefrence.

2017-01-30 Thread Shailendra Verma
of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/exynos/exynos_drm_dsi.c |4 drivers/gpu/drm/exynos/exynos_drm_fimd.c |4 drivers/gpu/drm/exynos/exynos_hdmi.c |4 dri

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Tomi Sarvela
On Monday, 30 January 2017 10:49:10 EET Daniel Vetter wrote: > On Mon, Jan 30, 2017 at 10:30:43AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc. > > > html > > > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html> >

Re: [PATCH v2] drm: remove unnecessary fault wrappers

2017-01-30 Thread Ross Zwisler
On Mon, Jan 30, 2017 at 03:09:39PM -0700, Ross Zwisler wrote: > This patch applies cleanly to mmots/master, which is currently at > v4.10-rc5-mmots-2017-01-26-15-49. Which may not be what you want... The reason I was looking at this code was because it was recently changed by Dave Jiang to remov

[PATCH 03/14] drm/omap: use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c index 3cab066..abd0b15

Re: [PATCH 09/10] drm/etnaviv: validate readback register address

2017-01-30 Thread Russell King - ARM Linux
On Mon, Jan 30, 2017 at 11:58:32AM +0100, Lucas Stach wrote: > Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner: > > Reading some registers end in a system crash ala: > > > > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfe641000 > > Internal error: : 1028 [#1

Re: [PATCH 08/10] drm/etnaviv: make it possible to reconfigure perf counter

2017-01-30 Thread Russell King - ARM Linux
On Mon, Jan 30, 2017 at 12:01:18PM +0100, Lucas Stach wrote: > Am Freitag, den 09.12.2016, 12:21 +0100 schrieb Christian Gmeiner: > > - if (r->flags) { > > - DRM_ERROR("readback flags not 0"); > > + if (r->flags > ETNA_READBACK_PERF) { > > + D

[PATCH 00/14] use atomic_dec_not_zero()

2017-01-30 Thread Fabian Frederick
complementary definition to atomic_inc_not_zero() featured in lib/fault-inject.c. This small patchset moves it to include/linux/atomic.h using it instead of atomic_add_unless(value, -1, 0) s390 patches were not compile-tested. Fabian Frederick (14): locking/atomic: import atomic_dec_not_zero()

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Dave Hansen
On 01/30/2017 01:12 AM, Daniel Vetter wrote: > On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: ... >> And, yeah, I think it just gets the connected status wrong. The >> connector is still there. > > Hm, I thought I replied here but I didn't: > - Is this just after boot (and then the

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-30 Thread Jani Nikula
On Sat, 28 Jan 2017, Peter Senna Tschudin wrote: > On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: > Hi Archit, > > Thank you for the comments! > > [...] >> > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH; >> > + if (total_size > EDID_LENGTH) { >> > + kfree

Re: [Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

2017-01-30 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 07:18 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:35PM -0800, Dhinakaran Pandiyan wrote: > > Having a ->atomic_release callback is useful to release shared resources > > that get allocated in compute_config(). > > > > Suggested-by: Daniel Vetter > > Signed-of

[PATCH] Gpu: drm: tegra - Fix possible NULL derefrence.

2017-01-30 Thread Shailendra Verma
of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/tegra/sor.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 74d0540..34f032f 100644

Re: BUG: 4.10 i915 drm display noise regression - bisected to a6a7cc4b7

2017-01-30 Thread lkml
On Mon, Jan 09, 2017 at 12:32:40AM -0600, l...@pengaru.com wrote: > Hello all, > > I'm experiencing display noise in the form of 8x1 pixel bars spuriously > appearing in random locations. This doesn't happen on 4.9, the machine > is an X61s, a Core2Duo 1.8Ghz w/XGA via LVDS. > > I was able to bi

[EVoC] Beginner question about X.org projects

2017-01-30 Thread Vinay Neekhra
Hello, I am Vinay. I want to get involved in X.org projects. As of now, to have a big picture view, I am going through the documentation. If possible, could you please suggest me where should I start from? About me: I am pursuing M.S. in Machine Translation from IIIT-Hyderabad, India. I am comfor

[GIT PULL] exynos-drm-next

2017-01-30 Thread Inki Dae
Hi Dave, adding runtime PM support to MIC driver, and including some cleanups - especially using atomic helper functions instead of specific ones - and fixups. In addition, it includes S6E3HA2 panel driver and its support. The panel driver should go to mainline by Thierry. Howev

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-30 Thread Inki Dae
2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: > Dear Thierry, > > Could you please review this patch? Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this. Thanks. > > Best Regards, > Hoegeun Kwon > > On 01/11/2017 03:33 PM, Ho

[Bug 74973] [radeonsi] Gimp OpenCL does not work

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74973 --- Comment #6 from Jan Vesely --- (In reply to darkbasic from comment #5) > Not sure, but I don't think so. AFAIK it' only GEGL-related stuff. a lot of gegl tests pass OK for me on Turks. notably clone test that includes box-blur and gaussian-b

Re: [PATCH v3 16/24] drm/rockchip: dw-mipi-dsi: properly configure PHY timing

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:36PM +, John Keeping wrote: > These values are specified as constant time periods but the PHY > configuration is in terms of the current lane byte clock so using > constant values guarantees that the timings will be outside the > specification with some display con

[Bug 99515] SIGSEGV MAPERR on Android nougat-x86 with mesa 17.0.0rc

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99515 --- Comment #3 from Mauro Rossi --- Created attachment 129239 --> https://bugs.freedesktop.org/attachment.cgi?id=129239&action=edit various EGL issues with addr2line logs -- You are receiving this mail because: You are the assignee for the bu

RE: [PATCH v1 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic

2017-01-30 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Bjorn Helgaas > Sent: Monday, January 30, 2017 3:41 PM > To: Deucher, Alexander; Koenig, Christian > Cc: linux...@vger.kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; a

Re: [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Harry Wentland
We'd like these in amdgpu as well. I've only skimmed the patch but it looks pretty good to me. Acked-by: Harry Wentland Harry On 2017-01-29 12:41 AM, Shashank Sharma wrote: > CEA-861-F specs defines new 4k video modes to be used with > HDMI 2.0 EDIDs. These modes start at VIC=93 and go all th

[PATCH v1 1/2] drm/amdgpu: remove unnecessary save/restore of pdev->d3_delay

2017-01-30 Thread Bjorn Helgaas
Remove unnecessary save/restore of pdev->d3_delay. The only assignments to pdev->d3_delay are in radeon_switcheroo_set_state() and some quirks, none of which should be relevant in the amdgpu_switcheroo_set_state() path. Signed-off-by: Bjorn Helgaas --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH v1 2/2] drm/radeon: make MacBook Pro d3_delay quirk more generic

2017-01-30 Thread Bjorn Helgaas
The PCI Power Management Spec, r1.2, sec 5.6.1, requires a 10 millisecond delay when powering on a device, i.e., transitioning from state D3hot to D0. Apparently some devices require more time, and d1f9809ed131 ("drm/radeon: add quirk for d3 delay during switcheroo poweron for apple macbooks") add

[PATCH v1 0/2] drm amdgpu/radeon: clean up d3_delay usage

2017-01-30 Thread Bjorn Helgaas
amdgpu doesn't need to touch pdev->d3_delay at all. radeon has a d3_delay quirk for MacBook Pro, but it only affects radeon_switcheroo_set_state(). I think it should affect wakeups done by the PCI core as well. --- Bjorn Helgaas (2): drm/amdgpu: remove unnecessary save/restore of pdev->d3

Re: [PATCH] drm: remove unnecessary fault wrappers

2017-01-30 Thread Sean Paul
On Mon, Jan 30, 2017 at 12:20:02PM -0700, Ross Zwisler wrote: > The fault wrappers drm_vm_fault(), drm_vm_shm_fault(), drm_vm_dma_fault() > and drm_vm_sg_fault() used to provide extra logic beyond what was in the > "drm_do_*" versions of these functions, but as of this commit: > > commit ca0b07d9a

Re: [PATCH v3 15/24] drm/rockchip: dw-mipi-dsi: configure PHY before enabling

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:35PM +, John Keeping wrote: > The bias, bandgap and PLL should all be configured before we enable > them. > Do you know why the test codes are hard-coded magic? It'd be nice to make some sense of them in a future patch. Reviewed-by: Sean Paul > Signed-off-by:

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 2:54 PM, Eric Anholt wrote: > Rob Clark writes: > >> On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the

[Bug 95306] Random Blank(black) screens on "Carrizo"

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95306 --- Comment #54 from Patrick Laurin --- Interesting enough, I started having screen blackouts again on RC6, but RC4 is fine, I can use it all day without issues. On 24 January 2017 at 20:13, wrote: > *Comment # 53

Re: [PATCH v3 14/24] drm/rockchip: dw-mipi-dsi: ensure PHY is reset

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:34PM +, John Keeping wrote: > Also don't power up the DSI host at this point since this is not > necessary in order to configure the PHY and we do so later when > selecting video or command mode. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewe

Re: [PATCH v3 13/24] drm/rockchip: dw-mipi-dsi: fix escape clock rate

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:33PM +, John Keeping wrote: > This clock rate is derived from the PHY PLL, so it should be calculated > dynamically. Use the same calculation as the vendor kernel to derive > the escape clock speed. > Nit below, but Reviewed-by: Sean Paul > Signed-off-by: Joh

Re: [PATCH v3 12/24] drm/rockchip: dw-mipi-dsi: allow commands in panel_disable

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:32PM +, John Keeping wrote: > Panel drivers may want to sent commands during the disable function, for > example MIPI_DCS_SET_DISPLAY_OFF before the video signal ends. In order > to send commands we need to write to registers, so pclk must be enabled. > > While c

Re: [PATCH 01/10] drm/etnaviv: add uapi for register read feature

2017-01-30 Thread Thierry Reding
On Fri, Dec 09, 2016 at 12:21:22PM +0100, Christian Gmeiner wrote: > We need to readout some registers _after_ the submited command > buffer got executed in order to support perf counters. > There is no way to read register via command stream - even the > Vivante kernel driver does it via a special

Re: [PATCH v3 11/24] drm/rockchip: dw-mipi-dsi: prepare panel after phy init

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:31PM +, John Keeping wrote: > Some panels need to be configured with commands sent over the MIPI link, > which they will do in the prepare hook. Call this after the PHY has > been initialized so that we are able to send commands to the panel. > Reviewed-by: Sean

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

2017-01-30 Thread Sean Paul
On Mon, Jan 30, 2017 at 06:14:27PM +, John Keeping wrote: > On Mon, 30 Jan 2017 10:26:11 -0500, Sean Paul wrote: > > > On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote: > > > I haven't found any method for getting the length of a response, so this > > > just uses the requested rx_l

RE: [v3 PATCH 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-01-30 Thread Grodzovsky, Andrey
> -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Monday, January 30, 2017 6:05 AM > To: Grodzovsky, Andrey > Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; > nouv...@lists.freedesktop.org; daniel.vet...@intel.com; dc_ups

Re: [PATCH v3 06/24] drm/rockchip: dw-mipi-dsi: avoid out-of-bounds read on tx_buf

2017-01-30 Thread Sean Paul
On Mon, Jan 30, 2017 at 06:16:36PM +, John Keeping wrote: > On Mon, 30 Jan 2017 13:01:46 -0500, Sean Paul wrote: > > > On Sun, Jan 29, 2017 at 01:24:26PM +, John Keeping wrote: > > > As a side-effect of this, encode the endianness explicitly rather than > > > casting a u16. > > > > > > Si

Re: [PATCH v3 10/24] drm/rockchip: dw-mipi-dsi: don't assume buffer is aligned

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:30PM +, John Keeping wrote: > By dereferencing the MIPI command buffer as a u32* we rely on it being > correctly aligned on ARM, but this may not be the case. Copy it into a > stack variable that will be correctly aligned. > > Signed-off-by: John Keeping > Revie

[PATCH] drm/nouveau: gk20a: Turn instmem lock into mutex

2017-01-30 Thread Thierry Reding
From: Thierry Reding The gk20a implementation of instance memory uses vmap()/vunmap() to map memory regions into the kernel's virtual address space. These functions may sleep, so protecting them by a spin lock is not safe. This triggers a warning if the DEBUG_ATOMIC_SLEEP Kconfig option is enable

[git pull] vmwgfx-next

2017-01-30 Thread Sinclair Yeh
Hi Dave, This is to address what we've discussed, moving some of the minor changes into a drm-next request. - The following changes since commit f0493e653f9679114d1dfd54ab88b54ce95576e1: drm/mgag200: Added support for the new device G200eH3 (2017-01-23 11:57:08 +1000) are available in t

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

2017-01-30 Thread Gustavo Padovan
2017-01-30 Sumit Semwal : > Hi Gustavo, Daniel, > > On 30 January 2017 at 14:07, Daniel Vetter wrote: > > > On Fri, Jan 27, 2017 at 03:54:44PM -0200, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > As Sync File is highly dependent on dma-fence* tracks it > > > under SYNC FILE_FR

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The plan is to use the OPP bindings. For now, remove the documentation >>> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >>> clock if the node is not present. >>> >>> Note

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The original way we determined the gpu version was based on downstream >>> bindings from android kernel. A cleaner way is to get the version from >>> the compatible string. >>> >>> Note that no

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Noralf Trønnes
Den 30.01.2017 19.06, skrev Daniel Vetter: On Mon, Jan 30, 2017 at 04:03:53PM +0100, Noralf Trønnes wrote: Den 30.01.2017 09.44, skrev Daniel Vetter: Hi Noralf, On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: This is an attempt at providing a DRM version of drivers/staging/fb

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:21 PM, Eric Anholt wrote: > Rob Clark writes: > >> The plan is to use the OPP bindings. For now, remove the documentation >> for qcom,gpu-pwrlevels, and make the driver fall back to a safe low >> clock if the node is not present. >> >> Note that no upstream dtb use this

Re: [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:15 PM, Eric Anholt wrote: > Rob Clark writes: > >> Suggested by Rob Herring. We still support the old names for >> compatibility with downstream android dt files. >> >> Cc: Rob Herring >> Signed-off-by: Rob Clark > > Huh, I don't think I would have cleaned up DT bindi

Re: [PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The plan is to use the OPP bindings. For now, remove the documentation > for qcom,gpu-pwrlevels, and make the driver fall back to a safe low > clock if the node is not present. > > Note that no upstream dtb use this node. For now we keep compatibility > with this node to avo

Re: [PATCH v3 09/24] drm/rockchip: dw-mipi-dsi: only request HS clock when required

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:29PM +, John Keeping wrote: > Requesting the HS clock from the PHY before we initialize it causes an > invalid signal to be sent out since the input clock is not yet > configured. The PHY databook suggests only asserting this signal when > performing HS transfers,

Re: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:28PM +, John Keeping wrote: > Instead of always sending commands in LP mode, respect the > MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also > request acks if MIPI_DSI_MSG_REQ_ACK is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: > Rob Clark writes: > >> The original way we determined the gpu version was based on downstream >> bindings from android kernel. A cleaner way is to get the version from >> the compatible string. >> >> Note that no upstream dtb uses these bindi

Re: [PATCH v3 06/24] drm/rockchip: dw-mipi-dsi: avoid out-of-bounds read on tx_buf

2017-01-30 Thread John Keeping
On Mon, 30 Jan 2017 13:01:46 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:26PM +, John Keeping wrote: > > As a side-effect of this, encode the endianness explicitly rather than > > casting a u16. > > > > Signed-off-by: John Keeping > > Reviewed-by: Chris Zhong > > --- > > v3: > >

Re: [PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Eric Anholt
Rob Clark writes: > Suggested by Rob Herring. We still support the old names for > compatibility with downstream android dt files. > > Cc: Rob Herring > Signed-off-by: Rob Clark Huh, I don't think I would have cleaned up DT bindings in exchange for adding driver code like this. But the code

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

2017-01-30 Thread John Keeping
On Mon, 30 Jan 2017 10:26:11 -0500, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote: > > I haven't found any method for getting the length of a response, so this > > just uses the requested rx_len > > > > Signed-off-by: John Keeping > > --- > > v3: > > - Fix check

Re: [PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Eric Anholt
Rob Clark writes: > This was never documented or used in upstream dtb. It is used by > downstream bindings from android device kernels. But the quirks are > a property of the gpu revision, and as such are redundant to be listed > separately in dt. Instead, move the quirks to the device table.

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The original way we determined the gpu version was based on downstream > bindings from android kernel. A cleaner way is to get the version from > the compatible string. > > Note that no upstream dtb uses these bindings. But the code still > supports falling back to the legac

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 04:03:53PM +0100, Noralf Trønnes wrote: > > Den 30.01.2017 09.44, skrev Daniel Vetter: > > Hi Noralf, > > > > On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: > > > This is an attempt at providing a DRM version of drivers/staging/fbtft. > > > > > > The tiny

Re: [PATCH v3 07/24] drm/rockchip: dw-mipi-dsi: include bad value in error message

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:27PM +, John Keeping wrote: > As an aid to debugging. Reviewed-by: Sean Paul > > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ++- > 1 file cha

Re: [PATCH v3 06/24] drm/rockchip: dw-mipi-dsi: avoid out-of-bounds read on tx_buf

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:26PM +, John Keeping wrote: > As a side-effect of this, encode the endianness explicitly rather than > casting a u16. > > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockch

[PATCH] drm/atomic: Fix double kfree on crtc_state->event

2017-01-30 Thread Daniel Vetter
This is a bug Maarten reported, with the following slab debug backtrace: [IGT] kms_rotation_crc: starting subtest primary-rotation-180 = BUG kmalloc-128 (Tainted: G U ): Object already free

Re: [PATCH v3 05/24] drm/rockchip: dw-mipi-dsi: fix generic packet status check

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:25PM +, John Keeping wrote: > We want to check that both the GEN_CMD_EMPTY and GEN_PLD_W_EMPTY bits > are set so we can't just check "val & mask" because that will be true if > either bit is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewe

Re: make fbdev/fbcon switchable per driver?

2017-01-30 Thread Alex Williamson
On Mon, 30 Jan 2017 09:15:50 +0100 Gerd Hoffmann wrote: > Hi, > > > The vgaarb code has a concept of a vga_default_device(), it's rather > > PCI-centric, but maybe better than nothing. This is typically the > > first VGA class code device found with I/O and MMIO enabled. If fbcon > > default

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > drm-misc runs with the committer model, i.e. a few maintainers to do pull > requests and backmerges, a big pile of people directly pushing patches. [ looked at docs too meanwhile ] Sounds good. I guess switching over simplifies things for all of us. We'll avoid issues like the one at ha

Re: [v3 PATCH 3/3] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-30 Thread Harry Wentland
On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote: > Swicth to use atomic helper. > Start using actual user's given target_vblank value for flip > instead of current value. > > v3: > Update for movig pflip flags to crtc_state > > Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda > Signed-off-by

Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.

2017-01-30 Thread Rob Herring
On Fri, Jan 27, 2017 at 8:41 PM, Eric Anholt wrote: > Rob Herring writes: > >> Need to cc DT list if you want it in my queue. >> >> On Mon, Jan 23, 2017 at 6:38 PM, Eric Anholt wrote: >>> These are part of the vc4 display pipeline. >>> >>> Signed-off-by: Eric Anholt >>> --- >>> .../devicetree/

[PATCH 1/4] drm/msm: remove qcom,gpu-pwrlevels bindings

2017-01-30 Thread Rob Clark
The plan is to use the OPP bindings. For now, remove the documentation for qcom,gpu-pwrlevels, and make the driver fall back to a safe low clock if the node is not present. Note that no upstream dtb use this node. For now we keep compatibility with this node to avoid breaking compatibility with

[PATCH 3/4] drm/msm: drop quirks binding

2017-01-30 Thread Rob Clark
This was never documented or used in upstream dtb. It is used by downstream bindings from android device kernels. But the quirks are a property of the gpu revision, and as such are redundant to be listed separately in dt. Instead, move the quirks to the device table. Signed-off-by: Rob Clark -

[PATCH 4/4] drm/msm: drop _clk suffix from clk names

2017-01-30 Thread Rob Clark
Suggested by Rob Herring. We still support the old names for compatibility with downstream android dt files. Cc: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree/bindings/display/msm/gpu.txt | 12 ++-- drivers/gpu/drm/msm/msm_drv.c | 19

[PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the version from the compatible string. Note that no upstream dtb uses these bindings. But the code still supports falling back to the legacy bindings (with a warning), so

[PATCH 0/4] drm/msm: cleanup gpu bindings

2017-01-30 Thread Rob Clark
Existing bindings for the gpu are based on the downstream android kgsl driver (a subset of the downstream bindings). But that isn't really how we want the upstream bindings to look. For now we have held off on adding gpu nodes to upstream dt files, but now that all the dependencies are in place f

Re: [PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Liviu Dudau
On Mon, Jan 30, 2017 at 03:42:26PM +, Mihail Atanassov wrote: > The reset hook needs to allocate space for a > malidp_plane_state, which is larger than drm_plane_state. > Otherwise, the hook is identical to the default one. > > Signed-off-by: Mihail Atanassov Acked-by: Liviu Dudau Thanks,

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:38, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++- 1 file changed, 22 insertions(+), 1 de

Re: [PATCH v3 01/24] drm/rockchip: dw-mipi-dsi: don't configure hardware in mode_set for MIPI

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:21PM +, John Keeping wrote: > With atomic modesetting the hardware will be powered off when the > mode_set function is called. We should configure the hardware in the > enable function, which is the atomic version of "commit" so let's use > the enable hook rather

Re: [PATCH v3 02/24] drm/rockchip: dw-mipi-dsi: pass mode in where needed

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:22PM +, John Keeping wrote: > This shows that we only use the mode from the enable function and > prepares us to remove the "mode" field and the mode_set hook in the next > commit. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zho

Re: [PATCH v3 04/24] drm/rockchip: dw-mipi-dsi: fix command header writes

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:24PM +, John Keeping wrote: > In a couple of places here we use "val" for the value that is about to > be written to a register but then reuse the same variable for the value > of a status register before we get around to writing it. Rename the > value to be writt

Re: [PATCH v3 03/24] drm/rockchip: dw-mipi-dsi: remove mode_set hook

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:23PM +, John Keeping wrote: > This is not needed since we can access the mode via the CRTC from the > enable hook. Also remove the "mode" field that is no longer used. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- >

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 16:11, Ville Syrjälä wrote: > > On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 30-01-17 14:10, Ville Syrjälä wrote: > >>> On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goe

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM

Re: [PATCH v3 24/24] drm/rockchip: dw-mipi-dsi: support read commands

2017-01-30 Thread Sean Paul
On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote: > I haven't found any method for getting the length of a response, so this > just uses the requested rx_len > > Signed-off-by: John Keeping > --- > v3: > - Fix checkpatch warnings > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mip

[PATCH] drm/i915: Skip modeset locking when atomic pageflips are used.

2017-01-30 Thread Maarten Lankhorst
With the atomic helper for pageflips there are no CS flips when that require resetting, so on most platforms we can completely skip the locking. Because we may end up reverting the page_flip patch add an explicit function pointer check so that if someone reverts the page flip patch there will not

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 14:10, Ville Syrjälä wrote: > > On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 01/28/2017 05:25 PM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 01/27/2017 02:51 PM, Ville Sy

Re: [PATCH v2 0/2] drm: Add support for tiny LCD displays

2017-01-30 Thread Noralf Trønnes
Den 30.01.2017 09.44, skrev Daniel Vetter: Hi Noralf, On Fri, Jan 27, 2017 at 08:56:29PM +0100, Noralf Trønnes wrote: This is an attempt at providing a DRM version of drivers/staging/fbtft. The tinydrm library provides a very simplified view of DRM in particular for tiny displays that has onb

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit o

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 09:17 schreef Daniel Vetter: > On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: >> On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: >>> On Fri, Jan 27, 2017 at 02:31:55PM +, Chris Wilson wrote: On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vette

[Bug 193651] New: Amdgpu error messages at boot with Amd RX460

2017-01-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193651 Bug ID: 193651 Summary: Amdgpu error messages at boot with Amd RX460 Product: Drivers Version: 2.5 Kernel Version: 4.11-wip Hardware: x86-64 OS: Linux Tree: M

Re: DRM Atomic property for color-space conversion

2017-01-30 Thread Ville Syrjälä
On Fri, Jan 27, 2017 at 05:23:24PM +, Brian Starkey wrote: > Hi, > > We're looking to enable the per-plane color management hardware in > Mali-DP with atomic properties, which has sparked some conversation > around how to handle YCbCr formats. > > As it stands today, it's assumed that a drive

Re: [PATCH] MAINTAINERS: add dma-fence* files to Sync File maintainership

2017-01-30 Thread Sumit Semwal
Hi Gustavo, Daniel, On 30 January 2017 at 14:07, Daniel Vetter wrote: > On Fri, Jan 27, 2017 at 03:54:44PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > As Sync File is highly dependent on dma-fence* tracks it > > under SYNC FILE_FRAMEWORK as well. > > > > Signed-off-by: Gusta

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > Hi, > > On 01/28/2017 05:25 PM, Hans de Goede wrote: > > Hi, > > > > On 01/27/2017 02:51 PM, Ville Syrjälä wrote: > >> On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: > >>> Make sure the P-Unit or the PMIC i2c bus is n

[Bug 99368] Full aspect scaling introduces interlacing on specific resolutions

2017-01-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99368 Platin changed: What|Removed |Added Attachment #128898|0 |1 is obsolete|

Re: [PATCH] Gpu: drm: exynos - Fix possible NULL derefrence.

2017-01-30 Thread Javier Martinez Canillas
Hello Shailendra, The subject line is wrong, please always use the convention used in previous commits, i.e: git log --oneline drivers/gpu/drm/exynos/ On 01/30/2017 02:02 AM, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later.

Re: [PATCH 2/2] drm/omapdrm: Move commit_modeset_enables() before commit_planes()

2017-01-30 Thread Jyri Sarha
On 01/30/17 13:15, Laurent Pinchart wrote: >>> rebase (and retest) this patch on top of "[PATCH 0/5] omapdrm: fences and >>> zpos" ? >> Thanks, I'll do that. > If you intend on merging this patch as a v4.10 fix then there's no need to > rebase. If it targets v4.11, the above-mentioned series will

Re: [PATCH 0/6] Etnaviv cmdbuf suballocator

2017-01-30 Thread Christian Gmeiner
Hi Lucas, 2017-01-30 12:48 GMT+01:00 Lucas Stach : > Am Mittwoch, den 18.01.2017, 12:25 +0100 schrieb Lucas Stach: >> Hi all, >> >> the following patches introduce a cmduf suballocator in the Etnaviv >> kernel driver, which has the following benefits: >> >> 1. Allocating and freeing a CMA buffer f

  1   2   >