On 09/21/15 18:08, Clemens Ladisch wrote:
>> >But there is no downside in using prepare callback.
> The prepare callback also can be called multiple times. This certainly
> happens when the stream is stopped/restarted multiple times.
>
> If something does not need to be done again when a stream is
Hey Emil,
Emil Velikov wrote:
> Hi Tobias,
>
> On 8 September 2015 at 16:22, Tobias Jakobi
> wrote:
>> Hello,
>>
>> during the discussion about the last patchset touching the
>> fimg2d code, it became apparent that the error handling for
>> the command submission is currently unsatisfactory.
>>
On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote:
> From: Kausal Malladi
>
> This patch adds new structures in DRM layer for Palette color
> correction.These structures will be used by user space agents
> to configure appropriate number of samples and Palette LUT for
> a platform.
nector_init(dp->drm_dev, connector,
>> &analogix_dp_connector_atomic_funcs,
>> DRM_MODE_CONNECTOR_eDP);
>> if (ret) {
>> DRM_ERROR("Failed to initialize connector with drm\n");
>> return ret;
>> }
>>
>> drm_connector_helper_add(connector,
>> &analogix_dp_connector_helper_funcs);
>> drm_connector_register(connector);
>> drm_mode_connector_attach_encoder(connector, encoder);
>>
>> -- analogix_dp-rockchip
>>
>> ret = drm_connector_init(dp->drm_dev, connector,
>> &analogix_dp_connector_funcs,
>> DRM_MODE_CONNECTOR_eDP);
>> if (ret) {
>> DRM_ERROR("Failed to initialize connector with drm\n");
>> return ret;
>> }
>>
>> drm_connector_helper_add(connector,
>> &analogix_dp_connector_helper_funcs);
>> drm_mode_connector_attach_encoder(connector, encoder);
>>
>>
>> Are those code corresponding to your suggestion. :)
> Yes, that looks about right. You could also move the implementations
> into the Exynos and Rockchip drivers, respectively, if they're only used
> from one place. Then you can simply export the low-level analogix_dp_*()
> functions. That might give you even more flexibility, but the above
> would probably work well enough.
Wow, much better, so I just need to export two low-level functions,
* analogix_dp_detect()
* analogix_dp_get_modes()
Pretty cool.
Thanks,
- Yakir
> Thierry
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/5407d3db/attachment-0001.html>
This change is needed to properly lock I2C bus device and driver,
which serve DDC lines. Without this change I2C bus driver module
may gone in runtime and this won't be noticed by the driver.
Signed-off-by: Vladimir Zapolskiy
---
drivers/gpu/drm/sti/sti_hdmi.c | 17 ++---
1 file chan
The commit 53bdcf5f026c ("drm: sti: fix sub-components bind") moves
i2c adapter search and locking from .bind() to .probe(), however
proper error path in the modified .probe() is not implemented and
leftover of the related error path in .bind() remains. This change
fixes these issues.
Fixes: 53bdc
because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/0c6fdc36/attachment.html>
Hi Thierry,
Thanks for your suggest :)
On 09/21/2015 05:15 PM, Thierry Reding wrote:
> On Mon, Sep 21, 2015 at 04:45:44PM +0800, Yakir Yang wrote:
>> Hi Heiko,
>>
>> On 09/02/2015 10:15 AM, Yakir Yang wrote:
>>> Hi Heiko,
>>>
>>> å¨ 09/02/2015 05:47 AM, Heiko Stuebner åé:
Hi Yakir,
r maybe it started out broken.
I might have missed something, but I'm not seeing GL_ARB_arrays_of_arrays being
exposed on radeonsi?
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<
The change adds support of internal HDMI I2C master controller, this
subdevice is used by default, if "ddc-i2c-bus" DT property is omitted.
The main purpose of this functionality is to support reading EDID from
an HDMI monitor on boards, which don't have an I2C bus connected to
DDC pins.
The curr
On 10 September 2015 at 16:49, Alex Deucher wrote:
> On Wed, Sep 9, 2015 at 1:21 PM, Emil Velikov
> wrote:
>> Hello all,
>>
>> With this series, we add a couple of new functions drm{Get,Free}Device,
>> which will be used to query information about the opened device.
>>
>> To do that some refacto
On 09/21/15 12:37, Russell King - ARM Linux wrote:
> On Fri, Sep 18, 2015 at 02:06:39PM +0300, Jyri Sarha wrote:
>> Add IEC958 channel status helper that gets the audio properties from
>> snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to
>> produce the channel status bits already in a
Hi Tobias,
On 8 September 2015 at 16:22, Tobias Jakobi
wrote:
> Hello,
>
> during the discussion about the last patchset touching the
> fimg2d code, it became apparent that the error handling for
> the command submission is currently unsatisfactory.
>
> This series rewrites the handling. All func
On Wed, Sep 16, 2015 at 12:21 PM, Christian König
wrote:
> On 16.09.2015 11:56, Andrzej Hajda wrote:
>>
>> Ping.
>>
>> Regards
>> Andrzej
>>
>> On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
>>>
>>> The patch was generated using fixed coccinelle semantic patch
>>> scripts/coccinelle/api/memdup.cocc
Starting with commit
commit 28cc504e8d52248962f5b485bdc65f539e3fe21d
Author: Rob Clark
Date: Tue Aug 25 15:36:00 2015 -0400
drm/i915: enable atomic fb-helper
I've been seeing some panics on i915 when the DRM master shuts down that appear
to be caused by usi
and you also
mention that in some cases where vendor would left out the HPD conductor,
so I still wish to support those "quirk" screen in the later version.
But I wish
you could share your opinion whether this could exist in the mainline
kernel.
If the answer is no, okay, I would remove this from the next versions.
but If
the answer is yes, wow, I may still can use the DT property to satisfied
this
demand (I guess it's okay to keep the DT property way from previous
discussion).
Thanks,
- Yakir
>
> Thierry
>
>
> ___
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/fe488f9b/attachment-0001.html>
Jyri Sarha wrote:
> On 09/21/15 12:37, Russell King - ARM Linux wrote:
>> ALSA documentation (which may be out of date) says that the hw_params
>> callback can be called multiple times during stream setup. Do we want
>> to be repeatedly programming the HDMI infoframe with different settings,
>> po
he assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/81227cf5/attachment-0001.html>
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/e5d6b13f/attachment.html>
On 17.09.2015 01:18, Russell King - ARM Linux wrote:
> On Wed, Sep 16, 2015 at 02:56:57PM -0700, Doug Anderson wrote:
>> Yes, I'd expect 100kHz and 400kHz.
>>
>> I agree that 50ms is non-trivial, but it's also not something you're
>> doing lots of. I'd expect that the EDID is read over this channe
e(594, 1, , NULL);
glCompileShader(594); # compile error
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/65d45bb4/attachment.html>
On Mon, 21 Sep 2015, Andrzej Hajda wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andr
prepared the v5 version, although those would work directly on
rockchip side, but I could upload some HACK patches to gerrit to make
this works, hope we can keep the discussion going forward.
Thanks,
- Yakir
>
> - Yakir
>
>>
>> Heiko
>>
>> [0] https://github.com/mmind/linux-rockchip/tree/tmp/edp-with-veyron
>>
>>
>>
>>
>
>
>
> ___
> Linux-rockchip mailing list
> Linux-rockchip at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/cb96a9a4/attachment.html>
On 09/21/15 12:31, Russell King - ARM Linux wrote:
> On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote:
>> On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote:
>>> +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |
>>> SNDRV_PCM_FMTBIT_S16_BE |\
>>> +SNDRV_P
The patch simplifies the code without changing behaviour, but most
problably there is a bug somewhere else.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-
nment variable?
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/733de548/attachment.html>
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plan
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/intel_lrc.c | 7 +++
Hi,
This is set of independent patches. The only connection between
them is that they try to address problems spotted by proposed
coccinelle semantic patch unsigned_lesser_than_zero.cocci[1].
Semantic patch finds comparisons of types:
unsigned < 0
unsigned >= 0
The former is always false,
Hi guys,
this assert_drm_connector_list_read_locked() thing fires here when
suspending to disk with Linus' master from around a week ago and
tip/master merged ontop.
After I resume, box comes up but wedges solid. I've managed to capture
that splat in its whole glory too, see the end of this mail.
Hi Joonyoung,
2015-09-16 Joonyoung Shim :
> The beginning of statement in function is next line of a brace.
>
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Gustavo Padovan
Gustav
Hi Joonyoung,
2015-09-16 Joonyoung Shim :
> By if statment, some function callings are written twice. It needs
> several line feed by indentation in if statment. Make to one function
> calling from outside if statment.
>
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm/exynos/exynos_drm
Add the HDMI dai link to support audio for HDMi output
Signed-off-by: Arnaud Pouliquen
---
arch/arm/boot/dts/stih410.dtsi | 4 ++--
arch/arm/boot/dts/stihxxx-b2120.dtsi | 21 +
arch/arm/configs/multi_v7_defconfig | 1 +
3 files changed, 24 insertions(+), 2 deletions(
Add management of the audio bridge
Signed-off-by: Arnaud Pouliquen
---
drivers/gpu/drm/sti/sti_hdmi.c | 146 +
drivers/gpu/drm/sti/sti_hdmi.h | 3 +
2 files changed, 137 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/driver
Add a generic codec to interface audio with DRM drivers
Signed-off-by: Arnaud Pouliquen
---
include/sound/hdmi_drm.h| 16 ++
sound/soc/codecs/Kconfig| 4 ++
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/hdmi_drm.c | 125
4 files
Extend bridge capabilities for audio to enable to connect an audio driver to a
DRM driver with audio capabilities
Signed-off-by: Arnaud Pouliquen
---
drivers/gpu/drm/drm_bridge.c | 114 +++
include/drm/drm_crtc.h | 31
include/linux/hdm
Add helper function to compute CTS and N parameters base on
table described in HDMI specification 1.4b
Signed-off-by: Arnaud Pouliquen
---
drivers/video/hdmi.c | 148 +++
include/linux/hdmi.h | 8 +++
2 files changed, 156 insertions(+)
diff --g
I 'm working on HDMI implementation for sti platform.
As some discussions are on going for audio on HDMI. Here is the begin of my
work...
This patch set is a tentative to implement a generic code for the HDMI audio.
Main concept are aligned with solution proposeded for TI platform.
- ASoC cod
...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/edd05e58/attachment.html>
On Mon, Sep 21, 2015 at 11:51:06AM +0200, Thierry Reding wrote:
> On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote:
> > There's a member in 'struct dw_hdmi' called cable_plugin. It's never
> > set to anything anywhere so thus is always false. There's a bit of code
> > checking it,
; * There's a screen attached for maintainence, but it usually turned
> off.
>
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/ce666361/attachment.html>
d...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/2ca00890/attachment.html>
assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/0019a8ce/attachment.html>
On 09/15/2015 09:45 AM, Sudip Mukherjee wrote:
> On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
>> coverity.com reported that memset was using a buffer of size 0, on
>> checking the code it turned out that the function was not being used. So
>> remove it.
>>
>> Signed-off-by: Su
On Mon, Sep 07, 2015 at 02:45:59PM -0400, Dave Jones wrote:
> On Fri, Sep 04, 2015 at 11:40:53PM +0100, Dave Airlie wrote:
> >
> > Hi Linus,
> >
> > This is the main pull request for the drm for 4.3. Nouveau is probably
> the biggest
> > amount of changes in here, since it missed 4.2
;
> }
>
> drm_connector_helper_add(connector,
> &analogix_dp_connector_helper_funcs);
> drm_connector_register(connector);
> drm_mode_connector_attach_encoder(connector, encoder);
>
> -- analogix_dp-rockchip
>
> ret = drm_connector_init(dp->drm_dev, connector,
> &analogix_dp_connector_funcs,
> DRM_MODE_CONNECTOR_eDP);
> if (ret) {
> DRM_ERROR("Failed to initialize connector with drm\n");
> return ret;
> }
>
> drm_connector_helper_add(connector,
> &analogix_dp_connector_helper_funcs);
> drm_mode_connector_attach_encoder(connector, encoder);
>
>
> Are those code corresponding to your suggestion. :)
Yes, that looks about right. You could also move the implementations
into the Exynos and Rockchip drivers, respectively, if they're only used
from one place. Then you can simply export the low-level analogix_dp_*()
functions. That might give you even more flexibility, but the above
would probably work well enough.
Thierry
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/1b50ec3d/attachment-0001.sig>
On Mon, Sep 21, 2015 at 11:40:15AM +0200, Gerd Hoffmann wrote:
> Add the bits needed for opengl rendering support: query
> capabilities, new virtio commands, drm ioctls.
>
> Signed-off-by: Dave Airlie
> Signed-off-by: Gerd Hoffmann
Looks good to me overall.
Some minor comments below.
I had to
Hi Joonyoung,
2015-09-16 Joonyoung Shim :
> The exynos_drm_gem_init() is used only in exynos_drm_gem.c file. Make it
> static and don't export it.
>
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 +--
> drivers/gpu/drm/exynos/exynos_drm_gem.h | 4
> 2
Hi Joonyoung,
2015-09-16 Joonyoung Shim :
> They will be freed right or was freed already, so NULL assignment is
> unnecessary.
>
> Signed-off-by: Joonyoung Shim
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Gustavo Padovan
Gu
Hi Joonyoung,
2015-09-16 Joonyoung Shim :
> There is no guarantee that DMA addresses are the same as physical
> addresses, but dma_to_pfn() knows how to convert a dma_addr_t to a PFN
> which can then be converted to a struct page.
>
> Suggested-by: Russell King
> Signed-off-by: Joonyoung Shim
HI Joonyoung,
2015-09-16 Joonyoung Shim :
> When obj->import_attach is existed, code calling drm_prime_gem_destroy()
> was removed from commit 67e93c808b48 ("drm/exynos: stop copying sg
> table"), and it's a fault.
>
> The drm_prime_gem_destroy() is cleanup function which GEM drivers need
> to c
part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/1e91d1d6/attachment.sig>
hdmi_tx_hdcp_config(hdmi);
>
> dw_hdmi_clear_overflow(hdmi);
> - if (hdmi->cable_plugin && hdmi->sink_is_hdmi)
> - hdmi_enable_overflow_interrupts(hdmi);
>
> return 0;
> }
> --
> 2.6.0.rc0.131.gf624c3d
>
-- next pa
From: Dave Airlie
Also add DRM_RENDER_ALLOW to the ioctls.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/virtio/vi
From: Dave Airlie
This is enough to enable DRI3.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/Makefile| 2 +-
drivers/gpu/drm/virtio/virtgpu_drv.c | 13 +-
drivers/gpu/drm/virtio/virtgpu_drv.h | 12 ++
drivers/gpu/drm/virtio/virtgpu_p
Add the bits needed for opengl rendering support: query
capabilities, new virtio commands, drm ioctls.
Signed-off-by: Dave Airlie
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/Makefile| 3 +-
drivers/gpu/drm/virtio/virtgpu_drv.c | 10 +
drivers/gpu/drm/virtio/virtgpu_drv.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
b/drivers/gpu/drm/virtio/virtgpu_display.c
index 4e160ef..97e5274 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/
Add helper function to handle the submission of fenced control requests.
Make sure we initialize the fence while holding the virtqueue lock, so
requests can't be reordered.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_fence.c | 2 +-
drivers/gpu/drm/virtio/virtgpu_vq.c| 4
Add virtio_gpu_queue_ctrl_buffer_locked function, which does the same as
virtio_gpu_queue_ctrl_buffer but does not take the virtqueue lock. The
caller must hold the lock instead.
Signed-off-by: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 17 +
1 file changed, 13 inse
er library that should give you enough flexibility to integrate it
into all existing users. For example you could leave out the connector
registration and let the drivers do that. Similarly since the helpers
are only hooked up at registration time you could probably find a way to
share the low-level code but again leave it up to the drivers to glue it
all together at registration time (drivers could wrap the low-level code
with atomic or non-atomic callbacks).
This option may also have the benefit of loosening the coupling between
DRM drivers and the helper code for this IP, which may be handy in case
the drivers diverge again in the future, or ease transitions to new API.
Thierry
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/29eafa21/attachment.sig>
On Fri, Sep 18, 2015 at 02:06:39PM +0300, Jyri Sarha wrote:
> Add IEC958 channel status helper that gets the audio properties from
> snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to
> produce the channel status bits already in audio stream configuration
> phase.
What is the reason f
On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote:
> On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote:
> > +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |
> > SNDRV_PCM_FMTBIT_S16_BE |\
> > +SNDRV_PCM_FMTBIT_S20_3LE | SNDRV_PCM_FMTBIT_S20_3BE |\
> > +
On 09/18/2015 06:06 AM, Jyri Sarha wrote:
> From: Jean-Francois Moine
>
> Two kinds of ports may be declared in a DT graph of ports: video and audio.
> This patch accepts the port value from a video port as an alternative
> to the video-ports property.
> It also accepts audio ports in the case th
--
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/2c2cf636/attachment.sig>
Hi Rob,
thank you for the comments.
Am Freitag, den 18.09.2015, 15:33 -0500 schrieb Rob Herring:
[...]
> > +The display-subsystem node binds together all individual device nodes that
> > +comprise the DISP subsystem.
> > +
> > +Required properties:
> > +
> > +- compatible: "mediatek,-disp"
>
> >
On 09/04/2015 10:15 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Hi,
>
> This series adds proper runtime PM suport to CRTCs and Encoders, so
> now instead of relying on 'suspended' or 'enabled' flags to track when
> the CRTC or Encoder is enabled we let the pm_runtime subsystem do it f
3840x2160 resolution is not
available on either monitor.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150921/a6a2d
67 matches
Mail list logo
