[now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 15:17:08 -0600, Jonathan Corbet wrote: > I went ahead and bisected the problem, which was added between -rc1 and > -rc2. The end result is this: Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which i2c_t

[PATCH 14/14] drm: kill agp indirection mess

2010-08-23 Thread Daniel Vetter
There's no point in jumping through two indirections. So kill one and call the kernels agp functions directly. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_agpsupport.c | 40 +++-- drivers/gpu/drm/drm_memory.c | 12 ++ include/drm/drmP.h

[PATCH 13/14] drm: drop return value of drm_free_agp

2010-08-23 Thread Daniel Vetter
No caller (rightly) cares about it, so drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_memory.c |4 ++-- include/drm/drmP.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 7732

[PATCH 12/14] drm: don't export dri1 locking functions

2010-08-23 Thread Daniel Vetter
Only used by ioctl, not by any in-tree drivers. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c | 10 +++--- include/drm/drmP.h |1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 1973d75

[PATCH 11/14] drm: kill gem_free_object_unlocked driver callback

2010-08-23 Thread Daniel Vetter
Not used by any current driver. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_gem.c |4 +--- include/drm/drmP.h|1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index bf92d07..cff7317 100644 --- a/dri

[PATCH 10/14] drm: kill dev->timer

2010-08-23 Thread Daniel Vetter
Totally unused. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c |2 -- drivers/gpu/drm/drm_stub.c |1 - include/drm/drmP.h |1 - 3 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index a35a410..5ff

[PATCH 09/14] drm: replace drawable ioctl by noops

2010-08-23 Thread Daniel Vetter
The information supplied by userspace through these ioctls is only accessible by dev->drw_idr. But there's no in-tree user of that. Also userspace does not really care about return values of these ioctls, either. Only hw/xfree86/dri/dri.c from the xserver actually checks the return from adddraw and

[PATCH 08/14] drm: don't export drm_get_drawable_info

2010-08-23 Thread Daniel Vetter
Not used by any in-tree user. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drawable.c |3 +-- include/drm/drmP.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drawable.c b/drivers/gpu/drm/drm_drawable.c index c53

[PATCH 07/14] drm: kill context_ctor callback

2010-08-23 Thread Daniel Vetter
It's not used by any driver. The destructor callback is unfortunately used by the via driver in a rather convoluted piece of code used to reimplement something resembling broken futexes. I didn't dare to touch this code. But at least kill the needless NULL assignemt in the sis driver. Signed-off-b

[PATCH 06/14] drm: kill get_reg_ofs callback

2010-08-23 Thread Daniel Vetter
Every driver used the default implementation. Fold that one into the only callsite and drop the callback. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_vm.c |6 ++ drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/i830_drv.c |1 - drivers/

[PATCH 05/14] drm: kill drm_map_ofs callbacks

2010-08-23 Thread Daniel Vetter
All drivers happily copy&pasted the default implementation without checking whether this callback is used at all. It's not. Sigh. Kill it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_vm.c |7 --- drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/

[PATCH 04/14] drm: kill procfs callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver (rightly so!). Kill them. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_proc.c | 13 - include/drm/drmP.h |2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index a

[PATCH 03/14] drm: kill dma_ready callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c |3 --- include/drm/drmP.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 566d203..1973d75 100644 --

[PATCH 02/14] drm: kill kernel_context_switch callbacks

2010-08-23 Thread Daniel Vetter
Not used by any in-kernel driver. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c | 18 -- include/drm/drmP.h |3 --- 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c inde

[PATCH 01/14] drm: don't export drm_sg_alloc

2010-08-23 Thread Daniel Vetter
It's not used internally by any driver, only by some generic ioctls. So don't export it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_scatter.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm/drm_scatter.c index 90

[PATCH 00/14] various drm core cleanups

2010-08-23 Thread Daniel Vetter
Hi all, The following patch-pile contains various cleanups in the drm core. All but patch 12 are resends. I've gone ahead and added the two reviewed-bys that patch 9 scored on the first submission to the patch. Patches apply on top of latest drm-core-next. Tested on my agp rv570 (kms and ums) i94

[patch] i915: signedness bugs in i915 ring buffer

2010-08-23 Thread Dan Carpenter
"ring->space" is unsigned so it's never less than zero. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 51e9c9e..a331898 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbu

[now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Tue, 24 Aug 2010 00:37:52 +0100 Chris Wilson wrote: > drm.debug=0x4 should print the right information for this bug. That doesn't seem to give me any output at all. One thing I noticed, though, is that I occasionally get something like: Aug 23 17:43:14 bike kernel: [ 142.920185] [drm:intel

PROBLEM: oops in nouveau driver in 2.6.36-rc*

2010-08-23 Thread Stephane Casset
Hi, Since 2.6.36-rc1 I have an oops when loading the nouveau driver. The system woks ok expect for the nouveau driver and the console gets corrupted :( I attach relevant informations in attached files : o dmesg output for 2.6.36-rc2-git1 o ksymoops output for the above file If you need more in

[now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Mon, 23 Aug 2010 23:36:55 +0100 Chris Wilson wrote: > Taking the patch at face value, the cause should be a mistake in error > handling. So the first step would be to identify which i2c_transfer() > failed. OK, I tried it, but neither warning triggers. Don't know if it helps or not, but I tr

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28294 Bug 28294 depends on bug 29722, which changed state. Bug 29722 Summary: [glsl] Unigine Sanctuary v2.2 assertion failed https://bugs.freedesktop.org/show_bug.cgi?id=29722 What|Old Value |New Value

[Bug 28294] [r300g] Unigine Sanctuary v2.2: black glitches

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28294 Bug 28294 depends on bug 29722, which changed state. Bug 29722 Summary: [glsl] Unigine Sanctuary v2.2 assertion failed https://bugs.freedesktop.org/show_bug.cgi?id=29722 What|Old Value |New Value

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #5 from Till Matthiesen 2010-08-23 17:17:27 PDT --- All I can tell so far is that it looks like this behaviour was introduced somewhere between 2.6.35-git2 and 2.6.35-git3. As Alexandre said, it is not straight forward to trigger. I

[REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-23 Thread Sitsofe Wheeler
Hi, With 2.6.36-rc2 I see periodic stalls when running with a stock Ubuntu 10.04 userspace. These stalls were not present in 2.6.36-rc1 on an EeePC 900 with an i915. Attempts to bisect the issue are not successful - most kernels in between rc1 and rc2 just make the system come up with a black scr

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #5 from Till Matthiesen 2010-08-23 17:17:27 PDT --- All I can tell so far is that it looks like this behaviour was introduced somewhere between 2.6.35-git2 and 2.6.35-git3. As Alexandre said, it is not straight forward to trigger. I

Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-23 Thread Chris Wilson
On Tue, 24 Aug 2010 00:35:51 +0100, Sitsofe Wheeler wrote: > Hi, > > With 2.6.36-rc2 I see periodic stalls when running with a stock Ubuntu > 10.04 userspace. These stalls were not present in 2.6.36-rc1 on an EeePC > 900 with an i915. >From the error message, I'd suggest we'd tackle hangcheck -

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 17:46:41 -0600, Jonathan Corbet wrote: > On Tue, 24 Aug 2010 00:37:52 +0100 > Chris Wilson wrote: > > > drm.debug=0x4 should print the right information for this bug. > > That doesn't seem to give me any output at all. > > One thing I noticed, though, is that I occasionally

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Tue, 24 Aug 2010 00:37:52 +0100 Chris Wilson wrote: > drm.debug=0x4 should print the right information for this bug. That doesn't seem to give me any output at all. One thing I noticed, though, is that I occasionally get something like: Aug 23 17:43:14 bike kernel: [ 142.920185] [drm:intel

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 17:32:25 -0600, Jonathan Corbet wrote: > On Mon, 23 Aug 2010 23:36:55 +0100 > Chris Wilson wrote: > > > Taking the patch at face value, the cause should be a mistake in error > > handling. So the first step would be to identify which i2c_transfer() > > failed. > > OK, I trie

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #4 from Alexandre 2010-08-23 16:37:19 PDT --- I will try to bisect. It will take a while because I still have not found a consistent a way to trigger the bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=ema

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #4 from Alexandre 2010-08-23 16:37:19 PDT --- I will try to bisect. It will take a while because I still have not found a consistent a way to trigger the bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=ema

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Mon, 23 Aug 2010 23:36:55 +0100 Chris Wilson wrote: > Taking the patch at face value, the cause should be a mistake in error > handling. So the first step would be to identify which i2c_transfer() > failed. OK, I tried it, but neither warning triggers. Don't know if it helps or not, but I tr

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 15:17:08 -0600, Jonathan Corbet wrote: > I went ahead and bisected the problem, which was added between -rc1 and > -rc2. The end result is this: Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which i2c_t

GPU lockup+blackout on 2.6.35 with r600...

2010-08-23 Thread Daniel J Blueman
On 17 August 2010 23:37, Alex Deucher wrote: > On Tue, Aug 17, 2010 at 6:12 PM, Daniel J Blueman > wrote: >> Hi chaps, >> >> On 9 August 2010 14:41, Daniel J Blueman wrote: >>> On 8 August 2010 17:36, Daniel J Blueman >>> wrote: On 5 August 2010 16:23, Alex Deucher wrote: > On Thu, A

[now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Mon, 23 Aug 2010 11:01:45 -0600 Jonathan Corbet wrote: > So I decided to fire up -rc2 today to see what would happen...the > results are best described by the attached images. Something is > clearly scrambled between my hardware and the i915 driver. Display with X > is hosed, but things go w

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Zhenyu Wang
->masks[type].mask; -- 1.7.0.4 -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digita

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Zhenyu Wang
le Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100823/58ed2b4f/attachment.pgp>

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
On Mon, 23 Aug 2010 11:01:45 -0600 Jonathan Corbet wrote: > So I decided to fire up -rc2 today to see what would happen...the > results are best described by the attached images. Something is > clearly scrambled between my hardware and the i915 driver. Display with X > is hosed, but things go w

[PATCH 09/14] drm: replace drawable ioctl by noops

2010-08-23 Thread Daniel Vetter
The information supplied by userspace through these ioctls is only accessible by dev->drw_idr. But there's no in-tree user of that. Also userspace does not really care about return values of these ioctls, either. Only hw/xfree86/dri/dri.c from the xserver actually checks the return from adddraw and

[PATCH 12/14] drm: don't export dri1 locking functions

2010-08-23 Thread Daniel Vetter
Only used by ioctl, not by any in-tree drivers. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c | 10 +++--- include/drm/drmP.h |1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 1973d75

[PATCH 05/14] drm: kill drm_map_ofs callbacks

2010-08-23 Thread Daniel Vetter
All drivers happily copy&pasted the default implementation without checking whether this callback is used at all. It's not. Sigh. Kill it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_vm.c |7 --- drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/

[PATCH 06/14] drm: kill get_reg_ofs callback

2010-08-23 Thread Daniel Vetter
Every driver used the default implementation. Fold that one into the only callsite and drop the callback. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_vm.c |6 ++ drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/i830_drv.c |1 - drivers/

[PATCH 13/14] drm: drop return value of drm_free_agp

2010-08-23 Thread Daniel Vetter
No caller (rightly) cares about it, so drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_memory.c |4 ++-- include/drm/drmP.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c index 7732

[PATCH 08/14] drm: don't export drm_get_drawable_info

2010-08-23 Thread Daniel Vetter
Not used by any in-tree user. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drawable.c |3 +-- include/drm/drmP.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drawable.c b/drivers/gpu/drm/drm_drawable.c index c53

[PATCH 10/14] drm: kill dev->timer

2010-08-23 Thread Daniel Vetter
Totally unused. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c |2 -- drivers/gpu/drm/drm_stub.c |1 - include/drm/drmP.h |1 - 3 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index a35a410..5ff

[PATCH 07/14] drm: kill context_ctor callback

2010-08-23 Thread Daniel Vetter
It's not used by any driver. The destructor callback is unfortunately used by the via driver in a rather convoluted piece of code used to reimplement something resembling broken futexes. I didn't dare to touch this code. But at least kill the needless NULL assignemt in the sis driver. Signed-off-b

[PATCH 11/14] drm: kill gem_free_object_unlocked driver callback

2010-08-23 Thread Daniel Vetter
Not used by any current driver. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_gem.c |4 +--- include/drm/drmP.h|1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index bf92d07..cff7317 100644 --- a/dri

[PATCH 03/14] drm: kill dma_ready callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c |3 --- include/drm/drmP.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 566d203..1973d75 100644 --

[PATCH 00/14] various drm core cleanups

2010-08-23 Thread Daniel Vetter
Hi all, The following patch-pile contains various cleanups in the drm core. All but patch 12 are resends. I've gone ahead and added the two reviewed-bys that patch 9 scored on the first submission to the patch. Patches apply on top of latest drm-core-next. Tested on my agp rv570 (kms and ums) i94

[PATCH 04/14] drm: kill procfs callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver (rightly so!). Kill them. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_proc.c | 13 - include/drm/drmP.h |2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index a

[PATCH 14/14] drm: kill agp indirection mess

2010-08-23 Thread Daniel Vetter
There's no point in jumping through two indirections. So kill one and call the kernels agp functions directly. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_agpsupport.c | 40 +++-- drivers/gpu/drm/drm_memory.c | 12 ++ include/drm/drmP.h

[PATCH 02/14] drm: kill kernel_context_switch callbacks

2010-08-23 Thread Daniel Vetter
Not used by any in-kernel driver. So drop it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_lock.c | 18 -- include/drm/drmP.h |3 --- 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c inde

[PATCH 01/14] drm: don't export drm_sg_alloc

2010-08-23 Thread Daniel Vetter
It's not used internally by any driver, only by some generic ioctls. So don't export it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_scatter.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm/drm_scatter.c index 90

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Zhenyu Wang
A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100823/f0dc7e14/attachment.pgp>

[PATCH] fix i915 compile in 2.6.36-rc2

2010-08-23 Thread Meelis Roos
Commit 6ef3d4278034982c13df87c4a51e0445f762d316 introduces seq_file usage in intel_overlay.c but does not include the header and now compilation fails on i386. Fix it by including the necessary header. Signed-off-by: Meelis Roos diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/

[patch] i915: remove unneed NULL checks

2010-08-23 Thread Dan Carpenter
On Wed, Jun 23, 2010 at 07:06:22PM +0200, Dan Carpenter wrote: > We don't need to check the list cursor in a list_for_each_entry(). It's > always non-null. > Here is another one that never got applied. I has a sad face. :( regards, dan carpenter > Signed-off-by: Dan Carpenter > > diff --gi

[patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Dan Carpenter
On Wed, Jun 23, 2010 at 07:03:01PM +0200, Dan Carpenter wrote: > copy_to_user() returns the number of bytes remaining to be copied and > I'm pretty sure we want to return a negative error code here. > This patch wasn't applied either. regards, dan carpenter > Signed-off-by: Dan Carpenter > >

[patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Dan Carpenter
On Sat, Jun 19, 2010 at 03:12:51PM +0200, Dan Carpenter wrote: > copy_to_user returns the number of bytes remaining to be copied, but we > want to return a negative error code here. These are returned to > userspace. > I didn't get a response on this patch. regards, dan carpenter > Signed-off-

[patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
On Sat, 19 Jun 2010 15:12:51 +0200, Dan Carpenter wrote: > copy_to_user returns the number of bytes remaining to be copied, but we > want to return a negative error code here. These are returned to > userspace. > > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -- Chris Wilson, Intel

[patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
On Wed, 23 Jun 2010 19:03:01 +0200, Dan Carpenter wrote: > copy_to_user() returns the number of bytes remaining to be copied and > I'm pretty sure we want to return a negative error code here. > > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Techno

[PATCH] fix i915 compile in 2.6.36-rc2

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 13:38:27 +0300 (EEST), Meelis Roos wrote: > Commit 6ef3d4278034982c13df87c4a51e0445f762d316 introduces seq_file > usage in intel_overlay.c but does not include the header and now > compilation fails on i386. Fix it by including the necessary header. > > Signed-off-by: Meeli

[Bug 29762] New: [r300g] Coldest: Buffer too small for color buffer 0 (need 3407872 have 2023424) !

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29762 Summary: [r300g] Coldest: Buffer too small for color buffer 0 (need 3407872 have 2023424) ! Product: Mesa Version: git Platform: Other URL: http://www.coldestgame.com/si

[Bug 29762] New: [r300g] Coldest: Buffer too small for color buffer 0 (need 3407872 have 2023424) !

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29762 Summary: [r300g] Coldest: Buffer too small for color buffer 0 (need 3407872 have 2023424) ! Product: Mesa Version: git Platform: Other URL: http://www.coldestgame.com/si

i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Jonathan Corbet
- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- SERR- http://lists.freedesktop.org/archives/dri-devel/attachments/20100823/7d120849/attachment-0002.jpg> -- next part -- A non-text attachment was scrubbed... Name: x.jpg Type: imag

[PATCH] drm/modes: Fix CVT-R modeline generation

2010-08-23 Thread Adam Jackson
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16651 Signed-off-by: Adam Jackson --- drivers/gpu/drm/drm_modes.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index f1f473e..949326d 100644 --- a/drive

2.6.36-rc2 build failure: implicit declaration of function 'seq_printf'

2010-08-23 Thread Sven Joachim
Commit 6ef3d4278034982c13df87c4a51e0445f762d316 causes a build failure for me: , | CC [M] drivers/gpu/drm/i915/intel_overlay.o | drivers/gpu/drm/i915/intel_overlay.c: In function 'intel_overlay_print_error_state': | drivers/gpu/drm/i915/intel_overlay.c:1467: error: implicit declaration of

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Zhenyu Wang
l ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/at

[Bug 29754] [r300g, glsl] Heroes of Newerth lockup GPU

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29754 Pavel Ondračka changed: What|Removed |Added URL||http://www.heroesofnewerth.

[Bug 29754] [r300g, glsl] Heroes of Newerth lockup GPU

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29754 Pavel Ondra?ka changed: What|Removed |Added URL||http://www.heroesofnewerth.

[patch] i915: signedness bugs in i915 ring buffer

2010-08-23 Thread Dan Carpenter
"ring->space" is unsigned so it's never less than zero. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 51e9c9e..a331898 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbu

[Bug 29754] New: [r300g, glsl] Heroes of Newerth lockup GPU

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29754 Summary: [r300g, glsl] Heroes of Newerth lockup GPU Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: me

[Bug 29754] New: [r300g, glsl] Heroes of Newerth lockup GPU

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29754 Summary: [r300g, glsl] Heroes of Newerth lockup GPU Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: me

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #34 from pete...@hottemptation.org 2010-08-23 09:12:16 PDT --- Great! This bug has one good side, I learned much stuff. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #34 from peterle at hottemptation.org 2010-08-23 09:12:16 PDT --- Great! This bug has one good side, I learned much stuff. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #3 from Alex Deucher 2010-08-23 09:00:46 PDT --- can you bisect the kernel to see what commit is causing the problem? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail bec

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #3 from Alex Deucher 2010-08-23 09:00:46 PDT --- can you bisect the kernel to see what commit is causing the problem? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #2 from Alexandre 2010-08-23 08:54:34 PDT --- Same error. It happens with xorg 1.9.0 and older versions but only with 2.6.36-rc1. All versions of 2.6.35 (including 2.6.35.2) work well, I could never generate a bus error. It sometime

[Bug 29738] SIGBUS after upgrade to 2.6.36-rc1-git4 [full stacktrace]

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29738 --- Comment #2 from Alexandre 2010-08-23 08:54:34 PDT --- Same error. It happens with xorg 1.9.0 and older versions but only with 2.6.36-rc1. All versions of 2.6.35 (including 2.6.35.2) work well, I could never generate a bus error. It sometime

drm/radeon/kms: Expose backlight class device for legacy LVDS encoder.

2010-08-23 Thread Michel Dänzer
Allows e.g. power management daemons to control the backlight level. Inspired by the corresponding code in radeonfb. (Updated to add backlight type and make the connector the parent device - mjg) Signed-off-by: Michel D?nzer Signed-off-by: Matthew Garrett --- drivers/gpu/drm/radeon/Kconfig

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Takashi Iwai
At Mon, 23 Aug 2010 14:19:22 +0800, Zhenyu Wang wrote: > > On 2010.08.23 08:02:42 +0200, Takashi Iwai wrote: > > > > Also, I don't understand the logic of 40bit addr calculation: > > > > > static unsigned long intel_gen6_mask_memory(struct agp_bridge_data > > > *bridge, > > >

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Takashi Iwai
At Mon, 23 Aug 2010 08:02:42 +0200, I wrote: > > At Mon, 23 Aug 2010 13:43:03 +0800, > Zhenyu Wang wrote: > > > > On 2010.08.23 07:29:29 +0200, Takashi Iwai wrote: > > > > Sandybridge can do 40-bit dma mask. This has been fixed upstream now. > > > > > > Could you point where is the upstream GIT

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Takashi Iwai
At Mon, 23 Aug 2010 13:43:03 +0800, Zhenyu Wang wrote: > > On 2010.08.23 07:29:29 +0200, Takashi Iwai wrote: > > > Sandybridge can do 40-bit dma mask. This has been fixed upstream now. > > > > Could you point where is the upstream GIT tree and the corresponding > > commit id? > > > > Linus's tr

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Takashi Iwai
At Mon, 23 Aug 2010 09:35:07 +0800, Zhenyu Wang wrote: > > On 2010.08.20 17:36:08 +0200, Takashi Iwai wrote: > > Sandybridge requires 36bit dma mask, but the current code checks only > > against i965, thus it gives Oops with i915 probing on 32bit machine: > > > >nommu_map_sg: overflow 14a

Re: GPU lockup+blackout on 2.6.35 with r600...

2010-08-23 Thread Daniel J Blueman
On 17 August 2010 23:37, Alex Deucher wrote: > On Tue, Aug 17, 2010 at 6:12 PM, Daniel J Blueman > wrote: >> Hi chaps, >> >> On 9 August 2010 14:41, Daniel J Blueman wrote: >>> On 8 August 2010 17:36, Daniel J Blueman wrote: On 5 August 2010 16:23, Alex Deucher wrote: > On Thu, Aug 5,

[PATCH] drm/modes: Fix CVT-R modeline generation

2010-08-23 Thread Adam Jackson
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16651 Signed-off-by: Adam Jackson --- drivers/gpu/drm/drm_modes.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index f1f473e..949326d 100644 --- a/drive

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #33 from Alex Deucher 2010-08-23 07:08:16 PDT --- (In reply to comment #32) > Linus didn't included the patch in rc2. > Typicall delay? The pull request just went out today, so it should show up as soon as Linus pulls it. -- Config

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #33 from Alex Deucher 2010-08-23 07:08:16 PDT --- (In reply to comment #32) > Linus didn't included the patch in rc2. > Typicall delay? The pull request just went out today, so it should show up as soon as Linus pulls it. -- Confi

Re: [PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Eric Anholt
On Mon, 23 Aug 2010 14:48:54 +0800, Zhenyu Wang wrote: > On 2010.08.23 08:31:42 +0200, Takashi Iwai wrote: > > > bit 31 bit 11 bit 4 > > > bit 0 > > >|<-physical addr 31:12->|<-physical addr 39:32->|<-cache ctl > > > 3:1->|valid| > > > >

[PATCH] agp/intel: Fix dma mask for Sandybridge

2010-08-23 Thread Eric Anholt
t available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100823/9cce1ca1/attachment.pgp>

[Bug 29680] [r600g] oolite segfaults on initialization

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29680 Nicolas Kaiser changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 29680] [r600g] oolite segfaults on initialization

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29680 Nicolas Kaiser changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 29363] [r300g] Starcraft 2: "r300 VP: Compiler error"

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29363 --- Comment #16 from Pavel Ondračka 2010-08-23 06:01:16 PDT --- With glsl2 merged into master things are looking much better now, terrain is rendered properly and most of units and buildings too, however there are some effects which are wrong an

[Bug 29363] [r300g] Starcraft 2: "r300 VP: Compiler error"

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29363 --- Comment #16 from Pavel Ondra?ka 2010-08-23 06:01:16 PDT --- With glsl2 merged into master things are looking much better now, terrain is rendered properly and most of units and buildings too, however there are some effects which are wrong an

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #32 from pete...@hottemptation.org 2010-08-23 05:22:51 PDT --- Linus didn't included the patch in rc2. Typicall delay? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail bec

[Bug 29384] Slow switch between TTY1-TTY6 with /dev/fb0 or X11 involved

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29384 --- Comment #32 from peterle at hottemptation.org 2010-08-23 05:22:51 PDT --- Linus didn't included the patch in rc2. Typicall delay? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail

[PATCH] fix i915 compile in 2.6.36-rc2

2010-08-23 Thread Meelis Roos
Commit 6ef3d4278034982c13df87c4a51e0445f762d316 introduces seq_file usage in intel_overlay.c but does not include the header and now compilation fails on i386. Fix it by including the necessary header. Signed-off-by: Meelis Roos diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/

[Bug 29137] [r300g] troubles with wine and "r300: Max size of the constant buffer is 256*4 floats."

2010-08-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29137 --- Comment #16 from Rubén Fernández 2010-08-23 04:43:33 PDT --- If it is of any help, aplyint that wined3d hack makes all the wine applications I have tested render correctly except for two games: One of them still complains about "r300: Max s

[Bug 29137] [r300g] troubles with wine and "r300: Max size of the constant buffer is 256*4 floats."

2010-08-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=29137 --- Comment #16 from Rub?n Fern?ndez 2010-08-23 04:43:33 PDT --- If it is of any help, aplyint that wined3d hack makes all the wine applications I have tested render correctly except for two games: One of them still complains about "r300: Max s

Re: [patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
On Sat, 19 Jun 2010 15:12:51 +0200, Dan Carpenter wrote: > copy_to_user returns the number of bytes remaining to be copied, but we > want to return a negative error code here. These are returned to > userspace. > > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -- Chris Wilson, Intel

Re: [patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
On Wed, 23 Jun 2010 19:03:01 +0200, Dan Carpenter wrote: > copy_to_user() returns the number of bytes remaining to be copied and > I'm pretty sure we want to return a negative error code here. > > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Techno

  1   2   >