Hi Dominik,
Nice to hear that it works and solves the issues. To me it seems this is a
simple oversight which has gone undetected for years because like I
described previously the triggering conditions are rather convoluted. It is
really a corner case issue.
Best regards,
Erik
Den mån 7 okt. 202
Hi Erik,
the decision of the Pi-hole team to apply your patch without the usual
waiting for patches to go into dnsmasq main trunk first is one way to
show that we were (and still are) absolutely convinced about the patch
and consider the likeliness of having to revert it at any point very
low
Hi everyone,
Does anyone have something to say about this patch? I sent it for the first
time about 6 months ago but the discussion quickly died down and it seems
to have been forgotten about since then.
To elaborate a bit about the rationale behind it the issue was discovered
by analyzing core d
On Tue, Oct 01, 2024 at 11:00:24AM +0200, Erik Karlsson wrote:
> From: Erik Karlsson
>
> Not doing so can result in a use after free since the name for DHCP
> derived DNS records is represented as a pointer into the DHCP lease
> table. Update will only happen when necessary since lease_update_dns
From: Erik Karlsson
Not doing so can result in a use after free since the name for DHCP
derived DNS records is represented as a pointer into the DHCP lease
table. Update will only happen when necessary since lease_update_dns
tests internally on dns_dirty and the force argument is zero.
Signed-of
Dear list,
we have added this commit to the currently running Pi-hole v6.0 beta. It
was confirmed by multiple users to fix aforementioned issues.
https://github.com/pi-hole/FTL/pull/1965
Have a great weekend!
Dominik
On 29.04.24 20:44, Erik Karlsson wrote:
From: Erik Karlsson
Not doing so
From: Erik Karlsson
Not doing so can result in a use after free since the name for DHCP
derived DNS records is represented as a pointer into the DHCP lease
table. Update will only happen when necessary since lease_update_dns
tests internally on dns_dirty and the force argument is zero.
Signed-of
On Mon, Apr 29, 2024 at 08:44:13PM +0200, Erik Karlsson wrote:
> From: Erik Karlsson
>
> Not doing so can result in a use after free since the name for DHCP
> derived DNS records is represented as a pointer into the DHCP lease
> table. Update will only happen when necessary since lease_update_dns
From: Erik Karlsson
Not doing so can result in a use after free since the name for DHCP
derived DNS records is represented as a pointer into the DHCP lease
table. Update will only happen when necessary since lease_update_dns
tests internally on dns_dirty and the force argument is zero.
Signed-of
