Re: [dm-devel] [PATCH] dm: rename max_io_len to io_boundary

2019-03-22 Thread John Dorminy
Thank you! I had not encountered that useful function, it does exactly what I want. You're the best! On Fri, Mar 22, 2019 at 9:21 AM Mikulas Patocka wrote: > > > > On Thu, 21 Mar 2019, John Dorminy wrote: > > > I'm thankful for this change making it explicit that this parameter is > > not a max I

Re: [dm-devel] [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static

2019-03-22 Thread Heinz Mauelshagen
On 3/22/19 3:16 PM, Yue Haibing wrote: From: YueHaibing Fix sparse warnings: drivers/md/dm-integrity.c:3619:12: warning: symbol 'dm_integrity_init' was not declared. Should it be static? drivers/md/dm-integrity.c:3638:6: warning: symbol 'dm_integrity_exit' was not declared. Should it be st

[dm-devel] [PATCH -next] dm integrity: Make dm_integrity_init and dm_integrity_exit static

2019-03-22 Thread Yue Haibing
From: YueHaibing Fix sparse warnings: drivers/md/dm-integrity.c:3619:12: warning: symbol 'dm_integrity_init' was not declared. Should it be static? drivers/md/dm-integrity.c:3638:6: warning: symbol 'dm_integrity_exit' was not declared. Should it be static? Signed-off-by: YueHaibing --- driv

Re: [dm-devel] [PATCH 0/3] New approach at handling changed WWIDs

2019-03-22 Thread Benjamin Marzinski
On Fri, Mar 22, 2019 at 12:28:56PM +0100, Martin Wilck wrote: > On Thu, 2019-03-21 at 17:31 -0500, Benjamin Marzinski wrote: > > > > ideally, we would be able to determine whether or not udev was able > > to > > get all the necessary information. It would be nice to be notified if > > scsi_id fail

Re: [dm-devel] [PATCH] dm: rename max_io_len to io_boundary

2019-03-22 Thread Mikulas Patocka
On Thu, 21 Mar 2019, John Dorminy wrote: > I'm thankful for this change making it explicit that this parameter is > not a max IO length but something else. I've been confused by the name > more than once when trying to figure out why IOs weren't coming in as > large as I expected. I wish there

Re: [dm-devel] [PATCH 0/3] New approach at handling changed WWIDs

2019-03-22 Thread Martin Wilck
On Thu, 2019-03-21 at 17:31 -0500, Benjamin Marzinski wrote: > > ideally, we would be able to determine whether or not udev was able > to > get all the necessary information. It would be nice to be notified if > scsi_id failed or udev timed out. The latter (udev timeout) won't work without signif