Re: documentation patch questions

2011-12-09 Thread Russell Keith-Magee
On Fri, Dec 9, 2011 at 2:33 PM, Annie wrote: > Russ: >> Long comments aren't required; you just need to provide something >> that can be answered "OK". > > That makes perfect sense, especially now that I see how it's being > used. *g* (Hadn't gotten to that part of the python unittest docs yet. >

Re: documentation patch questions

2011-12-08 Thread Annie
Russ: > Long comments aren't required; you just need to provide something > that can be answered "OK". That makes perfect sense, especially now that I see how it's being used. *g* (Hadn't gotten to that part of the python unittest docs yet. *g*) I've updated the patch and attached it. Thanks for

Re: documentation patch questions

2011-12-08 Thread Russell Keith-Magee
On Fri, Dec 9, 2011 at 9:58 AM, Annie wrote: > Thanks for the feedback, Russ. :) I've created the ticket and > submitted the patch. It's ticket #17364. Thanks! The patch looks good; the only thing preventing me from marking it ready for checkin is the discussion below about something else you may

Re: documentation patch questions

2011-12-08 Thread Annie
Thanks for the feedback, Russ. :) I've created the ticket and submitted the patch. It's ticket #17364. On Dec 7, 4:44 pm, Russell Keith-Magee wrote: > If you're in the area and aiming for perfection, I'd be inclined > to take a closer look at the test names, too. testSpeaking isn't > an especial

Re: documentation patch questions

2011-12-08 Thread Russell Keith-Magee
On Wed, Dec 7, 2011 at 4:55 PM, Annie wrote: > Hi all - > > I have some questions before I submit a ticket with a patch to change > a few things in the docs/topics/testing.txt file. One change is a typo > fix, and another is a possible change I have a question about. Since > they're both relativel

documentation patch questions

2011-12-07 Thread Annie
Hi all - I have some questions before I submit a ticket with a patch to change a few things in the docs/topics/testing.txt file. One change is a typo fix, and another is a possible change I have a question about. Since they're both relatively minor changes to the same file (no major rewrites requi