Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-28 Thread Aseem Bansal
Anyone interested in reviewing updated code? Now the search functionality is working. I have added comments and a link with screenshots of working functionality. Also refactoring done in the Javascript to make code easier to read. I think the functionality should be clearer by the changed code

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-27 Thread Aseem Bansal
Background? I have some experience(a few months only) with Java 6/Struts 1.2 for web development. Started working on Python May 2013. Not continuously but as a hobby for scripting purposes and some automation. I guess my github and stackoverflow account can give you a better idea https://github

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-27 Thread shmengie
Partials/sub-templates are the same. For a small one pager, includes aren't very useful. As for the logic in using them, that's more difficult to elaborate since it depends a lot on the layout and design of the site. There are a couple of different types of "sub sections" you can implement.

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-26 Thread Aseem Bansal
I am using webbrowser library because this project is supposed to store bookmarks instead of my browser. Storing bookmarks in a app is useful only if there is a way to open them via the app. I was initially serving the bookmarks as hyperlinks but then came across a problem. Web browser's were n

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-26 Thread Andre Terra
Why are you using the webbrowser library? I don't see how it makes sense.. Cheers, AT On Mon, May 26, 2014 at 12:32 PM, Aseem Bansal wrote: > Thanks Shmengie. I was thinking of using class based views as it was > pointed in tutorial that they are better but I was not sure which ones are > goo

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-26 Thread Aseem Bansal
Thanks Shmengie. I was thinking of using class based views as it was pointed in tutorial that they are better but I was not sure which ones are good here. So I decided to prioritize making it work and then go for refactoring. CSS location I will change. The tutorials used include's but I didn'

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-26 Thread shmengie
Looks like you're getting a handle on django. You're not using Class Based Views, but you import generic. Since you're getting familiar with django, you *might* want to hold off on delving into CBVs. They're very powerful and can reduce coding, but can be difficult to wrap your head around.

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-25 Thread Mark Phillips
I took a quick look at your code and my first comment is to add comments to your code. I would like to read in your comments what you are trying to accomplish, and then I can look at the code with a more informed eye. Mark On May 25, 2014 5:59 AM, "Avraham Serour" wrote: > any explanation you th

Re: Anyone interested in reviewing the code of a small project - BookMarker

2014-05-25 Thread Avraham Serour
any explanation you think would be necessary should be documented, either in code comments and/or on the project wiki/readme this is actually a very important part of the project, boring? yes, but this it the first (and maybe only) thing people will look On Sun, May 25, 2014 at 2:20 PM, Aseem Ban