Re: [Discuss-gnuradio] Possible bug in keep_m_in_n and patch

2014-09-25 Thread Tom Rondeau
As was pointed out to me in IRC, we have a webpage describing how to submit patches. See this page: http://gnuradio.org/redmine/projects/gnuradio/wiki/Development#How-do-I-submit-patches But I forgot that you actually submitted a patch in the email, so don't worry about opening an issue on this r

Re: [Discuss-gnuradio] Possible bug in keep_m_in_n and patch

2014-09-25 Thread Tom Rondeau
Zhe, To follow up on Martin's point. First, yes, please either use the Issue tracker or submit a patch/pull request via git and github. Also, just pointing out a bug is one thing, but it's also much easier for us to test and verify if you provide us with an example file. That having been said, y

Re: [Discuss-gnuradio] Possible bug in keep_m_in_n and patch

2014-09-24 Thread Martin Braun
No comment on the patch, but in general, it helps us a lot if you do this via github & pull request. M On 24.09.2014 12:21, Zhe Feng wrote: Dear all, I checked the keep_m_in_n block and found a possible bug in it. In the work function, the code wrote: consume_each(d_n); return d_m; which I

[Discuss-gnuradio] Possible bug in keep_m_in_n and patch

2014-09-24 Thread Zhe Feng
Dear all, I checked the keep_m_in_n block and found a possible bug in it. In the work function, the code wrote: consume_each(d_n); return d_m; which I think it should be consume_each(blks*d_n); return blks*d_m. while blks=std::min(noutput_items/d_m, ninput_items[0]/d_n). Since both m and n of