Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-07 Thread Tony van der Peet
The test is basic.OutputExact in oftest, which is on GitHub at: https://github.com/floodlight/oftest/blob/master/tests-1.3/basic.py Yes, it does have a barrier between adding the flow and verifying packets, so your idea would seem to be not only a total fix, but also the most elegant way to do it

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-05 Thread Ben Pfaff
On Fri, Jun 05, 2015 at 07:02:13PM +1200, Tony van der Peet wrote: > Turns out that the only behaviour change is a slight timing change. If I > put a 0.2s sleep into the outer loop of the test I can make is pass > reliably. In other words, the flows are still being deleted correctly, it's > just th

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-05 Thread Alex Wang
Glad to hear you figured it out, Curious about: 1. Do you need to do flow remove in the loop after the "for in_port..." loop in you test? 2. Where in the outer loop do you add the sleep.? Thanks, Alex Wang, On Fri, Jun 5, 2015 at 12:02 AM, Tony van der Peet < tony.vanderp...@gmail.com> wrote:

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-05 Thread Tony van der Peet
Alex Turns out that the only behaviour change is a slight timing change. If I put a 0.2s sleep into the outer loop of the test I can make is pass reliably. In other words, the flows are still being deleted correctly, it's just that the test is so quick in changing the flows and expecting to be abl

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-04 Thread Tony van der Peet
More on my day's debugging: my previous comment was a bit premature, and a bit confusing. To clarify: - dpif flows are not being deleted in time when the basic.OutputExact test runs on our most recent code - dpif flows are being deleted in time on last year's code (based on my previous upgrade fro

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-04 Thread Tony van der Peet
Alex and group This is a repeat of my earlier reply, sent also to the list (sorry about dropping the list). Plus some information about my day's debugging. Tony On Thu, Jun 4, 2015 at 6:05 PM, Alex Wang wrote: > Hey, > > Few questions, > > 1. how do you change the flow to output to port 2? us

Re: [ovs-discuss] Behaviour change in OpenVSwitch

2015-06-03 Thread Alex Wang
Hey, Few questions, 1. how do you change the flow to output to port 2? using ovs-ofctl mod-flows? Could you show the exact commands? 2. There was a commit (b2a4692 ofproto: Increase default datapath max_idle time.) that increased the max_idle time of dpif flows. That may be related. Thanks,

[ovs-discuss] Behaviour change in OpenVSwitch

2015-06-03 Thread Tony van der Peet
I use OpenVSwitch and occasionally upgrade from the tip of master. My previous upgrade was in Sep/2014, and I have just upgraded to last Friday's tip. A number of previously running test cases (using oftest) now fail for me, and I am investigating. The v1.3 test basic.OutputExact creates a flow ou