Re: [Devel] fuse: call proper fiemap_prep as it is required by new kernel api

2023-10-16 Thread Andrey Zaitsev
ok for me From: Denis V. Lunev Sent: Sunday, October 15, 2023 10:08:40 PM To: Alexey Kuznetsov; Devel; khore...@virtuozzo.com; Andrey Zaitsev; Kui Liu Subject: Re: fuse: call proper fiemap_prep as it is required by new kernel api On 10/13/23 20:35, Alexey Kuznets

Re: [Devel] fuse: call proper fiemap_prep as it is required by new kernel api

2023-10-16 Thread Kui Liu
Found 2 issues: 1. It’s better to move fiemap_prep() before inode_lock, as it was the case before when same thing is done in ioctl_fiemap(). 2. FIEMAP_FLAG_SYNC as the last parameter is unnecessary, because it is always checked in fiemap_prep(). From: Andrey Zaitsev Date: Monday, 16 Octo

Re: [Devel] fuse: call proper fiemap_prep as it is required by new kernel api

2023-10-16 Thread Alexey Kuznetsov
Hello! > 1. It’s better to move fiemap_prep() before inode_lock, as it was the case > before when same thing is done in ioctl_fiemap(). It is intentional. It was like a bug in older kernels that we flushed dirty pages outside of locks so that we could came to fiemap with new dirty pages. Not t

Re: [Devel] fuse: call proper fiemap_prep as it is required by new kernel api

2023-10-16 Thread Kui Liu
Then ok for me. -Original Message- From: Alexey Kuznetsov mailto:kuz...@virtuozzo.com>> Date: Monday, 16 October 2023 at 6:34 PM To: Kui Liu mailto:kui@acronis.com>> Cc: Devel mailto:devel@openvz.org>>, Andrey Zaitsev mailto:andrey.zait...@acronis.com>>, "Denis V. Lunev" mailto:d..