Hello! > 1. It’s better to move fiemap_prep() before inode_lock, as it was the case > before when same thing is done in ioctl_fiemap().
It is intentional. It was like a bug in older kernels that we flushed dirty pages outside of locks so that we could came to fiemap with new dirty pages. Not that it is of any importance, as user calling write() and fiemap() in parallel deemed to get bogus results. BTW generally flush should be called twice. The first time - out of mutex, to make bulk work out of mutex, and then under mutex to collect bits dirtied while the fist pass. But in this case as we flush only area which is subject of fiemap, the first pass is mostly useless. > FIEMAP_FLAG_SYNC as the last parameter is unnecessary, because it is always > checked in fiemap_prep(). It is noop but IMHO not redundant as states intention and improves readability w/o necessity to look into actual function to figure out why this flag is not marked as "supported". On Mon, Oct 16, 2023 at 6:17 PM Kui Liu <kui....@acronis.com> wrote: > > Found 2 issues: > > It’s better to move fiemap_prep() before inode_lock, as it was the case > before when same thing is done in ioctl_fiemap(). > FIEMAP_FLAG_SYNC as the last parameter is unnecessary, because it is always > checked in fiemap_prep(). > > > > From: Andrey Zaitsev <andrey.zait...@acronis.com> > Date: Monday, 16 October 2023 at 5:23 PM > To: "Denis V. Lunev" <d...@virtuozzo.com>, Alexey Kuznetsov > <kuz...@virtuozzo.com>, Devel <devel@openvz.org>, "khore...@virtuozzo.com" > <khore...@virtuozzo.com>, Kui Liu <kui....@acronis.com> > Subject: Re: fuse: call proper fiemap_prep as it is required by new kernel api > > > > ok for me > > ________________________________ > > From: Denis V. Lunev <d...@virtuozzo.com> > Sent: Sunday, October 15, 2023 10:08:40 PM > To: Alexey Kuznetsov; Devel; khore...@virtuozzo.com; Andrey Zaitsev; Kui Liu > Subject: Re: fuse: call proper fiemap_prep as it is required by new kernel api > > > > On 10/13/23 20:35, Alexey Kuznetsov wrote: > > Otherwise we consider locations with dirty page cache as holes. > > > > Affects: #VSTOR-76073, #PSBM-151414, #PSBM-151424, #PSBM-151464 > > > > Signed-off-by: Alexey Kuznetsov <kuz...@acronis.com> > > --- > > fs/fuse/file.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > > index 5e23bd5..c685e01 100644 > > --- a/fs/fuse/file.c > > +++ b/fs/fuse/file.c > > @@ -3711,6 +3711,10 @@ int fuse_fiemap(struct inode *inode, struct > > fiemap_extent_info *fieinfo, > > > > inode_lock(inode); > > > > + err = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC); > > + if (err) > > + goto out; > > + > > fuse_sync_writes(inode); > > fuse_read_dio_wait(fi); > > > Can we get acknowledgement for this patch in order to > start merge/build ASAP? > > Thanks you in advance, > Den _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
